summaryrefslogtreecommitdiff
path: root/indra/newview/llaudiosourcevo.h
diff options
context:
space:
mode:
authorVadim Savchuk <vsavchuk@productengine.com>2010-09-21 19:11:40 +0300
committerVadim Savchuk <vsavchuk@productengine.com>2010-09-21 19:11:40 +0300
commit5b2d4a169830c10dd5bfc4c72ddd94ef80e658d3 (patch)
tree781b636c27126019ab9f6a005495f51af9434094 /indra/newview/llaudiosourcevo.h
parent5304ad274636a07b764264cb6797c72705629fc3 (diff)
STORM-163 FIXED Intermittent FPS drop related to "audio" (main thread hangs often on openal lock)
Submitting a patch made by Aleric Inglewood (See VWR-14914). This bug happens for a lot of people, although it might be needed to have a fast multi core machine. I have seen it on 1.22.10 once, never used 1.23 sorry, and saw it often on snowglobe. I am sure it also affects 1.23 but I'd have to test that. The symptons are that on a viewer with normally a good, high FPS, sometimes it happens that the FPS dramatically drops (as low as 0.3, but it can also be anything higher, as high as 10, say). This particular jira is about a problem where the main thread is slowed down by a mutex lock in libopenal (most calls starting with 'al' in indra/llaudio/audioengine_openal.cpp and one in indra/llaudio/listener_openal.cpp). You can see that this is the case by opening the Frame Console (control-shift-2) and checking that the "audio" (and possibly misc) timings are very large compared to the Render time.
Diffstat (limited to 'indra/newview/llaudiosourcevo.h')
-rw-r--r--indra/newview/llaudiosourcevo.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/indra/newview/llaudiosourcevo.h b/indra/newview/llaudiosourcevo.h
index a68f58a4b2..f1d8ef4528 100644
--- a/indra/newview/llaudiosourcevo.h
+++ b/indra/newview/llaudiosourcevo.h
@@ -42,11 +42,10 @@ public:
/*virtual*/ void setGain(const F32 gain);
private:
- void updateGain();
+ void updateMute();
private:
LLPointer<LLViewerObject> mObjectp;
- F32 mActualGain; // The "real" gain, when not off due to parcel effects
};
#endif // LL_LLAUDIOSOURCEVO_H