summaryrefslogtreecommitdiff
path: root/indra/newview
AgeCommit message (Collapse)Author
2023-10-02DRTVWR-589: Add initial integration test for LLLUAmanager.Nat Goodspeed
The first test runs a Lua script that calls post_on(), listen_events() and await_event() to engage in LLEventPump handshakes with the test program. Make llluamanager.cpp testable by putting LL_TEST conditionals around lots of viewer-internals headers and the lua_function definitions that engage them. Since LuaListener::connect() is called by its constructor, make it a static method that explicitly accepts the lua_State* (instead of finding it as mState). Add that parameter to its two existing calls. Add a debug log message when LuaListener is destroyed. This surfaced the need to pass a no-op deleter when listen_events() constructs a LuaListener::ptr_t. When compiled for LL_TEST, make LuaListener::mReplyPump an LLEventLogProxyFor<LLEventStream> instead of a plain LLEventStream. For debugging purposes, add a type string "LLEventLogProxy" for LLEventPumps::make(). A make() call with this type will return an LLEventLogProxyFor<LLEventStream>.
2023-09-30DRTVWR-589: Emulate print() better, show output on Lua floater.Nat Goodspeed
Break out a lua_print_msg() function common to print_debug(), print_info() and print_warning(). Instead of accepting a single argument, lua_print_msg() accepts arbitrary arguments, passing each to the Lua tostring() function and concatenating the results. In addition to returning the combined string to its caller for level-appropriate logging, it also posts the message to a "lua output" LLEventPump for any interested party. Make LLFloaterLUADebug listen on "lua output" when the floater is constructed, storing the connection in an LLTempBoundListener to stop listening when the floater is destroyed. Append each message to the floater's output panel with a line break. Make LLTextEditor::addLineBreakChar() public. insertText("\n") only appends a little rectangle glyph. Enlarge the text capacity of the floater's output panel to be able to report whatever messages a Lua script wants to print. Add diagnostic logging for posting events from Lua, and receiving events to forward to Lua. Since lua_pop() is a macro implemented on lua_settop(), replace the awkward construct lua_pop(L, lua_gettop(L)) with lua_settop(L, 0). Use lambdas instead of std::bind() to connect LuaListener and LLLeapListener.
2023-09-28DRTVWR-589 - support for moving to destMnikolenko Productengine
2023-09-28DRTVWR-589: Call lua_pushstdstring() correctly.Nat Goodspeed
2023-09-28DRTVWR-589: Merge remote branch 'DRTVWR-589' into DRTVWR-589Nat Goodspeed
2023-09-28DRTVWR-589: Rename post_on_pump() to post_on()Nat Goodspeed
Sprinkle lua_checkstack() calls into functions that push to the Lua stack -- particularly important when traversing nested data structures of unknown depth! Tweak lua_pushllsd() handling of LLSD arrays.
2023-09-28DRTVWR-589: Add Lua-callable await_event() function.Nat Goodspeed
This suspends the calling Lua coroutine (and C++ coroutine on which the Lua state is running) until an event is received on the named LLEventPump. Returns the event. Pass optional timeout in seconds as a second argument. With no timeout, waits indefinitely. Pass optional timeout discriminator return value as a third argument (default nil).
2023-09-28DRTVWR-589: Try to override Lua's built-in print() with print_info()Nat Goodspeed
so Lua print() output will go to the viewer log, instead of getting discarded and possibly causing failures when the buffer fills and there's no open stdout file handle. Also name each Lua C++ coroutine with the description we give the LuaState instance.
2023-09-28DRTVWR-589 - support for rezing primsMnikolenko Productengine
2023-09-27DRTVWR-589: Always check regtype to avoid unref errorNat Goodspeed
2023-09-27DRTVWR-589: Use std::placeholders::_1, etc., for std::bind()Nat Goodspeed
2023-09-27DRTVWR-589: Fix compile errors in 354585d.Nat Goodspeed
2023-09-27DRTVWR-589: Add Lua-callable listen_events() function.Nat Goodspeed
Add LuaListener, based on LLLeap. LuaListener has an int key so the second and subsequent calls to listen_events() can find a previously-created one. LuaListener listens on its LLEventPump and arranges to call the specified Lua callback with any incoming event. It also instantiates an LLLeapListener. listen_events() locates the main thread for its state: we only want to call callbacks on the Lua chunk's main thread, not on a (possibly suspended) coroutine. It finds or creates a LuaListener and stashes it in the main thread's registry, along with the passed Lua callback function. Finally it returns the names of the LuaListener's reply pump and the LLLeapListener's command pump. Add LuaState RAII class to manage the lifespan of each lua_State we create. This encapsulates much of the boilerplate common to runScriptFile() and runScriptLine(). In addition, LuaState's destructor checks for a LuaListener key and, if found, destroys the referenced LuaListener. LuaState's constructor requires a description to clarify log messages. Move the checkLua() free function to a member of LuaState. This allows capturing an error message to pass to the C++ completion callback, if any. Use LuaState in runScriptFile() and runScriptLine(), synthesizing a suitable description in each case. Add print_debug() and print_info() logging calls, analogous to print_warning(). Add luaL_where() prefix to every such message. Add lua_pushstdstring(), like lua_tostdstring(): convenience for working with the pointer and length used by lua_pushlstring() and lua_tolstring(). Clean up return values of lua_functions. A lua_CFunction returns the number of return values it has pushed, so any 'void' lua_CFunction should pop its arguments and return 0.
2023-09-26DRTVWR-589: Fix typo due to old documentation.Nat Goodspeed
The function formerly known as luaL_typerror() is now luaL_typeerror().
2023-09-26DRTVWR-589: Collect int table keys in vector<int>, not set<int>.Nat Goodspeed
Given that we at least have a possibility of determining the length of a Lua table in advance, we might be able to populate a vector of keys with a single initial allocation. Even if Lua reports the length incorrectly, vector::push_back() is one of the bread-and-butter operations of the library, optimized to the extent possible. Inserting elements into a set seems more likely to incur allocations. Of course, we must then sort() the vector to determine its largest key value. Also document the requirement that we use a Lua runtime compiled for C++, that is, compiled to raise errors by C++ exceptions rather than by longjmp(). We rely on temporary stack objects being properly destroyed even if errors are raised. Conventionally, with lua_tomumble(L, index), 'index' refers to the stack index of the Lua object being converted to C++. For a Lua table, talk about table keys rather than table indexes to avoid confusing the maintainer.
2023-09-25DRTVWR-589: Fix Lua table to LLSD array conversion.Nat Goodspeed
The previous implementation assumed that the Lua length function would correctly report the number of entries in a table, and that traversing a table with integer keys would produce them in numeric order. Neither assumption is true. Instead, make a preliminary pass to validate and collect indexes, and to discover the highest integer index. Armed with that, we can construct a contiguous LLSD array of correct size, and populate it with a second pass. Also add Lua-callable post_on_pump(pumpname, datablob) function.
2023-09-22DRTVWR-589: Introduce LuaFunction: simplified function registration.Nat Goodspeed
2023-09-22DRTVWR-589: Existing lua_pushmumble() functions usually return void.Nat Goodspeed
2023-09-22DRTVWR-589: lua_objlen() removed, use lua_rawlen() insteadNat Goodspeed
2023-09-21DRTVWR-589: lua_objlen() only defined in luaconf.hNat Goodspeed
2023-09-21DRTVWR-589: Merge branch 'DRTVWR-589-llsd' into DRTVWR-589Nat Goodspeed
It seems TC only builds specific v-p branches, e.g. DRTVWR-589 but not DRTVWR-589-llsd.
2023-09-21DRTVWR-589: Add lua_tollsd() and lua_pushllsd() functions.Nat Goodspeed
2023-09-21DRTVWR-589 - allow adding branch to the menuMnikolenko Productengine
2023-09-21DRTVWR-589 - adding menu items to the top menuMnikolenko Productengine
2023-09-20DRTVWR-589 - added play animation and started to collect demo scriptsBrad Payne (Vir Linden)
2023-09-19Merge branch 'DRTVWR-589' of github.com:/secondlife/viewer-private into ↵Brad Payne (Vir Linden)
DRTVWR-589
2023-09-19DRTVWR-589 - click_child, limited support for pushing buttons in a floaterBrad Payne (Vir Linden)
2023-09-19lua support for notificationsMnikolenko Productengine
2023-09-18DRTVWR-589 - close_floater by nameBrad Payne (Vir Linden)
2023-09-15DRTVWR-589 - lua file browser added run button to allow re-running same scriptBrad Payne (Vir Linden)
2023-09-14DRTVWR-589 - lua support parameter to UI commandsBrad Payne (Vir Linden)
2023-09-14Merge branch 'DRTVWR-589' of github.com:/secondlife/viewer-private into ↵Brad Payne (Vir Linden)
DRTVWR-589
2023-09-14DRTVWR-589 - LUA support for UI commands, only if no parametersBrad Payne (Vir Linden)
2023-09-13autorun selected script after loginMnikolenko Productengine
2023-09-08allow to take snapshot; bind more funcs to call from luaMnikolenko Productengine
2023-09-06addcallback to display error msgMnikolenko Productengine
2023-09-05Initial prototype of embedded LUAMnikolenko Productengine
2023-08-23Increment viewer version to 6.6.15Vir Linden
following promotion of DRTVWR-582
2023-07-20SL-19948 Update estate manager and ban list limits to match new values from ↵Andrey Lihatskiy
simulator
2023-07-18Fixes for compatibility with new xcode 15 beta for any viewer branch after ↵Brad Linden
DRTVWR-577 (#232)
2023-07-18SL-19891 Make sure focusable elements clear focus on destructionAndrey Kleshchev
2023-07-17Merge pull request #285 from secondlife/marchcat/SL-19669marchcat-pe
INTL-490 Japanese Translation Update
2023-07-17Merge branch 'DRTVWR-580-maint-T' into DRTVWR-582-maint-UAndrey Lihatskiy
2023-07-17Merge branch 'main' into DRTVWR-582-maint-UAndrey Lihatskiy
# Conflicts: # doc/contributions.txt # indra/llcommon/llerrorthread.cpp
2023-07-17Increment viewer version to 6.6.14Nat Goodspeed
following promotion of DRTVWR-580
2023-07-12SL-19702 don't skip double clicks when clicking scripted objectsMnikolenko Productengine
2023-07-11SL-19728 Objects that cannot be clicked or cammed unless in edit modeAlexander Gavriliuk
2023-07-07SL-19702 restore previous double clicking behavior for objectsMaxim Nikolenko
2023-07-05Reverted changes to installer_template.msi introduced by PR #259Andrey Kleshchev
Changes do not appear to add anything sans mac's line ending which triggers coding policy protection and shouldn't be present in window's installer file.
2023-06-28DRTVWR-582: Merge branch DRTVWR-582-maint-U into contribute-frozenNat Goodspeed
to resolve conflicts in installer_template.nsi