Age | Commit message (Collapse) | Author | |
---|---|---|---|
2016-09-15 | MAINT-5232: Normalize LLSingleton subclasses. | Nat Goodspeed | |
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead. | |||
2015-11-10 | remove execute permission from many files that should not have it | Oz Linden | |
2014-01-31 | fix some flaws for memory corruption | Xiaohong Bao | |
2014-01-09 | fix for SH-4659:crash at LLOcclusionCullingGroup::doOcclusion line 1150 | Xiaohong Bao | |
2014-01-06 | fix for SH-4656: crash at LLVOCacheEntry::updateParentBoundingInfo() line 510 | Xiaohong Bao | |
2013-12-03 | SH-4606 FIX Interesting: Small objects do not load until they are very close. | Richard Linden | |
changed culling to use inverse distance to calculate solid angle, not distance squared | |||
2013-12-03 | SH-4606 FIX Interesting: Small objects do not load until they are very close. | Richard Linden | |
increased SceneLoadMinRadius to 32 changes logic so that falloff starts at SceneLoadMinRadius added timing to pixel threshold calculation | |||
2013-11-14 | fix for SH-4609: Interesting: Occluded objects are loaded at login | Xiaohong Bao | |
2013-11-13 | fix for SH-4608: Interesting: minimap shows objects loading/uinloading ↵ | Xiaohong Bao | |
behind your camera when camera is rotated | |||
2013-11-13 | more fix for SH-4607: Create new object cache tuning parameters | Xiaohong Bao | |
2013-11-11 | fix for SH-4607: Create new object cache tuning parameters | Xiaohong Bao | |
2013-11-06 | remove some unused debug settings. | Xiaohong Bao | |
2013-11-06 | re-organize the code of processing the debug setting ↵ | Xiaohong Bao | |
"ObjectProjectionAreaCutOff" | |||
2013-10-30 | more fix to reduce number of rendered triangles per frame. | Xiaohong Bao | |
2013-10-30 | fix for SH-4584: Interesting: objectprojectionAreaCutOFF hides large objects ↵ | Xiaohong Bao | |
on adjacent regions. | |||
2013-10-18 | stop other cameras than the world camera to asscee object cache. | Xiaohong Bao | |
2013-10-17 | fix for SH-4569: Objects are not culled by size in the distance | Xiaohong Bao | |
2013-10-16 | more fix for SH-4552: Interesting: objects sometimes fail to load after ↵ | Xiaohong Bao | |
teleport. | |||
2013-10-07 | renamed TraceType to StatType | Richard Linden | |
added more MemTrackable types optimized memory usage of LLTrace some more | |||
2013-10-03 | add a debug setting: "BackShpereCullingRadius" | Xiaohong Bao | |
2013-10-02 | more for SH-4521: Interesting viewer crash in Pipeline:RenderDrawPools | Xiaohong Bao | |
2013-09-26 | more optimization for memory footprint. | Xiaohong Bao | |
2013-09-25 | better memory usage for LLTrace (tighter packing of recording arrays) | Richard Linden | |
removed complicated and unnecessary fast timer gapless handoff logic (it should be gapless anyway) improved MemTrackable API, better separation of shadow and footprint added memory usage stats to floater_stats.xml | |||
2013-09-20 | more fix for SH-4501: Interesting: Occluded objects do not appear when ↵ | Xiaohong Bao | |
Occluder object is deleted. | |||
2013-09-20 | fix for SH-4430: Interesting: Light objects behind you are not loaded at login. | Xiaohong Bao | |
2013-09-19 | fix for SH-4501: Interesting: Occluded objects do not appear when Occluder ↵ | Xiaohong Bao | |
object is deleted. | |||
2013-09-05 | changed fast timer over to using macro | Richard Linden | |
another attempt to move mem stat into base class | |||
2013-08-29 | add some debug settings for easier tuning up performance. | Xiaohong Bao | |
2013-08-28 | fix for SH-4332: Cacheable object highlights from Render Metadata -> Update ↵ | Xiaohong Bao | |
Type do not render | |||
2013-08-22 | fix for SH-4400: Interesting: Side effect 1 of unloading culled objects. | Xiaohong Bao | |
2013-08-21 | fix some objects not rendered when login process is very long | Xiaohong Bao | |
2013-08-08 | fix for SH-4402: interesting: lower FPS with lots of objects in view | Xiaohong Bao | |
2013-08-07 | more fix for SH-4397: Object cache occlusion culling results are not always ↵ | Xiaohong Bao | |
correct | |||
2013-08-06 | fix for SH-4398: Interesting: viewer crash in ↵ | Xiaohong Bao | |
LLVOCacheEntry::updateParentBoundingInfo | |||
2013-08-05 | fix for SH-4397: Object cache occlusion culling results are not always correct | Xiaohong Bao | |
2013-07-29 | fix for SH-4293: texture console takes a while to settle down on Interesting ↵ | Xiaohong Bao | |
viewer. | |||
2013-07-02 | Automated merge with http://bitbucket.org/lindenlab/viewer-interesting | Xiaohong Bao | |
2013-07-02 | fix for SH-4264: interesting: Content near edges of screen does not load | Xiaohong Bao | |
2013-07-01 | BUILDFIX: reverted changes that attempted to automate mem track | Richard Linden | |
stat definition as they don't work on gcc/clang | |||
2013-07-01 | SH-4294 FIX Interesting: Statistics Texture cache hit rate is always 0% | Richard Linden | |
also, removed LLTrace::init and cleanup removed derived class implementation of memory stat for LLMemTrackable is automatic now | |||
2013-06-26 | more fix for SH-4284: interesting: viewer does not render cacheable objects ↵ | Xiaohong Bao | |
on far corner of region when camera moves | |||
2013-06-24 | fix for SH-4284: interesting: viewer does not render cacheable objects on ↵ | Xiaohong Bao | |
far corner of region when camera moves | |||
2013-06-17 | add a debug setting "InvisibleObjectsInMemoryTime" to adjust the time ↵ | Xiaohong Bao | |
invisible objects stay in memory. | |||
2013-06-05 | merge with viewer-release | Richard Linden | |
2013-05-28 | change the way to handle creating/destroying a same object repeatedly | Xiaohong Bao | |
2013-05-20 | BUILDFIX: mac gcc fix | Richard Linden | |
2013-05-05 | Spring cleaning: removed unused .cpp and.h files, and cleaned up header ↵ | Richard Linden | |
dependencies | |||
2013-04-17 | for SH-4105: interesting: new viewer does not handle orphaned child prims in ↵ | Xiaohong Bao | |
ObjectUpdateCompressed messages | |||
2013-04-11 | add LLTrace::MemTrackable to LLVOCachePartition | Xiaohong Bao | |
2013-03-29 | delay removing invalid objects from cache in case region is logged out too soon. | Xiaohong Bao | |