Age | Commit message (Collapse) | Author | |
---|---|---|---|
2012-10-10 | Introduce new LLDir::findSkinnedFilenames() method. Use as needed. | Nat Goodspeed | |
In a number of different places, for different reasons, the viewer wants to load a UI-related file that might be overridden by a non-default skin; and within that skin, might further be overridden by a non-default language. Apparently, for each of those use cases, every individual developer approached it as an entirely new problem, solving it idiosyncratically for that one case. Not only is this a maintenance problem, but it rubs one's nose in the fact that most such solutions consider only a subset of the relevant skin directories. Richard and I evolved an API intended to address all such cases: a central LLDir method returning a list of relevant pathnames, from most general to most localized, filtered to present only existing files; plus a couple of convenience methods to specifically obtain the most general and most localized available file. There were several load-skinned-file methods (LLFloater::buildFromFile(), LLPanel::buildFromFile() and LLUICtrlFactory::createFromFile() -- apparently cloned-and-modified from each other) that contained funky bolted-on logic to output the loaded data to an optional passed LLXMLNodePtr param. The trouble is that passing that param forced each of these methods to subvert its normal search: specifically for that case, it needed to find the baseline XML file instead of the localized one. Richard agreed that for the intended usage (reformatting XML files) we should use XML schema instead, and that the hacky functionality should be removed. Remove it. Also remove LLUICtrlFactory::getLocalizedXMLNode(), only used for those three special cases. Some callers explicitly passed the optional LLXMLNodePtr param as NULL. Remove that. Remove LLFloaterUIPreview::displayFloater(save) param, which relied on the optional output LLXMLNodePtr param. Make onClickSaveFloater() and onClickSaveAll() emit popupAndPrintWarning() about discontinued functionality. Recast LLFloater::buildFromFile(), LLPanel::buildFromFile(), LLUICtrlFactory::createFromFile(), LLNotifications::loadTemplates(), LLUI::locateSkin(), LLFontRegistry::parseFontInfo(), LLUIColorTable::loadFromSettings(), LLUICtrlFactory::loadWidgetTemplate(), LLUICtrlFactory::getLayeredXMLNode(), LLUIImageList::initFromFile(), LLAppViewer::launchUpdater() and LLMediaCtrl::navigateToLocalPage() to use findSkinnedFilenames(). (Is LLAppViewer::launchUpdater() ever called any more? Apparently so -- though the linux-updater.bin logic to process the relevant command-line switch has been disabled. Shrug.) (Is LLMediaCtrl::navigateToLocalPage() ever used?? If so, why?) Remove LLUI::setupPaths(), getXUIPaths(), getSkinPath() and getLocalizedSkinPath(). Remove the skins/paths.xml file read by setupPaths(). The only configuration it contained was the pair of partial paths "xui/en" and "xui/[LANGUAGE]" -- hardly likely to change. getSkinPath() specifically returned the first of these, while getLocalizedSkinPath() specifically returned the second. This knowledge is now embedded in findSkinnedFilenames(). Also remove paths.xml from viewer_manifest.py. Remove injected xui_paths from LLFontGL::initClass() and LLFontRegistry::LLFontRegistry(). These are no longer needed since LLFontRegistry can now directly consult LLDir for its path search. Stop passing LLUI::getXUIPaths() to LLFontGL::initClass() in LLViewerWindow's constructor and initFonts() method. Add LLDir::append() and add() methods for the simple task of combining two path components separated by getDirDelimiter() -- but only if they're both non-empty. Amazing how often that logic is replicated. Replace some existing concatenations with add() or append(). New LLDir::findSkinnedFilenames() method must know current language. Allow injecting current language by adding an LLDir::setSkinFolder(language) param, and pass it where LLAppViewer::init() and initConfiguration() currently call setSkinFolder(). Also add LLDir::getSkinFolder() and getLanguage() methods. Change LLFLoaterUIPreview's LLLocalizationResetForcer helper to "forcibly reset language" using LLDir::setSkinFolder() instead of LLUI::setupPaths(). Update LLDir stubs in lldir_stub.cpp and llupdaterservice_test.cpp. Add LLDir::getUserDefaultSkinDir() to obtain often-overlooked possible skin directory -- like getUserSkinDir() but with "default" in place of the current skin name as the last path component. (However, we hope findSkinnedFilenames() obviates most explicit use of such individual skin directory pathnames.) Add LLDir unit tests for new findSkinnedFilenames() and add() methods -- the latter exercises append() as well. Tweak indra/integration_tests/llui_libtest/llui_libtest.cpp for all the above. Notably, comment out its export_test_floaters() function, since the essential LLFloater::buildFromFile(optional LLXMLNodePtr) functionality has been removed. This may mean that llui_libtest.cpp has little remaining value, not sure. | |||
2012-08-13 | PATH-849: CRASHFIX This should fix the crash caused by ↵ | Todd Stinson | |
LLPathfindingObject::handleAvatarNameFetch being called after the corresponding LLPathfindingObject has been deleted. | |||
2012-07-23 | Pull and merge from ssh://hg@bitbucket.org/lindenlab/viewer-release. | Todd Stinson | |
2012-06-22 | Pull and merge from ssh://hg@bitbucket.org/lindenlab/viewer-release. | Todd Stinson | |
2012-06-22 | merge | Dave Parks | |
2012-06-21 | merge changes for DRTVWR-168 | Oz Linden | |
2012-06-21 | merge changes for DRTVWR-171 | Oz Linden | |
2012-06-19 | STORM-1887 FIXED Added words are not saved in dictionaries if main ↵ | Kitty Barnett | |
dictionary was reselected The user's custom dictionary and ignore list are now independent of the primary dictionary. | |||
2012-06-12 | EXP-1953: Altering the behavior of building an LLTextBase such that icons ↵ | Todd Stinson | |
are appended in place rather than prepended out of context. | |||
2012-06-11 | merge spelling changes for UI review | Oz Linden | |
2012-06-11 | STORM-276 Added the ability to remove (user-installed) dictionaries | Kitty Barnett | |
2012-06-11 | STORM-276 Distinguish between default dictionaries and user-installed ↵ | Kitty Barnett | |
dictionaries | |||
2012-06-11 | STORM-276 Insert braces around if/for/while loops | Kitty Barnett | |
2012-06-04 | merge dictionary import | Oz Linden | |
2012-06-04 | STORM-276 Dictionary import functionality and floater | Kitty Barnett | |
2012-06-01 | merge latest fixes from Kitty | Oz Linden | |
2012-05-31 | STORM-276 FIXED Last word in a line editor isn't spell checked | Kitty Barnett | |
2012-05-31 | merge changes for storm-276 | Oz Linden | |
2012-05-31 | STORM-276 FIXED Line editor misspells are checked every frame | Kitty Barnett | |
2012-05-31 | STORM-276 FIXED "Add to Ignore" doesn't trigger | Kitty Barnett | |
2012-05-30 | Merged with viewer-release | Kitty Barnett | |
2012-05-30 | merge up to 3.3.2-release | Oz Linden | |
2012-05-25 | Pull and merge from ssh://hg@bitbucket.org/lindenlab/viewer-release. | Todd Stinson | |
2012-05-25 | Merge pull from lindenlab/viewer-development as requested by Oz for DRTVWR-148 | simon@Simon-PC.lindenlab.com | |
2012-05-24 | merge changes for DRTVWR-151 | Oz Linden | |
2012-05-22 | merge changes for DRTVWR-152 | Oz Linden | |
2012-05-22 | merge changes for DRTVWR-149 | Oz Linden | |
2012-05-20 | Merged with viewer-beta | Kitty Barnett | |
2012-05-18 | MAINT-959 FIX [PUBLIC]Trouble resizing tabbed floaters | Richard Linden | |
don't auto position other floater when it is hosted | |||
2012-05-18 | MAINT-938 ADDITIONAL FIX (Make debit-permissions dialog give a stronger warning) | Paul ProductEngine | |
- Requested permissions are added dynamically to the dialog's footer - And the footer is not shown when it is empty | |||
2012-05-17 | MAINT-938 FIXED (Make debit-permissions dialog give a stronger warning) | Paul ProductEngine | |
- Added new tag called "footer" to the notification. This tag allows to display messages under the buttons in toasts. - Created new class LLToastScriptQuestion for the "ScriptQuestionCaution" notification. This notification supports tag <footer>. | |||
2012-05-15 | STORM-276 FIXED Right-to-left line editor selection becomes invisible if the ↵ | Kitty Barnett | |
cursor moves | |||
2012-05-15 | STORM-276 FIXED Squiggles overflow line editor height when font size is set ↵ | Kitty Barnett | |
to large - Also reduced squiggle width from 6 to 4 and prevented running past the end of a word | |||
2012-05-11 | rename feature from "autocorrect" to "autoreplace", change names accordingly | Oz Linden | |
2012-05-09 | Automated merge with http://hg.secondlife.com/viewer-release | Nat Goodspeed | |
2012-05-08 | merge changes for version 3.3.1 | Oz Linden | |
2012-05-02 | merge viewer-release to drano | Brad Payne (Vir Linden) | |
2012-04-27 | PATH-585: Adding an initial notification for when a server-side automatic ↵ | Todd Stinson | |
unfreeze occurs. | |||
2012-04-26 | Automated merge with http://hg.secondlife.com/viewer-release | Nat Goodspeed | |
2012-04-25 | Pull and merge from ssh://hg@bitbucket.org/lindenlab/viewer-release. | Todd Stinson | |
2012-04-20 | merge changes for latest viewer-development | Oz Linden | |
2012-04-17 | DRTVWR-139: merge back 3.3.1-beta2 fixes | Oz Linden | |
2012-04-14 | Touched a file to fix the TC build. | Seth ProductEngine | |
2012-04-03 | Pull and merge from ssh://hg@bitbucket.org/lindenlab/viewer-development. | Todd Stinson | |
2012-03-30 | merge changes for vmrg-233 | Oz Linden | |
2012-03-28 | MAINT-405 FIXED ([PUBLIC]Ctrl W does not properly close IM tabs using tabbed ↵ | Paul ProductEngine | |
IM in 2.x/3.x) - Now tabs are closed with Ctrl+W as expected | |||
2012-03-23 | CHUI-70 FIX Build floater and other floaters opened in default position ↵ | Richard Linden | |
become centered in viewer when object is built or viewer resized always initialize mPosition | |||
2012-03-23 | Automated merge with ssh://hg.lindenlab.com/richard/viewer-experience | Richard Linden | |
2012-03-21 | CHUI-61 FIX Relative floater positions not written to settings file if ↵ | Richard Linden | |
previous settings exist from old viewer | |||
2012-03-21 | CHUI-61 FIX Relative floater positions not written to settings file if ↵ | Richard Linden | |
previous settings exist from old viewer |