| Age | Commit message (Collapse) | Author |
|---|
|
|
|
accessed through the static LLThread::tldata().
Currently this object contains two (public) thread-local
objects: a LLAPRRootPool and a LLVolatileAPRPool.
The first is the general memory pool used by this thread
(and this thread alone), while the second is intended
for short lived memory allocations (needed for APR).
The advantages of not mixing those two is that the latter
is used most frequently, and as a result of it's nature
can be destroyed and reconstructed on a "regular" basis.
This patch adds LLAPRPool (completely replacing the old one),
which is a wrapper around apr_pool_t* and has complete
thread-safity checking.
Whenever an apr call requires memory for some resource,
a memory pool in the form of an LLAPRPool object can
be created with the same life-time as this resource;
assuring clean up of the memory no sooner, but also
not much later than the life-time of the resource
that needs the memory.
Many, many function calls and constructors had the
pool parameter simply removed (it is no longer the
concern of the developer, if you don't write code
that actually does an libapr call then you are no
longer bothered with memory pools at all).
However, I kept the notion of short-lived and
long-lived allocations alive (see my remark in
the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356
which requires that the LLAPRFile API needs
to allow the user to specify how long they
think a file will stay open. By choosing
'short_lived' as default for the constructor
that immediately opens a file, the number of
instances where this needs to be specified is
drastically reduced however (obviously, any
automatic LLAPRFile is short lived).
***
Addressed Boroondas remarks in https://codereview.secondlife.com/r/99/
regarding (doxygen) comments. This patch effectively only changes comments.
Includes some 'merge' stuff that ended up in llvocache.cpp
(while starting as a bug fix, now only resulting in a cleanup).
***
Added comment 'The use of apr_pool_t is OK here'.
Added this comment on every line where apr_pool_t
is correctly being used.
This should make it easier to spot (future) errors
where someone started to use apr_pool_t; you can
just grep all sources for 'apr_pool_t' and immediately
see where it's being used while LLAPRPool should
have been used.
Note that merging this patch is very easy:
If there are no other uses of apr_pool_t in the code
(one grep) and it compiles, then it will work.
***
Second Merge (needed to remove 'delete mCreationMutex'
from LLImageDecodeThread::~LLImageDecodeThread).
***
Added back #include <apr_pools.h>.
Apparently that is needed on libapr version 1.2.8.,
the version used by Linden Lab, for calls to
apr_queue_*. This is a bug in libapr (we also
include <apr_queue.h>, that is fixed in (at least) 1.3.7.
Note that 1.2.8 is VERY old. Even 1.3.x is old.
***
License fixes (GPL -> LGPL). And typo in comments.
Addresses merov's comments on the review board.
***
Added Merov's compile fixes for windows.
|
|
Turns out that most of my SNOW-800 patch was included in Viewer 2 (albeit without crediting me).
However, not everything was used and some more cleaning up was possible.
After this patch, and when compiling with optimization, there are no duplicates left
anymore that shouldn't be there in the first place. Apart from the debug stream
iostream guard variable, there are several static variables with the same name (r, r1,
r2, etc) but that indeed actually different symbol objects. Then there are a few
constant POD arrays that are duplicated a hand full of times because they are
accessed with a variable index (so optimizing them away is not possible). I left them
like that (although defining those as extern as well would have been more consistent
and not slower; in fact it would be faster theoretically because those arrays could
share the same cache page then).
|
|
|
|
|
|
|
|
Speculative bunch of robustification.
Reviewed by Soft.
|
|
feeeeling.
|
|
|
|
|
|
|
|
Animation and Sound Actions.
Also changed hardcoded "until animations are done" value for Wait with label from the appropriate Floater checkbox.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/762/
--HG--
branch : product-engine
|
|
|
|
steep hill
|
|
Added a third visual param group VISUAL_PARAM_GROUP_TWEAKABLE_NO_TRANSMIT
to specify visual params that are user-tweakable, but should not be sent
over the network.
We should have this group *only* for new user-tweakable visual parameters
that should not be sent over the network. These should only be used for
*new* parameters that only contribute to the generation of baked textures.
Code reviewed by Richard
|
|
See subtasks for complete lists of fixes. The preview gesture floater had some major issues and regressions.
|
|
so much
also, made camera default target and offset live-settable for debugging
reviewed by vir
|
|
to be reviewed by nyx.
|
|
reviewed by Nyx.
|
|
|
|
Cleanup and log spam reduction.
|
|
|
|
Diagnostic info.
|
|
New versions of animations fix looping and other problems, reduced log spam.
|
|
|
|
|
|
|
|
|
|
|
|
reviewed by monroe
|
|
Restored the call to updateMotions(LLCharacter::HIDDEN_UPDATE) in LLVOAvatar::updateCharacter().
Added a specific fast timer for hidden updates in LLCharacter::updateMotions() to assess how much this will impact performance.
Reviewed by Richard.
|
|
Checker: FORWARD_NULL
Function: LLEditingMotion::onUpdate(float, unsigned char *)
File: /indra/llcharacter/lleditingmotion.cpp
minor.
|
|
Checker: UNINIT_CTOR
Function: LLJoint::LLJoint(const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&, LLJoint*)
File: /indra/llcharacter/lljoint.cpp
|
|
Checker: UNINIT_CTOR
Function: LLStateDiagram::LLStateDiagram()
File: /indra/llcharacter/llstatemachine.cpp
|
|
Checker: UNINIT_CTOR
Function: LLStateMachine::LLStateMachine()
File: /indra/llcharacter/llstatemachine.cpp
|
|
|
|
Checker: UNINIT_CTOR
Function: LLKeyframeWalkMotion::LLKeyframeWalkMotion(const LLUUID &)
File: /indra/llcharacter/llkeyframewalkmotion.cpp
|
|
Checker: UNINIT_CTOR
Function: Translation::Translation()
File: /indra/llcharacter/llbvhloader.h
|
|
and reduce unnecessary dependencies and incredibuild wedging. Hopefully in
the long run this will reduce build time. Also cleaned up a lot of header
file usage to conform better to the coding standard.
reviewed by james and steve.
|
|
removed ambiguous parameter "set_by_user" from many places in codebase,
renaming it to be upload_bake, which is a more accurate descriptor.
This allowed me to see several inconsistencies in how this variable was
being set - these errors were also fixed. User-visible result should be
that baked textures are not reuploaded on changing avatar sex until the
save button is pressed. primary win here is code clarity.
Code reviewed by Bigpapi.
|
|
|
|
|
|
Several fixes here:
1) minor rename in argument of setIsDummy
2) corrected parameter set_by_user to calls of setVisualParamWeight where we
shouldn't be animating
3) ensured finally that mIsDummy is set properly for all wearable parameters
4) ensured that mIsDUmmy is set properly for non-wearable based parameters on
your own avatar
Code reviewed by Bigpapi
|
|
First round of fixes for trying to fix the visual param animations
Code reviewed by Seraph
|
|
|
|
No expected functionality change; this mostly contains cosmetic cleanup.
Reviewed by: Nyx
|
|
|
|
Found a couple bugs in the code relating to cross-wearable visual param linking.
Fixed with this patch - cross-wearable and inter-wearable visual params should
now link properly for both wearable-owned and avatar-owned parameters.
Code reviewed by Seraph
|
|
|
|
|
