diff options
Diffstat (limited to 'indra/test')
| -rw-r--r-- | indra/test/CMakeLists.txt | 4 | ||||
| -rw-r--r-- | indra/test/io.cpp | 8 | ||||
| -rw-r--r-- | indra/test/llpermissions_tut.cpp | 10 | ||||
| -rw-r--r-- | indra/test/llsaleinfo_tut.cpp | 5 | ||||
| -rw-r--r-- | indra/test/llstreamtools_tut.cpp | 53 | ||||
| -rw-r--r-- | indra/test/lltemplatemessagebuilder_tut.cpp | 3 | 
6 files changed, 41 insertions, 42 deletions
| diff --git a/indra/test/CMakeLists.txt b/indra/test/CMakeLists.txt index 816f1d7175..31e1d89c68 100644 --- a/indra/test/CMakeLists.txt +++ b/indra/test/CMakeLists.txt @@ -28,6 +28,10 @@ include_directories(      ${GOOGLEMOCK_INCLUDE_DIRS}      ${TUT_INCLUDE_DIR}      ) +include_directories(SYSTEM +    ${LLCOMMON_SYSTEM_INCLUDE_DIRS} +    ${LLXML_SYSTEM_INCLUDE_DIRS} +    )  set(test_SOURCE_FILES      io.cpp diff --git a/indra/test/io.cpp b/indra/test/io.cpp index 7f26ac6724..62e516accb 100644 --- a/indra/test/io.cpp +++ b/indra/test/io.cpp @@ -1140,7 +1140,7 @@ namespace tut  		bool connected = client->blockingConnect(server_host);  		ensure("Connected to server", connected);  		lldebugs << "connected" << llendl; -		F32 elapsed = pump_loop(mPump,0.1f); +		pump_loop(mPump,0.1f);  		(void)elapsed;  		count = mPump->runningChains();  		ensure_equals("server chain onboard", count, 2); @@ -1157,20 +1157,20 @@ namespace tut  		chain.clear();  		// pump for a bit and make sure all 3 chains are running -		elapsed = pump_loop(mPump,0.1f); +		pump_loop(mPump,0.1f);  		count = mPump->runningChains();  		ensure_equals("client chain onboard", count, 3);  		lldebugs << "** request should have been sent." << llendl;  		// pump for long enough the the client socket closes, and the  		// server socket should not be closed yet. -		elapsed = pump_loop(mPump,0.2f); +		pump_loop(mPump,0.2f);  		count = mPump->runningChains();  		ensure_equals("client chain timed out ", count, 2);  		lldebugs << "** client chain should be closed." << llendl;  		// At this point, the socket should be closed by the timeout -		elapsed = pump_loop(mPump,1.0f); +		pump_loop(mPump,1.0f);  		count = mPump->runningChains();  		ensure_equals("accepted socked close", count, 1);  		lldebugs << "** Sleeper should have timed out.." << llendl; diff --git a/indra/test/llpermissions_tut.cpp b/indra/test/llpermissions_tut.cpp index bf6766424c..bc2c87ba46 100644 --- a/indra/test/llpermissions_tut.cpp +++ b/indra/test/llpermissions_tut.cpp @@ -407,7 +407,7 @@ namespace tut  		LLFILE* fp = LLFile::fopen("linden_file.dat","w+");  		if(!fp)  		{ -			llerrs << "file coudnt be opened\n" << llendl; +			llerrs << "file couldn't be opened\n" << llendl;  			return;  		}  		LLPermissions perm,perm1; @@ -425,15 +425,15 @@ namespace tut  		perm.initMasks(base, ownerp, everyone, groupp, next); -		perm.exportFile(fp); +		ensure("Permissions export failed", perm.exportFile(fp));  		fclose(fp);	  		fp = LLFile::fopen("linden_file.dat","r+");  		if(!fp)  		{ -			llerrs << "file coudnt be opened\n" << llendl; +			llerrs << "file couldn't be opened\n" << llendl;  			return;  		} -		perm1.importFile(fp); +		ensure("Permissions import failed", perm1.importFile(fp));  		fclose(fp);  		ensure_equals("exportFile()/importFile():failed to export and import the data ", perm1, perm);	  } @@ -461,7 +461,7 @@ namespace tut  		std::istringstream istream(ostream.str());  		perm1.importLegacyStream(istream); -		ensure_equals("exportLegacyStream()/importLegacyStream():failed to export and import the data ", perm1, perm); +		ensure_equals("exportStream()/importStream():failed to export and import the data ", perm1, perm);  	}  	template<> template<> diff --git a/indra/test/llsaleinfo_tut.cpp b/indra/test/llsaleinfo_tut.cpp index 09fca2abba..2689eaa15e 100644 --- a/indra/test/llsaleinfo_tut.cpp +++ b/indra/test/llsaleinfo_tut.cpp @@ -154,8 +154,9 @@ namespace tut  		BOOL has_perm_mask = FALSE;  		llsaleinfo1.importLegacyStream(istream, has_perm_mask, perm_mask); -		ensure("importLegacyStream() fn failed ", llsaleinfo.getSalePrice() == llsaleinfo1.getSalePrice() && -										       llsaleinfo.getSaleType() == llsaleinfo1.getSaleType());		 +		ensure("importStream() fn failed ", +			llsaleinfo.getSalePrice() == llsaleinfo1.getSalePrice() && +			llsaleinfo.getSaleType() == llsaleinfo1.getSaleType());  	}  	template<> template<> diff --git a/indra/test/llstreamtools_tut.cpp b/indra/test/llstreamtools_tut.cpp index 68e56b5ee2..a9bb15d911 100644 --- a/indra/test/llstreamtools_tut.cpp +++ b/indra/test/llstreamtools_tut.cpp @@ -385,17 +385,16 @@ namespace tut  		std::string expected_result;  		std::string actual_result;  		std::istringstream is; -		bool ret;  		is.clear();  		is.str(str = "  First Second \t \r  \n Third  Fourth-ShouldThisBePartOfFourth  Fifth\n");  		actual_result = ""; -		ret = get_word(actual_result, is); // First +		get_word(actual_result, is); // First  		(void)ret;  		actual_result = ""; -		ret = get_word(actual_result, is); // Second +		get_word(actual_result, is); // Second  		(void)ret;  		actual_result = ""; -		ret = get_word(actual_result, is); // Third +		get_word(actual_result, is); // Third  		(void)ret;  		// the current implementation of get_word seems inconsistent with @@ -405,22 +404,22 @@ namespace tut  		// carriage  return ('\r'), horizontal tab ('\t'), and vertical tab ('\v')  		// as delimiters   		actual_result = ""; -		ret = get_word(actual_result, is); // will copy Fourth-ShouldThisBePartOfFourth +		get_word(actual_result, is); // will copy Fourth-ShouldThisBePartOfFourth  		actual_result = ""; -		ret = get_word(actual_result, is); // will copy Fifth +		get_word(actual_result, is); // will copy Fifth  		is.clear();  		is.str(str = "  First Second \t \r  \n Third  Fourth_ShouldThisBePartOfFourth Fifth\n"); -		ret = skip_to_next_word(is);  // should now point to First -		ret = skip_to_next_word(is);  // should now point to Second -		ret = skip_to_next_word(is);  // should now point to Third -		ret = skip_to_next_word(is);  // should now point to Fourth -		ret = skip_to_next_word(is);  // should now point to ShouldThisBePartOfFourth +		skip_to_next_word(is);  // should now point to First +		skip_to_next_word(is);  // should now point to Second +		skip_to_next_word(is);  // should now point to Third +		skip_to_next_word(is);  // should now point to Fourth +		skip_to_next_word(is);  // should now point to ShouldThisBePartOfFourth  		expected_result = "";  		// will copy ShouldThisBePartOfFourth, the fifth word,   		// while using get_word above five times result in getting "Fifth" -		ret = get_word(expected_result, is);  +		get_word(expected_result, is);   		ensure_equals("get_word: skip_to_next_word compatibility", actual_result, expected_result);  	} @@ -482,40 +481,39 @@ namespace tut  		std::string expected_result;  		std::string actual_result;  		std::istringstream is; -		bool ret;  		is.clear();  		is.str(str = "First Second \t \r\n Third  Fourth-ShouldThisBePartOfFourth  IsThisFifth\n");  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		(void)ret;  		expected_result = "First Second \t \r\n";  		ensure_equals("get_line: 1", actual_result, expected_result);  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		expected_result = " Third  Fourth-ShouldThisBePartOfFourth  IsThisFifth\n";  		ensure_equals("get_line: 2", actual_result, expected_result);  		is.clear();  		is.str(str = "\nFirst Line.\n\nSecond Line.\n");  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		expected_result = "\n";  		ensure_equals("get_line: First char as newline", actual_result, expected_result);  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		expected_result = "First Line.\n";  		ensure_equals("get_line: 3", actual_result, expected_result);  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		expected_result = "\n";  		ensure_equals("get_line: 4", actual_result, expected_result);  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		expected_result = "Second Line.\n";  		ensure_equals("get_line: 5", actual_result, expected_result);  	}	 @@ -547,13 +545,12 @@ namespace tut  		std::string expected_result;  		std::string actual_result;  		std::istringstream is; -		bool ret;  		// need to be check if this test case is wrong or the implementation is wrong.  		is.clear();  		is.str(str = "Should not skip lone \r.\r\n");  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		(void)ret;  		expected_result = "Should not skip lone \r.\r\n";  		ensure_equals("get_line: carriage return skipped even though not followed by newline", actual_result, expected_result); @@ -567,12 +564,11 @@ namespace tut  		std::string expected_result;  		std::string actual_result;  		std::istringstream is; -		bool ret;  		is.clear();  		is.str(str = "\n");  		actual_result = ""; -		ret = get_line(actual_result, is); +		get_line(actual_result, is);  		(void)ret;  		expected_result = "\n";  		ensure_equals("get_line: Just newline", actual_result, expected_result); @@ -587,37 +583,36 @@ namespace tut  		std::string expected_result;  		std::string actual_result;  		std::istringstream is; -		bool ret;  		is.clear();  		is.str(str = "First Line.\nSecond Line.\n");  		actual_result = ""; -		ret = get_line(actual_result, is, 255); +		get_line(actual_result, is, 255);  		(void)ret;  		expected_result = "First Line.\n";  		ensure_equals("get_line: Basic Operation", actual_result, expected_result);  		actual_result = ""; -		ret = get_line(actual_result, is, sizeof("Second")-1); +		get_line(actual_result, is, sizeof("Second")-1);  		expected_result = "Second\n";  		ensure_equals("get_line: Insufficient length 1", actual_result, expected_result);  		actual_result = ""; -		ret = get_line(actual_result, is, 255); +		get_line(actual_result, is, 255);  		expected_result = " Line.\n";  		ensure_equals("get_line: Remainder after earlier insufficient length", actual_result, expected_result);  		is.clear();  		is.str(str = "One Line only with no newline with limited length");  		actual_result = ""; -		ret = get_line(actual_result, is, sizeof("One Line only with no newline with limited length")-1); +		get_line(actual_result, is, sizeof("One Line only with no newline with limited length")-1);  		expected_result = "One Line only with no newline with limited length\n";  		ensure_equals("get_line: No newline with limited length", actual_result, expected_result);  		is.clear();  		is.str(str = "One Line only with no newline");  		actual_result = ""; -		ret = get_line(actual_result, is, 255); +		get_line(actual_result, is, 255);  		expected_result = "One Line only with no newline";  		ensure_equals("get_line: No newline", actual_result, expected_result);  	} diff --git a/indra/test/lltemplatemessagebuilder_tut.cpp b/indra/test/lltemplatemessagebuilder_tut.cpp index 0aad3cbc15..3d3edab102 100644 --- a/indra/test/lltemplatemessagebuilder_tut.cpp +++ b/indra/test/lltemplatemessagebuilder_tut.cpp @@ -937,7 +937,7 @@ namespace tut  		// build message with single block  		LLMessageTemplate messageTemplate = defaultTemplate();  		messageTemplate.addBlock(defaultBlock(MVT_U32, 4, MBT_SINGLE)); -		U32 outValue, outValue2, inValue = 0xbbbbbbbb; +		U32 outValue, inValue = 0xbbbbbbbb;  		LLTemplateMessageBuilder* builder = defaultBuilder(messageTemplate);  		builder->addU32(_PREHASH_Test0, inValue);  		const U32 bufferSize = 1024; @@ -963,7 +963,6 @@ namespace tut  		memset(buffer, 0xcc, bufferSize);  		reader->getString(_PREHASH_Test1, _PREHASH_Test0, bufferSize,   						  outBuffer); -		outValue2 = reader->getNumberOfBlocks(_PREHASH_Test1);  		(void)outValue2;  		ensure_equals("Ensure present value ", outValue, inValue);  		ensure_equals("Ensure unchanged buffer ", strlen(outBuffer), 0); | 
