summaryrefslogtreecommitdiff
path: root/indra/llxml/llxmlnode.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'indra/llxml/llxmlnode.cpp')
-rw-r--r--indra/llxml/llxmlnode.cpp7
1 files changed, 4 insertions, 3 deletions
diff --git a/indra/llxml/llxmlnode.cpp b/indra/llxml/llxmlnode.cpp
index 48805f8240..16860ab8b8 100644
--- a/indra/llxml/llxmlnode.cpp
+++ b/indra/llxml/llxmlnode.cpp
@@ -309,6 +309,7 @@ void LLXMLNode::addChild(LLXMLNodePtr& new_child)
// virtual
LLXMLNodePtr LLXMLNode::createChild(const char* name, bool is_attribute)
{
+ // Todo: validate to make sure node name is valid? (no spaces, etc)
return createChild(gStringTable.addStringEntry(name), is_attribute);
}
@@ -1284,7 +1285,7 @@ bool LLXMLNode::getAttributeU8(const char* name, U8& value )
bool LLXMLNode::getAttributeS8(const char* name, S8& value )
{
LLXMLNodePtr node;
- S32 val;
+ S32 val{};
if (!(getAttribute(name, node) && node->getIntValue(1, &val)))
{
return false;
@@ -1296,7 +1297,7 @@ bool LLXMLNode::getAttributeS8(const char* name, S8& value )
bool LLXMLNode::getAttributeU16(const char* name, U16& value )
{
LLXMLNodePtr node;
- U32 val;
+ U32 val{};
if (!(getAttribute(name, node) && node->getUnsignedValue(1, &val)))
{
return false;
@@ -1308,7 +1309,7 @@ bool LLXMLNode::getAttributeU16(const char* name, U16& value )
bool LLXMLNode::getAttributeS16(const char* name, S16& value )
{
LLXMLNodePtr node;
- S32 val;
+ S32 val{};
if (!(getAttribute(name, node) && node->getIntValue(1, &val)))
{
return false;