diff options
Diffstat (limited to 'indra/llrender')
| -rw-r--r-- | indra/llrender/llfontbitmapcache.cpp | 4 | ||||
| -rw-r--r-- | indra/llrender/llfontfreetype.h | 1 | ||||
| -rw-r--r-- | indra/llrender/llfontgl.cpp | 22 | ||||
| -rw-r--r-- | indra/llrender/llfontgl.h | 2 | ||||
| -rw-r--r-- | indra/llrender/llfontvertexbuffer.cpp | 6 | ||||
| -rw-r--r-- | indra/llrender/llfontvertexbuffer.h | 5 | ||||
| -rw-r--r-- | indra/llrender/llglslshader.h | 1 | ||||
| -rw-r--r-- | indra/llrender/llshadermgr.cpp | 9 | ||||
| -rw-r--r-- | indra/llrender/llshadermgr.h | 3 | 
9 files changed, 49 insertions, 4 deletions
| diff --git a/indra/llrender/llfontbitmapcache.cpp b/indra/llrender/llfontbitmapcache.cpp index ee9cfd0719..83f5d31186 100644 --- a/indra/llrender/llfontbitmapcache.cpp +++ b/indra/llrender/llfontbitmapcache.cpp @@ -107,7 +107,7 @@ bool LLFontBitmapCache::nextOpenPos(S32 width, S32& pos_x, S32& pos_y, EFontGlyp              mBitmapHeight = image_height;              S32 num_components = getNumComponents(bitmap_type); -            mImageRawVec[bitmap_idx].push_back(new LLImageRaw(mBitmapWidth, mBitmapHeight, num_components)); +            mImageRawVec[bitmap_idx].emplace_back(new LLImageRaw(mBitmapWidth, mBitmapHeight, num_components));              bitmap_num = static_cast<U32>(mImageRawVec[bitmap_idx].size()) - 1;              LLImageRaw* image_raw = getImageRaw(bitmap_type, bitmap_num); @@ -117,7 +117,7 @@ bool LLFontBitmapCache::nextOpenPos(S32 width, S32& pos_x, S32& pos_y, EFontGlyp              }              // Make corresponding GL image. -            mImageGLVec[bitmap_idx].push_back(new LLImageGL(image_raw, false, false)); +            mImageGLVec[bitmap_idx].emplace_back(new LLImageGL(image_raw, false, false));              LLImageGL* image_gl = getImageGL(bitmap_type, bitmap_num);              // Start at beginning of the new image. diff --git a/indra/llrender/llfontfreetype.h b/indra/llrender/llfontfreetype.h index 1ad795060a..a2d925c5f6 100644 --- a/indra/llrender/llfontfreetype.h +++ b/indra/llrender/llfontfreetype.h @@ -148,6 +148,7 @@ public:      void setStyle(U8 style);      U8 getStyle() const; +    S32 getAddedGlyphs() const { return mAddGlyphCount; }  private:      void resetBitmapCache(); diff --git a/indra/llrender/llfontgl.cpp b/indra/llrender/llfontgl.cpp index 4c9a062246..4037c036e5 100644 --- a/indra/llrender/llfontgl.cpp +++ b/indra/llrender/llfontgl.cpp @@ -58,6 +58,7 @@ F32 LLFontGL::sVertDPI = 96.f;  F32 LLFontGL::sHorizDPI = 96.f;  F32 LLFontGL::sScaleX = 1.f;  F32 LLFontGL::sScaleY = 1.f; +S32 LLFontGL::sResolutionGeneration = 0;  bool LLFontGL::sDisplayFont = true ;  std::string LLFontGL::sAppDir; @@ -109,6 +110,11 @@ S32 LLFontGL::getNumFaces(const std::string& filename)      return mFontFreetype->getNumFaces(filename);  } +S32 LLFontGL::getKnownGlyphCount() const +{ +    return mFontFreetype ? mFontFreetype->getAddedGlyphs() : 0; +} +  S32 LLFontGL::render(const LLWString &wstr, S32 begin_offset, const LLRect& rect, const LLColor4 &color, HAlign halign, VAlign valign, U8 style,      ShadowType shadow, S32 max_chars, F32* right_x, bool use_ellipses, bool use_color) const  { @@ -249,6 +255,10 @@ S32 LLFontGL::render(const LLWString &wstr, S32 begin_offset, F32 x, F32 y, cons      const LLFontBitmapCache* font_bitmap_cache = mFontFreetype->getFontBitmapCache(); +    // This looks wrong, value is dynamic. +    // LLFontBitmapCache::nextOpenPos can alter these values when +    // new characters get added to cache, which affects whole string. +    // Todo: Perhaps value should update after symbols were added?      F32 inv_width = 1.f / font_bitmap_cache->getBitmapWidth();      F32 inv_height = 1.f / font_bitmap_cache->getBitmapHeight(); @@ -270,6 +280,10 @@ S32 LLFontGL::render(const LLWString &wstr, S32 begin_offset, F32 x, F32 y, cons      const LLFontGlyphInfo* next_glyph = NULL; +    // string can have more than one glyph per char (ex: bold or shadow), +    // make sure that GLYPH_BATCH_SIZE won't end up with half a symbol. +    // See drawGlyph. +    // Ex: with shadows it's 6 glyps per char. 30 fits exactly 5 chars.      static constexpr S32 GLYPH_BATCH_SIZE = 30;      static thread_local LLVector4a vertices[GLYPH_BATCH_SIZE * 6];      static thread_local LLVector2 uvs[GLYPH_BATCH_SIZE * 6]; @@ -282,6 +296,7 @@ S32 LLFontGL::render(const LLWString &wstr, S32 begin_offset, F32 x, F32 y, cons      std::pair<EFontGlyphType, S32> bitmap_entry = std::make_pair(EFontGlyphType::Grayscale, -1);      S32 glyph_count = 0; +    llwchar last_char = wstr[begin_offset];      for (i = begin_offset; i < begin_offset + length; i++)      {          llwchar wch = wstr[i]; @@ -299,7 +314,7 @@ S32 LLFontGL::render(const LLWString &wstr, S32 begin_offset, F32 x, F32 y, cons          }          // Per-glyph bitmap texture.          std::pair<EFontGlyphType, S32> next_bitmap_entry = fgi->mBitmapEntry; -        if (next_bitmap_entry != bitmap_entry) +        if (next_bitmap_entry != bitmap_entry || last_char != wch)          {              // Actually draw the queued glyphs before switching their texture;              // otherwise the queued glyphs will be taken from wrong textures. @@ -316,6 +331,11 @@ S32 LLFontGL::render(const LLWString &wstr, S32 begin_offset, F32 x, F32 y, cons              bitmap_entry = next_bitmap_entry;              LLImageGL* font_image = font_bitmap_cache->getImageGL(bitmap_entry.first, bitmap_entry.second);              gGL.getTexUnit(0)->bind(font_image); + +            // For some reason it's not enough to compare by bitmap_entry. +            // Issue hits emojis, japenese and chinese glyphs, only on first run. +            // Todo: figure it out, there might be a bug with raw image data. +            last_char = wch;          }          if ((start_x + scaled_max_pixels) < (cur_x + fgi->mXBearing + fgi->mWidth)) diff --git a/indra/llrender/llfontgl.h b/indra/llrender/llfontgl.h index 4bb6c55c65..73efc6b1eb 100644 --- a/indra/llrender/llfontgl.h +++ b/indra/llrender/llfontgl.h @@ -90,6 +90,7 @@ public:      bool loadFace(const std::string& filename, F32 point_size, const F32 vert_dpi, const F32 horz_dpi, bool is_fallback, S32 face_n);      S32 getNumFaces(const std::string& filename); +    S32 getKnownGlyphCount() const;      S32 render(const LLWString &text, S32 begin_offset,                  const LLRect& rect, @@ -224,6 +225,7 @@ public:      static F32 sHorizDPI;      static F32 sScaleX;      static F32 sScaleY; +    static S32 sResolutionGeneration;      static bool sDisplayFont ;      static std::string sAppDir;         // For loading fonts diff --git a/indra/llrender/llfontvertexbuffer.cpp b/indra/llrender/llfontvertexbuffer.cpp index 5bd1ca5eed..b53a841a87 100644 --- a/indra/llrender/llfontvertexbuffer.cpp +++ b/indra/llrender/llfontvertexbuffer.cpp @@ -146,7 +146,9 @@ S32 LLFontVertexBuffer::render(               || mLastScaleY != LLFontGL::sScaleY               || mLastVertDPI != LLFontGL::sVertDPI               || mLastHorizDPI != LLFontGL::sHorizDPI -             || mLastOrigin != LLFontGL::sCurOrigin) +             || mLastOrigin != LLFontGL::sCurOrigin +             || mLastResGeneration != LLFontGL::sResolutionGeneration +             || mLastFontGlyphCount != fontp->getKnownGlyphCount())      {          genBuffers(fontp, text, begin_offset, x, y, color, halign, valign,              style, shadow, max_chars, max_pixels, right_x, use_ellipses, use_color); @@ -201,6 +203,8 @@ void LLFontVertexBuffer::genBuffers(      mLastVertDPI = LLFontGL::sVertDPI;      mLastHorizDPI = LLFontGL::sHorizDPI;      mLastOrigin = LLFontGL::sCurOrigin; +    mLastResGeneration = LLFontGL::sResolutionGeneration; +    mLastFontGlyphCount = fontp->getKnownGlyphCount();      if (right_x)      { diff --git a/indra/llrender/llfontvertexbuffer.h b/indra/llrender/llfontvertexbuffer.h index af195dfff9..d5e1280dbf 100644 --- a/indra/llrender/llfontvertexbuffer.h +++ b/indra/llrender/llfontvertexbuffer.h @@ -117,8 +117,13 @@ private:      F32 mLastScaleY = 1.f;      F32 mLastVertDPI = 0.f;      F32 mLastHorizDPI = 0.f; +    S32 mLastResGeneration = 0;      LLCoordGL mLastOrigin; +    // Adding new characters to bitmap cache can alter value from getBitmapWidth(); +    // which alters whole string. So rerender when new characters were added to cache. +    S32 mLastFontGlyphCount = 0; +      static bool sEnableBufferCollection;  }; diff --git a/indra/llrender/llglslshader.h b/indra/llrender/llglslshader.h index 58c456f134..873ab0cff5 100644 --- a/indra/llrender/llglslshader.h +++ b/indra/llrender/llglslshader.h @@ -59,6 +59,7 @@ public:      bool attachNothing = false;      bool hasHeroProbes = false;      bool isPBRTerrain = false; +    bool hasTonemap = false;  };  // ============= Structure for caching shader uniforms =============== diff --git a/indra/llrender/llshadermgr.cpp b/indra/llrender/llshadermgr.cpp index 37697f8a15..4807c12226 100644 --- a/indra/llrender/llshadermgr.cpp +++ b/indra/llrender/llshadermgr.cpp @@ -291,6 +291,14 @@ bool LLShaderMgr::attachShaderFeatures(LLGLSLShader * shader)          }      } +    if (features->hasTonemap) +    { +        if (!shader->attachFragmentObject("deferred/tonemapUtilF.glsl")) +        { +            return false; +        } +    } +      // NOTE order of shader object attaching is VERY IMPORTANT!!!      if (features->hasAtmospherics)      { @@ -1392,6 +1400,7 @@ void LLShaderMgr::initAttribsAndUniforms()      mReservedUniforms.push_back("screenTex");      mReservedUniforms.push_back("screenDepth");      mReservedUniforms.push_back("refTex"); +    mReservedUniforms.push_back("exclusionTex");      mReservedUniforms.push_back("eyeVec");      mReservedUniforms.push_back("time");      mReservedUniforms.push_back("waveDir1"); diff --git a/indra/llrender/llshadermgr.h b/indra/llrender/llshadermgr.h index 34bd73a42e..46788841a5 100644 --- a/indra/llrender/llshadermgr.h +++ b/indra/llrender/llshadermgr.h @@ -36,6 +36,8 @@ public:      LLShaderMgr();      virtual ~LLShaderMgr(); +    // Note: although you can use statically hashed strings to just bind a random uniform, it's generally preferably that you use this. +    // Always document what the actual shader uniform is next to the shader uniform in this struct.      // clang-format off      typedef enum      {                                       // Shader uniform name, set in LLShaderMgr::initAttribsAndUniforms() @@ -234,6 +236,7 @@ public:          WATER_SCREENTEX,                    //  "screenTex"          WATER_SCREENDEPTH,                  //  "screenDepth"          WATER_REFTEX,                       //  "refTex" +        WATER_EXCLUSIONTEX,                 //  "exclusionTex"          WATER_EYEVEC,                       //  "eyeVec"          WATER_TIME,                         //  "time"          WATER_WAVE_DIR1,                    //  "waveDir1" | 
