diff options
Diffstat (limited to 'indra/llcommon/tests')
| -rw-r--r-- | indra/llcommon/tests/StringVec.h | 37 | ||||
| -rw-r--r-- | indra/llcommon/tests/listener.h | 21 | ||||
| -rw-r--r-- | indra/llcommon/tests/llinstancetracker_test.cpp | 7 | ||||
| -rw-r--r-- | indra/llcommon/tests/llprocess_test.cpp | 1271 | ||||
| -rw-r--r-- | indra/llcommon/tests/llsdserialize_test.cpp | 274 | ||||
| -rw-r--r-- | indra/llcommon/tests/llstreamqueue_test.cpp | 197 | ||||
| -rw-r--r-- | indra/llcommon/tests/llstring_test.cpp | 118 | ||||
| -rw-r--r-- | indra/llcommon/tests/setpython.py | 19 | 
8 files changed, 1647 insertions, 297 deletions
| diff --git a/indra/llcommon/tests/StringVec.h b/indra/llcommon/tests/StringVec.h new file mode 100644 index 0000000000..a380b00a05 --- /dev/null +++ b/indra/llcommon/tests/StringVec.h @@ -0,0 +1,37 @@ +/** + * @file   StringVec.h + * @author Nat Goodspeed + * @date   2012-02-24 + * @brief  Extend TUT ensure_equals() to handle std::vector<std::string> + *  + * $LicenseInfo:firstyear=2012&license=viewerlgpl$ + * Copyright (c) 2012, Linden Research, Inc. + * $/LicenseInfo$ + */ + +#if ! defined(LL_STRINGVEC_H) +#define LL_STRINGVEC_H + +#include <vector> +#include <string> +#include <iostream> + +typedef std::vector<std::string> StringVec; + +std::ostream& operator<<(std::ostream& out, const StringVec& strings) +{ +    out << '('; +    StringVec::const_iterator begin(strings.begin()), end(strings.end()); +    if (begin != end) +    { +        out << '"' << *begin << '"'; +        while (++begin != end) +        { +            out << ", \"" << *begin << '"'; +        } +    } +    out << ')'; +    return out; +} + +#endif /* ! defined(LL_STRINGVEC_H) */ diff --git a/indra/llcommon/tests/listener.h b/indra/llcommon/tests/listener.h index dcdb2412be..9c5c18a150 100644 --- a/indra/llcommon/tests/listener.h +++ b/indra/llcommon/tests/listener.h @@ -30,6 +30,8 @@  #define LL_LISTENER_H  #include "llsd.h" +#include "llevents.h" +#include "tests/StringVec.h"  #include <iostream>  /***************************************************************************** @@ -133,24 +135,7 @@ struct Collect          return false;      }      void clear() { result.clear(); } -    typedef std::vector<std::string> StringList; -    StringList result; +    StringVec result;  }; -std::ostream& operator<<(std::ostream& out, const Collect::StringList& strings) -{ -    out << '('; -    Collect::StringList::const_iterator begin(strings.begin()), end(strings.end()); -    if (begin != end) -    { -        out << '"' << *begin << '"'; -        while (++begin != end) -        { -            out << ", \"" << *begin << '"'; -        } -    } -    out << ')'; -    return out; -} -  #endif /* ! defined(LL_LISTENER_H) */ diff --git a/indra/llcommon/tests/llinstancetracker_test.cpp b/indra/llcommon/tests/llinstancetracker_test.cpp index fda932c355..454695ff9f 100644 --- a/indra/llcommon/tests/llinstancetracker_test.cpp +++ b/indra/llcommon/tests/llinstancetracker_test.cpp @@ -112,6 +112,7 @@ namespace tut      void object::test<2>()      {          ensure_equals(Unkeyed::instanceCount(), 0); +        Unkeyed* dangling = NULL;          {              Unkeyed one;              ensure_equals(Unkeyed::instanceCount(), 1); @@ -124,7 +125,11 @@ namespace tut                  ensure_equals(found, two.get());              }              ensure_equals(Unkeyed::instanceCount(), 1); -        } +            // store an unwise pointer to a temp Unkeyed instance +            dangling = &one; +        } // make that instance vanish +        // check the now-invalid pointer to the destroyed instance +        ensure("getInstance(T*) failed to track destruction", ! Unkeyed::getInstance(dangling));          ensure_equals(Unkeyed::instanceCount(), 0);      } diff --git a/indra/llcommon/tests/llprocess_test.cpp b/indra/llcommon/tests/llprocess_test.cpp new file mode 100644 index 0000000000..d7feddd26b --- /dev/null +++ b/indra/llcommon/tests/llprocess_test.cpp @@ -0,0 +1,1271 @@ +/** + * @file   llprocess_test.cpp + * @author Nat Goodspeed + * @date   2011-12-19 + * @brief  Test for llprocess. + *  + * $LicenseInfo:firstyear=2011&license=viewerlgpl$ + * Copyright (c) 2011, Linden Research, Inc. + * $/LicenseInfo$ + */ + +// Precompiled header +#include "linden_common.h" +// associated header +#include "llprocess.h" +// STL headers +#include <vector> +#include <list> +// std headers +#include <fstream> +// external library headers +#include "llapr.h" +#include "apr_thread_proc.h" +#include <boost/foreach.hpp> +#include <boost/function.hpp> +#include <boost/algorithm/string/find_iterator.hpp> +#include <boost/algorithm/string/finder.hpp> +//#include <boost/lambda/lambda.hpp> +//#include <boost/lambda/bind.hpp> +// other Linden headers +#include "../test/lltut.h" +#include "../test/manageapr.h" +#include "../test/namedtempfile.h" +#include "../test/catch_and_store_what_in.h" +#include "stringize.h" +#include "llsdutil.h" +#include "llevents.h" +#include "llerrorcontrol.h" + +#if defined(LL_WINDOWS) +#define sleep(secs) _sleep((secs) * 1000) +#define EOL "\r\n" +#else +#define EOL "\n" +#include <sys/wait.h> +#endif + +//namespace lambda = boost::lambda; + +// static instance of this manages APR init/cleanup +static ManageAPR manager; + +/***************************************************************************** +*   Helpers +*****************************************************************************/ + +#define ensure_equals_(left, right) \ +        ensure_equals(STRINGIZE(#left << " != " << #right), (left), (right)) + +#define aprchk(expr) aprchk_(#expr, (expr)) +static void aprchk_(const char* call, apr_status_t rv, apr_status_t expected=APR_SUCCESS) +{ +    tut::ensure_equals(STRINGIZE(call << " => " << rv << ": " << manager.strerror(rv)), +                       rv, expected); +} + +/** + * Read specified file using std::getline(). It is assumed to be an error if + * the file is empty: don't use this function if that's an acceptable case. + * Last line will not end with '\n'; this is to facilitate the usual case of + * string compares with a single line of output. + * @param pathname The file to read. + * @param desc Optional description of the file for error message; + * defaults to "in <pathname>" + */ +static std::string readfile(const std::string& pathname, const std::string& desc="") +{ +    std::string use_desc(desc); +    if (use_desc.empty()) +    { +        use_desc = STRINGIZE("in " << pathname); +    } +    std::ifstream inf(pathname.c_str()); +    std::string output; +    tut::ensure(STRINGIZE("No output " << use_desc), std::getline(inf, output)); +    std::string more; +    while (std::getline(inf, more)) +    { +        output += '\n' + more; +    } +    return output; +} + +/// Looping on LLProcess::isRunning() must now be accompanied by pumping +/// "mainloop" -- otherwise the status won't update and you get an infinite +/// loop. +void yield(int seconds=1) +{ +    // This function simulates waiting for another viewer frame +    sleep(seconds); +    LLEventPumps::instance().obtain("mainloop").post(LLSD()); +} + +void waitfor(LLProcess& proc) +{ +    while (proc.isRunning()) +    { +        yield(); +    } +} + +void waitfor(LLProcess::handle h, const std::string& desc) +{ +    while (LLProcess::isRunning(h, desc)) +    { +        yield(); +    } +} + +/** + * Construct an LLProcess to run a Python script. + */ +struct PythonProcessLauncher +{ +    /** +     * @param desc Arbitrary description for error messages +     * @param script Python script, any form acceptable to NamedTempFile, +     * typically either a std::string or an expression of the form +     * (lambda::_1 << "script content with " << variable_data) +     */ +    template <typename CONTENT> +    PythonProcessLauncher(const std::string& desc, const CONTENT& script): +        mDesc(desc), +        mScript("py", script) +    { +        const char* PYTHON(getenv("PYTHON")); +        tut::ensure("Set $PYTHON to the Python interpreter", PYTHON); + +        mParams.desc = desc + " script"; +        mParams.executable = PYTHON; +        mParams.args.add(mScript.getName()); +    } + +    /// Launch Python script; verify that it launched +    void launch() +    { +        mPy = LLProcess::create(mParams); +        tut::ensure(STRINGIZE("Couldn't launch " << mDesc << " script"), mPy); +    } + +    /// Run Python script and wait for it to complete. +    void run() +    { +        launch(); +        // One of the irritating things about LLProcess is that +        // there's no API to wait for the child to terminate -- but given +        // its use in our graphics-intensive interactive viewer, it's +        // understandable. +        waitfor(*mPy); +    } + +    /** +     * Run a Python script using LLProcess, expecting that it will +     * write to the file passed as its sys.argv[1]. Retrieve that output. +     * +     * Until January 2012, LLProcess provided distressingly few +     * mechanisms for a child process to communicate back to its caller -- +     * not even its return code. We've introduced a convention by which we +     * create an empty temp file, pass the name of that file to our child +     * as sys.argv[1] and expect the script to write its output to that +     * file. This function implements the C++ (parent process) side of +     * that convention. +     */ +    std::string run_read() +    { +        NamedTempFile out("out", ""); // placeholder +        // pass name of this temporary file to the script +        mParams.args.add(out.getName()); +        run(); +        // assuming the script wrote to that file, read it +        return readfile(out.getName(), STRINGIZE("from " << mDesc << " script")); +    } + +    LLProcess::Params mParams; +    LLProcessPtr mPy; +    std::string mDesc; +    NamedTempFile mScript; +}; + +/// convenience function for PythonProcessLauncher::run() +template <typename CONTENT> +static void python(const std::string& desc, const CONTENT& script) +{ +    PythonProcessLauncher py(desc, script); +    py.run(); +} + +/// convenience function for PythonProcessLauncher::run_read() +template <typename CONTENT> +static std::string python_out(const std::string& desc, const CONTENT& script) +{ +    PythonProcessLauncher py(desc, script); +    return py.run_read(); +} + +/// Create a temporary directory and clean it up later. +class NamedTempDir: public boost::noncopyable +{ +public: +    // Use python() function to create a temp directory: I've found +    // nothing in either Boost.Filesystem or APR quite like Python's +    // tempfile.mkdtemp(). +    // Special extra bonus: on Mac, mkdtemp() reports a pathname +    // starting with /var/folders/something, whereas that's really a +    // symlink to /private/var/folders/something. Have to use +    // realpath() to compare properly. +    NamedTempDir(): +        mPath(python_out("mkdtemp()", +                         "from __future__ import with_statement\n" +                         "import os.path, sys, tempfile\n" +                         "with open(sys.argv[1], 'w') as f:\n" +                         "    f.write(os.path.normcase(os.path.normpath(os.path.realpath(tempfile.mkdtemp()))))\n")) +    {} + +    ~NamedTempDir() +    { +        aprchk(apr_dir_remove(mPath.c_str(), gAPRPoolp)); +    } + +    std::string getName() const { return mPath; } + +private: +    std::string mPath; +}; + +// statically reference the function in test.cpp... it's short, we could +// replicate, but better to reuse +extern void wouldHaveCrashed(const std::string& message); + +/** + * Capture log messages. This is adapted (simplified) from the one in + * llerror_test.cpp. Sigh, should've broken that out into a separate header + * file, but time for this project is short... + */ +class TestRecorder : public LLError::Recorder +{ +public: +    TestRecorder(): +        // Mostly what we're trying to accomplish by saving and resetting +        // LLError::Settings is to bypass the default RecordToStderr and +        // RecordToWinDebug Recorders. As these are visible only inside +        // llerror.cpp, we can't just call LLError::removeRecorder() with +        // each. For certain tests we need to produce, capture and examine +        // DEBUG log messages -- but we don't want to spam the user's console +        // with that output. If it turns out that saveAndResetSettings() has +        // some bad effect, give up and just let the DEBUG level log messages +        // display. +        mOldSettings(LLError::saveAndResetSettings()) +    { +        LLError::setFatalFunction(wouldHaveCrashed); +        LLError::setDefaultLevel(LLError::LEVEL_DEBUG); +        LLError::addRecorder(this); +    } + +    ~TestRecorder() +    { +        LLError::removeRecorder(this); +        LLError::restoreSettings(mOldSettings); +    } + +    void recordMessage(LLError::ELevel level, +                       const std::string& message) +    { +        mMessages.push_back(message); +    } + +    /// Don't assume the message we want is necessarily the LAST log message +    /// emitted by the underlying code; search backwards through all messages +    /// for the sought string. +    std::string messageWith(const std::string& search) +    { +        for (std::list<std::string>::const_reverse_iterator rmi(mMessages.rbegin()), +                 rmend(mMessages.rend()); +             rmi != rmend; ++rmi) +        { +            if (rmi->find(search) != std::string::npos) +                return *rmi; +        } +        // failed to find any such message +        return std::string(); +    } + +    typedef std::list<std::string> MessageList; +    MessageList mMessages; +    LLError::Settings* mOldSettings; +}; + +std::string getline(std::istream& in) +{ +    std::string line; +    std::getline(in, line); +    // Blur the distinction between "\r\n" and plain "\n". std::getline() will +    // have eaten the "\n", but we could still end up with a trailing "\r". +    std::string::size_type lastpos = line.find_last_not_of("\r"); +    if (lastpos != std::string::npos) +    { +        // Found at least one character that's not a trailing '\r'. SKIP OVER +        // IT and then erase the rest of the line. +        line.erase(lastpos+1); +    } +    return line; +} + +/***************************************************************************** +*   TUT +*****************************************************************************/ +namespace tut +{ +    struct llprocess_data +    { +        LLAPRPool pool; +    }; +    typedef test_group<llprocess_data> llprocess_group; +    typedef llprocess_group::object object; +    llprocess_group llprocessgrp("llprocess"); + +    struct Item +    { +        Item(): tries(0) {} +        unsigned    tries; +        std::string which; +        std::string what; +    }; + +/*==========================================================================*| +#define tabent(symbol) { symbol, #symbol } +    static struct ReasonCode +    { +        int code; +        const char* name; +    } reasons[] = +    { +        tabent(APR_OC_REASON_DEATH), +        tabent(APR_OC_REASON_UNWRITABLE), +        tabent(APR_OC_REASON_RESTART), +        tabent(APR_OC_REASON_UNREGISTER), +        tabent(APR_OC_REASON_LOST), +        tabent(APR_OC_REASON_RUNNING) +    }; +#undef tabent +|*==========================================================================*/ + +    struct WaitInfo +    { +        WaitInfo(apr_proc_t* child_): +            child(child_), +            rv(-1),                 // we haven't yet called apr_proc_wait() +            rc(0), +            why(apr_exit_why_e(0)) +        {} +        apr_proc_t* child;          // which subprocess +        apr_status_t rv;            // return from apr_proc_wait() +        int rc;                     // child's exit code +        apr_exit_why_e why;         // APR_PROC_EXIT, APR_PROC_SIGNAL, APR_PROC_SIGNAL_CORE +    }; + +    void child_status_callback(int reason, void* data, int status) +    { +/*==========================================================================*| +        std::string reason_str; +        BOOST_FOREACH(const ReasonCode& rcp, reasons) +        { +            if (reason == rcp.code) +            { +                reason_str = rcp.name; +                break; +            } +        } +        if (reason_str.empty()) +        { +            reason_str = STRINGIZE("unknown reason " << reason); +        } +        std::cout << "child_status_callback(" << reason_str << ")\n"; +|*==========================================================================*/ + +        if (reason == APR_OC_REASON_DEATH || reason == APR_OC_REASON_LOST) +        { +            // Somewhat oddly, APR requires that you explicitly unregister +            // even when it already knows the child has terminated. +            apr_proc_other_child_unregister(data); + +            WaitInfo* wi(static_cast<WaitInfo*>(data)); +            // It's just wrong to call apr_proc_wait() here. The only way APR +            // knows to call us with APR_OC_REASON_DEATH is that it's already +            // reaped this child process, so calling wait() will only produce +            // "huh?" from the OS. We must rely on the status param passed in, +            // which unfortunately comes straight from the OS wait() call. +//          wi->rv = apr_proc_wait(wi->child, &wi->rc, &wi->why, APR_NOWAIT); +            wi->rv = APR_CHILD_DONE; // fake apr_proc_wait() results +#if defined(LL_WINDOWS) +            wi->why = APR_PROC_EXIT; +            wi->rc  = status;         // no encoding on Windows (no signals) +#else  // Posix +            if (WIFEXITED(status)) +            { +                wi->why = APR_PROC_EXIT; +                wi->rc  = WEXITSTATUS(status); +            } +            else if (WIFSIGNALED(status)) +            { +                wi->why = APR_PROC_SIGNAL; +                wi->rc  = WTERMSIG(status); +            } +            else                    // uh, shouldn't happen? +            { +                wi->why = APR_PROC_EXIT; +                wi->rc  = status;   // someone else will have to decode +            } +#endif // Posix +        } +    } + +    template<> template<> +    void object::test<1>() +    { +        set_test_name("raw APR nonblocking I/O"); + +        // Create a script file in a temporary place. +        NamedTempFile script("py", +            "import sys" EOL +            "import time" EOL +            EOL +            "time.sleep(2)" EOL +            "print >>sys.stdout, 'stdout after wait'" EOL +            "sys.stdout.flush()" EOL +            "time.sleep(2)" EOL +            "print >>sys.stderr, 'stderr after wait'" EOL +            "sys.stderr.flush()" EOL +            ); + +        // Arrange to track the history of our interaction with child: what we +        // fetched, which pipe it came from, how many tries it took before we +        // got it. +        std::vector<Item> history; +        history.push_back(Item()); + +        // Run the child process. +        apr_procattr_t *procattr = NULL; +        aprchk(apr_procattr_create(&procattr, pool.getAPRPool())); +        aprchk(apr_procattr_io_set(procattr, APR_CHILD_BLOCK, APR_CHILD_BLOCK, APR_CHILD_BLOCK)); +        aprchk(apr_procattr_cmdtype_set(procattr, APR_PROGRAM_PATH)); + +        std::vector<const char*> argv; +        apr_proc_t child; +        argv.push_back("python"); +        // Have to have a named copy of this std::string so its c_str() value +        // will persist. +        std::string scriptname(script.getName()); +        argv.push_back(scriptname.c_str()); +        argv.push_back(NULL); + +        aprchk(apr_proc_create(&child, argv[0], +                               &argv[0], +                               NULL, // if we wanted to pass explicit environment +                               procattr, +                               pool.getAPRPool())); + +        // We do not want this child process to outlive our APR pool. On +        // destruction of the pool, forcibly kill the process. Tell APR to try +        // SIGTERM and wait 3 seconds. If that didn't work, use SIGKILL. +        apr_pool_note_subprocess(pool.getAPRPool(), &child, APR_KILL_AFTER_TIMEOUT); + +        // arrange to call child_status_callback() +        WaitInfo wi(&child); +        apr_proc_other_child_register(&child, child_status_callback, &wi, child.in, pool.getAPRPool()); + +        // TODO: +        // Stuff child.in until it (would) block to verify EWOULDBLOCK/EAGAIN. +        // Have child script clear it later, then write one more line to prove +        // that it gets through. + +        // Monitor two different output pipes. Because one will be closed +        // before the other, keep them in a list so we can drop whichever of +        // them is closed first. +        typedef std::pair<std::string, apr_file_t*> DescFile; +        typedef std::list<DescFile> DescFileList; +        DescFileList outfiles; +        outfiles.push_back(DescFile("out", child.out)); +        outfiles.push_back(DescFile("err", child.err)); + +        while (! outfiles.empty()) +        { +            // This peculiar for loop is designed to let us erase(dfli). With +            // a list, that invalidates only dfli itself -- but even so, we +            // lose the ability to increment it for the next item. So at the +            // top of every loop, while dfli is still valid, increment +            // dflnext. Then before the next iteration, set dfli to dflnext. +            for (DescFileList::iterator +                     dfli(outfiles.begin()), dflnext(outfiles.begin()), dflend(outfiles.end()); +                 dfli != dflend; dfli = dflnext) +            { +                // Only valid to increment dflnext once we're sure it's not +                // already at dflend. +                ++dflnext; + +                char buf[4096]; + +                apr_status_t rv = apr_file_gets(buf, sizeof(buf), dfli->second); +                if (APR_STATUS_IS_EOF(rv)) +                { +//                  std::cout << "(EOF on " << dfli->first << ")\n"; +//                  history.back().which = dfli->first; +//                  history.back().what  = "*eof*"; +//                  history.push_back(Item()); +                    outfiles.erase(dfli); +                    continue; +                } +                if (rv == EWOULDBLOCK || rv == EAGAIN) +                { +//                  std::cout << "(waiting; apr_file_gets(" << dfli->first << ") => " << rv << ": " << manager.strerror(rv) << ")\n"; +                    ++history.back().tries; +                    continue; +                } +                aprchk_("apr_file_gets(buf, sizeof(buf), dfli->second)", rv); +                // Is it even possible to get APR_SUCCESS but read 0 bytes? +                // Hope not, but defend against that anyway. +                if (buf[0]) +                { +//                  std::cout << dfli->first << ": " << buf; +                    history.back().which = dfli->first; +                    history.back().what.append(buf); +                    if (buf[strlen(buf) - 1] == '\n') +                        history.push_back(Item()); +                    else +                    { +                        // Just for pretty output... if we only read a partial +                        // line, terminate it. +//                      std::cout << "...\n"; +                    } +                } +            } +            // Do this once per tick, as we expect the viewer will +            apr_proc_other_child_refresh_all(APR_OC_REASON_RUNNING); +            sleep(1); +        } +        apr_file_close(child.in); +        apr_file_close(child.out); +        apr_file_close(child.err); + +        // Okay, we've broken the loop because our pipes are all closed. If we +        // haven't yet called wait, give the callback one more chance. This +        // models the fact that unlike this small test program, the viewer +        // will still be running. +        if (wi.rv == -1) +        { +            std::cout << "last gasp apr_proc_other_child_refresh_all()\n"; +            apr_proc_other_child_refresh_all(APR_OC_REASON_RUNNING); +        } + +        if (wi.rv == -1) +        { +            std::cout << "child_status_callback(APR_OC_REASON_DEATH) wasn't called" << std::endl; +            wi.rv = apr_proc_wait(wi.child, &wi.rc, &wi.why, APR_NOWAIT); +        } +//      std::cout << "child done: rv = " << rv << " (" << manager.strerror(rv) << "), why = " << why << ", rc = " << rc << '\n'; +        aprchk_("apr_proc_wait(wi->child, &wi->rc, &wi->why, APR_NOWAIT)", wi.rv, APR_CHILD_DONE); +        ensure_equals_(wi.why, APR_PROC_EXIT); +        ensure_equals_(wi.rc, 0); + +        // Beyond merely executing all the above successfully, verify that we +        // obtained expected output -- and that we duly got control while +        // waiting, proving the non-blocking nature of these pipes. +        try +        { +            unsigned i = 0; +            ensure("blocking I/O on child pipe (0)", history[i].tries); +            ensure_equals_(history[i].which, "out"); +            ensure_equals_(history[i].what,  "stdout after wait" EOL); +//          ++i; +//          ensure_equals_(history[i].which, "out"); +//          ensure_equals_(history[i].what,  "*eof*"); +            ++i; +            ensure("blocking I/O on child pipe (1)", history[i].tries); +            ensure_equals_(history[i].which, "err"); +            ensure_equals_(history[i].what,  "stderr after wait" EOL); +//          ++i; +//          ensure_equals_(history[i].which, "err"); +//          ensure_equals_(history[i].what,  "*eof*"); +        } +        catch (const failure&) +        { +            std::cout << "History:\n"; +            BOOST_FOREACH(const Item& item, history) +            { +                std::string what(item.what); +                if ((! what.empty()) && what[what.length() - 1] == '\n') +                { +                    what.erase(what.length() - 1); +                    if ((! what.empty()) && what[what.length() - 1] == '\r') +                    { +                        what.erase(what.length() - 1); +                        what.append("\\r"); +                    } +                    what.append("\\n"); +                } +                std::cout << "  " << item.which << ": '" << what << "' (" +                          << item.tries << " tries)\n"; +            } +            std::cout << std::flush; +            // re-raise same error; just want to enrich the output +            throw; +        } +    } + +    template<> template<> +    void object::test<2>() +    { +        set_test_name("setWorkingDirectory()"); +        // We want to test setWorkingDirectory(). But what directory is +        // guaranteed to exist on every machine, under every OS? Have to +        // create one. Naturally, ensure we clean it up when done. +        NamedTempDir tempdir; +        PythonProcessLauncher py("getcwd()", +                                 "from __future__ import with_statement\n" +                                 "import os, sys\n" +                                 "with open(sys.argv[1], 'w') as f:\n" +                                 "    f.write(os.path.normcase(os.path.normpath(os.getcwd())))\n"); +        // Before running, call setWorkingDirectory() +        py.mParams.cwd = tempdir.getName(); +        ensure_equals("os.getcwd()", py.run_read(), tempdir.getName()); +    } + +    template<> template<> +    void object::test<3>() +    { +        set_test_name("arguments"); +        PythonProcessLauncher py("args", +                                 "from __future__ import with_statement\n" +                                 "import sys\n" +                                 // note nonstandard output-file arg! +                                 "with open(sys.argv[3], 'w') as f:\n" +                                 "    for arg in sys.argv[1:]:\n" +                                 "        print >>f, arg\n"); +        // We expect that PythonProcessLauncher has already appended +        // its own NamedTempFile to mParams.args (sys.argv[0]). +        py.mParams.args.add("first arg");          // sys.argv[1] +        py.mParams.args.add("second arg");         // sys.argv[2] +        // run_read() appends() one more argument, hence [3] +        std::string output(py.run_read()); +        boost::split_iterator<std::string::const_iterator> +            li(output, boost::first_finder("\n")), lend; +        ensure("didn't get first arg", li != lend); +        std::string arg(li->begin(), li->end()); +        ensure_equals(arg, "first arg"); +        ++li; +        ensure("didn't get second arg", li != lend); +        arg.assign(li->begin(), li->end()); +        ensure_equals(arg, "second arg"); +        ++li; +        ensure("didn't get output filename?!", li != lend); +        arg.assign(li->begin(), li->end()); +        ensure("output filename empty?!", ! arg.empty()); +        ++li; +        ensure("too many args", li == lend); +    } + +    template<> template<> +    void object::test<4>() +    { +        set_test_name("exit(0)"); +        PythonProcessLauncher py("exit(0)", +                                 "import sys\n" +                                 "sys.exit(0)\n"); +        py.run(); +        ensure_equals("Status.mState", py.mPy->getStatus().mState, LLProcess::EXITED); +        ensure_equals("Status.mData",  py.mPy->getStatus().mData,  0); +    } + +    template<> template<> +    void object::test<5>() +    { +        set_test_name("exit(2)"); +        PythonProcessLauncher py("exit(2)", +                                 "import sys\n" +                                 "sys.exit(2)\n"); +        py.run(); +        ensure_equals("Status.mState", py.mPy->getStatus().mState, LLProcess::EXITED); +        ensure_equals("Status.mData",  py.mPy->getStatus().mData,  2); +    } + +    template<> template<> +    void object::test<6>() +    { +        set_test_name("syntax_error:"); +        PythonProcessLauncher py("syntax_error:", +                                 "syntax_error:\n"); +        py.mParams.files.add(LLProcess::FileParam()); // inherit stdin +        py.mParams.files.add(LLProcess::FileParam()); // inherit stdout +        py.mParams.files.add(LLProcess::FileParam().type("pipe")); // pipe for stderr +        py.run(); +        ensure_equals("Status.mState", py.mPy->getStatus().mState, LLProcess::EXITED); +        ensure_equals("Status.mData",  py.mPy->getStatus().mData,  1); +        std::istream& rpipe(py.mPy->getReadPipe(LLProcess::STDERR).get_istream()); +        std::vector<char> buffer(4096); +        rpipe.read(&buffer[0], buffer.size()); +        std::streamsize got(rpipe.gcount()); +        ensure("Nothing read from stderr pipe", got); +        std::string data(&buffer[0], got); +        ensure("Didn't find 'SyntaxError:'", data.find("\nSyntaxError:") != std::string::npos); +    } + +    template<> template<> +    void object::test<7>() +    { +        set_test_name("explicit kill()"); +        PythonProcessLauncher py("kill()", +                                 "from __future__ import with_statement\n" +                                 "import sys, time\n" +                                 "with open(sys.argv[1], 'w') as f:\n" +                                 "    f.write('ok')\n" +                                 "# now sleep; expect caller to kill\n" +                                 "time.sleep(120)\n" +                                 "# if caller hasn't managed to kill by now, bad\n" +                                 "with open(sys.argv[1], 'w') as f:\n" +                                 "    f.write('bad')\n"); +        NamedTempFile out("out", "not started"); +        py.mParams.args.add(out.getName()); +        py.launch(); +        // Wait for the script to wake up and do its first write +        int i = 0, timeout = 60; +        for ( ; i < timeout; ++i) +        { +            yield(); +            if (readfile(out.getName(), "from kill() script") == "ok") +                break; +        } +        // If we broke this loop because of the counter, something's wrong +        ensure("script never started", i < timeout); +        // script has performed its first write and should now be sleeping. +        py.mPy->kill(); +        // wait for the script to terminate... one way or another. +        waitfor(*py.mPy); +#if LL_WINDOWS +        ensure_equals("Status.mState", py.mPy->getStatus().mState, LLProcess::EXITED); +        ensure_equals("Status.mData",  py.mPy->getStatus().mData,  -1); +#else +        ensure_equals("Status.mState", py.mPy->getStatus().mState, LLProcess::KILLED); +        ensure_equals("Status.mData",  py.mPy->getStatus().mData,  SIGTERM); +#endif +        // If kill() failed, the script would have woken up on its own and +        // overwritten the file with 'bad'. But if kill() succeeded, it should +        // not have had that chance. +        ensure_equals("kill() script output", readfile(out.getName()), "ok"); +    } + +    template<> template<> +    void object::test<8>() +    { +        set_test_name("implicit kill()"); +        NamedTempFile out("out", "not started"); +        LLProcess::handle phandle(0); +        { +            PythonProcessLauncher py("kill()", +                                     "from __future__ import with_statement\n" +                                     "import sys, time\n" +                                     "with open(sys.argv[1], 'w') as f:\n" +                                     "    f.write('ok')\n" +                                     "# now sleep; expect caller to kill\n" +                                     "time.sleep(120)\n" +                                     "# if caller hasn't managed to kill by now, bad\n" +                                     "with open(sys.argv[1], 'w') as f:\n" +                                     "    f.write('bad')\n"); +            py.mParams.args.add(out.getName()); +            py.launch(); +            // Capture handle for later +            phandle = py.mPy->getProcessHandle(); +            // Wait for the script to wake up and do its first write +            int i = 0, timeout = 60; +            for ( ; i < timeout; ++i) +            { +                yield(); +                if (readfile(out.getName(), "from kill() script") == "ok") +                    break; +            } +            // If we broke this loop because of the counter, something's wrong +            ensure("script never started", i < timeout); +            // Script has performed its first write and should now be sleeping. +            // Destroy the LLProcess, which should kill the child. +        } +        // wait for the script to terminate... one way or another. +        waitfor(phandle, "kill() script"); +        // If kill() failed, the script would have woken up on its own and +        // overwritten the file with 'bad'. But if kill() succeeded, it should +        // not have had that chance. +        ensure_equals("kill() script output", readfile(out.getName()), "ok"); +    } + +    template<> template<> +    void object::test<9>() +    { +        set_test_name("autokill=false"); +        NamedTempFile from("from", "not started"); +        NamedTempFile to("to", ""); +        LLProcess::handle phandle(0); +        { +            PythonProcessLauncher py("autokill", +                                     "from __future__ import with_statement\n" +                                     "import sys, time\n" +                                     "with open(sys.argv[1], 'w') as f:\n" +                                     "    f.write('ok')\n" +                                     "# wait for 'go' from test program\n" +                                     "for i in xrange(60):\n" +                                     "    time.sleep(1)\n" +                                     "    with open(sys.argv[2]) as f:\n" +                                     "        go = f.read()\n" +                                     "    if go == 'go':\n" +                                     "        break\n" +                                     "else:\n" +                                     "    with open(sys.argv[1], 'w') as f:\n" +                                     "        f.write('never saw go')\n" +                                     "    sys.exit(1)\n" +                                     "# okay, saw 'go', write 'ack'\n" +                                     "with open(sys.argv[1], 'w') as f:\n" +                                     "    f.write('ack')\n"); +            py.mParams.args.add(from.getName()); +            py.mParams.args.add(to.getName()); +            py.mParams.autokill = false; +            py.launch(); +            // Capture handle for later +            phandle = py.mPy->getProcessHandle(); +            // Wait for the script to wake up and do its first write +            int i = 0, timeout = 60; +            for ( ; i < timeout; ++i) +            { +                yield(); +                if (readfile(from.getName(), "from autokill script") == "ok") +                    break; +            } +            // If we broke this loop because of the counter, something's wrong +            ensure("script never started", i < timeout); +            // Now destroy the LLProcess, which should NOT kill the child! +        } +        // If the destructor killed the child anyway, give it time to die +        yield(2); +        // How do we know it's not terminated? By making it respond to +        // a specific stimulus in a specific way. +        { +            std::ofstream outf(to.getName().c_str()); +            outf << "go"; +        } // flush and close. +        // now wait for the script to terminate... one way or another. +        waitfor(phandle, "autokill script"); +        // If the LLProcess destructor implicitly called kill(), the +        // script could not have written 'ack' as we expect. +        ensure_equals("autokill script output", readfile(from.getName()), "ack"); +    } + +    template<> template<> +    void object::test<10>() +    { +        set_test_name("'bogus' test"); +        TestRecorder recorder; +        PythonProcessLauncher py("'bogus' test", +                                 "print 'Hello world'\n"); +        py.mParams.files.add(LLProcess::FileParam("bogus")); +        py.mPy = LLProcess::create(py.mParams); +        ensure("should have rejected 'bogus'", ! py.mPy); +        std::string message(recorder.messageWith("bogus")); +        ensure("did not log 'bogus' type", ! message.empty()); +        ensure_contains("did not name 'stdin'", message, "stdin"); +    } + +    template<> template<> +    void object::test<11>() +    { +        set_test_name("'file' test"); +        // Replace this test with one or more real 'file' tests when we +        // implement 'file' support +        PythonProcessLauncher py("'file' test", +                                 "print 'Hello world'\n"); +        py.mParams.files.add(LLProcess::FileParam()); +        py.mParams.files.add(LLProcess::FileParam("file")); +        py.mPy = LLProcess::create(py.mParams); +        ensure("should have rejected 'file'", ! py.mPy); +    } + +    template<> template<> +    void object::test<12>() +    { +        set_test_name("'tpipe' test"); +        // Replace this test with one or more real 'tpipe' tests when we +        // implement 'tpipe' support +        TestRecorder recorder; +        PythonProcessLauncher py("'tpipe' test", +                                 "print 'Hello world'\n"); +        py.mParams.files.add(LLProcess::FileParam()); +        py.mParams.files.add(LLProcess::FileParam("tpipe")); +        py.mPy = LLProcess::create(py.mParams); +        ensure("should have rejected 'tpipe'", ! py.mPy); +        std::string message(recorder.messageWith("tpipe")); +        ensure("did not log 'tpipe' type", ! message.empty()); +        ensure_contains("did not name 'stdout'", message, "stdout"); +    } + +    template<> template<> +    void object::test<13>() +    { +        set_test_name("'npipe' test"); +        // Replace this test with one or more real 'npipe' tests when we +        // implement 'npipe' support +        TestRecorder recorder; +        PythonProcessLauncher py("'npipe' test", +                                 "print 'Hello world'\n"); +        py.mParams.files.add(LLProcess::FileParam()); +        py.mParams.files.add(LLProcess::FileParam()); +        py.mParams.files.add(LLProcess::FileParam("npipe")); +        py.mPy = LLProcess::create(py.mParams); +        ensure("should have rejected 'npipe'", ! py.mPy); +        std::string message(recorder.messageWith("npipe")); +        ensure("did not log 'npipe' type", ! message.empty()); +        ensure_contains("did not name 'stderr'", message, "stderr"); +    } + +    template<> template<> +    void object::test<14>() +    { +        set_test_name("internal pipe name warning"); +        TestRecorder recorder; +        PythonProcessLauncher py("pipe warning", +                                 "import sys\n" +                                 "sys.exit(7)\n"); +        py.mParams.files.add(LLProcess::FileParam("pipe", "somename")); +        py.run();                   // verify that it did launch anyway +        ensure_equals("Status.mState", py.mPy->getStatus().mState, LLProcess::EXITED); +        ensure_equals("Status.mData",  py.mPy->getStatus().mData,  7); +        std::string message(recorder.messageWith("not yet supported")); +        ensure("did not log pipe name warning", ! message.empty()); +        ensure_contains("log message did not mention internal pipe name", +                        message, "somename"); +    } + +    /*-------------- support for "get*Pipe() validation" test --------------*/ +#define TEST_getPipe(PROCESS, GETPIPE, GETOPTPIPE, VALID, NOPIPE, BADPIPE) \ +    do                                                                  \ +    {                                                                   \ +        std::string threw;                                              \ +        /* Both the following calls should work. */                     \ +        (PROCESS).GETPIPE(VALID);                                       \ +        ensure(#GETOPTPIPE "(" #VALID ") failed", (PROCESS).GETOPTPIPE(VALID)); \ +        /* pass obviously bogus PIPESLOT */                             \ +        CATCH_IN(threw, LLProcess::NoPipe, (PROCESS).GETPIPE(LLProcess::FILESLOT(4))); \ +        ensure_contains("didn't reject bad slot", threw, "no slot");    \ +        ensure_contains("didn't mention bad slot num", threw, "4");     \ +        EXPECT_FAIL_WITH_LOG(threw, (PROCESS).GETOPTPIPE(LLProcess::FILESLOT(4))); \ +        /* pass NOPIPE */                                               \ +        CATCH_IN(threw, LLProcess::NoPipe, (PROCESS).GETPIPE(NOPIPE));  \ +        ensure_contains("didn't reject non-pipe", threw, "not a monitored"); \ +        EXPECT_FAIL_WITH_LOG(threw, (PROCESS).GETOPTPIPE(NOPIPE));      \ +        /* pass BADPIPE: FILESLOT isn't empty but wrong direction */    \ +        CATCH_IN(threw, LLProcess::NoPipe, (PROCESS).GETPIPE(BADPIPE)); \ +        /* sneaky: GETPIPE is getReadPipe or getWritePipe */            \ +        /* so skip "get" to obtain ReadPipe or WritePipe  :-P  */       \ +        ensure_contains("didn't reject wrong pipe", threw, (#GETPIPE)+3); \ +        EXPECT_FAIL_WITH_LOG(threw, (PROCESS).GETOPTPIPE(BADPIPE));     \ +    } while (0) + +/// For expecting exceptions. Execute CODE, catch EXCEPTION, store its what() +/// in std::string THREW, ensure it's not empty (i.e. EXCEPTION did happen). +#define CATCH_IN(THREW, EXCEPTION, CODE)                                \ +    do                                                                  \ +    {                                                                   \ +        (THREW).clear();                                                \ +        try                                                             \ +        {                                                               \ +            CODE;                                                       \ +        }                                                               \ +        CATCH_AND_STORE_WHAT_IN(THREW, EXCEPTION)                       \ +        ensure("failed to throw " #EXCEPTION ": " #CODE, ! (THREW).empty()); \ +    } while (0) + +#define EXPECT_FAIL_WITH_LOG(EXPECT, CODE)                              \ +    do                                                                  \ +    {                                                                   \ +        TestRecorder recorder;                                          \ +        ensure(#CODE " succeeded", ! (CODE));                           \ +        ensure("wrong log message", ! recorder.messageWith(EXPECT).empty()); \ +    } while (0) + +    template<> template<> +    void object::test<15>() +    { +        set_test_name("get*Pipe() validation"); +        PythonProcessLauncher py("just stderr", +                                 "print 'this output is expected'\n"); +        py.mParams.files.add(LLProcess::FileParam("pipe")); // pipe for  stdin +        py.mParams.files.add(LLProcess::FileParam());       // inherit stdout +        py.mParams.files.add(LLProcess::FileParam("pipe")); // pipe for stderr +        py.run(); +        TEST_getPipe(*py.mPy, getWritePipe, getOptWritePipe, +                     LLProcess::STDIN,   // VALID +                     LLProcess::STDOUT,  // NOPIPE +                     LLProcess::STDERR); // BADPIPE +        TEST_getPipe(*py.mPy, getReadPipe,  getOptReadPipe, +                     LLProcess::STDERR,  // VALID +                     LLProcess::STDOUT,  // NOPIPE +                     LLProcess::STDIN);  // BADPIPE +    } + +    template<> template<> +    void object::test<16>() +    { +        set_test_name("talk to stdin/stdout"); +        PythonProcessLauncher py("stdin/stdout", +                                 "import sys, time\n" +                                 "print 'ok'\n" +                                 "sys.stdout.flush()\n" +                                 "# wait for 'go' from test program\n" +                                 "go = sys.stdin.readline()\n" +                                 "if go != 'go\\n':\n" +                                 "    sys.exit('expected \"go\", saw %r' % go)\n" +                                 "print 'ack'\n"); +        py.mParams.files.add(LLProcess::FileParam("pipe")); // stdin +        py.mParams.files.add(LLProcess::FileParam("pipe")); // stdout +        py.launch(); +        LLProcess::ReadPipe& childout(py.mPy->getReadPipe(LLProcess::STDOUT)); +        int i, timeout = 60; +        for (i = 0; i < timeout && py.mPy->isRunning() && childout.size() < 3; ++i) +        { +            yield(); +        } +        ensure("script never started", i < timeout); +        ensure_equals("bad wakeup from stdin/stdout script", +                      getline(childout.get_istream()), "ok"); +        // important to get the implicit flush from std::endl +        py.mPy->getWritePipe().get_ostream() << "go" << std::endl; +        for (i = 0; i < timeout && py.mPy->isRunning() && ! childout.contains("\n"); ++i) +        { +            yield(); +        } +        ensure("script never replied", childout.contains("\n")); +        ensure_equals("child didn't ack", getline(childout.get_istream()), "ack"); +        ensure_equals("bad child termination", py.mPy->getStatus().mState, LLProcess::EXITED); +        ensure_equals("bad child exit code",   py.mPy->getStatus().mData,  0); +    } + +    struct EventListener: public boost::noncopyable +    { +        EventListener(LLEventPump& pump) +        { +            mConnection =  +                pump.listen("EventListener", boost::bind(&EventListener::tick, this, _1)); +        } + +        bool tick(const LLSD& data) +        { +            mHistory.push_back(data); +            return false; +        } + +        std::list<LLSD> mHistory; +        LLTempBoundListener mConnection; +    }; + +    static bool ack(std::ostream& out, const LLSD& data) +    { +        out << "continue" << std::endl; +        return false; +    } + +    template<> template<> +    void object::test<17>() +    { +        set_test_name("listen for ReadPipe events"); +        PythonProcessLauncher py("ReadPipe listener", +                                 "import sys\n" +                                 "sys.stdout.write('abc')\n" +                                 "sys.stdout.flush()\n" +                                 "sys.stdin.readline()\n" +                                 "sys.stdout.write('def')\n" +                                 "sys.stdout.flush()\n" +                                 "sys.stdin.readline()\n" +                                 "sys.stdout.write('ghi\\n')\n" +                                 "sys.stdout.flush()\n" +                                 "sys.stdin.readline()\n" +                                 "sys.stdout.write('second line\\n')\n"); +        py.mParams.files.add(LLProcess::FileParam("pipe")); // stdin +        py.mParams.files.add(LLProcess::FileParam("pipe")); // stdout +        py.launch(); +        std::ostream& childin(py.mPy->getWritePipe(LLProcess::STDIN).get_ostream()); +        LLProcess::ReadPipe& childout(py.mPy->getReadPipe(LLProcess::STDOUT)); +        // lift the default limit; allow event to carry (some of) the actual data +        childout.setLimit(20); +        // listen for incoming data on childout +        EventListener listener(childout.getPump()); +        // also listen with a function that prompts the child to continue +        // every time we see output +        LLTempBoundListener connection( +            childout.getPump().listen("ack", boost::bind(ack, boost::ref(childin), _1))); +        int i, timeout = 60; +        // wait through stuttering first line +        for (i = 0; i < timeout && py.mPy->isRunning() && ! childout.contains("\n"); ++i) +        { +            yield(); +        } +        ensure("couldn't get first line", i < timeout); +        // disconnect from listener +        listener.mConnection.disconnect(); +        // finish out the run +        waitfor(*py.mPy); +        // now verify history +        std::list<LLSD>::const_iterator li(listener.mHistory.begin()), +                                        lend(listener.mHistory.end()); +        ensure("no events", li != lend); +        ensure_equals("history[0]", (*li)["data"].asString(), "abc"); +        ensure_equals("history[0] len", (*li)["len"].asInteger(), 3); +        ++li; +        ensure("only 1 event", li != lend); +        ensure_equals("history[1]", (*li)["data"].asString(), "abcdef"); +        ensure_equals("history[0] len", (*li)["len"].asInteger(), 6); +        ++li; +        ensure("only 2 events", li != lend); +        ensure_equals("history[2]", (*li)["data"].asString(), "abcdefghi" EOL); +        ensure_equals("history[0] len", (*li)["len"].asInteger(), 9 + sizeof(EOL) - 1); +        ++li; +        // We DO NOT expect a whole new event for the second line because we +        // disconnected. +        ensure("more than 3 events", li == lend); +    } + +    template<> template<> +    void object::test<18>() +    { +        set_test_name("setLimit()"); +        PythonProcessLauncher py("setLimit()", +                                 "import sys\n" +                                 "sys.stdout.write(sys.argv[1])\n"); +        std::string abc("abcdefghijklmnopqrstuvwxyz"); +        py.mParams.args.add(abc); +        py.mParams.files.add(LLProcess::FileParam()); // stdin +        py.mParams.files.add(LLProcess::FileParam("pipe")); // stdout +        py.launch(); +        LLProcess::ReadPipe& childout(py.mPy->getReadPipe(LLProcess::STDOUT)); +        // listen for incoming data on childout +        EventListener listener(childout.getPump()); +        // but set limit +        childout.setLimit(10); +        ensure_equals("getLimit() after setlimit(10)", childout.getLimit(), 10); +        // okay, pump I/O to pick up output from child +        waitfor(*py.mPy); +        ensure("no events", ! listener.mHistory.empty()); +        // For all we know, that data could have arrived in several different +        // bursts... probably not, but anyway, only check the last one. +        ensure_equals("event[\"len\"]", +                      listener.mHistory.back()["len"].asInteger(), abc.length()); +        ensure_equals("length of setLimit(10) data", +                      listener.mHistory.back()["data"].asString().length(), 10); +    } + +    template<> template<> +    void object::test<19>() +    { +        set_test_name("peek() ReadPipe data"); +        PythonProcessLauncher py("peek() ReadPipe", +                                 "import sys\n" +                                 "sys.stdout.write(sys.argv[1])\n"); +        std::string abc("abcdefghijklmnopqrstuvwxyz"); +        py.mParams.args.add(abc); +        py.mParams.files.add(LLProcess::FileParam()); // stdin +        py.mParams.files.add(LLProcess::FileParam("pipe")); // stdout +        py.launch(); +        LLProcess::ReadPipe& childout(py.mPy->getReadPipe(LLProcess::STDOUT)); +        // okay, pump I/O to pick up output from child +        waitfor(*py.mPy); +        // peek() with substr args +        ensure_equals("peek()", childout.peek(), abc); +        ensure_equals("peek(23)", childout.peek(23), abc.substr(23)); +        ensure_equals("peek(5, 3)", childout.peek(5, 3), abc.substr(5, 3)); +        ensure_equals("peek(27, 2)", childout.peek(27, 2), ""); +        ensure_equals("peek(23, 5)", childout.peek(23, 5), "xyz"); +        // contains() -- we don't exercise as thoroughly as find() because the +        // contains() implementation is trivially (and visibly) based on find() +        ensure("contains(\":\")", ! childout.contains(":")); +        ensure("contains(':')",   ! childout.contains(':')); +        ensure("contains(\"d\")", childout.contains("d")); +        ensure("contains('d')",   childout.contains('d')); +        ensure("contains(\"klm\")", childout.contains("klm")); +        ensure("contains(\"klx\")", ! childout.contains("klx")); +        // find() +        ensure("find(\":\")", childout.find(":") == LLProcess::ReadPipe::npos); +        ensure("find(':')",   childout.find(':') == LLProcess::ReadPipe::npos); +        ensure_equals("find(\"d\")", childout.find("d"), 3); +        ensure_equals("find('d')",   childout.find('d'), 3); +        ensure_equals("find(\"d\", 3)", childout.find("d", 3), 3); +        ensure_equals("find('d', 3)",   childout.find('d', 3), 3); +        ensure("find(\"d\", 4)", childout.find("d", 4) == LLProcess::ReadPipe::npos); +        ensure("find('d', 4)",   childout.find('d', 4) == LLProcess::ReadPipe::npos); +        // The case of offset == end and offset > end are different. In the +        // first case, we can form a valid (albeit empty) iterator range and +        // search that. In the second, guard logic in the implementation must +        // realize we can't form a valid iterator range. +        ensure("find(\"d\", 26)", childout.find("d", 26) == LLProcess::ReadPipe::npos); +        ensure("find('d', 26)",   childout.find('d', 26) == LLProcess::ReadPipe::npos); +        ensure("find(\"d\", 27)", childout.find("d", 27) == LLProcess::ReadPipe::npos); +        ensure("find('d', 27)",   childout.find('d', 27) == LLProcess::ReadPipe::npos); +        ensure_equals("find(\"ghi\")", childout.find("ghi"), 6); +        ensure_equals("find(\"ghi\", 6)", childout.find("ghi"), 6); +        ensure("find(\"ghi\", 7)", childout.find("ghi", 7) == LLProcess::ReadPipe::npos); +        ensure("find(\"ghi\", 26)", childout.find("ghi", 26) == LLProcess::ReadPipe::npos); +        ensure("find(\"ghi\", 27)", childout.find("ghi", 27) == LLProcess::ReadPipe::npos); +    } + +    template<> template<> +    void object::test<20>() +    { +        set_test_name("good postend"); +        PythonProcessLauncher py("postend", +                                 "import sys\n" +                                 "sys.exit(35)\n"); +        std::string pumpname("postend"); +        EventListener listener(LLEventPumps::instance().obtain(pumpname)); +        py.mParams.postend = pumpname; +        py.launch(); +        LLProcess::id childid(py.mPy->getProcessID()); +        // Don't use waitfor(), which calls isRunning(); instead wait for an +        // event on pumpname. +        int i, timeout = 60; +        for (i = 0; i < timeout && listener.mHistory.empty(); ++i) +        { +            yield(); +        } +        ensure("no postend event", i < timeout); +        ensure_equals("number of postend events", listener.mHistory.size(), 1); +        LLSD postend(listener.mHistory.front()); +        ensure_equals("id",    postend["id"].asInteger(), childid); +        ensure("desc empty", ! postend["desc"].asString().empty()); +        ensure_equals("state", postend["state"].asInteger(), LLProcess::EXITED); +        ensure_equals("data",  postend["data"].asInteger(),  35); +        std::string str(postend["string"]); +        ensure_contains("string", str, "exited"); +        ensure_contains("string", str, "35"); +    } + +    template<> template<> +    void object::test<21>() +    { +        set_test_name("bad postend"); +        std::string pumpname("postend"); +        EventListener listener(LLEventPumps::instance().obtain(pumpname)); +        LLProcess::Params params; +        params.desc = "bad postend"; +        params.postend = pumpname; +        LLProcessPtr child = LLProcess::create(params); +        ensure("shouldn't have launched", ! child); +        ensure_equals("number of postend events", listener.mHistory.size(), 1); +        LLSD postend(listener.mHistory.front()); +        ensure("has id", ! postend.has("id")); +        ensure_equals("desc", postend["desc"].asString(), std::string(params.desc)); +        ensure_equals("state", postend["state"].asInteger(), LLProcess::UNSTARTED); +        ensure("has data", ! postend.has("data")); +        std::string error(postend["string"]); +        // All we get from canned parameter validation is a bool, so the +        // "validation failed" message we ourselves generate can't mention +        // "executable" by name. Just check that it's nonempty. +        //ensure_contains("error", error, "executable"); +        ensure("string", ! error.empty()); +    } + +    // TODO: +    // test EOF -- check logging + +} // namespace tut diff --git a/indra/llcommon/tests/llsdserialize_test.cpp b/indra/llcommon/tests/llsdserialize_test.cpp index 72322c3b72..e625545763 100644 --- a/indra/llcommon/tests/llsdserialize_test.cpp +++ b/indra/llcommon/tests/llsdserialize_test.cpp @@ -40,41 +40,15 @@ typedef U32 uint32_t;  #include <fcntl.h>  #include <sys/stat.h>  #include <sys/wait.h> -#include "llprocesslauncher.h" +#include "llprocess.h"  #endif -#include <sstream> - -/*==========================================================================*| -// Whoops, seems Linden's Boost package and the viewer are built with -// different settings of VC's /Zc:wchar_t switch! Using Boost.Filesystem -// pathname operations produces Windows link errors: -// unresolved external symbol "private: static class std::codecvt<unsigned short, -// char,int> const * & __cdecl boost::filesystem3::path::wchar_t_codecvt_facet()" -// unresolved external symbol "void __cdecl boost::filesystem3::path_traits::convert()" -// See: -// http://boost.2283326.n4.nabble.com/filesystem-v3-unicode-and-std-codecvt-linker-error-td3455549.html -// which points to: -// http://msdn.microsoft.com/en-us/library/dh8che7s%28v=VS.100%29.aspx - -// As we're not trying to preserve compatibility with old Boost.Filesystem -// code, but rather writing brand-new code, use the newest available -// Filesystem API. -#define BOOST_FILESYSTEM_VERSION 3 -#include "boost/filesystem.hpp" -#include "boost/filesystem/v3/fstream.hpp" -|*==========================================================================*/  #include "boost/range.hpp"  #include "boost/foreach.hpp"  #include "boost/function.hpp"  #include "boost/lambda/lambda.hpp"  #include "boost/lambda/bind.hpp"  namespace lambda = boost::lambda; -/*==========================================================================*| -// Aaaarrgh, Linden's Boost package doesn't even include Boost.Iostreams! -#include "boost/iostreams/stream.hpp" -#include "boost/iostreams/device/file_descriptor.hpp" -|*==========================================================================*/  #include "../llsd.h"  #include "../llsdserialize.h" @@ -82,236 +56,17 @@ namespace lambda = boost::lambda;  #include "../llformat.h"  #include "../test/lltut.h" +#include "../test/manageapr.h" +#include "../test/namedtempfile.h"  #include "stringize.h" +static ManageAPR manager; +  std::vector<U8> string_to_vector(const std::string& str)  {  	return std::vector<U8>(str.begin(), str.end());  } -#if ! LL_WINDOWS -// We want to call strerror_r(), but alarmingly, there are two different -// variants. The one that returns int always populates the passed buffer -// (except in case of error), whereas the other one always returns a valid -// char* but might or might not populate the passed buffer. How do we know -// which one we're getting? Define adapters for each and let the compiler -// select the applicable adapter. - -// strerror_r() returns char* -std::string message_from(int /*orig_errno*/, const char* /*buffer*/, const char* strerror_ret) -{ -    return strerror_ret; -} - -// strerror_r() returns int -std::string message_from(int orig_errno, const char* buffer, int strerror_ret) -{ -    if (strerror_ret == 0) -    { -        return buffer; -    } -    // Here strerror_r() has set errno. Since strerror_r() has already failed, -    // seems like a poor bet to call it again to diagnose its own error... -    int stre_errno = errno; -    if (stre_errno == ERANGE) -    { -        return STRINGIZE("strerror_r() can't explain errno " << orig_errno -                         << " (buffer too small)"); -    } -    if (stre_errno == EINVAL) -    { -        return STRINGIZE("unknown errno " << orig_errno); -    } -    // Here we don't even understand the errno from strerror_r()! -    return STRINGIZE("strerror_r() can't explain errno " << orig_errno -                     << " (error " << stre_errno << ')'); -} -#endif  // ! LL_WINDOWS - -// boost::filesystem::temp_directory_path() isn't yet in Boost 1.45! :-( -std::string temp_directory_path() -{ -#if LL_WINDOWS -    char buffer[4096]; -    GetTempPathA(sizeof(buffer), buffer); -    return buffer; - -#else  // LL_DARWIN, LL_LINUX -    static const char* vars[] = { "TMPDIR", "TMP", "TEMP", "TEMPDIR" }; -    BOOST_FOREACH(const char* var, vars) -    { -        const char* found = getenv(var); -        if (found) -            return found; -    } -    return "/tmp"; -#endif // LL_DARWIN, LL_LINUX -} - -// Windows presents a kinda sorta compatibility layer. Code to the yucky -// Windows names because they're less likely than the Posix names to collide -// with any other names in this source. -#if LL_WINDOWS -#define _remove   DeleteFileA -#else  // ! LL_WINDOWS -#define _open     open -#define _write    write -#define _close    close -#define _remove   remove -#endif  // ! LL_WINDOWS - -// Create a text file with specified content "somewhere in the -// filesystem," cleaning up when it goes out of scope. -class NamedTempFile -{ -public: -    // Function that accepts an ostream ref and (presumably) writes stuff to -    // it, e.g.: -    // (lambda::_1 << "the value is " << 17 << '\n') -    typedef boost::function<void(std::ostream&)> Streamer; - -    NamedTempFile(const std::string& ext, const std::string& content): -        mPath(temp_directory_path()) -    { -        createFile(ext, lambda::_1 << content); -    } - -    // Disambiguate when passing string literal -    NamedTempFile(const std::string& ext, const char* content): -        mPath(temp_directory_path()) -    { -        createFile(ext, lambda::_1 << content); -    } - -    NamedTempFile(const std::string& ext, const Streamer& func): -        mPath(temp_directory_path()) -    { -        createFile(ext, func); -    } - -    ~NamedTempFile() -    { -        _remove(mPath.c_str()); -    } - -    std::string getName() const { return mPath; } - -private: -    void createFile(const std::string& ext, const Streamer& func) -    { -        // Silly maybe, but use 'ext' as the name prefix. Strip off a leading -        // '.' if present. -        int pfx_offset = ((! ext.empty()) && ext[0] == '.')? 1 : 0; - -#if ! LL_WINDOWS -        // Make sure mPath ends with a directory separator, if it doesn't already. -        if (mPath.empty() || -            ! (mPath[mPath.length() - 1] == '\\' || mPath[mPath.length() - 1] == '/')) -        { -            mPath.append("/"); -        } - -        // mkstemp() accepts and modifies a char* template string. Generate -        // the template string, then copy to modifiable storage. -        // mkstemp() requires its template string to end in six X's. -        mPath += ext.substr(pfx_offset) + "XXXXXX"; -        // Copy to vector<char> -        std::vector<char> pathtemplate(mPath.begin(), mPath.end()); -        // append a nul byte for classic-C semantics -        pathtemplate.push_back('\0'); -        // std::vector promises that a pointer to the 0th element is the same -        // as a pointer to a contiguous classic-C array -        int fd(mkstemp(&pathtemplate[0])); -        if (fd == -1) -        { -            // The documented errno values (http://linux.die.net/man/3/mkstemp) -            // are used in a somewhat unusual way, so provide context-specific -            // errors. -            if (errno == EEXIST) -            { -                LL_ERRS("NamedTempFile") << "mkstemp(\"" << mPath -                                         << "\") could not create unique file " << LL_ENDL; -            } -            if (errno == EINVAL) -            { -                LL_ERRS("NamedTempFile") << "bad mkstemp() file path template '" -                                         << mPath << "'" << LL_ENDL; -            } -            // Shrug, something else -            int mkst_errno = errno; -            char buffer[256]; -            LL_ERRS("NamedTempFile") << "mkstemp(\"" << mPath << "\") failed: " -                                     << message_from(mkst_errno, buffer, -                                                     strerror_r(mkst_errno, buffer, sizeof(buffer))) -                                     << LL_ENDL; -        } -        // mkstemp() seems to have worked! Capture the modified filename. -        // Avoid the nul byte we appended. -        mPath.assign(pathtemplate.begin(), (pathtemplate.end()-1)); - -/*==========================================================================*| -        // Define an ostream on the open fd. Tell it to close fd on destruction. -        boost::iostreams::stream<boost::iostreams::file_descriptor_sink> -            out(fd, boost::iostreams::close_handle); -|*==========================================================================*/ - -        // Write desired content. -        std::ostringstream out; -        // Stream stuff to it. -        func(out); - -        std::string data(out.str()); -        int written(_write(fd, data.c_str(), data.length())); -        int closed(_close(fd)); -        llassert_always(written == data.length() && closed == 0); - -#else // LL_WINDOWS -        // GetTempFileName() is documented to require a MAX_PATH buffer. -        char tempname[MAX_PATH]; -        // Use 'ext' as filename prefix, but skip leading '.' if any. -        // The 0 param is very important: requests iterating until we get a -        // unique name. -        if (0 == GetTempFileNameA(mPath.c_str(), ext.c_str() + pfx_offset, 0, tempname)) -        { -            // I always have to look up this call...  :-P -            LPSTR msgptr; -            FormatMessageA( -                FORMAT_MESSAGE_ALLOCATE_BUFFER |  -                FORMAT_MESSAGE_FROM_SYSTEM | -                FORMAT_MESSAGE_IGNORE_INSERTS, -                NULL, -                GetLastError(), -                MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), -                LPSTR(&msgptr),     // have to cast (char**) to (char*) -                0, NULL ); -            LL_ERRS("NamedTempFile") << "GetTempFileName(\"" << mPath << "\", \"" -                                     << (ext.c_str() + pfx_offset) << "\") failed: " -                                     << msgptr << LL_ENDL; -            LocalFree(msgptr); -        } -        // GetTempFileName() appears to have worked! Capture the actual -        // filename. -        mPath = tempname; -        // Open the file and stream content to it. Destructor will close. -        std::ofstream out(tempname); -        func(out); - -#endif  // LL_WINDOWS -    } - -    void peep() -    { -        std::cout << "File '" << mPath << "' contains:\n"; -        std::ifstream reader(mPath.c_str()); -        std::string line; -        while (std::getline(reader, line)) -            std::cout << line << '\n'; -        std::cout << "---\n"; -    } - -    std::string mPath; -}; -  namespace tut  {  	struct sd_xml_data @@ -1783,7 +1538,7 @@ namespace tut              const char* PYTHON(getenv("PYTHON"));              ensure("Set $PYTHON to the Python interpreter", PYTHON); -            NamedTempFile scriptfile(".py", script); +            NamedTempFile scriptfile("py", script);  #if LL_WINDOWS              std::string q("\""); @@ -1802,14 +1557,15 @@ namespace tut              }  #else  // LL_DARWIN, LL_LINUX -            LLProcessLauncher py; -            py.setExecutable(PYTHON); -            py.addArgument(scriptfile.getName()); -            ensure_equals(STRINGIZE("Couldn't launch " << desc << " script"), py.launch(), 0); +            LLProcess::Params params; +            params.executable = PYTHON; +            params.args.add(scriptfile.getName()); +            LLProcessPtr py(LLProcess::create(params)); +            ensure(STRINGIZE("Couldn't launch " << desc << " script"), py);              // Implementing timeout would mean messing with alarm() and              // catching SIGALRM... later maybe...              int status(0); -            if (waitpid(py.getProcessID(), &status, 0) == -1) +            if (waitpid(py->getProcessID(), &status, 0) == -1)              {                  int waitpid_errno(errno);                  ensure_equals(STRINGIZE("Couldn't retrieve rc from " << desc << " script: " @@ -1888,12 +1644,12 @@ namespace tut              "    else:\n"              "        assert False, 'Too many data items'\n"; -        // Create a something.llsd file containing 'data' serialized to +        // Create an llsdXXXXXX file containing 'data' serialized to          // notation. It's important to separate with newlines because Python's          // llsd module doesn't support parsing from a file stream, only from a          // string, so we have to know how much of the file to read into a          // string. -        NamedTempFile file(".llsd", +        NamedTempFile file("llsd",                             // NamedTempFile's boost::function constructor                             // takes a callable. To this callable it passes the                             // std::ostream with which it's writing the @@ -1926,7 +1682,7 @@ namespace tut          // Create an empty data file. This is just a placeholder for our          // script to write into. Create it to establish a unique name that          // we know. -        NamedTempFile file(".llsd", ""); +        NamedTempFile file("llsd", "");          python("write Python notation",                 lambda::_1 << diff --git a/indra/llcommon/tests/llstreamqueue_test.cpp b/indra/llcommon/tests/llstreamqueue_test.cpp new file mode 100644 index 0000000000..050ad5c5bf --- /dev/null +++ b/indra/llcommon/tests/llstreamqueue_test.cpp @@ -0,0 +1,197 @@ +/** + * @file   llstreamqueue_test.cpp + * @author Nat Goodspeed + * @date   2012-01-05 + * @brief  Test for llstreamqueue. + *  + * $LicenseInfo:firstyear=2012&license=viewerlgpl$ + * Copyright (c) 2012, Linden Research, Inc. + * $/LicenseInfo$ + */ + +// Precompiled header +#include "linden_common.h" +// associated header +#include "llstreamqueue.h" +// STL headers +#include <vector> +// std headers +// external library headers +#include <boost/foreach.hpp> +// other Linden headers +#include "../test/lltut.h" +#include "stringize.h" + +/***************************************************************************** +*   TUT +*****************************************************************************/ +namespace tut +{ +    struct llstreamqueue_data +    { +        llstreamqueue_data(): +            // we want a buffer with actual bytes in it, not an empty vector +            buffer(10) +        {} +        // As LLStreamQueue is merely a typedef for +        // LLGenericStreamQueue<char>, and no logic in LLGenericStreamQueue is +        // specific to the <char> instantiation, we're comfortable for now +        // testing only the narrow-char version. +        LLStreamQueue strq; +        // buffer for use in multiple tests +        std::vector<char> buffer; +    }; +    typedef test_group<llstreamqueue_data> llstreamqueue_group; +    typedef llstreamqueue_group::object object; +    llstreamqueue_group llstreamqueuegrp("llstreamqueue"); + +    template<> template<> +    void object::test<1>() +    { +        set_test_name("empty LLStreamQueue"); +        ensure_equals("brand-new LLStreamQueue isn't empty", +                      strq.size(), 0); +        ensure_equals("brand-new LLStreamQueue returns data", +                      strq.asSource().read(&buffer[0], buffer.size()), 0); +        strq.asSink().close(); +        ensure_equals("closed empty LLStreamQueue not at EOF", +                      strq.asSource().read(&buffer[0], buffer.size()), -1); +    } + +    template<> template<> +    void object::test<2>() +    { +        set_test_name("one internal block, one buffer"); +        LLStreamQueue::Sink sink(strq.asSink()); +        ensure_equals("write(\"\")", sink.write("", 0), 0); +        ensure_equals("0 write should leave LLStreamQueue empty (size())", +                      strq.size(), 0); +        ensure_equals("0 write should leave LLStreamQueue empty (peek())", +                      strq.peek(&buffer[0], buffer.size()), 0); +        // The meaning of "atomic" is that it must be smaller than our buffer. +        std::string atomic("atomic"); +        ensure("test data exceeds buffer", atomic.length() < buffer.size()); +        ensure_equals(STRINGIZE("write(\"" << atomic << "\")"), +                      sink.write(&atomic[0], atomic.length()), atomic.length()); +        ensure_equals("size() after write()", strq.size(), atomic.length()); +        size_t peeklen(strq.peek(&buffer[0], buffer.size())); +        ensure_equals(STRINGIZE("peek(\"" << atomic << "\")"), +                      peeklen, atomic.length()); +        ensure_equals(STRINGIZE("peek(\"" << atomic << "\") result"), +                      std::string(buffer.begin(), buffer.begin() + peeklen), atomic); +        ensure_equals("size() after peek()", strq.size(), atomic.length()); +        // peek() should not consume. Use a different buffer to prove it isn't +        // just leftover data from the first peek(). +        std::vector<char> again(buffer.size()); +        peeklen = size_t(strq.peek(&again[0], again.size())); +        ensure_equals(STRINGIZE("peek(\"" << atomic << "\") again"), +                      peeklen, atomic.length()); +        ensure_equals(STRINGIZE("peek(\"" << atomic << "\") again result"), +                      std::string(again.begin(), again.begin() + peeklen), atomic); +        // now consume. +        std::vector<char> third(buffer.size()); +        size_t readlen(strq.read(&third[0], third.size())); +        ensure_equals(STRINGIZE("read(\"" << atomic << "\")"), +                      readlen, atomic.length()); +        ensure_equals(STRINGIZE("read(\"" << atomic << "\") result"), +                      std::string(third.begin(), third.begin() + readlen), atomic); +        ensure_equals("peek() after read()", strq.peek(&buffer[0], buffer.size()), 0); +        ensure_equals("size() after read()", strq.size(), 0); +    } + +    template<> template<> +    void object::test<3>() +    { +        set_test_name("basic skip()"); +        std::string lovecraft("lovecraft"); +        ensure("test data exceeds buffer", lovecraft.length() < buffer.size()); +        ensure_equals(STRINGIZE("write(\"" << lovecraft << "\")"), +                      strq.write(&lovecraft[0], lovecraft.length()), lovecraft.length()); +        size_t peeklen(strq.peek(&buffer[0], buffer.size())); +        ensure_equals(STRINGIZE("peek(\"" << lovecraft << "\")"), +                      peeklen, lovecraft.length()); +        ensure_equals(STRINGIZE("peek(\"" << lovecraft << "\") result"), +                      std::string(buffer.begin(), buffer.begin() + peeklen), lovecraft); +        std::streamsize skip1(4); +        ensure_equals(STRINGIZE("skip(" << skip1 << ")"), strq.skip(skip1), skip1); +        ensure_equals("size() after skip()", strq.size(), lovecraft.length() - skip1); +        size_t readlen(strq.read(&buffer[0], buffer.size())); +        ensure_equals(STRINGIZE("read(\"" << lovecraft.substr(skip1) << "\")"), +                      readlen, lovecraft.length() - skip1); +        ensure_equals(STRINGIZE("read(\"" << lovecraft.substr(skip1) << "\") result"), +                      std::string(buffer.begin(), buffer.begin() + readlen), +                      lovecraft.substr(skip1)); +        ensure_equals("unconsumed", strq.read(&buffer[0], buffer.size()), 0); +    } + +    template<> template<> +    void object::test<4>() +    { +        set_test_name("skip() multiple blocks"); +        std::string blocks[] = { "books of ", "H.P. ", "Lovecraft" }; +        std::streamsize total(blocks[0].length() + blocks[1].length() + blocks[2].length()); +        std::streamsize leave(5);   // len("craft") above +        std::streamsize skip(total - leave); +        std::streamsize written(0); +        BOOST_FOREACH(const std::string& block, blocks) +        { +            written += strq.write(&block[0], block.length()); +            ensure_equals("size() after write()", strq.size(), written); +        } +        std::streamsize skiplen(strq.skip(skip)); +        ensure_equals(STRINGIZE("skip(" << skip << ")"), skiplen, skip); +        ensure_equals("size() after skip()", strq.size(), leave); +        size_t readlen(strq.read(&buffer[0], buffer.size())); +        ensure_equals("read(\"craft\")", readlen, leave); +        ensure_equals("read(\"craft\") result", +                      std::string(buffer.begin(), buffer.begin() + readlen), "craft"); +    } + +    template<> template<> +    void object::test<5>() +    { +        set_test_name("concatenate blocks"); +        std::string blocks[] = { "abcd", "efghij", "klmnopqrs" }; +        BOOST_FOREACH(const std::string& block, blocks) +        { +            strq.write(&block[0], block.length()); +        } +        std::vector<char> longbuffer(30); +        std::streamsize readlen(strq.read(&longbuffer[0], longbuffer.size())); +        ensure_equals("read() multiple blocks", +                      readlen, blocks[0].length() + blocks[1].length() + blocks[2].length()); +        ensure_equals("read() multiple blocks result", +                      std::string(longbuffer.begin(), longbuffer.begin() + readlen), +                      blocks[0] + blocks[1] + blocks[2]); +    } + +    template<> template<> +    void object::test<6>() +    { +        set_test_name("split blocks"); +        std::string blocks[] = { "abcdefghijklm", "nopqrstuvwxyz" }; +        BOOST_FOREACH(const std::string& block, blocks) +        { +            strq.write(&block[0], block.length()); +        } +        strq.close(); +        // We've already verified what strq.size() should be at this point; +        // see above test named "skip() multiple blocks" +        std::streamsize chksize(strq.size()); +        std::streamsize readlen(strq.read(&buffer[0], buffer.size())); +        ensure_equals("read() 0", readlen, buffer.size()); +        ensure_equals("read() 0 result", std::string(buffer.begin(), buffer.end()), "abcdefghij"); +        chksize -= readlen; +        ensure_equals("size() after read() 0", strq.size(), chksize); +        readlen = strq.read(&buffer[0], buffer.size()); +        ensure_equals("read() 1", readlen, buffer.size()); +        ensure_equals("read() 1 result", std::string(buffer.begin(), buffer.end()), "klmnopqrst"); +        chksize -= readlen; +        ensure_equals("size() after read() 1", strq.size(), chksize); +        readlen = strq.read(&buffer[0], buffer.size()); +        ensure_equals("read() 2", readlen, chksize); +        ensure_equals("read() 2 result", +                      std::string(buffer.begin(), buffer.begin() + readlen), "uvwxyz"); +        ensure_equals("read() 3", strq.read(&buffer[0], buffer.size()), -1); +    } +} // namespace tut diff --git a/indra/llcommon/tests/llstring_test.cpp b/indra/llcommon/tests/llstring_test.cpp index 6a1cbf652a..93d3968dbf 100644 --- a/indra/llcommon/tests/llstring_test.cpp +++ b/indra/llcommon/tests/llstring_test.cpp @@ -29,7 +29,11 @@  #include "linden_common.h"  #include "../test/lltut.h" +#include <boost/assign/list_of.hpp>  #include "../llstring.h" +#include "StringVec.h" + +using boost::assign::list_of;  namespace tut  { @@ -750,4 +754,118 @@ namespace tut  		ensure("empty substr.", !LLStringUtil::endsWith(empty, value));  		ensure("empty everything.", !LLStringUtil::endsWith(empty, empty));  	} + +	template<> template<> +	void string_index_object_t::test<41>() +	{ +		set_test_name("getTokens(\"delims\")"); +		ensure_equals("empty string", LLStringUtil::getTokens("", " "), StringVec()); +		ensure_equals("only delims", +					  LLStringUtil::getTokens("   \r\n   ", " \r\n"), StringVec()); +		ensure_equals("sequence of delims", +					  LLStringUtil::getTokens(",,, one ,,,", ","), list_of("one")); +		// nat considers this a dubious implementation side effect, but I'd +		// hate to change it now... +		ensure_equals("noncontiguous tokens", +					  LLStringUtil::getTokens(", ,, , one ,,,", ","), list_of("")("")("one")); +		ensure_equals("space-padded tokens", +					  LLStringUtil::getTokens(",    one  ,  two  ,", ","), list_of("one")("two")); +		ensure_equals("no delims", LLStringUtil::getTokens("one", ","), list_of("one")); +	} + +	// Shorthand for verifying that getTokens() behaves the same when you +	// don't pass a string of escape characters, when you pass an empty string +	// (different overloads), and when you pass a string of characters that +	// aren't actually present. +	void ensure_getTokens(const std::string& desc, +						  const std::string& string, +						  const std::string& drop_delims, +						  const std::string& keep_delims, +						  const std::string& quotes, +						  const std::vector<std::string>& expect) +	{ +		ensure_equals(desc + " - no esc", +					  LLStringUtil::getTokens(string, drop_delims, keep_delims, quotes), +					  expect); +		ensure_equals(desc + " - empty esc", +					  LLStringUtil::getTokens(string, drop_delims, keep_delims, quotes, ""), +					  expect); +		ensure_equals(desc + " - unused esc", +					  LLStringUtil::getTokens(string, drop_delims, keep_delims, quotes, "!"), +					  expect); +	} + +	void ensure_getTokens(const std::string& desc, +						  const std::string& string, +						  const std::string& drop_delims, +						  const std::string& keep_delims, +						  const std::vector<std::string>& expect) +	{ +		ensure_getTokens(desc, string, drop_delims, keep_delims, "", expect); +	} + +	template<> template<> +	void string_index_object_t::test<42>() +	{ +		set_test_name("getTokens(\"delims\", etc.)"); +		// Signatures to test in this method: +		// getTokens(string, drop_delims, keep_delims [, quotes [, escapes]]) +		// If you omit keep_delims, you get the older function (test above). + +		// cases like the getTokens(string, delims) tests above +		ensure_getTokens("empty string", "", " ", "", StringVec()); +		ensure_getTokens("only delims", +						 "   \r\n   ", " \r\n", "", StringVec()); +		ensure_getTokens("sequence of delims", +						 ",,, one ,,,", ", ", "", list_of("one")); +		// Note contrast with the case in the previous method +		ensure_getTokens("noncontiguous tokens", +						 ", ,, , one ,,,", ", ", "", list_of("one")); +		ensure_getTokens("space-padded tokens", +						 ",    one  ,  two  ,", ", ", "", +                         list_of("one")("two")); +		ensure_getTokens("no delims", "one", ",", "", list_of("one")); + +		// drop_delims vs. keep_delims +		ensure_getTokens("arithmetic", +						 " ab+def  / xx*  yy ", " ", "+-*/", +						 list_of("ab")("+")("def")("/")("xx")("*")("yy")); + +		// quotes +		ensure_getTokens("no quotes", +						 "She said, \"Don't go.\"", " ", ",", "", +						 list_of("She")("said")(",")("\"Don't")("go.\"")); +		ensure_getTokens("quotes", +						 "She said, \"Don't go.\"", " ", ",", "\"", +						 list_of("She")("said")(",")("Don't go.")); +		ensure_getTokens("quotes and delims", +						 "run c:/'Documents and Settings'/someone", " ", "", "'", +						 list_of("run")("c:/Documents and Settings/someone")); +		ensure_getTokens("unmatched quote", +						 "baby don't leave", " ", "", "'", +						 list_of("baby")("don't")("leave")); +		ensure_getTokens("adjacent quoted", +						 "abc'def \"ghi'\"jkl' mno\"pqr", " ", "", "\"'", +						 list_of("abcdef \"ghijkl' mnopqr")); +		ensure_getTokens("quoted empty string", +						 "--set SomeVar ''", " ", "", "'", +						 list_of("--set")("SomeVar")("")); + +		// escapes +		// Don't use backslash as an escape for these tests -- you'll go nuts +		// between the C++ string scanner and getTokens() escapes. Test with +		// something else! +		ensure_equals("escaped delims", +					  LLStringUtil::getTokens("^ a - dog^-gone^ phrase", " ", "-", "", "^"), +					  list_of(" a")("-")("dog-gone phrase")); +		ensure_equals("escaped quotes", +					  LLStringUtil::getTokens("say: 'this isn^'t w^orking'.", " ", "", "'", "^"), +					  list_of("say:")("this isn't working.")); +		ensure_equals("escaped escape", +					  LLStringUtil::getTokens("want x^^2", " ", "", "", "^"), +					  list_of("want")("x^2")); +		ensure_equals("escape at end", +					  LLStringUtil::getTokens("it's^ up there^", " ", "", "'", "^"), +					  list_of("it's up")("there^")); +    }  } diff --git a/indra/llcommon/tests/setpython.py b/indra/llcommon/tests/setpython.py deleted file mode 100644 index df7b90428e..0000000000 --- a/indra/llcommon/tests/setpython.py +++ /dev/null @@ -1,19 +0,0 @@ -#!/usr/bin/python -"""\ -@file   setpython.py -@author Nat Goodspeed -@date   2011-07-13 -@brief  Set PYTHON environment variable for tests that care. - -$LicenseInfo:firstyear=2011&license=viewerlgpl$ -Copyright (c) 2011, Linden Research, Inc. -$/LicenseInfo$ -""" - -import os -import sys -import subprocess - -if __name__ == "__main__": -    os.environ["PYTHON"] = sys.executable -    sys.exit(subprocess.call(sys.argv[1:])) | 
