diff options
| author | Andrey Lihatskiy <alihatskiy@productengine.com> | 2025-06-03 13:25:02 +0300 | 
|---|---|---|
| committer | Andrey Lihatskiy <alihatskiy@productengine.com> | 2025-06-03 14:04:58 +0300 | 
| commit | b322b3f6f11d6eb9d4113cf1b344d05daf2c1be0 (patch) | |
| tree | 3d7df55a9daa47d86e6ba1e93727250c5911807b /indra | |
| parent | 4ae9b7b24564a5d50360781d2b63f73a6aa2141c (diff) | |
#4097 Fix crash in LLGLTFLoader::populateModelFromMesh()
Diffstat (limited to 'indra')
| -rw-r--r-- | indra/newview/gltf/llgltfloader.cpp | 15 | 
1 files changed, 12 insertions, 3 deletions
| diff --git a/indra/newview/gltf/llgltfloader.cpp b/indra/newview/gltf/llgltfloader.cpp index 800b986b59..4d705279a5 100644 --- a/indra/newview/gltf/llgltfloader.cpp +++ b/indra/newview/gltf/llgltfloader.cpp @@ -450,9 +450,18 @@ bool LLGLTFLoader::populateModelFromMesh(LLModel* pModel, const LL::GLTF::Mesh&                  GLTFVertex vert;                  vert.position = glm::vec3(transformed_pos); -                // Use pre-computed normal_transform -                glm::vec3 normal_vec(prim.mNormals[i][0], prim.mNormals[i][1], prim.mNormals[i][2]); -                vert.normal = glm::normalize(normal_transform * normal_vec); +                if (!prim.mNormals.empty()) +                { +                    // Use pre-computed normal_transform +                    glm::vec3 normal_vec(prim.mNormals[i][0], prim.mNormals[i][1], prim.mNormals[i][2]); +                    vert.normal = glm::normalize(normal_transform * normal_vec); +                } +                else +                { +                    // Use default normal (pointing up in model space) +                    vert.normal = glm::normalize(normal_transform * glm::vec3(0.0f, 0.0f, 1.0f)); +                    LL_DEBUGS("GLTF_IMPORT") << "No normals found for primitive, using default normal." << LL_ENDL; +                }                  vert.uv0 = glm::vec2(prim.mTexCoords0[i][0], -prim.mTexCoords0[i][1]); | 
