diff options
| author | Oz Linden <oz@lindenlab.com> | 2017-03-06 14:31:51 -0500 | 
|---|---|---|
| committer | Oz Linden <oz@lindenlab.com> | 2017-03-06 14:31:51 -0500 | 
| commit | 61bddc22d97150cd590bc4184355133b6dd3ff87 (patch) | |
| tree | 59b488c8c4edc51096338fab153d9eaf837d27fe /indra/newview | |
| parent | a18d4df6c742aa397b70e4dafb41475bd201a558 (diff) | |
| parent | 08ed7f676f2ce38937a03c2a4e823e3564981264 (diff) | |
merge changes for 5.0.2-release
Diffstat (limited to 'indra/newview')
71 files changed, 823 insertions, 277 deletions
| diff --git a/indra/newview/VIEWER_VERSION.txt b/indra/newview/VIEWER_VERSION.txt index a1ef0cae18..50e2274e6d 100644 --- a/indra/newview/VIEWER_VERSION.txt +++ b/indra/newview/VIEWER_VERSION.txt @@ -1 +1 @@ -5.0.2 +5.0.3 diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml index ef252ae8f2..4fc9e0b7c9 100644 --- a/indra/newview/app_settings/settings.xml +++ b/indra/newview/app_settings/settings.xml @@ -1608,18 +1608,6 @@      <real>60.0</real>    </map> -  <key>CameraAspectRatio</key> -  <map> -    <key>Comment</key> -    <string>Camera aspect ratio for DoF effect</string> -    <key>Persist</key> -    <integer>1</integer> -    <key>Type</key> -    <string>F32</string> -    <key>Value</key> -    <real>1.5</real> -  </map> -    <key>CertStore</key>      <map>        <key>Comment</key> @@ -5388,7 +5376,7 @@      <key>LeftClickShowMenu</key>      <map>        <key>Comment</key> -      <string>Left click opens pie menu (FALSE = left click touches or grabs object)</string> +      <string>Unused obsolete setting</string>        <key>Persist</key>        <integer>1</integer>        <key>Type</key> @@ -11824,6 +11812,17 @@        <key>Value</key>        <integer>75</integer>      </map> +    <key>AbuseReportScreenshotDelay</key> +    <map> +      <key>Comment</key> +      <string>Time delay before taking screenshot to avoid UI artifacts.</string> +      <key>Persist</key> +      <integer>1</integer> +      <key>Type</key> +      <string>F32</string> +      <key>Value</key> +      <real>0.3</real> +    </map>      <key>SpeedTest</key>      <map>        <key>Comment</key> @@ -14744,6 +14743,7 @@  	      <string>snapshot</string>  	      <string>postcard</string>  	      <string>mini_map</string> +	      <string>beacons</string>        </array>      </map>      <key>LandmarksSortedByDate</key> diff --git a/indra/newview/app_settings/settings_per_account.xml b/indra/newview/app_settings/settings_per_account.xml index eee13fb28e..92e61d2e86 100644 --- a/indra/newview/app_settings/settings_per_account.xml +++ b/indra/newview/app_settings/settings_per_account.xml @@ -348,5 +348,49 @@          <key>Value</key>               <integer>1</integer>          </map> +      <key>ModelUploadFolder</key> +      <map> +        <key>Comment</key> +        <string>All model uploads will be stored in this directory (UUID)</string> +        <key>Persist</key> +        <integer>1</integer> +        <key>Type</key> +        <string>String</string> +        <key>Value</key> +        <string></string> +      </map> +      <key>TextureUploadFolder</key> +      <map> +        <key>Comment</key> +        <string>All image(texture) uploads will be stored in this directory (UUID)</string> +        <key>Persist</key> +        <integer>1</integer> +        <key>Type</key> +        <string>String</string> +        <key>Value</key> +        <string></string> +      </map> +      <key>SoundUploadFolder</key> +      <map> +        <key>Comment</key> +        <string>All sound uploads will be stored in this directory (UUID)</string> +        <key>Persist</key> +        <integer>1</integer> +        <key>Type</key> +        <string>String</string> +        <key>Value</key> +        <string></string> +      </map> +      <key>AnimationUploadFolder</key> +      <map> +        <key>Comment</key> +        <string>All animation uploads will be stored in this directory (UUID)</string> +        <key>Persist</key> +        <integer>1</integer> +        <key>Type</key> +        <string>String</string> +        <key>Value</key> +        <string></string> +      </map>      </map>  </llsd> diff --git a/indra/newview/llagent.cpp b/indra/newview/llagent.cpp index cfb09d329b..7d0d39e22a 100644 --- a/indra/newview/llagent.cpp +++ b/indra/newview/llagent.cpp @@ -2050,7 +2050,10 @@ void LLAgent::endAnimationUpdateUI()  			{  				skip_list.insert(LLFloaterReg::findInstance("mini_map"));  			} - +			if (LLFloaterReg::findInstance("beacons")) +			{ +				skip_list.insert(LLFloaterReg::findInstance("beacons")); +			}  			LLFloaterIMContainer* im_box = LLFloaterReg::getTypedInstance<LLFloaterIMContainer>("im_container");  			LLFloaterIMContainer::floater_list_t conversations;  			im_box->getDetachedConversationFloaters(conversations); @@ -2172,6 +2175,7 @@ void LLAgent::endAnimationUpdateUI()  #else // Use this for now  		LLFloaterView::skip_list_t skip_list;  		skip_list.insert(LLFloaterReg::findInstance("mini_map")); +		skip_list.insert(LLFloaterReg::findInstance("beacons"));  		gFloaterView->pushVisibleAll(FALSE, skip_list);  #endif diff --git a/indra/newview/llappearancemgr.cpp b/indra/newview/llappearancemgr.cpp index fc4be98fbd..feb981217d 100644 --- a/indra/newview/llappearancemgr.cpp +++ b/indra/newview/llappearancemgr.cpp @@ -1227,11 +1227,12 @@ void LLWearableHoldingPattern::onWearableAssetFetch(LLViewerWearable *wearable)  		return;  	} +	U32 use_count = 0;  	for (LLWearableHoldingPattern::found_list_t::iterator iter = getFoundList().begin(); -		 iter != getFoundList().end(); ++iter) +		iter != getFoundList().end(); ++iter)  	{  		LLFoundData& data = *iter; -		if(wearable->getAssetID() == data.mAssetID) +		if (wearable->getAssetID() == data.mAssetID)  		{  			// Failing this means inventory or asset server are corrupted in a way we don't handle.  			if ((data.mWearableType >= LLWearableType::WT_COUNT) || (wearable->getType() != data.mWearableType)) @@ -1240,9 +1241,48 @@ void LLWearableHoldingPattern::onWearableAssetFetch(LLViewerWearable *wearable)  				break;  			} -			data.mWearable = wearable; +			if (use_count == 0) +			{ +				data.mWearable = wearable; +				use_count++; +			} +			else +			{ +				LLViewerInventoryItem* wearable_item = gInventory.getItem(data.mItemID); +				if (wearable_item && wearable_item->isFinished() && wearable_item->getPermissions().allowModifyBy(gAgentID)) +				{ +					// We can't edit and do some other interactions with same asset twice, copy it +					// Note: can't update incomplete items. Usually attached from previous viewer build, but +					// consider adding fetch and completion callback +					LLViewerWearable* new_wearable = LLWearableList::instance().createCopy(wearable, wearable->getName()); +					data.mWearable = new_wearable; +					data.mAssetID = new_wearable->getAssetID(); + +					// Update existing inventory item +					wearable_item->setAssetUUID(new_wearable->getAssetID()); +					wearable_item->setTransactionID(new_wearable->getTransactionID()); +					gInventory.updateItem(wearable_item, LLInventoryObserver::INTERNAL); +					wearable_item->updateServer(FALSE); + +					use_count++; +				} +				else +				{ +					// Note: technically a bug, LLViewerWearable can identify only one item id at a time, +					// yet we are tying it to multiple items here. +					// LLViewerWearable need to support more then one item. +					LL_WARNS() << "Same LLViewerWearable is used by multiple items! " << wearable->getAssetID() << LL_ENDL; +					data.mWearable = wearable; +				} +			}  		}  	} + +	if (use_count > 1) +	{ +		LL_WARNS() << "Copying wearable, multiple asset id uses! " << wearable->getAssetID() << LL_ENDL; +		gInventory.notifyObservers(); +	}  }  static void onWearableAssetFetch(LLViewerWearable* wearable, void* data) diff --git a/indra/newview/llappviewer.cpp b/indra/newview/llappviewer.cpp index 86bf44567d..e504ba4683 100644 --- a/indra/newview/llappviewer.cpp +++ b/indra/newview/llappviewer.cpp @@ -1235,7 +1235,8 @@ bool LLAppViewer::init()          boost::bind(&LLControlGroup::getU32, boost::ref(gSavedSettings), _1),          boost::bind(&LLControlGroup::declareU32, boost::ref(gSavedSettings), _1, _2, _3, LLControlVariable::PERSIST_ALWAYS)); -	showReleaseNotesIfRequired(); +	// TODO: consider moving proxy initialization here or LLCopocedureManager after proxy initialization, may be implement +	// some other protection to make sure we don't use network before initializng proxy  	/*----------------------------------------------------------------------*/  	// nat 2016-06-29 moved the following here from the former mainLoop(). @@ -1489,11 +1490,9 @@ bool LLAppViewer::frame()  				ms_sleep(500);  			} -			const F64Milliseconds max_idle_time = llmin(.005f*10.f*(F32Milliseconds)gFrameTimeSeconds, F32Milliseconds(5)); // 5 ms a second  			idleTimer.reset();  			S32 total_work_pending = 0;  			S32 total_io_pending = 0;	 -			while(1)  			{  				S32 work_pending = 0;  				S32 io_pending = 0; @@ -1517,11 +1516,7 @@ bool LLAppViewer::frame()  				total_work_pending += work_pending ;  				total_io_pending += io_pending ; -				 -				if (!work_pending || idleTimer.getElapsedTimeF64() >= max_idle_time) -				{ -					break; -				} +  			}  			gMeshRepo.update() ; @@ -5870,21 +5865,6 @@ void LLAppViewer::launchUpdater()  	// LLAppViewer::instance()->forceQuit();  } -/** -* Check if user is running a new version of the viewer. -* Display the Release Notes if it's not overriden by the "UpdaterShowReleaseNotes" setting. -*/ -void LLAppViewer::showReleaseNotesIfRequired() -{ -	if (LLVersionInfo::getChannelAndVersion() != gLastRunVersion -		&& gSavedSettings.getBOOL("UpdaterShowReleaseNotes") -		&& !gSavedSettings.getBOOL("FirstLoginThisInstall")) -	{ -		LLSD info(getViewerInfo()); -		LLWeb::loadURLInternal(info["VIEWER_RELEASE_NOTES_URL"]); -	} -} -  //virtual  void LLAppViewer::setMasterSystemAudioMute(bool mute)  { diff --git a/indra/newview/llappviewer.h b/indra/newview/llappviewer.h index 948d316009..7bb3c32c51 100644 --- a/indra/newview/llappviewer.h +++ b/indra/newview/llappviewer.h @@ -255,8 +255,6 @@ private:      void sendLogoutRequest();      void disconnectViewer(); -	void showReleaseNotesIfRequired(); -	  	// *FIX: the app viewer class should be some sort of singleton, no?  	// Perhaps its child class is the singleton and this should be an abstract base.  	static LLAppViewer* sInstance;  diff --git a/indra/newview/llblocklist.h b/indra/newview/llblocklist.h index 0f7fa41c32..96af8d898e 100644 --- a/indra/newview/llblocklist.h +++ b/indra/newview/llblocklist.h @@ -67,6 +67,8 @@ public:  	void sortByType();  	void refresh(); +	U32 getMuteListSize() { return mMuteListSize; } +  private:  	void addNewItem(const LLMute* mute); diff --git a/indra/newview/llconversationloglist.cpp b/indra/newview/llconversationloglist.cpp index ffc235bdbf..86e23e7c83 100644 --- a/indra/newview/llconversationloglist.cpp +++ b/indra/newview/llconversationloglist.cpp @@ -369,8 +369,13 @@ bool LLConversationLogList::isActionEnabled(const LLSD& userdata)  	bool is_p2p   = LLIMModel::LLIMSession::P2P_SESSION == stype;  	bool is_group = LLIMModel::LLIMSession::GROUP_SESSION == stype; +	bool is_group_member = is_group && gAgent.isInGroup(selected_id, TRUE); -	if ("can_im" == command_name || "can_view_profile" == command_name) +	if ("can_im" == command_name) +	{ +		return is_p2p || is_group_member; +	} +	else if ("can_view_profile" == command_name)  	{  		return is_p2p || is_group;  	} @@ -380,7 +385,7 @@ bool LLConversationLogList::isActionEnabled(const LLSD& userdata)  	}  	else if ("can_call"	== command_name)  	{ -		return (is_p2p || is_group) && LLAvatarActions::canCall(); +		return (is_p2p || is_group_member) && LLAvatarActions::canCall();  	}  	else if ("add_rem_friend"		== command_name ||  			 "can_invite_to_group"	== command_name || diff --git a/indra/newview/llexpandabletextbox.cpp b/indra/newview/llexpandabletextbox.cpp index f0331f20d8..314b859cea 100644 --- a/indra/newview/llexpandabletextbox.cpp +++ b/indra/newview/llexpandabletextbox.cpp @@ -63,10 +63,10 @@ public:  	{   		return start_offset;  	} -	/*virtual*/ S32		getNumChars(S32 num_pixels, S32 segment_offset, S32 line_offset, S32 max_chars) const  +	/*virtual*/ S32		getNumChars(S32 num_pixels, S32 segment_offset, S32 line_offset, S32 max_chars, S32 line_ind) const  	{   		// require full line to ourselves -		if (line_offset == 0)  +		if (line_offset == 0)  		{  			// print all our text  			return getEnd() - getStart();  diff --git a/indra/newview/llfloaterimcontainer.cpp b/indra/newview/llfloaterimcontainer.cpp index 7039e48e74..7007c58b3c 100644 --- a/indra/newview/llfloaterimcontainer.cpp +++ b/indra/newview/llfloaterimcontainer.cpp @@ -1505,15 +1505,21 @@ bool LLFloaterIMContainer::checkContextMenuItem(const std::string& item, uuid_ve  bool LLFloaterIMContainer::visibleContextMenuItem(const LLSD& userdata)  { +	const LLConversationItem *conversation_item = getCurSelectedViewModelItem(); +	if(!conversation_item) +	{ +		return false; +	} +  	const std::string& item = userdata.asString();  	if ("show_mute" == item)  	{ -		return !isMuted(getCurSelectedViewModelItem()->getUUID()); +		return !isMuted(conversation_item->getUUID());  	}  	else if ("show_unmute" == item)  	{ -		return isMuted(getCurSelectedViewModelItem()->getUUID()); +		return isMuted(conversation_item->getUUID());  	}  	return true; diff --git a/indra/newview/llfloaterimnearbychat.cpp b/indra/newview/llfloaterimnearbychat.cpp index 257b39a7dd..7d0ff22ed3 100644 --- a/indra/newview/llfloaterimnearbychat.cpp +++ b/indra/newview/llfloaterimnearbychat.cpp @@ -304,6 +304,13 @@ void LLFloaterIMNearbyChat::onClose(bool app_quitting)  {  	// Override LLFloaterIMSessionTab::onClose() so that Nearby Chat is not removed from the conversation floater  	LLFloaterIMSessionTab::restoreFloater(); +	if (app_quitting) +	{ +		// We are starting and closing floater in "expanded" state +		// Update expanded (restored) rect and position for use in next session +		forceReshape(); +		storeRectControl(); +	}  }  // virtual diff --git a/indra/newview/llfloaterland.cpp b/indra/newview/llfloaterland.cpp index 7f952d4dd4..a340cd1143 100644 --- a/indra/newview/llfloaterland.cpp +++ b/indra/newview/llfloaterland.cpp @@ -2029,7 +2029,6 @@ void LLPanelLandOptions::refresh()  	else  	{  		// something selected, hooray! -		LLViewerRegion* regionp = LLViewerParcelMgr::getInstance()->getSelectionRegion();  		// Display options  		BOOL can_change_options = LLViewerParcelMgr::isParcelModifiableByAgent(parcel, GP_LAND_OPTIONS); @@ -2045,9 +2044,8 @@ void LLPanelLandOptions::refresh()  		mCheckGroupObjectEntry	->set( parcel->getAllowGroupObjectEntry() ||  parcel->getAllowAllObjectEntry());  		mCheckGroupObjectEntry	->setEnabled( can_change_options && !parcel->getAllowAllObjectEntry() ); -		BOOL region_damage = regionp ? regionp->getAllowDamage() : FALSE;  		mCheckSafe			->set( !parcel->getAllowDamage() ); -		mCheckSafe			->setEnabled( can_change_options && region_damage ); +		mCheckSafe			->setEnabled( can_change_options );  		mCheckFly			->set( parcel->getAllowFly() );  		mCheckFly			->setEnabled( can_change_options ); @@ -2127,6 +2125,7 @@ void LLPanelLandOptions::refresh()  			// they can see the checkbox, but its disposition depends on the   			// state of the region +			LLViewerRegion* regionp = LLViewerParcelMgr::getInstance()->getSelectionRegion();  			if (regionp)  			{  				if (regionp->getSimAccess() == SIM_ACCESS_PG) @@ -2448,6 +2447,7 @@ void LLPanelLandAccess::refresh()  			mListAccess->deleteAllItems();  			S32 count = parcel->mAccessList.size();  			getChild<LLUICtrl>("AllowedText")->setTextArg("[COUNT]", llformat("%d",count)); +			getChild<LLUICtrl>("AllowedText")->setTextArg("[MAX]", llformat("%d",PARCEL_MAX_ACCESS_LIST));  			getChild<LLUICtrl>("AccessList")->setToolTipArg(LLStringExplicit("[LISTED]"), llformat("%d",count));  			getChild<LLUICtrl>("AccessList")->setToolTipArg(LLStringExplicit("[MAX]"), llformat("%d",PARCEL_MAX_ACCESS_LIST)); @@ -2495,6 +2495,7 @@ void LLPanelLandAccess::refresh()  			mListBanned->deleteAllItems();  			S32 count = parcel->mBanList.size();  			getChild<LLUICtrl>("BanCheck")->setTextArg("[COUNT]", llformat("%d",count)); +			getChild<LLUICtrl>("BanCheck")->setTextArg("[MAX]", llformat("%d",PARCEL_MAX_ACCESS_LIST));  			getChild<LLUICtrl>("BannedList")->setToolTipArg(LLStringExplicit("[LISTED]"), llformat("%d",count));  			getChild<LLUICtrl>("BannedList")->setToolTipArg(LLStringExplicit("[MAX]"), llformat("%d",PARCEL_MAX_ACCESS_LIST)); diff --git a/indra/newview/llfloaterpathfindingobjects.cpp b/indra/newview/llfloaterpathfindingobjects.cpp index f6ff83eaf4..5cf16f3ad6 100644 --- a/indra/newview/llfloaterpathfindingobjects.cpp +++ b/indra/newview/llfloaterpathfindingobjects.cpp @@ -329,7 +329,7 @@ void LLFloaterPathfindingObjects::handleUpdateObjectList(LLPathfindingManager::r  	}  } -void LLFloaterPathfindingObjects::rebuildObjectsScrollList() +void LLFloaterPathfindingObjects::rebuildObjectsScrollList(bool update_if_needed)  {  	if (!mHasObjectsToBeSelected)  	{ @@ -355,7 +355,14 @@ void LLFloaterPathfindingObjects::rebuildObjectsScrollList()  	{  		buildObjectsScrollList(mObjectList); -		mObjectsScrollList->selectMultiple(mObjectsToBeSelected); +		if(mObjectsScrollList->selectMultiple(mObjectsToBeSelected) == 0) +		{ +			if(update_if_needed && mRefreshListButton->getEnabled()) +			{ +				requestGetObjects(); +				return; +			} +		}  		if (mHasObjectsToBeSelected)  		{  			mObjectsScrollList->scrollToShowSelected(); @@ -484,7 +491,7 @@ void LLFloaterPathfindingObjects::showFloaterWithSelectionObjects()  	}  	else  	{ -		rebuildObjectsScrollList(); +		rebuildObjectsScrollList(true);  		if (isMinimized())  		{  			setMinimized(FALSE); diff --git a/indra/newview/llfloaterpathfindingobjects.h b/indra/newview/llfloaterpathfindingobjects.h index 4024e15fd6..752f741959 100644 --- a/indra/newview/llfloaterpathfindingobjects.h +++ b/indra/newview/llfloaterpathfindingobjects.h @@ -80,7 +80,7 @@ protected:  	void                               handleNewObjectList(LLPathfindingManager::request_id_t pRequestId, LLPathfindingManager::ERequestStatus pRequestStatus, LLPathfindingObjectListPtr pObjectList);  	void                               handleUpdateObjectList(LLPathfindingManager::request_id_t pRequestId, LLPathfindingManager::ERequestStatus pRequestStatus, LLPathfindingObjectListPtr pObjectList); -	void                               rebuildObjectsScrollList(); +	void                               rebuildObjectsScrollList(bool update_if_needed = false);  	virtual void                       buildObjectsScrollList(const LLPathfindingObjectListPtr pObjectListPtr);  	void                               addObjectToScrollList(const LLPathfindingObjectPtr pObjectPr, const LLSD &pScrollListItemData); diff --git a/indra/newview/llfloaterpreference.cpp b/indra/newview/llfloaterpreference.cpp index 100ee5ab72..df4bc043e5 100644 --- a/indra/newview/llfloaterpreference.cpp +++ b/indra/newview/llfloaterpreference.cpp @@ -467,6 +467,11 @@ BOOL LLFloaterPreference::postBuild()  	gSavedSettings.getControl("PreferredMaturity")->getSignal()->connect(boost::bind(&LLFloaterPreference::onChangeMaturity, this)); +	gSavedPerAccountSettings.getControl("ModelUploadFolder")->getSignal()->connect(boost::bind(&LLFloaterPreference::onChangeModelFolder, this)); +	gSavedPerAccountSettings.getControl("TextureUploadFolder")->getSignal()->connect(boost::bind(&LLFloaterPreference::onChangeTextureFolder, this)); +	gSavedPerAccountSettings.getControl("SoundUploadFolder")->getSignal()->connect(boost::bind(&LLFloaterPreference::onChangeSoundFolder, this)); +	gSavedPerAccountSettings.getControl("AnimationUploadFolder")->getSignal()->connect(boost::bind(&LLFloaterPreference::onChangeAnimationFolder, this)); +  	LLTabContainer* tabcontainer = getChild<LLTabContainer>("pref core");  	if (!tabcontainer->selectTab(gSavedSettings.getS32("LastPrefTab")))  		tabcontainer->selectFirstTab(); @@ -501,6 +506,7 @@ BOOL LLFloaterPreference::postBuild()  	fov_slider->setMinValue(LLViewerCamera::getInstance()->getMinView());  	fov_slider->setMaxValue(LLViewerCamera::getInstance()->getMaxView()); +  	return TRUE;  } @@ -742,7 +748,12 @@ void LLFloaterPreference::onOpen(const LLSD& key)  	// Display selected maturity icons.  	onChangeMaturity(); -	 + +	onChangeModelFolder(); +	onChangeTextureFolder(); +	onChangeSoundFolder(); +	onChangeAnimationFolder(); +  	// Load (double-)click to walk/teleport settings.  	updateClickActionControls(); @@ -1979,6 +1990,63 @@ void LLFloaterPreference::onChangeMaturity()  	getChild<LLIconCtrl>("rating_icon_adult")->setVisible(sim_access == SIM_ACCESS_ADULT);  } +std::string get_category_path(LLUUID cat_id) +{ +    LLViewerInventoryCategory* cat = gInventory.getCategory(cat_id); +    std::string localized_cat_name; +    if (!LLTrans::findString(localized_cat_name, "InvFolder " + cat->getName())) +    { +        localized_cat_name = cat->getName(); +    } + +    if (cat->getParentUUID().notNull()) +    { +        return get_category_path(cat->getParentUUID()) + " > " + localized_cat_name; +    } +    else +    { +        return localized_cat_name; +    } +} + +std::string get_category_path(LLFolderType::EType cat_type) +{ +    LLUUID cat_id = gInventory.findUserDefinedCategoryUUIDForType(cat_type); +    return get_category_path(cat_id); +} + +void LLFloaterPreference::onChangeModelFolder() +{ +    if (gInventory.isInventoryUsable()) +    { +        getChild<LLTextBox>("upload_models")->setText(get_category_path(LLFolderType::FT_OBJECT)); +    } +} + +void LLFloaterPreference::onChangeTextureFolder() +{ +    if (gInventory.isInventoryUsable()) +    { +        getChild<LLTextBox>("upload_textures")->setText(get_category_path(LLFolderType::FT_TEXTURE)); +    } +} + +void LLFloaterPreference::onChangeSoundFolder() +{ +    if (gInventory.isInventoryUsable()) +    { +        getChild<LLTextBox>("upload_sounds")->setText(get_category_path(LLFolderType::FT_SOUND)); +    } +} + +void LLFloaterPreference::onChangeAnimationFolder() +{ +    if (gInventory.isInventoryUsable()) +    { +        getChild<LLTextBox>("upload_animation")->setText(get_category_path(LLFolderType::FT_ANIMATION)); +    } +} +  // FIXME: this will stop you from spawning the sidetray from preferences dialog on login screen  // but the UI for this will still be enabled  void LLFloaterPreference::onClickBlockList() diff --git a/indra/newview/llfloaterpreference.h b/indra/newview/llfloaterpreference.h index fa0c09e97a..ea199cf034 100644 --- a/indra/newview/llfloaterpreference.h +++ b/indra/newview/llfloaterpreference.h @@ -161,6 +161,10 @@ public:  	void onCommitMusicEnabled();  	void applyResolution();  	void onChangeMaturity(); +	void onChangeModelFolder(); +	void onChangeTextureFolder(); +	void onChangeSoundFolder(); +	void onChangeAnimationFolder();  	void onClickBlockList();  	void onClickProxySettings();  	void onClickTranslationSettings(); diff --git a/indra/newview/llfloaterreporter.cpp b/indra/newview/llfloaterreporter.cpp index 275554540e..515c2b0c4b 100644 --- a/indra/newview/llfloaterreporter.cpp +++ b/indra/newview/llfloaterreporter.cpp @@ -35,6 +35,7 @@  #include "llassetstorage.h"  #include "llavatarnamecache.h"  #include "llcachename.h" +#include "llcallbacklist.h"  #include "llcheckboxctrl.h"  #include "llfontgl.h"  #include "llimagebmp.h" @@ -211,7 +212,7 @@ BOOL LLFloaterReporter::postBuild()  	// grab the user's name  	std::string reporter = LLSLURL("agent", gAgent.getID(), "inspect").getSLURLString();  	getChild<LLUICtrl>("reporter_field")->setValue(reporter); -	 +  	center();  	return TRUE; @@ -837,8 +838,9 @@ void LLFloaterReporter::takeScreenshot(bool use_prev_screenshot)  	}  } -void LLFloaterReporter::onOpen(const LLSD& key) +void LLFloaterReporter::takeNewSnapshot()  { +	childSetEnabled("send_btn", true);  	mImageRaw = new LLImageRaw;  	const S32 IMAGE_WIDTH = 1024;  	const S32 IMAGE_HEIGHT = 768; @@ -867,10 +869,18 @@ void LLFloaterReporter::onOpen(const LLSD& key)  			}  		}  	} -  	takeScreenshot();  } + +void LLFloaterReporter::onOpen(const LLSD& key) +{ +	childSetEnabled("send_btn", false); +	//Time delay to avoid UI artifacts. MAINT-7067 +	doAfterInterval(boost::bind(&LLFloaterReporter::takeNewSnapshot,this), gSavedSettings.getF32("AbuseReportScreenshotDelay")); + +} +  void LLFloaterReporter::onLoadScreenshotDialog(const LLSD& notification, const LLSD& response)  {  	S32 option = LLNotificationsUtil::getSelectedOption(notification, response); diff --git a/indra/newview/llfloaterreporter.h b/indra/newview/llfloaterreporter.h index e5232268c0..decc01be98 100644 --- a/indra/newview/llfloaterreporter.h +++ b/indra/newview/llfloaterreporter.h @@ -107,6 +107,8 @@ public:  	void onLoadScreenshotDialog(const LLSD& notification, const LLSD& response); +	void takeNewSnapshot(); +  private:  	static void show(const LLUUID& object_id, const std::string& avatar_name = LLStringUtil::null, const LLUUID& experience_id = LLUUID::null); diff --git a/indra/newview/llfloaterscriptdebug.cpp b/indra/newview/llfloaterscriptdebug.cpp index 6c17f62c1e..468537e659 100644 --- a/indra/newview/llfloaterscriptdebug.cpp +++ b/indra/newview/llfloaterscriptdebug.cpp @@ -34,6 +34,7 @@  #include "llrect.h"  #include "llerror.h"  #include "llstring.h" +#include "llvoavatarself.h"  #include "message.h"  // project include @@ -80,6 +81,36 @@ BOOL LLFloaterScriptDebug::postBuild()  	return FALSE;  } +void LLFloaterScriptDebug::setVisible(BOOL visible) +{ +	if(visible) +	{ +		LLFloaterScriptDebugOutput* floater_output = LLFloaterReg::findTypedInstance<LLFloaterScriptDebugOutput>("script_debug_output", LLUUID::null); +		if (floater_output == NULL) +		{ +			floater_output = dynamic_cast<LLFloaterScriptDebugOutput*>(LLFloaterReg::showInstance("script_debug_output", LLUUID::null, FALSE)); +			if (floater_output) +			{ +				addFloater(floater_output, false); +			} +		} + +	} +	LLMultiFloater::setVisible(visible); +} + +void LLFloaterScriptDebug::closeFloater(bool app_quitting/* = false*/) +{ +	if(app_quitting) +	{ +		LLMultiFloater::closeFloater(app_quitting); +	} +	else +	{ +		setVisible(false); +	} +} +  LLFloater* LLFloaterScriptDebug::addOutputWindow(const LLUUID &object_id)  {  	LLMultiFloater* host = LLFloaterReg::showTypedInstance<LLMultiFloater>("script_debug", LLSD()); @@ -105,7 +136,14 @@ void LLFloaterScriptDebug::addScriptLine(const std::string &utf8mesg, const std:  	if (objectp)  	{ -		objectp->setIcon(LLViewerTextureManager::getFetchedTextureFromFile("script_error.j2c", FTT_LOCAL_FILE, TRUE, LLGLTexture::BOOST_UI)); +		if(objectp->isHUDAttachment()) +		{ +			((LLViewerObject*)gAgentAvatarp)->setIcon(LLViewerTextureManager::getFetchedTextureFromFile("script_error.j2c", FTT_LOCAL_FILE, TRUE, LLGLTexture::BOOST_UI)); +		} +		else +		{ +			objectp->setIcon(LLViewerTextureManager::getFetchedTextureFromFile("script_error.j2c", FTT_LOCAL_FILE, TRUE, LLGLTexture::BOOST_UI)); +		}  		floater_label = llformat("%s(%.0f, %.0f, %.0f)",  						user_name.c_str(),  						objectp->getPositionRegion().mV[VX], @@ -117,7 +155,6 @@ void LLFloaterScriptDebug::addScriptLine(const std::string &utf8mesg, const std:  		floater_label = user_name;  	} -	addOutputWindow(LLUUID::null);  	addOutputWindow(source_id);  	// add to "All" floater diff --git a/indra/newview/llfloaterscriptdebug.h b/indra/newview/llfloaterscriptdebug.h index 6d9d1eb500..8c08b234f3 100644 --- a/indra/newview/llfloaterscriptdebug.h +++ b/indra/newview/llfloaterscriptdebug.h @@ -38,7 +38,10 @@ public:  	LLFloaterScriptDebug(const LLSD& key);  	virtual ~LLFloaterScriptDebug();  	virtual BOOL postBuild(); +	virtual void setVisible(BOOL visible);      static void show(const LLUUID& object_id); + +    /*virtual*/ void closeFloater(bool app_quitting = false);  	static void addScriptLine(const std::string &utf8mesg, const std::string &user_name, const LLColor4& color, const LLUUID& source_id);  protected: diff --git a/indra/newview/llfloaterworldmap.cpp b/indra/newview/llfloaterworldmap.cpp index c67feb8158..c0bd9b1c23 100644 --- a/indra/newview/llfloaterworldmap.cpp +++ b/indra/newview/llfloaterworldmap.cpp @@ -546,7 +546,7 @@ void LLFloaterWorldMap::trackAvatar( const LLUUID& avatar_id, const std::string&  		// convenience.  		if(gAgent.isGodlike())  		{ -			getChild<LLUICtrl>("spin z")->setValue(LLSD(200.f)); +			getChild<LLUICtrl>("teleport_coordinate_z")->setValue(LLSD(200.f));  		}  		// Don't re-request info if we already have it or we won't have it in time to teleport  		if (mTrackedStatus != LLTracker::TRACKING_AVATAR || name != mTrackedAvatarName) @@ -1375,7 +1375,7 @@ void LLFloaterWorldMap::teleport()  		&& av_tracker.haveTrackingInfo() )  	{  		pos_global = av_tracker.getGlobalPos(); -		pos_global.mdV[VZ] = getChild<LLUICtrl>("spin z")->getValue(); +		pos_global.mdV[VZ] = getChild<LLUICtrl>("teleport_coordinate_z")->getValue();  	}  	else if ( LLTracker::TRACKING_LANDMARK == tracking_status)  	{ diff --git a/indra/newview/llimview.cpp b/indra/newview/llimview.cpp index 2405c3a1a3..2e9332c355 100644 --- a/indra/newview/llimview.cpp +++ b/indra/newview/llimview.cpp @@ -2703,7 +2703,7 @@ void LLIMMgr::addMessage(  		// Logically it would make more sense to reject the session sooner, in another area of the  		// code, but the session has to be established inside the server before it can be left. -		if (LLMuteList::getInstance()->isMuted(other_participant_id) && !from_linden) +		if (LLMuteList::getInstance()->isMuted(other_participant_id, LLMute::flagTextChat) && !from_linden)  		{  			LL_WARNS() << "Leaving IM session from initiating muted resident " << from << LL_ENDL;  			if(!gIMMgr->leaveSession(new_session_id)) @@ -3011,14 +3011,20 @@ void LLIMMgr::inviteToSession(  	payload["question_type"] = question_type;  	//ignore invites from muted residents -	if (LLMuteList::getInstance()->isMuted(caller_id) && !is_linden) +	if (!is_linden)  	{ -		if (voice_invite && "VoiceInviteQuestionDefault" == question_type) +		if (LLMuteList::getInstance()->isMuted(caller_id, LLMute::flagVoiceChat) +			&& voice_invite && "VoiceInviteQuestionDefault" == question_type)  		{  			LL_INFOS() << "Rejecting voice call from initiating muted resident " << caller_name << LL_ENDL;  			LLIncomingCallDialog::processCallResponse(1, payload); +			return; +		} +		else if (LLMuteList::getInstance()->isMuted(caller_id, LLMute::flagAll & ~LLMute::flagVoiceChat)) +		{ +			LL_INFOS() << "Rejecting session invite from initiating muted resident " << caller_name << LL_ENDL; +			return;  		} -		return;  	}  	LLVoiceChannel* channelp = LLVoiceChannel::getChannelByID(session_id); diff --git a/indra/newview/llinventorybridge.cpp b/indra/newview/llinventorybridge.cpp index 1de579d4c3..b7f5424f25 100644 --- a/indra/newview/llinventorybridge.cpp +++ b/indra/newview/llinventorybridge.cpp @@ -3789,6 +3789,7 @@ void LLFolderBridge::buildContextMenuOptions(U32 flags, menuentry_vec_t&   items  		disabled_items.push_back(std::string("New Gesture"));  		disabled_items.push_back(std::string("New Clothes"));  		disabled_items.push_back(std::string("New Body Parts")); +		disabled_items.push_back(std::string("upload_def"));  	}  	if (favorites == mUUID)  	{ @@ -3815,6 +3816,7 @@ void LLFolderBridge::buildContextMenuOptions(U32 flags, menuentry_vec_t&   items  		disabled_items.push_back(std::string("New Gesture"));  		disabled_items.push_back(std::string("New Clothes"));  		disabled_items.push_back(std::string("New Body Parts")); +		disabled_items.push_back(std::string("upload_def"));      }      if (marketplace_listings_id == mUUID)      { @@ -3864,6 +3866,7 @@ void LLFolderBridge::buildContextMenuOptions(U32 flags, menuentry_vec_t&   items                      items.push_back(std::string("New Gesture"));                      items.push_back(std::string("New Clothes"));                      items.push_back(std::string("New Body Parts")); +                    items.push_back(std::string("upload_def"));                  }  			}  			getClipboardEntries(false, items, disabled_items, flags); diff --git a/indra/newview/llinventoryfilter.cpp b/indra/newview/llinventoryfilter.cpp index e995c138b4..1433ea36bf 100644 --- a/indra/newview/llinventoryfilter.cpp +++ b/indra/newview/llinventoryfilter.cpp @@ -40,6 +40,7 @@  #include "llinventorybridge.h"  #include "llviewerfoldertype.h"  #include "llradiogroup.h" +#include "llstartup.h"  // linden library includes  #include "llclipboard.h" @@ -132,8 +133,10 @@ bool LLInventoryFilter::checkFolder(const LLUUID& folder_id) const  	}  	// when applying a filter, matching folders get their contents downloaded first +	// but make sure we are not interfering with pre-download  	if (isNotDefault() -		&& !gInventory.isCategoryComplete(folder_id)) +		&& !gInventory.isCategoryComplete(folder_id) +		&& LLStartUp::getStartupState() > STATE_WEARABLES_WAIT)  	{  		LLInventoryModelBackgroundFetch::instance().start(folder_id);  	} @@ -307,7 +310,11 @@ bool LLInventoryFilter::checkAgainstFilterType(const LLFolderViewModelItemInvent  			if (is_hidden_if_empty)  			{  				// Force the fetching of those folders so they are hidden if they really are empty... -				gInventory.fetchDescendentsOf(object_id); +				// But don't interfere with startup download +				if (LLStartUp::getStartupState() > STATE_WEARABLES_WAIT) +				{ +					gInventory.fetchDescendentsOf(object_id); +				}  				LLInventoryModel::cat_array_t* cat_array = NULL;  				LLInventoryModel::item_array_t* item_array = NULL; diff --git a/indra/newview/llinventorymodel.cpp b/indra/newview/llinventorymodel.cpp index 503fa28a33..287fa4c45b 100644 --- a/indra/newview/llinventorymodel.cpp +++ b/indra/newview/llinventorymodel.cpp @@ -515,6 +515,42 @@ const LLUUID LLInventoryModel::findCategoryUUIDForType(LLFolderType::EType prefe  	return findCategoryUUIDForTypeInRoot(preferred_type, create_folder, gInventory.getRootFolderID());  } +const LLUUID LLInventoryModel::findUserDefinedCategoryUUIDForType(LLFolderType::EType preferred_type) +{ +    LLUUID cat_id; +    switch (preferred_type) +    { +    case LLFolderType::FT_OBJECT: +    { +        cat_id = LLUUID(gSavedPerAccountSettings.getString("ModelUploadFolder")); +        break; +    } +    case LLFolderType::FT_TEXTURE: +    { +        cat_id = LLUUID(gSavedPerAccountSettings.getString("TextureUploadFolder")); +        break; +    } +    case LLFolderType::FT_SOUND: +    { +        cat_id = LLUUID(gSavedPerAccountSettings.getString("SoundUploadFolder")); +        break; +    } +    case LLFolderType::FT_ANIMATION: +    { +        cat_id = LLUUID(gSavedPerAccountSettings.getString("AnimationUploadFolder")); +        break; +    } +    default: +        break; +    } +     +    if (cat_id.isNull() || !getCategory(cat_id)) +    { +        cat_id = findCategoryUUIDForTypeInRoot(preferred_type, true, getRootFolderID()); +    } +    return cat_id; +} +  const LLUUID LLInventoryModel::findLibraryCategoryUUIDForType(LLFolderType::EType preferred_type, bool create_folder)  {  	return findCategoryUUIDForTypeInRoot(preferred_type, create_folder, gInventory.getLibraryRootFolderID()); diff --git a/indra/newview/llinventorymodel.h b/indra/newview/llinventorymodel.h index 826d1f880d..dee1769172 100644 --- a/indra/newview/llinventorymodel.h +++ b/indra/newview/llinventorymodel.h @@ -287,6 +287,9 @@ public:  	//    will search in the user's library folder instead of "My Inventory"  	const LLUUID findLibraryCategoryUUIDForType(LLFolderType::EType preferred_type,   												bool create_folder = true); +	// Returns user specified category for uploads, returns default id if there are no +	// user specified one or it does not exist, creates default category if it is missing. +	const LLUUID findUserDefinedCategoryUUIDForType(LLFolderType::EType preferred_type);  	// Get whatever special folder this object is a child of, if any.  	const LLViewerInventoryCategory *getFirstNondefaultParent(const LLUUID& obj_id) const; diff --git a/indra/newview/llinventorypanel.cpp b/indra/newview/llinventorypanel.cpp index 6a27c0fe21..bd15ba4975 100644 --- a/indra/newview/llinventorypanel.cpp +++ b/indra/newview/llinventorypanel.cpp @@ -167,7 +167,7 @@ LLInventoryPanel::LLInventoryPanel(const LLInventoryPanel::Params& p) :  	mCommitCallbackRegistrar.add("Inventory.AttachObject", boost::bind(&LLInventoryPanel::attachObject, this, _2));  	mCommitCallbackRegistrar.add("Inventory.BeginIMSession", boost::bind(&LLInventoryPanel::beginIMSession, this));  	mCommitCallbackRegistrar.add("Inventory.Share",  boost::bind(&LLAvatarActions::shareWithAvatars, this)); - +	mCommitCallbackRegistrar.add("Inventory.FileUploadLocation", boost::bind(&LLInventoryPanel::fileUploadLocation, this, _2));  }  LLFolderView * LLInventoryPanel::createFolderRoot(LLUUID root_id ) @@ -1190,6 +1190,27 @@ bool LLInventoryPanel::beginIMSession()  	return true;  } +void LLInventoryPanel::fileUploadLocation(const LLSD& userdata) +{ +    const std::string param = userdata.asString(); +    if (param == "model") +    { +        gSavedPerAccountSettings.setString("ModelUploadFolder", LLFolderBridge::sSelf.get()->getUUID().asString()); +    } +    else if (param == "texture") +    { +        gSavedPerAccountSettings.setString("TextureUploadFolder", LLFolderBridge::sSelf.get()->getUUID().asString()); +    } +    else if (param == "sound") +    { +        gSavedPerAccountSettings.setString("SoundUploadFolder", LLFolderBridge::sSelf.get()->getUUID().asString()); +    } +    else if (param == "animation") +    { +        gSavedPerAccountSettings.setString("AnimationUploadFolder", LLFolderBridge::sSelf.get()->getUUID().asString()); +    } +} +  bool LLInventoryPanel::attachObject(const LLSD& userdata)  {  	// Copy selected item UUIDs to a vector. diff --git a/indra/newview/llinventorypanel.h b/indra/newview/llinventorypanel.h index b69edd8b93..5cb9dde47a 100644 --- a/indra/newview/llinventorypanel.h +++ b/indra/newview/llinventorypanel.h @@ -201,6 +201,7 @@ public:  	void doToSelected(const LLSD& userdata);  	void doCreate(const LLSD& userdata);  	bool beginIMSession(); +	void fileUploadLocation(const LLSD& userdata);  	bool attachObject(const LLSD& userdata);  	static void idle(void* user_data); diff --git a/indra/newview/llloginhandler.cpp b/indra/newview/llloginhandler.cpp index 39f3c0f113..eca34c0d4d 100644 --- a/indra/newview/llloginhandler.cpp +++ b/indra/newview/llloginhandler.cpp @@ -168,7 +168,6 @@ LLPointer<LLCredential> LLLoginHandler::loadSavedUserLoginInfo()  		authenticator["algorithm"] = "md5";  		authenticator["secret"] = md5pass;  		// yuck, we'll fix this with mani's changes. -		gSavedSettings.setBOOL("AutoLogin", TRUE);  		return gSecAPIHandler->createCredential(LLGridManager::getInstance()->getGrid(),   													   identifier, authenticator);  	} diff --git a/indra/newview/llmeshrepository.cpp b/indra/newview/llmeshrepository.cpp index 9dacae2c4e..1a533dace7 100644 --- a/indra/newview/llmeshrepository.cpp +++ b/indra/newview/llmeshrepository.cpp @@ -2030,8 +2030,8 @@ void LLMeshUploadThread::wholeModelToLLSD(LLSD& dest, bool include_textures)  	LLSD result;  	LLSD res; -	result["folder_id"] = gInventory.findCategoryUUIDForType(LLFolderType::FT_OBJECT); -	result["texture_folder_id"] = gInventory.findCategoryUUIDForType(LLFolderType::FT_TEXTURE); +	result["folder_id"] = gInventory.findUserDefinedCategoryUUIDForType(LLFolderType::FT_OBJECT); +	result["texture_folder_id"] = gInventory.findUserDefinedCategoryUUIDForType(LLFolderType::FT_TEXTURE);  	result["asset_type"] = "mesh";  	result["inventory_type"] = "object";  	result["description"] = "(No Description)"; @@ -3536,11 +3536,11 @@ void LLMeshRepository::notifyLoadedMeshes()  			// Handle addition of texture, if any.  			if ( data.mResponse.has("new_texture_folder_id") )  			{ -				const LLUUID& folder_id = data.mResponse["new_texture_folder_id"].asUUID(); +				const LLUUID& new_folder_id = data.mResponse["new_texture_folder_id"].asUUID(); -				if ( folder_id.notNull() ) +				if ( new_folder_id.notNull() )  				{ -					LLUUID parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_TEXTURE); +					LLUUID parent_id = gInventory.findUserDefinedCategoryUUIDForType(LLFolderType::FT_TEXTURE);  					std::string name;  					// Check if the server built a different name for the texture folder @@ -3555,7 +3555,7 @@ void LLMeshRepository::notifyLoadedMeshes()  					// Add the category to the internal representation  					LLPointer<LLViewerInventoryCategory> cat =  -						new LLViewerInventoryCategory(folder_id, parent_id,  +						new LLViewerInventoryCategory(new_folder_id, parent_id,   							LLFolderType::FT_NONE, name, gAgent.getID());  					cat->setVersion(LLViewerInventoryCategory::VERSION_UNKNOWN); diff --git a/indra/newview/llpanelblockedlist.cpp b/indra/newview/llpanelblockedlist.cpp index 81ed2963e6..25ae4774fc 100644 --- a/indra/newview/llpanelblockedlist.cpp +++ b/indra/newview/llpanelblockedlist.cpp @@ -141,6 +141,9 @@ void LLPanelBlockedList::updateButtons()  	bool hasSelected = NULL != mBlockedList->getSelectedItem();  	getChildView("unblock_btn")->setEnabled(hasSelected);  	getChildView("blocked_gear_btn")->setEnabled(hasSelected); + +	getChild<LLUICtrl>("block_limit")->setTextArg("[COUNT]", llformat("%d", mBlockedList->getMuteListSize())); +	getChild<LLUICtrl>("block_limit")->setTextArg("[LIMIT]", llformat("%d", gSavedSettings.getS32("MuteListLimit")));  }  void LLPanelBlockedList::unblockItem() diff --git a/indra/newview/llpanelface.cpp b/indra/newview/llpanelface.cpp index ec2d37c30d..ad600358dd 100644 --- a/indra/newview/llpanelface.cpp +++ b/indra/newview/llpanelface.cpp @@ -649,7 +649,7 @@ void LLPanelFace::getState()  	updateUI();  } -void LLPanelFace::updateUI() +void LLPanelFace::updateUI(bool force_set_values /*false*/)  { //set state of UI to match state of texture entry(ies)  (calls setEnabled, setValue, etc, but NOT setVisible)  	LLViewerObject* objectp = LLSelectMgr::getInstance()->getSelection()->getFirstObject(); @@ -1025,7 +1025,14 @@ void LLPanelFace::updateUI()  			getChildView("shinyScaleV")->setEnabled(editable && specmap_id.notNull());  			getChildView("bumpyScaleV")->setEnabled(editable && normmap_id.notNull()); -			getChild<LLUICtrl>("TexScaleV")->setValue(diff_scale_t); +			if (force_set_values) +			{ +				getChild<LLSpinCtrl>("TexScaleV")->forceSetValue(diff_scale_t); +			} +			else +			{ +				getChild<LLSpinCtrl>("TexScaleV")->setValue(diff_scale_t); +			}  			getChild<LLUICtrl>("shinyScaleV")->setValue(norm_scale_t);  			getChild<LLUICtrl>("bumpyScaleV")->setValue(spec_scale_t); @@ -1235,8 +1242,17 @@ void LLPanelFace::updateUI()  				BOOL repeats_tentative = !identical_repeats;  				getChildView("rptctrl")->setEnabled(identical_planar_texgen ? FALSE : enabled); -				getChild<LLUICtrl>("rptctrl")->setValue(editable ? repeats : 1.0f); -				getChild<LLUICtrl>("rptctrl")->setTentative(LLSD(repeats_tentative)); +				LLSpinCtrl* rpt_ctrl = getChild<LLSpinCtrl>("rptctrl"); +				if (force_set_values) +				{ +					//onCommit, previosly edited element updates related ones +					rpt_ctrl->forceSetValue(editable ? repeats : 1.0f); +				} +				else +				{ +					rpt_ctrl->setValue(editable ? repeats : 1.0f); +				} +				rpt_ctrl->setTentative(LLSD(repeats_tentative));  			}  		} @@ -1974,6 +1990,8 @@ void LLPanelFace::onCommitTextureInfo( LLUICtrl* ctrl, void* userdata )  {  	LLPanelFace* self = (LLPanelFace*) userdata;  	self->sendTextureInfo(); +	// vertical scale and repeats per meter depends on each other, so force set on changes +	self->updateUI(true);  }  // Commit the number of repeats per meter @@ -2038,6 +2056,8 @@ void LLPanelFace::onCommitRepeatsPerMeter(LLUICtrl* ctrl, void* userdata)  			llassert(false);  		break;  	} +	// vertical scale and repeats per meter depends on each other, so force set on changes +	self->updateUI(true);  }  struct LLPanelFaceSetMediaFunctor : public LLSelectedTEFunctor diff --git a/indra/newview/llpanelface.h b/indra/newview/llpanelface.h index 9823e84cd9..078995e787 100644 --- a/indra/newview/llpanelface.h +++ b/indra/newview/llpanelface.h @@ -152,7 +152,8 @@ protected:  	// Make UI reflect state of currently selected material (refresh)  	// and UI mode (e.g. editing normal map v diffuse map)  	// -	void updateUI(); +	// @param force_set_values forces spinners to set value even if they are focused +	void updateUI(bool force_set_values = false);  	// Convenience func to determine if all faces in selection have  	// identical planar texgen settings during edits diff --git a/indra/newview/llpanelobjectinventory.cpp b/indra/newview/llpanelobjectinventory.cpp index c4211d5508..6409620336 100644 --- a/indra/newview/llpanelobjectinventory.cpp +++ b/indra/newview/llpanelobjectinventory.cpp @@ -1519,6 +1519,7 @@ LLPanelObjectInventory::LLPanelObjectInventory(const LLPanelObjectInventory::Par  	mCommitCallbackRegistrar.add("Inventory.AttachObject", boost::bind(&do_nothing));  	mCommitCallbackRegistrar.add("Inventory.BeginIMSession", boost::bind(&do_nothing));  	mCommitCallbackRegistrar.add("Inventory.Share",  boost::bind(&LLAvatarActions::shareWithAvatars, this)); +	mCommitCallbackRegistrar.add("Inventory.FileUploadLocation", boost::bind(&do_nothing));  }  // Destroys the object @@ -1849,6 +1850,7 @@ void LLPanelObjectInventory::refresh()  			if(mTaskUUID != object->mID)  			{  				mTaskUUID = object->mID; +				mAttachmentUUID = object->getAttachmentItemID();  				make_request = TRUE;  				// This is a new object so pre-emptively clear the contents @@ -1858,6 +1860,16 @@ void LLPanelObjectInventory::refresh()  				// Register for updates from this object,  				registerVOInventoryListener(object,NULL);  			} +			else if (mAttachmentUUID != object->getAttachmentItemID()) +			{ +				mAttachmentUUID = object->getAttachmentItemID(); +				if (mAttachmentUUID.notNull()) +				{ +					// Server unsubsribes viewer (deselects object) from property +					// updates after "ObjectAttach" so we need to resubscribe +					LLSelectMgr::getInstance()->sendSelect(); +				} +			}  			// Based on the node information, we may need to dirty the  			// object inventory and get it again. @@ -1888,6 +1900,7 @@ void LLPanelObjectInventory::refresh()  void LLPanelObjectInventory::clearInventoryTask()  {  	mTaskUUID = LLUUID::null; +	mAttachmentUUID = LLUUID::null;  	removeVOInventoryListener();  	clearContents();  } diff --git a/indra/newview/llpanelobjectinventory.h b/indra/newview/llpanelobjectinventory.h index 3de49242ac..d700c8f4cf 100644 --- a/indra/newview/llpanelobjectinventory.h +++ b/indra/newview/llpanelobjectinventory.h @@ -105,6 +105,7 @@ private:  	LLFolderView* mFolders;  	LLUUID mTaskUUID; +	LLUUID mAttachmentUUID;  	BOOL mHaveInventory;  	BOOL mIsInventoryEmpty;  	BOOL mInventoryNeedsUpdate; diff --git a/indra/newview/llpanelplaces.cpp b/indra/newview/llpanelplaces.cpp index 5d43c38612..ed942fc7fc 100644 --- a/indra/newview/llpanelplaces.cpp +++ b/indra/newview/llpanelplaces.cpp @@ -304,7 +304,11 @@ BOOL LLPanelPlaces::postBuild()  	enable_registrar.add("Places.OverflowMenu.Enable",  boost::bind(&LLPanelPlaces::onOverflowMenuItemEnable, this, _2));  	mPlaceMenu = LLUICtrlFactory::getInstance()->createFromFile<LLToggleableMenu>("menu_place.xml", gMenuHolder, LLViewerMenuHolderGL::child_registry_t::instance()); -	if (!mPlaceMenu) +	if (mPlaceMenu) +	{ +		mPlaceMenu->setAlwaysShowMenu(TRUE); +	} +	else  	{  		LL_WARNS() << "Error loading Place menu" << LL_ENDL;  	} @@ -1006,7 +1010,7 @@ void LLPanelPlaces::togglePlaceInfoPanel(BOOL visible)  			 mPlaceInfoType == LANDMARK_TAB_INFO_TYPE)  	{  		mLandmarkInfo->setVisible(visible); - +		mPlaceProfile->setVisible(FALSE);  		if (visible)  		{  			mLandmarkInfo->resetLocation(); @@ -1014,8 +1018,6 @@ void LLPanelPlaces::togglePlaceInfoPanel(BOOL visible)  			LLRect rect = getRect();  			LLRect new_rect = LLRect(rect.mLeft, rect.mTop, rect.mRight, mTabContainer->getRect().mBottom);  			mLandmarkInfo->reshape(new_rect.getWidth(), new_rect.getHeight()); - -			mPlaceProfile->setVisible(FALSE);  		}  		else  		{ diff --git a/indra/newview/llpanelprimmediacontrols.cpp b/indra/newview/llpanelprimmediacontrols.cpp index 0bcd8a9e63..5f413fc3c0 100644 --- a/indra/newview/llpanelprimmediacontrols.cpp +++ b/indra/newview/llpanelprimmediacontrols.cpp @@ -566,11 +566,16 @@ void LLPanelPrimMediaControls::updateShape()  			}  		} -		// MAINT-1392 If this is a HUD always set it visible, but hide each control if user has no perms. -		// When setting it invisible it won't receive any mouse messages anymore +		// Web plugins and HUD may have media controls invisible for user, but still need scroll mouse events. +		// LLView checks for visibleEnabledAndContains() and won't pass events to invisible panel, so instead +		// of hiding whole panel hide each control instead (if user has no perms). +		// Note: It might be beneficial to keep panel visible for all plugins to make behavior consistent, but  +		// for now limiting change to cases that need events. -		if( !is_hud ) +		if (!is_hud && (!media_plugin || media_plugin->pluginSupportsMediaTime())) +		{  			setVisible(enabled); +		}  		else  		{  			if( !hasPermsControl ) diff --git a/indra/newview/llselectmgr.cpp b/indra/newview/llselectmgr.cpp index dd934ce6b8..ee7c22800a 100644 --- a/indra/newview/llselectmgr.cpp +++ b/indra/newview/llselectmgr.cpp @@ -4416,6 +4416,9 @@ void LLSelectMgr::sendAttach(U8 attachment_point, bool replace)  			SEND_ONLY_ROOTS );  		if (!build_mode)  		{ +			// After "ObjectAttach" server will unsubscribe us from properties updates +			// so either deselect objects or resend selection after attach packet reaches server +			// In case of build_mode LLPanelObjectInventory::refresh() will deal with selection  			deselectAll();  		}  	} @@ -7101,7 +7104,7 @@ F32 LLObjectSelection::getSelectedLinksetCost()  		LLSelectNode* node = *iter;  		LLViewerObject* object = node->getObject(); -		if (object) +		if (object && !object->isAttachment())  		{  			LLViewerObject* root = static_cast<LLViewerObject*>(object->getRoot());  			if (root) diff --git a/indra/newview/llsidepanelappearance.cpp b/indra/newview/llsidepanelappearance.cpp index a32ed258f8..3e95811bb8 100644 --- a/indra/newview/llsidepanelappearance.cpp +++ b/indra/newview/llsidepanelappearance.cpp @@ -421,6 +421,7 @@ void LLSidepanelAppearance::toggleWearableEditPanel(BOOL visible, LLViewerWearab  	{  		// Save changes if closing.  		mEditWearable->saveChanges(); +		mEditWearable->setWearable(NULL);  		LLAppearanceMgr::getInstance()->updateIsDirty();  		if (change_state)  		{ diff --git a/indra/newview/llsidepaneliteminfo.cpp b/indra/newview/llsidepaneliteminfo.cpp index 12cbff888d..af2173dd17 100644 --- a/indra/newview/llsidepaneliteminfo.cpp +++ b/indra/newview/llsidepaneliteminfo.cpp @@ -779,23 +779,7 @@ void LLSidepanelItemInfo::onCommitName()  	{  		LLPointer<LLViewerInventoryItem> new_item = new LLViewerInventoryItem(item);  		new_item->rename(labelItemName->getText()); -		if(mObjectID.isNull()) -		{ -			new_item->updateServer(FALSE); -			gInventory.updateItem(new_item); -			gInventory.notifyObservers(); -		} -		else -		{ -			LLViewerObject* object = gObjectList.findObject(mObjectID); -			if(object) -			{ -				object->updateInventory( -					new_item, -					TASK_INVENTORY_ITEM_KEY, -					false); -			} -		} +		onCommitChanges(new_item);  	}  } @@ -816,23 +800,7 @@ void LLSidepanelItemInfo::onCommitDescription()  		LLPointer<LLViewerInventoryItem> new_item = new LLViewerInventoryItem(item);  		new_item->setDescription(labelItemDesc->getText()); -		if(mObjectID.isNull()) -		{ -			new_item->updateServer(FALSE); -			gInventory.updateItem(new_item); -			gInventory.notifyObservers(); -		} -		else -		{ -			LLViewerObject* object = gObjectList.findObject(mObjectID); -			if(object) -			{ -				object->updateInventory( -					new_item, -					TASK_INVENTORY_ITEM_KEY, -					false); -			} -		} +		onCommitChanges(new_item);  	}  } @@ -908,23 +876,7 @@ void LLSidepanelItemInfo::onCommitPermissions()  			flags |= LLInventoryItemFlags::II_FLAGS_OBJECT_PERM_OVERWRITE_GROUP;  		}  		new_item->setFlags(flags); -		if(mObjectID.isNull()) -		{ -			new_item->updateServer(FALSE); -			gInventory.updateItem(new_item); -			gInventory.notifyObservers(); -		} -		else -		{ -			LLViewerObject* object = gObjectList.findObject(mObjectID); -			if(object) -			{ -				object->updateInventory( -					new_item, -					TASK_INVENTORY_ITEM_KEY, -					false); -			} -		} +		onCommitChanges(new_item);  	}  	else  	{ @@ -1008,25 +960,7 @@ void LLSidepanelItemInfo::updateSaleInfo()  		}  		new_item->setSaleInfo(sale_info); -		if(mObjectID.isNull()) -		{ -			// This is in the agent's inventory. -			new_item->updateServer(FALSE); -			gInventory.updateItem(new_item); -			gInventory.notifyObservers(); -		} -		else -		{ -			// This is in an object's contents. -			LLViewerObject* object = gObjectList.findObject(mObjectID); -			if(object) -			{ -				object->updateInventory( -					new_item, -					TASK_INVENTORY_ITEM_KEY, -					false); -			} -		} +		onCommitChanges(new_item);  	}  	else  	{ @@ -1035,6 +969,45 @@ void LLSidepanelItemInfo::updateSaleInfo()  	}  } +void LLSidepanelItemInfo::onCommitChanges(LLPointer<LLViewerInventoryItem> item) +{ +    if (item.isNull()) +    { +        return; +    } + +    if (mObjectID.isNull()) +    { +        // This is in the agent's inventory. +        item->updateServer(FALSE); +        gInventory.updateItem(item); +        gInventory.notifyObservers(); +    } +    else +    { +        // This is in an object's contents. +        LLViewerObject* object = gObjectList.findObject(mObjectID); +        if (object) +        { +            object->updateInventory( +                item, +                TASK_INVENTORY_ITEM_KEY, +                false); + +            if (object->isSelected()) +            { +                // Since object is selected (build floater is open) object will +                // receive properties update, detect serial mismatch, dirty and +                // reload inventory, meanwhile some other updates will refresh it. +                // So mark dirty early, this will prevent unnecessary changes +                // and download will be triggered by LLPanelObjectInventory - it +                // prevents flashing in content tab and some duplicated request. +                object->dirtyInventory(); +            } +        } +    } +} +  LLViewerInventoryItem* LLSidepanelItemInfo::findItem() const  {  	LLViewerInventoryItem* item = NULL; diff --git a/indra/newview/llsidepaneliteminfo.h b/indra/newview/llsidepaneliteminfo.h index 2e24e58a2a..74cf7afe35 100644 --- a/indra/newview/llsidepaneliteminfo.h +++ b/indra/newview/llsidepaneliteminfo.h @@ -89,6 +89,7 @@ protected:  	void 						onCommitSaleInfo();  	void 						onCommitSaleType();  	void 						updateSaleInfo(); +	void 						onCommitChanges(LLPointer<LLViewerInventoryItem> item);  };  #endif // LL_LLSIDEPANELITEMINFO_H diff --git a/indra/newview/llstartup.cpp b/indra/newview/llstartup.cpp index 1bb3d65e05..b762b2ae1c 100644 --- a/indra/newview/llstartup.cpp +++ b/indra/newview/llstartup.cpp @@ -256,6 +256,7 @@ boost::scoped_ptr<LLViewerStats::PhaseMap> LLStartUp::sPhases(new LLViewerStats:  void login_show();  void login_callback(S32 option, void* userdata); +void show_release_notes_if_required();  void show_first_run_dialog();  bool first_run_dialog_callback(const LLSD& notification, const LLSD& response);  void set_startup_status(const F32 frac, const std::string& string, const std::string& msg); @@ -682,10 +683,17 @@ bool idle_startup()  		}  		else if (gSavedSettings.getBOOL("AutoLogin"))    		{ +			// Log into last account  			gRememberPassword = TRUE;  			gSavedSettings.setBOOL("RememberPassword", TRUE);                                                        			show_connect_box = false;    			  		} +		else if (gSavedSettings.getLLSD("UserLoginInfo").size() == 3) +		{ +			// Console provided login&password +			gRememberPassword = gSavedSettings.getBOOL("RememberPassword"); +			show_connect_box = false; +		}  		else   		{  			gRememberPassword = gSavedSettings.getBOOL("RememberPassword"); @@ -709,6 +717,7 @@ bool idle_startup()  		set_startup_status(0.03f, msg.c_str(), gAgent.mMOTD.c_str());  		display_startup();  		// LLViewerMedia::initBrowser(); +		show_release_notes_if_required();  		LLStartUp::setStartupState( STATE_LOGIN_SHOW );  		return FALSE;  	} @@ -2247,6 +2256,22 @@ void login_callback(S32 option, void *userdata)  	}  } +/** +* Check if user is running a new version of the viewer. +* Display the Release Notes if it's not overriden by the "UpdaterShowReleaseNotes" setting. +*/ +void show_release_notes_if_required() +{ +    if (LLVersionInfo::getChannelAndVersion() != gLastRunVersion +        && LLVersionInfo::getViewerMaturity() != LLVersionInfo::TEST_VIEWER // don't show Release Notes for the test builds +        && gSavedSettings.getBOOL("UpdaterShowReleaseNotes") +        && !gSavedSettings.getBOOL("FirstLoginThisInstall")) +    { +        LLSD info(LLAppViewer::instance()->getViewerInfo()); +        LLWeb::loadURLInternal(info["VIEWER_RELEASE_NOTES_URL"]); +    } +} +  void show_first_run_dialog()  {  	LLNotificationsUtil::add("FirstRun", LLSD(), LLSD(), first_run_dialog_callback); diff --git a/indra/newview/llsyntaxid.cpp b/indra/newview/llsyntaxid.cpp index 9e54c521b5..10a9dee415 100644 --- a/indra/newview/llsyntaxid.cpp +++ b/indra/newview/llsyntaxid.cpp @@ -50,6 +50,7 @@ LLSyntaxIdLSL::LLSyntaxIdLSL()  ,	mCapabilityURL(std::string())  ,	mFilePath(LL_PATH_APP_SETTINGS)  ,	mSyntaxId(LLUUID()) +,	mInitialized(false)  {  	loadDefaultKeywordsIntoLLSD();  	mRegionChangedCallback = gAgent.addRegionChangedCallback(boost::bind(&LLSyntaxIdLSL::handleRegionChanged, this)); @@ -179,6 +180,7 @@ void LLSyntaxIdLSL::cacheFile(const std::string &fileSpec, const LLSD& content_r  //-----------------------------------------------------------------------------  void LLSyntaxIdLSL::initialize()  { +	if(mInitialized) return;  	if (mSyntaxId.isNull())  	{  		loadDefaultKeywordsIntoLLSD(); @@ -213,6 +215,7 @@ void LLSyntaxIdLSL::initialize()  		LL_DEBUGS("SyntaxLSL") << "LSLSyntaxId capability URL is empty." << LL_ENDL;  		loadDefaultKeywordsIntoLLSD();  	} +	mInitialized = true;  }  //----------------------------------------------------------------------------- @@ -303,6 +306,7 @@ void LLSyntaxIdLSL::handleRegionChanged()  	{  		buildFullFileSpec();  		fetchKeywordsFile(mFullFileSpec); +		mInitialized = false;  	}  } diff --git a/indra/newview/llsyntaxid.h b/indra/newview/llsyntaxid.h index 1360b3e042..caddba5527 100644 --- a/indra/newview/llsyntaxid.h +++ b/indra/newview/llsyntaxid.h @@ -65,6 +65,7 @@ private:  	ELLPath			mFilePath;  	LLUUID			mSyntaxId;  	LLSD			mKeywordsXml; +	bool 			mInitialized;  public:  	void initialize(); diff --git a/indra/newview/lltoolpie.cpp b/indra/newview/lltoolpie.cpp index e17651dc91..e79ce55854 100644 --- a/indra/newview/lltoolpie.cpp +++ b/indra/newview/lltoolpie.cpp @@ -338,56 +338,41 @@ BOOL LLToolPie::handleLeftClickPick()  	// If left-click never selects or spawns a menu  	// Eat the event. -	if (!gSavedSettings.getBOOL("LeftClickShowMenu")) + +	// mouse already released +	if (!mMouseButtonDown)  	{ -		// mouse already released -		if (!mMouseButtonDown) -		{ -			return true; -		} +		return true; +	} -		while( object && object->isAttachment() && !object->flagHandleTouch()) +	while (object && object->isAttachment() && !object->flagHandleTouch()) +	{ +		// don't pick avatar through hud attachment +		if (object->isHUDAttachment())  		{ -			// don't pick avatar through hud attachment -			if (object->isHUDAttachment()) -			{ -				break; -			} -			object = (LLViewerObject*)object->getParent(); +			break;  		} -		if (object && object == gAgentAvatarp && !gSavedSettings.getBOOL("ClickToWalk")) -		{ -			// we left clicked on avatar, switch to focus mode -			mMouseButtonDown = false; -			LLToolMgr::getInstance()->setTransientTool(LLToolCamera::getInstance()); -			gViewerWindow->hideCursor(); -			LLToolCamera::getInstance()->setMouseCapture(TRUE); -			LLToolCamera::getInstance()->pickCallback(mPick); -			gAgentCamera.setFocusOnAvatar(TRUE, TRUE); +		object = (LLViewerObject*)object->getParent(); +	} +	if (object && object == gAgentAvatarp && !gSavedSettings.getBOOL("ClickToWalk")) +	{ +		// we left clicked on avatar, switch to focus mode +		mMouseButtonDown = false; +		LLToolMgr::getInstance()->setTransientTool(LLToolCamera::getInstance()); +		gViewerWindow->hideCursor(); +		LLToolCamera::getInstance()->setMouseCapture(TRUE); +		LLToolCamera::getInstance()->pickCallback(mPick); +		gAgentCamera.setFocusOnAvatar(TRUE, TRUE); -			return TRUE; -		} +		return TRUE; +	}  	//////////  	//	// Could be first left-click on nothing  	//	LLFirstUse::useLeftClickNoHit();  	///////// -		 -		// Eat the event -		return LLTool::handleMouseDown(x, y, mask); -	} - -	if (gAgent.leftButtonGrabbed()) -	{ -		// if the left button is grabbed, don't put up the pie menu -		return LLTool::handleMouseDown(x, y, mask); -	} - -	// Can't ignore children here. -	LLToolSelect::handleObjectSelection(mPick, FALSE, TRUE); -	// Spawn pie menu -	LLTool::handleRightMouseDown(x, y, mask); -	return TRUE; +	// Eat the event +	return LLTool::handleMouseDown(x, y, mask);  }  BOOL LLToolPie::useClickAction(MASK mask,  diff --git a/indra/newview/llviewerassetupload.cpp b/indra/newview/llviewerassetupload.cpp index cafaf8645a..49d29c0e4e 100644 --- a/indra/newview/llviewerassetupload.cpp +++ b/indra/newview/llviewerassetupload.cpp @@ -307,10 +307,9 @@ void LLResourceUploadInfo::assignDefaults()          mDescription = "(No Description)";      } -    mFolderId = gInventory.findCategoryUUIDForType( +    mFolderId = gInventory.findUserDefinedCategoryUUIDForType(          (mDestinationFolderType == LLFolderType::FT_NONE) ?          (LLFolderType::EType)mAssetType : mDestinationFolderType); -  }  std::string LLResourceUploadInfo::getDisplayName() const diff --git a/indra/newview/llviewercontrol.cpp b/indra/newview/llviewercontrol.cpp index db71849659..7c1921b143 100644 --- a/indra/newview/llviewercontrol.cpp +++ b/indra/newview/llviewercontrol.cpp @@ -507,7 +507,7 @@ bool handleVelocityInterpolate(const LLSD& newvalue)  bool handleForceShowGrid(const LLSD& newvalue)  { -	LLPanelLogin::updateServer( ); +	LLPanelLogin::updateLocationSelectorsVisibility();  	return true;  } diff --git a/indra/newview/llviewerparcelmgr.cpp b/indra/newview/llviewerparcelmgr.cpp index dddfb6745e..2a126c9f01 100644 --- a/indra/newview/llviewerparcelmgr.cpp +++ b/indra/newview/llviewerparcelmgr.cpp @@ -706,7 +706,7 @@ bool LLViewerParcelMgr::allowAgentScripts(const LLViewerRegion* region, const LL  bool LLViewerParcelMgr::allowAgentDamage(const LLViewerRegion* region, const LLParcel* parcel) const  {  	return (region && region->getAllowDamage()) -		&& (parcel && parcel->getAllowDamage()); +		|| (parcel && parcel->getAllowDamage());  }  BOOL LLViewerParcelMgr::isOwnedAt(const LLVector3d& pos_global) const diff --git a/indra/newview/llviewertexteditor.cpp b/indra/newview/llviewertexteditor.cpp index 09cdfe1309..9e09971ced 100644 --- a/indra/newview/llviewertexteditor.cpp +++ b/indra/newview/llviewertexteditor.cpp @@ -191,7 +191,7 @@ public:  		return false;  	} -	/*virtual*/ S32				getNumChars(S32 num_pixels, S32 segment_offset, S32 line_offset, S32 max_chars) const  +	/*virtual*/ S32				getNumChars(S32 num_pixels, S32 segment_offset, S32 line_offset, S32 max_chars, S32 line_ind) const  	{  		// always draw at beginning of line  		if (line_offset == 0) @@ -1105,10 +1105,6 @@ BOOL LLViewerTextEditor::openEmbeddedItem(LLPointer<LLInventoryItem> item, llwch  			openEmbeddedSound( item, wc );  			return TRUE; -		case LLAssetType::AT_NOTECARD: -			openEmbeddedNotecard( item, wc ); -			return TRUE; -  		case LLAssetType::AT_LANDMARK:  			openEmbeddedLandmark( item, wc );  			return TRUE; @@ -1117,6 +1113,7 @@ BOOL LLViewerTextEditor::openEmbeddedItem(LLPointer<LLInventoryItem> item, llwch  			openEmbeddedCallingcard( item, wc );  			return TRUE; +		case LLAssetType::AT_NOTECARD:  		case LLAssetType::AT_LSL_TEXT:  		case LLAssetType::AT_CLOTHING:  		case LLAssetType::AT_OBJECT: @@ -1182,11 +1179,6 @@ void LLViewerTextEditor::openEmbeddedLandmark( LLPointer<LLInventoryItem> item_p  	}  } -void LLViewerTextEditor::openEmbeddedNotecard( LLInventoryItem* item, llwchar wc ) -{ -	copyInventory(item, gInventoryCallbacks.registerCB(mInventoryCallback)); -} -  void LLViewerTextEditor::openEmbeddedCallingcard( LLInventoryItem* item, llwchar wc )  {  	if(item && !item->getCreatorUUID().isNull()) diff --git a/indra/newview/llviewertexteditor.h b/indra/newview/llviewertexteditor.h index 477119d4f2..33cfca4f90 100644 --- a/indra/newview/llviewertexteditor.h +++ b/indra/newview/llviewertexteditor.h @@ -105,7 +105,6 @@ private:  	void			openEmbeddedTexture( LLInventoryItem* item, llwchar wc );  	void			openEmbeddedSound( LLInventoryItem* item, llwchar wc );  	void			openEmbeddedLandmark( LLPointer<LLInventoryItem> item_ptr, llwchar wc ); -	void			openEmbeddedNotecard( LLInventoryItem* item, llwchar wc);  	void			openEmbeddedCallingcard( LLInventoryItem* item, llwchar wc);  	void			showCopyToInvDialog( LLInventoryItem* item, llwchar wc );  	void			showUnsavedAlertDialog( LLInventoryItem* item ); diff --git a/indra/newview/llvoavatar.cpp b/indra/newview/llvoavatar.cpp index 96a1beffbc..8888879b8a 100644 --- a/indra/newview/llvoavatar.cpp +++ b/indra/newview/llvoavatar.cpp @@ -118,6 +118,9 @@ extern U32 JOINT_COUNT_REQUIRED_FOR_FULLRIG;  const F32 MAX_HOVER_Z = 2.0;  const F32 MIN_HOVER_Z = -2.0; +const F32 MIN_ATTACHMENT_COMPLEXITY = 0.f; +const F32 MAX_ATTACHMENT_COMPLEXITY = 1.0e6f; +  using namespace LLAvatarAppearanceDefines;  //----------------------------------------------------------------------------- @@ -9056,10 +9059,10 @@ void LLVOAvatar::calculateUpdateRenderComplexity()  						const LLVOVolume* volume = drawable->getVOVolume();  						if (volume)  						{ -                            U32 attachment_total_cost = 0; -                            U32 attachment_volume_cost = 0; -                            U32 attachment_texture_cost = 0; -                            U32 attachment_children_cost = 0; +                            F32 attachment_total_cost = 0; +                            F32 attachment_volume_cost = 0; +                            F32 attachment_texture_cost = 0; +                            F32 attachment_children_cost = 0;  							attachment_volume_cost += volume->getRenderCost(textures); @@ -9083,7 +9086,6 @@ void LLVOAvatar::calculateUpdateRenderComplexity()  								// add the cost of each individual texture in the linkset  								attachment_texture_cost += volume_texture->second;  							} -                              attachment_total_cost = attachment_volume_cost + attachment_texture_cost + attachment_children_cost;                              LL_DEBUGS("ARCdetail") << "Attachment costs " << attached_object->getAttachmentItemID()                                                     << " total: " << attachment_total_cost @@ -9092,7 +9094,8 @@ void LLVOAvatar::calculateUpdateRenderComplexity()                                                     << ", " << volume->numChildren()                                                     << " children: " << attachment_children_cost                                                     << LL_ENDL; -                            cost += attachment_total_cost; +                            // Limit attachment complexity to avoid signed integer flipping of the wearer's ACI +                            cost += (U32)llclamp(attachment_total_cost, MIN_ATTACHMENT_COMPLEXITY, MAX_ATTACHMENT_COMPLEXITY);  						}  					}  				} diff --git a/indra/newview/llwlanimator.cpp b/indra/newview/llwlanimator.cpp index 2142885767..c8879e73eb 100644 --- a/indra/newview/llwlanimator.cpp +++ b/indra/newview/llwlanimator.cpp @@ -155,17 +155,28 @@ F64 LLWLAnimator::getDayTime()  		// we're not solving the non-linear equation that determines sun phase  		// we're just linearly interpolating between the major points -		if (phase <= 5.0 / 4.0) { + +		if (phase <= 5.0 / 4.0) +		{ +			// mDayTime from 0.33 to 0.75 (6:00 to 21:00)  			mDayTime = (1.0 / 3.0) * phase + (1.0 / 3.0);  		} +		else if (phase > 7.0 / 4.0) +		{ +			// maximum value for phase is 2 +			// mDayTime from 0.25 to 0.33 (3:00 to 6:00) +			mDayTime = (1.0 / 3.0) - (1.0 / 3.0) * (2 - phase); +		}  		else  		{ +			// phase == 3/2 is where day restarts (24:00) +			// mDayTime from 0.75 to 0.999 and 0 to 0.25 (21:00 to 03:00)  			mDayTime = phase - (1.0 / 2.0); -		} -		if(mDayTime > 1) -		{ -			mDayTime--; +			if(mDayTime > 1) +			{ +				mDayTime--; +			}  		}  		return mDayTime; diff --git a/indra/newview/pipeline.cpp b/indra/newview/pipeline.cpp index 890839e6e6..19487c3230 100644 --- a/indra/newview/pipeline.cpp +++ b/indra/newview/pipeline.cpp @@ -7773,12 +7773,10 @@ void LLPipeline::renderBloom(BOOL for_snapshot, F32 zoom_factor, int subfield)  			F32 fov = LLViewerCamera::getInstance()->getView();  			const F32 default_fov = CameraFieldOfView * F_PI/180.f; -			//const F32 default_aspect_ratio = gSavedSettings.getF32("CameraAspectRatio");  			//F32 aspect_ratio = (F32) mScreen.getWidth()/(F32)mScreen.getHeight();  			F32 dv = 2.f*default_focal_length * tanf(default_fov/2.f); -			//F32 dh = 2.f*default_focal_length * tanf(default_fov*default_aspect_ratio/2.f);  			F32 focal_length = dv/(2*tanf(fov/2.f)); diff --git a/indra/newview/skins/default/xui/en/floater_about_land.xml b/indra/newview/skins/default/xui/en/floater_about_land.xml index 8391bacf51..a137770e26 100644 --- a/indra/newview/skins/default/xui/en/floater_about_land.xml +++ b/indra/newview/skins/default/xui/en/floater_about_land.xml @@ -2014,7 +2014,7 @@ Only large parcels can be listed in search.               name="AllowedText"               top="0"               width="230"> -                Allowed Residents ([COUNT]) +                Allowed Residents ([COUNT], max [MAX])              </text>              <name_list               column_padding="0" @@ -2063,7 +2063,7 @@ Only large parcels can be listed in search.               name="BanCheck"               top="0"               width="200"> -                Banned Residents ([COUNT]) +                Banned Residents ([COUNT], max [MAX])              </text>              <name_list               column_padding="0" diff --git a/indra/newview/skins/default/xui/en/floater_inspect.xml b/indra/newview/skins/default/xui/en/floater_inspect.xml index bea35e5fc1..63334e2b24 100644 --- a/indra/newview/skins/default/xui/en/floater_inspect.xml +++ b/indra/newview/skins/default/xui/en/floater_inspect.xml @@ -27,21 +27,21 @@       tool_tip="Select an object from this list to highlight it in-world"       top="20">          <scroll_list.columns -         dynamic_width="true" +         relative_width="0.25"           label="Object Name"           name="object_name" />          <scroll_list.columns -         dynamic_width="true" +         relative_width="0.25"           label="Owner Name"           name="owner_name" />          <scroll_list.columns -         dynamic_width="true" +         relative_width="0.25"           label="Creator Name"           name="creator_name" />          <scroll_list.columns +         relative_width="0.25"           label="Creation Date" -         name="creation_date" -         width="150" /> +         name="creation_date" />  		 <scroll_list.commit_callback  		   function="Inspect.SelectObject" />      </scroll_list> diff --git a/indra/newview/skins/default/xui/en/floater_pathfinding_linksets.xml b/indra/newview/skins/default/xui/en/floater_pathfinding_linksets.xml index 52d03cc432..00d70556b4 100644 --- a/indra/newview/skins/default/xui/en/floater_pathfinding_linksets.xml +++ b/indra/newview/skins/default/xui/en/floater_pathfinding_linksets.xml @@ -290,7 +290,7 @@        layout="topleft"        left="0"        height="67" -      width="1010"> +      width="1070">      <text          name="linksets_actions_label"          height="13" diff --git a/indra/newview/skins/default/xui/en/floater_preferences.xml b/indra/newview/skins/default/xui/en/floater_preferences.xml index 9a9101e0da..5ca527ad20 100644 --- a/indra/newview/skins/default/xui/en/floater_preferences.xml +++ b/indra/newview/skins/default/xui/en/floater_preferences.xml @@ -120,6 +120,13 @@           layout="topleft"           help_topic="preferences_advanced1_tab"           name="advanced1" /> +        <panel +         class="panel_preference" +         filename="panel_preferences_uploads.xml" +         label="Uploads" +         layout="topleft" +         help_topic="preferences_uploads_tab" +         name="uploads" />      </tab_container>  </floater> diff --git a/indra/newview/skins/default/xui/en/floater_scene_load_stats.xml b/indra/newview/skins/default/xui/en/floater_scene_load_stats.xml index b53698a9f2..62cce3a1e3 100644 --- a/indra/newview/skins/default/xui/en/floater_scene_load_stats.xml +++ b/indra/newview/skins/default/xui/en/floater_scene_load_stats.xml @@ -7,6 +7,7 @@           save_rect="true"           save_visibility="true"           title="SCENE LOAD STATISTICS" +         min_width="250"           width="400">      <scroll_container follows="top|left|bottom|right"                        bottom="400" diff --git a/indra/newview/skins/default/xui/en/floater_script_debug.xml b/indra/newview/skins/default/xui/en/floater_script_debug.xml index 53d4925214..cd88048d6b 100644 --- a/indra/newview/skins/default/xui/en/floater_script_debug.xml +++ b/indra/newview/skins/default/xui/en/floater_script_debug.xml @@ -7,6 +7,7 @@   help_topic="script_debug_floater"   save_rect="true"   title="Script Warning/Error" + reuse_instance="true"   width="450">      <tab_container       follows="left|top|right|bottom" diff --git a/indra/newview/skins/default/xui/en/floater_stats.xml b/indra/newview/skins/default/xui/en/floater_stats.xml index be9b93837a..e4f735740b 100644 --- a/indra/newview/skins/default/xui/en/floater_stats.xml +++ b/indra/newview/skins/default/xui/en/floater_stats.xml @@ -8,6 +8,7 @@           save_rect="true"           save_visibility="true"           title="STATISTICS" +         min_width="250"           width="270">    <scroll_container follows="all"                      height="380" diff --git a/indra/newview/skins/default/xui/en/menu_gesture_gear.xml b/indra/newview/skins/default/xui/en/menu_gesture_gear.xml index b08d21e8f4..c1458977ca 100644 --- a/indra/newview/skins/default/xui/en/menu_gesture_gear.xml +++ b/indra/newview/skins/default/xui/en/menu_gesture_gear.xml @@ -5,8 +5,7 @@   name="menu_gesture_gear"   visible="false">      <menu_item_call -     font="SansSerifBold" -     label="Add/Remove from Favorites" +     label="Activate/Deactivate selected gesture"       layout="topleft"       name="activate">          <on_click diff --git a/indra/newview/skins/default/xui/en/menu_inventory.xml b/indra/newview/skins/default/xui/en/menu_inventory.xml index 5b8a9413bf..e1f9269c70 100644 --- a/indra/newview/skins/default/xui/en/menu_inventory.xml +++ b/indra/newview/skins/default/xui/en/menu_inventory.xml @@ -322,6 +322,43 @@          </menu_item_call>      </menu>      <menu +     label="Use as default for" +     layout="topleft" +     name="upload_def"> +      <menu_item_call +       label="Image uploads" +       layout="topleft" +       name="Image uploads"> +        <menu_item_call.on_click +         function="Inventory.FileUploadLocation" +         parameter="texture" /> +      </menu_item_call> +      <menu_item_call +       label="Sound uploads" +       layout="topleft" +       name="Sound uploads"> +        <menu_item_call.on_click +         function="Inventory.FileUploadLocation" +         parameter="sound" /> +      </menu_item_call> +      <menu_item_call +       label="Animation uploads" +       layout="topleft" +       name="Animation uploads"> +        <menu_item_call.on_click +         function="Inventory.FileUploadLocation" +         parameter="animation" /> +      </menu_item_call> +      <menu_item_call +       label="Model uploads" +       layout="topleft" +       name="Model uploads"> +        <menu_item_call.on_click +         function="Inventory.FileUploadLocation" +         parameter="model" /> +      </menu_item_call> +    </menu> +    <menu       label="Change Type"       layout="topleft"       name="Change Type"> diff --git a/indra/newview/skins/default/xui/en/menu_login.xml b/indra/newview/skins/default/xui/en/menu_login.xml index a39ee5fddd..8cd0c415f4 100644 --- a/indra/newview/skins/default/xui/en/menu_login.xml +++ b/indra/newview/skins/default/xui/en/menu_login.xml @@ -20,6 +20,18 @@               function="Floater.Toggle"               parameter="preferences" />          </menu_item_call> +        <menu_item_check +         label="Show Grid Picker" +         name="Show Grid Picker" +         visible="false"  +         shortcut="control|shift|G"> +        <on_check +         function="CheckControl" +         parameter="ForceShowGrid" /> +        <on_click +         function="ToggleControl" +         parameter="ForceShowGrid" /> +        </menu_item_check>          <menu_item_separator />          <menu_item_call           label="Exit [APP_NAME]" @@ -287,18 +299,6 @@             parameter="4" />          </menu_item_check>        </menu> -     <menu_item_check -        label="Show Grid Picker" -        name="Show Grid Picker" -        visible="false"  -        shortcut="control|shift|G"> -        <on_check -         function="CheckControl" -         parameter="ForceShowGrid" /> -        <on_click -         function="ToggleControl" -         parameter="ForceShowGrid" /> -      </menu_item_check>        <menu_item_call          label="Show Notifications Console"          name="Show Notifications Console" diff --git a/indra/newview/skins/default/xui/en/menu_viewer.xml b/indra/newview/skins/default/xui/en/menu_viewer.xml index f911c2da7b..332d79e1ea 100644 --- a/indra/newview/skins/default/xui/en/menu_viewer.xml +++ b/indra/newview/skins/default/xui/en/menu_viewer.xml @@ -447,6 +447,13 @@               function="Floater.Toggle"               parameter="mini_map" />          </menu_item_check> +        <menu_item_call +             label="Events" +             name="Events"> +            <menu_item_call.on_click +             function="Advanced.ShowURL" +             parameter="http://events.secondlife.com"/> +        </menu_item_call>          <menu_item_check          label="Search..."          name="Search" @@ -1018,6 +1025,16 @@             label="Scripts"             name="Scripts"             tear_off="true"> +          <menu_item_check +             label="Script warnings/errors..." +             name="Script debug"> +            <menu_item_check.on_check +             function="Floater.IsOpen" +             parameter="script_debug" /> +            <menu_item_check.on_click +             function="Floater.ToggleOrBringToFront" +             parameter="script_debug" /> +          </menu_item_check>            <menu_item_call               label="Recompile Scripts (Mono)"               name="Mono"> diff --git a/indra/newview/skins/default/xui/en/notifications.xml b/indra/newview/skins/default/xui/en/notifications.xml index da777417ac..04a636b09e 100644 --- a/indra/newview/skins/default/xui/en/notifications.xml +++ b/indra/newview/skins/default/xui/en/notifications.xml @@ -4031,7 +4031,7 @@ An update was downloaded. It will be installed during restart.   icon="alertmodal.tga"   name="UpdateCheckError"   type="alertmodal"> -An error occured while checking for update. +An error occurred while checking for update.  Please try again later.      <tag>confirm</tag>      <usetemplate @@ -9844,29 +9844,29 @@ Eject failed because you don't have admin permission for that parcel.    <notification     icon="alertmodal.tga" -   name="CantMoveObjectParcelFull" +   name="CMOParcelFull"     type="notify">     <tag>fail</tag> -Can't move object '[OBJECT_NAME]' to -[OBJ_POSITION] in region [REGION_NAME] because the parcel is full. +Can't move object '[O]' to +[P] in region [R] because the parcel is full.    </notification>    <notification     icon="alertmodal.tga" -   name="CantMoveObjectParcelPerms" +   name="CMOParcelPerms"     type="notify">     <tag>fail</tag> -Can't move object '[OBJECT_NAME]' to -[OBJ_POSITION] in region [REGION_NAME] because your objects are not allowed on this parcel. +Can't move object '[O]' to +[P] in region [R] because your objects are not allowed on this parcel.    </notification>    <notification     icon="alertmodal.tga" -   name="CantMoveObjectParcelResources" +   name="CMOParcelResources"     type="notify">     <tag>fail</tag> -Can't move object '[OBJECT_NAME]' to -[OBJ_POSITION] in region [REGION_NAME] because there are not enough resources for this object on this parcel. +Can't move object '[O]' to +[P] in region [R] because there are not enough resources for this object on this parcel.    </notification>    <notification @@ -9879,29 +9879,29 @@ Copy failed because you lack access to that parcel.    <notification     icon="alertmodal.tga" -   name="CantMoveObjectRegionVersion" +   name="CMORegionVersion"     type="notify"> -   <tag>fail</tag> -Can't move object '[OBJECT_NAME]' to -[OBJ_POSITION] in region [REGION_NAME] because the other region is running an older version which does not support receiving this object via region crossing. +    <tag>fail</tag> +    Can't move object '[O]' to +    [P] in region [R] because the other region is running an older version which does not support receiving this object via region crossing.    </notification>    <notification     icon="alertmodal.tga" -   name="CantMoveObjectNavMesh" +   name="CMONavMesh"     type="notify">     <tag>fail</tag> -Can't move object '[OBJECT_NAME]' to -[OBJ_POSITION] in region [REGION_NAME] because you cannot modify the navmesh across region boundaries. +Can't move object '[O]' to +[P] in region [R] because you cannot modify the navmesh across region boundaries.    </notification>    <notification     icon="alertmodal.tga" -   name="CantMoveObjectWTF" +   name="CMOWTF"     type="notify">     <tag>fail</tag> -Can't move object '[OBJECT_NAME]' to -[OBJ_POSITION] in region [REGION_NAME] because of an unknown reason. ([FAILURE_TYPE]) +Can't move object '[O]' to +[P] in region [R] because of an unknown reason. ([F])    </notification>    <notification diff --git a/indra/newview/skins/default/xui/en/panel_block_list_sidetray.xml b/indra/newview/skins/default/xui/en/panel_block_list_sidetray.xml index 53d0252215..574e5f3cbc 100644 --- a/indra/newview/skins/default/xui/en/panel_block_list_sidetray.xml +++ b/indra/newview/skins/default/xui/en/panel_block_list_sidetray.xml @@ -90,13 +90,26 @@            top_delta="0"            width="31"/>       </panel> +     <text +          type="string" +          length="1" +          follows="left|top|right" +          height="14" +          layout="topleft" +          right="-10" +          top_pad="4" +          left="3" +          use_ellipses="true" +          name="block_limit"> +          [COUNT] entries in your block list, and the limit is [LIMIT]. +      </text>      <block_list       follows="all" -     height="273" +     height="255"       layout="topleft"       left="3"       name="blocked"       tool_tip="List of currently blocked Residents" -     top="31" +     top_pad="4"    	 right="-1"/>  </panel> diff --git a/indra/newview/skins/default/xui/en/panel_outfits_inventory.xml b/indra/newview/skins/default/xui/en/panel_outfits_inventory.xml index ff0714adbb..eeb930485e 100644 --- a/indra/newview/skins/default/xui/en/panel_outfits_inventory.xml +++ b/indra/newview/skins/default/xui/en/panel_outfits_inventory.xml @@ -26,10 +26,11 @@       layout="topleft"       left="5"       name="appearance_tabs" -     tab_min_width="150" +     tab_min_width="100"       tab_height="30"       tab_position="top"       halign="center" +     hide_scroll_arrows="true"       top="8"       width="315">           <panel diff --git a/indra/newview/skins/default/xui/en/panel_preferences_uploads.xml b/indra/newview/skins/default/xui/en/panel_preferences_uploads.xml new file mode 100644 index 0000000000..487da54fdf --- /dev/null +++ b/indra/newview/skins/default/xui/en/panel_preferences_uploads.xml @@ -0,0 +1,135 @@ +<?xml version="1.0" encoding="UTF-8"?> +<panel + border="true" + follows="all" + height="408" + label="Uploads" + layout="topleft" + left="102" + name="uploads" + top="1" + width="517"> +  <text +   type="string" +   length="1" +   follows="left|top" +   height="12" +   layout="topleft" +   left="33" +   name="title" +   top_pad="10" +   width="250"> +    Current destination folders for uploads +  </text> + +  <text +   type="string" +   length="1" +   follows="left|top" +   height="12" +   layout="topleft" +   left="37" +   name="title_models" +   top_pad="17" +   width="100"> +    Images +  </text> +  <text +   type="string" +   use_ellipses="true" +   follows="left|top" +   height="23" +   layout="topleft" +   font.style="BOLD" +   left="37" +   name="upload_textures" +   top_pad="5" +   width="350" /> +   +  <text +   type="string" +   length="1" +   follows="left|top" +   height="12" +   layout="topleft" +   left="37" +   name="title_sounds" +   top_pad="7" +   width="100"> +    Sounds +  </text> +  <text +   type="string" +   use_ellipses="true" +   follows="left|top" +   height="23" +   layout="topleft" +   font.style="BOLD" +   left="37" +   name="upload_sounds" +   top_pad="5" +   width="350" /> +   +  <text +   type="string" +   length="1" +   follows="left|top" +   height="12" +   layout="topleft" +   left="37" +   name="title_animation" +   top_pad="7" +   width="100"> +    Animations +  </text> +  <text +   type="string" +   use_ellipses="true" +   follows="left|top" +   height="23" +   layout="topleft" +   font.style="BOLD" +   left="37" +   name="upload_animation" +   top_pad="5" +   width="350" /> + +  <text +   type="string" +   length="1" +   follows="left|top" +   height="12" +   layout="topleft" +   left="37" +   name="title_animation" +   top_pad="7" +   width="100"> +    Models +  </text> +  <text +   type="string" +   use_ellipses="true" +   follows="left|top" +   height="23" +   layout="topleft" +   font.style="BOLD" +   left="37" +   name="upload_models" +   top_pad="5" +   width="350" /> + +  <text +   type="string" +   length="1" +   follows="left|top" +   height="30" +   layout="topleft" +   font.style="ITALIC" +   left="33" +   name="upload_help" +   top_pad="6" +   width="387"> +    To change a destination folder, right click on it in inventory and choose + "Use as default for" +  </text> +</panel> diff --git a/indra/newview/skins/default/xui/en/strings.xml b/indra/newview/skins/default/xui/en/strings.xml index 88ad8bbf7b..b75f631799 100644 --- a/indra/newview/skins/default/xui/en/strings.xml +++ b/indra/newview/skins/default/xui/en/strings.xml @@ -3815,7 +3815,7 @@ Abuse Report</string>    <string name="Male - Laugh">Male - Laugh</string>    <string name="Male - Repulsed">Male - Repulsed</string>    <string name="Male - Shrug">Male - Shrug</string> -  <string name="Male - Stick tougue out">Male - Stick tougue out</string> +  <string name="Male - Stick tougue out">Male - Stick tongue out</string>    <string name="Male - Wow">Male - Wow</string>    <string name="Female - Chuckle">Female - Chuckle</string> @@ -3834,7 +3834,7 @@ Abuse Report</string>    <string name="Female - Please">Female - Please</string>    <string name="Female - Repulsed">Female - Repulsed</string>    <string name="Female - Shrug">Female - Shrug</string> -  <string name="Female - Stick tougue out">Female - Stick tougue out</string> +  <string name="Female - Stick tougue out">Female - Stick tongue out</string>    <string name="Female - Wow">Female - Wow</string>    <string name="/bow">/bow</string> diff --git a/indra/newview/skins/default/xui/en/widgets/location_input.xml b/indra/newview/skins/default/xui/en/widgets/location_input.xml index 61ec046649..674be59753 100644 --- a/indra/newview/skins/default/xui/en/widgets/location_input.xml +++ b/indra/newview/skins/default/xui/en/widgets/location_input.xml @@ -133,7 +133,7 @@      name="damage_text"  	width="35"  	height="18" -	top="17" +	top="18"      follows="right|top"  	halign="right"  	font="SansSerifSmall" | 
