diff options
| author | Rye Mutt <rye@alchemyviewer.org> | 2024-07-01 22:24:32 -0400 | 
|---|---|---|
| committer | Rye Mutt <rye@alchemyviewer.org> | 2024-07-01 22:24:32 -0400 | 
| commit | 49d60e0ded52c095c834e9ca134b67282728b389 (patch) | |
| tree | 02426a87a60b23c8efa308198278b2e52e41cfbd /indra/newview | |
| parent | e834e77988fcf637ee0f3e4c5c0875e47044e324 (diff) | |
Reduce string temporaries from LLFloaterReg find/get
Diffstat (limited to 'indra/newview')
| -rw-r--r-- | indra/newview/llfloatersidepanelcontainer.cpp | 10 | ||||
| -rw-r--r-- | indra/newview/llfloatersidepanelcontainer.h | 12 | ||||
| -rw-r--r-- | indra/newview/llfloaterwebcontent.cpp | 2 | ||||
| -rw-r--r-- | indra/newview/llsidetraypanelcontainer.cpp | 4 | ||||
| -rw-r--r-- | indra/newview/llsidetraypanelcontainer.h | 2 | 
5 files changed, 15 insertions, 15 deletions
| diff --git a/indra/newview/llfloatersidepanelcontainer.cpp b/indra/newview/llfloatersidepanelcontainer.cpp index 2f6d14d6b5..48547852c4 100644 --- a/indra/newview/llfloatersidepanelcontainer.cpp +++ b/indra/newview/llfloatersidepanelcontainer.cpp @@ -113,7 +113,7 @@ LLFloater* LLFloaterSidePanelContainer::getTopmostInventoryFloater()      return topmost_floater;  } -LLPanel* LLFloaterSidePanelContainer::openChildPanel(const std::string& panel_name, const LLSD& params) +LLPanel* LLFloaterSidePanelContainer::openChildPanel(std::string_view panel_name, const LLSD& params)  {      LLView* view = findChildView(panel_name, true);      if (!view) @@ -144,7 +144,7 @@ LLPanel* LLFloaterSidePanelContainer::openChildPanel(const std::string& panel_na      return panel;  } -void LLFloaterSidePanelContainer::showPanel(const std::string& floater_name, const LLSD& key) +void LLFloaterSidePanelContainer::showPanel(std::string_view floater_name, const LLSD& key)  {      LLFloaterSidePanelContainer* floaterp = LLFloaterReg::getTypedInstance<LLFloaterSidePanelContainer>(floater_name);      if (floaterp) @@ -153,7 +153,7 @@ void LLFloaterSidePanelContainer::showPanel(const std::string& floater_name, con      }  } -void LLFloaterSidePanelContainer::showPanel(const std::string& floater_name, const std::string& panel_name, const LLSD& key) +void LLFloaterSidePanelContainer::showPanel(std::string_view floater_name, std::string_view panel_name, const LLSD& key)  {      LLFloaterSidePanelContainer* floaterp = LLFloaterReg::getTypedInstance<LLFloaterSidePanelContainer>(floater_name);      if (floaterp) @@ -162,7 +162,7 @@ void LLFloaterSidePanelContainer::showPanel(const std::string& floater_name, con      }  } -LLPanel* LLFloaterSidePanelContainer::getPanel(const std::string& floater_name, const std::string& panel_name) +LLPanel* LLFloaterSidePanelContainer::getPanel(std::string_view floater_name, std::string_view panel_name)  {      LLFloaterSidePanelContainer* floaterp = LLFloaterReg::getTypedInstance<LLFloaterSidePanelContainer>(floater_name); @@ -174,7 +174,7 @@ LLPanel* LLFloaterSidePanelContainer::getPanel(const std::string& floater_name,      return NULL;  } -LLPanel* LLFloaterSidePanelContainer::findPanel(const std::string& floater_name, const std::string& panel_name) +LLPanel* LLFloaterSidePanelContainer::findPanel(std::string_view floater_name, std::string_view panel_name)  {      LLFloaterSidePanelContainer* floaterp = LLFloaterReg::findTypedInstance<LLFloaterSidePanelContainer>(floater_name); diff --git a/indra/newview/llfloatersidepanelcontainer.h b/indra/newview/llfloatersidepanelcontainer.h index d5d0c43cae..19d6c747cb 100644 --- a/indra/newview/llfloatersidepanelcontainer.h +++ b/indra/newview/llfloatersidepanelcontainer.h @@ -55,17 +55,17 @@ public:      void cleanup() { destroy(); } -    LLPanel* openChildPanel(const std::string& panel_name, const LLSD& params); +    LLPanel* openChildPanel(std::string_view panel_name, const LLSD& params);      static LLFloater* getTopmostInventoryFloater(); -    static void showPanel(const std::string& floater_name, const LLSD& key); +    static void showPanel(std::string_view floater_name, const LLSD& key); -    static void showPanel(const std::string& floater_name, const std::string& panel_name, const LLSD& key); +    static void showPanel(std::string_view floater_name, std::string_view panel_name, const LLSD& key); -    static LLPanel* getPanel(const std::string& floater_name, const std::string& panel_name = sMainPanelName); +    static LLPanel* getPanel(std::string_view floater_name, std::string_view panel_name = sMainPanelName); -    static LLPanel* findPanel(const std::string& floater_name, const std::string& panel_name = sMainPanelName); +    static LLPanel* findPanel(std::string_view floater_name, std::string_view panel_name = sMainPanelName);      /**       * Gets the panel of given type T (doesn't show it or do anything else with it). @@ -75,7 +75,7 @@ public:       * @returns a pointer to the panel of given type T.       */      template <typename T> -    static T* getPanel(const std::string& floater_name, const std::string& panel_name = sMainPanelName) +    static T* getPanel(std::string_view floater_name, std::string_view panel_name = sMainPanelName)      {          T* panel = dynamic_cast<T*>(getPanel(floater_name, panel_name));          if (!panel) diff --git a/indra/newview/llfloaterwebcontent.cpp b/indra/newview/llfloaterwebcontent.cpp index f5b5b8293f..e1b6df6072 100644 --- a/indra/newview/llfloaterwebcontent.cpp +++ b/indra/newview/llfloaterwebcontent.cpp @@ -220,7 +220,7 @@ void LLFloaterWebContent::preCreate(LLFloaterWebContent::Params& p)          // showInstance will open a new window.  Figure out how many web browsers are already open,          // and close the least recently opened one if this will put us over the limit. -        LLFloaterReg::const_instance_list_t &instances = LLFloaterReg::getFloaterList(p.window_class); +        LLFloaterReg::const_instance_list_t &instances = LLFloaterReg::getFloaterList(p.window_class());          if(instances.size() >= (size_t)browser_window_limit)          { diff --git a/indra/newview/llsidetraypanelcontainer.cpp b/indra/newview/llsidetraypanelcontainer.cpp index eb8e05ec27..44e0c3b05c 100644 --- a/indra/newview/llsidetraypanelcontainer.cpp +++ b/indra/newview/llsidetraypanelcontainer.cpp @@ -62,10 +62,10 @@ void LLSideTrayPanelContainer::onOpen(const LLSD& key)      getCurrentPanel()->onOpen(key);  } -void LLSideTrayPanelContainer::openPanel(const std::string& panel_name, const LLSD& key) +void LLSideTrayPanelContainer::openPanel(std::string_view panel_name, const LLSD& key)  {      LLSD combined_key = key; -    combined_key[PARAM_SUB_PANEL_NAME] = panel_name; +    combined_key[PARAM_SUB_PANEL_NAME] = std::string(panel_name);      onOpen(combined_key);  } diff --git a/indra/newview/llsidetraypanelcontainer.h b/indra/newview/llsidetraypanelcontainer.h index 5dfd7f2d83..0017d7743f 100644 --- a/indra/newview/llsidetraypanelcontainer.h +++ b/indra/newview/llsidetraypanelcontainer.h @@ -59,7 +59,7 @@ public:      /**       * Opens given subpanel.       */ -    void openPanel(const std::string& panel_name, const LLSD& key = LLSD::emptyMap()); +    void openPanel(std::string_view panel_name, const LLSD& key = LLSD::emptyMap());      /**      * Opens previous panel from panel navigation history. | 
