diff options
| author | Andrey Lihatskiy <alihatskiy@productengine.com> | 2021-06-07 21:08:53 +0300 | 
|---|---|---|
| committer | Andrey Lihatskiy <alihatskiy@productengine.com> | 2021-06-07 21:08:53 +0300 | 
| commit | 07a118889e9a15391e950710864800e8d5c43efc (patch) | |
| tree | c47c0a617f48c57cab2f5a5784f1e4f71880f79c /indra/newview | |
| parent | 0c5a621e2945133bca35b7d81998a9fb313d05db (diff) | |
| parent | 4623b822386accfae5907c88099c2a88377a0271 (diff) | |
Merge branch 'master' into DRTVWR-486
Diffstat (limited to 'indra/newview')
128 files changed, 2612 insertions, 1866 deletions
| diff --git a/indra/newview/CMakeLists.txt b/indra/newview/CMakeLists.txt index 87ee77a117..fc8d8b805b 100644 --- a/indra/newview/CMakeLists.txt +++ b/indra/newview/CMakeLists.txt @@ -234,6 +234,7 @@ set(viewer_SOURCE_FILES      llfloaterconversationpreview.cpp      llfloaterdeleteprefpreset.cpp      llfloaterdestinations.cpp +    llfloatereditenvironmentbase.cpp      llfloatereditextdaycycle.cpp      llfloaterenvironmentadjust.cpp      llfloaterevent.cpp @@ -585,6 +586,7 @@ set(viewer_SOURCE_FILES      llsyntaxid.cpp      llsyswellitem.cpp      llsyswellwindow.cpp +    lltelemetry.cpp      llteleporthistory.cpp      llteleporthistorystorage.cpp      lltextureatlas.cpp @@ -867,6 +869,7 @@ set(viewer_HEADER_FILES      llfloaterconversationpreview.h      llfloaterdeleteprefpreset.h      llfloaterdestinations.h +    llfloatereditenvironmentbase.h      llfloatereditextdaycycle.h      llfloaterenvironmentadjust.h      llfloaterevent.h @@ -1816,6 +1819,8 @@ if (WINDOWS)        ${SHARED_LIB_STAGING_DIR}/Release/libhunspell.dll        ${SHARED_LIB_STAGING_DIR}/RelWithDebInfo/libhunspell.dll        ${SHARED_LIB_STAGING_DIR}/Debug/libhunspell.dll +      ${SHARED_LIB_STAGING_DIR}/Release/uriparser.dll +      ${SHARED_LIB_STAGING_DIR}/RelWithDebInfo/uriparser.dll        ${SHARED_LIB_STAGING_DIR}/${CMAKE_CFG_INTDIR}/SLVoice.exe        ${SHARED_LIB_STAGING_DIR}/${CMAKE_CFG_INTDIR}/libsndfile-1.dll        ${SHARED_LIB_STAGING_DIR}/${CMAKE_CFG_INTDIR}/vivoxoal.dll diff --git a/indra/newview/VIEWER_VERSION.txt b/indra/newview/VIEWER_VERSION.txt index a0b6fce83f..e786022da5 100644 --- a/indra/newview/VIEWER_VERSION.txt +++ b/indra/newview/VIEWER_VERSION.txt @@ -1 +1 @@ -6.4.18 +6.4.20 diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml index 626a3d1ff3..6de3fd04e6 100644 --- a/indra/newview/app_settings/settings.xml +++ b/indra/newview/app_settings/settings.xml @@ -5935,7 +5935,7 @@        <key>Type</key>        <string>String</string>        <key>Value</key> -      <string>http://map.secondlife.com.s3.amazonaws.com/</string> +      <string>https://map.secondlife.com/</string>      </map>      <key>CurrentMapServerURL</key>      <map> @@ -6586,7 +6586,7 @@      <key>Value</key>      <integer>1</integer>    </map> -  <key>MemoryFailurePreventionEnabled</key> +  <key>MemoryFailurePreventionEnabled</key> <!-- deprecated, only used for obsolete-in-2020 Intel 965 Express GPU -->    <map>      <key>Comment</key>      <string>If set, the viewer will quit to avoid crash when memory failure happens</string> @@ -9113,7 +9113,7 @@      <key>Type</key>      <string>F32</string>      <key>Value</key> -    <real>0.03</real> +    <real>0.1</real>    </map>    <key>RenderDebugPipeline</key>      <map> @@ -15169,7 +15169,7 @@          <key>Value</key>              <real>1</real>          </map> -    <key>PoolSizeVAssetStorage</key> +    <key>PoolSizeAssetStorage</key>          <map>          <key>Comment</key>              <string>Coroutine Pool size for AssetStorage requests</string> diff --git a/indra/newview/app_settings/shaders/class1/deferred/cloudsV.glsl b/indra/newview/app_settings/shaders/class1/deferred/cloudsV.glsl index b7036e02cf..8e0a001403 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/cloudsV.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/cloudsV.glsl @@ -1,24 +1,24 @@ -/** +/**    * @file WLCloudsV.glsl   *   * $LicenseInfo:firstyear=2005&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2005, Linden Research, Inc. - * + *    * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - * + *    * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - * + *    * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - * + *    * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ @@ -33,26 +33,26 @@ ATTRIBUTE vec2 texcoord0;  ///////////////////////////////////////////////////////////////////////////////  // Output parameters -VARYING vec4  vary_CloudColorSun; -VARYING vec4  vary_CloudColorAmbient; +VARYING vec4 vary_CloudColorSun; +VARYING vec4 vary_CloudColorAmbient;  VARYING float vary_CloudDensity; -VARYING vec2  vary_texcoord0; -VARYING vec2  vary_texcoord1; -VARYING vec2  vary_texcoord2; -VARYING vec2  vary_texcoord3; +VARYING vec2 vary_texcoord0; +VARYING vec2 vary_texcoord1; +VARYING vec2 vary_texcoord2; +VARYING vec2 vary_texcoord3;  VARYING float altitude_blend_factor;  // Inputs  uniform vec3 camPosLocal; -uniform vec4  lightnorm; -uniform vec4  sunlight_color; -uniform vec4  moonlight_color; -uniform int   sun_up_factor; -uniform vec4  ambient_color; -uniform vec4  blue_horizon; -uniform vec4  blue_density; +uniform vec4 lightnorm; +uniform vec4 sunlight_color; +uniform vec4 moonlight_color; +uniform int sun_up_factor; +uniform vec4 ambient_color; +uniform vec4 blue_horizon; +uniform vec4 blue_density;  uniform float haze_horizon;  uniform float haze_density; @@ -60,7 +60,7 @@ uniform float cloud_shadow;  uniform float density_multiplier;  uniform float max_y; -uniform vec4  glow; +uniform vec4 glow;  uniform float sun_moon_glow_factor;  uniform vec4 cloud_color; @@ -75,53 +75,53 @@ uniform float cloud_scale;  //       indra\newview\llsettingsvo.cpp  void main()  { -    // World / view / projection -    gl_Position = modelview_projection_matrix * vec4(position.xyz, 1.0); +	// World / view / projection +	gl_Position = modelview_projection_matrix * vec4(position.xyz, 1.0); -    // Texture coords +	// Texture coords      // SL-13084 EEP added support for custom cloud textures -- flip them horizontally to match the preview of Clouds > Cloud Scroll      vary_texcoord0 = vec2(-texcoord0.x, texcoord0.y);  // See: LLSettingsVOSky::applySpecial -    vary_texcoord0.xy -= 0.5; -    vary_texcoord0.xy /= cloud_scale; -    vary_texcoord0.xy += 0.5; +	vary_texcoord0.xy -= 0.5; +	vary_texcoord0.xy /= cloud_scale; +	vary_texcoord0.xy += 0.5; -    vary_texcoord1 = vary_texcoord0; -    vary_texcoord1.x += lightnorm.x * 0.0125; -    vary_texcoord1.y += lightnorm.z * 0.0125; +	vary_texcoord1 = vary_texcoord0; +	vary_texcoord1.x += lightnorm.x * 0.0125; +	vary_texcoord1.y += lightnorm.z * 0.0125; -    vary_texcoord2 = vary_texcoord0 * 16.; -    vary_texcoord3 = vary_texcoord1 * 16.; +	vary_texcoord2 = vary_texcoord0 * 16.; +	vary_texcoord3 = vary_texcoord1 * 16.; -    // Get relative position +	// Get relative position      vec3 rel_pos = position.xyz - camPosLocal.xyz + vec3(0, 50, 0);      altitude_blend_factor = clamp((rel_pos.y + 512.0) / max_y, 0.0, 1.0); -    // Set altitude +	// Set altitude      if (rel_pos.y > 0) -    { +	{          rel_pos *= (max_y / rel_pos.y); -    } +	}      if (rel_pos.y < 0) -    { -        altitude_blend_factor = 0;  // SL-11589 Fix clouds drooping below horizon +	{ +		altitude_blend_factor = 0; // SL-11589 Fix clouds drooping below horizon          rel_pos *= (-32000. / rel_pos.y); -    } +	} -    // Can normalize then +	// Can normalize then      vec3  rel_pos_norm = normalize(rel_pos);      float rel_pos_len  = length(rel_pos); -    // Initialize temp variables -    vec4 sunlight = sunlight_color; -    vec4 light_atten; +	// Initialize temp variables +	vec4 sunlight = sunlight_color; +	vec4 light_atten; -    // Sunlight attenuation effect (hue and brightness) due to atmosphere -    // this is used later for sunlight modulation at various altitudes +	// Sunlight attenuation effect (hue and brightness) due to atmosphere +	// this is used later for sunlight modulation at various altitudes      light_atten = (blue_density + vec4(haze_density * 0.25)) * (density_multiplier * max_y); -    // Calculate relative weights +	// Calculate relative weights      vec4 combined_haze = abs(blue_density) + vec4(abs(haze_density));      vec4 blue_weight   = blue_density / combined_haze;      vec4 haze_weight   = haze_density / combined_haze; @@ -130,63 +130,64 @@ void main()      float off_axis = 1.0 / max(1e-6, max(0., rel_pos_norm.y) + lightnorm.y);      sunlight *= exp(-light_atten * off_axis); -    // Distance +	// Distance      float density_dist = rel_pos_len * density_multiplier;      // Transparency (-> combined_haze)      // ATI Bugfix -- can't store combined_haze*density_dist in a variable because the ati -    // compiler gets confused. +	// compiler gets confused.      combined_haze = exp(-combined_haze * density_dist); -    // Compute haze glow +	// Compute haze glow      float haze_glow = 1.0 - dot(rel_pos_norm, lightnorm.xyz);      // haze_glow is 0 at the sun and increases away from sun      haze_glow = max(haze_glow, .001); -    // Set a minimum "angle" (smaller glow.y allows tighter, brighter hotspot) +		// Set a minimum "angle" (smaller glow.y allows tighter, brighter hotspot)      haze_glow *= glow.x; -    // Higher glow.x gives dimmer glow (because next step is 1 / "angle") +		// Higher glow.x gives dimmer glow (because next step is 1 / "angle")      haze_glow = pow(haze_glow, glow.z); -    // glow.z should be negative, so we're doing a sort of (1 / "angle") function +		// glow.z should be negative, so we're doing a sort of (1 / "angle") function      haze_glow *= sun_moon_glow_factor; -    // Add "minimum anti-solar illumination" +	// Add "minimum anti-solar illumination"      // For sun, add to glow.  For moon, remove glow entirely. SL-13768      haze_glow = (sun_moon_glow_factor < 1.0) ? 0.0 : (haze_glow + 0.25); -    // Increase ambient when there are more clouds -    vec4 tmpAmbient = ambient_color; -    tmpAmbient += (1. - tmpAmbient) * cloud_shadow * 0.5; +	// Increase ambient when there are more clouds +	vec4 tmpAmbient = ambient_color; +	tmpAmbient += (1. - tmpAmbient) * cloud_shadow * 0.5;  -    // Dim sunlight by cloud shadow percentage -    sunlight *= (1. - cloud_shadow); +	// Dim sunlight by cloud shadow percentage +	sunlight *= (1. - cloud_shadow); -    // Haze color below cloud +	// Haze color below cloud      vec4 additiveColorBelowCloud =          (blue_horizon * blue_weight * (sunlight + tmpAmbient) + (haze_horizon * haze_weight) * (sunlight * haze_glow + tmpAmbient)); -    // CLOUDS +	// CLOUDS +    sunlight = sunlight_color;  // SL-14707 reset color -- Clouds are unusually dim in EEP      off_axis = 1.0 / max(1e-6, lightnorm.y * 2.);      sunlight *= exp(-light_atten * off_axis); -    // Cloud color out +	// Cloud color out      vary_CloudColorSun     = (sunlight * haze_glow) * cloud_color; -    vary_CloudColorAmbient = tmpAmbient * cloud_color; - -    // Attenuate cloud color by atmosphere +	vary_CloudColorAmbient = tmpAmbient * cloud_color; +	 +	// Attenuate cloud color by atmosphere      combined_haze = sqrt(combined_haze);  // less atmos opacity (more transparency) below clouds      vary_CloudColorSun *= combined_haze;      vary_CloudColorAmbient *= combined_haze;      vec4 oHazeColorBelowCloud = additiveColorBelowCloud * (1. - combined_haze); -    // Make a nice cloud density based on the cloud_shadow value that was passed in. -    vary_CloudDensity = 2. * (cloud_shadow - 0.25); +	// Make a nice cloud density based on the cloud_shadow value that was passed in. +	vary_CloudDensity = 2. * (cloud_shadow - 0.25); -    // Combine these to minimize register use -    vary_CloudColorAmbient += oHazeColorBelowCloud; +	// Combine these to minimize register use +	vary_CloudColorAmbient += oHazeColorBelowCloud; -    // needs this to compile on mac -    // vary_AtmosAttenuation = vec3(0.0,0.0,0.0); +	// needs this to compile on mac +	//vary_AtmosAttenuation = vec3(0.0,0.0,0.0); -    // END CLOUDS +	// END CLOUDS  } diff --git a/indra/newview/app_settings/shaders/class1/deferred/fullbrightShinyF.glsl b/indra/newview/app_settings/shaders/class1/deferred/fullbrightShinyF.glsl index 6b36d00f97..9fcee04c32 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/fullbrightShinyF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/fullbrightShinyF.glsl @@ -64,28 +64,27 @@ void main()  #else  	vec4 color = texture2D(diffuseMap, vary_texcoord0.xy);  #endif - +	  	color.rgb *= vertex_color.rgb;  	// SL-9632 HUDs are affected by Atmosphere  	if (no_atmo == 0)  	{ -		vec3 sunlit; -		vec3 amblit; -		vec3 additive; -		vec3 atten; +	vec3 sunlit; +	vec3 amblit; +	vec3 additive; +	vec3 atten;  		vec3 pos = vary_position.xyz/vary_position.w; -		calcAtmosphericVars(pos.xyz, vec3(0), 1.0, sunlit, amblit, additive, atten, false); - -		vec3 envColor = textureCube(environmentMap, vary_texcoord1.xyz).rgb; -		float env_intensity = vertex_color.a; +	calcAtmosphericVars(pos.xyz, vec3(0), 1.0, sunlit, amblit, additive, atten, false); +	 +	vec3 envColor = textureCube(environmentMap, vary_texcoord1.xyz).rgb;	 +	float env_intensity = vertex_color.a;  	//color.rgb = srgb_to_linear(color.rgb);  		color.rgb = mix(color.rgb, envColor.rgb, env_intensity); - -		color.rgb = fullbrightAtmosTransportFrag(color.rgb, additive, atten); -		color.rgb = fullbrightScaleSoftClip(color.rgb); +	color.rgb = fullbrightAtmosTransportFrag(color.rgb, additive, atten); +	color.rgb = fullbrightScaleSoftClip(color.rgb);  	}  /* diff --git a/indra/newview/app_settings/shaders/class1/deferred/impostorF.glsl b/indra/newview/app_settings/shaders/class1/deferred/impostorF.glsl index d29e8a9423..eb6e56e718 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/impostorF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/impostorF.glsl @@ -40,6 +40,8 @@ uniform sampler2D specularMap;  VARYING vec2 vary_texcoord0; +vec3 linear_to_srgb(vec3 c); +  void main()   {  	vec4 col = texture2D(diffuseMap, vary_texcoord0.xy); @@ -52,6 +54,7 @@ void main()  	vec4 norm = texture2D(normalMap,   vary_texcoord0.xy);  	vec4 spec = texture2D(specularMap, vary_texcoord0.xy); +	col.rgb = linear_to_srgb(col.rgb);  	frag_data[0] = vec4(col.rgb, 0.0);  	frag_data[1] = spec;  	frag_data[2] = vec4(norm.xy,0,0); diff --git a/indra/newview/app_settings/shaders/class1/deferred/materialF.glsl b/indra/newview/app_settings/shaders/class1/deferred/materialF.glsl index 80d19102b6..e1f7031af6 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/materialF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/materialF.glsl @@ -406,6 +406,8 @@ void main()      vec3 light = vec3(0, 0, 0); +    final_specular.rgb = srgb_to_linear(final_specular.rgb); // SL-14035 +  #define LIGHT_LOOP(i) light.rgb += calcPointLightOrSpotLight(light_diffuse[i].rgb, npos, diffuse.rgb, final_specular, pos.xyz, norm.xyz, light_position[i], light_direction[i].xyz, light_attenuation[i].x, light_attenuation[i].y, light_attenuation[i].z, glare, light_attenuation[i].w );      LIGHT_LOOP(1) diff --git a/indra/newview/app_settings/shaders/class1/deferred/multiPointLightF.glsl b/indra/newview/app_settings/shaders/class1/deferred/multiPointLightF.glsl index 8c402fcb54..09c47165dd 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/multiPointLightF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/multiPointLightF.glsl @@ -73,9 +73,7 @@ void main()      vec3 norm = getNorm(frag.xy);      vec4 spec = texture2DRect(specularRect, frag.xy); -    spec.rgb  = srgb_to_linear(spec.rgb);      vec3 diff = texture2DRect(diffuseRect, frag.xy).rgb; -    diff.rgb  = srgb_to_linear(diff.rgb);      float noise = texture2D(noiseMap, frag.xy / 128.0).b;      vec3  npos  = normalize(-pos); diff --git a/indra/newview/app_settings/shaders/class1/deferred/multiSpotLightF.glsl b/indra/newview/app_settings/shaders/class1/deferred/multiSpotLightF.glsl index 9bba45bc4e..ec3fb9c543 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/multiSpotLightF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/multiSpotLightF.glsl @@ -182,10 +182,6 @@ void main()  	vec3 diff_tex = texture2DRect(diffuseRect, frag.xy).rgb; -    // SL-12005 Projector light pops as we get closer, more objectionable than being in wrong color space. -    //          We can't switch to linear here unless we do it everywhere* -	// *gbuffer is sRGB, convert to linear whenever sampling from it -    diff_tex.rgb = srgb_to_linear(diff_tex.rgb);  	vec3 dlit = vec3(0, 0, 0); diff --git a/indra/newview/app_settings/shaders/class1/deferred/pointLightF.glsl b/indra/newview/app_settings/shaders/class1/deferred/pointLightF.glsl index d805c9ea48..18616a9bb3 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/pointLightF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/pointLightF.glsl @@ -90,7 +90,6 @@ void main()      float noise = texture2D(noiseMap, frag.xy/128.0).b;      vec3 col = texture2DRect(diffuseRect, frag.xy).rgb; -    col.rgb = srgb_to_linear(col.rgb);      float fa = falloff+1.0;      float dist_atten = clamp(1.0-(dist-1.0*(1.0-fa))/fa, 0.0, 1.0); @@ -127,7 +126,7 @@ void main()      {          discard;      } -//col.rgb = vec3(0);         +      frag_color.rgb = col;         frag_color.a = 0.0;  } diff --git a/indra/newview/app_settings/shaders/class1/deferred/softenLightF.glsl b/indra/newview/app_settings/shaders/class1/deferred/softenLightF.glsl index f80f1a985a..7f2c603f87 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/softenLightF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/softenLightF.glsl @@ -90,7 +90,7 @@ void main()      vec4 diffuse = texture2DRect(diffuseRect, tc);      //convert to gamma space -    //diffuse.rgb = linear_to_srgb(diffuse.rgb); +    diffuse.rgb = linear_to_srgb(diffuse.rgb); // SL-14035      vec4 spec = texture2DRect(specularRect, vary_fragcoord.xy);      vec3 color = vec3(0); diff --git a/indra/newview/app_settings/shaders/class1/deferred/sunDiscF.glsl b/indra/newview/app_settings/shaders/class1/deferred/sunDiscF.glsl index 454af2a9bc..b2fa5d8a25 100644 --- a/indra/newview/app_settings/shaders/class1/deferred/sunDiscF.glsl +++ b/indra/newview/app_settings/shaders/class1/deferred/sunDiscF.glsl @@ -49,10 +49,6 @@ void main()      vec4 sunDiscB = texture2D(altDiffuseMap, vary_texcoord0.xy);      vec4 c     = mix(sunDiscA, sunDiscB, blend_factor); -    c.rgb = srgb_to_linear(c.rgb); -    c.rgb = clamp(c.rgb, vec3(0), vec3(1)); -    c.rgb = pow(c.rgb, vec3(0.7f)); -      //c.rgb = fullbrightAtmosTransport(c.rgb);      c.rgb = fullbrightScaleSoftClip(c.rgb); diff --git a/indra/newview/app_settings/shaders/class1/lighting/lightFullbrightShinyF.glsl b/indra/newview/app_settings/shaders/class1/lighting/lightFullbrightShinyF.glsl index 6f7e777d23..5e966293c6 100644 --- a/indra/newview/app_settings/shaders/class1/lighting/lightFullbrightShinyF.glsl +++ b/indra/newview/app_settings/shaders/class1/lighting/lightFullbrightShinyF.glsl @@ -48,15 +48,15 @@ void fullbright_shiny_lighting()  {  	vec4 color = diffuseLookup(vary_texcoord0.xy);  	color.rgb *= vertex_color.rgb; - +	  	// SL-9632 HUDs are affected by Atmosphere  	if (no_atmo == 0)  	{ -		vec3 envColor = textureCube(environmentMap, vary_texcoord1.xyz).rgb; -		color.rgb = mix(color.rgb, envColor.rgb, vertex_color.a*0.75); // MAGIC NUMBER SL-12574; ALM: Off, Quality > Low +	vec3 envColor = textureCube(environmentMap, vary_texcoord1.xyz).rgb;	 +	color.rgb = mix(color.rgb, envColor.rgb, vertex_color.a*0.75); // MAGIC NUMBER SL-12574; ALM: Off, Quality > Low -		color.rgb = fullbrightShinyAtmosTransport(color.rgb); -		color.rgb = fullbrightScaleSoftClip(color.rgb); +	color.rgb = fullbrightShinyAtmosTransport(color.rgb); +	color.rgb = fullbrightScaleSoftClip(color.rgb);  	}  /*  	// NOTE: HUD objects will be full bright. Uncomment if you want "some" environment lighting effecting these HUD objects. diff --git a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsF.glsl b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsF.glsl index a0699affbf..3b4d358cfa 100644 --- a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsF.glsl +++ b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsF.glsl @@ -1,30 +1,37 @@ -/**  +/**   * @file class1\windlight\atmosphericVarsF.glsl   *   * $LicenseInfo:firstyear=2007&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2007, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ -  -vec3 getPositionEye() -{ -	return vec3(0,0,0); -} +VARYING vec3 vary_AdditiveColor; +VARYING vec3 vary_AtmosAttenuation; + +vec3 getAmblitColor() { return vec3(0, 0, 0); } + +vec3 getAdditiveColor() { return vary_AdditiveColor; } + +vec3 getAtmosAttenuation() { return vec3(vary_AtmosAttenuation); } + +vec3 getSunlitColor() { return vec3(0, 0, 0); } + +vec3 getPositionEye() { return vec3(0, 0, 0); } diff --git a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsV.glsl b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsV.glsl index bd1d150fc8..1fea2c3628 100644 --- a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsV.glsl +++ b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsV.glsl @@ -1,36 +1,56 @@ -/**  +/**   * @file class1\windlight\atmosphericVarsV.glsl   *   * $LicenseInfo:firstyear=2007&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2007, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ -  +VARYING vec3 vary_AdditiveColor; +VARYING vec3 vary_AtmosAttenuation; -vec3 getPositionEye() +vec3 additive_color; +vec3 atmos_attenuation; +vec3 sunlit_color; +vec3 amblit_color; +vec3 position_eye; + +vec3 getSunlitColor() { return sunlit_color; } +void setSunlitColor(vec3 v) { sunlit_color = v; } + +vec3 getAdditiveColor() { return additive_color; } +void setAdditiveColor(vec3 v)  { -	return vec3(0,0,0); +    additive_color     = v; +    vary_AdditiveColor = v;  } -void setPositionEye(vec3 v) +vec3 getAmblitColor() { return amblit_color; } +void setAmblitColor(vec3 v) { amblit_color = v; } + +vec3 getAtmosAttenuation() { return atmos_attenuation; } +void setAtmosAttenuation(vec3 v)  { -	 +    atmos_attenuation     = v; +    vary_AtmosAttenuation = v;  } + +vec3 getPositionEye() { return position_eye; } +void setPositionEye(vec3 v) { position_eye = v; } diff --git a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterF.glsl b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterF.glsl index 5dc086ab1e..f83434b7ec 100644 --- a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterF.glsl +++ b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterF.glsl @@ -1,33 +1,38 @@ -/**  +/**   * @file class1\windlight\atmosphericVarsWaterF.glsl   *   * $LicenseInfo:firstyear=2007&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2007, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ -   VARYING vec3 vary_PositionEye; +VARYING vec3 vary_AdditiveColor; +VARYING vec3 vary_AtmosAttenuation; + +vec3 getSunlitColor() { return vec3(0, 0, 0); } + +vec3 getAmblitColor() { return vec3(0, 0, 0); } + +vec3 getAdditiveColor() { return vary_AdditiveColor; } -vec3 getPositionEye() -{ -	return vary_PositionEye; -} +vec3 getAtmosAttenuation() { return vary_AtmosAttenuation; } +vec3 getPositionEye() { return vary_PositionEye; } diff --git a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterV.glsl b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterV.glsl index e59eca265a..65d1176777 100644 --- a/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterV.glsl +++ b/indra/newview/app_settings/shaders/class1/windlight/atmosphericsVarsWaterV.glsl @@ -1,37 +1,51 @@ -/**  +/**   * @file class1\windlight\atmosphericVarsWaterV.glsl   *   * $LicenseInfo:firstyear=2007&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2007, Linden Research, Inc. - *  + *   * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - *  + *   * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - *  + *   * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  + *   * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ -  -  +  VARYING vec3 vary_PositionEye; +VARYING vec3 vary_AdditiveColor; +VARYING vec3 vary_AtmosAttenuation; -vec3 getPositionEye() -{ -	return vary_PositionEye; -} +vec3 atmos_attenuation; +vec3 sunlit_color; +vec3 amblit_color; + +vec3 getSunlitColor() { return sunlit_color; } +void setSunlitColor(vec3 v) { sunlit_color = v; } + +vec3 getAmblitColor() { return amblit_color; } +void setAmblitColor(vec3 v) { amblit_color = v; } -void setPositionEye(vec3 v) +vec3 getAdditiveColor() { return vary_AdditiveColor; } +void setAdditiveColor(vec3 v) { vary_AdditiveColor = v; } + +vec3 getAtmosAttenuation() { return atmos_attenuation; } +void setAtmosAttenuation(vec3 v)  { -	vary_PositionEye = v; +    atmos_attenuation     = v; +    vary_AtmosAttenuation = v;  } + +vec3 getPositionEye() { return vary_PositionEye; } +void setPositionEye(vec3 v) { vary_PositionEye = v; } diff --git a/indra/newview/app_settings/shaders/class1/windlight/sunDiscF.glsl b/indra/newview/app_settings/shaders/class1/windlight/sunDiscF.glsl index b9ae7a0226..5a41dc644a 100644 --- a/indra/newview/app_settings/shaders/class1/windlight/sunDiscF.glsl +++ b/indra/newview/app_settings/shaders/class1/windlight/sunDiscF.glsl @@ -51,7 +51,6 @@ void main()  // SL-9806 stars poke through  //    c.a *= sun_fade; -    c.rgb = pow(c.rgb, vec3(0.7f));      c.rgb = fullbrightAtmosTransport(c.rgb);      c.rgb = fullbrightScaleSoftClip(c.rgb);      frag_color = c; diff --git a/indra/newview/app_settings/shaders/class2/deferred/multiSpotLightF.glsl b/indra/newview/app_settings/shaders/class2/deferred/multiSpotLightF.glsl index 5d7a28c359..1b7a1cc6ec 100644 --- a/indra/newview/app_settings/shaders/class2/deferred/multiSpotLightF.glsl +++ b/indra/newview/app_settings/shaders/class2/deferred/multiSpotLightF.glsl @@ -191,10 +191,6 @@ void main()      float da = dot(norm, lv);      vec3 diff_tex = texture2DRect(diffuseRect, frag.xy).rgb; -    // SL-12005 Projector light pops as we get closer, more objectionable than being in wrong color space. -    //          We can't switch to linear here unless we do it everywhere* -    // *gbuffer IS sRGB, convert to linear since this shader outputs linear -    diff_tex.rgb = srgb_to_linear(diff_tex.rgb);      vec4 spec = texture2DRect(specularRect, frag.xy); diff --git a/indra/newview/app_settings/shaders/class2/deferred/skyF.glsl b/indra/newview/app_settings/shaders/class2/deferred/skyF.glsl index 1485c515a4..6841a8194f 100644 --- a/indra/newview/app_settings/shaders/class2/deferred/skyF.glsl +++ b/indra/newview/app_settings/shaders/class2/deferred/skyF.glsl @@ -73,7 +73,21 @@ uniform float ice_level;  vec3 rainbow(float d)  { -    d         = clamp(d, -1.0, 0.0); +    // d is the dot product of view and sun directions, so ranging -1.0..1.0 +    // 'interesting' values of d are the range -0.75..-0.825, when view is nearly opposite of sun vec +    // Rainbox texture mode is GL_REPEAT, so tc of -.75 is equiv to 0.25, -0.825 equiv to 0.175. + +    // SL-13629 Rainbow texture has colors within the correct .175...250 range, but order is inverted. +    // Rather than replace the texture, we mirror and translate the y tc to keep the colors within the +    // interesting range, but in reversed order:  i.e. d = (1 - d) - 1.575 +    d = clamp(-0.575 - d, 0.0, 1.0); + +    // With the colors in the lower 1/4 of the texture, inverting the coords leaves most of it inaccessible. +    // So, we can stretch the texcoord above the colors (ie > 0.25) to fill the entire remaining coordinate +    // space. This improves gradation, reduces banding within the rainbow interior. (1-0.25) / (0.425/0.25) = 4.2857 +    float interior_coord = max(0.0, d - 0.25) * 4.2857; +    d = clamp(d, 0.0, 0.25) + interior_coord; +      float rad = (droplet_radius - 5.0f) / 1024.0f;      return pow(texture2D(rainbow_map, vec2(rad, d)).rgb, vec3(1.8)) * moisture_level;  } diff --git a/indra/newview/app_settings/shaders/class2/deferred/softenLightF.glsl b/indra/newview/app_settings/shaders/class2/deferred/softenLightF.glsl index f4db53e0b7..7700d16007 100644 --- a/indra/newview/app_settings/shaders/class2/deferred/softenLightF.glsl +++ b/indra/newview/app_settings/shaders/class2/deferred/softenLightF.glsl @@ -87,8 +87,9 @@ void main()      float light_gamma = 1.0 / 1.3;      da                = pow(da, light_gamma); -    vec4 diffuse = texture2DRect(diffuseRect, tc); -    vec4 spec    = texture2DRect(specularRect, vary_fragcoord.xy); +    vec4 diffuse     = texture2DRect(diffuseRect, tc); +         diffuse.rgb = linear_to_srgb(diffuse.rgb); // SL-14025 +    vec4 spec        = texture2DRect(specularRect, vary_fragcoord.xy);      vec2 scol_ambocc = texture2DRect(lightMap, vary_fragcoord.xy).rg;      scol_ambocc      = pow(scol_ambocc, vec2(light_gamma)); diff --git a/indra/newview/app_settings/shaders/class2/deferred/spotLightF.glsl b/indra/newview/app_settings/shaders/class2/deferred/spotLightF.glsl index 5ab0b5c5b4..774f537821 100644 --- a/indra/newview/app_settings/shaders/class2/deferred/spotLightF.glsl +++ b/indra/newview/app_settings/shaders/class2/deferred/spotLightF.glsl @@ -189,7 +189,7 @@ void main()  	lv = normalize(lv);  	float da = dot(norm, lv); -	vec3 diff_tex = srgb_to_linear(texture2DRect(diffuseRect, frag.xy).rgb); +	vec3 diff_tex = texture2DRect(diffuseRect, frag.xy).rgb;  	vec4 spec = texture2DRect(specularRect, frag.xy);  	vec3 dlit = vec3(0, 0, 0); diff --git a/indra/newview/app_settings/shaders/class2/windlight/atmosphericsVarsF.glsl b/indra/newview/app_settings/shaders/class2/windlight/atmosphericsVarsF.glsl index d758f85d71..07733bda18 100644 --- a/indra/newview/app_settings/shaders/class2/windlight/atmosphericsVarsF.glsl +++ b/indra/newview/app_settings/shaders/class2/windlight/atmosphericsVarsF.glsl @@ -1,5 +1,5 @@  /**  - * @file class2\wl\atmosphericVars.glsl + * @file class2\wl\atmosphericVarsF.glsl   *   * $LicenseInfo:firstyear=2007&license=viewerlgpl$   * Second Life Viewer Source Code diff --git a/indra/newview/app_settings/shaders/class2/windlight/cloudsF.glsl b/indra/newview/app_settings/shaders/class2/windlight/cloudsF.glsl index 75bf8730df..fa928d993e 100644 --- a/indra/newview/app_settings/shaders/class2/windlight/cloudsF.glsl +++ b/indra/newview/app_settings/shaders/class2/windlight/cloudsF.glsl @@ -26,9 +26,9 @@  /*[EXTRA_CODE_HERE]*/   #ifdef DEFINE_GL_FRAGCOLOR -out vec4 frag_data[3]; +out vec4 frag_color;  #else -#define frag_data gl_FragData +#define frag_color gl_FragColor  #endif  ///////////////////////////////////////////////////////////////////////// @@ -126,8 +126,6 @@ void main()      color.rgb = scaleSoftClip(color.rgb);      /// Gamma correct for WL (soft clip effect). -    frag_data[0] = vec4(color.rgb, alpha1); -    frag_data[1] = vec4(0.0,0.0,0.0,0.0); -    frag_data[2] = vec4(0,0,0,1); +    frag_color = vec4(color.rgb, alpha1);  } diff --git a/indra/newview/app_settings/shaders/class2/windlight/cloudsV.glsl b/indra/newview/app_settings/shaders/class2/windlight/cloudsV.glsl index 1f881eb44b..97ffa9feef 100644 --- a/indra/newview/app_settings/shaders/class2/windlight/cloudsV.glsl +++ b/indra/newview/app_settings/shaders/class2/windlight/cloudsV.glsl @@ -1,24 +1,24 @@ -/** +/**    * @file class2\wl\cloudsV.glsl   *   * $LicenseInfo:firstyear=2005&license=viewerlgpl$   * Second Life Viewer Source Code   * Copyright (C) 2005, Linden Research, Inc. - * + *    * This library is free software; you can redistribute it and/or   * modify it under the terms of the GNU Lesser General Public   * License as published by the Free Software Foundation;   * version 2.1 of the License only. - * + *    * This library is distributed in the hope that it will be useful,   * but WITHOUT ANY WARRANTY; without even the implied warranty of   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   * Lesser General Public License for more details. - * + *    * You should have received a copy of the GNU Lesser General Public   * License along with this library; if not, write to the Free Software   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - * + *    * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA   * $/LicenseInfo$   */ @@ -33,26 +33,26 @@ ATTRIBUTE vec2 texcoord0;  ///////////////////////////////////////////////////////////////////////////////  // Output parameters -VARYING vec4  vary_CloudColorSun; -VARYING vec4  vary_CloudColorAmbient; +VARYING vec4 vary_CloudColorSun; +VARYING vec4 vary_CloudColorAmbient;  VARYING float vary_CloudDensity; -VARYING vec2  vary_texcoord0; -VARYING vec2  vary_texcoord1; -VARYING vec2  vary_texcoord2; -VARYING vec2  vary_texcoord3; +VARYING vec2 vary_texcoord0; +VARYING vec2 vary_texcoord1; +VARYING vec2 vary_texcoord2; +VARYING vec2 vary_texcoord3;  VARYING float altitude_blend_factor;  // Inputs  uniform vec3 camPosLocal; -uniform vec4  lightnorm; -uniform vec4  sunlight_color; -uniform vec4  moonlight_color; -uniform int   sun_up_factor; -uniform vec4  ambient_color; -uniform vec4  blue_horizon; -uniform vec4  blue_density; +uniform vec4 lightnorm; +uniform vec4 sunlight_color; +uniform vec4 moonlight_color; +uniform int sun_up_factor; +uniform vec4 ambient_color; +uniform vec4 blue_horizon; +uniform vec4 blue_density;  uniform float haze_horizon;  uniform float haze_density; @@ -60,7 +60,7 @@ uniform float cloud_shadow;  uniform float density_multiplier;  uniform float max_y; -uniform vec4  glow; +uniform vec4 glow;  uniform float sun_moon_glow_factor;  uniform vec4 cloud_color; @@ -75,8 +75,8 @@ uniform float cloud_scale;  //       indra\newview\llsettingsvo.cpp  void main()  { -    // World / view / projection -    gl_Position = modelview_projection_matrix * vec4(position.xyz, 1.0); +	// World / view / projection +	gl_Position = modelview_projection_matrix * vec4(position.xyz, 1.0);      // Texture coords      // SL-13084 EEP added support for custom cloud textures -- flip them horizontally to match the preview of Clouds > Cloud Scroll @@ -93,7 +93,7 @@ void main()      vary_texcoord2 = vary_texcoord0 * 16.;      vary_texcoord3 = vary_texcoord1 * 16.; -    // Get relative position +	// Get relative position      vec3 rel_pos = position.xyz - camPosLocal.xyz + vec3(0, 50, 0);      // fade clouds beyond a certain point so the bottom of the sky dome doesn't look silly at high altitude @@ -101,27 +101,27 @@ void main()      // Adj position vector to clamp altitude      if (rel_pos.y > 0.) -    { +	{          rel_pos *= (max_y / rel_pos.y); -    } +	}      if (rel_pos.y < 0.) -    { +	{          rel_pos *= (-32000. / rel_pos.y); -    } +	} -    // Can normalize then +	// Can normalize then      vec3  rel_pos_norm = normalize(rel_pos);      float rel_pos_len  = length(rel_pos); -    // Initialize temp variables -    vec4 sunlight = sunlight_color; -    vec4 light_atten; +	// Initialize temp variables +	vec4 sunlight = sunlight_color; +	vec4 light_atten; -    // Sunlight attenuation effect (hue and brightness) due to atmosphere -    // this is used later for sunlight modulation at various altitudes +	// Sunlight attenuation effect (hue and brightness) due to atmosphere +	// this is used later for sunlight modulation at various altitudes      light_atten = (blue_density + vec4(haze_density * 0.25)) * (density_multiplier * max_y); -    // Calculate relative weights +	// Calculate relative weights      vec4 combined_haze = abs(blue_density) + vec4(abs(haze_density));      vec4 blue_weight   = blue_density / combined_haze;      vec4 haze_weight   = haze_density / combined_haze; @@ -130,63 +130,64 @@ void main()      float off_axis = 1.0 / max(1e-6, max(0., rel_pos_norm.y) + lightnorm.y);      sunlight *= exp(-light_atten * off_axis); -    // Distance +	// Distance      float density_dist = rel_pos_len * density_multiplier;      // Transparency (-> combined_haze)      // ATI Bugfix -- can't store combined_haze*density_dist in a variable because the ati -    // compiler gets confused. +	// compiler gets confused.      combined_haze = exp(-combined_haze * density_dist); -    // Compute haze glow +	// Compute haze glow      float haze_glow = 1.0 - dot(rel_pos_norm, lightnorm.xyz);      // haze_glow is 0 at the sun and increases away from sun      haze_glow = max(haze_glow, .001); -    // Set a minimum "angle" (smaller glow.y allows tighter, brighter hotspot) +		// Set a minimum "angle" (smaller glow.y allows tighter, brighter hotspot)      haze_glow *= glow.x; -    // Higher glow.x gives dimmer glow (because next step is 1 / "angle") +		// Higher glow.x gives dimmer glow (because next step is 1 / "angle")      haze_glow = pow(haze_glow, glow.z); -    // glow.z should be negative, so we're doing a sort of (1 / "angle") function +		// glow.z should be negative, so we're doing a sort of (1 / "angle") function      haze_glow *= sun_moon_glow_factor; -    // Add "minimum anti-solar illumination" +	// Add "minimum anti-solar illumination"      // For sun, add to glow.  For moon, remove glow entirely. SL-13768      haze_glow = (sun_moon_glow_factor < 1.0) ? 0.0 : (haze_glow + 0.25); -    // Increase ambient when there are more clouds -    vec4 tmpAmbient = ambient_color; -    tmpAmbient += (1. - tmpAmbient) * cloud_shadow * 0.5; +	// Increase ambient when there are more clouds +	vec4 tmpAmbient = ambient_color; +	tmpAmbient += (1. - tmpAmbient) * cloud_shadow * 0.5;  -    // Dim sunlight by cloud shadow percentage -    sunlight *= (1. - cloud_shadow); +	// Dim sunlight by cloud shadow percentage +	sunlight *= (1. - cloud_shadow); -    // Haze color below cloud +	// Haze color below cloud      vec4 additiveColorBelowCloud =          (blue_horizon * blue_weight * (sunlight + tmpAmbient) + (haze_horizon * haze_weight) * (sunlight * haze_glow + tmpAmbient)); -    // CLOUDS +	// CLOUDS +    sunlight = sunlight_color;  // SL-14707 reset color -- Clouds are unusually dim in EEP      off_axis = 1.0 / max(1e-6, lightnorm.y * 2.);      sunlight *= exp(-light_atten * off_axis); -    // Cloud color out +	// Cloud color out      vary_CloudColorSun     = (sunlight * haze_glow) * cloud_color; -    vary_CloudColorAmbient = tmpAmbient * cloud_color; - -    // Attenuate cloud color by atmosphere +	vary_CloudColorAmbient = tmpAmbient * cloud_color; +	 +	// Attenuate cloud color by atmosphere      combined_haze = sqrt(combined_haze);  // less atmos opacity (more transparency) below clouds      vary_CloudColorSun *= combined_haze;      vary_CloudColorAmbient *= combined_haze;      vec4 oHazeColorBelowCloud = additiveColorBelowCloud * (1. - combined_haze); -    // Make a nice cloud density based on the cloud_shadow value that was passed in. -    vary_CloudDensity = 2. * (cloud_shadow - 0.25); +	// Make a nice cloud density based on the cloud_shadow value that was passed in. +	vary_CloudDensity = 2. * (cloud_shadow - 0.25); -    // Combine these to minimize register use -    vary_CloudColorAmbient += oHazeColorBelowCloud; +	// Combine these to minimize register use +	vary_CloudColorAmbient += oHazeColorBelowCloud; -    // needs this to compile on mac -    // vary_AtmosAttenuation = vec3(0.0,0.0,0.0); +	// needs this to compile on mac +	//vary_AtmosAttenuation = vec3(0.0,0.0,0.0); -    // END CLOUDS +	// END CLOUDS  } diff --git a/indra/newview/app_settings/shaders/class3/deferred/lightUtil.glsl b/indra/newview/app_settings/shaders/class3/deferred/lightUtil.glsl deleted file mode 100644 index 8bb3f07fc6..0000000000 --- a/indra/newview/app_settings/shaders/class3/deferred/lightUtil.glsl +++ /dev/null @@ -1,117 +0,0 @@ -/**  - * @file lightInfo.glsl - * - * $LicenseInfo:firstyear=2007&license=viewerlgpl$ - * Second Life Viewer Source Code - * Copyright (C) 2007, Linden Research, Inc. - *  - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; - * version 2.1 of the License only. - *  - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU - * Lesser General Public License for more details. - *  - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA - *  - * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA - * $/LicenseInfo$ - */ - -struct DirectionalLightInfo -{ -    vec4 pos; -    float depth; -    vec4 normal; -    vec3 normalizedLightDirection; -    vec3 normalizedToLight; -    float lightIntensity; -    vec3 lightDiffuseColor; -    float specExponent; -    float shadow; -}; - -struct SpotLightInfo -{ -    vec4 pos; -    float depth; -    vec4 normal; -    vec3 normalizedLightDirection; -    vec3 normalizedToLight; -    float lightIntensity; -    float attenuation; -    float distanceToLight; -    vec3 lightDiffuseColor; -    float innerHalfAngleCos; -    float outerHalfAngleCos; -    float spotExponent; -    float specExponent; -    float shadow; -}; - -struct PointLightInfo -{ -    vec4 pos; -    float depth; -    vec4 normal; -    vec3 normalizedToLight; -    float lightIntensity; -    float attenuation; -    float distanceToLight; -    vec3 lightDiffuseColor; -    float lightRadius; -    float specExponent; -    vec3 worldspaceLightDirection; -    float shadow; -}; - -float attenuate(float attenuationSelection, float distanceToLight) -{ -// LLRENDER_REVIEW -// sh/could eventually consume attenuation func defined in texture -    return (attenuationSelection == 0.0f) ? 1.0f : // none -           (attenuationSelection <  1.0f) ? (1.0f / distanceToLight) : // linear atten  -           (attenuationSelection <  2.0f) ? (1.0f / (distanceToLight*distanceToLight)) // quadratic atten -										  : (1.0f / (distanceToLight*distanceToLight*distanceToLight));	// cubic atten     -} - - -vec3 lightDirectional(struct DirectionalLightInfo dli) -{ -    float lightIntensity = dli.lightIntensity; -	lightIntensity *= dot(dli.normal.xyz, dli.normalizedLightDirection); -    //lightIntensity *= directionalShadowSample(vec4(dli.pos.xyz, 1.0f), dli.depth, dli.directionalShadowMap, dli.directionalShadowMatrix); -	return lightIntensity * dli.lightDiffuseColor; -} - - -vec3 lightSpot(struct SpotLightInfo sli)     -{ -	float penumbraRange = (sli.outerHalfAngleCos - sli.innerHalfAngleCos); -    float coneAngleCos = max(dot(sli.normalizedLightDirection, sli.normalizedToLight), 0.0); -	float coneAttenFactor = (coneAngleCos <= sli.outerHalfAngleCos) ? 1.0f : pow(smoothstep(1,0, sli.outerHalfAngleCos / penumbraRange), sli.spotExponent); -    float distanceAttenuation = attenuate(sli.attenuation, sli.distanceToLight); -    float lightIntensity = sli.lightIntensity; -    lightIntensity *= distanceAttenuation; -	lightIntensity *= max(dot(sli.normal.xyz, sli.normalizedLightDirection), 0.0); -	lightIntensity *= coneAttenFactor; -    lightIntensity *= sli.shadow; -	return lightIntensity * sli.lightDiffuseColor; -} - -vec3 lightPoint(struct PointLightInfo pli) -{ -    float padRadius = pli.lightRadius * 0.1; // distance for which to perform smoothed dropoff past light radius -	float distanceAttenuation =	attenuate(pli.attenuation, pli.distanceToLight); -    float lightIntensity = pli.lightIntensity; -    lightIntensity*= distanceAttenuation;     -	lightIntensity *= clamp((padRadius - pli.distanceToLight + pli.lightRadius) / padRadius, 0.0, 1.0); -    lightIntensity *= pli.shadow; -    lightIntensity *= max(dot(pli.normal.xyz, pli.normalizedToLight), 0.0); -	return lightIntensity * pli.lightDiffuseColor; -} diff --git a/indra/newview/app_settings/shaders/class3/deferred/skyF.glsl b/indra/newview/app_settings/shaders/class3/deferred/skyF.glsl index 6de01cb667..a0b082ed7c 100644 --- a/indra/newview/app_settings/shaders/class3/deferred/skyF.glsl +++ b/indra/newview/app_settings/shaders/class3/deferred/skyF.glsl @@ -56,8 +56,23 @@ vec3 GetSkyLuminanceToPoint(vec3 camPos, vec3 pos, float shadow_length, vec3 dir  vec3 ColorFromRadiance(vec3 radiance);  vec3 rainbow(float d)  { -   float rad = (droplet_radius - 5.0f) / 1024.0f; -   return pow(texture2D(rainbow_map, vec2(rad, d)).rgb, vec3(1.8)) * moisture_level; +    // d is the dot product of view and sun directions, so ranging -1.0..1.0 +    // 'interesting' values of d are the range -0.75..-0.825, when view is nearly opposite of sun vec +    // Rainbox texture mode is GL_REPEAT, so tc of -.75 is equiv to 0.25, -0.825 equiv to 0.175. + +    // SL-13629 Rainbow texture has colors within the correct .175...250 range, but order is inverted. +    // Rather than replace the texture, we mirror and translate the y tc to keep the colors within the +    // interesting range, but in reversed order:  i.e. d = (1 - d) - 1.575 +    d = clamp(-0.575 - d, 0.0, 1.0); + +    // With the colors in the lower 1/4 of the texture, inverting the coords leaves most of it inaccessible. +    // So, we can stretch the texcoord above the colors (ie > 0.25) to fill the entire remaining coordinate +    // space. This improves gradation, reduces banding within the rainbow interior. (1-0.25) / (0.425/0.25) = 4.2857 +    float interior_coord = max(0.0, d - 0.25) * 4.2857; +    d = clamp(d, 0.0, 0.25) + interior_coord; + +    float rad = (droplet_radius - 5.0f) / 1024.0f; +    return pow(texture2D(rainbow_map, vec2(rad, d)).rgb, vec3(1.8)) * moisture_level;  }  vec3 halo22(float d) diff --git a/indra/newview/icons/release/secondlife.icns b/indra/newview/icons/release/secondlife.icnsBinary files differ index e15e34140d..a30b51b67a 100644 --- a/indra/newview/icons/release/secondlife.icns +++ b/indra/newview/icons/release/secondlife.icns diff --git a/indra/newview/icons/release/secondlife.ico b/indra/newview/icons/release/secondlife.icoBinary files differ index 28bf1e7664..93d4fa54ba 100644 --- a/indra/newview/icons/release/secondlife.ico +++ b/indra/newview/icons/release/secondlife.ico diff --git a/indra/newview/icons/release/secondlife_128.png b/indra/newview/icons/release/secondlife_128.pngBinary files differ index 4c9544f498..2f21c1c7fc 100644 --- a/indra/newview/icons/release/secondlife_128.png +++ b/indra/newview/icons/release/secondlife_128.png diff --git a/indra/newview/icons/release/secondlife_16.png b/indra/newview/icons/release/secondlife_16.pngBinary files differ index bb3168b8be..68f1427309 100644 --- a/indra/newview/icons/release/secondlife_16.png +++ b/indra/newview/icons/release/secondlife_16.png diff --git a/indra/newview/icons/release/secondlife_256.BMP b/indra/newview/icons/release/secondlife_256.BMPBinary files differ index 74deedd7d3..dba2636803 100644 --- a/indra/newview/icons/release/secondlife_256.BMP +++ b/indra/newview/icons/release/secondlife_256.BMP diff --git a/indra/newview/icons/release/secondlife_256.png b/indra/newview/icons/release/secondlife_256.pngBinary files differ index bece338a90..8f324910e7 100644 --- a/indra/newview/icons/release/secondlife_256.png +++ b/indra/newview/icons/release/secondlife_256.png diff --git a/indra/newview/icons/release/secondlife_32.png b/indra/newview/icons/release/secondlife_32.pngBinary files differ index 736359c147..2b7cdef03d 100644 --- a/indra/newview/icons/release/secondlife_32.png +++ b/indra/newview/icons/release/secondlife_32.png diff --git a/indra/newview/icons/release/secondlife_48.png b/indra/newview/icons/release/secondlife_48.pngBinary files differ index 07d39ae585..c2ef372dd7 100644 --- a/indra/newview/icons/release/secondlife_48.png +++ b/indra/newview/icons/release/secondlife_48.png diff --git a/indra/newview/icons/release/secondlife_512.png b/indra/newview/icons/release/secondlife_512.pngBinary files differ index 53d1643f45..d8a0c2924d 100644 --- a/indra/newview/icons/release/secondlife_512.png +++ b/indra/newview/icons/release/secondlife_512.png diff --git a/indra/newview/installers/windows/install_icon.BMP b/indra/newview/installers/windows/install_icon.BMPBinary files differ index 09df573870..dba2636803 100644 --- a/indra/newview/installers/windows/install_icon.BMP +++ b/indra/newview/installers/windows/install_icon.BMP diff --git a/indra/newview/installers/windows/install_icon.ico b/indra/newview/installers/windows/install_icon.icoBinary files differ index efe6c4f323..93d4fa54ba 100644 --- a/indra/newview/installers/windows/install_icon.ico +++ b/indra/newview/installers/windows/install_icon.ico diff --git a/indra/newview/installers/windows/uninstall_icon.BMP b/indra/newview/installers/windows/uninstall_icon.BMPBinary files differ index 562b56676a..dba2636803 100644 --- a/indra/newview/installers/windows/uninstall_icon.BMP +++ b/indra/newview/installers/windows/uninstall_icon.BMP diff --git a/indra/newview/installers/windows/uninstall_icon.ico b/indra/newview/installers/windows/uninstall_icon.icoBinary files differ index 05e1546860..93d4fa54ba 100644 --- a/indra/newview/installers/windows/uninstall_icon.ico +++ b/indra/newview/installers/windows/uninstall_icon.ico diff --git a/indra/newview/llappdelegate-objc.mm b/indra/newview/llappdelegate-objc.mm index a2b7362608..3f1b5139c5 100644 --- a/indra/newview/llappdelegate-objc.mm +++ b/indra/newview/llappdelegate-objc.mm @@ -134,6 +134,7 @@  		// called again. Since it returned false, do not yet cancel  		// frameTimer.  		handleQuit(); +		[[NSApplication sharedApplication] stopModal];  		return NSTerminateCancel;  	} else {  		// pumpMainLoop() returned true: it's done. Okay, done with frameTimer. diff --git a/indra/newview/llappviewer.cpp b/indra/newview/llappviewer.cpp index 5a64f5e01c..053c0a5ab7 100644 --- a/indra/newview/llappviewer.cpp +++ b/indra/newview/llappviewer.cpp @@ -90,6 +90,7 @@  #include "llsdutil_math.h"  #include "lllocationhistory.h"  #include "llfasttimerview.h" +#include "lltelemetry.h"  #include "llvector4a.h"  #include "llviewermenufile.h"  #include "llvoicechannel.h" @@ -256,9 +257,9 @@  // define a self-registering event API object  #include "llappviewerlistener.h" -#if (LL_LINUX || LL_SOLARIS) && LL_GTK +#if LL_LINUX && LL_GTK  #include "glib.h" -#endif // (LL_LINUX || LL_SOLARIS) && LL_GTK +#endif // (LL_LINUX) && LL_GTK  #if LL_MSVC  // disable boost::lexical_cast warning @@ -1098,6 +1099,46 @@ bool LLAppViewer::init()  		}  	} +#if LL_WINDOWS && ADDRESS_SIZE == 64 +    if (gGLManager.mIsIntel) +    { +        // Check intel driver's version +        // Ex: "3.1.0 - Build 8.15.10.2559"; +        std::string version = ll_safe_string((const char *)glGetString(GL_VERSION)); + +        const boost::regex is_intel_string("[0-9].[0-9].[0-9] - Build [0-9]{1,2}.[0-9]{2}.[0-9]{2}.[0-9]{4}"); + +        if (boost::regex_search(version, is_intel_string)) +        { +            // Valid string, extract driver version +            std::size_t found = version.find("Build "); +            std::string driver = version.substr(found + 6); +            S32 v1, v2, v3, v4; +            S32 count = sscanf(driver.c_str(), "%d.%d.%d.%d", &v1, &v2, &v3, &v4); +            if (count > 0 && v1 <= 10) +            { +                LL_INFOS("AppInit") << "Detected obsolete intel driver: " << driver << LL_ENDL; +                LLUIString details = LLNotifications::instance().getGlobalString("UnsupportedIntelDriver"); +                std::string gpu_name = ll_safe_string((const char *)glGetString(GL_RENDERER)); +                details.setArg("[VERSION]", driver); +                details.setArg("[GPUNAME]", gpu_name); +                S32 button = OSMessageBox(details.getString(), +                                          LLStringUtil::null, +                                          OSMB_YESNO); +                if (OSBTN_YES == button && gViewerWindow) +                { +                    std::string url = LLWeb::escapeURL(LLTrans::getString("IntelDriverPage")); +                    if (gViewerWindow->getWindow()) +                    { +                        gViewerWindow->getWindow()->spawnWebBrowser(url, false); +                    } +                } +            } +        } +    } +#endif + +    // Obsolete? mExpectedGLVersion is always zero  #if LL_WINDOWS  	if (gGLManager.mGLVersion < LLFeatureManager::getInstance()->getExpectedGLVersion())  	{ @@ -1172,7 +1213,16 @@ bool LLAppViewer::init()  	// add LEAP mode command-line argument to whichever of these we selected  	updater.args.add("leap");  	// UpdaterServiceSettings -	updater.args.add(stringize(gSavedSettings.getU32("UpdaterServiceSetting"))); +    if (gSavedSettings.getBOOL("FirstLoginThisInstall")) +    { +        // Befor first login, treat this as 'manual' updates, +        // updater won't install anything, but required updates +        updater.args.add("0"); +    } +    else +    { +        updater.args.add(stringize(gSavedSettings.getU32("UpdaterServiceSetting"))); +    }  	// channel  	updater.args.add(LLVersionInfo::instance().getChannel());  	// testok @@ -1313,39 +1363,8 @@ void LLAppViewer::initMaxHeapSize()  	//F32 max_heap_size_gb = llmin(1.6f, (F32)gSavedSettings.getF32("MaxHeapSize")) ;  	F32Gigabytes max_heap_size_gb = (F32Gigabytes)gSavedSettings.getF32("MaxHeapSize") ; -	BOOL enable_mem_failure_prevention = (BOOL)gSavedSettings.getBOOL("MemoryFailurePreventionEnabled") ; -	LLMemory::initMaxHeapSizeGB(max_heap_size_gb, enable_mem_failure_prevention) ; -} - -void LLAppViewer::checkMemory() -{ -	const static F32 MEMORY_CHECK_INTERVAL = 1.0f ; //second -	//const static F32 MAX_QUIT_WAIT_TIME = 30.0f ; //seconds -	//static F32 force_quit_timer = MAX_QUIT_WAIT_TIME + MEMORY_CHECK_INTERVAL ; - -	if(!gGLManager.mDebugGPU) -	{ -		return ; -	} - -	if(MEMORY_CHECK_INTERVAL > mMemCheckTimer.getElapsedTimeF32()) -	{ -		return ; -	} -	mMemCheckTimer.reset() ; - -		//update the availability of memory -		LLMemory::updateMemoryInfo() ; - -	bool is_low = LLMemory::isMemoryPoolLow() ; - -	LLPipeline::throttleNewMemoryAllocation(is_low) ; - -	if(is_low) -	{ -		LLMemory::logMemoryInfo() ; -	} +	LLMemory::initMaxHeapSizeGB(max_heap_size_gb);  }  static LLTrace::BlockTimerStatHandle FTM_MESSAGES("System Messages"); @@ -1424,9 +1443,6 @@ bool LLAppViewer::doFrame()  	//clear call stack records  	LL_CLEAR_CALLSTACKS(); -	//check memory availability information -	checkMemory() ; -  	{  		pingMainloopTimeout("Main:MiscNativeWindowEvents"); @@ -1654,12 +1670,15 @@ bool LLAppViewer::doFrame()  		}  		delete gServicePump; +		gServicePump = NULL;  		destroyMainloopTimeout();  		LL_INFOS() << "Exiting main_loop" << LL_ENDL;  	} +    LLPROFILE_UPDATE(); +  	return ! LLApp::isRunning();  } @@ -1711,7 +1730,11 @@ bool LLAppViewer::cleanup()  	//dump scene loading monitor results  	if (LLSceneMonitor::instanceExists())  	{ -		LLSceneMonitor::instance().dumpToFile(gDirUtilp->getExpandedFilename(LL_PATH_LOGS, "scene_monitor_results.csv")); +		if (!isSecondInstance()) +		{ +			LLSceneMonitor::instance().dumpToFile(gDirUtilp->getExpandedFilename(LL_PATH_LOGS, "scene_monitor_results.csv")); +		} +		LLSceneMonitor::deleteSingleton();  	}  	// There used to be an 'if (LLFastTimerView::sAnalyzePerformance)' block @@ -3505,6 +3528,12 @@ void LLAppViewer::writeSystemInfo()  	gDebugInfo["FirstRunThisInstall"] = gSavedSettings.getBOOL("FirstRunThisInstall");      gDebugInfo["StartupState"] = LLStartUp::getStartupStateString(); +	std::vector<std::string> resolutions = gViewerWindow->getWindow()->getDisplaysResolutionList(); +	for (auto res_iter : resolutions) +	{ +		gDebugInfo["DisplayInfo"].append(res_iter); +	} +  	writeDebugInfo(); // Save out debug_info.log early, in case of crash.  } diff --git a/indra/newview/llappviewer.h b/indra/newview/llappviewer.h index d24cdcedc7..5ceb540784 100644 --- a/indra/newview/llappviewer.h +++ b/indra/newview/llappviewer.h @@ -235,7 +235,6 @@ private:  	bool initConfiguration(); // Initialize settings from the command line/config file.  	void initStrings();       // Initialize LLTrans machinery  	bool initCache(); // Initialize local client cache. -	void checkMemory() ;  	// We have switched locations of both Mac and Windows cache, make sure  	// files migrate and old cache is cleared out. @@ -314,8 +313,6 @@ private:      LLAllocator mAlloc; -	LLFrameTimer mMemCheckTimer; -  	// llcorehttp library init/shutdown helper  	LLAppCoreHttp mAppCoreHttp; diff --git a/indra/newview/llappviewerlinux.cpp b/indra/newview/llappviewerlinux.cpp index 6f32aab851..dc487967fc 100644 --- a/indra/newview/llappviewerlinux.cpp +++ b/indra/newview/llappviewerlinux.cpp @@ -73,10 +73,6 @@ static void exceptionTerminateHandler()  int main( int argc, char **argv )   { -#if LL_SOLARIS && defined(__sparc) -	asm ("ta\t6");		 // NOTE:  Make sure memory alignment is enforced on SPARC -#endif -  	gArgC = argc;  	gArgV = argv; @@ -336,8 +332,6 @@ void LLAppViewerLinux::initCrashReporting(bool reportFreeze)  	cmd += gDirUtilp->getDirDelimiter();  #if LL_LINUX  	cmd += "linux-crash-logger.bin"; -#elif LL_SOLARIS -	cmd += "solaris-crash-logger";  #else  # error Unknown platform  #endif @@ -394,9 +388,6 @@ bool LLAppViewerLinux::beingDebugged()  {  	static enum {unknown, no, yes} debugged = unknown; -#if LL_SOLARIS -	return debugged == no;	// BUG: fix this for Solaris -#else  	if (debugged == unknown)  	{  		pid_t ppid = getppid(); @@ -431,7 +422,6 @@ bool LLAppViewerLinux::beingDebugged()  	}  	return debugged == yes; -#endif  }  void LLAppViewerLinux::initLoggingAndGetLastDuration() diff --git a/indra/newview/llattachmentsmgr.cpp b/indra/newview/llattachmentsmgr.cpp index d3e66289d1..0fd6009074 100644 --- a/indra/newview/llattachmentsmgr.cpp +++ b/indra/newview/llattachmentsmgr.cpp @@ -248,6 +248,7 @@ void LLAttachmentsMgr::linkRecentlyArrivedAttachments()          {              if (isAgentAvatarValid() &&                  gAgentAvatarp->isWearingAttachment(*it) && +                !gAgentAvatarp->getWornAttachment(*it)->isTempAttachment() && // Don't link temp attachments in COF!                  !LLAppearanceMgr::instance().isLinkedInCOF(*it))              {                  LLUUID item_id = *it; diff --git a/indra/newview/llconversationlog.cpp b/indra/newview/llconversationlog.cpp index 9430bb3ca3..a696c99a82 100644 --- a/indra/newview/llconversationlog.cpp +++ b/indra/newview/llconversationlog.cpp @@ -398,6 +398,24 @@ void LLConversationLog::deleteBackupLogs()  	}  } +void LLConversationLog::verifyFilename(const LLUUID& session_id, const std::string &expected_filename, const std::string &new_session_name) +{ +    conversations_vec_t::iterator conv_it = mConversations.begin(); +    for (; conv_it != mConversations.end(); ++conv_it) +    { +        if (conv_it->getSessionID() == session_id) +        { +            if (conv_it->getHistoryFileName() != expected_filename) +            { +                LLLogChat::renameLogFile(conv_it->getHistoryFileName(), expected_filename); +                conv_it->updateHistoryFileName(expected_filename); +                conv_it->setConversationName(new_session_name); +            } +            break; +        } +    } +} +  bool LLConversationLog::moveLog(const std::string &originDirectory, const std::string &targetDirectory)  { @@ -518,7 +536,9 @@ bool LLConversationLog::loadFromFile(const std::string& filename)  	}  	bool purge_required = false; -	char buffer[MAX_STRING]; +	static constexpr int UTF_BUFFER{ 1024 }; // long enough to handle the most extreme Unicode nonsense and some to spare + +	char buffer[UTF_BUFFER];  	char conv_name_buffer[MAX_STRING];  	char part_id_buffer[MAX_STRING];  	char conv_id_buffer[MAX_STRING]; @@ -529,11 +549,14 @@ bool LLConversationLog::loadFromFile(const std::string& filename)  	// before CHUI-348 it was a flag of conversation voice state  	int prereserved_unused; -	while (!feof(fp) && fgets(buffer, MAX_STRING, fp)) +	memset(buffer, '\0', UTF_BUFFER); +	while (!feof(fp) && fgets(buffer, UTF_BUFFER, fp))  	{ -		conv_name_buffer[0] = '\0'; -		part_id_buffer[0]	= '\0'; -		conv_id_buffer[0]	= '\0'; +        // force blank for added safety +        memset(conv_name_buffer, '\0', MAX_STRING); +        memset(part_id_buffer, '\0', MAX_STRING); +        memset(conv_id_buffer, '\0', MAX_STRING); +        memset(history_file_name, '\0', MAX_STRING);  		sscanf(buffer, "[%lld] %d %d %d %[^|]| %s %s %[^|]|",  				&time, @@ -570,6 +593,7 @@ bool LLConversationLog::loadFromFile(const std::string& filename)  		}  		mConversations.push_back(conversation); +		memset(buffer, '\0', UTF_BUFFER);  	}  	fclose(fp); diff --git a/indra/newview/llconversationlog.h b/indra/newview/llconversationlog.h index 46e46a3278..820a5db491 100644 --- a/indra/newview/llconversationlog.h +++ b/indra/newview/llconversationlog.h @@ -59,7 +59,7 @@ public:  						getTime()				const	{ return mTime; }  	bool				hasOfflineMessages()	const	{ return mHasOfflineIMs; } -	void setConversationName(std::string conv_name) { mConversationName = conv_name; } +	void setConversationName(const std::string &conv_name) { mConversationName = conv_name; }  	void setOfflineMessages(bool new_messages) { mHasOfflineIMs = new_messages; }  	bool isOlderThan(U32Days days) const; @@ -68,6 +68,8 @@ public:  	 */  	void updateTimestamp(); +    void updateHistoryFileName(const std::string &new_name) { mHistoryFileName = new_name; } +  	/*  	 * Resets flag of unread offline message to false when im floater with this conversation is opened.  	 */ @@ -137,6 +139,8 @@ public:  	 * public method which is called on viewer exit to save conversation log  	 */  	void cache(); +    // will check if current name is edentical with the one on disk and will rename the one on disk if it isn't +	void verifyFilename(const LLUUID& session_id, const std::string &expected_filename, const std::string &new_session_name);  	bool moveLog(const std::string &originDirectory, const std::string &targetDirectory);  	void getListOfBackupLogs(std::vector<std::string>& list_of_backup_logs);  	void deleteBackupLogs(); diff --git a/indra/newview/llconversationmodel.cpp b/indra/newview/llconversationmodel.cpp index 4aa74a550c..a685639427 100644 --- a/indra/newview/llconversationmodel.cpp +++ b/indra/newview/llconversationmodel.cpp @@ -341,11 +341,36 @@ void LLConversationItemSession::removeParticipant(const LLUUID& participant_id)  void LLConversationItemSession::clearParticipants()  { +    // clearParticipants function potentially is malfunctioning since it only cleans children of models, +    // it does nothing to views that own those models (listeners) +    // probably needs to post some kind of 'remove all participants' event  	clearChildren();  	mIsLoaded = false;  	mNeedsRefresh = true;  } + +void LLConversationItemSession::clearAndDeparentModels() +{ +    std::for_each(mChildren.begin(), mChildren.end(), +        [](LLFolderViewModelItem* c) +        { +            if (c->getNumRefs() == 0) +            { +                // LLConversationItemParticipant can be created but not assigned to any view, +                // it was waiting for an "add_participant" event to be processed +                delete c; +            } +            else +            { +                // Model is still assigned to some view/widget +                c->setParent(NULL); +            } +        } +    ); +    mChildren.clear(); +} +  LLConversationItemParticipant* LLConversationItemSession::findParticipant(const LLUUID& participant_id)  {  	// This is *not* a general tree parsing algorithm. It assumes that a session contains only  @@ -355,7 +380,7 @@ LLConversationItemParticipant* LLConversationItemSession::findParticipant(const  	for (iter = mChildren.begin(); iter != mChildren.end(); iter++)  	{  		participant = dynamic_cast<LLConversationItemParticipant*>(*iter); -		if (participant->hasSameValue(participant_id)) +		if (participant && participant->hasSameValue(participant_id))  		{  			break;  		} @@ -466,7 +491,7 @@ const bool LLConversationItemSession::getTime(F64& time) const  	{  		participant = dynamic_cast<LLConversationItemParticipant*>(*iter);  		F64 participant_time; -		if (participant->getTime(participant_time)) +		if (participant && participant->getTime(participant_time))  		{  			has_time = true;  			most_recent_time = llmax(most_recent_time,participant_time); diff --git a/indra/newview/llconversationmodel.h b/indra/newview/llconversationmodel.h index 30c7481864..787deeb594 100644 --- a/indra/newview/llconversationmodel.h +++ b/indra/newview/llconversationmodel.h @@ -165,6 +165,7 @@ public:  	void removeParticipant(LLConversationItemParticipant* participant);  	void removeParticipant(const LLUUID& participant_id);  	void clearParticipants(); +	void clearAndDeparentModels(); // will delete unowned models and deparent owned ones  	LLConversationItemParticipant* findParticipant(const LLUUID& participant_id);  	void setParticipantIsMuted(const LLUUID& participant_id, bool is_muted); diff --git a/indra/newview/llconversationview.cpp b/indra/newview/llconversationview.cpp index 093e772abe..65cec68884 100644 --- a/indra/newview/llconversationview.cpp +++ b/indra/newview/llconversationview.cpp @@ -31,6 +31,7 @@  #include <boost/bind.hpp>  #include "llagentdata.h" +#include "llavataractions.h"  #include "llconversationmodel.h"  #include "llfloaterimsession.h"  #include "llfloaterimnearbychat.h" @@ -102,6 +103,56 @@ LLConversationViewSession::~LLConversationViewSession()  	mFlashTimer->unset();  } +void LLConversationViewSession::destroyView() +{ +    // Chat can create and parent models(listeners) to session's model before creating +    // coresponding views, such participant's models normally will wait for idle cycles +    // but since we are deleting session and won't be processing any more events, make +    // sure unowned LLConversationItemParticipant models are removed as well. + +    LLConversationItemSession* vmi = dynamic_cast<LLConversationItemSession*>(getViewModelItem()); + +    // CONV_SESSION_1_ON_1 stores participants as two models that belong to views independent +    // from session (nasty! These views are widgets in LLFloaterIMSessionTab, see buildConversationViewParticipant) +    if (vmi && vmi->getType() != LLConversationItem::CONV_SESSION_1_ON_1) +    { +        // Destroy existing views +        while (!mItems.empty()) +        { +            LLFolderViewItem *itemp = mItems.back(); +            mItems.pop_back(); + +            LLFolderViewModelItem* item_vmi = itemp->getViewModelItem(); +            if (item_vmi) // supposed to exist +            { +                // unparent to remove from child list +                vmi->removeChild(item_vmi); +            } +            itemp->destroyView(); +        } + +        // Not needed in scope of sessions, but just in case +        while (!mFolders.empty()) +        { +            LLFolderViewFolder *folderp = mFolders.back(); +            mFolders.pop_back(); + +            LLFolderViewModelItem* folder_vmi = folderp->getViewModelItem(); +            if (folder_vmi) +            { +                vmi->removeChild(folder_vmi); +            } +            folderp->destroyView(); +        } + +        // Now everything that is left in model(listener) is not owned by views, +        // only by sessions, deparent so it won't point to soon to be dead model +        vmi->clearAndDeparentModels(); +    } + +    LLFolderViewFolder::destroyView(); +} +  void LLConversationViewSession::setFlashState(bool flash_state)  {  	if (flash_state && !mFlashStateOn) @@ -432,8 +483,13 @@ void LLConversationViewSession::refresh()  	vmi->resetRefresh();  	if (mSessionTitle) -	{ -		mSessionTitle->setText(vmi->getDisplayName()); +	{		 +		if (!highlightFriendTitle(vmi)) +		{ +			LLStyle::Params title_style; +			title_style.color = LLUIColorTable::instance().getColor("LabelTextColor"); +			mSessionTitle->setText(vmi->getDisplayName(), title_style); +		}  	}  	// Update all speaking indicators @@ -478,6 +534,22 @@ void LLConversationViewSession::onCurrentVoiceSessionChanged(const LLUUID& sessi  	}  } +bool LLConversationViewSession::highlightFriendTitle(LLConversationItem* vmi) +{ +	if(vmi->getType() == LLConversationItem::CONV_PARTICIPANT || vmi->getType() == LLConversationItem::CONV_SESSION_1_ON_1) +	{ +		LLIMModel::LLIMSession* session=  LLIMModel::instance().findIMSession(vmi->getUUID()); +		if (session && LLAvatarActions::isFriend(session->mOtherParticipantID)) +		{ +			LLStyle::Params title_style; +			title_style.color = LLUIColorTable::instance().getColor("ConversationFriendColor"); +			mSessionTitle->setText(vmi->getDisplayName(), title_style); +			return true; +		} +	} +	return false; +} +  //  // Implementation of conversations list participant (avatar) widgets  // @@ -578,7 +650,14 @@ void LLConversationViewParticipant::draw()  	}  	else  	{ -		color = mIsSelected ? sHighlightFgColor : sFgColor; +		if (LLAvatarActions::isFriend(mUUID)) +		{ +			color = LLUIColorTable::instance().getColor("ConversationFriendColor"); +		} +		else +		{ +			color = mIsSelected ? sHighlightFgColor : sFgColor; +		}  	}  	LLConversationItemParticipant* participant_model = dynamic_cast<LLConversationItemParticipant*>(getViewModelItem()); @@ -617,10 +696,13 @@ void LLConversationViewParticipant::refresh()  {  	// Refresh the participant view from its model data  	LLConversationItemParticipant* participant_model = dynamic_cast<LLConversationItemParticipant*>(getViewModelItem()); -	participant_model->resetRefresh(); -	 -	// *TODO: We should also do something with vmi->isModerator() to echo that state in the UI somewhat -	mSpeakingIndicator->setIsModeratorMuted(participant_model->isModeratorMuted()); +    if (participant_model) +    { +        participant_model->resetRefresh(); + +        // *TODO: We should also do something with vmi->isModerator() to echo that state in the UI somewhat +        mSpeakingIndicator->setIsModeratorMuted(participant_model->isModeratorMuted()); +    }  	// Do the regular upstream refresh  	LLFolderViewItem::refresh(); diff --git a/indra/newview/llconversationview.h b/indra/newview/llconversationview.h index c5930c8a29..0932d24dfe 100644 --- a/indra/newview/llconversationview.h +++ b/indra/newview/llconversationview.h @@ -36,6 +36,7 @@  class LLTextBox;  class LLFloater;  class LLFloaterIMContainer; +class LLConversationItem;  class LLConversationViewSession;  class LLConversationViewParticipant; @@ -66,6 +67,8 @@ protected:  public:  	virtual ~LLConversationViewSession(); +	/*virtual*/ void destroyView(); +  	/*virtual*/ BOOL postBuild();  	/*virtual*/ void draw();  	/*virtual*/ BOOL handleMouseDown( S32 x, S32 y, MASK mask ); @@ -93,6 +96,8 @@ public:  	LLFloater* getSessionFloater();  	bool isInActiveVoiceChannel() { return mIsInActiveVoiceChannel; } +	bool highlightFriendTitle(LLConversationItem* vmi); +  private:  	void onCurrentVoiceSessionChanged(const LLUUID& session_id); diff --git a/indra/newview/lldirpicker.cpp b/indra/newview/lldirpicker.cpp index b8e6e81ee6..01790ad19e 100644 --- a/indra/newview/lldirpicker.cpp +++ b/indra/newview/lldirpicker.cpp @@ -37,7 +37,7 @@  #include "llviewercontrol.h"  #include "llwin32headerslean.h" -#if LL_LINUX || LL_SOLARIS || LL_DARWIN +#if LL_LINUX || LL_DARWIN  # include "llfilepicker.h"  #endif @@ -187,7 +187,7 @@ std::string LLDirPicker::getDirName()  	return mFilePicker->getFirstFile();  } -#elif LL_LINUX || LL_SOLARIS +#elif LL_LINUX  LLDirPicker::LLDirPicker() :  	mFileName(NULL), diff --git a/indra/newview/lldirpicker.h b/indra/newview/lldirpicker.h index c7dba12130..52febe4523 100644 --- a/indra/newview/lldirpicker.h +++ b/indra/newview/lldirpicker.h @@ -78,7 +78,7 @@ private:  	void buildDirname( void );  	bool check_local_file_access_enabled(); -#if LL_LINUX || LL_SOLARIS || LL_DARWIN +#if LL_LINUX || LL_DARWIN  	// On Linux we just implement LLDirPicker on top of LLFilePicker  	LLFilePicker *mFilePicker;  #endif diff --git a/indra/newview/lldrawable.cpp b/indra/newview/lldrawable.cpp index 5034bd1c5e..507af56cb0 100644 --- a/indra/newview/lldrawable.cpp +++ b/indra/newview/lldrawable.cpp @@ -912,22 +912,18 @@ void LLDrawable::updateDistance(LLCamera& camera, bool force_update)              if (volume->getAvatar())              {                  const LLVector3* av_box = volume->getAvatar()->getLastAnimExtents(); -                LLVector3d cam_pos = gAgent.getPosGlobalFromAgent(LLViewerCamera::getInstance()->getOrigin()); -                LLVector3 cam_region_pos = LLVector3(cam_pos - volume->getRegion()->getOriginGlobal()); -                 -                LLVector3 cam_to_box_offset = point_to_box_offset(cam_region_pos, av_box); +                LLVector3 cam_pos_from_agent = LLViewerCamera::getInstance()->getOrigin(); +                LLVector3 cam_to_box_offset = point_to_box_offset(cam_pos_from_agent, av_box);                  mDistanceWRTCamera = llmax(0.01f, ll_round(cam_to_box_offset.magVec(), 0.01f));                  LL_DEBUGS("DynamicBox") << volume->getAvatar()->getFullname()                                           << " pos (ignored) " << pos -                                        << " cam pos " << cam_pos -                                        << " cam region pos " << cam_region_pos +                                        << " cam pos " << cam_pos_from_agent                                          << " box " << av_box[0] << "," << av_box[1]                                           << " -> dist " << mDistanceWRTCamera                                          << LL_ENDL;                  mVObjp->updateLOD();                  return;              } -              		}  		else  		{ diff --git a/indra/newview/lldrawpoolwlsky.cpp b/indra/newview/lldrawpoolwlsky.cpp index d4e7f1600e..0c3d8f3098 100644 --- a/indra/newview/lldrawpoolwlsky.cpp +++ b/indra/newview/lldrawpoolwlsky.cpp @@ -226,7 +226,7 @@ void LLDrawPoolWLSky::renderSkyHaze(const LLVector3& camPosLocal, F32 camHeightL      }  } -void LLDrawPoolWLSky::renderStars(void) const +void LLDrawPoolWLSky::renderStars(const LLVector3& camPosLocal) const  {      LLGLSPipelineBlendSkyBox gls_skybox(true, false); @@ -266,6 +266,7 @@ void LLDrawPoolWLSky::renderStars(void) const      }  	gGL.pushMatrix(); +	gGL.translatef(camPosLocal.mV[0], camPosLocal.mV[1], camPosLocal.mV[2]);  	gGL.rotatef(gFrameTimeSeconds*0.01f, 0.f, 0.f, 1.f);  	if (LLGLSLShader::sNoFixedFunction)  	{ @@ -296,7 +297,7 @@ void LLDrawPoolWLSky::renderStars(void) const  	}  } -void LLDrawPoolWLSky::renderStarsDeferred(void) const +void LLDrawPoolWLSky::renderStarsDeferred(const LLVector3& camPosLocal) const  {  	LLGLSPipelineBlendSkyBox gls_sky(true, false); @@ -337,6 +338,8 @@ void LLDrawPoolWLSky::renderStarsDeferred(void) const          gGL.getTexUnit(1)->bind(tex_b);      } +	gGL.pushMatrix(); +	gGL.translatef(camPosLocal.mV[0], camPosLocal.mV[1], camPosLocal.mV[2]);      gDeferredStarProgram.uniform1f(LLShaderMgr::BLEND_FACTOR, blend_factor);      if (LLPipeline::sReflectionRender) @@ -355,6 +358,8 @@ void LLDrawPoolWLSky::renderStarsDeferred(void) const      gGL.getTexUnit(1)->unbind(LLTexUnit::TT_TEXTURE);      gDeferredStarProgram.unbind(); + +	gGL.popMatrix();  }  void LLDrawPoolWLSky::renderSkyCloudsDeferred(const LLVector3& camPosLocal, F32 camHeightLocal, LLGLSLShader* cloudshader) const @@ -601,7 +606,7 @@ void LLDrawPoolWLSky::renderDeferred(S32 pass)      if (gPipeline.canUseWindLightShaders())      {          renderSkyHazeDeferred(origin, camHeightLocal); -        renderStarsDeferred(); +        renderStarsDeferred(origin);          renderHeavenlyBodies();          renderSkyCloudsDeferred(origin, camHeightLocal, cloud_shader);      } @@ -620,7 +625,7 @@ void LLDrawPoolWLSky::render(S32 pass)      LLVector3 const & origin = LLViewerCamera::getInstance()->getOrigin();  	renderSkyHaze(origin, camHeightLocal);     -    renderStars(); +    renderStars(origin);      renderHeavenlyBodies();	  	renderSkyClouds(origin, camHeightLocal, cloud_shader); diff --git a/indra/newview/lldrawpoolwlsky.h b/indra/newview/lldrawpoolwlsky.h index a4f176d6db..324886ed42 100644 --- a/indra/newview/lldrawpoolwlsky.h +++ b/indra/newview/lldrawpoolwlsky.h @@ -78,8 +78,8 @@ private:  	void renderSkyHazeDeferred(const LLVector3& camPosLocal, F32 camHeightLocal) const;      void renderSkyCloudsDeferred(const LLVector3& camPosLocal, F32 camHeightLocal, LLGLSLShader* cloudshader) const; -    void renderStarsDeferred(void) const; -	void renderStars(void) const; +    void renderStarsDeferred(const LLVector3& camPosLocal) const; +	void renderStars(const LLVector3& camPosLocal) const;  	void renderHeavenlyBodies();      }; diff --git a/indra/newview/lldynamictexture.cpp b/indra/newview/lldynamictexture.cpp index 89c20904c1..8b8273d183 100644 --- a/indra/newview/lldynamictexture.cpp +++ b/indra/newview/lldynamictexture.cpp @@ -56,13 +56,6 @@ LLViewerDynamicTexture::LLViewerDynamicTexture(S32 width, S32 height, S32 compon  {  	llassert((1 <= components) && (components <= 4)); -	if(gGLManager.mDebugGPU) -	{ -		if(components == 3) -		{ -			mComponents = 4 ; //convert to 32bits. -		} -	}  	generateGLTexture();  	llassert( 0 <= order && order < ORDER_COUNT ); @@ -211,7 +204,7 @@ void LLViewerDynamicTexture::postRender(BOOL success)  BOOL LLViewerDynamicTexture::updateAllInstances()  {  	sNumRenders = 0; -	if (gGLManager.mIsDisabled || LLPipeline::sMemAllocationThrottled) +	if (gGLManager.mIsDisabled)  	{  		return TRUE;  	} diff --git a/indra/newview/llfavoritesbar.cpp b/indra/newview/llfavoritesbar.cpp index 347997a69a..7a887a2549 100644 --- a/indra/newview/llfavoritesbar.cpp +++ b/indra/newview/llfavoritesbar.cpp @@ -384,6 +384,8 @@ LLFavoritesBarCtrl::LLFavoritesBarCtrl(const LLFavoritesBarCtrl::Params& p)  	mUpdateDropDownItems(true),  	mRestoreOverflowMenu(false),  	mGetPrevItems(true), +	mMouseX(0), +	mMouseY(0),  	mItemsChangedTimer()  {  	// Register callback for menus with current registrar (will be parent panel's registrar) @@ -399,7 +401,7 @@ LLFavoritesBarCtrl::LLFavoritesBarCtrl(const LLFavoritesBarCtrl::Params& p)  	//make chevron button                                                                                                                                 	LLTextBox::Params more_button_params(p.more_button);  	mMoreTextBox = LLUICtrlFactory::create<LLTextBox> (more_button_params); -	mMoreTextBox->setClickedCallback(boost::bind(&LLFavoritesBarCtrl::showDropDownMenu, this)); +	mMoreTextBox->setClickedCallback(boost::bind(&LLFavoritesBarCtrl::onMoreTextBoxClicked, this));  	addChild(mMoreTextBox);  	mDropDownItemsCount = 0; @@ -975,6 +977,12 @@ BOOL LLFavoritesBarCtrl::collectFavoriteItems(LLInventoryModel::item_array_t &it  	return TRUE;  } +void LLFavoritesBarCtrl::onMoreTextBoxClicked() +{ +	LLUI::getInstance()->getMousePositionScreen(&mMouseX, &mMouseY); +	showDropDownMenu(); +} +  void LLFavoritesBarCtrl::showDropDownMenu()  {  	if (mOverflowMenuHandle.isDead()) @@ -1130,7 +1138,7 @@ void LLFavoritesBarCtrl::positionAndShowMenu(LLToggleableMenu* menu)  		}  	} -	LLMenuGL::showPopup(this, menu, menu_x, menu_y); +	LLMenuGL::showPopup(this, menu, menu_x, menu_y, mMouseX, mMouseY);  }  void LLFavoritesBarCtrl::onButtonClick(LLUUID item_id) diff --git a/indra/newview/llfavoritesbar.h b/indra/newview/llfavoritesbar.h index 571208aa31..868f1c83c8 100644 --- a/indra/newview/llfavoritesbar.h +++ b/indra/newview/llfavoritesbar.h @@ -96,6 +96,8 @@ protected:  	void showDropDownMenu(); +	void onMoreTextBoxClicked(); +  	LLHandle<LLView> mOverflowMenuHandle;  	LLHandle<LLView> mContextMenuHandle; @@ -163,6 +165,9 @@ private:  	BOOL mTabsHighlightEnabled; +	S32 mMouseX; +	S32 mMouseY; +  	boost::signals2::connection mEndDragConnection;  }; diff --git a/indra/newview/llfeaturemanager.cpp b/indra/newview/llfeaturemanager.cpp index d915a9fd26..e6bbe234b3 100644 --- a/indra/newview/llfeaturemanager.cpp +++ b/indra/newview/llfeaturemanager.cpp @@ -379,22 +379,6 @@ F32 gpu_benchmark();  #if LL_WINDOWS -static const U32 STATUS_MSC_EXCEPTION = 0xE06D7363; // compiler specific - -U32 exception_benchmark_filter(U32 code, struct _EXCEPTION_POINTERS *exception_infop) -{ -    if (code == STATUS_MSC_EXCEPTION) -    { -        // C++ exception, go on -        return EXCEPTION_CONTINUE_SEARCH; -    } -    else -    { -        // handle it -        return EXCEPTION_EXECUTE_HANDLER; -    } -} -  F32 logExceptionBenchmark()  {      // Todo: make a wrapper/class for SEH exceptions @@ -403,7 +387,7 @@ F32 logExceptionBenchmark()      {          gbps = gpu_benchmark();      } -    __except (exception_benchmark_filter(GetExceptionCode(), GetExceptionInformation())) +    __except (msc_exception_filter(GetExceptionCode(), GetExceptionInformation()))      {          // convert to C++ styled exception          char integer_string[32]; @@ -771,12 +755,7 @@ void LLFeatureManager::applyBaseMasks()  		maskFeatures("RAM256MB");  	} -#if LL_SOLARIS && defined(__sparc) 	//  even low MHz SPARCs are fast -#error The 800 is hinky. Would something like a LL_MIN_MHZ make more sense here? -	if (gSysCPU.getMHz() < 800) -#else  	if (gSysCPU.getMHz() < 1100) -#endif  	{  		maskFeatures("CPUSlow");  	} diff --git a/indra/newview/llfilepicker.cpp b/indra/newview/llfilepicker.cpp index b6fd70452e..3669fb1eeb 100644 --- a/indra/newview/llfilepicker.cpp +++ b/indra/newview/llfilepicker.cpp @@ -40,7 +40,7 @@  #include "llwindowsdl.h" // for some X/GTK utils to help with filepickers  #endif // LL_SDL -#if LL_LINUX || LL_SOLARIS +#if LL_LINUX  #include "llhttpconstants.h"    // file picker uses some of thes constants on Linux  #endif @@ -939,7 +939,7 @@ BOOL LLFilePicker::getSaveFile(ESaveFilter filter, const std::string& filename,  }  //END LL_DARWIN -#elif LL_LINUX || LL_SOLARIS +#elif LL_LINUX  # if LL_GTK @@ -1504,4 +1504,4 @@ BOOL LLFilePicker::getMultipleOpenFiles( ELoadFilter filter, bool blocking)  	return FALSE;  } -#endif // LL_LINUX || LL_SOLARIS +#endif // LL_LINUX diff --git a/indra/newview/llfloaterbuy.cpp b/indra/newview/llfloaterbuy.cpp index 4d3ebcda1e..ea93d3bfaa 100644 --- a/indra/newview/llfloaterbuy.cpp +++ b/indra/newview/llfloaterbuy.cpp @@ -49,7 +49,8 @@  #include "lltrans.h"  LLFloaterBuy::LLFloaterBuy(const LLSD& key) -:	LLFloater(key) +:	LLFloater(key), +	mSelectionUpdateSlot()  {  } @@ -179,12 +180,19 @@ void LLFloaterBuy::show(const LLSaleInfo& sale_info)  	floater->getChild<LLUICtrl>("buy_text")->setTextArg("[AMOUNT]", llformat("%d", sale_info.getSalePrice()));  	floater->getChild<LLUICtrl>("buy_name_text")->setTextArg("[NAME]", owner_name); +	floater->showViews(true); +  	// Must do this after the floater is created, because  	// sometimes the inventory is already there and   	// the callback is called immediately.  	LLViewerObject* obj = selection->getFirstRootObject();  	floater->registerVOInventoryListener(obj,NULL);  	floater->requestVOInventory(); + +	if (!floater->mSelectionUpdateSlot.connected()) +	{ +		floater->mSelectionUpdateSlot = LLSelectMgr::getInstance()->mUpdateSignal.connect(boost::bind(&LLFloaterBuy::onSelectionChanged, floater)); +	}  }  void LLFloaterBuy::inventoryChanged(LLViewerObject* obj, @@ -280,6 +288,30 @@ void LLFloaterBuy::inventoryChanged(LLViewerObject* obj,  	removeVOInventoryListener();  } +void LLFloaterBuy::onSelectionChanged() +{ +	 +	if (LLSelectMgr::getInstance()->getEditSelection()->getRootObjectCount() == 0) +	{ +		removeVOInventoryListener(); +		closeFloater(); +	} +	else if (LLSelectMgr::getInstance()->getEditSelection()->getRootObjectCount() > 1) +	{ +		removeVOInventoryListener(); +		showViews(false); +		reset(); +		setTitle(getString("mupliple_selected")); +	} +} + +void LLFloaterBuy::showViews(bool show) +{ +	getChild<LLUICtrl>("buy_btn")->setEnabled(show); +	getChild<LLUICtrl>("buy_text")->setVisible(show); +	getChild<LLUICtrl>("buy_name_text")->setVisible(show); +} +  void LLFloaterBuy::onClickBuy()  {  	// Put the items where we put new folders. @@ -303,5 +335,10 @@ void LLFloaterBuy::onClickCancel()  // virtual  void LLFloaterBuy::onClose(bool app_quitting)  { +	if (mSelectionUpdateSlot.connected()) +	{ +		mSelectionUpdateSlot.disconnect(); +	} +  	mObjectSelection.clear();  } diff --git a/indra/newview/llfloaterbuy.h b/indra/newview/llfloaterbuy.h index 3ec642dee1..e83b3c6ba6 100644 --- a/indra/newview/llfloaterbuy.h +++ b/indra/newview/llfloaterbuy.h @@ -63,12 +63,17 @@ protected:  								 S32 serial_num,  								 void* data); +	void onSelectionChanged(); +	void showViews(bool show); +  	void onClickBuy();  	void onClickCancel();  private:  	LLSafeHandle<LLObjectSelection>	mObjectSelection;  	LLSaleInfo mSaleInfo; + +	boost::signals2::connection mSelectionUpdateSlot;  };  #endif diff --git a/indra/newview/llfloatercamera.cpp b/indra/newview/llfloatercamera.cpp index d574f1433f..3b192ff81b 100644 --- a/indra/newview/llfloatercamera.cpp +++ b/indra/newview/llfloatercamera.cpp @@ -457,6 +457,7 @@ void LLFloaterCamera::switchMode(ECameraControlMode mode)  	switch (mode)  	{ +	case CAMERA_CTRL_MODE_PRESETS:  	case CAMERA_CTRL_MODE_PAN:  		sFreeCamera = false;  		clear_camera_tool(); @@ -467,13 +468,6 @@ void LLFloaterCamera::switchMode(ECameraControlMode mode)  		activate_camera_tool();  		break; -	case CAMERA_CTRL_MODE_PRESETS: -		if(sFreeCamera) -		{ -			switchMode(CAMERA_CTRL_MODE_FREE_CAMERA); -		} -		break; -  	default:  		//normally we won't occur here  		llassert_always(FALSE); @@ -528,7 +522,6 @@ void LLFloaterCamera::onClickCameraItem(const LLSD& param)  		{  			camera_floater->switchMode(CAMERA_CTRL_MODE_FREE_CAMERA);  			camera_floater->updateItemsSelection(); -			camera_floater->fromFreeToPresets();  		}  	}  	else @@ -586,15 +579,7 @@ void LLFloaterCamera::switchToPreset(const std::string& name)  	if (camera_floater)  	{  		camera_floater->updateItemsSelection(); -		camera_floater->fromFreeToPresets(); -	} -} - -void LLFloaterCamera::fromFreeToPresets() -{ -	if (!sFreeCamera && mCurrMode == CAMERA_CTRL_MODE_FREE_CAMERA && mPrevMode == CAMERA_CTRL_MODE_PRESETS) -	{ -		switchMode(CAMERA_CTRL_MODE_PRESETS); +		camera_floater->switchMode(CAMERA_CTRL_MODE_PRESETS);  	}  } diff --git a/indra/newview/llfloatercamera.h b/indra/newview/llfloatercamera.h index 9440f50c3f..a69b87ad16 100644 --- a/indra/newview/llfloatercamera.h +++ b/indra/newview/llfloatercamera.h @@ -69,10 +69,6 @@ public:  	/*switch to one of the camera presets (front, rear, side)*/  	static void switchToPreset(const std::string& name); -	/* move to CAMERA_CTRL_MODE_PRESETS from CAMERA_CTRL_MODE_FREE_CAMERA if we are on presets panel and -	   are not in free camera mode*/ -	void fromFreeToPresets(); -  	virtual void onOpen(const LLSD& key);  	virtual void onClose(bool app_quitting); diff --git a/indra/newview/llfloatereditenvironmentbase.cpp b/indra/newview/llfloatereditenvironmentbase.cpp new file mode 100644 index 0000000000..e888144b6a --- /dev/null +++ b/indra/newview/llfloatereditenvironmentbase.cpp @@ -0,0 +1,479 @@ +/**  + * @file llfloatereditenvironmentbase.cpp + * @brief Floaters to create and edit fixed settings for sky and water. + * + * $LicenseInfo:firstyear=2011&license=viewerlgpl$ + * Second Life Viewer Source Code + * Copyright (C) 2011, Linden Research, Inc. + *  + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License only. + *  + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU + * Lesser General Public License for more details. + *  + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA + *  + * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA + * $/LicenseInfo$ + */ + +#include "llviewerprecompiledheaders.h" + +#include "llfloatereditenvironmentbase.h" + +#include <boost/make_shared.hpp> + +// libs +#include "llnotifications.h" +#include "llnotificationsutil.h" +#include "llfilepicker.h" +#include "llsettingspicker.h" +#include "llviewerparcelmgr.h" + +// newview +#include "llsettingssky.h" +#include "llsettingswater.h" + +#include "llenvironment.h" +#include "llagent.h" +#include "llparcel.h" + +#include "llsettingsvo.h" +#include "llinventorymodel.h" + +namespace +{ +    const std::string ACTION_APPLY_LOCAL("apply_local"); +    const std::string ACTION_APPLY_PARCEL("apply_parcel"); +    const std::string ACTION_APPLY_REGION("apply_region"); +} + +//========================================================================= +const std::string LLFloaterEditEnvironmentBase::KEY_INVENTORY_ID("inventory_id"); + + +//========================================================================= + +class LLFixedSettingCopiedCallback : public LLInventoryCallback +{ +public: +    LLFixedSettingCopiedCallback(LLHandle<LLFloater> handle) : mHandle(handle) {} + +    virtual void fire(const LLUUID& inv_item_id) +    { +        if (!mHandle.isDead()) +        { +            LLViewerInventoryItem* item = gInventory.getItem(inv_item_id); +            if (item) +            { +                LLFloaterEditEnvironmentBase* floater = (LLFloaterEditEnvironmentBase*)mHandle.get(); +                floater->onInventoryCreated(item->getAssetUUID(), inv_item_id); +            } +        } +    } + +private: +    LLHandle<LLFloater> mHandle; +}; + +//========================================================================= +LLFloaterEditEnvironmentBase::LLFloaterEditEnvironmentBase(const LLSD &key) : +    LLFloater(key), +    mInventoryId(), +    mInventoryItem(nullptr), +    mIsDirty(false), +    mCanCopy(false), +    mCanMod(false), +    mCanTrans(false), +    mCanSave(false) +{ +} + +LLFloaterEditEnvironmentBase::~LLFloaterEditEnvironmentBase() +{ +} + +void LLFloaterEditEnvironmentBase::onFocusReceived() +{ +    if (isInVisibleChain()) +    { +        updateEditEnvironment(); +        LLEnvironment::instance().setSelectedEnvironment(LLEnvironment::ENV_EDIT, LLEnvironment::TRANSITION_FAST); +    } +} + +void LLFloaterEditEnvironmentBase::onFocusLost() +{ +} + +void LLFloaterEditEnvironmentBase::loadInventoryItem(const LLUUID  &inventoryId, bool can_trans) +{ +    if (inventoryId.isNull()) +    { +        mInventoryItem = nullptr; +        mInventoryId.setNull(); +        mCanMod = true; +        mCanCopy = true; +        mCanTrans = true; +        return; +    } + +    mInventoryId = inventoryId; +    LL_INFOS("SETTINGS") << "Setting edit inventory item to " << mInventoryId << "." << LL_ENDL; +    mInventoryItem = gInventory.getItem(mInventoryId); + +    if (!mInventoryItem) +    { +        LL_WARNS("SETTINGS") << "Could not find inventory item with Id = " << mInventoryId << LL_ENDL; +        LLNotificationsUtil::add("CantFindInvItem"); +        closeFloater(); + +        mInventoryId.setNull(); +        mInventoryItem = nullptr; +        return; +    } + +    if (mInventoryItem->getAssetUUID().isNull()) +    { +        LL_WARNS("ENVIRONMENT") << "Asset ID in inventory item is NULL (" << mInventoryId << ")" << LL_ENDL; +        LLNotificationsUtil::add("UnableEditItem"); +        closeFloater(); + +        mInventoryId.setNull(); +        mInventoryItem = nullptr; +        return; +    } + +    mCanSave = true; +    mCanCopy = mInventoryItem->getPermissions().allowCopyBy(gAgent.getID()); +    mCanMod = mInventoryItem->getPermissions().allowModifyBy(gAgent.getID()); +    mCanTrans = can_trans && mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID()); + +    mExpectingAssetId = mInventoryItem->getAssetUUID(); +    LLSettingsVOBase::getSettingsAsset(mInventoryItem->getAssetUUID(), +        [this](LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status, LLExtStat) { onAssetLoaded(asset_id, settings, status); }); +} + + +void LLFloaterEditEnvironmentBase::checkAndConfirmSettingsLoss(LLFloaterEditEnvironmentBase::on_confirm_fn cb) +{ +    if (isDirty()) +    { +        LLSD args(LLSDMap("TYPE", getEditSettings()->getSettingsType()) +            ("NAME", getEditSettings()->getName())); + +        // create and show confirmation textbox +        LLNotificationsUtil::add("SettingsConfirmLoss", args, LLSD(), +            [cb](const LLSD¬if, const LLSD&resp) +            { +                S32 opt = LLNotificationsUtil::getSelectedOption(notif, resp); +                if (opt == 0) +                    cb(); +            }); +    } +    else if (cb) +    { +        cb(); +    } +} + +void LLFloaterEditEnvironmentBase::onAssetLoaded(LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status) +{ +    if (asset_id != mExpectingAssetId) +    { +        LL_WARNS("ENVDAYEDIT") << "Expecting {" << mExpectingAssetId << "} got {" << asset_id << "} - throwing away." << LL_ENDL; +        return; +    } +    mExpectingAssetId.setNull(); +    clearDirtyFlag(); + +    if (!settings || status) +    { +        LLSD args; +        args["NAME"] = (mInventoryItem) ? mInventoryItem->getName() : asset_id.asString(); +        LLNotificationsUtil::add("FailedToFindSettings", args); +        closeFloater(); +        return; +    } + +    if (settings->getFlag(LLSettingsBase::FLAG_NOSAVE)) +    { +        mCanSave = false; +        mCanCopy = false; +        mCanMod = false; +        mCanTrans = false; +    } +    else +    { +        if (mInventoryItem) +            settings->setName(mInventoryItem->getName()); + +        if (mCanCopy) +            settings->clearFlag(LLSettingsBase::FLAG_NOCOPY); +        else +            settings->setFlag(LLSettingsBase::FLAG_NOCOPY); + +        if (mCanMod) +            settings->clearFlag(LLSettingsBase::FLAG_NOMOD); +        else +            settings->setFlag(LLSettingsBase::FLAG_NOMOD); + +        if (mCanTrans) +            settings->clearFlag(LLSettingsBase::FLAG_NOTRANS); +        else +            settings->setFlag(LLSettingsBase::FLAG_NOTRANS); +    } + +    setEditSettingsAndUpdate(settings); +} + +void LLFloaterEditEnvironmentBase::onButtonImport() +{ +    checkAndConfirmSettingsLoss([this](){ doImportFromDisk(); }); +} + +void LLFloaterEditEnvironmentBase::onSaveAsCommit(const LLSD& notification, const LLSD& response, const LLSettingsBase::ptr_t &settings) +{ +    S32 option = LLNotificationsUtil::getSelectedOption(notification, response); +    if (0 == option) +    { +        std::string settings_name = response["message"].asString(); + +        LLInventoryObject::correctInventoryName(settings_name); +        if (settings_name.empty()) +        { +            // Ideally notification should disable 'OK' button if name won't fit our requirements, +            // for now either display notification, or use some default name +            settings_name = "Unnamed"; +        } + +        if (mCanMod) +        { +            doApplyCreateNewInventory(settings_name, settings); +        } +        else if (mInventoryItem) +        { +            const LLUUID &marketplacelistings_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_MARKETPLACE_LISTINGS, false); +            LLUUID parent_id = mInventoryItem->getParentUUID(); +            if (marketplacelistings_id == parent_id) +            { +                parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS); +            } + +            LLPointer<LLInventoryCallback> cb = new LLFixedSettingCopiedCallback(getHandle()); +            copy_inventory_item( +                gAgent.getID(), +                mInventoryItem->getPermissions().getOwner(), +                mInventoryItem->getUUID(), +                parent_id, +                settings_name, +                cb); +        } +        else +        { +            LL_WARNS() << "Failed to copy fixed env setting" << LL_ENDL; +        } +    } +} + +void LLFloaterEditEnvironmentBase::onClickCloseBtn(bool app_quitting) +{ +    if (!app_quitting) +        checkAndConfirmSettingsLoss([this](){ closeFloater(); clearDirtyFlag(); }); +    else +        closeFloater(); +} + +void LLFloaterEditEnvironmentBase::doApplyCreateNewInventory(std::string settings_name, const LLSettingsBase::ptr_t &settings) +{ +    if (mInventoryItem) +    { +        LLUUID parent_id = mInventoryItem->getParentUUID(); +        U32 next_owner_perm = mInventoryItem->getPermissions().getMaskNextOwner(); +        LLSettingsVOBase::createInventoryItem(settings, next_owner_perm, parent_id, settings_name, +            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); +    } +    else +    { +        LLUUID parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS); +        // This method knows what sort of settings object to create. +        LLSettingsVOBase::createInventoryItem(settings, parent_id, settings_name, +            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); +    } +} + +void LLFloaterEditEnvironmentBase::doApplyUpdateInventory(const LLSettingsBase::ptr_t &settings) +{ +    LL_DEBUGS("ENVEDIT") << "Update inventory for " << mInventoryId << LL_ENDL; +    if (mInventoryId.isNull()) +    { +        LLSettingsVOBase::createInventoryItem(settings, gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS), std::string(), +            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); +    } +    else +    { +        LLSettingsVOBase::updateInventoryItem(settings, mInventoryId, +            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryUpdated(asset_id, inventory_id, results); }); +    } +} + +void LLFloaterEditEnvironmentBase::doApplyEnvironment(const std::string &where, const LLSettingsBase::ptr_t &settings) +{ +    U32 flags(0); + +    if (mInventoryItem) +    { +        if (!mInventoryItem->getPermissions().allowOperationBy(PERM_MODIFY, gAgent.getID())) +            flags |= LLSettingsBase::FLAG_NOMOD; +        if (!mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID())) +            flags |= LLSettingsBase::FLAG_NOTRANS; +    } + +    flags |= settings->getFlags(); +    settings->setFlag(flags); + +    if (where == ACTION_APPLY_LOCAL) +    { +        settings->setName("Local"); // To distinguish and make sure there is a name. Safe, because this is a copy. +        LLEnvironment::instance().setEnvironment(LLEnvironment::ENV_LOCAL, settings); +    } +    else if (where == ACTION_APPLY_PARCEL) +    { +        LLParcel *parcel(LLViewerParcelMgr::instance().getAgentOrSelectedParcel()); + +        if ((!parcel) || (parcel->getLocalID() == INVALID_PARCEL_ID)) +        { +            LL_WARNS("ENVIRONMENT") << "Can not identify parcel. Not applying." << LL_ENDL; +            LLNotificationsUtil::add("WLParcelApplyFail"); +            return; +        } + +        if (mInventoryItem && !isDirty()) +        { +            LLEnvironment::instance().updateParcel(parcel->getLocalID(), mInventoryItem->getAssetUUID(), mInventoryItem->getName(), LLEnvironment::NO_TRACK, -1, -1, flags); +        } +        else if (settings->getSettingsType() == "sky") +        { +            LLEnvironment::instance().updateParcel(parcel->getLocalID(), std::static_pointer_cast<LLSettingsSky>(settings), -1, -1); +        } +        else if (settings->getSettingsType() == "water") +        { +            LLEnvironment::instance().updateParcel(parcel->getLocalID(), std::static_pointer_cast<LLSettingsWater>(settings), -1, -1); +        } +        else if (settings->getSettingsType() == "day") +        { +            LLEnvironment::instance().updateParcel(parcel->getLocalID(), std::static_pointer_cast<LLSettingsDay>(settings), -1, -1); +        } +    } +    else if (where == ACTION_APPLY_REGION) +    { +        if (mInventoryItem && !isDirty()) +        { +            LLEnvironment::instance().updateRegion(mInventoryItem->getAssetUUID(), mInventoryItem->getName(), LLEnvironment::NO_TRACK, -1, -1, flags); +        } +        else if (settings->getSettingsType() == "sky") +        { +            LLEnvironment::instance().updateRegion(std::static_pointer_cast<LLSettingsSky>(settings), -1, -1); +        } +        else if (settings->getSettingsType() == "water") +        { +            LLEnvironment::instance().updateRegion(std::static_pointer_cast<LLSettingsWater>(settings), -1, -1); +        } +        else if (settings->getSettingsType() == "day") +        { +            LLEnvironment::instance().updateRegion(std::static_pointer_cast<LLSettingsDay>(settings), -1, -1); +        } +    } +    else +    { +        LL_WARNS("ENVIRONMENT") << "Unknown apply '" << where << "'" << LL_ENDL; +        return; +    } + +} + +void LLFloaterEditEnvironmentBase::doCloseInventoryFloater(bool quitting) +{ +    LLFloater* floaterp = mInventoryFloater.get(); + +    if (floaterp) +    { +        floaterp->closeFloater(quitting); +    } +} + +void LLFloaterEditEnvironmentBase::onInventoryCreated(LLUUID asset_id, LLUUID inventory_id, LLSD results) +{ +    LL_WARNS("ENVIRONMENT") << "Inventory item " << inventory_id << " has been created with asset " << asset_id << " results are:" << results << LL_ENDL; + +    if (inventory_id.isNull() || !results["success"].asBoolean()) +    { +        LLNotificationsUtil::add("CantCreateInventory"); +        return; +    } +    onInventoryCreated(asset_id, inventory_id); +} + +void LLFloaterEditEnvironmentBase::onInventoryCreated(LLUUID asset_id, LLUUID inventory_id) +{ +    bool can_trans = true; +    if (mInventoryItem) +    { +        LLPermissions perms = mInventoryItem->getPermissions(); + +        LLInventoryItem *created_item = gInventory.getItem(mInventoryId); + +        if (created_item) +        { +            can_trans = perms.allowOperationBy(PERM_TRANSFER, gAgent.getID()); +            created_item->setPermissions(perms); +            created_item->updateServer(false); +        } +    } + +    clearDirtyFlag(); +    setFocus(TRUE);                 // Call back the focus... +    loadInventoryItem(inventory_id, can_trans); +} + +void LLFloaterEditEnvironmentBase::onInventoryUpdated(LLUUID asset_id, LLUUID inventory_id, LLSD results) +{ +    LL_WARNS("ENVIRONMENT") << "Inventory item " << inventory_id << " has been updated with asset " << asset_id << " results are:" << results << LL_ENDL; + +    clearDirtyFlag(); +    if (inventory_id != mInventoryId) +    { +        loadInventoryItem(inventory_id); +    } +} + +void LLFloaterEditEnvironmentBase::onPanelDirtyFlagChanged(bool value) +{ +    if (value) +        setDirtyFlag(); +} + +//------------------------------------------------------------------------- +bool LLFloaterEditEnvironmentBase::canUseInventory() const +{ +    return LLEnvironment::instance().isInventoryEnabled(); +} + +bool LLFloaterEditEnvironmentBase::canApplyRegion() const +{ +    return gAgent.canManageEstate(); +} + +bool LLFloaterEditEnvironmentBase::canApplyParcel() const +{ +    return LLEnvironment::instance().canAgentUpdateParcelEnvironment(); +} + +//========================================================================= diff --git a/indra/newview/llfloatereditenvironmentbase.h b/indra/newview/llfloatereditenvironmentbase.h new file mode 100644 index 0000000000..7c7cf5bdcd --- /dev/null +++ b/indra/newview/llfloatereditenvironmentbase.h @@ -0,0 +1,148 @@ +/**  + * @file llfloatereditenvironmentbase.h + * @brief Floaters to create and edit fixed settings for sky and water. + * + * $LicenseInfo:firstyear=2011&license=viewerlgpl$ + * Second Life Viewer Source Code + * Copyright (C) 2011, Linden Research, Inc. + *  + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License only. + *  + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU + * Lesser General Public License for more details. + *  + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA + *  + * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA + * $/LicenseInfo$ + */ + +#ifndef LL_FLOATEREDITENVIRONMENTBASE_H +#define LL_FLOATEREDITENVIRONMENTBASE_H + +#include "llfloater.h" +#include "llsettingsbase.h" +#include "llflyoutcombobtn.h" +#include "llinventory.h" + +#include "boost/signals2.hpp" + +class LLTabContainer; +class LLButton; +class LLLineEditor; +class LLFloaterSettingsPicker; +class LLFixedSettingCopiedCallback; + +class LLFloaterEditEnvironmentBase : public LLFloater +{ +    LOG_CLASS(LLFloaterEditEnvironmentBase); + +    friend class LLFixedSettingCopiedCallback; + +public: +    static const std::string    KEY_INVENTORY_ID; + +                            LLFloaterEditEnvironmentBase(const LLSD &key); +                            ~LLFloaterEditEnvironmentBase(); + +    virtual void            onFocusReceived()           override; +    virtual void            onFocusLost()               override; +     +    virtual LLSettingsBase::ptr_t   getEditSettings()   const = 0; + +    virtual BOOL            isDirty() const override            { return getIsDirty(); } + +protected: +    typedef std::function<void()> on_confirm_fn; + +    virtual void            setEditSettingsAndUpdate(const LLSettingsBase::ptr_t &settings) = 0; +    virtual void            updateEditEnvironment() = 0; + +    virtual LLFloaterSettingsPicker *getSettingsPicker() = 0; + +    void                    loadInventoryItem(const LLUUID  &inventoryId, bool can_trans = true); + +    void                    checkAndConfirmSettingsLoss(on_confirm_fn cb); + +    virtual void            doImportFromDisk() = 0; +    virtual void            doApplyCreateNewInventory(std::string settings_name, const LLSettingsBase::ptr_t &settings); +    virtual void            doApplyUpdateInventory(const LLSettingsBase::ptr_t &settings); +    virtual void            doApplyEnvironment(const std::string &where, const LLSettingsBase::ptr_t &settings); +    void                    doCloseInventoryFloater(bool quitting = false); + +    bool                    canUseInventory() const; +    bool                    canApplyRegion() const; +    bool                    canApplyParcel() const; + +    LLUUID                  mInventoryId; +    LLInventoryItem *       mInventoryItem; +    LLHandle<LLFloater>     mInventoryFloater; +    bool                    mCanCopy; +    bool                    mCanMod; +    bool                    mCanTrans; +    bool                    mCanSave; + +    bool                    mIsDirty; + +    void                    onInventoryCreated(LLUUID asset_id, LLUUID inventory_id); +    void                    onInventoryCreated(LLUUID asset_id, LLUUID inventory_id, LLSD results); +    void                    onInventoryUpdated(LLUUID asset_id, LLUUID inventory_id, LLSD results); + +    bool                    getIsDirty() const  { return mIsDirty; } +    void                    setDirtyFlag()      { mIsDirty = true; } +    virtual void            clearDirtyFlag() = 0; + +    void                    onPanelDirtyFlagChanged(bool); + +    virtual void            onClickCloseBtn(bool app_quitting = false) override; +    void                    onSaveAsCommit(const LLSD& notification, const LLSD& response, const LLSettingsBase::ptr_t &settings); +    void                    onButtonImport(); + +    void                    onAssetLoaded(LLUUID asset_id, LLSettingsBase::ptr_t settins, S32 status); + +private: +    LLUUID                  mExpectingAssetId; // for asset load confirmation +}; + +class LLSettingsEditPanel : public LLPanel +{ +public: +    virtual void setSettings(const LLSettingsBase::ptr_t &) = 0; + +    typedef boost::signals2::signal<void(LLPanel *, bool)> on_dirty_charged_sg; +    typedef boost::signals2::connection connection_t; + +    inline bool         getIsDirty() const      { return mIsDirty; } +    inline void         setIsDirty()            { mIsDirty = true; if (!mOnDirtyChanged.empty()) mOnDirtyChanged(this, mIsDirty); } +    inline void         clearIsDirty()          { mIsDirty = false; if (!mOnDirtyChanged.empty()) mOnDirtyChanged(this, mIsDirty); } + +    inline bool        getCanChangeSettings() const    { return mCanEdit; } +    inline void        setCanChangeSettings(bool flag) { mCanEdit = flag; } + +    inline connection_t setOnDirtyFlagChanged(on_dirty_charged_sg::slot_type cb)    { return mOnDirtyChanged.connect(cb); } + + +protected: +    LLSettingsEditPanel() : +        LLPanel(), +        mIsDirty(false), +        mOnDirtyChanged() +    {} + +private: +    void onTextureChanged(LLUUID &inventory_item_id); + +    bool                mIsDirty; +    bool                mCanEdit; +     +    on_dirty_charged_sg mOnDirtyChanged; +}; + +#endif // LL_FLOATERENVIRONMENTBASE_H diff --git a/indra/newview/llfloatereditextdaycycle.cpp b/indra/newview/llfloatereditextdaycycle.cpp index a7c2cbbeaa..0501c287ad 100644 --- a/indra/newview/llfloatereditextdaycycle.cpp +++ b/indra/newview/llfloatereditextdaycycle.cpp @@ -125,7 +125,6 @@ namespace {  }  //========================================================================= -const std::string LLFloaterEditExtDayCycle::KEY_INVENTORY_ID("inventory_id");  const std::string LLFloaterEditExtDayCycle::KEY_EDIT_CONTEXT("edit_context");  const std::string LLFloaterEditExtDayCycle::KEY_DAY_LENGTH("day_length");  const std::string LLFloaterEditExtDayCycle::KEY_CANMOD("canmod"); @@ -133,7 +132,7 @@ const std::string LLFloaterEditExtDayCycle::KEY_CANMOD("canmod");  const std::string LLFloaterEditExtDayCycle::VALUE_CONTEXT_INVENTORY("inventory");  const std::string LLFloaterEditExtDayCycle::VALUE_CONTEXT_PARCEL("parcel");  const std::string LLFloaterEditExtDayCycle::VALUE_CONTEXT_REGION("region"); - +/*  //=========================================================================  class LLDaySettingCopiedCallback : public LLInventoryCallback @@ -156,12 +155,12 @@ public:  private:      LLHandle<LLFloater> mHandle; -}; +};*/  //=========================================================================  LLFloaterEditExtDayCycle::LLFloaterEditExtDayCycle(const LLSD &key) : -    LLFloater(key), +    LLFloaterEditEnvironmentBase(key),      mFlyoutControl(nullptr),      mDayLength(0),      mCurrentTrack(1), @@ -170,19 +169,12 @@ LLFloaterEditExtDayCycle::LLFloaterEditExtDayCycle(const LLSD &key) :      mFramesSlider(nullptr),      mCurrentTimeLabel(nullptr),      mImportButton(nullptr), -    mInventoryId(), -    mInventoryItem(nullptr),      mLoadFrame(nullptr),      mSkyBlender(),      mWaterBlender(),      mScratchSky(),      mScratchWater(),      mIsPlaying(false), -    mIsDirty(false), -    mCanSave(false), -    mCanCopy(false), -    mCanMod(false), -    mCanTrans(false),      mCloneTrack(nullptr),      mLoadTrack(nullptr),      mClearTrack(nullptr) @@ -425,19 +417,6 @@ void LLFloaterEditExtDayCycle::onClose(bool app_quitting)      }  } -void LLFloaterEditExtDayCycle::onFocusReceived() -{ -    if (isInVisibleChain()) -    { -        updateEditEnvironment(); -        LLEnvironment::instance().setSelectedEnvironment(LLEnvironment::ENV_EDIT, LLEnvironment::TRANSITION_FAST); -    } -} - -void LLFloaterEditExtDayCycle::onFocusLost() -{ -} -  void LLFloaterEditExtDayCycle::onVisibilityChange(BOOL new_visibility)  { @@ -488,6 +467,10 @@ void LLFloaterEditExtDayCycle::refresh()      LLFloater::refresh();  } +void LLFloaterEditExtDayCycle::setEditSettingsAndUpdate(const LLSettingsBase::ptr_t &settings) +{ +    setEditDayCycle(std::dynamic_pointer_cast<LLSettingsDay>(settings)); +}  void LLFloaterEditExtDayCycle::setEditDayCycle(const LLSettingsDay::ptr_t &pday)  { @@ -700,63 +683,6 @@ void LLFloaterEditExtDayCycle::onButtonApply(LLUICtrl *ctrl, const LLSD &data)      }  } -void LLFloaterEditExtDayCycle::onSaveAsCommit(const LLSD& notification, const LLSD& response, const LLSettingsDay::ptr_t &day) -{ -    S32 option = LLNotificationsUtil::getSelectedOption(notification, response); -    if (0 == option) -    { -        std::string settings_name = response["message"].asString(); - -        LLInventoryObject::correctInventoryName(settings_name); -        if (settings_name.empty()) -        { -            // Ideally notification should disable 'OK' button if name won't fit our requirements, -            // for now either display notification, or use some default name -            settings_name = "Unnamed"; -        } - -        if (mCanMod) -        { -            doApplyCreateNewInventory(day, settings_name); -        } -        else if (mInventoryItem) -        { -            const LLUUID &marketplacelistings_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_MARKETPLACE_LISTINGS, false); -            LLUUID parent_id = mInventoryItem->getParentUUID(); -            if (marketplacelistings_id == parent_id) -            { -                parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS); -            } - -            LLPointer<LLInventoryCallback> cb = new LLDaySettingCopiedCallback(getHandle()); -            copy_inventory_item( -                gAgent.getID(), -                mInventoryItem->getPermissions().getOwner(), -                mInventoryItem->getUUID(), -                parent_id, -                settings_name, -                cb); -        } -        else -        { -            LL_WARNS() << "Failed to copy day setting" << LL_ENDL; -        } -    } -} - -void LLFloaterEditExtDayCycle::onClickCloseBtn(bool app_quitting /*= false*/) -{ -    if (!app_quitting) -        checkAndConfirmSettingsLoss([this](){ closeFloater(); clearDirtyFlag(); }); -    else -        closeFloater(); -} - -void LLFloaterEditExtDayCycle::onButtonImport() -{ -    checkAndConfirmSettingsLoss([this]() { doImportFromDisk(); }); -} -  void LLFloaterEditExtDayCycle::onButtonLoadFrame()  {      doOpenInventoryFloater((mCurrentTrack == LLSettingsDay::TRACK_WATER) ? LLSettingsType::ST_WATER : LLSettingsType::ST_SKY, LLUUID::null); @@ -1053,35 +979,6 @@ void LLFloaterEditExtDayCycle::onFrameSliderMouseUp(S32 x, S32 y, MASK mask)      selectFrame(sliderpos, LLSettingsDay::DEFAULT_FRAME_SLOP_FACTOR);  } - -void LLFloaterEditExtDayCycle::onPanelDirtyFlagChanged(bool value) -{ -    if (value) -        setDirtyFlag(); -} - -void LLFloaterEditExtDayCycle::checkAndConfirmSettingsLoss(on_confirm_fn cb) -{ -    if (isDirty()) -    { -        LLSD args(LLSDMap("TYPE", mEditDay->getSettingsType()) -            ("NAME", mEditDay->getName())); - -        // create and show confirmation textbox -        LLNotificationsUtil::add("SettingsConfirmLoss", args, LLSD(), -            [cb](const LLSD¬if, const LLSD&resp) -            { -                S32 opt = LLNotificationsUtil::getSelectedOption(notif, resp); -                if (opt == 0) -                    cb(); -            }); -    } -    else if (cb) -    { -        cb(); -    } -} -  void LLFloaterEditExtDayCycle::onTimeSliderCallback()  {      stopPlay(); @@ -1435,106 +1332,6 @@ LLFloaterEditExtDayCycle::connection_t LLFloaterEditExtDayCycle::setEditCommitSi      return mCommitSignal.connect(cb);  } -void LLFloaterEditExtDayCycle::loadInventoryItem(const LLUUID  &inventoryId, bool can_trans) -{ -    if (inventoryId.isNull()) -    { -        mInventoryItem = nullptr; -        mInventoryId.setNull(); -        mCanSave = true; -        mCanCopy = true; -        mCanMod = true; -        mCanTrans = true; -        return; -    } - -    mInventoryId = inventoryId; -    LL_INFOS("ENVDAYEDIT") << "Setting edit inventory item to " << mInventoryId << "." << LL_ENDL; -    mInventoryItem = gInventory.getItem(mInventoryId); - -    if (!mInventoryItem) -    { -        LL_WARNS("ENVDAYEDIT") << "Could not find inventory item with Id = " << mInventoryId << LL_ENDL; - -        LLNotificationsUtil::add("CantFindInvItem"); -        closeFloater(); -        mInventoryId.setNull(); -        mInventoryItem = nullptr; -        return; -    } - -    if (mInventoryItem->getAssetUUID().isNull()) -    { -        LL_WARNS("ENVDAYEDIT") << "Asset ID in inventory item is NULL (" << mInventoryId << ")" <<  LL_ENDL; - -        LLNotificationsUtil::add("UnableEditItem"); -        closeFloater(); - -        mInventoryId.setNull(); -        mInventoryItem = nullptr; -        return; -    } - -    mCanSave = true; -    mCanCopy = mInventoryItem->getPermissions().allowCopyBy(gAgent.getID()); -    mCanMod = mInventoryItem->getPermissions().allowModifyBy(gAgent.getID()); -    mCanTrans = can_trans && mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID()); - -    mExpectingAssetId = mInventoryItem->getAssetUUID(); -    LLSettingsVOBase::getSettingsAsset(mInventoryItem->getAssetUUID(), -        [this](LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status, LLExtStat) { onAssetLoaded(asset_id, settings, status); }); -} - -void LLFloaterEditExtDayCycle::onAssetLoaded(LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status) -{ -    if (asset_id != mExpectingAssetId) -    { -        LL_WARNS("ENVDAYEDIT") << "Expecting {" << mExpectingAssetId << "} got {" << asset_id << "} - throwing away." << LL_ENDL; -        return; -    } -    mExpectingAssetId.setNull(); -    clearDirtyFlag(); - -    if (!settings || status) -    { -        LLSD args; -        args["NAME"] = (mInventoryItem) ? mInventoryItem->getName() : asset_id.asString(); -        LLNotificationsUtil::add("FailedToFindSettings", args); -        closeFloater(); -        return; -    } - -    if (settings->getFlag(LLSettingsBase::FLAG_NOSAVE)) -    { -        mCanSave = false; -        mCanCopy = false; -        mCanMod = false; -        mCanTrans = false; -    } -    else -    { -        if (mCanCopy) -            settings->clearFlag(LLSettingsBase::FLAG_NOCOPY); -        else -            settings->setFlag(LLSettingsBase::FLAG_NOCOPY); - -        if (mCanMod) -            settings->clearFlag(LLSettingsBase::FLAG_NOMOD); -        else -            settings->setFlag(LLSettingsBase::FLAG_NOMOD); - -        if (mCanTrans) -            settings->clearFlag(LLSettingsBase::FLAG_NOTRANS); -        else -            settings->setFlag(LLSettingsBase::FLAG_NOTRANS); - -        if (mInventoryItem) -            settings->setName(mInventoryItem->getName()); -    } - -    setEditDayCycle(std::dynamic_pointer_cast<LLSettingsDay>(settings)); -} -  void LLFloaterEditExtDayCycle::updateEditEnvironment(void)  {      if (!mEditDay) @@ -1670,93 +1467,6 @@ void LLFloaterEditExtDayCycle::reblendSettings()      mWaterBlender->setPosition(position);      } -void LLFloaterEditExtDayCycle::doApplyCreateNewInventory(const LLSettingsDay::ptr_t &day, std::string settings_name) -{ -    if (mInventoryItem) -    { -        LLUUID parent_id = mInventoryItem->getParentUUID(); -        U32 next_owner_perm = mInventoryItem->getPermissions().getMaskNextOwner(); -        LLSettingsVOBase::createInventoryItem(day, next_owner_perm, parent_id, settings_name, -            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); -    } -    else -    { -        LLUUID parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS); -        // This method knows what sort of settings object to create. -        LLSettingsVOBase::createInventoryItem(day, parent_id, settings_name, -            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); -    } -} - -void LLFloaterEditExtDayCycle::doApplyUpdateInventory(const LLSettingsDay::ptr_t &day) -{ -    if (mInventoryId.isNull()) -        LLSettingsVOBase::createInventoryItem(day, gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS), std::string(), -                [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); -    else -        LLSettingsVOBase::updateInventoryItem(day, mInventoryId, -                [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryUpdated(asset_id, inventory_id, results); }); -} - -void LLFloaterEditExtDayCycle::doApplyEnvironment(const std::string &where, const LLSettingsDay::ptr_t &day) -{ -    U32 flags(0); - -    if (mInventoryItem) -    { -        if (!mInventoryItem->getPermissions().allowOperationBy(PERM_MODIFY, gAgent.getID())) -            flags |= LLSettingsBase::FLAG_NOMOD; -        if (!mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID())) -            flags |= LLSettingsBase::FLAG_NOTRANS; -    } - -    flags |= day->getFlags(); -    day->setFlag(flags); - -    if (where == ACTION_APPLY_LOCAL) -    { -        day->setName("Local"); // To distinguish and make sure there is a name. Safe, because this is a copy. -        LLEnvironment::instance().setEnvironment(LLEnvironment::ENV_LOCAL, day); -    } -    else if (where == ACTION_APPLY_PARCEL) -    { -        LLParcel *parcel(LLViewerParcelMgr::instance().getAgentOrSelectedParcel()); - -        if ((!parcel) || (parcel->getLocalID() == INVALID_PARCEL_ID)) -        { -            LL_WARNS("ENVDAYEDIT") << "Can not identify parcel. Not applying." << LL_ENDL; -            LLNotificationsUtil::add("WLParcelApplyFail"); -            return; -        } - -        if (mInventoryItem && !isDirty()) -        { -            LLEnvironment::instance().updateParcel(parcel->getLocalID(), mInventoryItem->getAssetUUID(), mInventoryItem->getName(), LLEnvironment::NO_TRACK, -1, -1, flags); -        } -        else -        { -            LLEnvironment::instance().updateParcel(parcel->getLocalID(), day, -1, -1); -        } -    } -    else if (where == ACTION_APPLY_REGION) -    { -        if (mInventoryItem && !isDirty()) -        { -            LLEnvironment::instance().updateRegion(mInventoryItem->getAssetUUID(), mInventoryItem->getName(), LLEnvironment::NO_TRACK, -1, -1, flags); -        } -        else -        { -            LLEnvironment::instance().updateRegion(day, -1, -1); -        } -    } -    else -    { -        LL_WARNS("ENVDAYEDIT") << "Unknown apply '" << where << "'" << LL_ENDL; -        return; -    } - -} -  void LLFloaterEditExtDayCycle::doApplyCommit(LLSettingsDay::ptr_t day)  {      if (!mCommitSignal.empty()) @@ -1793,51 +1503,6 @@ bool LLFloaterEditExtDayCycle::isAddingFrameAllowed()      return mFramesSlider->canAddSliders();  } -void LLFloaterEditExtDayCycle::onInventoryCreated(LLUUID asset_id, LLUUID inventory_id, LLSD results) -{ -    LL_INFOS("ENVDAYEDIT") << "Inventory item " << inventory_id << " has been created with asset " << asset_id << " results are:" << results << LL_ENDL; - -    if (inventory_id.isNull() || !results["success"].asBoolean()) -    { -        LLNotificationsUtil::add("CantCreateInventory"); -        return; -    } -    onInventoryCreated(asset_id, inventory_id); -} - -void LLFloaterEditExtDayCycle::onInventoryCreated(LLUUID asset_id, LLUUID inventory_id) -{ -    bool can_trans = true; -    if (mInventoryItem) -    { -        LLPermissions perms = mInventoryItem->getPermissions(); - -        LLInventoryItem *created_item = gInventory.getItem(mInventoryId); -         -        if (created_item) -        { -            can_trans = perms.allowOperationBy(PERM_TRANSFER, gAgent.getID()); -            created_item->setPermissions(perms); -            created_item->updateServer(false); -        } -    } - -    clearDirtyFlag(); -    setFocus(TRUE);                 // Call back the focus... -    loadInventoryItem(inventory_id, can_trans); -} - -void LLFloaterEditExtDayCycle::onInventoryUpdated(LLUUID asset_id, LLUUID inventory_id, LLSD results) -{ -    LL_WARNS("ENVDAYEDIT") << "Inventory item " << inventory_id << " has been updated with asset " << asset_id << " results are:" << results << LL_ENDL; - -    clearDirtyFlag(); -    if (inventory_id != mInventoryId) -    { -        loadInventoryItem(inventory_id); -    } -} -  void LLFloaterEditExtDayCycle::doImportFromDisk()  {   // Load a a legacy Windlight XML from disk.      (new LLFilePickerReplyThread(boost::bind(&LLFloaterEditExtDayCycle::loadSettingFromFile, this, _1), LLFilePicker::FFLOAD_XML, false))->getFile(); @@ -1864,21 +1529,6 @@ void LLFloaterEditExtDayCycle::loadSettingFromFile(const std::vector<std::string      setEditDayCycle(legacyday);  } -bool LLFloaterEditExtDayCycle::canUseInventory() const -{ -    return LLEnvironment::instance().isInventoryEnabled(); -} - -bool LLFloaterEditExtDayCycle::canApplyRegion() const -{ -    return gAgent.canManageEstate(); -} - -bool LLFloaterEditExtDayCycle::canApplyParcel() const -{ -    return LLEnvironment::instance().canAgentUpdateParcelEnvironment(); -} -  void LLFloaterEditExtDayCycle::startPlay()  {      doCloseInventoryFloater(); @@ -1983,14 +1633,8 @@ void LLFloaterEditExtDayCycle::doCloseTrackFloater(bool quitting)      }  } -void LLFloaterEditExtDayCycle::onPickerCommitTrackId(U32 track_id) +LLFloaterSettingsPicker * LLFloaterEditExtDayCycle::getSettingsPicker()  { -    cloneTrack(track_id, mCurrentTrack); -} - -void LLFloaterEditExtDayCycle::doOpenInventoryFloater(LLSettingsType::type_e type, LLUUID curritem) -{ -//  LLUI::sWindow->setCursor(UI_CURSOR_WAIT);      LLFloaterSettingsPicker *picker = static_cast<LLFloaterSettingsPicker *>(mInventoryFloater.get());      // Show the dialog @@ -2003,7 +1647,17 @@ void LLFloaterEditExtDayCycle::doOpenInventoryFloater(LLSettingsType::type_e typ          picker->setCommitCallback([this](LLUICtrl *, const LLSD &data){ onPickerCommitSetting(data["ItemId"].asUUID(), data["Track"].asInteger()); });      } +    return picker; +} + +void LLFloaterEditExtDayCycle::onPickerCommitTrackId(U32 track_id) +{ +    cloneTrack(track_id, mCurrentTrack); +} +void LLFloaterEditExtDayCycle::doOpenInventoryFloater(LLSettingsType::type_e type, LLUUID curritem) +{ +    LLFloaterSettingsPicker *picker = getSettingsPicker();      picker->setSettingsFilter(type);      picker->setSettingsItemId(curritem);      if (type == LLSettingsType::ST_DAYCYCLE) @@ -2018,16 +1672,6 @@ void LLFloaterEditExtDayCycle::doOpenInventoryFloater(LLSettingsType::type_e typ      picker->setFocus(TRUE);  } -void LLFloaterEditExtDayCycle::doCloseInventoryFloater(bool quitting) -{ -    LLFloater* floaterp = mInventoryFloater.get(); - -    if (floaterp) -    { -        floaterp->closeFloater(quitting); -    } -} -  void LLFloaterEditExtDayCycle::onPickerCommitSetting(LLUUID item_id, S32 track)  {      LLSettingsBase::TrackPosition frame(mTimeSlider->getCurSliderValue()); @@ -2118,7 +1762,9 @@ void LLFloaterEditExtDayCycle::onAssetLoadedForInsertion(LLUUID item_id, LLUUID      LLInventoryItem *inv_item = gInventory.getItem(item_id); -    if (inv_item && !inv_item->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID())) +    if (inv_item +        && (!inv_item->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID()) +            || !inv_item->getPermissions().allowOperationBy(PERM_COPY, gAgent.getID())))      {          // Need to check if item is already no-transfer, otherwise make it no-transfer          bool no_transfer = false; diff --git a/indra/newview/llfloatereditextdaycycle.h b/indra/newview/llfloatereditextdaycycle.h index b6e9fdb14f..9a30fb199f 100644 --- a/indra/newview/llfloatereditextdaycycle.h +++ b/indra/newview/llfloatereditextdaycycle.h @@ -32,6 +32,7 @@  #include <boost/signals2.hpp>  #include "llenvironment.h" +#include "llfloatereditenvironmentbase.h"  class LLCheckBoxCtrl;  class LLComboBox; @@ -50,14 +51,13 @@ typedef std::shared_ptr<LLSettingsBase> LLSettingsBasePtr_t;  /**   * Floater for creating or editing a day cycle.   */ -class LLFloaterEditExtDayCycle : public LLFloater +class LLFloaterEditExtDayCycle : public LLFloaterEditEnvironmentBase  {  	LOG_CLASS(LLFloaterEditExtDayCycle);      friend class LLDaySettingCopiedCallback;  public: -    static const std::string    KEY_INVENTORY_ID;      static const std::string    KEY_EDIT_CONTEXT;      static const std::string    KEY_DAY_LENGTH;      static const std::string    KEY_CANMOD; @@ -82,8 +82,8 @@ public:      virtual BOOL                postBuild() override;      virtual void                onOpen(const LLSD& key) override;      virtual void                onClose(bool app_quitting) override; -    virtual void                onFocusReceived() override; -    virtual void                onFocusLost() override; +    //virtual void                onFocusReceived() override; +    //virtual void                onFocusLost() override;      virtual void                onVisibilityChange(BOOL new_visibility) override;      connection_t                setEditCommitSignal(edit_commit_signal_t::slot_type cb); @@ -97,10 +97,13 @@ public:      LLUUID                      getEditingAssetId() { return mEditDay ? mEditDay->getAssetId() : LLUUID::null; }      LLUUID                      getEditingInventoryId() { return mInventoryId; } +    virtual LLSettingsBase::ptr_t getEditSettings()   const override { return mEditDay; } +      BOOL			            handleKeyUp(KEY key, MASK mask, BOOL called_from_parent) override; -    BOOL                        isDirty() const override { return getIsDirty(); }  +protected: +    virtual void                setEditSettingsAndUpdate(const LLSettingsBase::ptr_t &settings) override;  private:      typedef std::function<void()> on_confirm_fn; @@ -108,8 +111,8 @@ private:  	// flyout response/click  	void                        onButtonApply(LLUICtrl *ctrl, const LLSD &data); -    virtual void                onClickCloseBtn(bool app_quitting = false) override; -    void                        onButtonImport(); +    //virtual void                onClickCloseBtn(bool app_quitting = false) override; +    //void                        onButtonImport();      void                        onButtonLoadFrame();      void                        onAddFrame();  	void                        onRemoveFrame(); @@ -119,7 +122,6 @@ private:  	void                        onCommitName(class LLLineEditor* caller, void* user_data);  	void                        onTrackSelectionCallback(const LLSD& user_data);  	void                        onPlayActionCallback(const LLSD& user_data); -	void                        onSaveAsCommit(const LLSD& notification, const LLSD& response, const LLSettingsDay::ptr_t &day);  	// time slider clicked  	void                        onTimeSliderCallback();  	// a frame moved or frame selection changed @@ -128,10 +130,6 @@ private:      void                        onFrameSliderMouseDown(S32 x, S32 y, MASK mask);      void                        onFrameSliderMouseUp(S32 x, S32 y, MASK mask); -    void                        onPanelDirtyFlagChanged(bool); - -    void                        checkAndConfirmSettingsLoss(on_confirm_fn cb); -      void                        cloneTrack(U32 source_index, U32 dest_index);      void                        cloneTrack(const LLSettingsDay::ptr_t &source_day, U32 source_index, U32 dest_index);  	void                        selectTrack(U32 track_index, bool force = false); @@ -148,25 +146,21 @@ private:      void                        removeCurrentSliderFrame();      void                        removeSliderFrame(F32 frame); -    void                        loadInventoryItem(const LLUUID  &inventoryId, bool can_trans = true); -    void                        onAssetLoaded(LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status); - -    void                        doImportFromDisk(); +    virtual void                doImportFromDisk() override;      void                        loadSettingFromFile(const std::vector<std::string>& filenames); -    void                        doApplyCreateNewInventory(const LLSettingsDay::ptr_t &day, std::string settings_name); -    void                        doApplyUpdateInventory(const LLSettingsDay::ptr_t &day); -    void                        doApplyEnvironment(const std::string &where, const LLSettingsDay::ptr_t &day);      void                        doApplyCommit(LLSettingsDay::ptr_t day);      void                        onInventoryCreated(LLUUID asset_id, LLUUID inventory_id);      void                        onInventoryCreated(LLUUID asset_id, LLUUID inventory_id, LLSD results);      void                        onInventoryUpdated(LLUUID asset_id, LLUUID inventory_id, LLSD results); +      void                        doOpenTrackFloater(const LLSD &args);      void                        doCloseTrackFloater(bool quitting = false); +    virtual LLFloaterSettingsPicker* getSettingsPicker() override;      void                        onPickerCommitTrackId(U32 track_id);      void                        doOpenInventoryFloater(LLSettingsType::type_e type, LLUUID curritem); -    void                        doCloseInventoryFloater(bool quitting = false); +    //void                        doCloseInventoryFloater(bool quitting = false);      void                        onPickerCommitSetting(LLUUID item_id, S32 track);      void                        onAssetLoadedForInsertion(LLUUID item_id,                                                            LLUUID asset_id, @@ -176,11 +170,7 @@ private:                                                            S32 dest_track,                                                            LLSettingsBase::TrackPosition dest_frame); -    bool                        canUseInventory() const; -    bool                        canApplyRegion() const; -    bool                        canApplyParcel() const; - -    void                        updateEditEnvironment(); +    virtual void                updateEditEnvironment() override;      void                        synchronizeTabs();      void                        reblendSettings(); @@ -193,7 +183,7 @@ private:      bool                        getIsDirty() const  { return mIsDirty; }      void                        setDirtyFlag()      { mIsDirty = true; } -    virtual void                clearDirtyFlag(); +    virtual void                clearDirtyFlag() override;      bool                        isRemovingFrameAllowed();      bool                        isAddingFrameAllowed(); @@ -218,11 +208,8 @@ private:      LLView*                     mSkyTabLayoutContainer;      LLView*                     mWaterTabLayoutContainer;      LLTextBox*                  mCurrentTimeLabel; -    LLUUID                      mInventoryId; -    LLInventoryItem *           mInventoryItem;      LLFlyoutComboBtnCtrl *      mFlyoutControl; -    LLHandle<LLFloater>         mInventoryFloater;      LLHandle<LLFloater>         mTrackFloater;      LLTrackBlenderLoopingManual::ptr_t  mSkyBlender; @@ -236,11 +223,6 @@ private:      LLFrameTimer                mPlayTimer;      F32                         mPlayStartFrame; // an env frame      bool                        mIsPlaying; -    bool                        mIsDirty; -    bool                        mCanCopy; -    bool                        mCanMod; -    bool                        mCanTrans; -    bool                        mCanSave;      edit_commit_signal_t        mCommitSignal; diff --git a/indra/newview/llfloaterfixedenvironment.cpp b/indra/newview/llfloaterfixedenvironment.cpp index cd8e0a48e7..41bbd5e8f9 100644 --- a/indra/newview/llfloaterfixedenvironment.cpp +++ b/indra/newview/llfloaterfixedenvironment.cpp @@ -81,44 +81,11 @@ namespace      const std::string XML_FLYOUTMENU_FILE("menu_save_settings.xml");  } -//========================================================================= -const std::string LLFloaterFixedEnvironment::KEY_INVENTORY_ID("inventory_id"); - - -//========================================================================= - -class LLFixedSettingCopiedCallback : public LLInventoryCallback -{ -public: -    LLFixedSettingCopiedCallback(LLHandle<LLFloater> handle) : mHandle(handle) {} - -    virtual void fire(const LLUUID& inv_item_id) -    { -        if (!mHandle.isDead()) -        { -            LLViewerInventoryItem* item = gInventory.getItem(inv_item_id); -            if (item) -            { -                LLFloaterFixedEnvironment* floater = (LLFloaterFixedEnvironment*)mHandle.get(); -                floater->onInventoryCreated(item->getAssetUUID(), inv_item_id); -            } -        } -    } - -private: -    LLHandle<LLFloater> mHandle; -};  //=========================================================================  LLFloaterFixedEnvironment::LLFloaterFixedEnvironment(const LLSD &key) : -    LLFloater(key), -    mFlyoutControl(nullptr), -    mInventoryId(), -    mInventoryItem(nullptr), -    mIsDirty(false), -    mCanCopy(false), -    mCanMod(false), -    mCanTrans(false) +    LLFloaterEditEnvironmentBase(key), +    mFlyoutControl(nullptr)  {  } @@ -176,19 +143,6 @@ void LLFloaterFixedEnvironment::onClose(bool app_quitting)      syncronizeTabs();  } -void LLFloaterFixedEnvironment::onFocusReceived() -{ -    if (isInVisibleChain()) -    { -        updateEditEnvironment(); -        LLEnvironment::instance().setSelectedEnvironment(LLEnvironment::ENV_EDIT, LLEnvironment::TRANSITION_FAST); -    } -} - -void LLFloaterFixedEnvironment::onFocusLost() -{ -} -  void LLFloaterFixedEnvironment::refresh()  {      if (!mSettings) @@ -220,6 +174,15 @@ void LLFloaterFixedEnvironment::refresh()      }  } +void LLFloaterFixedEnvironment::setEditSettingsAndUpdate(const LLSettingsBase::ptr_t &settings) +{ +    mSettings = settings; // shouldn't this do buildDeepCloneAndUncompress() ? +    updateEditEnvironment(); +    syncronizeTabs(); +    refresh(); +    LLEnvironment::instance().updateEnvironment(LLEnvironment::TRANSITION_FAST); +} +  void LLFloaterFixedEnvironment::syncronizeTabs()  {      S32 count = mTab->getTabCount(); @@ -250,131 +213,9 @@ LLFloaterSettingsPicker * LLFloaterFixedEnvironment::getSettingsPicker()      return picker;  } -void LLFloaterFixedEnvironment::loadInventoryItem(const LLUUID  &inventoryId, bool can_trans) -{ -    if (inventoryId.isNull()) -    { -        mInventoryItem = nullptr; -        mInventoryId.setNull(); -        mCanMod = true; -        mCanCopy = true; -        mCanTrans = true; -        return; -    } - -    mInventoryId = inventoryId; -    LL_INFOS("SETTINGS") << "Setting edit inventory item to " << mInventoryId << "." << LL_ENDL; -    mInventoryItem = gInventory.getItem(mInventoryId); - -    if (!mInventoryItem) -    { -        LL_WARNS("SETTINGS") << "Could not find inventory item with Id = " << mInventoryId << LL_ENDL; -        LLNotificationsUtil::add("CantFindInvItem"); -        closeFloater(); - -        mInventoryId.setNull(); -        mInventoryItem = nullptr; -        return; -    } - -    if (mInventoryItem->getAssetUUID().isNull()) -    { -        LL_WARNS("ENVIRONMENT") << "Asset ID in inventory item is NULL (" << mInventoryId << ")" << LL_ENDL; -        LLNotificationsUtil::add("UnableEditItem"); -        closeFloater(); - -        mInventoryId.setNull(); -        mInventoryItem = nullptr; -        return; -    } - -    mCanCopy = mInventoryItem->getPermissions().allowCopyBy(gAgent.getID()); -    mCanMod = mInventoryItem->getPermissions().allowModifyBy(gAgent.getID()); -    mCanTrans = can_trans && mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID()); - -    LLSettingsVOBase::getSettingsAsset(mInventoryItem->getAssetUUID(), -        [this](LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status, LLExtStat) { onAssetLoaded(asset_id, settings, status); }); -} - - -void LLFloaterFixedEnvironment::checkAndConfirmSettingsLoss(LLFloaterFixedEnvironment::on_confirm_fn cb) -{ -    if (isDirty()) -    { -        LLSD args(LLSDMap("TYPE", mSettings->getSettingsType()) -            ("NAME", mSettings->getName())); - -        // create and show confirmation textbox -        LLNotificationsUtil::add("SettingsConfirmLoss", args, LLSD(), -            [cb](const LLSD¬if, const LLSD&resp) -            { -                S32 opt = LLNotificationsUtil::getSelectedOption(notif, resp); -                if (opt == 0) -                    cb(); -            }); -    } -    else if (cb) -    { -        cb(); -    } -} -  void LLFloaterFixedEnvironment::onPickerCommitSetting(LLUUID item_id)  {      loadInventoryItem(item_id); -//     mInventoryId = item_id; -//     mInventoryItem = gInventory.getItem(mInventoryId); -//  -//     mCanCopy = mInventoryItem->getPermissions().allowCopyBy(gAgent.getID()); -//     mCanMod = mInventoryItem->getPermissions().allowModifyBy(gAgent.getID()); -//     mCanTrans = mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID()); -//  -//     LLSettingsVOBase::getSettingsAsset(mInventoryItem->getAssetUUID(), -//         [this](LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status, LLExtStat) { onAssetLoaded(asset_id, settings, status); }); -} - -void LLFloaterFixedEnvironment::onAssetLoaded(LLUUID asset_id, LLSettingsBase::ptr_t settings, S32 status) -{ -    if (mInventoryItem && mInventoryItem->getAssetUUID() != asset_id) -    { -        LL_WARNS("ENVIRONMENT") << "Discarding obsolete asset callback" << LL_ENDL; -        return; -    } - -    clearDirtyFlag(); - -    if (!settings || status) -    { -        LLSD args; -        args["NAME"] = (mInventoryItem) ? mInventoryItem->getName() : asset_id.asString(); -        LLNotificationsUtil::add("FailedToFindSettings", args); -        closeFloater(); -        return; -    } - -    mSettings = settings; -    if (mInventoryItem) -        mSettings->setName(mInventoryItem->getName()); - -    if (mCanCopy) -        settings->clearFlag(LLSettingsBase::FLAG_NOCOPY); -    else -        settings->setFlag(LLSettingsBase::FLAG_NOCOPY); - -    if (mCanMod) -        settings->clearFlag(LLSettingsBase::FLAG_NOMOD); -    else -        settings->setFlag(LLSettingsBase::FLAG_NOMOD); - -    if (mCanTrans) -        settings->clearFlag(LLSettingsBase::FLAG_NOTRANS); -    else -        settings->setFlag(LLSettingsBase::FLAG_NOTRANS); - -    updateEditEnvironment(); -    syncronizeTabs(); -    refresh(); -    LLEnvironment::instance().updateEnvironment(LLEnvironment::TRANSITION_FAST);  }  void LLFloaterFixedEnvironment::onNameChanged(const std::string &name) @@ -473,50 +314,6 @@ void LLFloaterFixedEnvironment::onButtonApply(LLUICtrl *ctrl, const LLSD &data)      }  } -void LLFloaterFixedEnvironment::onSaveAsCommit(const LLSD& notification, const LLSD& response, const LLSettingsBase::ptr_t &settings) -{ -    S32 option = LLNotificationsUtil::getSelectedOption(notification, response); -    if (0 == option) -    { -        std::string settings_name = response["message"].asString(); - -        LLInventoryObject::correctInventoryName(settings_name); -        if (settings_name.empty()) -        { -            // Ideally notification should disable 'OK' button if name won't fit our requirements, -            // for now either display notification, or use some default name -            settings_name = "Unnamed"; -        } - -        if (mCanMod) -        { -            doApplyCreateNewInventory(settings_name, settings); -        } -        else if (mInventoryItem) -        { -            const LLUUID &marketplacelistings_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_MARKETPLACE_LISTINGS, false); -            LLUUID parent_id = mInventoryItem->getParentUUID(); -            if (marketplacelistings_id == parent_id) -            { -                parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS); -            } - -            LLPointer<LLInventoryCallback> cb = new LLFixedSettingCopiedCallback(getHandle()); -            copy_inventory_item( -                gAgent.getID(), -                mInventoryItem->getPermissions().getOwner(), -                mInventoryItem->getUUID(), -                parent_id, -                settings_name, -                cb); -        } -        else -        { -            LL_WARNS() << "Failed to copy fixed env setting" << LL_ENDL; -        } -    } -} -  void LLFloaterFixedEnvironment::onClickCloseBtn(bool app_quitting)  {      if (!app_quitting) @@ -530,116 +327,6 @@ void LLFloaterFixedEnvironment::onButtonLoad()      checkAndConfirmSettingsLoss([this](){ doSelectFromInventory(); });  } -void LLFloaterFixedEnvironment::doApplyCreateNewInventory(std::string settings_name, const LLSettingsBase::ptr_t &settings) -{ -    if (mInventoryItem) -    { -        LLUUID parent_id = mInventoryItem->getParentUUID(); -        U32 next_owner_perm = mInventoryItem->getPermissions().getMaskNextOwner(); -        LLSettingsVOBase::createInventoryItem(settings, next_owner_perm, parent_id, settings_name, -            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); -    } -    else -    { -        LLUUID parent_id = gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS); -        // This method knows what sort of settings object to create. -        LLSettingsVOBase::createInventoryItem(settings, parent_id, settings_name, -            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); -    } -} - -void LLFloaterFixedEnvironment::doApplyUpdateInventory(const LLSettingsBase::ptr_t &settings) -{ -    LL_DEBUGS("ENVEDIT") << "Update inventory for " << mInventoryId << LL_ENDL; -    if (mInventoryId.isNull()) -    { -        LLSettingsVOBase::createInventoryItem(settings, gInventory.findCategoryUUIDForType(LLFolderType::FT_SETTINGS), std::string(), -            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryCreated(asset_id, inventory_id, results); }); -    } -    else -    { -        LLSettingsVOBase::updateInventoryItem(settings, mInventoryId, -            [this](LLUUID asset_id, LLUUID inventory_id, LLUUID, LLSD results) { onInventoryUpdated(asset_id, inventory_id, results); }); -    } -} - -void LLFloaterFixedEnvironment::doApplyEnvironment(const std::string &where, const LLSettingsBase::ptr_t &settings) -{ -    U32 flags(0); - -    if (mInventoryItem) -    { -        if (!mInventoryItem->getPermissions().allowOperationBy(PERM_MODIFY, gAgent.getID())) -            flags |= LLSettingsBase::FLAG_NOMOD; -        if (!mInventoryItem->getPermissions().allowOperationBy(PERM_TRANSFER, gAgent.getID())) -            flags |= LLSettingsBase::FLAG_NOTRANS; -    } - -    flags |= settings->getFlags(); -    settings->setFlag(flags); - -    if (where == ACTION_APPLY_LOCAL) -    { -        settings->setName("Local"); // To distinguish and make sure there is a name. Safe, because this is a copy. -        LLEnvironment::instance().setEnvironment(LLEnvironment::ENV_LOCAL, settings); -    } -    else if (where == ACTION_APPLY_PARCEL) -    { -        LLParcel *parcel(LLViewerParcelMgr::instance().getAgentOrSelectedParcel()); - -        if ((!parcel) || (parcel->getLocalID() == INVALID_PARCEL_ID)) -        { -            LL_WARNS("ENVIRONMENT") << "Can not identify parcel. Not applying." << LL_ENDL; -            LLNotificationsUtil::add("WLParcelApplyFail"); -            return; -        } - -        if (mInventoryItem && !isDirty()) -        { -            LLEnvironment::instance().updateParcel(parcel->getLocalID(), mInventoryItem->getAssetUUID(), mInventoryItem->getName(), LLEnvironment::NO_TRACK, -1, -1, flags); -        } -        else if (settings->getSettingsType() == "sky") -        { -            LLEnvironment::instance().updateParcel(parcel->getLocalID(), std::static_pointer_cast<LLSettingsSky>(settings), -1, -1); -        } -        else if (settings->getSettingsType() == "water") -        { -            LLEnvironment::instance().updateParcel(parcel->getLocalID(), std::static_pointer_cast<LLSettingsWater>(settings), -1, -1); -        } -    } -    else if (where == ACTION_APPLY_REGION) -    { -        if (mInventoryItem && !isDirty()) -        { -            LLEnvironment::instance().updateRegion(mInventoryItem->getAssetUUID(), mInventoryItem->getName(), LLEnvironment::NO_TRACK, -1, -1, flags); -        } -        else if (settings->getSettingsType() == "sky") -        { -            LLEnvironment::instance().updateRegion(std::static_pointer_cast<LLSettingsSky>(settings), -1, -1); -        } -        else if (settings->getSettingsType() == "water") -        { -            LLEnvironment::instance().updateRegion(std::static_pointer_cast<LLSettingsWater>(settings), -1, -1); -        } -    } -    else -    { -        LL_WARNS("ENVIRONMENT") << "Unknown apply '" << where << "'" << LL_ENDL; -        return; -    } - -} - -void LLFloaterFixedEnvironment::doCloseInventoryFloater(bool quitting) -{ -    LLFloater* floaterp = mInventoryFloater.get(); - -    if (floaterp) -    { -        floaterp->closeFloater(quitting); -    } -} -  void LLFloaterFixedEnvironment::onInventoryCreated(LLUUID asset_id, LLUUID inventory_id, LLSD results)  {      LL_WARNS("ENVIRONMENT") << "Inventory item " << inventory_id << " has been created with asset " << asset_id << " results are:" << results << LL_ENDL; @@ -709,28 +396,6 @@ void LLFloaterFixedEnvironment::doSelectFromInventory()      picker->setFocus(TRUE);  } -void LLFloaterFixedEnvironment::onPanelDirtyFlagChanged(bool value) -{ -    if (value) -        setDirtyFlag(); -} - -//------------------------------------------------------------------------- -bool LLFloaterFixedEnvironment::canUseInventory() const -{ -    return LLEnvironment::instance().isInventoryEnabled(); -} - -bool LLFloaterFixedEnvironment::canApplyRegion() const -{ -    return gAgent.canManageEstate(); -} - -bool LLFloaterFixedEnvironment::canApplyParcel() const -{ -    return LLEnvironment::instance().canAgentUpdateParcelEnvironment(); -} -  //=========================================================================  LLFloaterFixedEnvironmentWater::LLFloaterFixedEnvironmentWater(const LLSD &key):      LLFloaterFixedEnvironment(key) diff --git a/indra/newview/llfloaterfixedenvironment.h b/indra/newview/llfloaterfixedenvironment.h index 513996c4a3..f35f4a4368 100644 --- a/indra/newview/llfloaterfixedenvironment.h +++ b/indra/newview/llfloaterfixedenvironment.h @@ -27,7 +27,7 @@  #ifndef LL_FLOATERFIXEDENVIRONMENT_H  #define LL_FLOATERFIXEDENVIRONMENT_H -#include "llfloater.h" +#include "llfloatereditenvironmentbase.h"  #include "llsettingsbase.h"  #include "llflyoutcombobtn.h"  #include "llinventory.h" @@ -43,15 +43,10 @@ class LLFixedSettingCopiedCallback;  /**   * Floater container for creating and editing fixed environment settings.   */ -class LLFloaterFixedEnvironment : public LLFloater +class LLFloaterFixedEnvironment : public LLFloaterEditEnvironmentBase  {      LOG_CLASS(LLFloaterFixedEnvironment); - -    friend class LLFixedSettingCopiedCallback; -  public: -    static const std::string    KEY_INVENTORY_ID; -                              LLFloaterFixedEnvironment(const LLSD &key);                              ~LLFloaterFixedEnvironment(); @@ -59,64 +54,35 @@ public:      virtual void            onOpen(const LLSD& key)     override;      virtual void            onClose(bool app_quitting)  override; -    virtual void            onFocusReceived()           override; -    virtual void            onFocusLost()               override; -      void                    setEditSettings(const LLSettingsBase::ptr_t &settings)  { mSettings = settings; clearDirtyFlag(); syncronizeTabs(); refresh(); } -    LLSettingsBase::ptr_t   getEditSettings()   const                           { return mSettings; } - -    virtual BOOL            isDirty() const override            { return getIsDirty(); } +    virtual LLSettingsBase::ptr_t getEditSettings()   const override                { return mSettings; }  protected:      typedef std::function<void()> on_confirm_fn; -    virtual void            updateEditEnvironment() = 0;      virtual void            refresh()                   override; +    void                    setEditSettingsAndUpdate(const LLSettingsBase::ptr_t &settings) override;      virtual void            syncronizeTabs(); -    LLFloaterSettingsPicker *getSettingsPicker(); - -    void                    loadInventoryItem(const LLUUID  &inventoryId, bool can_trans = true); - -    void                    checkAndConfirmSettingsLoss(on_confirm_fn cb); +    virtual LLFloaterSettingsPicker *getSettingsPicker() override;      LLTabContainer *        mTab;      LLLineEditor *          mTxtName;      LLSettingsBase::ptr_t   mSettings; -    virtual void            doImportFromDisk() = 0; -    virtual void            doApplyCreateNewInventory(std::string settings_name, const LLSettingsBase::ptr_t &settings); -    virtual void            doApplyUpdateInventory(const LLSettingsBase::ptr_t &settings); -    virtual void            doApplyEnvironment(const std::string &where, const LLSettingsBase::ptr_t &settings); -    void                    doCloseInventoryFloater(bool quitting = false); - -    bool                    canUseInventory() const; -    bool                    canApplyRegion() const; -    bool                    canApplyParcel() const; -      LLFlyoutComboBtnCtrl *      mFlyoutControl; -    LLUUID                  mInventoryId; -    LLInventoryItem *       mInventoryItem; -    LLHandle<LLFloater>     mInventoryFloater; -    bool                    mCanCopy; -    bool                    mCanMod; -    bool                    mCanTrans; -      void                    onInventoryCreated(LLUUID asset_id, LLUUID inventory_id);      void                    onInventoryCreated(LLUUID asset_id, LLUUID inventory_id, LLSD results);      void                    onInventoryUpdated(LLUUID asset_id, LLUUID inventory_id, LLSD results); -    bool                    getIsDirty() const  { return mIsDirty; } -    void                    setDirtyFlag()      { mIsDirty = true; } -    virtual void            clearDirtyFlag(); +    virtual void            clearDirtyFlag() override; +    void                    updatePermissionFlags();      void                    doSelectFromInventory(); -    void                    onPanelDirtyFlagChanged(bool);      virtual void            onClickCloseBtn(bool app_quitting = false) override; -    void                    onSaveAsCommit(const LLSD& notification, const LLSD& response, const LLSettingsBase::ptr_t &settings);  private:      void                    onNameChanged(const std::string &name); @@ -126,9 +92,6 @@ private:      void                    onButtonLoad();      void                    onPickerCommitSetting(LLUUID item_id); -    void                    onAssetLoaded(LLUUID asset_id, LLSettingsBase::ptr_t settins, S32 status); - -    bool                    mIsDirty;  };  class LLFloaterFixedEnvironmentWater : public LLFloaterFixedEnvironment @@ -172,36 +135,4 @@ protected:  private:  }; -class LLSettingsEditPanel : public LLPanel -{ -public: -    virtual void setSettings(const LLSettingsBase::ptr_t &) = 0; - -    typedef boost::signals2::signal<void(LLPanel *, bool)> on_dirty_charged_sg; -    typedef boost::signals2::connection connection_t; - -    inline bool         getIsDirty() const      { return mIsDirty; } -    inline void         setIsDirty()            { mIsDirty = true; if (!mOnDirtyChanged.empty()) mOnDirtyChanged(this, mIsDirty); } -    inline void         clearIsDirty()          { mIsDirty = false; if (!mOnDirtyChanged.empty()) mOnDirtyChanged(this, mIsDirty); } - -    inline bool        getCanChangeSettings() const    { return mCanEdit; } -    inline void        setCanChangeSettings(bool flag) { mCanEdit = flag; } - -    inline connection_t setOnDirtyFlagChanged(on_dirty_charged_sg::slot_type cb)    { return mOnDirtyChanged.connect(cb); } - - -protected: -    LLSettingsEditPanel() : -        LLPanel(), -        mIsDirty(false), -        mOnDirtyChanged() -    {} - -private: -    bool                mIsDirty; -    bool                mCanEdit; -     -    on_dirty_charged_sg mOnDirtyChanged; -}; -  #endif // LL_FLOATERFIXEDENVIRONMENT_H diff --git a/indra/newview/llfloaterimcontainer.cpp b/indra/newview/llfloaterimcontainer.cpp index c6e9069d09..9c84fa1991 100644 --- a/indra/newview/llfloaterimcontainer.cpp +++ b/indra/newview/llfloaterimcontainer.cpp @@ -59,7 +59,9 @@  #include "boost/foreach.hpp" -const S32 EVENTS_PER_IDLE_LOOP = 100; +const S32 EVENTS_PER_IDLE_LOOP_CURRENT_SESSION = 80; +const S32 EVENTS_PER_IDLE_LOOP_BACKGROUND = 40; +const F32 EVENTS_PER_IDLE_LOOP_MIN_PERCENTAGE = 0.01f; // process a minimum of 1% of total events per frame  //  // LLFloaterIMContainer @@ -309,12 +311,15 @@ void LLFloaterIMContainer::addFloater(LLFloater* floaterp,  	LLIconCtrl* icon = 0; +	bool is_in_group = gAgent.isInGroup(session_id, TRUE); +	LLUUID icon_id; -	if(gAgent.isInGroup(session_id, TRUE)) +	if (is_in_group)  	{  		LLGroupIconCtrl::Params icon_params;  		icon_params.group_id = session_id;  		icon = LLUICtrlFactory::instance().create<LLGroupIconCtrl>(icon_params); +		icon_id = session_id;  		mSessions[session_id] = floaterp;  		floaterp->mCloseSignal.connect(boost::bind(&LLFloaterIMContainer::onCloseFloater, this, session_id)); @@ -326,11 +331,18 @@ void LLFloaterIMContainer::addFloater(LLFloater* floaterp,  		LLAvatarIconCtrl::Params icon_params;  		icon_params.avatar_id = avatar_id;  		icon = LLUICtrlFactory::instance().create<LLAvatarIconCtrl>(icon_params); +		icon_id = avatar_id;  		mSessions[session_id] = floaterp;  		floaterp->mCloseSignal.connect(boost::bind(&LLFloaterIMContainer::onCloseFloater, this, session_id));  	} +	LLFloaterIMSessionTab* floater = LLFloaterIMSessionTab::getConversation(session_id); +	if (floater) +	{ +		floater->updateChatIcon(icon_id); +	} +  	// forced resize of the floater  	LLRect wrapper_rect = this->mTabContainer->getLocalRect();  	floaterp->setRect(wrapper_rect); @@ -416,8 +428,11 @@ void LLFloaterIMContainer::processParticipantsStyleUpdate()  		while (current_participant_model != end_participant_model)  		{  			LLConversationItemParticipant* participant_model = dynamic_cast<LLConversationItemParticipant*>(*current_participant_model); -			// Get the avatar name for this participant id from the cache and update the model -			participant_model->updateName(); +            if (participant_model) +            { +                // Get the avatar name for this participant id from the cache and update the model +                participant_model->updateName(); +            }  			// Next participant  			current_participant_model++;  		} @@ -464,8 +479,11 @@ void LLFloaterIMContainer::idleUpdate()                  while (current_participant_model != end_participant_model)                  {                      LLConversationItemParticipant* participant_model = dynamic_cast<LLConversationItemParticipant*>(*current_participant_model); -                    participant_model->setModeratorOptionsVisible(is_moderator); -                    participant_model->setGroupBanVisible(can_ban && participant_model->getUUID() != gAgentID); +                    if (participant_model) +                    { +                        participant_model->setModeratorOptionsVisible(is_moderator); +                        participant_model->setGroupBanVisible(can_ban && participant_model->getUUID() != gAgentID); +                    }                      current_participant_model++;                  } @@ -498,20 +516,49 @@ void LLFloaterIMContainer::idleUpdate()  void LLFloaterIMContainer::idleProcessEvents()  { -	if (!mConversationEventQueue.empty()) -	{ -		S32 events_to_handle = llmin((S32)mConversationEventQueue.size(), EVENTS_PER_IDLE_LOOP); -		for (S32 i = 0; i < events_to_handle; i++) -		{ -			handleConversationModelEvent(mConversationEventQueue.back()); -			mConversationEventQueue.pop_back(); -		} -	} +    LLUUID current_session_id = getSelectedSession(); +    conversations_items_deque::iterator iter = mConversationEventQueue.begin(); +    conversations_items_deque::iterator end = mConversationEventQueue.end(); +    while (iter != end) +    { +        std::deque<LLSD> &events = iter->second; +        if (!events.empty()) +        { +            S32 events_to_handle; +            S32 query_size = (S32)events.size(); +            if (current_session_id == iter->first) +            { +                events_to_handle = EVENTS_PER_IDLE_LOOP_CURRENT_SESSION; +            } +            else +            { +                events_to_handle = EVENTS_PER_IDLE_LOOP_BACKGROUND; +            } + +            if (events_to_handle <= query_size) +            { +                // Some groups can be very large and can generate huge amount of updates, scale processing up to keep up +                events_to_handle = llmax(events_to_handle, (S32)(query_size * EVENTS_PER_IDLE_LOOP_MIN_PERCENTAGE)); +            } +            else +            { +                events_to_handle = query_size; +            } + +            for (S32 i = 0; i < events_to_handle; i++) +            { +                handleConversationModelEvent(events.back()); +                events.pop_back(); +            } +        } +        iter++; +    }  }  bool LLFloaterIMContainer::onConversationModelEvent(const LLSD& event)  { -	mConversationEventQueue.push_front(event); +	LLUUID id = event.get("session_uuid").asUUID(); +	mConversationEventQueue[id].push_front(event);  	return true;  } @@ -1816,12 +1863,16 @@ bool LLFloaterIMContainer::removeConversationListItem(const LLUUID& uuid, bool c  		{  			new_selection = mConversationsRoot->getPreviousFromChild(widget, FALSE);  		} + +		// Will destroy views and delete models that are not assigned to any views  		widget->destroyView();  	}  	// Suppress the conversation items and widgets from their respective maps  	mConversationsItems.erase(uuid);  	mConversationsWidgets.erase(uuid); +	// Clear event query (otherwise reopening session in some way can bombard session with stale data) +	mConversationEventQueue.erase(uuid);  	// Don't let the focus fall IW, select and refocus on the first conversation in the list  	if (change_focus) diff --git a/indra/newview/llfloaterimcontainer.h b/indra/newview/llfloaterimcontainer.h index 468b47f1f1..b4a9d377ab 100644 --- a/indra/newview/llfloaterimcontainer.h +++ b/indra/newview/llfloaterimcontainer.h @@ -229,9 +229,10 @@ private:  	conversations_widgets_map mConversationsWidgets;  	LLConversationViewModel mConversationViewModel;  	LLFolderView* mConversationsRoot; -	LLEventStream mConversationsEventStream;  +	LLEventStream mConversationsEventStream; -	std::deque<LLSD> mConversationEventQueue; +	typedef std::map<LLUUID, std::deque<LLSD> > conversations_items_deque; +	conversations_items_deque mConversationEventQueue;  	LLTimer mParticipantRefreshTimer;  }; diff --git a/indra/newview/llfloaterimsessiontab.cpp b/indra/newview/llfloaterimsessiontab.cpp index d604d0a789..7541bb5efe 100644 --- a/indra/newview/llfloaterimsessiontab.cpp +++ b/indra/newview/llfloaterimsessiontab.cpp @@ -32,6 +32,8 @@  #include "llagent.h"  #include "llagentcamera.h"  #include "llavataractions.h" +#include "llavatariconctrl.h" +#include "llgroupiconctrl.h"  #include "llchatentry.h"  #include "llchathistory.h"  #include "llchiclet.h" @@ -45,6 +47,9 @@  #include "llfloaterimnearbychat.h"  const F32 REFRESH_INTERVAL = 1.0f; +const std::string ICN_GROUP("group_chat_icon"); +const std::string ICN_NEARBY("nearby_chat_icon"); +const std::string ICN_AVATAR("avatar_icon");  void cb_group_do_nothing()  { @@ -492,7 +497,10 @@ void LLFloaterIMSessionTab::buildConversationViewParticipant()  	while (current_participant_model != end_participant_model)  	{  		LLConversationItem* participant_model = dynamic_cast<LLConversationItem*>(*current_participant_model); -		addConversationViewParticipant(participant_model); +        if (participant_model) +        { +            addConversationViewParticipant(participant_model); +        }  		current_participant_model++;  	}  } @@ -529,8 +537,7 @@ void LLFloaterIMSessionTab::removeConversationViewParticipant(const LLUUID& part  	LLFolderViewItem* widget = get_ptr_in_map(mConversationsWidgets,participant_id);  	if (widget)  	{ -		mConversationsRoot->extractItem(widget); -		delete widget; +		widget->destroyView();  	}  	mConversationsWidgets.erase(participant_id);  } @@ -700,6 +707,39 @@ void LLFloaterIMSessionTab::updateSessionName(const std::string& name)  	mInputEditor->setLabel(LLTrans::getString("IM_to_label") + " " + name);  } +void LLFloaterIMSessionTab::updateChatIcon(const LLUUID& id) +{ +	if (mSession) +	{ +		if (mSession->isP2PSessionType()) +		{ +			LLAvatarIconCtrl* icon = getChild<LLAvatarIconCtrl>(ICN_AVATAR); +			icon->setVisible(true); +			icon->setValue(id); +		} +		if (mSession->isAdHocSessionType()) +		{ +			LLGroupIconCtrl* icon = getChild<LLGroupIconCtrl>(ICN_GROUP); +			icon->setVisible(true); +		} +		if (mSession->isGroupSessionType()) +		{ +			LLGroupIconCtrl* icon = getChild<LLGroupIconCtrl>(ICN_GROUP); +			icon->setVisible(true); +			icon->setValue(id); +		} +	} +	else +	{ +		if (mIsNearbyChat) +		{ +			LLIconCtrl* icon = getChild<LLIconCtrl>(ICN_NEARBY); +			icon->setVisible(true); +		} +	} + +} +  void LLFloaterIMSessionTab::hideAllStandardButtons()  {  	for (S32 i = 0; i < BUTTON_COUNT; i++) diff --git a/indra/newview/llfloaterimsessiontab.h b/indra/newview/llfloaterimsessiontab.h index 5357a14ab9..375461cfc1 100644 --- a/indra/newview/llfloaterimsessiontab.h +++ b/indra/newview/llfloaterimsessiontab.h @@ -103,6 +103,8 @@ public:  	void restoreFloater();  	void saveCollapsedState(); +	void updateChatIcon(const LLUUID& id); +  	LLView* getChatHistory();  protected: diff --git a/indra/newview/llfloatermarketplacelistings.cpp b/indra/newview/llfloatermarketplacelistings.cpp index 889d017389..524162ba51 100644 --- a/indra/newview/llfloatermarketplacelistings.cpp +++ b/indra/newview/llfloatermarketplacelistings.cpp @@ -103,14 +103,17 @@ void LLPanelMarketplaceListings::buildAllPanels()      panel = buildInventoryPanel("Active Items", "panel_marketplace_listings_listed.xml");  	panel->getFilter().setFilterMarketplaceActiveFolders();  	panel->getFilter().setEmptyLookupMessage("MarketplaceNoMatchingItems"); +	panel->getFilter().setDefaultEmptyLookupMessage("MarketplaceNoListing");  	panel->getFilter().markDefault();      panel = buildInventoryPanel("Inactive Items", "panel_marketplace_listings_unlisted.xml");  	panel->getFilter().setFilterMarketplaceInactiveFolders();  	panel->getFilter().setEmptyLookupMessage("MarketplaceNoMatchingItems"); +	panel->getFilter().setDefaultEmptyLookupMessage("MarketplaceNoListing");  	panel->getFilter().markDefault();      panel = buildInventoryPanel("Unassociated Items", "panel_marketplace_listings_unassociated.xml");  	panel->getFilter().setFilterMarketplaceUnassociatedFolders();  	panel->getFilter().setEmptyLookupMessage("MarketplaceNoMatchingItems"); +	panel->getFilter().setDefaultEmptyLookupMessage("MarketplaceNoListing");  	panel->getFilter().markDefault();      // Set the tab panel diff --git a/indra/newview/llfloatermodelpreview.cpp b/indra/newview/llfloatermodelpreview.cpp index b9c03f66a3..d9edd4dc30 100644 --- a/indra/newview/llfloatermodelpreview.cpp +++ b/indra/newview/llfloatermodelpreview.cpp @@ -103,6 +103,11 @@ LLMeshFilePicker::LLMeshFilePicker(LLModelPreview* mp, S32 lod)  void LLMeshFilePicker::notify(const std::vector<std::string>& filenames)  { +	if(LLAppViewer::instance()->quitRequested()) +	{ +		return; +	} +	  	if (filenames.size() > 0)  	{  		mMP->loadModel(filenames[0], mLOD); @@ -906,7 +911,7 @@ BOOL LLFloaterModelPreview::handleScrollWheel(S32 x, S32 y, S32 clicks)      {          LLFloaterModelUploadBase::handleScrollWheel(x, y, clicks);      } -    return TRUE; +	return TRUE;  }  /*virtual*/ @@ -1287,47 +1292,47 @@ void LLFloaterModelPreview::onMouseCaptureLostModelPreview(LLMouseHandler* handl  void LLFloaterModelPreview::addStringToLog(const std::string& message, const LLSD& args, bool flash, S32 lod)  {      if (sInstance && sInstance->hasString(message)) -    { +	{          std::string str;          switch (lod) -        { +{          case LLModel::LOD_IMPOSTOR: str = "LOD0 "; break;          case LLModel::LOD_LOW:      str = "LOD1 "; break;          case LLModel::LOD_MEDIUM:   str = "LOD2 "; break;          case LLModel::LOD_PHYSICS:  str = "PHYS "; break;          case LLModel::LOD_HIGH:     str = "LOD3 ";   break;          default: break; -        } -         +} +          LLStringUtil::format_map_t args_msg;          LLSD::map_const_iterator iter = args.beginMap();          LLSD::map_const_iterator end = args.endMap();          for (; iter != end; ++iter) -        { +{              args_msg[iter->first] = iter->second.asString(); -        } +		}		          str += sInstance->getString(message, args_msg);          sInstance->addStringToLogTab(str, flash); -    } -} +	} +	}  // static  void LLFloaterModelPreview::addStringToLog(const std::string& str, bool flash) -{ +	{      if (sInstance) -    { +		{          sInstance->addStringToLogTab(str, flash); -    } -} +				} +			}  // static  void LLFloaterModelPreview::addStringToLog(const std::ostringstream& strm, bool flash) -{ +			{      if (sInstance) -    { +            {          sInstance->addStringToLogTab(strm.str(), flash); -    } -} +            } +		}  void LLFloaterModelPreview::clearAvatarTab()  { @@ -1338,9 +1343,9 @@ void LLFloaterModelPreview::clearAvatarTab()      joints_pos->deleteAllItems();    mSelectedJointName.clear();      for (U32 i = 0; i < LLModel::NUM_LODS; ++i) -    { +{          mJointOverrides[i].clear(); -    } +	}      LLTextBox *joint_total_descr = panel->getChild<LLTextBox>("conflicts_description");      joint_total_descr->setTextArg("[CONFLICTS]", llformat("%d", 0)); @@ -1349,34 +1354,34 @@ void LLFloaterModelPreview::clearAvatarTab()      LLTextBox *joint_pos_descr = panel->getChild<LLTextBox>("pos_overrides_descr");      joint_pos_descr->setTextArg("[JOINT]", std::string("mPelvis")); // Might be better to hide it -} +			}  void LLFloaterModelPreview::updateAvatarTab(bool highlight_overrides) -{ +			{      S32 display_lod = mModelPreview->mPreviewLOD;      if (mModelPreview->mModel[display_lod].empty()) -    { +				{          mSelectedJointName.clear();          return; -    } +					}      // Joints will be listed as long as they are listed in mAlternateBindMatrix      // even if they are for some reason identical to defaults.      // Todo: Are overrides always identical for all lods? They normally are, but there might be situations where they aren't.      if (mJointOverrides[display_lod].empty()) -    { +					{          // populate map          for (LLModelLoader::scene::iterator iter = mModelPreview->mScene[display_lod].begin(); iter != mModelPreview->mScene[display_lod].end(); ++iter) -        { +					{              for (LLModelLoader::model_instance_list::iterator model_iter = iter->second.begin(); model_iter != iter->second.end(); ++model_iter) -            { +					{                  LLModelInstance& instance = *model_iter;                  LLModel* model = instance.mModel;                  const LLMeshSkinInfo *skin = &model->mSkinInfo;                  U32 joint_count = LLSkinningUtil::getMeshJointCount(skin);                  U32 bind_count = highlight_overrides ? skin->mAlternateBindMatrix.size() : 0; // simply do not include overrides if data is not needed                  if (bind_count > 0 && bind_count != joint_count) -                { +						{                      std::ostringstream out;                      out << "Invalid joint overrides for model " << model->getName();                      out << ". Amount of joints " << joint_count; @@ -1385,68 +1390,68 @@ void LLFloaterModelPreview::updateAvatarTab(bool highlight_overrides)                      addStringToLog(out.str(), true);                      // Disable overrides for this model                      bind_count = 0; -                } +						}                  if (bind_count > 0) -                { +						{                      for (U32 j = 0; j < joint_count; ++j) -                    { +							{                          const LLVector3& joint_pos = skin->mAlternateBindMatrix[j].getTranslation();                          LLJointOverrideData &data = mJointOverrides[display_lod][skin->mJointNames[j]];                          LLJoint* pJoint = LLModelPreview::lookupJointByName(skin->mJointNames[j], mModelPreview);                          if (pJoint) -                        { +							{                              // see how voavatar uses aboveJointPosThreshold                              if (pJoint->aboveJointPosThreshold(joint_pos)) -                            { +				{                                  // valid override                                  if (data.mPosOverrides.size() > 0                                      && (data.mPosOverrides.begin()->second - joint_pos).lengthSquared() > (LL_JOINT_TRESHOLD_POS_OFFSET * LL_JOINT_TRESHOLD_POS_OFFSET)) -                                { +					{                                      // File contains multiple meshes with conflicting joint offsets                                      // preview may be incorrect, upload result might wary (depends onto                                      // mesh_id that hasn't been generated yet).                                      data.mHasConflicts = true; -                                } +							}                                  data.mPosOverrides[model->getName()] = joint_pos; -                            } -                            else -                            { +						} +						else +						{                                  // default value, it won't be accounted for by avatar                                  data.mModelsNoOverrides.insert(model->getName()); -                            } -                        } -                    } -                } -                else -                { +					} +					} +				} +			} +			else +			{                      for (U32 j = 0; j < joint_count; ++j) -                    { +				{				                          LLJointOverrideData &data = mJointOverrides[display_lod][skin->mJointNames[j]];                          data.mModelsNoOverrides.insert(model->getName());                      }                  } -            } -        } -    } +			} +		} +	}      LLPanel *panel = mTabContainer->getPanelByName("rigging_panel");      LLScrollListCtrl *joints_list = panel->getChild<LLScrollListCtrl>("joints_list");      if (joints_list->isEmpty()) -    { +	{          // Populate table -        std::map<std::string, std::string> joint_alias_map; +    std::map<std::string, std::string> joint_alias_map;          mModelPreview->getJointAliases(joint_alias_map); - +              S32 conflicts = 0;          joint_override_data_map_t::iterator joint_iter = mJointOverrides[display_lod].begin();          joint_override_data_map_t::iterator joint_end = mJointOverrides[display_lod].end();          while (joint_iter != joint_end) -        { +	{              const std::string& listName = joint_iter->first; - +                      LLScrollListItem::Params item_params;              item_params.value(listName); @@ -1454,38 +1459,38 @@ void LLFloaterModelPreview::updateAvatarTab(bool highlight_overrides)              cell_params.font = LLFontGL::getFontSansSerif();              cell_params.value = listName;              if (joint_alias_map.find(listName) == joint_alias_map.end()) -            { +	{                  // Missing names                  cell_params.color = LLColor4::red; -            } +	}              if (joint_iter->second.mHasConflicts) -            { +	{                  // Conflicts                  cell_params.color = LLColor4::orange;                  conflicts++; -            } +	}              if (highlight_overrides && joint_iter->second.mPosOverrides.size() > 0) -            { +	{                  cell_params.font.style = "BOLD"; -            } +	}              item_params.columns.add(cell_params);              joints_list->addRow(item_params, ADD_BOTTOM);              joint_iter++; -        } +	}          joints_list->selectFirstItem();          LLScrollListItem *selected = joints_list->getFirstSelected();          if (selected) -        { +{              mSelectedJointName = selected->getValue().asString(); -        } +	}          LLTextBox *joint_conf_descr = panel->getChild<LLTextBox>("conflicts_description");          joint_conf_descr->setTextArg("[CONFLICTS]", llformat("%d", conflicts));          joint_conf_descr->setTextArg("[JOINTS_COUNT]", llformat("%d", mJointOverrides[display_lod].size())); -    } -} +		} +	}  //-----------------------------------------------------------------------------  // addStringToLogTab() @@ -1493,52 +1498,52 @@ void LLFloaterModelPreview::updateAvatarTab(bool highlight_overrides)  void LLFloaterModelPreview::addStringToLogTab(const std::string& str, bool flash)  {      if (str.empty()) -    { -        return; -    } +		{ +		return; +	}      LLWString text = utf8str_to_wstring(str);      S32 add_text_len = text.length() + 1; // newline      S32 editor_max_len = mUploadLogText->getMaxTextLength();      if (add_text_len > editor_max_len) -    { -        return; -    } +		{ +		return; +	}      // Make sure we have space for new string      S32 editor_text_len = mUploadLogText->getLength();      if (editor_max_len < (editor_text_len + add_text_len)          && mUploadLogText->getLineCount() <= 0) -    { +	{          mUploadLogText->getTextBoundingRect();// forces a reflow() to fix line count -    } +			}      while (editor_max_len < (editor_text_len + add_text_len)) -    { +		{          S32 shift = mUploadLogText->removeFirstLine();          if (shift > 0) -        { +	{              // removed a line              editor_text_len -= shift; -        } -        else -        { +} +	else +	{              //nothing to remove?              LL_WARNS() << "Failed to clear log lines" << LL_ENDL; -            break; -        } -    } +					break; +				} +			}      mUploadLogText->appendText(str, true);      if (flash) -    { +	{          LLPanel* panel = mTabContainer->getPanelByName("logs_panel");          if (mTabContainer->getCurrentPanel() != panel) -        { +		{              mTabContainer->setTabPanelFlashing(panel, true); -        } -    } -} +		} +	} +	}  void LLFloaterModelPreview::setDetails(F32 x, F32 y, F32 z, F32 streaming_cost, F32 physics_cost)  { @@ -1546,15 +1551,15 @@ void LLFloaterModelPreview::setDetails(F32 x, F32 y, F32 z, F32 streaming_cost,  	childSetTextArg("import_dimensions", "[X]", llformat("%.3f", x));  	childSetTextArg("import_dimensions", "[Y]", llformat("%.3f", y));  	childSetTextArg("import_dimensions", "[Z]", llformat("%.3f", z)); -} +		}  void LLFloaterModelPreview::setPreviewLOD(S32 lod) -{ +		{  	if (mModelPreview)  	{  		mModelPreview->setPreviewLOD(lod); -	} -} +								} +							}  void LLFloaterModelPreview::onBrowseLOD(S32 lod)  { @@ -1643,13 +1648,13 @@ void LLFloaterModelPreview::setCtrlLoadFromFile(S32 lod)          }      }      else -    { +{          LLComboBox* lod_combo = findChild<LLComboBox>("lod_source_" + lod_name[lod]);          if (lod_combo) -        { +	{              lod_combo->setCurrentByIndex(0); -        } -    } +	} +}  }  void LLFloaterModelPreview::setStatusMessage(const std::string& msg) diff --git a/indra/newview/llfloaterreporter.cpp b/indra/newview/llfloaterreporter.cpp index 7bfba2a6d7..a30c73768d 100644 --- a/indra/newview/llfloaterreporter.cpp +++ b/indra/newview/llfloaterreporter.cpp @@ -746,9 +746,6 @@ LLSD LLFloaterReporter::gatherReport()  	const char* platform = "Mac";  #elif LL_LINUX  	const char* platform = "Lnx"; -#elif LL_SOLARIS -	const char* platform = "Sol"; -	const char* short_platform = "O:S";  #else  	const char* platform = "???";  #endif diff --git a/indra/newview/llgroupactions.cpp b/indra/newview/llgroupactions.cpp index d2bd716f55..12d82d101f 100644 --- a/indra/newview/llgroupactions.cpp +++ b/indra/newview/llgroupactions.cpp @@ -39,6 +39,7 @@  #include "llfloaterimcontainer.h"  #include "llimview.h" // for gIMMgr  #include "llnotificationsutil.h" +#include "llstartup.h"  #include "llstatusbar.h"	// can_afford_transaction()  #include "groupchatlistener.h" @@ -55,6 +56,11 @@ public:  	bool handle(const LLSD& tokens, const LLSD& query_map,  				LLMediaCtrl* web)  	{ +		if (LLStartUp::getStartupState() < STATE_STARTED) +		{ +			return true; +		} +  		if (!LLUI::getInstance()->mSettingGroups["config"]->getBOOL("EnableGroupInfo"))  		{  			LLNotificationsUtil::add("NoGroupInfo", LLSD(), LLSD(), std::string("SwitchToStandardSkinAndQuit")); diff --git a/indra/newview/llimview.cpp b/indra/newview/llimview.cpp index 9afb6ca58b..1059324a16 100644 --- a/indra/newview/llimview.cpp +++ b/indra/newview/llimview.cpp @@ -969,6 +969,9 @@ void LLIMModel::LLIMSession::buildHistoryFileName()  			// Incoming P2P sessions include a name that we can use to build a history file name  			mHistoryFileName = LLCacheName::buildUsername(mName);  		} + +        // user's account name can change, but filenames and session names are account name based +        LLConversationLog::getInstance()->verifyFilename(mSessionID, mHistoryFileName, av_name.getCompleteName());  	}  	else if (isGroupChat())  	{ diff --git a/indra/newview/llinventoryfilter.cpp b/indra/newview/llinventoryfilter.cpp index 72013f7396..2a22eb1329 100644 --- a/indra/newview/llinventoryfilter.cpp +++ b/indra/newview/llinventoryfilter.cpp @@ -74,6 +74,7 @@ LLInventoryFilter::LLInventoryFilter(const Params& p)  :	mName(p.name),  	mFilterModified(FILTER_NONE),  	mEmptyLookupMessage("InventoryNoMatchingItems"), +	mDefaultEmptyLookupMessage(""),  	mFilterOps(p.filter_ops),  	mBackupFilterOps(mFilterOps),  	mFilterSubString(p.substring), @@ -1441,12 +1442,24 @@ void LLInventoryFilter::setEmptyLookupMessage(const std::string& message)  	mEmptyLookupMessage = message;  } +void LLInventoryFilter::setDefaultEmptyLookupMessage(const std::string& message) +{ +	mDefaultEmptyLookupMessage = message; +} +  std::string LLInventoryFilter::getEmptyLookupMessage() const  { -	LLStringUtil::format_map_t args; -	args["[SEARCH_TERM]"] = LLURI::escape(getFilterSubStringOrig()); +	if (isDefault() && !mDefaultEmptyLookupMessage.empty()) +	{ +		return LLTrans::getString(mDefaultEmptyLookupMessage); +	} +	else +	{ +		LLStringUtil::format_map_t args; +		args["[SEARCH_TERM]"] = LLURI::escape(getFilterSubStringOrig()); -	return LLTrans::getString(mEmptyLookupMessage, args); +		return LLTrans::getString(mEmptyLookupMessage, args); +	}  } diff --git a/indra/newview/llinventoryfilter.h b/indra/newview/llinventoryfilter.h index be02ee3623..61cc5ae602 100644 --- a/indra/newview/llinventoryfilter.h +++ b/indra/newview/llinventoryfilter.h @@ -257,6 +257,7 @@ public:  	EFilterCreatorType		getFilterCreatorType() const;  	void 				setEmptyLookupMessage(const std::string& message); +	void				setDefaultEmptyLookupMessage(const std::string& message);  	std::string			getEmptyLookupMessage() const;  	// +-------------------------------------------------------------------+ @@ -332,6 +333,7 @@ private:  	std::string 			mFilterText;  	std::string 			mEmptyLookupMessage; +	std::string				mDefaultEmptyLookupMessage;  	ESearchType 			mSearchType; diff --git a/indra/newview/lllandmarklist.cpp b/indra/newview/lllandmarklist.cpp index b4236c406b..543d2a087f 100644 --- a/indra/newview/lllandmarklist.cpp +++ b/indra/newview/lllandmarklist.cpp @@ -107,11 +107,13 @@ LLLandmark* LLLandmarkList::getAsset(const LLUUID& asset_uuid, loaded_callback_t              return NULL;          } +        mRequestedList[asset_uuid] = gFrameTimeSeconds; + +        // Note that getAssetData can callback immediately and cleans mRequestedList  		gAssetStorage->getAssetData(asset_uuid,  									LLAssetType::AT_LANDMARK,  									LLLandmarkList::processGetAssetReply,  									NULL); -		mRequestedList[asset_uuid] = gFrameTimeSeconds;  	}  	return NULL;  } @@ -194,11 +196,15 @@ void LLLandmarkList::processGetAssetReply(              landmark_uuid_list_t::iterator iter = gLandmarkList.mWaitList.begin();              LLUUID asset_uuid = *iter;              gLandmarkList.mWaitList.erase(iter); + +            // add to mRequestedList before calling getAssetData() +            gLandmarkList.mRequestedList[asset_uuid] = gFrameTimeSeconds; + +            // Note that getAssetData can callback immediately and cleans mRequestedList              gAssetStorage->getAssetData(asset_uuid,                  LLAssetType::AT_LANDMARK,                  LLLandmarkList::processGetAssetReply,                  NULL); -            gLandmarkList.mRequestedList[asset_uuid] = gFrameTimeSeconds;          }          scheduling = false;      } diff --git a/indra/newview/lllogchat.cpp b/indra/newview/lllogchat.cpp index 415781bc27..eebc2486a2 100644 --- a/indra/newview/lllogchat.cpp +++ b/indra/newview/lllogchat.cpp @@ -281,6 +281,28 @@ std::string LLLogChat::makeLogFileName(std::string filename)  	return filename;  } +//static +void LLLogChat::renameLogFile(const std::string& old_filename, const std::string& new_filename) +{ +    std::string new_name = cleanFileName(new_filename); +    std::string old_name = cleanFileName(old_filename); +    new_name = gDirUtilp->getExpandedFilename(LL_PATH_PER_ACCOUNT_CHAT_LOGS, new_name); +    old_name = gDirUtilp->getExpandedFilename(LL_PATH_PER_ACCOUNT_CHAT_LOGS, old_name); + +    if (new_name.empty() || old_name.empty()) +    { +        return; +    } + +    new_name += '.' + LL_TRANSCRIPT_FILE_EXTENSION; +    old_name += '.' + LL_TRANSCRIPT_FILE_EXTENSION; + +    if (!LLFile::isfile(new_name) && LLFile::isfile(old_name)) +    { +        LLFile::rename(old_name, new_name); +    } +} +  std::string LLLogChat::cleanFileName(std::string filename)  {  	std::string invalidChars = "\"\'\\/?*:.<>|[]{}~"; // Cannot match glob or illegal filename chars diff --git a/indra/newview/lllogchat.h b/indra/newview/lllogchat.h index 8b7fe14e16..c4b61ee716 100644 --- a/indra/newview/lllogchat.h +++ b/indra/newview/lllogchat.h @@ -94,6 +94,7 @@ public:  	static std::string timestamp(bool withdate = false);  	static std::string makeLogFileName(std::string(filename)); +	static void renameLogFile(const std::string& old_filename, const std::string& new_filename);  	/**  	*Add functions to get old and non date stamped file names when needed  	*/ diff --git a/indra/newview/lllogininstance.cpp b/indra/newview/lllogininstance.cpp index fa53a21940..e81d2cc082 100644 --- a/indra/newview/lllogininstance.cpp +++ b/indra/newview/lllogininstance.cpp @@ -58,6 +58,7 @@  #include "llevents.h"  #include "llappviewer.h"  #include "llsdserialize.h" +#include "lltrans.h"  #include <boost/scoped_ptr.hpp>  #include <sstream> @@ -332,7 +333,7 @@ void LLLoginInstance::handleLoginFailure(const LLSD& event)          {              data["certificate"] = response["certificate"];          } -         +          if (gViewerWindow)              gViewerWindow->setShowProgress(FALSE); @@ -349,13 +350,36 @@ void LLLoginInstance::handleLoginFailure(const LLSD& event)          // login.cgi is insisting on a required update. We were called with an          // event that bundles both the login.cgi 'response' and the          // synchronization event from the 'updater'. -        std::string required_version = response["message_args"]["VERSION"]; -        LL_WARNS("LLLogin") << "Login failed because an update to version " << required_version << " is required." << LL_ENDL; +        std::string login_version = response["message_args"]["VERSION"]; +        std::string vvm_version   = updater["VERSION"]; +        std::string relnotes      = updater["URL"]; +        LL_WARNS("LLLogin") << "Login failed because an update to version " << login_version << " is required." << LL_ENDL; +        // vvm_version might be empty because we might not have gotten +        // SLVersionChecker's LoginSync handshake. But if it IS populated, it +        // should (!) be the same as the version we got from login.cgi. +        if ((! vvm_version.empty()) && vvm_version != login_version) +        { +            LL_WARNS("LLLogin") << "VVM update version " << vvm_version +                                << " differs from login version " << login_version +                                << "; presenting VVM version to match release notes URL" +                                << LL_ENDL; +            login_version = vvm_version; +        } +        if (relnotes.empty() || relnotes.find("://") == std::string::npos) +        { +            relnotes = LLTrans::getString("RELEASE_NOTES_BASE_URL"); +            if (!LLStringUtil::endsWith(relnotes, "/")) +                relnotes += "/"; +            relnotes += LLURI::escape(login_version) + ".html"; +        }          if (gViewerWindow)              gViewerWindow->setShowProgress(FALSE); -        LLSD args(LLSDMap("VERSION", required_version)); +        LLSD args; +        args["VERSION"] = login_version; +        args["URL"] = relnotes; +          if (updater.isUndefined())          {              // If the updater failed to shake hands, better advise the user to diff --git a/indra/newview/llnotificationhandler.h b/indra/newview/llnotificationhandler.h index 52c5234137..ef4aced2c7 100644 --- a/indra/newview/llnotificationhandler.h +++ b/indra/newview/llnotificationhandler.h @@ -297,6 +297,7 @@ public:  	 * Writes notification message to IM  p2p session.  	 */  	static void logToIMP2P(const LLNotificationPtr& notification, bool to_file_only = false); +	static void logToIMP2P(const LLUUID& from_id, const std::string& message, bool to_file_only = false);  	/**  	 * Writes group notice notification message to IM  group session. diff --git a/indra/newview/llnotificationhandlerutil.cpp b/indra/newview/llnotificationhandlerutil.cpp index 9a3f1a853a..39a0b9b50e 100644 --- a/indra/newview/llnotificationhandlerutil.cpp +++ b/indra/newview/llnotificationhandlerutil.cpp @@ -123,15 +123,13 @@ void log_name_callback(const LLAvatarName& av_name, const std::string& from_name  }  // static -void LLHandlerUtil::logToIMP2P(const LLNotificationPtr& notification, bool to_file_only) +void LLHandlerUtil::logToIMP2P(const LLUUID& from_id, const std::string& message, bool to_file_only)  {  	if (!gCacheName)  	{  		return;  	} -	LLUUID from_id = notification->getPayload()["from_id"]; -  	if (from_id.isNull())  	{  		// Normal behavior for system generated messages, don't spam. @@ -141,15 +139,22 @@ void LLHandlerUtil::logToIMP2P(const LLNotificationPtr& notification, bool to_fi  	if(to_file_only)  	{ -		LLAvatarNameCache::get(from_id, boost::bind(&log_name_callback, _2, "", notification->getMessage(), LLUUID())); +		LLAvatarNameCache::get(from_id, boost::bind(&log_name_callback, _2, "", message, LLUUID()));  	}  	else  	{ -		LLAvatarNameCache::get(from_id, boost::bind(&log_name_callback, _2, INTERACTIVE_SYSTEM_FROM, notification->getMessage(), from_id)); +		LLAvatarNameCache::get(from_id, boost::bind(&log_name_callback, _2, INTERACTIVE_SYSTEM_FROM, message, from_id));  	}  }  // static +void LLHandlerUtil::logToIMP2P(const LLNotificationPtr& notification, bool to_file_only) +{ +	LLUUID from_id = notification->getPayload()["from_id"]; +	logToIMP2P(from_id, notification->getMessage(), to_file_only);	 +} + +// static  void LLHandlerUtil::logGroupNoticeToIMGroup(  		const LLNotificationPtr& notification)  { diff --git a/indra/newview/llnotificationofferhandler.cpp b/indra/newview/llnotificationofferhandler.cpp index 14d25d8158..a9678b1e93 100644 --- a/indra/newview/llnotificationofferhandler.cpp +++ b/indra/newview/llnotificationofferhandler.cpp @@ -37,6 +37,8 @@  #include "llimview.h"  #include "llnotificationsutil.h" +#include <boost/regex.hpp> +  using namespace LLNotificationsUI;  //-------------------------------------------------------------------------- @@ -143,7 +145,19 @@ bool LLOfferHandler::processNotification(const LLNotificationPtr& notification)  		{  			// log only to file if notif panel can be embedded to IM and IM is opened  			bool file_only = add_notif_to_im && LLHandlerUtil::isIMFloaterOpened(notification); -			LLHandlerUtil::logToIMP2P(notification, file_only); +			if ((notification->getName() == "TeleportOffered" +				|| notification->getName() == "TeleportOffered_MaturityExceeded" +				|| notification->getName() == "TeleportOffered_MaturityBlocked")) +			{ +				boost::regex r("<icon\\s*>\\s*([^<]*)?\\s*</icon\\s*>( - )?", +					boost::regex::perl|boost::regex::icase); +				std::string stripped_msg = boost::regex_replace(notification->getMessage(), r, ""); +				LLHandlerUtil::logToIMP2P(notification->getPayload()["from_id"], stripped_msg,file_only); +			} +			else +			{ +				LLHandlerUtil::logToIMP2P(notification, file_only); +			}  		}  	} diff --git a/indra/newview/llpaneleditsky.h b/indra/newview/llpaneleditsky.h index c02c9c95a0..801fb8b9b2 100644 --- a/indra/newview/llpaneleditsky.h +++ b/indra/newview/llpaneleditsky.h @@ -29,7 +29,7 @@  #include "llpanel.h"  #include "llsettingssky.h" -#include "llfloaterfixedenvironment.h" +#include "llfloatereditenvironmentbase.h"  //=========================================================================  class LLSlider; diff --git a/indra/newview/llpaneleditwater.h b/indra/newview/llpaneleditwater.h index ab2dc47bcc..4b7ec903c9 100644 --- a/indra/newview/llpaneleditwater.h +++ b/indra/newview/llpaneleditwater.h @@ -30,7 +30,7 @@  #include "llpanel.h"  #include "llsettingswater.h" -#include "llfloaterfixedenvironment.h" +#include "llfloatereditenvironmentbase.h"  //=========================================================================  class LLSlider; diff --git a/indra/newview/llpanellogin.cpp b/indra/newview/llpanellogin.cpp index 4f60703488..3964dc075c 100644 --- a/indra/newview/llpanellogin.cpp +++ b/indra/newview/llpanellogin.cpp @@ -545,6 +545,16 @@ void LLPanelLogin::show(const LLRect &rect,  }  //static +void LLPanelLogin::reshapePanel() +{ +    if (sInstance) +    { +        LLRect rect = sInstance->getRect(); +        sInstance->reshape(rect.getWidth(), rect.getHeight()); +    } +} + +//static  void LLPanelLogin::populateFields(LLPointer<LLCredential> credential, bool remember_user, bool remember_psswrd)  {      if (!sInstance) diff --git a/indra/newview/llpanellogin.h b/indra/newview/llpanellogin.h index c9b8e1b6fc..788c269ffd 100644 --- a/indra/newview/llpanellogin.h +++ b/indra/newview/llpanellogin.h @@ -54,6 +54,7 @@ public:  	static void show(const LLRect &rect,  		void (*callback)(S32 option, void* user_data),   		void* callback_data); +	static void reshapePanel();  	static void populateFields(LLPointer<LLCredential> credential, bool remember_user, bool remember_psswrd);  	static void resetFields(); diff --git a/indra/newview/llpanelpicks.cpp b/indra/newview/llpanelpicks.cpp index c39df3fe8b..4762e15d8f 100644 --- a/indra/newview/llpanelpicks.cpp +++ b/indra/newview/llpanelpicks.cpp @@ -37,6 +37,7 @@  #include "llfloatersidepanelcontainer.h"  #include "llfloaterworldmap.h"  #include "llnotificationsutil.h" +#include "llstartup.h"  #include "lltexturectrl.h"  #include "lltoggleablemenu.h"  #include "lltrans.h" @@ -84,6 +85,11 @@ public:  	bool handle(const LLSD& params, const LLSD& query_map,  		LLMediaCtrl* web)  	{ +		if (LLStartUp::getStartupState() < STATE_STARTED) +		{ +			return true; +		} +  		if (!LLUI::getInstance()->mSettingGroups["config"]->getBOOL("EnablePicks"))  		{  			LLNotificationsUtil::add("NoPicks", LLSD(), LLSD(), std::string("SwitchToStandardSkinAndQuit")); @@ -198,6 +204,11 @@ public:  	bool handle(const LLSD& params, const LLSD& query_map, LLMediaCtrl* web)  	{ +		if (LLStartUp::getStartupState() < STATE_STARTED) +		{ +			return true; +		} +  		if (!LLUI::getInstance()->mSettingGroups["config"]->getBOOL("EnableClassifieds"))  		{  			LLNotificationsUtil::add("NoClassifieds", LLSD(), LLSD(), std::string("SwitchToStandardSkinAndQuit")); diff --git a/indra/newview/llpanelprimmediacontrols.cpp b/indra/newview/llpanelprimmediacontrols.cpp index 2bd78f40ba..c42cd6c6ba 100644 --- a/indra/newview/llpanelprimmediacontrols.cpp +++ b/indra/newview/llpanelprimmediacontrols.cpp @@ -74,6 +74,8 @@ const LLPanelPrimMediaControls::EZoomLevel LLPanelPrimMediaControls::kZoomLevels  const int LLPanelPrimMediaControls::kNumZoomLevels = 2;  const F32 EXCEEDING_ZOOM_DISTANCE = 0.5f; +const S32 ADDR_LEFT_PAD = 3; +  //  // LLPanelPrimMediaControls  // @@ -156,7 +158,7 @@ BOOL LLPanelPrimMediaControls::postBuild()  	mMediaProgressPanel		= getChild<LLPanel>("media_progress_indicator");  	mMediaProgressBar		= getChild<LLProgressBar>("media_progress_bar");  	mMediaAddressCtrl		= getChild<LLUICtrl>("media_address"); -	mMediaAddress			= getChild<LLUICtrl>("media_address_url"); +	mMediaAddress			= getChild<LLLineEditor>("media_address_url");  	mMediaPlaySliderPanel	= getChild<LLUICtrl>("media_play_position");  	mMediaPlaySliderCtrl	= getChild<LLUICtrl>("media_play_slider");  	mSkipFwdCtrl			= getChild<LLUICtrl>("skip_forward"); @@ -501,8 +503,10 @@ void LLPanelPrimMediaControls::updateShape()  			std::string test_prefix = mCurrentURL.substr(0, prefix.length());  			LLStringUtil::toLower(test_prefix);              mSecureURL = has_focus && (test_prefix == prefix); -            mCurrentURL = (mSecureURL ? "      " + mCurrentURL : mCurrentURL); -			 + +			S32 left_pad = mSecureURL ? mSecureLockIcon->getRect().getWidth() : ADDR_LEFT_PAD; +			mMediaAddress->setTextPadding(left_pad, 0); +  			if(mCurrentURL!=mPreviousURL)  			{  				setCurrentURL(); diff --git a/indra/newview/llpanelprimmediacontrols.h b/indra/newview/llpanelprimmediacontrols.h index 86fc036553..dd0e4ff095 100644 --- a/indra/newview/llpanelprimmediacontrols.h +++ b/indra/newview/llpanelprimmediacontrols.h @@ -39,6 +39,7 @@ class LLProgressBar;  class LLSliderCtrl;  class LLViewerMediaImpl;  class LLWindowShade; +class LLLineEditor;  class LLPanelPrimMediaControls : public LLPanel  { @@ -164,7 +165,7 @@ private:  	LLPanel  *mMediaProgressPanel;  	LLProgressBar *mMediaProgressBar;  	LLUICtrl *mMediaAddressCtrl; -	LLUICtrl *mMediaAddress; +	LLLineEditor *mMediaAddress;  	LLUICtrl *mMediaPlaySliderPanel;  	LLUICtrl *mMediaPlaySliderCtrl;  	LLUICtrl *mVolumeCtrl; diff --git a/indra/newview/llparticipantlist.cpp b/indra/newview/llparticipantlist.cpp index ee6893907e..94d20828ec 100644 --- a/indra/newview/llparticipantlist.cpp +++ b/indra/newview/llparticipantlist.cpp @@ -259,11 +259,7 @@ LLParticipantList::~LLParticipantList()  */  void LLParticipantList::onAvalineCallerFound(const LLUUID& participant_id)  { -	LLConversationItemParticipant* participant = findParticipant(participant_id); -	if (participant) -	{ -		removeParticipant(participant); -	} +	removeParticipant(participant_id);  	// re-add avaline caller with a correct class instance.  	addAvatarIDExceptAgent(participant_id);  } @@ -397,6 +393,7 @@ void LLParticipantList::addAvatarIDExceptAgent(const LLUUID& avatar_id)  	// Hack for this: LLAvatarTracker::instance().isBuddyOnline(avatar_id))  	// Add the participant model to the session's children list +	// This will post "add_participant" event  	addParticipant(participant);  	adjustParticipant(avatar_id); diff --git a/indra/newview/llpreviewscript.cpp b/indra/newview/llpreviewscript.cpp index 5e81fa6402..4c539ded38 100644 --- a/indra/newview/llpreviewscript.cpp +++ b/indra/newview/llpreviewscript.cpp @@ -733,7 +733,10 @@ void LLScriptEdCore::updateDynamicHelp(BOOL immediate)  		}  		if (immediate || (mLiveHelpTimer.getStarted() && mLiveHelpTimer.getElapsedTimeF32() > LIVE_HELP_REFRESH_TIME))  		{ -			std::string help_string = mEditor->getText().substr(segment->getStart(), segment->getEnd() - segment->getStart()); +			// Use Wtext since segment's start/end are made for wstring and will +			// result in a shift for case of multi-byte symbols inside std::string. +			LLWString segment_text = mEditor->getWText().substr(segment->getStart(), segment->getEnd() - segment->getStart()); +			std::string help_string = wstring_to_utf8str(segment_text);  			setHelpPage(help_string);  			mLiveHelpTimer.stop();  		} diff --git a/indra/newview/llscenemonitor.cpp b/indra/newview/llscenemonitor.cpp index 3c9ce6b752..f9baf5fbd3 100644 --- a/indra/newview/llscenemonitor.cpp +++ b/indra/newview/llscenemonitor.cpp @@ -530,157 +530,163 @@ void LLSceneMonitor::dumpToFile(std::string file_name)  	if (!hasResults()) return;  	LL_INFOS("SceneMonitor") << "Saving scene load stats to " << file_name << LL_ENDL;  - -	llofstream os(file_name.c_str()); - -	os << std::setprecision(10); - -	LLTrace::PeriodicRecording& scene_load_recording = mSceneLoadRecording.getResults(); -	const U32 frame_count = scene_load_recording.getNumRecordedPeriods(); - -	F64Seconds frame_time; - -	os << "Stat"; -	for (S32 frame = 1; frame <= frame_count; frame++) +	try  	{ -		frame_time += scene_load_recording.getPrevRecording(frame_count - frame).getDuration(); -		os << ", " << frame_time.value(); -	} -	os << '\n'; +		llofstream os(file_name.c_str()); -	os << "Sample period(s)"; -	for (S32 frame = 1; frame <= frame_count; frame++) -	{ -		frame_time = scene_load_recording.getPrevRecording(frame_count - frame).getDuration(); -		os << ", " << frame_time.value(); -	} -	os << '\n'; +		os << std::setprecision(10); +		LLTrace::PeriodicRecording& scene_load_recording = mSceneLoadRecording.getResults(); +		const U32 frame_count = scene_load_recording.getNumRecordedPeriods(); -	typedef LLTrace::StatType<LLTrace::CountAccumulator> trace_count; -	for (auto& it : trace_count::instance_snapshot()) -	{ -		std::ostringstream row; -		row << std::setprecision(10); +		F64Seconds frame_time; -		row << it.getName(); - -		const char* unit_label = it.getUnitLabel(); -		if(unit_label[0]) +		os << "Stat"; +		for (S32 frame = 1; frame <= frame_count; frame++)  		{ -			row << "(" << unit_label << ")"; +			frame_time += scene_load_recording.getPrevRecording(frame_count - frame).getDuration(); +			os << ", " << frame_time.value();  		} +		os << '\n'; -		S32 samples = 0; - +		os << "Sample period(s)";  		for (S32 frame = 1; frame <= frame_count; frame++)  		{ -			LLTrace::Recording& recording = scene_load_recording.getPrevRecording(frame_count - frame); -			samples += recording.getSampleCount(it); -			row << ", " << recording.getSum(it); +			frame_time = scene_load_recording.getPrevRecording(frame_count - frame).getDuration(); +			os << ", " << frame_time.value();  		} +		os << '\n'; -		row << '\n'; -		if (samples > 0) +		typedef LLTrace::StatType<LLTrace::CountAccumulator> trace_count; +		for (auto& it : trace_count::instance_snapshot())  		{ -			os << row.str(); -		} -	} - -	typedef LLTrace::StatType<LLTrace::EventAccumulator> trace_event; +			std::ostringstream row; +			row << std::setprecision(10); -	for (auto& it : trace_event::instance_snapshot()) -	{ -		std::ostringstream row; -		row << std::setprecision(10); -		row << it.getName(); +			row << it.getName(); -		const char* unit_label = it.getUnitLabel(); -		if(unit_label[0]) -		{ -			row << "(" << unit_label << ")"; -		} +			const char* unit_label = it.getUnitLabel(); +			if (unit_label[0]) +			{ +				row << "(" << unit_label << ")"; +			} -		S32 samples = 0; +			S32 samples = 0; -		for (S32 frame = 1; frame <= frame_count; frame++) -		{ -			LLTrace::Recording& recording = scene_load_recording.getPrevRecording(frame_count - frame); -			samples += recording.getSampleCount(it); -			F64 mean = recording.getMean(it); -			if (llisnan(mean)) +			for (S32 frame = 1; frame <= frame_count; frame++)  			{ -				row << ", n/a"; +				LLTrace::Recording& recording = scene_load_recording.getPrevRecording(frame_count - frame); +				samples += recording.getSampleCount(it); +				row << ", " << recording.getSum(it);  			} -			else + +			row << '\n'; + +			if (samples > 0)  			{ -				row << ", " << mean; +				os << row.str();  			}  		} -		row << '\n'; +		typedef LLTrace::StatType<LLTrace::EventAccumulator> trace_event; -		if (samples > 0) +		for (auto& it : trace_event::instance_snapshot())  		{ -			os << row.str(); -		} -	} +			std::ostringstream row; +			row << std::setprecision(10); +			row << it.getName(); -	typedef LLTrace::StatType<LLTrace::SampleAccumulator> trace_sample; +			const char* unit_label = it.getUnitLabel(); +			if (unit_label[0]) +			{ +				row << "(" << unit_label << ")"; +			} -	for (auto& it : trace_sample::instance_snapshot()) -	{ -		std::ostringstream row; -		row << std::setprecision(10); -		row << it.getName(); +			S32 samples = 0; -		const char* unit_label = it.getUnitLabel(); -		if(unit_label[0]) -		{ -			row << "(" << unit_label << ")"; +			for (S32 frame = 1; frame <= frame_count; frame++) +			{ +				LLTrace::Recording& recording = scene_load_recording.getPrevRecording(frame_count - frame); +				samples += recording.getSampleCount(it); +				F64 mean = recording.getMean(it); +				if (llisnan(mean)) +				{ +					row << ", n/a"; +				} +				else +				{ +					row << ", " << mean; +				} +			} + +			row << '\n'; + +			if (samples > 0) +			{ +				os << row.str(); +			}  		} -		S32 samples = 0; +		typedef LLTrace::StatType<LLTrace::SampleAccumulator> trace_sample; -		for (S32 frame = 1; frame <= frame_count; frame++) +		for (auto& it : trace_sample::instance_snapshot())  		{ -			LLTrace::Recording& recording = scene_load_recording.getPrevRecording(frame_count - frame); -			samples += recording.getSampleCount(it); -			F64 mean = recording.getMean(it); -			if (llisnan(mean)) +			std::ostringstream row; +			row << std::setprecision(10); +			row << it.getName(); + +			const char* unit_label = it.getUnitLabel(); +			if (unit_label[0]) +			{ +				row << "(" << unit_label << ")"; +			} + +			S32 samples = 0; + +			for (S32 frame = 1; frame <= frame_count; frame++)  			{ -				row << ", n/a"; +				LLTrace::Recording& recording = scene_load_recording.getPrevRecording(frame_count - frame); +				samples += recording.getSampleCount(it); +				F64 mean = recording.getMean(it); +				if (llisnan(mean)) +				{ +					row << ", n/a"; +				} +				else +				{ +					row << ", " << mean; +				}  			} -			else + +			row << '\n'; + +			if (samples > 0)  			{ -				row << ", " << mean; +				os << row.str();  			}  		} -		row << '\n';  - -		if (samples > 0) +		typedef LLTrace::StatType<LLTrace::MemAccumulator> trace_mem; +		for (auto& it : trace_mem::instance_snapshot())  		{ -			os << row.str(); -		} -	} +			os << it.getName() << "(KiB)"; -	typedef LLTrace::StatType<LLTrace::MemAccumulator> trace_mem; -	for (auto& it : trace_mem::instance_snapshot()) -	{ -		os << it.getName() << "(KiB)"; +			for (S32 frame = 1; frame <= frame_count; frame++) +			{ +				os << ", " << scene_load_recording.getPrevRecording(frame_count - frame).getMax(it).valueInUnits<LLUnits::Kilobytes>(); +			} -		for (S32 frame = 1; frame <= frame_count; frame++) -		{ -			os << ", " << scene_load_recording.getPrevRecording(frame_count - frame).getMax(it).valueInUnits<LLUnits::Kilobytes>(); +			os << '\n';  		} -		os << '\n'; +		os.flush(); +		os.close(); +	} +	catch (const std::ios_base::failure &e) +	{ +		LL_WARNS() << "Unable to dump scene monitor results: " << e.what() << LL_ENDL;  	} - -	os.flush(); -	os.close();  }  //------------------------------------------------------------------------------------------------------------- diff --git a/indra/newview/llspatialpartition.cpp b/indra/newview/llspatialpartition.cpp index 2cb27d85bc..efa4a7fd66 100644 --- a/indra/newview/llspatialpartition.cpp +++ b/indra/newview/llspatialpartition.cpp @@ -2253,52 +2253,91 @@ void renderBoundingBox(LLDrawable* drawable, BOOL set_color = TRUE)  	}  } -void renderNormals(LLDrawable* drawablep) +void renderNormals(LLDrawable *drawablep)  { -	LLVertexBuffer::unbind(); +    if (!drawablep->isVisible()) +        return; -	LLVOVolume* vol = drawablep->getVOVolume(); -	if (vol) -	{ -		LLVolume* volume = vol->getVolume(); -		gGL.pushMatrix(); -		gGL.multMatrix((F32*) vol->getRelativeXform().mMatrix); -		 -		gGL.getTexUnit(0)->unbind(LLTexUnit::TT_TEXTURE); +    LLVertexBuffer::unbind(); -		LLVector4a scale(gSavedSettings.getF32("RenderDebugNormalScale")); +    LLVOVolume *vol = drawablep->getVOVolume(); -		for (S32 i = 0; i < volume->getNumVolumeFaces(); ++i) -		{ -			const LLVolumeFace& face = volume->getVolumeFace(i); +    if (vol) +    { +        LLVolume *volume = vol->getVolume(); -			for (S32 j = 0; j < face.mNumVertices; ++j) -			{ -				gGL.begin(LLRender::LINES); -				LLVector4a n,p; -				 -				n.setMul(face.mNormals[j], scale); -				p.setAdd(face.mPositions[j], n); -				 -				gGL.diffuseColor4f(1,1,1,1); -				gGL.vertex3fv(face.mPositions[j].getF32ptr()); -				gGL.vertex3fv(p.getF32ptr()); -				 -				if (face.mTangents) -				{ -					n.setMul(face.mTangents[j], scale); -					p.setAdd(face.mPositions[j], n); -				 -					gGL.diffuseColor4f(0,1,1,1); -					gGL.vertex3fv(face.mPositions[j].getF32ptr()); -					gGL.vertex3fv(p.getF32ptr()); -				}	 -				gGL.end(); -			} -		} +        // Drawable's normals & tangents are stored in model space, i.e. before any scaling is applied. +        // +        // SL-13490, using pos + normal to compute the 2nd vertex of a normal line segment doesn't +        // work when there's a non-uniform scale in the mix. Normals require MVP-inverse-transpose +        // transform. We get that effect here by pre-applying the inverse scale (twice, because +        // one forward scale will be re-applied via the MVP in the vertex shader) -		gGL.popMatrix(); -	} +        LLVector3  scale_v3 = vol->getScale(); +        float      scale_len = scale_v3.length(); +        LLVector4a obj_scale(scale_v3.mV[VX], scale_v3.mV[VY], scale_v3.mV[VZ]); +        obj_scale.normalize3(); + +        // Normals &tangent line segments get scaled along with the object. Divide by scale length +        // to keep the as-viewed lengths (relatively) constant with the debug setting length +        float draw_length = gSavedSettings.getF32("RenderDebugNormalScale") / scale_len; + +        // Create inverse-scale vector for normals +        LLVector4a inv_scale(1.0 / scale_v3.mV[VX], 1.0 / scale_v3.mV[VY], 1.0 / scale_v3.mV[VZ]); +        inv_scale.mul(inv_scale);  // Squared, to apply inverse scale twice +        inv_scale.normalize3fast(); + +        gGL.pushMatrix(); +        gGL.multMatrix((F32 *) vol->getRelativeXform().mMatrix); + +        gGL.getTexUnit(0)->unbind(LLTexUnit::TT_TEXTURE); + +        for (S32 i = 0; i < volume->getNumVolumeFaces(); ++i) +        { +            const LLVolumeFace &face = volume->getVolumeFace(i); + +            gGL.flush(); +            gGL.diffuseColor4f(1, 1, 0, 1); +            gGL.begin(LLRender::LINES); +            for (S32 j = 0; j < face.mNumVertices; ++j) +            { +                LLVector4a n, p; + +                n.setMul(face.mNormals[j], 1.0); +                n.mul(inv_scale);  // Pre-scale normal, so it's left with an inverse-transpose xform after MVP +                n.normalize3fast(); +                n.mul(draw_length); +                p.setAdd(face.mPositions[j], n); + +                gGL.vertex3fv(face.mPositions[j].getF32ptr()); +                gGL.vertex3fv(p.getF32ptr()); +            } +            gGL.end(); + +            // Tangents are simple vectors and do not require reorientation via pre-scaling +            if (face.mTangents) +            { +                gGL.flush(); +                gGL.diffuseColor4f(0, 1, 1, 1); +                gGL.begin(LLRender::LINES); +                for (S32 j = 0; j < face.mNumVertices; ++j) +                { +                    LLVector4a t, p; + +                    t.setMul(face.mTangents[j], 1.0f); +                    t.normalize3fast(); +                    t.mul(draw_length); +                    p.setAdd(face.mPositions[j], t); + +                    gGL.vertex3fv(face.mPositions[j].getF32ptr()); +                    gGL.vertex3fv(p.getF32ptr()); +                } +                gGL.end(); +            } +        } + +        gGL.popMatrix(); +    }  }  S32 get_physics_detail(const LLVolumeParams& volume_params, const LLVector3& scale) diff --git a/indra/newview/llstartup.cpp b/indra/newview/llstartup.cpp index e2a39bdf86..3fb79e4739 100644 --- a/indra/newview/llstartup.cpp +++ b/indra/newview/llstartup.cpp @@ -176,6 +176,7 @@  #include "pipeline.h"  #include "llappviewer.h"  #include "llfasttimerview.h" +#include "lltelemetry.h"  #include "llfloatermap.h"  #include "llweb.h"  #include "llvoiceclient.h" @@ -527,6 +528,8 @@ bool idle_startup()  			}  			#if LL_WINDOWS +                LLPROFILE_STARTUP(); +  				// On the windows dev builds, unpackaged, the message.xml file will   				// be located in indra/build-vc**/newview/<config>/app_settings.  				std::string message_path = gDirUtilp->getExpandedFilename(LL_PATH_APP_SETTINGS,"message.xml"); @@ -3540,11 +3543,6 @@ bool process_login_success_response()  	}  	// Request the map server url -	// Non-agni grids have a different default location. -	if (!LLGridManager::getInstance()->isInProductionGrid()) -	{ -		gSavedSettings.setString("MapServerURL", "http://test.map.secondlife.com.s3.amazonaws.com/"); -	}  	std::string map_server_url = response["map-server-url"];  	if(!map_server_url.empty())  	{ diff --git a/indra/newview/lltelemetry.cpp b/indra/newview/lltelemetry.cpp new file mode 100644 index 0000000000..0c63e2fede --- /dev/null +++ b/indra/newview/lltelemetry.cpp @@ -0,0 +1,145 @@ + /** + * @file lltelemetry.cpp + * @brief Wrapper for Rad Game Tools Telemetry + * + * $LicenseInfo:firstyear=2020&license=viewerlgpl$ + * Second Life Viewer Source Code + * Copyright (C) 2020, Linden Research, Inc. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License only. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA + * + * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA + * $/LicenseInfo$ + */ + +#include "llviewerprecompiledheaders.h" + +#include "lltelemetry.h" + +#if LLPROFILE_USE_RAD_TELEMETRY_PROFILER +    #if LL_WINDOWS +        #include "llwin32headers.h" + +        // build-vc120-64\packages\lib\release +        // build-vc150-64\packages\lib\release +        #ifdef _MSC_VER +            #pragma comment(lib,"rad_tm_win64.lib") +        #else +            #pragma message "NOTE: Rad GameTools Telemetry requested but non-MSVC compiler not yet supported on Windows" +        #endif +    #endif // LL_WINDOWS + +    #if LL_DARWIN +        #pragma message "NOTE: Rad Game Tools Telemetry requested but not yet supported on Darwin" +    #endif + +    #if LL_LINUX +        #pragma message "NOTE: Rad Game Tools Telemetry requested but not yet supported on Linux" +    #endif + +// +// local consts +// +static const tm_int32 TELEMETRY_BUFFER_SIZE  = 8 * 1024 * 1024; + +// +// local globals +// +static char *gTelemetryBufferPtr = NULL; // Telemetry + +static const char *tm_status[ TMERR_INIT_NETWORKING_FAILED + 1 ] = +{ +      "Telemetry pass: connected"                       // TM_OK +    , "Telemetry FAIL: disabled via #define NTELEMETRY" // TMERR_DISABLED +    , "Telemetry FAIL: invalid paramater"               // TMERR_INVALID_PARAM +    , "Telemetry FAIL: DLL not found"                   // TMERR_NULL_API +    , "Telemetry FAIL: out of resources"                // TMERR_OUT_OF_RESOURCES +    , "Telemetry FAIL: tmInitialize() not called"       // TMERR_UNINITIALIZED +    , "Telemetry FAIL: bad hostname"                    // TMERR_BAD_HOSTNAME +    , "Telemetry FAIL: couldn't connect to server"      // TMERR_COULD_NOT_CONNECT +    , "Telemetry FAIL: unknown network error"           // TMERR_UNKNOWN_NETWORK +    , "Telemetry FAIL: tmShutdown() already called"     // TMERR_ALREADY_SHUTDOWN +    , "Telemetry FAIL: memory buffer too small"         // TMERR_ARENA_TOO_SMALL +    , "Telemetry FAIL: server handshake error"          // TMERR_BAD_HANDSHAKE +    , "Telemetry FAIL: unaligned parameters"            // TMERR_UNALIGNED +    , "Telemetry FAIL: network not initialized"         // TMERR_NETWORK_NOT_INITIALIZED -- WSAStartup not called before tmOpen() +    , "Telemetry FAIL: bad version"                     // TMERR_BAD_VERSION +    , "Telemetry FAIL: timer too large"                 // TMERR_BAD_TIMER +    , "Telemetry FAIL: tmOpen() already called"         // TMERR_ALREADY_OPENED +    , "Telemetry FAIL: tmInitialize() already called"   // TMERR_ALREADY_INITIALIZED +    , "Telemetry FAIL: could't open file"               // TMERR_FILE_OPEN_FAILED +    , "Telemetry FAIL: tmOpen() failed networking"      // TMERR_INIT_NETWORKING_FAILED +}; + +// +// exported functionality +// + +void telemetry_shutdown() +{ +    #if LL_WINDOWS +        if (gTelemetryBufferPtr) +        { +            tmClose(0); +            tmShutdown(); + +            delete[] gTelemetryBufferPtr; +            gTelemetryBufferPtr = NULL; +        } +    #endif +} + +void telemetry_startup() +{ +    #if LL_WINDOWS +        tmLoadLibrary(TM_RELEASE); // Loads .dll + +        gTelemetryBufferPtr = new char[ TELEMETRY_BUFFER_SIZE ]; +        tmInitialize(TELEMETRY_BUFFER_SIZE, gTelemetryBufferPtr); + +        tm_error telemetry_status = tmOpen( +            0,                     // unused +            "SecondLife",          // app name +            __DATE__ " " __TIME__, // build identifier +            "localhost",           // server name (or filename) +            TMCT_TCP,              // connection type (or TMCT_FILE) +            4719,                  // port +            TMOF_INIT_NETWORKING,  // open flags +            250 );                 // timeout ms + +        if (telemetry_status == TMERR_UNKNOWN) +        { +            LL_ERRS() << "Telemetry FAIL: unknown error" << LL_ENDL; +        } +        else if (telemetry_status && (telemetry_status <= TMERR_INIT_NETWORKING_FAILED)) +        { +            LL_INFOS() << tm_status[ telemetry_status ] << LL_ENDL; +            free(gTelemetryBufferPtr); +            gTelemetryBufferPtr = NULL; +        } +    #endif // LL_WINDOWS +} + +// Called after we render a frame +void telemetry_update() +{ +    #if LL_WINDOWS +        if (gTelemetryBufferPtr) +        { +            tmTick(0); +        } +    #endif +} +#endif // LLPROFILE_USE_RAD_TELEMETRY_PROFILER diff --git a/indra/newview/lltelemetry.h b/indra/newview/lltelemetry.h new file mode 100644 index 0000000000..a73e5fcfa2 --- /dev/null +++ b/indra/newview/lltelemetry.h @@ -0,0 +1,81 @@ +/** + * @file lltelemetry.h + * @brief Wrapper for Rad Game Tools Telemetry + * + * $LicenseInfo:firstyear=2020&license=viewerlgpl$ + * Second Life Viewer Source Code + * Copyright (C) 2020, Linden Research, Inc. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License only. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA + * + * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA + * $/LicenseInfo$ + */ + +/* +To use: + +1. Uncomment #define LLPROFILE_USE_RAD_TELEMETRY_PROFILER below + +2. Include this header file +    #include "lltelemetry.h" + +3. Add zones to the functions you wish to profile +    void onFoo() +    { +        LLPROFILE_ZONE("Foo"); +    } +*/ +//#define LLPROFILE_USE_RAD_TELEMETRY_PROFILER 1 + +// Default NO local telemetry profiling +#ifndef LLPROFILE_USE_RAD_TELEMETRY_PROFILER +    #define LLPROFILE_USE_RAD_TELEMETRY_PROFILER 0 +    #define LLPROFILE_SHUTDOWN( ...) {} +    #define LLPROFILE_STARTUP(  ...) {} +    #define LLPROFILE_UPDATE(   ...) {} + +    #define LLPROFILE_AUTO_CPU_MARKER_COLOR(r, g, b) +    #define LLPROFILE_ENTER(name) +    #define LLPROFILE_ENTER_FORMAT(format, ...) +    #define LLPROFILE_FUNCTION +    #define LLPROFILE_LEAVE() +    #define LLPROFILE_THREAD_NAME(name) +    #define LLPROFILE_ZONE(name) +    #define LLPROFILE_ZONE_FORMAT(format, ...) +#else +    #include <rad_tm.h> + +    #define LLPROFILE_SHUTDOWN                       telemetry_shutdown +    #define LLPROFILE_STARTUP                        telemetry_startup +    #define LLPROFILE_UPDATE                         telemetry_update + +    #define LLPROFILE_AUTO_CPU_MARKER_COLOR(r, g, b) tmZoneColor(r, g, b) +    #define LLPROFILE_ENTER(name)                    tmEnter(0, 0, name) +    #define LLPROFILE_ENTER_FORMAT(format, ...)      tmEnter(0, 0, format, __VA_ARGS__) +    #define LLPROFILE_FUNCTION                       tmFunction(0, 0) +    #define LLPROFILE_LEAVE()                        tmLeave(0) +    #define LLPROFILE_THREAD_NAME(name)              tmThreadName(0, 0, name) +    #define LLPROFILE_ZONE(name)                     tmZone(0, 0, name) +    #define LLPROFILE_ZONE_FORMAT(format, ...)       tmZone(0, 0, format, __VA_ARGS__) +#endif // LLPROFILE_USE_RAD_TELEMETRY_PROFILER + +// +// exported functionality +// + +extern void telemetry_startup(); +extern void telemetry_shutdown(); +extern void telemetry_update(); // called after every frame update diff --git a/indra/newview/llviewerassetstorage.cpp b/indra/newview/llviewerassetstorage.cpp index 54f80a2995..7842d24279 100644 --- a/indra/newview/llviewerassetstorage.cpp +++ b/indra/newview/llviewerassetstorage.cpp @@ -49,8 +49,8 @@  /// LLViewerAssetRequest  ///---------------------------------------------------------------------------- - // There is also PoolSizeVAssetStorage value in setting that should mirror this name -static const std::string VIEWER_ASSET_STORAGE_CORO_POOL = "VAssetStorage"; + // There is also PoolSizeAssetStorage value in setting that should mirror this name +static const std::string VIEWER_ASSET_STORAGE_CORO_POOL = "AssetStorage";  /**   * @brief Local class to encapsulate asset fetch requests with a timestamp. @@ -137,6 +137,14 @@ LLViewerAssetStorage::~LLViewerAssetStorage()          // This class has dedicated coroutine pool, clean it up, otherwise coroutines will crash later.           LLCoprocedureManager::instance().close(VIEWER_ASSET_STORAGE_CORO_POOL);      } + +    while (mCoroWaitList.size() > 0) +    { +        CoroWaitList &request = mCoroWaitList.front(); +        // Clean up pending downloads, delete request and trigger callbacks +        removeAndCallbackPendingDownloads(request.mId, request.mType, request.mId, request.mType, LL_ERR_NOERR, LLExtStat::NONE); +        mCoroWaitList.pop_front(); +    }  }  // virtual  @@ -350,6 +358,27 @@ void LLViewerAssetStorage::storeAssetData(      }  } +void LLViewerAssetStorage::checkForTimeouts() +{ +    LLAssetStorage::checkForTimeouts(); + +    // Restore requests +    LLCoprocedureManager* manager = LLCoprocedureManager::getInstance(); +    while (mCoroWaitList.size() > 0 +           && manager->count(VIEWER_ASSET_STORAGE_CORO_POOL) < LLCoprocedureManager::DEFAULT_QUEUE_SIZE) +    { +        CoroWaitList &request = mCoroWaitList.front(); +         +        bool with_http = true; +        bool is_temp = false; +        LLViewerAssetStatsFF::record_enqueue(request.mType, with_http, is_temp); + +        manager->enqueueCoprocedure(VIEWER_ASSET_STORAGE_CORO_POOL, "LLViewerAssetStorage::assetRequestCoro", +            boost::bind(&LLViewerAssetStorage::assetRequestCoro, this, request.mRequest, request.mId, request.mType, request.mCallback, request.mUserData)); + +        mCoroWaitList.pop_front(); +    } +}  /**   * @brief Allocate and queue an asset fetch request for the viewer @@ -407,12 +436,20 @@ void LLViewerAssetStorage::queueRequestHttp(      // This is the same as the current UDP logic - don't re-request a duplicate.      if (!duplicate)      { -        bool with_http = true; -        bool is_temp = false; -        LLViewerAssetStatsFF::record_enqueue(atype, with_http, is_temp); +        // Coroutine buffer has fixed size (synchronization buffer, so we have no alternatives), so buffer any request above limit +        if (LLCoprocedureManager::instance().count(VIEWER_ASSET_STORAGE_CORO_POOL) < LLCoprocedureManager::DEFAULT_QUEUE_SIZE) +        { +            bool with_http = true; +            bool is_temp = false; +            LLViewerAssetStatsFF::record_enqueue(atype, with_http, is_temp); -        LLCoprocedureManager::instance().enqueueCoprocedure(VIEWER_ASSET_STORAGE_CORO_POOL,"LLViewerAssetStorage::assetRequestCoro", -            boost::bind(&LLViewerAssetStorage::assetRequestCoro, this, req, uuid, atype, callback, user_data)); +            LLCoprocedureManager::instance().enqueueCoprocedure(VIEWER_ASSET_STORAGE_CORO_POOL, "LLViewerAssetStorage::assetRequestCoro", +                boost::bind(&LLViewerAssetStorage::assetRequestCoro, this, req, uuid, atype, callback, user_data)); +        } +        else +        { +            mCoroWaitList.emplace_back(req, uuid, atype, callback, user_data); +        }      }  } diff --git a/indra/newview/llviewerassetstorage.h b/indra/newview/llviewerassetstorage.h index ef01d179b7..c1a5534b81 100644 --- a/indra/newview/llviewerassetstorage.h +++ b/indra/newview/llviewerassetstorage.h @@ -45,7 +45,7 @@ public:  	~LLViewerAssetStorage(); -	virtual void storeAssetData( +	void storeAssetData(  		const LLTransactionID& tid,  		LLAssetType::EType atype,  		LLStoreAssetCallback callback, @@ -54,9 +54,9 @@ public:  		bool is_priority = false,  		bool store_local = false,  		bool user_waiting=FALSE, -		F64Seconds timeout=LL_ASSET_STORAGE_TIMEOUT); -	 -	virtual void storeAssetData( +		F64Seconds timeout=LL_ASSET_STORAGE_TIMEOUT) override; + +	void storeAssetData(  		const std::string& filename,  		const LLTransactionID& tid,  		LLAssetType::EType type, @@ -65,16 +65,17 @@ public:  		bool temp_file = false,  		bool is_priority = false,  		bool user_waiting=FALSE, -		F64Seconds timeout=LL_ASSET_STORAGE_TIMEOUT); +		F64Seconds timeout=LL_ASSET_STORAGE_TIMEOUT) override; + +    void checkForTimeouts() override;  protected: -	// virtual  	void _queueDataRequest(const LLUUID& uuid,  						   LLAssetType::EType type,                             LLGetAssetCallback callback,  						   void *user_data,  						   BOOL duplicate, -						   BOOL is_priority); +						   BOOL is_priority) override;      void queueRequestHttp(const LLUUID& uuid,                            LLAssetType::EType type, @@ -93,8 +94,35 @@ protected:      std::string getAssetURL(const std::string& cap_url, const LLUUID& uuid, LLAssetType::EType atype); -    void logAssetStorageInfo(); -     +    void logAssetStorageInfo() override; + +    // Asset storage works through coroutines and coroutines have limited queue capacity +    // This class is meant to temporary store requests when fiber's queue is full +    class CoroWaitList +    { +    public: +        CoroWaitList(LLViewerAssetRequest *req, +            const LLUUID& uuid, +            LLAssetType::EType atype, +            LLGetAssetCallback &callback, +            void *user_data) +          : mRequest(req), +            mId(uuid), +            mType(atype), +            mCallback(callback), +            mUserData(user_data) +        { +        } + +        LLViewerAssetRequest* mRequest; +        LLUUID mId; +        LLAssetType::EType mType; +        LLGetAssetCallback mCallback; +        void *mUserData; +    }; +    typedef std::list<CoroWaitList> wait_list_t; +    wait_list_t mCoroWaitList; +      std::string mViewerAssetUrl;      S32 mAssetCoroCount;      S32 mCountRequests; diff --git a/indra/newview/llviewerdisplay.cpp b/indra/newview/llviewerdisplay.cpp index d314b1477a..6d939fbe21 100644 --- a/indra/newview/llviewerdisplay.cpp +++ b/indra/newview/llviewerdisplay.cpp @@ -753,10 +753,7 @@ void display(BOOL rebuild, F32 zoom_factor, int subfield, BOOL for_snapshot)  				glViewport(0,0,512,512);  				LLVOAvatar::updateFreezeCounter() ; -				if(!LLPipeline::sMemAllocationThrottled) -				{		 -					LLVOAvatar::updateImpostors(); -				} +				LLVOAvatar::updateImpostors();  				set_current_projection(proj);  				set_current_modelview(mod); diff --git a/indra/newview/llviewerjoint.cpp b/indra/newview/llviewerjoint.cpp index a448a95904..9653e80b53 100644 --- a/indra/newview/llviewerjoint.cpp +++ b/indra/newview/llviewerjoint.cpp @@ -143,8 +143,10 @@ U32 LLViewerJoint::render( F32 pixelArea, BOOL first_pass, BOOL is_dummy )  	//----------------------------------------------------------------  	for (LLJoint* j : mChildren)  	{ -		LLAvatarJoint* joint = dynamic_cast<LLAvatarJoint*>(j); -		F32 jointLOD = joint ? joint->getLOD() : 0; +		// LLViewerJoint is derived from LLAvatarJoint, +		// all children of LLAvatarJoint are assumed to be LLAvatarJoint +		LLAvatarJoint* joint = static_cast<LLAvatarJoint*>(j); +		F32 jointLOD = joint->getLOD();  		if (pixelArea >= jointLOD || sDisableLOD)  		{  			triangle_count += joint->render( pixelArea, TRUE, is_dummy ); diff --git a/indra/newview/llviewerjointmesh.cpp b/indra/newview/llviewerjointmesh.cpp index fdfd22c117..63ad708e59 100644 --- a/indra/newview/llviewerjointmesh.cpp +++ b/indra/newview/llviewerjointmesh.cpp @@ -56,7 +56,7 @@  #include "m4math.h"  #include "llmatrix4a.h" -#if !LL_DARWIN && !LL_LINUX && !LL_SOLARIS +#if !LL_DARWIN && !LL_LINUX  extern PFNGLWEIGHTPOINTERARBPROC glWeightPointerARB;  extern PFNGLWEIGHTFVARBPROC glWeightfvARB;  extern PFNGLVERTEXBLENDARBPROC glVertexBlendARB; diff --git a/indra/newview/llviewermenu.cpp b/indra/newview/llviewermenu.cpp index eef48ad083..9d05f59b09 100644 --- a/indra/newview/llviewermenu.cpp +++ b/indra/newview/llviewermenu.cpp @@ -5406,7 +5406,7 @@ class LLToolsSelectNextPartFace : public view_listener_t                          new_te = to_select->getNumTEs() - 1;                      }                  } -                LLSelectMgr::getInstance()->addAsIndividual(to_select, new_te, FALSE); +                LLSelectMgr::getInstance()->selectObjectOnly(to_select, new_te);              }              else              { diff --git a/indra/newview/llviewernetwork.cpp b/indra/newview/llviewernetwork.cpp index a593905060..be05ac0d3a 100644 --- a/indra/newview/llviewernetwork.cpp +++ b/indra/newview/llviewernetwork.cpp @@ -130,7 +130,7 @@ void LLGridManager::initialize(const std::string& grid_file)  				  "https://secondlife.aditi.lindenlab.com/helpers/",  				  DEFAULT_LOGIN_PAGE,  				  SL_UPDATE_QUERY_URL, -				  "https://my.aditi.lindenlab.com/", +				  "https://my.secondlife-beta.com/",  				  "Aditi");  	LLSD other_grids; diff --git a/indra/newview/llviewertexture.cpp b/indra/newview/llviewertexture.cpp index 20a22ba45e..ca01bb46aa 100644 --- a/indra/newview/llviewertexture.cpp +++ b/indra/newview/llviewertexture.cpp @@ -3314,13 +3314,6 @@ void LLViewerLODTexture::processTextureStats()  	{  		mDesiredDiscardLevel = llmin(mDesiredDiscardLevel, (S8)mDesiredSavedRawDiscardLevel);  	} -	else if(LLPipeline::sMemAllocationThrottled)//release memory of large textures by decrease their resolutions. -	{ -		if(scaleDown()) -		{ -			mDesiredDiscardLevel = mCachedRawDiscardLevel; -		} -	}  }  bool LLViewerLODTexture::scaleDown() diff --git a/indra/newview/llviewerwindow.cpp b/indra/newview/llviewerwindow.cpp index 9c1aa772d8..21985d5a8a 100644 --- a/indra/newview/llviewerwindow.cpp +++ b/indra/newview/llviewerwindow.cpp @@ -314,6 +314,99 @@ RecordToChatConsole::RecordToChatConsole():  ////////////////////////////////////////////////////////////////////////////  // +// Print Utility +// + +// Convert a normalized float (-1.0 <= x <= +1.0) to a fixed 1.4 format string: +// +//    s#.#### +// +// Where: +//    s  sign character; space if x is positiv, minus if negative +//    #  decimal digits +// +// This is similar to printf("%+.4f") except positive numbers are NOT cluttered with a leading '+' sign. +// NOTE: This does NOT null terminate the output +void normalized_float_to_string(const float x, char *out_str) +{ +    static const unsigned char DECIMAL_BCD2[] = +    { +        0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, +        0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18, 0x19, +        0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27, 0x28, 0x29, +        0x30, 0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, +        0x40, 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48, 0x49, +        0x50, 0x51, 0x52, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, +        0x60, 0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67, 0x68, 0x69, +        0x70, 0x71, 0x72, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, +        0x80, 0x81, 0x82, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89, +        0x90, 0x91, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98, 0x99 +    }; + +    int neg = (x < 0); +    int rem = neg +            ? (int)(x * -10000.) +            : (int)(x *  10000.); + +    int d10 = rem % 100; rem /= 100; +    int d32 = rem % 100; rem /= 100; + +    out_str[6] = '0' + ((DECIMAL_BCD2[ d10 ] >> 0) & 0xF); +    out_str[5] = '0' + ((DECIMAL_BCD2[ d10 ] >> 4) & 0xF); +    out_str[4] = '0' + ((DECIMAL_BCD2[ d32 ] >> 0) & 0xF); +    out_str[3] = '0' + ((DECIMAL_BCD2[ d32 ] >> 4) & 0xF); +    out_str[2] = '.'; +    out_str[1] = '0' + (rem & 1); +    out_str[0] = " -"[neg]; // Could always show '+' for positive but this clutters up the common case +} + +// normalized float +//    printf("%-.4f    %-.4f    %-.4f") +// Params: +//   float  &matrix_row[4] +//   int    matrix_cell_index +//   string out_buffer (size 32) +// Note: The buffer is assumed to be pre-filled with spaces +#define MATRIX_ROW_N32_TO_STR(matrix_row, i, out_buffer)          \ +    normalized_float_to_string(matrix_row[i+0], out_buffer +  0); \ +    normalized_float_to_string(matrix_row[i+1], out_buffer + 11); \ +    normalized_float_to_string(matrix_row[i+2], out_buffer + 22); \ +    out_buffer[31] = 0; + + +// regular float +//    sprintf(buffer, "%-8.2f  %-8.2f  %-8.2f", matrix_row[i+0], matrix_row[i+1], matrix_row[i+2]); +// Params: +//   float  &matrix_row[4] +//   int    matrix_cell_index +//   char   out_buffer[32] +// Note: The buffer is assumed to be pre-filled with spaces +#define MATRIX_ROW_F32_TO_STR(matrix_row, i, out_buffer) {                       \ +    static const char *format[3] = {                                             \ +        "%-8.2f"  ,  /* 0 */                                                     \ +        ">  99K  ",  /* 1 */                                                     \ +        "< -99K  "   /* 2 */                                                     \ +    };                                                                           \ +                                                                                 \ +    F32 temp_0 = matrix_row[i+0];                                                \ +    F32 temp_1 = matrix_row[i+1];                                                \ +    F32 temp_2 = matrix_row[i+2];                                                \ +                                                                                 \ +    U8 flag_0 = (((U8)(temp_0 < -99999.99)) << 1) | ((U8)(temp_0 > 99999.99));   \ +    U8 flag_1 = (((U8)(temp_1 < -99999.99)) << 1) | ((U8)(temp_1 > 99999.99));   \ +    U8 flag_2 = (((U8)(temp_2 < -99999.99)) << 1) | ((U8)(temp_2 > 99999.99));   \ +                                                                                 \ +    if (temp_0 < 0.f) out_buffer[ 0] = '-';                                      \ +    if (temp_1 < 0.f) out_buffer[11] = '-';                                      \ +    if (temp_2 < 0.f) out_buffer[22] = '-';                                      \ +                                                                                 \ +    sprintf(out_buffer+ 1,format[flag_0],fabsf(temp_0)); out_buffer[ 1+8] = ' '; \ +    sprintf(out_buffer+12,format[flag_1],fabsf(temp_1)); out_buffer[12+8] = ' '; \ +    sprintf(out_buffer+23,format[flag_2],fabsf(temp_2)); out_buffer[23+8] =  0 ; \ +} + +//////////////////////////////////////////////////////////////////////////// +//  // LLDebugText  // @@ -334,7 +427,11 @@ private:  	typedef std::vector<Line> line_list_t;  	line_list_t mLineList;  	LLColor4 mTextColor; -	 + +	LLColor4 mBackColor; +	LLRect mBackRectCamera1; +	LLRect mBackRectCamera2; +  	void addText(S32 x, S32 y, const std::string &text)   	{  		mLineList.push_back(Line(text, x, y)); @@ -376,11 +473,22 @@ public:  		mTextColor = LLColor4( 0.86f, 0.86f, 0.86f, 1.f );  		// Draw stuff growing up from right lower corner of screen -		S32 xpos = mWindow->getWorldViewWidthScaled() - 400; +		S32 x_right = mWindow->getWorldViewWidthScaled(); +		S32 xpos = x_right - 400;  		xpos = llmax(xpos, 0);  		S32 ypos = 64;  		const S32 y_inc = 20; +		// Camera matrix text is hard to see again a white background +		// Add a dark background underneath the matrices for readability (contrast) +		mBackRectCamera1.mLeft   = xpos; +		mBackRectCamera1.mRight  = x_right; +		mBackRectCamera1.mTop    = -1; +		mBackRectCamera1.mBottom = -1; +		mBackRectCamera2 = mBackRectCamera1; + +		mBackColor = LLUIColorTable::instance().getColor( "MenuDefaultBgColor" ); +  		clearText();  		if (gSavedSettings.getBOOL("DebugShowTime")) @@ -716,48 +824,45 @@ public:  		}  		if (gSavedSettings.getBOOL("DebugShowRenderMatrices"))  		{ -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLProjection[12], gGLProjection[13], gGLProjection[14], gGLProjection[15])); -			ypos += y_inc; - -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLProjection[8], gGLProjection[9], gGLProjection[10], gGLProjection[11])); -			ypos += y_inc; - -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLProjection[4], gGLProjection[5], gGLProjection[6], gGLProjection[7])); -			ypos += y_inc; +			char camera_lines[8][32]; +			memset(camera_lines, ' ', sizeof(camera_lines)); -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLProjection[0], gGLProjection[1], gGLProjection[2], gGLProjection[3])); -			ypos += y_inc; +			// Projection last column is always <0,0,-1.0001,0> +			// Projection last row is always <0,0,-0.2> +			mBackRectCamera1.mBottom = ypos - y_inc + 2; +			MATRIX_ROW_N32_TO_STR(gGLProjection, 12,camera_lines[7]); addText(xpos, ypos, std::string(camera_lines[7])); ypos += y_inc; +			MATRIX_ROW_N32_TO_STR(gGLProjection,  8,camera_lines[6]); addText(xpos, ypos, std::string(camera_lines[6])); ypos += y_inc; +			MATRIX_ROW_N32_TO_STR(gGLProjection,  4,camera_lines[5]); addText(xpos, ypos, std::string(camera_lines[5])); ypos += y_inc; mBackRectCamera1.mTop    = ypos + 2; +			MATRIX_ROW_N32_TO_STR(gGLProjection,  0,camera_lines[4]); addText(xpos, ypos, std::string(camera_lines[4])); ypos += y_inc; mBackRectCamera2.mBottom = ypos + 2;  			addText(xpos, ypos, "Projection Matrix");  			ypos += y_inc; - -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLModelView[12], gGLModelView[13], gGLModelView[14], gGLModelView[15])); -			ypos += y_inc; - -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLModelView[8], gGLModelView[9], gGLModelView[10], gGLModelView[11])); -			ypos += y_inc; - -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLModelView[4], gGLModelView[5], gGLModelView[6], gGLModelView[7])); -			ypos += y_inc; - -			addText(xpos, ypos, llformat("%.4f    .%4f    %.4f    %.4f", gGLModelView[0], gGLModelView[1], gGLModelView[2], gGLModelView[3])); -			ypos += y_inc; +			// View last column is always <0,0,0,1> +			MATRIX_ROW_F32_TO_STR(gGLModelView, 12,camera_lines[3]); addText(xpos, ypos, std::string(camera_lines[3])); ypos += y_inc; +			MATRIX_ROW_N32_TO_STR(gGLModelView,  8,camera_lines[2]); addText(xpos, ypos, std::string(camera_lines[2])); ypos += y_inc; +			MATRIX_ROW_N32_TO_STR(gGLModelView,  4,camera_lines[1]); addText(xpos, ypos, std::string(camera_lines[1])); ypos += y_inc; mBackRectCamera2.mTop = ypos + 2; +			MATRIX_ROW_N32_TO_STR(gGLModelView,  0,camera_lines[0]); addText(xpos, ypos, std::string(camera_lines[0])); ypos += y_inc;  			addText(xpos, ypos, "View Matrix");  			ypos += y_inc;  		}  		// disable use of glReadPixels which messes up nVidia nSight graphics debugging -		if (gSavedSettings.getBOOL("DebugShowColor") && !LLRender::sNsightDebugSupport) -		{ -			U8 color[4]; -			LLCoordGL coord = gViewerWindow->getCurrentMouse(); -			glReadPixels(coord.mX, coord.mY, 1,1,GL_RGBA, GL_UNSIGNED_BYTE, color); -			addText(xpos, ypos, llformat("%d %d %d %d", color[0], color[1], color[2], color[3])); -			ypos += y_inc; -		} +        if (gSavedSettings.getBOOL("DebugShowColor") && !LLRender::sNsightDebugSupport) +        { +            U8 color[4]; +            LLCoordGL coord = gViewerWindow->getCurrentMouse(); -		// only display these messages if we are actually rendering beacons at this moment +            // Convert x,y to raw pixel coords +            S32 x_raw = llround(coord.mX * gViewerWindow->getWindowWidthRaw() / (F32) gViewerWindow->getWindowWidthScaled()); +            S32 y_raw = llround(coord.mY * gViewerWindow->getWindowHeightRaw() / (F32) gViewerWindow->getWindowHeightScaled()); +             +            glReadPixels(x_raw, y_raw, 1, 1, GL_RGBA, GL_UNSIGNED_BYTE, color); +            addText(xpos, ypos, llformat("Pixel <%1d, %1d> R:%1d G:%1d B:%1d A:%1d", x_raw, y_raw, color[0], color[1], color[2], color[3])); +            ypos += y_inc; +        } + +        // only display these messages if we are actually rendering beacons at this moment  		if (LLPipeline::getRenderBeacons() && LLFloaterReg::instanceVisible("beacons"))  		{  			if (LLPipeline::getRenderMOAPBeacons()) @@ -884,6 +989,18 @@ public:  	void draw()  	{  		LL_RECORD_BLOCK_TIME(FTM_DISPLAY_DEBUG_TEXT); + +		// Camera matrix text is hard to see again a white background +		// Add a dark background underneath the matrices for readability (contrast) +		if (mBackRectCamera1.mTop >= 0) +		{ +			mBackColor.setAlpha( 0.75f ); +			gl_rect_2d(mBackRectCamera1, mBackColor, true); + +			mBackColor.setAlpha( 0.66f ); +			gl_rect_2d(mBackRectCamera2, mBackColor, true); +		} +  		for (line_list_t::iterator iter = mLineList.begin();  			 iter != mLineList.end(); ++iter)  		{ @@ -892,7 +1009,6 @@ public:  											 LLFontGL::LEFT, LLFontGL::TOP,  											 LLFontGL::NORMAL, LLFontGL::NO_SHADOW, S32_MAX, S32_MAX, NULL, FALSE);  		} -		mLineList.clear();  	}  }; @@ -1800,8 +1916,8 @@ LLViewerWindow::LLViewerWindow(const Params& p)  		ms_sleep(5000) ; //wait for 5 seconds.  		LLSplashScreen::update(LLTrans::getString("ShuttingDown")); -#if LL_LINUX || LL_SOLARIS -		LL_WARNS() << "Unable to create window, be sure screen is set at 32-bit color and your graphics driver is configured correctly.  See README-linux.txt or README-solaris.txt for further information." +#if LL_LINUX +		LL_WARNS() << "Unable to create window, be sure screen is set at 32-bit color and your graphics driver is configured correctly.  See README-linux.txt for further information."  				<< LL_ENDL;  #else  		LL_WARNS("Window") << "Unable to create window, be sure screen is set at 32-bit color in Control Panels->Display->Settings" @@ -2316,7 +2432,6 @@ void LLViewerWindow::shutdownGL()  LLViewerWindow::~LLViewerWindow()  {  	LL_INFOS() << "Destroying Window" << LL_ENDL; -	gDebugWindowProc = TRUE; // event catching, disable once we figure out cause for exit crashes  	destroyWindow();  	delete mDebugText; @@ -2407,6 +2522,11 @@ void LLViewerWindow::reshape(S32 width, S32 height)  		// round up when converting coordinates to make sure there are no gaps at edge of window  		LLView::sForceReshape = display_scale_changed;  		mRootView->reshape(llceil((F32)width / mDisplayScale.mV[VX]), llceil((F32)height / mDisplayScale.mV[VY])); +        if (display_scale_changed) +        { +            // Needs only a 'scale change' update, everything else gets handled by LLLayoutStack::updateClass() +            LLPanelLogin::reshapePanel(); +        }  		LLView::sForceReshape = FALSE;  		// clear font width caches @@ -4731,10 +4851,6 @@ BOOL LLViewerWindow::rawSnapshot(LLImageRaw *raw, S32 image_width, S32 image_hei  		return FALSE;  	}  	//check if there is enough memory for the snapshot image -	if(LLPipeline::sMemAllocationThrottled) -	{ -		return FALSE ; //snapshot taking is disabled due to memory restriction. -	}  	if(image_width * image_height > (1 << 22)) //if snapshot image is larger than 2K by 2K  	{  		if(!LLMemory::tryToAlloc(NULL, image_width * image_height * 3)) diff --git a/indra/newview/llvoiceclient.cpp b/indra/newview/llvoiceclient.cpp index 57599c9f3a..e2bd1a39c7 100644 --- a/indra/newview/llvoiceclient.cpp +++ b/indra/newview/llvoiceclient.cpp @@ -180,6 +180,13 @@ void LLVoiceClient::terminate()  {  	if (mVoiceModule) mVoiceModule->terminate();  	mVoiceModule = NULL; +    m_servicePump = NULL; + +    // Shutdown speaker volume storage before LLSingletonBase::deleteAll() does it +    if (LLSpeakerVolumeStorage::instanceExists()) +    { +        LLSpeakerVolumeStorage::deleteSingleton(); +    }  }  const LLVoiceVersionInfo LLVoiceClient::getVersion() diff --git a/indra/newview/llvoicevivox.cpp b/indra/newview/llvoicevivox.cpp index a8d668420e..b0f57beff8 100644 --- a/indra/newview/llvoicevivox.cpp +++ b/indra/newview/llvoicevivox.cpp @@ -359,7 +359,7 @@ LLVivoxVoiceClient::LLVivoxVoiceClient() :  //	gMuteListp->addObserver(&mutelist_listener); -#if LL_DARWIN || LL_LINUX || LL_SOLARIS +#if LL_DARWIN || LL_LINUX  		// HACK: THIS DOES NOT BELONG HERE  		// When the vivox daemon dies, the next write attempt on our socket generates a SIGPIPE, which kills us.  		// This should cause us to ignore SIGPIPE and handle the error through proper channels. @@ -391,7 +391,7 @@ LLVivoxVoiceClient::~LLVivoxVoiceClient()  void LLVivoxVoiceClient::init(LLPumpIO *pump)  {  	// constructor will set up LLVoiceClient::getInstance() -	LLVivoxVoiceClient::getInstance()->mPump = pump; +	mPump = pump;  //     LLCoros::instance().launch("LLVivoxVoiceClient::voiceControlCoro",  //         boost::bind(&LLVivoxVoiceClient::voiceControlCoro, LLVivoxVoiceClient::getInstance())); @@ -419,6 +419,7 @@ void LLVivoxVoiceClient::terminate()  	}      sShuttingDown = true; +    mPump = NULL;  }  //--------------------------------------------------- @@ -953,10 +954,15 @@ bool LLVivoxVoiceClient::startAndLaunchDaemon()      llcoro::suspendUntilTimeout(UPDATE_THROTTLE_SECONDS); -    while (!mPump) -    {   // Can't do this until we have the pump available. +    while (!mPump && !sShuttingDown) +    {   // Can't use the pump until we have it available.          llcoro::suspend();      } + +    if (sShuttingDown) +    { +        return false; +    }      // MBW -- Note to self: pumps and pipes examples in      //  indra/test/io.cpp @@ -969,8 +975,10 @@ bool LLVivoxVoiceClient::startAndLaunchDaemon()      readChain.push_back(LLIOPipe::ptr_t(new LLIOSocketReader(mSocket)));      readChain.push_back(LLIOPipe::ptr_t(new LLVivoxProtocolParser())); +      mPump->addChain(readChain, NEVER_CHAIN_EXPIRY_SECS); +      //---------------------------------------------------------------------      llcoro::suspendUntilTimeout(UPDATE_THROTTLE_SECONDS); @@ -993,6 +1001,11 @@ bool LLVivoxVoiceClient::provisionVoiceAccount()          // *TODO* Pump a message for wake up.          llcoro::suspend();      } +     +    if (sShuttingDown) +    { +        return false; +    }      std::string url = gAgent.getRegionCapability("ProvisionVoiceAccountRequest"); diff --git a/indra/newview/llvosky.cpp b/indra/newview/llvosky.cpp index 2037aca7e9..878d7287ed 100644 --- a/indra/newview/llvosky.cpp +++ b/indra/newview/llvosky.cpp @@ -209,14 +209,7 @@ void LLSkyTex::create()  void LLSkyTex::createGLImage(S32 which)  {	 -    if (mIsShiny) -    { -        mTexture[which]->setExplicitFormat(GL_RGBA8, GL_RGBA); -    } -    else -    { -        mTexture[which]->setExplicitFormat(GL_SRGB8_ALPHA8, GL_RGBA); -    } +	mTexture[which]->setExplicitFormat(GL_RGBA8, GL_RGBA);  	mTexture[which]->createGLTexture(0, mImageRaw[which], 0, TRUE, LLGLTexture::LOCAL);  	mTexture[which]->setAddressMode(LLTexUnit::TAM_CLAMP);  } diff --git a/indra/newview/llvotree.cpp b/indra/newview/llvotree.cpp index 8e46ccd555..41099cb570 100644 --- a/indra/newview/llvotree.cpp +++ b/indra/newview/llvotree.cpp @@ -45,6 +45,8 @@  #include "llviewertexturelist.h"  #include "llviewerobjectlist.h"  #include "llviewerregion.h" +#include "llvolumemgr.h" +#include "llvovolume.h"  #include "llworld.h"  #include "noise.h"  #include "pipeline.h" @@ -85,6 +87,9 @@ LLVOTree::LLVOTree(const LLUUID &id, const LLPCode pcode, LLViewerRegion *region  	mFrameCount = 0;  	mWind = mRegionp->mWind.getVelocity(getPositionRegion());  	mTrunkLOD = 0; + +	// if assert triggers, idleUpdate() needs to be revised and adjusted to new LOD levels +	llassert(sMAX_NUM_TREE_LOD_LEVELS == LLVolumeLODGroup::NUM_LODS);  } @@ -347,8 +352,11 @@ void LLVOTree::idleUpdate(LLAgent &agent, const F64 &time)  		return;  	} -	S32 trunk_LOD = sMAX_NUM_TREE_LOD_LEVELS ; +	S32 trunk_LOD = sMAX_NUM_TREE_LOD_LEVELS ; // disabled  	F32 app_angle = getAppAngle()*LLVOTree::sTreeFactor; +	F32 distance = mDrawable->mDistanceWRTCamera * LLVOVolume::sDistanceFactor * (F_PI / 3.f); +	F32 diameter = getScale().length(); // trees have very broken scale, but length rougtly outlines proper diameter +	F32 sz = mBillboardScale * mBillboardRatio * diameter;  	for (S32 j = 0; j < sMAX_NUM_TREE_LOD_LEVELS; j++)  	{ @@ -357,7 +365,14 @@ void LLVOTree::idleUpdate(LLAgent &agent, const F64 &time)  			trunk_LOD = j;  			break;  		} -	}  +	} + +    F32 tan_angle = (LLVOTree::sTreeFactor * 64 * sz) / distance; +    S32 cur_detail = LLVolumeLODGroup::getDetailFromTan(ll_round(tan_angle, 0.01f)); // larger value, better quality + +    // for trunk_LOD lower value means better quality, but both trunk_LOD and cur_detail have 4 levels +    trunk_LOD = llmax(trunk_LOD, LLVolumeLODGroup::NUM_LODS - cur_detail - 1); +    trunk_LOD = llmin(trunk_LOD, sMAX_NUM_TREE_LOD_LEVELS);  	if (mReferenceBuffer.isNull())  	{ @@ -408,8 +423,9 @@ void LLVOTree::setPixelAreaAndAngle(LLAgent &agent)  	LLVector3 lookAt = center - viewer_pos_agent;  	F32 dist = lookAt.normVec() ;	  	F32 cos_angle_to_view_dir = lookAt * LLViewerCamera::getInstance()->getXAxis() ;	 -	 -	F32 range = dist - getMinScale()/2; +	F32 radius = getScale().length()*0.5f; +	F32 range = dist - radius; +  	if (range < F_ALMOST_ZERO || isHUDAttachment())		// range == zero  	{  		mAppAngle = 180.f; diff --git a/indra/newview/llvovolume.cpp b/indra/newview/llvovolume.cpp index 95cfe29a80..3bdb8a2981 100644 --- a/indra/newview/llvovolume.cpp +++ b/indra/newview/llvovolume.cpp @@ -2337,8 +2337,7 @@ bool LLVOVolume::notifyAboutCreatingTexture(LLViewerTexture *texture)  	//setup new materials  	for(map_te_material::const_iterator it = new_material.begin(), end = new_material.end(); it != end; ++it)  	{ -		// These are placeholder materials, they shouldn't be sent to server -		LLMaterialMgr::getInstance()->setLocalMaterial(getRegion()->getRegionID(), it->second); +		LLMaterialMgr::getInstance()->put(getID(), it->first, *it->second);  		LLViewerObject::setTEMaterialParams(it->first, it->second);  	} diff --git a/indra/newview/pipeline.cpp b/indra/newview/pipeline.cpp index 7ba7e545f4..cd1b9c7c69 100644 --- a/indra/newview/pipeline.cpp +++ b/indra/newview/pipeline.cpp @@ -129,6 +129,16 @@  //  #define MATERIALS_IN_REFLECTIONS 0 +// NOTE: Keep in sync with indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml +// NOTE: Unused consts are commented out since some compilers (on macOS) may complain about unused variables. +//  const S32 WATER_REFLECT_NONE_WATER_OPAQUE       = -2; +    const S32 WATER_REFLECT_NONE_WATER_TRANSPARENT  = -1; +    const S32 WATER_REFLECT_MINIMAL                 =  0; +//  const S32 WATER_REFLECT_TERRAIN                 =  1; +    const S32 WATER_REFLECT_STATIC_OBJECTS          =  2; +    const S32 WATER_REFLECT_AVATARS                 =  3; +    const S32 WATER_REFLECT_EVERYTHING              =  4; +  bool gShiftFrame = false;  //cached settings @@ -348,7 +358,6 @@ bool	LLPipeline::sRenderFrameTest = false;  bool	LLPipeline::sRenderAttachedLights = true;  bool	LLPipeline::sRenderAttachedParticles = true;  bool	LLPipeline::sRenderDeferred = false; -bool    LLPipeline::sMemAllocationThrottled = false;  S32		LLPipeline::sVisibleLightCount = 0;  F32		LLPipeline::sMinRenderSize = 0.f;  bool	LLPipeline::sRenderingHUDs; @@ -718,24 +727,6 @@ void LLPipeline::destroyGL()  static LLTrace::BlockTimerStatHandle FTM_RESIZE_SCREEN_TEXTURE("Resize Screen Texture"); -//static -void LLPipeline::throttleNewMemoryAllocation(bool disable) -{ -	if(sMemAllocationThrottled != disable) -	{ -		sMemAllocationThrottled = disable ; - -		if(sMemAllocationThrottled) -		{ -			//send out notification -			LLNotification::Params params("LowMemory"); -			LLNotifications::instance().add(params); - -			//release some memory. -		} -	} -} -  void LLPipeline::requestResizeScreenTexture()  {      gResizeScreenTexture = TRUE; @@ -9270,30 +9261,29 @@ inline float sgn(float a)  }  void LLPipeline::generateWaterReflection(LLCamera& camera_in) -{	 -	if (LLPipeline::sWaterReflections && assertInitialized() && LLDrawPoolWater::sNeedsReflectionUpdate) -	{ -		bool skip_avatar_update = false; -		if (!isAgentAvatarValid() || gAgentCamera.getCameraAnimating() || gAgentCamera.getCameraMode() != CAMERA_MODE_MOUSELOOK || !LLVOAvatar::sVisibleInFirstPerson) -		{ -			skip_avatar_update = true; -		} -		 -        LLCamera camera = camera_in; +{ +    if (LLPipeline::sWaterReflections && assertInitialized() && LLDrawPoolWater::sNeedsReflectionUpdate) +    { +        bool skip_avatar_update = false; +        if (!isAgentAvatarValid() || gAgentCamera.getCameraAnimating() || gAgentCamera.getCameraMode() != CAMERA_MODE_MOUSELOOK || !LLVOAvatar::sVisibleInFirstPerson) +        { +            skip_avatar_update = true; +        } +        LLCamera camera = camera_in;          camera.setFar(camera_in.getFar() * 0.75f);          bool camera_is_underwater = LLViewerCamera::getInstance()->cameraUnderWater(); -		LLPipeline::sReflectionRender = true; -		 -		gPipeline.pushRenderTypeMask(); +        LLPipeline::sReflectionRender = true; + +        gPipeline.pushRenderTypeMask();          glh::matrix4f saved_modelview  = get_current_modelview();          glh::matrix4f saved_projection = get_current_projection(); -		glh::matrix4f mat; +        glh::matrix4f mat; -        S32 detail = RenderReflectionDetail; +        S32 reflection_detail  = RenderReflectionDetail;          F32 water_height      = gAgent.getRegion()->getWaterHeight();           F32 camera_height     = camera_in.getOrigin().mV[VZ]; @@ -9307,32 +9297,34 @@ void LLPipeline::generateWaterReflection(LLCamera& camera_in)          camera.setOriginAndLookAt(reflect_origin, LLVector3::z_axis, reflect_interest_point); -		//plane params +        //plane params          LLPlane plane; -		LLVector3 pnorm; -		S32 water_clip = 0; +        LLVector3 pnorm; +        S32 water_clip = 0;          if (!camera_is_underwater) -		{ //camera is above water, clip plane points up -			pnorm.setVec(0,0,1); +        { +            //camera is above water, clip plane points up +            pnorm.setVec(0,0,1);              plane.setVec(pnorm, -water_height);              water_clip = 1; -		} -		else -		{	//camera is below water, clip plane points down -			pnorm = LLVector3(0,0,-1); +        } +        else +        { +            //camera is below water, clip plane points down +            pnorm = LLVector3(0,0,-1);              plane.setVec(pnorm, water_height);              water_clip = -1; -		} +        }          S32 occlusion = LLPipeline::sUseOcclusion; -			//disable occlusion culling for reflection map for now -			LLPipeline::sUseOcclusion = 0; +        //disable occlusion culling for reflection map for now +        LLPipeline::sUseOcclusion = 0;          if (!camera_is_underwater) -        {   //generate planar reflection map - -			LLViewerCamera::sCurCameraID = LLViewerCamera::CAMERA_WATER0; +        { +            //generate planar reflection map +            LLViewerCamera::sCurCameraID = LLViewerCamera::CAMERA_WATER0;              gGL.matrixMode(LLRender::MM_MODELVIEW);              gGL.pushMatrix(); @@ -9345,9 +9337,9 @@ void LLPipeline::generateWaterReflection(LLCamera& camera_in)              mReflectionModelView = mat;              set_current_modelview(mat); -			gGL.loadMatrix(mat.m); +            gGL.loadMatrix(mat.m); -			LLViewerCamera::updateFrustumPlanes(camera, FALSE, TRUE); +            LLViewerCamera::updateFrustumPlanes(camera, FALSE, TRUE);              glh::vec3f    origin(0, 0, 0);              glh::matrix4f inv_mat = mat.inverse(); @@ -9355,10 +9347,10 @@ void LLPipeline::generateWaterReflection(LLCamera& camera_in)              camera.setOrigin(origin.v); -			glCullFace(GL_FRONT); +            glCullFace(GL_FRONT); -			if (LLDrawPoolWater::sNeedsReflectionUpdate) -			{ +            if (LLDrawPoolWater::sNeedsReflectionUpdate) +            {                  gGL.getTexUnit(0)->unbind(LLTexUnit::TT_TEXTURE);                  glClearColor(0,0,0,0);                  mWaterRef.bindTarget(); @@ -9368,106 +9360,127 @@ void LLPipeline::generateWaterReflection(LLCamera& camera_in)                  gGL.setColorMask(true, false);                  mWaterRef.getViewport(gGLViewport); -				//initial sky pass (no user clip plane) -				{ //mask out everything but the sky -					gPipeline.pushRenderTypeMask(); -					gPipeline.andRenderTypeMask(LLPipeline::RENDER_TYPE_SKY, -						LLPipeline::RENDER_TYPE_WL_SKY, -						LLPipeline::RENDER_TYPE_CLOUDS, -						LLPipeline::END_RENDER_TYPES); +                //initial sky pass (no user clip plane) +                //mask out everything but the sky +                gPipeline.pushRenderTypeMask(); +                { +                    if (reflection_detail >= WATER_REFLECT_MINIMAL) +                    { +                        gPipeline.andRenderTypeMask( +                            LLPipeline::RENDER_TYPE_SKY, +                            LLPipeline::RENDER_TYPE_WL_SKY, +                            LLPipeline::RENDER_TYPE_CLOUDS, +                            LLPipeline::END_RENDER_TYPES); +                    } +                    else +                    { +                        gPipeline.andRenderTypeMask( +                            LLPipeline::RENDER_TYPE_SKY, +                            LLPipeline::RENDER_TYPE_WL_SKY, +                            LLPipeline::END_RENDER_TYPES); +                    }                      updateCull(camera, mSky);                      stateSort(camera, mSky); -						renderGeom(camera, TRUE); - -					gPipeline.popRenderTypeMask(); -				} +                    renderGeom(camera, TRUE); +                } +                gPipeline.popRenderTypeMask(); -				gPipeline.pushRenderTypeMask(); +                if (reflection_detail >= WATER_REFLECT_NONE_WATER_TRANSPARENT) +                { +                    gPipeline.pushRenderTypeMask(); +                    { +                        clearRenderTypeMask( +                            LLPipeline::RENDER_TYPE_WATER, +                            LLPipeline::RENDER_TYPE_VOIDWATER, +                            LLPipeline::RENDER_TYPE_GROUND, +                            LLPipeline::RENDER_TYPE_SKY, +                            LLPipeline::RENDER_TYPE_CLOUDS, +                            LLPipeline::END_RENDER_TYPES); + +                        if (reflection_detail > WATER_REFLECT_MINIMAL) +                        { //mask out selected geometry based on reflection detail +                            if (reflection_detail < WATER_REFLECT_EVERYTHING) +                            { +                                clearRenderTypeMask(LLPipeline::RENDER_TYPE_PARTICLES, END_RENDER_TYPES); +                                if (reflection_detail < WATER_REFLECT_AVATARS) +                                { +                                    clearRenderTypeMask( +                                        LLPipeline::RENDER_TYPE_AVATAR, +                                        LLPipeline::RENDER_TYPE_CONTROL_AV, +                                        END_RENDER_TYPES); +                                    if (reflection_detail < WATER_REFLECT_STATIC_OBJECTS) +                                    { +                                        clearRenderTypeMask(LLPipeline::RENDER_TYPE_VOLUME, END_RENDER_TYPES); +                                    } +                                } +                            } -				clearRenderTypeMask(LLPipeline::RENDER_TYPE_WATER, -					LLPipeline::RENDER_TYPE_VOIDWATER, -					LLPipeline::RENDER_TYPE_GROUND, -					LLPipeline::RENDER_TYPE_SKY, -					LLPipeline::RENDER_TYPE_CLOUDS, -					LLPipeline::END_RENDER_TYPES);	 - -				if (detail > 0) -				{ //mask out selected geometry based on reflection detail -					if (detail < 4) -					{ -						clearRenderTypeMask(LLPipeline::RENDER_TYPE_PARTICLES, END_RENDER_TYPES); -						if (detail < 3) -						{ -                            clearRenderTypeMask(LLPipeline::RENDER_TYPE_AVATAR, LLPipeline::RENDER_TYPE_CONTROL_AV, END_RENDER_TYPES); -							if (detail < 2) -							{ -								clearRenderTypeMask(LLPipeline::RENDER_TYPE_VOLUME, END_RENDER_TYPES); -							} -						} -					} +                            LLGLUserClipPlane clip_plane(plane, mReflectionModelView, saved_projection); +                            LLGLDisable cull(GL_CULL_FACE); +                            updateCull(camera, mReflectedObjects, -water_clip, &plane); +                            stateSort(camera, mReflectedObjects); +                            renderGeom(camera); +                        } +                    } +                    gPipeline.popRenderTypeMask(); +                } -                    LLGLUserClipPlane clip_plane(plane, mReflectionModelView, saved_projection); -					LLGLDisable cull(GL_CULL_FACE); -                    updateCull(camera, mReflectedObjects, -water_clip, &plane); -                    stateSort(camera, mReflectedObjects); -							renderGeom(camera); -						} -                gPipeline.popRenderTypeMask();                  mWaterRef.flush(); -				} +            } -			glCullFace(GL_BACK); +            glCullFace(GL_BACK);              gGL.matrixMode(LLRender::MM_MODELVIEW); -			gGL.popMatrix(); -             +            gGL.popMatrix(); +              set_current_modelview(saved_modelview); -		} +        }          //LLPipeline::sUseOcclusion = occlusion; -		camera.setOrigin(camera_in.getOrigin()); -		//render distortion map -		static bool last_update = true; -		if (last_update) -		{ +        camera.setOrigin(camera_in.getOrigin()); +        //render distortion map +        static bool last_update = true; +        if (last_update) +        {              gPipeline.pushRenderTypeMask(); -			camera.setFar(camera_in.getFar()); -			clearRenderTypeMask(LLPipeline::RENDER_TYPE_WATER, -								LLPipeline::RENDER_TYPE_VOIDWATER, -								LLPipeline::RENDER_TYPE_GROUND, -								END_RENDER_TYPES);	 +            camera.setFar(camera_in.getFar()); +            clearRenderTypeMask( +                LLPipeline::RENDER_TYPE_WATER, +                LLPipeline::RENDER_TYPE_VOIDWATER, +                LLPipeline::RENDER_TYPE_GROUND, +                END_RENDER_TYPES);              // intentionally inverted so that distortion map contents (objects under the water when we're above it)              // will properly include water fog effects              LLPipeline::sUnderWaterRender = !camera_is_underwater; -			if (LLPipeline::sUnderWaterRender) -			{ +            if (LLPipeline::sUnderWaterRender) +            {                  clearRenderTypeMask( -                                    LLPipeline::RENDER_TYPE_GROUND, -									LLPipeline::RENDER_TYPE_SKY, -									LLPipeline::RENDER_TYPE_CLOUDS, -									LLPipeline::RENDER_TYPE_WL_SKY, -									END_RENDER_TYPES);		 -			} -			LLViewerCamera::updateFrustumPlanes(camera); +                    LLPipeline::RENDER_TYPE_GROUND, +                    LLPipeline::RENDER_TYPE_SKY, +                    LLPipeline::RENDER_TYPE_CLOUDS, +                    LLPipeline::RENDER_TYPE_WL_SKY, +                    END_RENDER_TYPES); +            } +            LLViewerCamera::updateFrustumPlanes(camera); + +            gGL.getTexUnit(0)->unbind(LLTexUnit::TT_TEXTURE); -			gGL.getTexUnit(0)->unbind(LLTexUnit::TT_TEXTURE); -			              if (LLPipeline::sUnderWaterRender || LLDrawPoolWater::sNeedsDistortionUpdate)              {                  LLPipeline::sDistortionRender = true;                  LLColor3 col = LLEnvironment::instance().getCurrentWater()->getWaterFogColor(); -			glClearColor(col.mV[0], col.mV[1], col.mV[2], 0.f); +                glClearColor(col.mV[0], col.mV[1], col.mV[2], 0.f); + +                LLViewerCamera::sCurCameraID = LLViewerCamera::CAMERA_WATER1; -			LLViewerCamera::sCurCameraID = LLViewerCamera::CAMERA_WATER1; -			                  mWaterDis.bindTarget(); -			mWaterDis.getViewport(gGLViewport); -			 +                mWaterDis.getViewport(gGLViewport); +                  gGL.setColorMask(true, true);                  mWaterDis.clear();                  gGL.setColorMask(true, false); @@ -9479,66 +9492,69 @@ void LLPipeline::generateWaterReflection(LLCamera& camera_in)                  LLPlane plane(-pnorm, water_dist);                  LLGLUserClipPlane clip_plane(plane, saved_modelview, saved_projection); -				gGL.setColorMask(true, true); -				mWaterDis.clear(); -				gGL.setColorMask(true, false); +                gGL.setColorMask(true, true); +                mWaterDis.clear(); +                gGL.setColorMask(true, false);                  // ignore clip plane if we're underwater and viewing distortion map of objects above waterline                  if (camera_is_underwater) -				{ +                {                      clip_plane.disable(); -				} +                } -                updateCull(camera, mRefractedObjects, water_clip, &plane); -                stateSort(camera, mRefractedObjects); -					renderGeom(camera); +                if (reflection_detail >= WATER_REFLECT_NONE_WATER_TRANSPARENT) +                { +                    updateCull(camera, mRefractedObjects, water_clip, &plane); +                    stateSort(camera, mRefractedObjects); +                    renderGeom(camera); +                } -					if (LLGLSLShader::sNoFixedFunction) -					{ -						gUIProgram.bind(); -					} -					 -					LLWorld::getInstance()->renderPropertyLines(); -					 -					if (LLGLSLShader::sNoFixedFunction) -					{ -						gUIProgram.unbind(); -					} +                if (LLGLSLShader::sNoFixedFunction) +                { +                    gUIProgram.bind(); +                } + +                LLWorld::getInstance()->renderPropertyLines(); + +                if (LLGLSLShader::sNoFixedFunction) +                { +                    gUIProgram.unbind(); +                }                  mWaterDis.flush(); -			} +            }              LLPipeline::sDistortionRender = false; -			 +              gPipeline.popRenderTypeMask(); -		} -		last_update = LLDrawPoolWater::sNeedsReflectionUpdate && LLDrawPoolWater::sNeedsDistortionUpdate; +        } +        last_update = LLDrawPoolWater::sNeedsReflectionUpdate && LLDrawPoolWater::sNeedsDistortionUpdate;          gPipeline.popRenderTypeMask();          LLPipeline::sUseOcclusion     = occlusion;          LLPipeline::sUnderWaterRender = false; -		LLPipeline::sReflectionRender = false; +        LLPipeline::sReflectionRender = false;          LLDrawPoolWater::sNeedsReflectionUpdate = FALSE;          LLDrawPoolWater::sNeedsDistortionUpdate = FALSE; -		if (!LLRenderTarget::sUseFBO) -		{ -			glClear(GL_DEPTH_BUFFER_BIT); -		} -		glClearColor(0.f, 0.f, 0.f, 0.f); -		gViewerWindow->setup3DViewport(); -		 -		LLGLState::checkStates(); +        if (!LLRenderTarget::sUseFBO) +        { +            glClear(GL_DEPTH_BUFFER_BIT); +        } +        glClearColor(0.f, 0.f, 0.f, 0.f); +        gViewerWindow->setup3DViewport(); -		if (!skip_avatar_update) -		{ -			gAgentAvatarp->updateAttachmentVisibility(gAgentCamera.getCameraMode()); -		} +        LLGLState::checkStates(); -		LLViewerCamera::sCurCameraID = LLViewerCamera::CAMERA_WORLD; -	} +        if (!skip_avatar_update) +        { +            gAgentAvatarp->updateAttachmentVisibility(gAgentCamera.getCameraMode()); +        } + +        LLViewerCamera::sCurCameraID = LLViewerCamera::CAMERA_WORLD; +    }  }  glh::matrix4f look(const LLVector3 pos, const LLVector3 dir, const LLVector3 up) diff --git a/indra/newview/pipeline.h b/indra/newview/pipeline.h index 52fd51cd80..0eaa6b141d 100644 --- a/indra/newview/pipeline.h +++ b/indra/newview/pipeline.h @@ -414,10 +414,6 @@ public:  	static void updateRenderDeferred();  	static void refreshCachedSettings(); -	static void throttleNewMemoryAllocation(bool disable); - -	 -  	void addDebugBlip(const LLVector3& position, const LLColor4& color);  	void hidePermanentObjects( std::vector<U32>& restoreList ); @@ -600,7 +596,6 @@ public:  	static bool				sRenderAttachedLights;  	static bool				sRenderAttachedParticles;  	static bool				sRenderDeferred; -	static bool             sMemAllocationThrottled;  	static S32				sVisibleLightCount;  	static F32				sMinRenderSize;  	static bool				sRenderingHUDs; diff --git a/indra/newview/skins/default/colors.xml b/indra/newview/skins/default/colors.xml index e1cf708094..efe8102f83 100644 --- a/indra/newview/skins/default/colors.xml +++ b/indra/newview/skins/default/colors.xml @@ -337,6 +337,9 @@       name="ContextSilhouetteColor"       reference="EmphasisColor" />      <color +     name="ConversationFriendColor" +     value="0.42 0.85 0.71 1" /> +    <color       name="DefaultHighlightDark"       reference="White_10" />      <color diff --git a/indra/newview/skins/default/xui/en/floater_buy_object.xml b/indra/newview/skins/default/xui/en/floater_buy_object.xml index 49be4290c7..1f7d52dbf5 100644 --- a/indra/newview/skins/default/xui/en/floater_buy_object.xml +++ b/indra/newview/skins/default/xui/en/floater_buy_object.xml @@ -32,6 +32,10 @@       name="no_transfer_text">          (no transfer)      </floater.string> +    <floater.string +      name="mupliple_selected"> +        Mupliple selection +    </floater.string>      <scroll_list       background_visible="true"       draw_border="false" diff --git a/indra/newview/skins/default/xui/en/floater_im_session.xml b/indra/newview/skins/default/xui/en/floater_im_session.xml index c64ee5565a..15f02ab9c3 100644 --- a/indra/newview/skins/default/xui/en/floater_im_session.xml +++ b/indra/newview/skins/default/xui/en/floater_im_session.xml @@ -267,6 +267,36 @@                   right="-1">                      <layout_panel                       name="input_editor_layout_panel"> +                        <avatar_icon +                         follows="left|bottom" +                         name="avatar_icon" +                         height="20" +                         default_icon_name="Generic_Person" +                         layout="topleft" +                         left="3" +                         bottom="-9" +                         visible="false" +                         width="20" /> +                        <group_icon +                         follows="left|bottom" +                         name="group_chat_icon" +                         height="20" +                         default_icon_name="Generic_Group" +                         layout="topleft" +                         left="3" +                         bottom="-9" +                         visible="false" +                         width="20" /> +                        <icon +                         follows="left|bottom" +                         height="20" +                         image_name="Nearby_chat_icon" +                         layout="topleft" +                         left="3" +                         bottom="-9" +                         name="nearby_chat_icon" +                         visible="false" +                         width="20"/>                          <chat_editor                           layout="topleft"                           expand_lines_count="5" @@ -280,7 +310,7 @@                           spellcheck="true"                           tab_group="3"                           bottom="-8" -                         left="5" +                         left_pad="5"                           right="-5"                           wrap="true" />                      </layout_panel> diff --git a/indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml b/indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml index e282f1b179..3cc99b28c9 100644 --- a/indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml +++ b/indra/newview/skins/default/xui/en/floater_preferences_graphics_advanced.xml @@ -724,6 +724,14 @@      name="Reflections"      width="150">        <combo_box.item +        label="None; opaque" +        name="0" +        value="-2"/> +      <combo_box.item +        label="None; transparent" +        name="0" +        value="-1"/> +      <combo_box.item          label="Minimal"          name="0"          value="0"/> diff --git a/indra/newview/skins/default/xui/en/floater_publish_classified.xml b/indra/newview/skins/default/xui/en/floater_publish_classified.xml index 322e34272c..84e0b489d0 100644 --- a/indra/newview/skins/default/xui/en/floater_publish_classified.xml +++ b/indra/newview/skins/default/xui/en/floater_publish_classified.xml @@ -6,6 +6,7 @@   layout="topleft"   name="publish_classified"   title="Publishing Classified" + help_topic="profile_edit_classified"   width="320">      <text       top="20" diff --git a/indra/newview/skins/default/xui/en/notifications.xml b/indra/newview/skins/default/xui/en/notifications.xml index 1313632803..ff2d6c0d84 100644 --- a/indra/newview/skins/default/xui/en/notifications.xml +++ b/indra/newview/skins/default/xui/en/notifications.xml @@ -4039,6 +4039,8 @@ Finished download of raw terrain file to:  [DOWNLOAD_PATH].    </notification> +  <!-- RequiredUpdate does not display release notes URL because we don't get +       that from login.cgi's login failure message. -->    <notification     icon="alertmodal.tga"     name="RequiredUpdate" @@ -4056,6 +4058,8 @@ Please download from https://secondlife.com/support/downloads/     name="PauseForUpdate"     type="alertmodal">  Version [VERSION] is required for login. +Release notes: [URL] +  Click OK to download and install.      <tag>confirm</tag>      <usetemplate @@ -4068,6 +4072,8 @@ Click OK to download and install.     name="OptionalUpdateReady"     type="alertmodal">  Version [VERSION] has been downloaded and is ready to install. +Release notes: [URL] +  Click OK to install.      <tag>confirm</tag>      <usetemplate @@ -4080,6 +4086,8 @@ Click OK to install.     name="PromptOptionalUpdate"     type="alertmodal">  Version [VERSION] has been downloaded and is ready to install. +Release notes: [URL] +  Proceed?      <tag>confirm</tag>      <usetemplate @@ -9603,6 +9611,12 @@ You do not appear to have the proper hardware requirements for [APP_NAME]. [APP_  If you continue to have problems, please visit the [SUPPORT_SITE].    </global> +  <global name="UnsupportedIntelDriver"> +The installed Intel graphics driver for [GPUNAME], version [VERSION], is significantly out of date and is known to cause excessive rates of program crashes. You are strongly advised to update to a current Intel driver + +Do you want to check the Intel driver website? +  </global> +    <global name="UnsupportedCPUAmount">  796    </global> diff --git a/indra/newview/skins/default/xui/en/strings.xml b/indra/newview/skins/default/xui/en/strings.xml index a6116dc9be..440e8b140f 100644 --- a/indra/newview/skins/default/xui/en/strings.xml +++ b/indra/newview/skins/default/xui/en/strings.xml @@ -2299,6 +2299,7 @@ For AI Character: Get the closest navigable point to the point provided.  	<string name="InventoryNoMatchingRecentItems">Didn't find what you're looking for? Try [secondlife:///app/inventory/filters Show filters].</string>  	<string name="PlacesNoMatchingItems">Didn't find what you're looking for? Try [secondlife:///app/search/places/[SEARCH_TERM] Search].</string>  	<string name="FavoritesNoMatchingItems">Drag a landmark here to add it to your favorites.</string> +	<string name="MarketplaceNoListing">You have no listings yet.</string>  	<string name="MarketplaceNoMatchingItems">No items found. Check the spelling of your search string and try again.</string>  	<string name="InventoryNoTexture">You do not have a copy of this texture in your inventory</string>  	<string name="InventoryInboxNoItems">Your Marketplace purchases will appear here. You may then drag them into your inventory to use them.</string> @@ -3693,10 +3694,10 @@ If you continue to receive this message, contact the [SUPPORT_SITE].    Also there are some other places where "generic" is used.    So, let add string with name="generic" with the same value as "generic_request_error" -->    <string name="generic"> -    Error making request, please try again later. +    Please close and reopen the conversation, or relog and try again.    </string>    <string name="generic_request_error"> -    Error making request, please try again later. +    Please close and reopen the conversation, or relog and try again.    </string>    <string name="insufficient_perms_error">      You do not have sufficient permissions. diff --git a/indra/newview/tests/lllogininstance_test.cpp b/indra/newview/tests/lllogininstance_test.cpp index 57f2d31eab..f9abc8b25d 100644 --- a/indra/newview/tests/lllogininstance_test.cpp +++ b/indra/newview/tests/lllogininstance_test.cpp @@ -41,6 +41,7 @@  #include "../test/lltut.h"  #include "llevents.h"  #include "llnotificationsutil.h" +#include "lltrans.h"  #if defined(LL_WINDOWS)  #pragma warning(disable: 4355)      // using 'this' in base-class ctor initializer expr @@ -77,6 +78,11 @@ void LLViewerWindow::setShowProgress(BOOL show) {}  LLProgressView * LLViewerWindow::getProgressView(void) const { return 0; }  LLViewerWindow* gViewerWindow; + +std::string LLTrans::getString(const std::string &xml_desc, const LLStringUtil::format_map_t& args, bool def_string) +{ +    return std::string("test_trans"); +}  class LLLogin::Impl  { diff --git a/indra/newview/viewer_manifest.py b/indra/newview/viewer_manifest.py index 6d231040f7..adac7af712 100755 --- a/indra/newview/viewer_manifest.py +++ b/indra/newview/viewer_manifest.py @@ -533,6 +533,9 @@ class WindowsManifest(ViewerManifest):              # For textures              self.path("openjpeg.dll") +            # Uriparser +            self.path("uriparser.dll") +              # These need to be installed as a SxS assembly, currently a 'private' assembly.              # See http://msdn.microsoft.com/en-us/library/ms235291(VS.80).aspx              self.path("msvcp140.dll") @@ -1035,6 +1038,7 @@ class DarwinManifest(ViewerManifest):                                  # libnghttp2.major.dylib, which is a symlink to                                  # libnghttp2.version.dylib. Get all of them.                                  "libnghttp2.*dylib", +                                "liburiparser.*dylib",                                  ):                      dylibs += path_optional(os.path.join(relpkgdir, libfile), libfile) | 
