EXT-3144 EXT-4226: Re-employ tentative state for individual items in media settings

Review #95

This change undoes some prior change that seems to not allow showing
media data for multiple selection. There was all of this code put in
to support displaying tentative state for media, but code was added to
basically override it. Perhaps the reason was tentative state items
were not ignored on apply...this change does that.

1 files changed, 57 insertions, 38 deletions

diff --git a/indra/newview/llpanelmediasettingspermissions.cpp b/indra/newview/llpanelmediasettingspermissions.cpp
index a23aed2e98..e5caaaaffc 100644
--- a/indra/newview/llpanelmediasettingspermissions.cpp
+++ b/indra/newview/llpanelmediasettingspermissions.cpp
@@ -149,27 +149,6 @@ void LLPanelMediaSettingsPermissions::clearValues( void* userdata, bool editable
 void LLPanelMediaSettingsPermissions::initValues( void* userdata, const LLSD& media_settings ,  bool editable)
 {
     LLPanelMediaSettingsPermissions *self =(LLPanelMediaSettingsPermissions *)userdata;
-
-	if ( LLFloaterMediaSettings::getInstance()->mIdenticalHasMediaInfo )
-	{
-		if(LLFloaterMediaSettings::getInstance()->mMultipleMedia) 
-		{
-			self->clearValues(self, editable);
-			// only show multiple 
-			return;
-		}
-		
-	}
-	else
-	{
-		if(LLFloaterMediaSettings::getInstance()->mMultipleValidMedia) 
-		{
-			self->clearValues(self, editable);
-			// only show multiple 
-			return;
-		}			
-		
-	}
     std::string base_key( "" );
     std::string tentative_key( "" );
 
@@ -215,7 +194,29 @@ void LLPanelMediaSettingsPermissions::initValues( void* userdata, const LLSD& me
             data_set[ i ].ctrl_ptr->setTentative( media_settings[ tentative_key ].asBoolean() );
         };
     };
-
+	
+	// *NOTE: If any of a particular flavor is tentative, we have to disable 
+	// them all because of an architectural issue: namely that we represent 
+	// these as a bit field, and we can't selectively apply only one bit to all selected
+	// faces if they don't match.  Also see the *NOTE below.
+	if ( self->mPermsOwnerInteract->getTentative() ||
+		 self->mPermsGroupInteract->getTentative() ||
+		 self->mPermsWorldInteract->getTentative())
+	{
+		self->mPermsOwnerInteract->setEnabled(false);
+		self->mPermsGroupInteract->setEnabled(false);
+		self->mPermsWorldInteract->setEnabled(false);
+	}	
+	if ( self->mPermsOwnerControl->getTentative() ||
+		 self->mPermsGroupControl->getTentative() ||
+		 self->mPermsWorldControl->getTentative())
+	{
+		self->mPermsOwnerControl->setEnabled(false);
+		self->mPermsGroupControl->setEnabled(false);
+		self->mPermsWorldControl->setEnabled(false);
+	}
+	
+	
 	self->childSetEnabled("media_perms_label_owner", editable );
 	self->childSetText("media_perms_label_owner",  LLTrans::getString("Media Perms Owner") );
 	self->childSetEnabled("media_perms_label_group", editable );
@@ -233,29 +234,47 @@ void LLPanelMediaSettingsPermissions::preApply()
 
 ////////////////////////////////////////////////////////////////////////////////
 //
-void LLPanelMediaSettingsPermissions::getValues( LLSD &fill_me_in )
+void LLPanelMediaSettingsPermissions::getValues( LLSD &fill_me_in, bool include_tentative )
 {
 	// moved over from the 'General settings' tab
-	fill_me_in[LLMediaEntry::CONTROLS_KEY] = (LLSD::Integer)mControls->getCurrentIndex();
-
-    // *NOTE: For some reason, gcc does not like these symbol references in the 
-    // expressions below (inside the static_casts).  I have NO idea why :(.
-    // For some reason, assigning them to const temp vars here fixes the link
-    // error.  Bizarre.
-    const U8 none = LLMediaEntry::PERM_NONE;
-    const U8 owner = LLMediaEntry::PERM_OWNER;
-    const U8 group = LLMediaEntry::PERM_GROUP;
-    const U8 anyone = LLMediaEntry::PERM_ANYONE;
-    const LLSD::Integer control = static_cast<LLSD::Integer>(
+	if (include_tentative || !mControls->getTentative()) fill_me_in[LLMediaEntry::CONTROLS_KEY] = (LLSD::Integer)mControls->getCurrentIndex();
+	
+	// *NOTE: For some reason, gcc does not like these symbol references in the 
+	// expressions below (inside the static_casts).	 I have NO idea why :(.
+	// For some reason, assigning them to const temp vars here fixes the link
+	// error.  Bizarre.
+	const U8 none = LLMediaEntry::PERM_NONE;
+	const U8 owner = LLMediaEntry::PERM_OWNER;
+	const U8 group = LLMediaEntry::PERM_GROUP;
+	const U8 anyone = LLMediaEntry::PERM_ANYONE; 
+	const LLSD::Integer control = static_cast<LLSD::Integer>(
 		(mPermsOwnerControl->getValue() ? owner : none ) |
 		(mPermsGroupControl->getValue() ? group: none  ) |
 		(mPermsWorldControl->getValue() ? anyone : none ));
-    const LLSD::Integer interact = static_cast<LLSD::Integer>(
-		(mPermsOwnerInteract->getValue() ? owner: none  ) |
+	const LLSD::Integer interact = static_cast<LLSD::Integer>(
+		(mPermsOwnerInteract->getValue() ? owner: none	) |
 		(mPermsGroupInteract->getValue() ? group : none ) |
 		(mPermsWorldInteract->getValue() ? anyone : none ));
-    fill_me_in[LLMediaEntry::PERMS_CONTROL_KEY] = control;
-    fill_me_in[LLMediaEntry::PERMS_INTERACT_KEY] = interact;
+	
+	// *TODO: This will fill in the values of all permissions values, even if
+	// one or more is tentative.  This is not quite the user expectation...what
+	// it should do is only change the bit that was made "untentative", but in
+	// a multiple-selection situation, this isn't possible given the architecture
+	// for how settings are applied.
+	if (include_tentative || 
+		!mPermsOwnerControl->getTentative() || 
+		!mPermsGroupControl->getTentative() || 
+		!mPermsWorldControl->getTentative())
+	{
+		fill_me_in[LLMediaEntry::PERMS_CONTROL_KEY] = control;
+	}
+	if (include_tentative || 
+		!mPermsOwnerInteract->getTentative() || 
+		!mPermsGroupInteract->getTentative() || 
+		!mPermsWorldInteract->getTentative())
+	{
+		fill_me_in[LLMediaEntry::PERMS_INTERACT_KEY] = interact;
+	}
 }