MAINT-5691: Browser was using deprecated outbox display type AND not correctly returning error body to application.

LLCore:HTTP now will provide and LLSD translation of the message body when possible in the case of an error HTTP result
VMM alert boxes now use type="alertmodal" rather than "outbox"

1 files changed, 0 insertions, 15 deletions

diff --git a/indra/newview/llappearancemgr.cpp b/indra/newview/llappearancemgr.cpp
index 720a4ff2df..025009d40b 100755
--- a/indra/newview/llappearancemgr.cpp
+++ b/indra/newview/llappearancemgr.cpp
@@ -3440,21 +3440,6 @@ void LLAppearanceMgr::serverAppearanceUpdateCoro()
 
         if (!status || !result["success"].asBoolean())
         {
-            if (httpResults.has("error_body"))
-            {
-                std::istringstream bodystream(httpResults["error_body"].asStringRef());
-                LLSD body_llsd;
-
-                if (LLSDSerialize::fromXML(body_llsd, bodystream, true) == LLSDParser::PARSE_FAILURE)
-                {
-                    LL_WARNS() << "Unable to parse body as LLSD" << LL_ENDL;
-                }
-                else
-                {
-                    result = body_llsd;
-                }
-            }
-
             std::string message = (result.has("error")) ? result["error"].asString() : status.toString();
             LL_WARNS("Avatar") << "Appearance Failure. server responded with \"" << message << "\"" << LL_ENDL;