summaryrefslogtreecommitdiff
path: root/indra/llwebrtc
diff options
context:
space:
mode:
authorRoxie Linden <roxie@lindenlab.com>2024-04-07 19:23:00 -0700
committerRoxie Linden <roxie@lindenlab.com>2024-04-07 19:23:00 -0700
commit648741470f67120d99aec3a4aeceeaf4395cca09 (patch)
treed6afcd0bc1cf2c86e5f5a668749c01c14bf04da2 /indra/llwebrtc
parent4be63d8c1f56fb6d00f13b9a2d84f2d58e170344 (diff)
CR suggestions
Diffstat (limited to 'indra/llwebrtc')
-rw-r--r--indra/llwebrtc/llwebrtc.cpp19
-rw-r--r--indra/llwebrtc/llwebrtc.h7
2 files changed, 6 insertions, 20 deletions
diff --git a/indra/llwebrtc/llwebrtc.cpp b/indra/llwebrtc/llwebrtc.cpp
index 57130bb734..eb9bb65e67 100644
--- a/indra/llwebrtc/llwebrtc.cpp
+++ b/indra/llwebrtc/llwebrtc.cpp
@@ -515,16 +515,6 @@ void LLWebRTCImpl::updateDevices()
char name[webrtc::kAdmMaxDeviceNameSize];
char guid[webrtc::kAdmMaxGuidSize];
mTuningDeviceModule->PlayoutDeviceName(index, name, guid);
-
-#if WEBRTC_LINUX
- // Linux audio implementation (pulse and alsa)
- // return empty strings for the guid, so
- // use the name for the guid
- if (!strcmp(guid, ""))
- {
- strcpy(guid, name);
- }
-#endif // WEBRTC_LINUX
mPlayoutDeviceList.emplace_back(name, guid);
}
@@ -543,15 +533,6 @@ void LLWebRTCImpl::updateDevices()
char name[webrtc::kAdmMaxDeviceNameSize];
char guid[webrtc::kAdmMaxGuidSize];
mTuningDeviceModule->RecordingDeviceName(index, name, guid);
-#if WEBRTC_LINUX
- // Linux audio implementation (pulse and alsa)
- // return empty strings for the guid, so
- // use the name for the guid
- if (!strcmp(guid, ""))
- {
- strcpy(guid, name);
- }
-#endif // WEBRTC_LINUX
mRecordingDeviceList.emplace_back(name, guid);
}
diff --git a/indra/llwebrtc/llwebrtc.h b/indra/llwebrtc/llwebrtc.h
index 8830799cde..ac71e0c744 100644
--- a/indra/llwebrtc/llwebrtc.h
+++ b/indra/llwebrtc/llwebrtc.h
@@ -78,7 +78,12 @@ class LLWebRTCVoiceDevice
LLWebRTCVoiceDevice(const std::string &display_name, const std::string &id) :
mDisplayName(display_name),
mID(id)
- {};
+ {
+ if (mID.empty())
+ {
+ mID = display_name;
+ }
+ };
};
typedef std::vector<LLWebRTCVoiceDevice> LLWebRTCVoiceDeviceList;