MAINT-5271: Converted internal pointers to internal operation to managed shared pointers. Removed direct cast and dereference of handles.

2 files changed, 23 insertions, 22 deletions

diff --git a/indra/llcorehttp/tests/test_httpoperation.hpp b/indra/llcorehttp/tests/test_httpoperation.hpp
index 890e5fdd9c..e7df2337de 100755
--- a/indra/llcorehttp/tests/test_httpoperation.hpp
+++ b/indra/llcorehttp/tests/test_httpoperation.hpp
@@ -76,12 +76,12 @@ namespace tut
 		mMemTotal = GetMemTotal();
 
 		// create a new ref counted object with an implicit reference
-		HttpOpNull * op = new HttpOpNull();
-		ensure(op->getRefCount() == 1);
+		HttpOperation::ptr_t op (new HttpOpNull());
+		ensure(op.use_count() == 1);
 		ensure(mMemTotal < GetMemTotal());
 		
 		// release the implicit reference, causing the object to be released
-		op->release();
+        op.reset();
 
 		// make sure we didn't leak any memory
 		ensure(mMemTotal == GetMemTotal());
@@ -99,18 +99,17 @@ namespace tut
 		LLCore::HttpHandler::ptr_t h1 (new TestHandler());
 		
 		// create a new ref counted object with an implicit reference
-		HttpOpNull * op = new HttpOpNull();
+		HttpOperation::ptr_t op (new HttpOpNull());
 
 		// Add the handlers
 		op->setReplyPath(LLCore::HttpOperation::HttpReplyQueuePtr_t(), h1);
 
 		// Check ref count
-		ensure(op->getRefCount() == 1);
+		ensure(op.unique() == 1);
 
 		// release the reference, releasing the operation but
 		// not the handlers.
-		op->release();
-		op = NULL;
+        op.reset();
 		ensure(mMemTotal != GetMemTotal());
 		
 		// release the handlers
diff --git a/indra/llcorehttp/tests/test_httprequestqueue.hpp b/indra/llcorehttp/tests/test_httprequestqueue.hpp
index 1de2d8f9ab..ef4ce0479b 100755
--- a/indra/llcorehttp/tests/test_httprequestqueue.hpp
+++ b/indra/llcorehttp/tests/test_httprequestqueue.hpp
@@ -113,16 +113,16 @@ void HttpRequestqueueTestObjectType::test<3>()
 
 	HttpRequestQueue * rq = HttpRequestQueue::instanceOf();
 
-	HttpOperation * op = new HttpOpNull();
+	HttpOperation::ptr_t op(new HttpOpNull());
 
 	rq->addOp(op);		// transfer my refcount
 
 	op = rq->fetchOp(true);		// Potentially hangs the test on failure
-	ensure("One goes in, one comes out", NULL != op);
-	op->release();
+	ensure("One goes in, one comes out", static_cast<bool>(op));
+    op.reset();
 
 	op = rq->fetchOp(false);
-	ensure("Better not be two of them", NULL == op);
+	ensure("Better not be two of them", !op);
 	
 	// release the singleton, hold on to the object
 	HttpRequestQueue::term();
@@ -144,13 +144,13 @@ void HttpRequestqueueTestObjectType::test<4>()
 
 	HttpRequestQueue * rq = HttpRequestQueue::instanceOf();
 
-	HttpOperation * op = new HttpOpNull();
+	HttpOperation::ptr_t op (new HttpOpNull());
 	rq->addOp(op);		// transfer my refcount
 
-	op = new HttpOpNull();
+	op.reset(new HttpOpNull());
 	rq->addOp(op);		// transfer my refcount
 
-	op = new HttpOpNull();
+	op.reset(new HttpOpNull());
 	rq->addOp(op);		// transfer my refcount
 	
 	{
@@ -159,8 +159,9 @@ void HttpRequestqueueTestObjectType::test<4>()
 		ensure("Three go in, three come out", 3 == ops.size());
 
 		op = rq->fetchOp(false);
-		ensure("Better not be any more of them", NULL == op);
-	
+		ensure("Better not be any more of them", !op);
+        op.reset();
+
 		// release the singleton, hold on to the object
 		HttpRequestQueue::term();
 	
@@ -168,12 +169,13 @@ void HttpRequestqueueTestObjectType::test<4>()
 		ensure(mMemTotal < GetMemTotal());
 
 		// Release them
-		while (! ops.empty())
-		{
-			HttpOperation * op = ops.front();
-			ops.erase(ops.begin());
-			op->release();
-		}
+        ops.clear();
+// 		while (! ops.empty())
+// 		{
+// 			HttpOperation * op = ops.front();
+// 			ops.erase(ops.begin());
+// 			op->release();
+// 		}
 	}
 
 	// Should be clean