Pass std::string_view by value, not by const reference.

Consensus seems to be that (a) string_view is, in effect, already a reference,
(b) it's small enough to make pass-by-value reasonable and (c) the optimizer
can reason about values way better than it can about references.

1 files changed, 1 insertions, 1 deletions

diff --git a/indra/llcommon/llleaplistener.h b/indra/llcommon/llleaplistener.h
index d36d2ff8db..d38a6f4ace 100644
--- a/indra/llcommon/llleaplistener.h
+++ b/indra/llcommon/llleaplistener.h
@@ -28,7 +28,7 @@ public:
      * event is received.
      */
     using Callback = std::function<bool(const std::string& pump, const LLSD& data)>;
-    LLLeapListener(const std::string_view& caller, const Callback& callback);
+    LLLeapListener(std::string_view caller, const Callback& callback);
     ~LLLeapListener();
 
     LLEventPump& getReplyPump() { return mReplyPump; }