diff options
| author | Richard Linden <none@none> | 2010-04-29 18:06:09 -0700 |
|---|---|---|
| committer | Richard Linden <none@none> | 2010-04-29 18:06:09 -0700 |
| commit | f1f07e66e3caaf4f633592f7d121c4b938899f49 (patch) | |
| tree | cb67790a8b42f34b83888fa406a3b7192b9e3f3c | |
| parent | a0527cb6f728a2814fdf8b0fa6f149c7041efcac (diff) | |
fixed potential buffer overrun in volume code
| -rw-r--r-- | indra/media_plugins/winmmshim/winmm_shim.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/indra/media_plugins/winmmshim/winmm_shim.cpp b/indra/media_plugins/winmmshim/winmm_shim.cpp index f7df3b19a0..54bfa652e9 100644 --- a/indra/media_plugins/winmmshim/winmm_shim.cpp +++ b/indra/media_plugins/winmmshim/winmm_shim.cpp @@ -144,10 +144,11 @@ extern "C" // copy volume level 4 times into 64 bit MMX register __m64 volume_64 = _mm_set_pi16(volume_16, volume_16, volume_16, volume_16); - __m64 *sample_64; + __m64* sample_64; + __m64* last_sample_64 = (__m64*)(pwh->lpData + pwh->dwBufferLength - sizeof(__m64)); // for everything that can be addressed in 64 bit multiples... for (sample_64 = (__m64*)pwh->lpData; - sample_64 < (__m64*)(pwh->lpData + pwh->dwBufferLength); + sample_64 <= last_sample_64; ++sample_64) { //...multiply the samples by the volume... |