MAINT-7533: Stop NSIS installer from pinging secondlife.com.

Specifically, the installer has been hitting
http://install.secondlife.com/check/
In most situations, the installer is run right after the user finishes
downloading it. If s/he can successfully download a big executable, we should
be able to use that network connection.

More to the point, *nothing is done* with the connect result. It serves only
to slow down the viewer installer.

1 files changed, 0 insertions, 36 deletions

diff --git a/indra/newview/installers/windows/installer_template.nsi b/indra/newview/installers/windows/installer_template.nsi
index 4e41d6d083..330e46fe4b 100644
--- a/indra/newview/installers/windows/installer_template.nsi
+++ b/indra/newview/installers/windows/installer_template.nsi
@@ -282,7 +282,6 @@ StrCpy $INSTSHORTCUT "${SHORTCUT}"
 

 Call CheckIfAdministrator		# Make sure the user can install/uninstall

 Call CloseSecondLife			# Make sure Second Life not currently running

-Call CheckNetworkConnection		# Ping secondlife.com

 Call CheckWillUninstallV2		# Check if Second Life is already installed

 

 StrCmp $DO_UNINSTALL_V2 "" PRESERVE_DONE

@@ -531,41 +530,6 @@ Function un.CloseSecondLife
 FunctionEnd

 

 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

-;; Test our connection to secondlife.com

-;; Also allows us to count attempted installs by examining web logs.

-;; *TODO: Return current SL version info and have installer check

-;; if it is up to date.

-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

-Function CheckNetworkConnection

-    Push $0

-    Push $1

-    Push $2	# Option value for GetOptions

-    DetailPrint $(CheckNetworkConnectionDP)

-# Look for a tag value from the stub installer, used for statistics to correlate installs.

-# Default to "" if not found on command line.

-    StrCpy $2 ""

-    ${GetOptions} $COMMANDLINE "/STUBTAG=" $2

-    GetTempFileName $0

-    !define HTTP_TIMEOUT 5000		# Milliseconds

-# Don't show secondary progress bar, this will be quick.

-    NSISdl::download_quiet \

-        /TIMEOUT=${HTTP_TIMEOUT} \

-        "http://install.secondlife.com/check/?stubtag=$2&version=${VERSION_LONG}" \

-        $0

-    Pop $1		# Return value, either "success", "cancel" or an error message

-    ; MessageBox MB_OK "Download result: $1"

-    ; Result ignored for now

-	; StrCmp $1 "success" +2

-	;	DetailPrint "Connection failed: $1"

-    Delete $0	# Temporary file

-    Pop $2

-    Pop $1

-    Pop $0

-    Return

-

-FunctionEnd

-

-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

 ;; Delete files on install if previous install exists to prevent undesired behavior

 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

 Function RemoveProgFilesOnInst