summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrey Kleshchev <117672381+akleshchev@users.noreply.github.com>2025-09-19 01:00:43 +0300
committerAndrey Kleshchev <117672381+akleshchev@users.noreply.github.com>2025-09-19 12:29:27 +0300
commite918d240fd516d9116f0d1c170df34039c63a3ac (patch)
treeac026c8b85e3e3b324103a56cd601eb0441b8eec
parent95725f709d615a9848b3381290276cd9b2254f32 (diff)
#4679 Logging for crash on updateMenuOptions
Logs say that viewer closed settings picker and immediately crashed Yet callstack indicates that some inventory was right clicked, which shouldn't be possible if picker already closed. May be some click is closing the picker and opens menu at the same time, but it's better to gather information first.
-rw-r--r--indra/llui/llfolderview.cpp1
-rw-r--r--indra/newview/llsettingspicker.cpp6
2 files changed, 6 insertions, 1 deletions
diff --git a/indra/llui/llfolderview.cpp b/indra/llui/llfolderview.cpp
index b664065532..db4ab8487e 100644
--- a/indra/llui/llfolderview.cpp
+++ b/indra/llui/llfolderview.cpp
@@ -1510,6 +1510,7 @@ bool LLFolderView::handleRightMouseDown( S32 x, S32 y, MASK mask )
&& ( count > 0 && (hasVisibleChildren()) ))) && // show menu only if selected items are visible
!hide_folder_menu)
{
+ LL_INFOS("Inventory") << "Opening inventory menu from path: " << getPathname() << LL_ENDL;
if (mCallbackRegistrar)
{
mCallbackRegistrar->pushScope();
diff --git a/indra/newview/llsettingspicker.cpp b/indra/newview/llsettingspicker.cpp
index 619882dc5e..5fc39b0dd8 100644
--- a/indra/newview/llsettingspicker.cpp
+++ b/indra/newview/llsettingspicker.cpp
@@ -152,7 +152,11 @@ void LLFloaterSettingsPicker::onClose(bool app_quitting)
owner->setFocus(true);
}
mSettingItemID.setNull();
- mInventoryPanel->getRootFolder()->clearSelection();
+ mInventoryPanel->clearSelection();
+ if (mInventoryPanel->getRootFolder())
+ {
+ mInventoryPanel->getRootFolder()->clearSelection();
+ }
}
void LLFloaterSettingsPicker::setValue(const LLSD& value)