summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Yap <none@none>2013-11-27 10:43:02 -0500
committerJonathan Yap <none@none>2013-11-27 10:43:02 -0500
commitbb68d6a889b339690a90a7e622daa632c9e6fd7e (patch)
tree18dbb149bc5bec538334634b34f334c244e2d0c5
parentdb8e4824e7f00516142461fa25616e3527007d66 (diff)
STORM-1986 Eliminated early return per code review
-rwxr-xr-xindra/newview/llinventorybridge.cpp16
1 files changed, 7 insertions, 9 deletions
diff --git a/indra/newview/llinventorybridge.cpp b/indra/newview/llinventorybridge.cpp
index f65e28a165..44943d8722 100755
--- a/indra/newview/llinventorybridge.cpp
+++ b/indra/newview/llinventorybridge.cpp
@@ -1473,16 +1473,14 @@ void LLItemBridge::doShowOnMap(LLLandmark* landmark)
{
LLVector3d landmark_global_pos;
// landmark has already been tested for NULL by calling routine
- if (!landmark->getGlobalPos(landmark_global_pos))
+ if (landmark->getGlobalPos(landmark_global_pos))
{
- return;
- }
-
- LLFloaterWorldMap* worldmap_instance = LLFloaterWorldMap::getInstance();
- if (!landmark_global_pos.isExactlyZero() && worldmap_instance)
- {
- worldmap_instance->trackLocation(landmark_global_pos);
- LLFloaterReg::showInstance("world_map", "center");
+ LLFloaterWorldMap* worldmap_instance = LLFloaterWorldMap::getInstance();
+ if (!landmark_global_pos.isExactlyZero() && worldmap_instance)
+ {
+ worldmap_instance->trackLocation(landmark_global_pos);
+ LLFloaterReg::showInstance("world_map", "center");
+ }
}
}