diff options
| author | Callum Prentice <callum@lindenlab.com> | 2023-01-26 14:45:45 -0800 | 
|---|---|---|
| committer | Kitty Barnett <develop@catznip.com> | 2023-02-14 17:01:22 +0100 | 
| commit | 547c0665eaa19b6a2b5112faeae75e3a270b7a36 (patch) | |
| tree | 930755196559c57b629eee54129774edc7e2bfe5 | |
| parent | 4df2c0b8d67af267d3c9c6d58d63df3ed063a89e (diff) | |
DRTVWR-489-emoji: As part of the work to get macOS version of the Viewer working, the flag was introduced to warn (and therefore error out) when a virtual override was not marked with the 'override' keyword. Fixing this up involved a large number of changes and this commit represents just those changes - nothing specially from the DRTVWR-489 viewer
(Cherry pick of 3 commits from Callum to declutter the emoji PR: 3185bdea27b19e155c2ccc03c80624e113d312a6,
923733e591eb547ad5dfec395ce7d3e8f0468c16 and 6f31fabbc2d082b77c8f09bce30234ec9c506e33)
54 files changed, 273 insertions, 296 deletions
diff --git a/indra/llappearance/llwearabletype.h b/indra/llappearance/llwearabletype.h index 793a33cc87..1fbe19ddd1 100644 --- a/indra/llappearance/llwearabletype.h +++ b/indra/llappearance/llwearabletype.h @@ -37,7 +37,7 @@ class LLWearableType : public LLParamSingleton<LLWearableType>  {  	LLSINGLETON(LLWearableType, LLTranslationBridge::ptr_t &trans);  	~LLWearableType(); -	void initSingleton(); +	void initSingleton() override;  public:   	enum EType  	{ diff --git a/indra/llcommon/llcoros.h b/indra/llcommon/llcoros.h index 966ce03296..fd878f20ad 100644 --- a/indra/llcommon/llcoros.h +++ b/indra/llcommon/llcoros.h @@ -92,7 +92,7 @@ class LL_COMMON_API LLCoros: public LLSingleton<LLCoros>      LLSINGLETON(LLCoros);      ~LLCoros(); -    void cleanupSingleton(); +    void cleanupSingleton() override;  public:      /// The viewer's use of the term "coroutine" became deeply embedded before      /// the industry term "fiber" emerged to distinguish userland threads from diff --git a/indra/llcommon/llsingleton.h b/indra/llcommon/llsingleton.h index 51ef514cf7..cbe5ab6406 100644 --- a/indra/llcommon/llsingleton.h +++ b/indra/llcommon/llsingleton.h @@ -802,7 +802,7 @@ public:  private:                                                                \      /* implement LLSingleton pure virtual method whose sole purpose */  \      /* is to remind people to use this macro */                         \ -    virtual void you_must_use_LLSINGLETON_macro() {}                    \ +    virtual void you_must_use_LLSINGLETON_macro() override {}                    \      friend class LLSingleton<DERIVED_CLASS>;                            \      DERIVED_CLASS(__VA_ARGS__) diff --git a/indra/llcommon/tests/llsingleton_test.cpp b/indra/llcommon/tests/llsingleton_test.cpp index 15ffe68e67..6f8aaaa0cb 100644 --- a/indra/llcommon/tests/llsingleton_test.cpp +++ b/indra/llcommon/tests/llsingleton_test.cpp @@ -47,8 +47,8 @@ public:                                             \          DEP_INIT  /* dependency in initSingleton */ \      } sDepFlag;                                     \                                                      \ -    void initSingleton();                           \ -    void cleanupSingleton();                        \ +    void initSingleton() override;                  \ +    void cleanupSingleton() override;               \  };                                                  \                                                      \  CLS::dep_flag CLS::sDepFlag = DEP_NONE @@ -300,7 +300,7 @@ namespace tut      {          LLSINGLETON_EMPTY_CTOR(CircularPInit);      public: -        virtual void initSingleton() +        virtual void initSingleton() override          {              // never mind indirection, just go straight for the circularity              CircularPInit *pt = getInstance(); diff --git a/indra/llinventory/llfoldertype.cpp b/indra/llinventory/llfoldertype.cpp index 675da65af2..818a8b5cc3 100644 --- a/indra/llinventory/llfoldertype.cpp +++ b/indra/llinventory/llfoldertype.cpp @@ -60,7 +60,7 @@ class LLFolderDictionary : public LLSingleton<LLFolderDictionary>,  {  	LLSINGLETON(LLFolderDictionary);  protected: -	virtual LLFolderType::EType notFound() const +	virtual LLFolderType::EType notFound() const override  	{  		return LLFolderType::FT_NONE;  	} diff --git a/indra/llinventory/llinventorysettings.cpp b/indra/llinventory/llinventorysettings.cpp index 81485b3a97..bc604097da 100644 --- a/indra/llinventory/llinventorysettings.cpp +++ b/indra/llinventory/llinventorysettings.cpp @@ -62,7 +62,7 @@ class LLSettingsDictionary : public LLSingleton<LLSettingsDictionary>,  {      LLSINGLETON(LLSettingsDictionary); -    void initSingleton(); +    void initSingleton() override;  };  LLSettingsDictionary::LLSettingsDictionary()  diff --git a/indra/llmessage/llexperiencecache.h b/indra/llmessage/llexperiencecache.h index 1c97133723..8be4c64dfc 100644 --- a/indra/llmessage/llexperiencecache.h +++ b/indra/llmessage/llexperiencecache.h @@ -106,7 +106,7 @@ public:  private:      virtual ~LLExperienceCache(); -    virtual void initSingleton(); +    virtual void initSingleton() override;      typedef boost::function<LLSD(LLCoreHttpUtil::HttpCoroutineAdapter::ptr_t &, LLCore::HttpRequest::ptr_t, std::string)> permissionInvoker_fn; diff --git a/indra/llmessage/llproxy.h b/indra/llmessage/llproxy.h index 25f6977e14..8a64cdbfaa 100644 --- a/indra/llmessage/llproxy.h +++ b/indra/llmessage/llproxy.h @@ -226,7 +226,7 @@ class LLProxy: public LLSingleton<LLProxy>  	LLSINGLETON(LLProxy);  	LOG_CLASS(LLProxy); -    /*virtual*/ void initSingleton(); +    /*virtual*/ void initSingleton() override;  public:  	// Static check for enabled status for UDP packets. Call from main thread only. diff --git a/indra/llui/llnotifications.h b/indra/llui/llnotifications.h index 921398a693..4d9a33f1d7 100644 --- a/indra/llui/llnotifications.h +++ b/indra/llui/llnotifications.h @@ -913,7 +913,7 @@ public:  	/* virtual */ LLNotificationPtr add(const std::string& name,   						const LLSD& substitutions,   						const LLSD& payload,  -						LLNotificationFunctorRegistry::ResponseFunctor functor); +						LLNotificationFunctorRegistry::ResponseFunctor functor) override;  	LLNotificationPtr add(const LLNotification::Params& p);  	void add(const LLNotificationPtr pNotif); @@ -964,8 +964,8 @@ public:  	bool isVisibleByRules(LLNotificationPtr pNotification);  private: -	/*virtual*/ void initSingleton(); -	/*virtual*/ void cleanupSingleton(); +	/*virtual*/ void initSingleton() override; +	/*virtual*/ void cleanupSingleton() override;  	void loadPersistentNotifications(); diff --git a/indra/llui/llspellcheck.h b/indra/llui/llspellcheck.h index 3da5e30955..14f9b44fe4 100644 --- a/indra/llui/llspellcheck.h +++ b/indra/llui/llspellcheck.h @@ -47,7 +47,7 @@ public:  protected:  	void addToDictFile(const std::string& dict_path, const std::string& word);  	void initHunspell(const std::string& dict_language); -	void initSingleton(); +	void initSingleton() override;  public:  	typedef std::list<std::string> dict_list_t; diff --git a/indra/llui/lltextbase.cpp b/indra/llui/lltextbase.cpp index 82a3c01c6d..1389fc2a14 100644 --- a/indra/llui/lltextbase.cpp +++ b/indra/llui/lltextbase.cpp @@ -1979,19 +1979,8 @@ LLTextBase::segment_set_t::const_iterator LLTextBase::getEditableSegIterContaini  LLTextBase::segment_set_t::iterator LLTextBase::getSegIterContaining(S32 index)  { -  	static LLPointer<LLIndexSegment> index_segment = new LLIndexSegment(); -	S32 text_len = 0; -	if (!useLabel()) -	{ -		text_len = getLength(); -	} -	else -	{ -		text_len = mLabel.getWString().length(); -	} -  	if (index > text_len) { return mSegments.end(); }  	// when there are no segments, we return the end iterator, which must be checked by caller @@ -2007,16 +1996,6 @@ LLTextBase::segment_set_t::const_iterator LLTextBase::getSegIterContaining(S32 i  {  	static LLPointer<LLIndexSegment> index_segment = new LLIndexSegment(); -	S32 text_len = 0; -	if (!useLabel()) -	{ -		text_len = getLength(); -	} -	else -	{ -		text_len = mLabel.getWString().length(); -	} -  	if (index > text_len) { return mSegments.end(); }  	// when there are no segments, we return the end iterator, which must be checked by caller diff --git a/indra/llui/lluictrl.h b/indra/llui/lluictrl.h index 67dd24341c..d71dc8d859 100644 --- a/indra/llui/lluictrl.h +++ b/indra/llui/lluictrl.h @@ -263,7 +263,7 @@ public:  	class LLTextInputFilter : public LLQueryFilter, public LLSingleton<LLTextInputFilter>  	{  		LLSINGLETON_EMPTY_CTOR(LLTextInputFilter); -		/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const  +		/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override  		{  			return filterResult_t(view->isCtrl() && static_cast<const LLUICtrl *>(view)->acceptsTextInput(), TRUE);  		} diff --git a/indra/llui/llview.cpp b/indra/llui/llview.cpp index 9ba71913d0..5e74817f1f 100644 --- a/indra/llui/llview.cpp +++ b/indra/llui/llview.cpp @@ -1953,7 +1953,7 @@ private:  class SortByTabOrder : public LLQuerySorter, public LLSingleton<SortByTabOrder>  {  	LLSINGLETON_EMPTY_CTOR(SortByTabOrder); -	/*virtual*/ void sort(LLView * parent, LLView::child_list_t &children) const  +	/*virtual*/ void sort(LLView * parent, LLView::child_list_t &children) const override  	{  		children.sort(CompareByTabOrder(parent->getTabOrder(), parent->getDefaultTabGroup()));  	} @@ -1977,7 +1977,7 @@ const LLViewQuery & LLView::getTabOrderQuery()  class LLFocusRootsFilter : public LLQueryFilter, public LLSingleton<LLFocusRootsFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLFocusRootsFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const  +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override  	{  		return filterResult_t(view->isCtrl() && view->isFocusRoot(), !view->isFocusRoot());  	} diff --git a/indra/llui/llviewquery.h b/indra/llui/llviewquery.h index 21bb1be26f..4bc9c4a08e 100644 --- a/indra/llui/llviewquery.h +++ b/indra/llui/llviewquery.h @@ -55,37 +55,37 @@ public:  class LLLeavesFilter : public LLQueryFilter, public LLSingleton<LLLeavesFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLLeavesFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const; +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override;  };  class LLRootsFilter : public LLQueryFilter, public LLSingleton<LLRootsFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLRootsFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const; +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override;  };  class LLVisibleFilter : public LLQueryFilter, public LLSingleton<LLVisibleFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLVisibleFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const; +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override;  };  class LLEnabledFilter : public LLQueryFilter, public LLSingleton<LLEnabledFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLEnabledFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const; +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override;  };  class LLTabStopFilter : public LLQueryFilter, public LLSingleton<LLTabStopFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLTabStopFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const; +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override;  };  class LLCtrlFilter : public LLQueryFilter, public LLSingleton<LLCtrlFilter>  {  	LLSINGLETON_EMPTY_CTOR(LLCtrlFilter); -	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const; +	/*virtual*/ filterResult_t operator() (const LLView* const view, const viewList_t & children) const override;  };  template <class T> diff --git a/indra/newview/llautoreplace.h b/indra/newview/llautoreplace.h index 23cc313646..a1eebf9dcb 100644 --- a/indra/newview/llautoreplace.h +++ b/indra/newview/llautoreplace.h @@ -203,7 +203,7 @@ public:      void setSettings(const LLAutoReplaceSettings& settings);  private: -    /*virtual*/ void initSingleton(); +    /*virtual*/ void initSingleton() override;      LLAutoReplaceSettings mSettings; ///< configuration information diff --git a/indra/newview/llchannelmanager.h b/indra/newview/llchannelmanager.h index 8abe350196..22ae595d66 100644 --- a/indra/newview/llchannelmanager.h +++ b/indra/newview/llchannelmanager.h @@ -46,7 +46,7 @@ class LLChannelManager : public LLSingleton<LLChannelManager>  	LLSINGLETON(LLChannelManager);  	virtual ~LLChannelManager(); -	void cleanupSingleton(); +	void cleanupSingleton() override;  public: diff --git a/indra/newview/llchicletbar.h b/indra/newview/llchicletbar.h index 6c521dc1d5..c295b99962 100644 --- a/indra/newview/llchicletbar.h +++ b/indra/newview/llchicletbar.h @@ -43,11 +43,11 @@ class LLChicletBar  public: -	BOOL postBuild(); +	BOOL postBuild() override;  	LLChicletPanel*	getChicletPanel() { return mChicletPanel; } -	/*virtual*/ void reshape(S32 width, S32 height, BOOL called_from_parent); +	/*virtual*/ void reshape(S32 width, S32 height, BOOL called_from_parent) override;  	/** diff --git a/indra/newview/llconversationlog.h b/indra/newview/llconversationlog.h index 820a5db491..54aeedcf9a 100644 --- a/indra/newview/llconversationlog.h +++ b/indra/newview/llconversationlog.h @@ -125,11 +125,11 @@ public:  	void removeObserver(LLConversationLogObserver* observer);  	// LLIMSessionObserver triggers -	virtual void sessionAdded(const LLUUID& session_id, const std::string& name, const LLUUID& other_participant_id, BOOL has_offline_msg); -    virtual void sessionActivated(const LLUUID& session_id, const std::string& name, const LLUUID& other_participant_id) {}; // Stub -	virtual void sessionRemoved(const LLUUID& session_id){}											// Stub -	virtual void sessionVoiceOrIMStarted(const LLUUID& session_id){};								// Stub -	virtual void sessionIDUpdated(const LLUUID& old_session_id, const LLUUID& new_session_id){};	// Stub +	virtual void sessionAdded(const LLUUID& session_id, const std::string& name, const LLUUID& other_participant_id, BOOL has_offline_msg) override; +    virtual void sessionActivated(const LLUUID& session_id, const std::string& name, const LLUUID& other_participant_id) override {}; // Stub +	virtual void sessionRemoved(const LLUUID& session_id) override{}											// Stub +	virtual void sessionVoiceOrIMStarted(const LLUUID& session_id) override{};								// Stub +	virtual void sessionIDUpdated(const LLUUID& old_session_id, const LLUUID& new_session_id) override{};	// Stub  	void notifyObservers(); diff --git a/indra/newview/llfeaturemanager.h b/indra/newview/llfeaturemanager.h index 42a226cd18..d9269224af 100644 --- a/indra/newview/llfeaturemanager.h +++ b/indra/newview/llfeaturemanager.h @@ -101,7 +101,7 @@ class LLFeatureManager : public LLFeatureList, public LLSingleton<LLFeatureManag  	~LLFeatureManager() {cleanupFeatureTables();}  	// initialize this by loading feature table and gpu table -	void initSingleton(); +	void initSingleton() override;  public: diff --git a/indra/newview/llfriendcard.h b/indra/newview/llfriendcard.h index f5679d7d85..ef0dda7949 100644 --- a/indra/newview/llfriendcard.h +++ b/indra/newview/llfriendcard.h @@ -55,7 +55,7 @@ public:      };  	// LLFriendObserver implementation -	void changed(U32 mask) +	void changed(U32 mask) override  	{  		onFriendListUpdate(mask);  	} diff --git a/indra/newview/llgesturemgr.h b/indra/newview/llgesturemgr.h index 7c8e8279c2..7bb60f00e2 100644 --- a/indra/newview/llgesturemgr.h +++ b/indra/newview/llgesturemgr.h @@ -135,7 +135,7 @@ public:  	void notifyObservers();  	// Overriding so we can update active gesture names and notify observers  -	void changed(U32 mask);  +	void changed(U32 mask) override;  	BOOL matchPrefix(const std::string& in_str, std::string* out_str); @@ -150,7 +150,7 @@ protected:  	void runStep(LLMultiGesture* gesture, LLGestureStep* step);  	// LLInventoryCompletionObserver trigger -	void done(); +	void done() override;  	// Used by loadGesture  	static void onLoadComplete(const LLUUID& asset_uuid, diff --git a/indra/newview/llimagefiltersmanager.h b/indra/newview/llimagefiltersmanager.h index d06212d85a..05d1806da4 100644 --- a/indra/newview/llimagefiltersmanager.h +++ b/indra/newview/llimagefiltersmanager.h @@ -45,7 +45,7 @@ private:  	void loadAllFilters();  	void loadFiltersFromDir(const std::string& dir); -	/*virtual*/ void initSingleton(); +	/*virtual*/ void initSingleton() override;  	// List of filters : first is the user friendly localized name, second is the xml file name      std::map<std::string,std::string> mFiltersList; diff --git a/indra/newview/llimview.h b/indra/newview/llimview.h index 326e8f22e3..353373f3b4 100644 --- a/indra/newview/llimview.h +++ b/indra/newview/llimview.h @@ -506,7 +506,7 @@ public:  	static void onVoiceChannelStateChanged(const LLVoiceChannel::EState& old_state, const LLVoiceChannel::EState& new_state, const LLVoiceChannel::EDirection& direction, bool ended_by_agent);  private: -	void initSingleton(); +	void initSingleton() override;  	void onVoiceChannelChangedInt(const LLUUID &session_id);  	void onVoiceChannelStateChangedInt(const LLVoiceChannel::EState& old_state, const LLVoiceChannel::EState& new_state, const LLVoiceChannel::EDirection& direction, bool ended_by_agent); diff --git a/indra/newview/llmutelist.h b/indra/newview/llmutelist.h index 0d426fbd48..f86c2acd10 100644 --- a/indra/newview/llmutelist.h +++ b/indra/newview/llmutelist.h @@ -73,7 +73,7 @@ class LLMuteList : public LLSingleton<LLMuteList>  {  	LLSINGLETON(LLMuteList);  	~LLMuteList(); -	/*virtual*/ void cleanupSingleton(); +	/*virtual*/ void cleanupSingleton() override;  public:  	// reasons for auto-unmuting a resident  	enum EAutoReason  diff --git a/indra/newview/llnavigationbar.h b/indra/newview/llnavigationbar.h index 11c671294a..4649f5bcb0 100755 --- a/indra/newview/llnavigationbar.h +++ b/indra/newview/llnavigationbar.h @@ -92,10 +92,10 @@ class LLNavigationBar  public: -	/*virtual*/ void	draw(); -	/*virtual*/ BOOL handleRightMouseDown(S32 x, S32 y, MASK mask); -	/*virtual*/ BOOL	postBuild(); -	/*virtual*/ void	setVisible(BOOL visible); +	/*virtual*/ void	draw() override; +	/*virtual*/ BOOL handleRightMouseDown(S32 x, S32 y, MASK mask) override; +	/*virtual*/ BOOL	postBuild() override; +	/*virtual*/ void	setVisible(BOOL visible) override;  	void handleLoginComplete();  	void clearHistoryCache(); diff --git a/indra/newview/lloutfitobserver.h b/indra/newview/lloutfitobserver.h index 77041db68d..77bb3543aa 100644 --- a/indra/newview/lloutfitobserver.h +++ b/indra/newview/lloutfitobserver.h @@ -41,7 +41,7 @@ class LLOutfitObserver: public LLInventoryObserver, public LLSingleton<LLOutfitO  public: -	virtual void changed(U32 mask); +	virtual void changed(U32 mask) override;  	void notifyOutfitLockChanged() { mOutfitLockChanged();  } diff --git a/indra/newview/llpaneltopinfobar.h b/indra/newview/llpaneltopinfobar.h index 78dd997029..b6c263e331 100644 --- a/indra/newview/llpaneltopinfobar.h +++ b/indra/newview/llpaneltopinfobar.h @@ -46,8 +46,8 @@ class LLPanelTopInfoBar : public LLPanel, public LLSingleton<LLPanelTopInfoBar>,  public:  	typedef boost::signals2::signal<void ()> resize_signal_t; -	/*virtual*/ BOOL postBuild(); -	/*virtual*/ void draw(); +	/*virtual*/ BOOL postBuild() override; +	/*virtual*/ void draw() override;  	/**  	 * Updates location and parcel icons on login complete @@ -83,7 +83,7 @@ private:  	 */  	void initParcelIcons(); -	BOOL handleRightMouseDown(S32 x, S32 y, MASK mask); +	BOOL handleRightMouseDown(S32 x, S32 y, MASK mask) override;  	/**  	 * Handles clicks on the parcel icons. diff --git a/indra/newview/llpathfindingpathtool.h b/indra/newview/llpathfindingpathtool.h index 88cb3a15f8..f98624e30d 100644 --- a/indra/newview/llpathfindingpathtool.h +++ b/indra/newview/llpathfindingpathtool.h @@ -66,17 +66,17 @@ public:  	typedef boost::signals2::signal<void (void)> path_event_signal_t;  	typedef boost::signals2::connection          path_event_slot_t; -	virtual BOOL      handleMouseDown(S32 pX, S32 pY, MASK pMask); -	virtual BOOL      handleMouseUp(S32 pX, S32 pY, MASK pMask); -	virtual BOOL      handleMiddleMouseDown(S32 pX, S32 pY, MASK pMask); -	virtual BOOL      handleMiddleMouseUp(S32 pX, S32 pY, MASK pMask); -	virtual BOOL      handleRightMouseDown(S32 pX, S32 pY, MASK pMask); -	virtual BOOL      handleRightMouseUp(S32 pX, S32 pY, MASK pMask); -	virtual BOOL      handleDoubleClick(S32 x, S32 y, MASK mask); +	virtual BOOL      handleMouseDown(S32 pX, S32 pY, MASK pMask) override; +	virtual BOOL      handleMouseUp(S32 pX, S32 pY, MASK pMask) override; +	virtual BOOL      handleMiddleMouseDown(S32 pX, S32 pY, MASK pMask) override; +	virtual BOOL      handleMiddleMouseUp(S32 pX, S32 pY, MASK pMask) override; +	virtual BOOL      handleRightMouseDown(S32 pX, S32 pY, MASK pMask) override; +	virtual BOOL      handleRightMouseUp(S32 pX, S32 pY, MASK pMask) override; +	virtual BOOL      handleDoubleClick(S32 x, S32 y, MASK mask) override; -	virtual BOOL      handleHover(S32 pX, S32 pY, MASK pMask); +	virtual BOOL      handleHover(S32 pX, S32 pY, MASK pMask) override; -	virtual BOOL      handleKey(KEY pKey, MASK pMask); +	virtual BOOL      handleKey(KEY pKey, MASK pMask) override;  	EPathStatus       getPathStatus() const; diff --git a/indra/newview/llproductinforequest.h b/indra/newview/llproductinforequest.h index d1036374e8..0b94c39d11 100644 --- a/indra/newview/llproductinforequest.h +++ b/indra/newview/llproductinforequest.h @@ -46,7 +46,7 @@ public:  	std::string getDescriptionForSku(const std::string& sku);  private: -	/* virtual */ void initSingleton(); +	/* virtual */ void initSingleton() override;      void getLandDescriptionsCoro(std::string url);      LLSD mSkuDescriptions; diff --git a/indra/newview/llrecentpeople.h b/indra/newview/llrecentpeople.h index 1b322f2c0a..0c04222a9f 100644 --- a/indra/newview/llrecentpeople.h +++ b/indra/newview/llrecentpeople.h @@ -106,7 +106,7 @@ public:  	/**  	 * LLSimpleListener interface.  	 */ -	/*virtual*/ bool handleEvent(LLPointer<LLOldEvents::LLEvent> event, const LLSD& userdata); +	/*virtual*/ bool handleEvent(LLPointer<LLOldEvents::LLEvent> event, const LLSD& userdata) override;  	void updateAvatarsArrivalTime(uuid_vec_t& uuids);  	F32 getArrivalTimeByID(const LLUUID& id); diff --git a/indra/newview/llspeakers.h b/indra/newview/llspeakers.h index ed795b5155..22c9481687 100644 --- a/indra/newview/llspeakers.h +++ b/indra/newview/llspeakers.h @@ -338,7 +338,7 @@ class LLActiveSpeakerMgr : public LLSpeakerMgr, public LLSingleton<LLActiveSpeak  	LOG_CLASS(LLActiveSpeakerMgr);  protected: -	virtual void updateSpeakerList(); +	virtual void updateSpeakerList() override;  };  class LLLocalSpeakerMgr : public LLSpeakerMgr, public LLSingleton<LLLocalSpeakerMgr> @@ -347,7 +347,7 @@ class LLLocalSpeakerMgr : public LLSpeakerMgr, public LLSingleton<LLLocalSpeaker  	~LLLocalSpeakerMgr ();  	LOG_CLASS(LLLocalSpeakerMgr);  protected: -	virtual void updateSpeakerList(); +	virtual void updateSpeakerList() override;  };  #endif // LL_LLSPEAKERS_H diff --git a/indra/newview/llspeakingindicatormanager.cpp b/indra/newview/llspeakingindicatormanager.cpp index 0111d8869c..37c7ea55ae 100644 --- a/indra/newview/llspeakingindicatormanager.cpp +++ b/indra/newview/llspeakingindicatormanager.cpp @@ -88,7 +88,7 @@ public:  	 * So, method does not calculate difference between these list it only switches off already   	 * switched on indicators and switches on indicators of voice channel participants  	 */ -	void onParticipantsChanged(); +	void onParticipantsChanged() override;  private:  	typedef std::set<LLUUID> speaker_ids_t; diff --git a/indra/newview/lltoolbrush.h b/indra/newview/lltoolbrush.h index c108d83256..6545ee3611 100644 --- a/indra/newview/lltoolbrush.h +++ b/indra/newview/lltoolbrush.h @@ -49,27 +49,27 @@ class LLToolBrushLand : public LLTool, public LLEditMenuHandler, public LLSingle  public:  	// x,y in window coords, 0,0 = left,bot -	virtual BOOL handleMouseDown( S32 x, S32 y, MASK mask ); -	virtual BOOL handleMouseUp( S32 x, S32 y, MASK mask );		 -	virtual BOOL handleHover( S32 x, S32 y, MASK mask ); -	virtual void handleSelect(); -	virtual void handleDeselect(); +	virtual BOOL handleMouseDown( S32 x, S32 y, MASK mask ) override; +	virtual BOOL handleMouseUp( S32 x, S32 y, MASK mask ) override; +	virtual BOOL handleHover( S32 x, S32 y, MASK mask ) override; +	virtual void handleSelect() override; +	virtual void handleDeselect() override;  	// isAlwaysRendered() - return true if this is a tool that should  	// always be rendered regardless of selection. -	virtual BOOL isAlwaysRendered() { return TRUE; } +	virtual BOOL isAlwaysRendered()  override { return TRUE; }  	// Draw the area that will be affected. -	virtual void render(); +	virtual void render() override;  	// on Idle is where the land modification actually occurs  	static void onIdle(void* brush_tool);   -	void			onMouseCaptureLost(); +	void onMouseCaptureLost() override;  	void modifyLandInSelectionGlobal(); -	virtual void	undo(); -	virtual BOOL	canUndo() const	{ return TRUE; } +	virtual void	undo() override; +	virtual BOOL	canUndo() const	 override { return TRUE; }  protected:  	void brush( void ); diff --git a/indra/newview/lltoolcomp.h b/indra/newview/lltoolcomp.h index 86506f725e..f539a045b7 100644 --- a/indra/newview/lltoolcomp.h +++ b/indra/newview/lltoolcomp.h @@ -108,11 +108,11 @@ class LLToolCompInspect : public LLToolComposite, public LLSingleton<LLToolCompI  public:  	// Overridden from LLToolComposite -    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask); -    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); -	virtual BOOL		handleKey(KEY key, MASK mask); -	virtual void		onMouseCaptureLost(); +    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override; +    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleKey(KEY key, MASK mask) override; +	virtual void		onMouseCaptureLost() override;  			void		keyUp(KEY key, MASK mask);  	static void pickCallback(const LLPickInfo& pick_info); @@ -133,13 +133,13 @@ class LLToolCompTranslate : public LLToolComposite, public LLSingleton<LLToolCom  public:  	// Overridden from LLToolComposite -	virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); -	virtual BOOL		handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask);			// Returns to the default tool -	virtual void		render(); +	virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override;			// Returns to the default tool +	virtual void		render() override; -	virtual LLTool*		getOverrideTool(MASK mask); +	virtual LLTool*		getOverrideTool(MASK mask) override;  	static void pickCallback(const LLPickInfo& pick_info);  }; @@ -154,13 +154,13 @@ class LLToolCompScale : public LLToolComposite, public LLSingleton<LLToolCompSca  public:  	// Overridden from LLToolComposite -    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); -    virtual BOOL		handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask);			// Returns to the default tool -	virtual void		render(); +    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override; +    virtual BOOL		handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override;			// Returns to the default tool +	virtual void		render() override; -	virtual LLTool*		getOverrideTool(MASK mask); +	virtual LLTool*		getOverrideTool(MASK mask) override;  	static void pickCallback(const LLPickInfo& pick_info);  }; @@ -176,13 +176,13 @@ class LLToolCompRotate : public LLToolComposite, public LLSingleton<LLToolCompRo  public:  	// Overridden from LLToolComposite -    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); -    virtual BOOL		handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask); -	virtual void		render(); +    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override; +    virtual BOOL		handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual void		render() override; -	virtual LLTool*		getOverrideTool(MASK mask); +	virtual LLTool*		getOverrideTool(MASK mask) override;  	static void pickCallback(const LLPickInfo& pick_info); @@ -199,9 +199,9 @@ class LLToolCompCreate : public LLToolComposite, public LLSingleton<LLToolCompCr  public:  	// Overridden from LLToolComposite -    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask); +    virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +    virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override;  	static void pickCallback(const LLPickInfo& pick_info);  protected: @@ -224,16 +224,16 @@ class LLToolCompGun : public LLToolComposite, public LLSingleton<LLToolCompGun>  public:  	// Overridden from LLToolComposite -    virtual BOOL			handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL			handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL			handleDoubleClick(S32 x, S32 y, MASK mask); -	virtual BOOL			handleRightMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL			handleMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL			handleScrollWheel(S32 x, S32 y, S32 clicks); -	virtual void			onMouseCaptureLost(); -	virtual void			handleSelect(); -	virtual void			handleDeselect(); -	virtual LLTool*			getOverrideTool(MASK mask) { return NULL; } +    virtual BOOL			handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL			handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL			handleDoubleClick(S32 x, S32 y, MASK mask) override; +	virtual BOOL			handleRightMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL			handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL			handleScrollWheel(S32 x, S32 y, S32 clicks) override; +	virtual void			onMouseCaptureLost() override; +	virtual void			handleSelect() override; +	virtual void			handleDeselect() override; +	virtual LLTool*			getOverrideTool(MASK mask) override { return NULL; }  protected:  	LLToolGun*			mGun; diff --git a/indra/newview/lltooldraganddrop.h b/indra/newview/lltooldraganddrop.h index 4537d73332..8ec027cb0e 100644 --- a/indra/newview/lltooldraganddrop.h +++ b/indra/newview/lltooldraganddrop.h @@ -48,12 +48,12 @@ public:  	typedef boost::signals2::signal<void ()> enddrag_signal_t;  	// overridden from LLTool -	virtual BOOL	handleMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL	handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL	handleKey(KEY key, MASK mask); -	virtual BOOL	handleToolTip(S32 x, S32 y, MASK mask); -	virtual void	onMouseCaptureLost(); -	virtual void	handleDeselect(); +	virtual BOOL	handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleKey(KEY key, MASK mask) override; +	virtual BOOL	handleToolTip(S32 x, S32 y, MASK mask) override; +	virtual void	onMouseCaptureLost() override; +	virtual void	handleDeselect() override;  	void			setDragStart( S32 x, S32 y );			// In screen space  	BOOL			isOverThreshold( S32 x, S32 y );		// In screen space diff --git a/indra/newview/lltoolface.h b/indra/newview/lltoolface.h index e4b8ae12b8..7c8ff20480 100644 --- a/indra/newview/lltoolface.h +++ b/indra/newview/lltoolface.h @@ -39,11 +39,11 @@ class LLToolFace  	virtual ~LLToolFace();  public: -	virtual BOOL	handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL	handleDoubleClick(S32 x, S32 y, MASK mask); -	virtual void	handleSelect(); -	virtual void	handleDeselect(); -	virtual void	render();			// draw face highlights +	virtual BOOL	handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleDoubleClick(S32 x, S32 y, MASK mask) override; +	virtual void	handleSelect() override; +	virtual void	handleDeselect() override; +	virtual void	render() override;			// draw face highlights  	static void pickCallback(const LLPickInfo& pick_info);  }; diff --git a/indra/newview/lltoolfocus.h b/indra/newview/lltoolfocus.h index cfc235b6c2..c9dd39ff4b 100644 --- a/indra/newview/lltoolfocus.h +++ b/indra/newview/lltoolfocus.h @@ -38,16 +38,16 @@ class LLToolCamera  	virtual ~LLToolCamera();  public: -	virtual BOOL	handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL	handleMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL	handleHover(S32 x, S32 y, MASK mask); +	virtual BOOL	handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleHover(S32 x, S32 y, MASK mask) override; -	virtual void	onMouseCaptureLost(); +	virtual void	onMouseCaptureLost() override; -	virtual void	handleSelect(); -	virtual void	handleDeselect(); +	virtual void	handleSelect() override; +	virtual void	handleDeselect() override; -	virtual LLTool*	getOverrideTool(MASK mask) { return NULL; } +	virtual LLTool*	getOverrideTool(MASK mask) override { return NULL; }  	static void pickCallback(const LLPickInfo& pick_info);  	BOOL mouseSteerMode() { return mMouseSteering; } diff --git a/indra/newview/lltoolindividual.h b/indra/newview/lltoolindividual.h index e7c2060fba..89dd9d9796 100644 --- a/indra/newview/lltoolindividual.h +++ b/indra/newview/lltoolindividual.h @@ -43,11 +43,9 @@ class LLToolIndividual : public LLTool, public LLSingleton<LLToolIndividual>  	virtual ~LLToolIndividual();  public: -	virtual BOOL handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL handleDoubleClick(S32 x, S32 y, MASK mask); -	virtual void handleSelect(); -	//virtual void handleDeselect(); -	//virtual void render(); +	virtual BOOL handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL handleDoubleClick(S32 x, S32 y, MASK mask) override; +	virtual void handleSelect() override;  	static void pickCallback(const LLPickInfo& pick_info); diff --git a/indra/newview/lltoolobjpicker.h b/indra/newview/lltoolobjpicker.h index 5ad9b67e21..a55cd223de 100644 --- a/indra/newview/lltoolobjpicker.h +++ b/indra/newview/lltoolobjpicker.h @@ -38,16 +38,16 @@ class LLToolObjPicker : public LLTool, public LLSingleton<LLToolObjPicker>  	LLSINGLETON(LLToolObjPicker);  public: -	virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL		handleHover(S32 x, S32 y, MASK mask); +	virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleHover(S32 x, S32 y, MASK mask) override; -	virtual void 		handleSelect(); -	virtual void 		handleDeselect(); +	virtual void 		handleSelect() override; +	virtual void 		handleDeselect() override; -	virtual void		onMouseCaptureLost(); +	virtual void		onMouseCaptureLost() override; -	virtual void 		setExitCallback(void (*callback)(void *), void *callback_data); +	void 		setExitCallback(void (*callback)(void *), void *callback_data);  	LLUUID				getObjectID() const { return mHitObjectID; } diff --git a/indra/newview/lltoolpie.h b/indra/newview/lltoolpie.h index 8f6100e4b4..dca0d12cf6 100644 --- a/indra/newview/lltoolpie.h +++ b/indra/newview/lltoolpie.h @@ -42,26 +42,26 @@ class LLToolPie : public LLTool, public LLSingleton<LLToolPie>  public:  	// Virtual functions inherited from LLMouseHandler -	virtual BOOL		handleAnyMouseClick(S32 x, S32 y, MASK mask, EMouseClickType clicktype, BOOL down); -	virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL		handleRightMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL		handleRightMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL		handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); +	virtual BOOL		handleAnyMouseClick(S32 x, S32 y, MASK mask, EMouseClickType clicktype, BOOL down) override; +	virtual BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleRightMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleRightMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override;  	BOOL				handleScrollWheelAny(S32 x, S32 y, S32 clicks_x, S32 clicks_y); -	virtual BOOL		handleScrollWheel(S32 x, S32 y, S32 clicks); -	virtual BOOL		handleScrollHWheel(S32 x, S32 y, S32 clicks); -	virtual BOOL		handleToolTip(S32 x, S32 y, MASK mask); +	virtual BOOL		handleScrollWheel(S32 x, S32 y, S32 clicks) override; +	virtual BOOL		handleScrollHWheel(S32 x, S32 y, S32 clicks) override; +	virtual BOOL		handleToolTip(S32 x, S32 y, MASK mask) override; -	virtual void		render(); +	virtual void		render() override; -	virtual void		stopEditing(); +	virtual void		stopEditing() override; -	virtual void		onMouseCaptureLost(); -	virtual void		handleSelect(); -	virtual void		handleDeselect(); -	virtual LLTool*		getOverrideTool(MASK mask); +	virtual void		onMouseCaptureLost() override; +	virtual void		handleSelect() override; +	virtual void		handleDeselect() override; +	virtual LLTool*		getOverrideTool(MASK mask) override;  	LLPickInfo&			getPick() { return mPick; }  	U8					getClickAction() { return mClickAction; } diff --git a/indra/newview/lltoolpipette.h b/indra/newview/lltoolpipette.h index 7575d8ad18..2636811c66 100644 --- a/indra/newview/lltoolpipette.h +++ b/indra/newview/lltoolpipette.h @@ -47,10 +47,10 @@ class LLToolPipette  	virtual ~LLToolPipette();  public: -	virtual BOOL	handleMouseDown(S32 x, S32 y, MASK mask); -	virtual BOOL	handleMouseUp(S32 x, S32 y, MASK mask); -	virtual BOOL	handleHover(S32 x, S32 y, MASK mask); -	virtual BOOL	handleToolTip(S32 x, S32 y, MASK mask); +	virtual BOOL	handleMouseDown(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleMouseUp(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleHover(S32 x, S32 y, MASK mask) override; +	virtual BOOL	handleToolTip(S32 x, S32 y, MASK mask) override;  	// Note: Don't return connection; use boost::bind + boost::signals2::trackable to disconnect slots  	typedef boost::signals2::signal<void (const LLTextureEntry& te)> signal_t; diff --git a/indra/newview/lltoolselectland.h b/indra/newview/lltoolselectland.h index b5ba72f16d..88bc4e2e3d 100644 --- a/indra/newview/lltoolselectland.h +++ b/indra/newview/lltoolselectland.h @@ -39,15 +39,15 @@ class LLToolSelectLand  	virtual ~LLToolSelectLand();  public: -	/*virtual*/ BOOL		handleMouseDown(S32 x, S32 y, MASK mask); -	/*virtual*/ BOOL		handleDoubleClick(S32 x, S32 y, MASK mask); -	/*virtual*/ BOOL		handleMouseUp(S32 x, S32 y, MASK mask); -	/*virtual*/ BOOL		handleHover(S32 x, S32 y, MASK mask); -	/*virtual*/ void		render();				// draw the select rectangle -	/*virtual*/ BOOL		isAlwaysRendered()		{ return TRUE; } +	/*virtual*/ BOOL		handleMouseDown(S32 x, S32 y, MASK mask) override; +	/*virtual*/ BOOL		handleDoubleClick(S32 x, S32 y, MASK mask) override; +	/*virtual*/ BOOL		handleMouseUp(S32 x, S32 y, MASK mask) override; +	/*virtual*/ BOOL		handleHover(S32 x, S32 y, MASK mask) override; +	/*virtual*/ void		render() override;				// draw the select rectangle +	/*virtual*/ BOOL		isAlwaysRendered() override	{ return TRUE; } -	/*virtual*/ void		handleSelect(); -	/*virtual*/ void		handleDeselect(); +	/*virtual*/ void		handleSelect() override; +	/*virtual*/ void		handleDeselect() override;  protected:  	BOOL			outsideSlop(S32 x, S32 y, S32 start_x, S32 start_y); diff --git a/indra/newview/llversioninfo.h b/indra/newview/llversioninfo.h index 02ff0c094a..37382243f6 100644 --- a/indra/newview/llversioninfo.h +++ b/indra/newview/llversioninfo.h @@ -47,7 +47,7 @@ class LLStoreListener;  class LLVersionInfo: public LLSingleton<LLVersionInfo>  {  	LLSINGLETON(LLVersionInfo); -	void initSingleton(); +	void initSingleton() override;  public:  	~LLVersionInfo(); diff --git a/indra/newview/llviewerhelp.h b/indra/newview/llviewerhelp.h index da50e07a43..bbd20bc07e 100644 --- a/indra/newview/llviewerhelp.h +++ b/indra/newview/llviewerhelp.h @@ -43,21 +43,21 @@ class LLViewerHelp : public LLHelp, public LLSingleton<LLViewerHelp>   public:  	/// display the specified help topic in the help viewer -	/*virtual*/ void showTopic(const std::string &topic); +	/*virtual*/ void showTopic(const std::string &topic) override; -	std::string getURL(const std::string& topic); +	std::string getURL(const std::string& topic) override;  	// return topic derived from viewer UI focus, else default topic  	std::string getTopicFromFocus();  	/// return default (fallback) topic name suitable for showTopic() -	/*virtual*/ std::string defaultTopic(); +	/*virtual*/ std::string defaultTopic() override;  	// return topic to use before the user logs in -	/*virtual*/ std::string preLoginTopic(); +	/*virtual*/ std::string preLoginTopic() override;  	// return topic to use for the top-level help, invoked by F1 -	/*virtual*/ std::string f1HelpTopic(); +	/*virtual*/ std::string f1HelpTopic() override;  };  #endif // header guard diff --git a/indra/newview/llviewermedia.h b/indra/newview/llviewermedia.h index f1f42afd81..ad7c4bcefa 100644 --- a/indra/newview/llviewermedia.h +++ b/indra/newview/llviewermedia.h @@ -74,7 +74,7 @@ class LLViewerMedia: public LLSingleton<LLViewerMedia>  {  	LLSINGLETON(LLViewerMedia);  	~LLViewerMedia(); -	void initSingleton(); +	void initSingleton() override;  	LOG_CLASS(LLViewerMedia);  public: diff --git a/indra/newview/llviewermediafocus.h b/indra/newview/llviewermediafocus.h index effd08a559..2310e4dbfc 100644 --- a/indra/newview/llviewermediafocus.h +++ b/indra/newview/llviewermediafocus.h @@ -54,10 +54,10 @@ public:  	void setHoverFace(LLPointer<LLViewerObject> objectp, S32 face, viewer_media_t media_impl, LLVector3 pick_normal = LLVector3::zero);  	void clearHover(); -	/*virtual*/ bool	getFocus(); -	/*virtual*/ BOOL	handleKey(KEY key, MASK mask, BOOL called_from_parent); -	/*virtual*/ BOOL	handleKeyUp(KEY key, MASK mask, BOOL called_from_parent); -	/*virtual*/ BOOL	handleUnicodeChar(llwchar uni_char, BOOL called_from_parent); +	bool	getFocus(); +	/*virtual*/ BOOL	handleKey(KEY key, MASK mask, BOOL called_from_parent) override; +	/*virtual*/ BOOL	handleKeyUp(KEY key, MASK mask, BOOL called_from_parent) override; +	/*virtual*/ BOOL	handleUnicodeChar(llwchar uni_char, BOOL called_from_parent) override;  	BOOL handleScrollWheel(const LLVector2& texture_coords, S32 clicks_x, S32 clicks_y);  	BOOL handleScrollWheel(S32 x, S32 y, S32 clicks_x, S32 clicks_y); @@ -92,12 +92,12 @@ public:  	LLUUID getControlsMediaID();      // The MoaP object wants keyup and keydown events.  Overridden to return true. -    virtual bool    wantsKeyUpKeyDown() const; -    virtual bool    wantsReturnKey() const; +    virtual bool    wantsKeyUpKeyDown() const override; +    virtual bool    wantsReturnKey() const override;  protected: -	/*virtual*/ void	onFocusReceived(); -	/*virtual*/ void	onFocusLost(); +	/*virtual*/ void	onFocusReceived() override; +	/*virtual*/ void	onFocusLost() override;  private: diff --git a/indra/newview/llviewerparcelaskplay.h b/indra/newview/llviewerparcelaskplay.h index dc711917d2..56faddae66 100644 --- a/indra/newview/llviewerparcelaskplay.h +++ b/indra/newview/llviewerparcelaskplay.h @@ -34,8 +34,8 @@ class LLViewerParcelAskPlay : public LLSingleton<LLViewerParcelAskPlay>  {      LLSINGLETON(LLViewerParcelAskPlay);      ~LLViewerParcelAskPlay(); -    void initSingleton(); -    void cleanupSingleton(); +    void initSingleton() override; +    void cleanupSingleton() override;  public:      // functor expects functor(region_id, parcel_id, url, play/stop)      typedef boost::function<void(const LLUUID&, const S32&, const std::string&, const bool&)> ask_callback; diff --git a/indra/newview/llviewerparcelmedia.h b/indra/newview/llviewerparcelmedia.h index 779a65bdf8..790b2b71fc 100644 --- a/indra/newview/llviewerparcelmedia.h +++ b/indra/newview/llviewerparcelmedia.h @@ -74,7 +74,7 @@ public:  	void sendMediaNavigateMessage(const std::string& url);  	// inherited from LLViewerMediaObserver -	virtual void handleMediaEvent(LLPluginClassMedia* self, EMediaEvent event); +	virtual void handleMediaEvent(LLPluginClassMedia* self, EMediaEvent event) override;  private:  	void processParcelMediaCommandMessage(LLMessageSystem *msg); diff --git a/indra/newview/llviewerparcelmediaautoplay.h b/indra/newview/llviewerparcelmediaautoplay.h index d71fd4c075..e83085dee0 100644 --- a/indra/newview/llviewerparcelmediaautoplay.h +++ b/indra/newview/llviewerparcelmediaautoplay.h @@ -35,7 +35,7 @@ class LLViewerParcelMediaAutoPlay : LLEventTimer, public LLSingleton<LLViewerPar  {  	LLSINGLETON(LLViewerParcelMediaAutoPlay);  public: -	virtual BOOL tick(); +	virtual BOOL tick() override;  	static void playStarted();   private: diff --git a/indra/newview/llviewertexturelist.h b/indra/newview/llviewertexturelist.h index 0018e78d45..f159682b67 100644 --- a/indra/newview/llviewertexturelist.h +++ b/indra/newview/llviewertexturelist.h @@ -242,9 +242,9 @@ class LLUIImageList : public LLImageProviderInterface, public LLSingleton<LLUIIm  	LLSINGLETON_EMPTY_CTOR(LLUIImageList);  public:  	// LLImageProviderInterface -	/*virtual*/ LLPointer<LLUIImage> getUIImageByID(const LLUUID& id, S32 priority); -	/*virtual*/ LLPointer<LLUIImage> getUIImage(const std::string& name, S32 priority); -	void cleanUp(); +	/*virtual*/ LLPointer<LLUIImage> getUIImageByID(const LLUUID& id, S32 priority) override; +	/*virtual*/ LLPointer<LLUIImage> getUIImage(const std::string& name, S32 priority) override; +	void cleanUp() override;  	bool initFromFile(); diff --git a/indra/newview/llvoicechannel.h b/indra/newview/llvoicechannel.h index 309c3eebdd..e68bfbe1ff 100644 --- a/indra/newview/llvoicechannel.h +++ b/indra/newview/llvoicechannel.h @@ -170,12 +170,12 @@ class LLVoiceChannelProximal : public LLVoiceChannel, public LLSingleton<LLVoice  	LLSINGLETON(LLVoiceChannelProximal);  public: -	/*virtual*/ void onChange(EStatusType status, const std::string &channelURI, bool proximal); -	/*virtual*/ void handleStatusChange(EStatusType status); -	/*virtual*/ void handleError(EStatusType status); -	/*virtual*/ BOOL isActive(); -	/*virtual*/ void activate(); -	/*virtual*/ void deactivate(); +	/*virtual*/ void onChange(EStatusType status, const std::string &channelURI, bool proximal) override; +	/*virtual*/ void handleStatusChange(EStatusType status) override; +	/*virtual*/ void handleError(EStatusType status) override; +	/*virtual*/ BOOL isActive() override; +	/*virtual*/ void activate() override; +	/*virtual*/ void deactivate() override;  }; @@ -184,15 +184,15 @@ class LLVoiceChannelP2P : public LLVoiceChannelGroup  public:  	LLVoiceChannelP2P(const LLUUID& session_id, const std::string& session_name, const LLUUID& other_user_id); -	/*virtual*/ void handleStatusChange(EStatusType status); -	/*virtual*/ void handleError(EStatusType status); -    /*virtual*/ void activate(); -	/*virtual*/ void getChannelInfo(); +	/*virtual*/ void handleStatusChange(EStatusType status) override; +	/*virtual*/ void handleError(EStatusType status) override; +    /*virtual*/ void activate() override; +	/*virtual*/ void getChannelInfo() override;  	void setSessionHandle(const std::string& handle, const std::string &inURI);  protected: -	virtual void setState(EState state); +	virtual void setState(EState state) override;  private: diff --git a/indra/newview/llvoicevivox.h b/indra/newview/llvoicevivox.h index 0a785401c1..3df5cd33ac 100644 --- a/indra/newview/llvoicevivox.h +++ b/indra/newview/llvoicevivox.h @@ -64,26 +64,26 @@ public:  	/// @name LLVoiceModuleInterface virtual implementations  	///  @see LLVoiceModuleInterface  	//@{ -	virtual void init(LLPumpIO *pump);	// Call this once at application startup (creates connector) -	virtual void terminate();	// Call this to clean up during shutdown +	virtual void init(LLPumpIO *pump) override;	// Call this once at application startup (creates connector) +	virtual void terminate() override;	// Call this to clean up during shutdown -	virtual const LLVoiceVersionInfo& getVersion(); +	virtual const LLVoiceVersionInfo& getVersion() override; -	virtual void updateSettings(); // call after loading settings and whenever they change +	virtual void updateSettings() override; // call after loading settings and whenever they change  	// Returns true if vivox has successfully logged in and is not in error state	 -	virtual bool isVoiceWorking() const; +	virtual bool isVoiceWorking() const override;  	/////////////////////  	/// @name Tuning  	//@{ -	virtual void tuningStart(); -	virtual void tuningStop(); -	virtual bool inTuningMode(); +	virtual void tuningStart() override; +	virtual void tuningStop() override; +	virtual bool inTuningMode() override; -	virtual void tuningSetMicVolume(float volume); -	virtual void tuningSetSpeakerVolume(float volume); -	virtual float tuningGetEnergy(void); +	virtual void tuningSetMicVolume(float volume) override; +	virtual void tuningSetSpeakerVolume(float volume) override; +	virtual float tuningGetEnergy(void) override;  	//@}  	///////////////////// @@ -91,40 +91,40 @@ public:  	//@{  	// This returns true when it's safe to bring up the "device settings" dialog in the prefs.  	// i.e. when the daemon is running and connected, and the device lists are populated. -	virtual bool deviceSettingsAvailable(); -	virtual bool deviceSettingsUpdated();  //return if the list has been updated and never fetched,  only to be called from the voicepanel. +	virtual bool deviceSettingsAvailable() override; +	virtual bool deviceSettingsUpdated() override;  //return if the list has been updated and never fetched,  only to be called from the voicepanel.  	// Requery the vivox daemon for the current list of input/output devices.  	// If you pass true for clearCurrentList, deviceSettingsAvailable() will be false until the query has completed  	// (use this if you want to know when it's done).  	// If you pass false, you'll have no way to know when the query finishes, but the device lists will not appear empty in the interim. -	virtual void refreshDeviceLists(bool clearCurrentList = true); +	virtual void refreshDeviceLists(bool clearCurrentList = true) override; -	virtual void setCaptureDevice(const std::string& name); -	virtual void setRenderDevice(const std::string& name); +	virtual void setCaptureDevice(const std::string& name) override; +	virtual void setRenderDevice(const std::string& name) override; -	virtual LLVoiceDeviceList& getCaptureDevices(); -	virtual LLVoiceDeviceList& getRenderDevices(); +	virtual LLVoiceDeviceList& getCaptureDevices() override; +	virtual LLVoiceDeviceList& getRenderDevices() override;  	//@}	 -	virtual void getParticipantList(std::set<LLUUID> &participants); -	virtual bool isParticipant(const LLUUID& speaker_id); +	virtual void getParticipantList(std::set<LLUUID> &participants) override; +	virtual bool isParticipant(const LLUUID& speaker_id) override;  	// Send a text message to the specified user, initiating the session if necessary.  	// virtual BOOL sendTextMessage(const LLUUID& participant_id, const std::string& message) const {return false;};  	// close any existing text IM session with the specified user -	virtual void endUserIMSession(const LLUUID &uuid); +	virtual void endUserIMSession(const LLUUID &uuid) override;  	// Returns true if calling back the session URI after the session has closed is possible.  	// Currently this will be false only for PSTN P2P calls.		  	// NOTE: this will return true if the session can't be found.  -	virtual BOOL isSessionCallBackPossible(const LLUUID &session_id); +	virtual BOOL isSessionCallBackPossible(const LLUUID &session_id) override;  	// Returns true if the session can accepte text IM's.  	// Currently this will be false only for PSTN P2P calls.  	// NOTE: this will return true if the session can't be found.  -	virtual BOOL isSessionTextIMPossible(const LLUUID &session_id); +	virtual BOOL isSessionTextIMPossible(const LLUUID &session_id) override;  	//////////////////////////// @@ -132,21 +132,21 @@ public:  	//@{  	// returns true iff the user is currently in a proximal (local spatial) channel.  	// Note that gestures should only fire if this returns true. -	virtual bool inProximalChannel(); +	virtual bool inProximalChannel() override;  	virtual void setNonSpatialChannel(const std::string &uri, -									  const std::string &credentials); +									  const std::string &credentials) override;  	virtual bool setSpatialChannel(const std::string &uri, -								   const std::string &credentials); +								   const std::string &credentials) override; -	virtual void leaveNonSpatialChannel(); +	virtual void leaveNonSpatialChannel() override; -	virtual void leaveChannel(void);	 +	virtual void leaveChannel(void) override;  	// Returns the URI of the current channel, or an empty string if not currently in a channel.  	// NOTE that it will return an empty string if it's in the process of joining a channel. -	virtual std::string getCurrentChannel(); +	virtual std::string getCurrentChannel() override;  	//@} @@ -154,59 +154,59 @@ public:  	/// @name invitations  	//@{  	// start a voice channel with the specified user -	virtual void callUser(const LLUUID &uuid);	 -	virtual bool isValidChannel(std::string &channelHandle); -	virtual bool answerInvite(std::string &channelHandle); -	virtual void declineInvite(std::string &channelHandle); +	virtual void callUser(const LLUUID &uuid) override; +	virtual bool isValidChannel(std::string &channelHandle) override; +	virtual bool answerInvite(std::string &channelHandle) override; +	virtual void declineInvite(std::string &channelHandle) override;  	//@}  	/////////////////////////  	/// @name Volume/gain  	//@{ -	virtual void setVoiceVolume(F32 volume); -	virtual void setMicGain(F32 volume); +	virtual void setVoiceVolume(F32 volume) override; +	virtual void setMicGain(F32 volume) override;  	//@}  	/////////////////////////  	/// @name enable disable voice and features  	//@{ -	virtual bool voiceEnabled(); -	virtual void setVoiceEnabled(bool enabled); -	virtual BOOL lipSyncEnabled();	 -	virtual void setLipSyncEnabled(BOOL enabled); -	virtual void setMuteMic(bool muted);		// Set the mute state of the local mic. +	virtual bool voiceEnabled() override; +	virtual void setVoiceEnabled(bool enabled) override; +	virtual BOOL lipSyncEnabled() override; +	virtual void setLipSyncEnabled(BOOL enabled) override; +	virtual void setMuteMic(bool muted) override;		// Set the mute state of the local mic.  	//@}  	//////////////////////////  	/// @name nearby speaker accessors  	//@{ -	virtual BOOL getVoiceEnabled(const LLUUID& id);		// true if we've received data for this avatar -	virtual std::string getDisplayName(const LLUUID& id); -	virtual BOOL isParticipantAvatar(const LLUUID &id); -	virtual BOOL getIsSpeaking(const LLUUID& id); -	virtual BOOL getIsModeratorMuted(const LLUUID& id); -	virtual F32 getCurrentPower(const LLUUID& id);		// "power" is related to "amplitude" in a defined way.  I'm just not sure what the formula is... -	virtual BOOL getOnMuteList(const LLUUID& id); -	virtual F32 getUserVolume(const LLUUID& id); -	virtual void setUserVolume(const LLUUID& id, F32 volume); // set's volume for specified agent, from 0-1 (where .5 is nominal)	 +	virtual BOOL getVoiceEnabled(const LLUUID& id) override;		// true if we've received data for this avatar +	virtual std::string getDisplayName(const LLUUID& id) override; +	virtual BOOL isParticipantAvatar(const LLUUID &id) override; +	virtual BOOL getIsSpeaking(const LLUUID& id) override; +	virtual BOOL getIsModeratorMuted(const LLUUID& id) override; +	virtual F32 getCurrentPower(const LLUUID& id) override;		// "power" is related to "amplitude" in a defined way.  I'm just not sure what the formula is... +	virtual BOOL getOnMuteList(const LLUUID& id) override; +	virtual F32 getUserVolume(const LLUUID& id) override; +	virtual void setUserVolume(const LLUUID& id, F32 volume) override; // set's volume for specified agent, from 0-1 (where .5 is nominal)  	//@}  	// authorize the user  	virtual void userAuthorized(const std::string& user_id, -								const LLUUID &agentID); +								const LLUUID &agentID) override;  	//////////////////////////////  	/// @name Status notification  	//@{ -	virtual void addObserver(LLVoiceClientStatusObserver* observer); -	virtual void removeObserver(LLVoiceClientStatusObserver* observer); -	virtual void addObserver(LLFriendObserver* observer); -	virtual void removeObserver(LLFriendObserver* observer);		 -	virtual void addObserver(LLVoiceClientParticipantObserver* observer); -	virtual void removeObserver(LLVoiceClientParticipantObserver* observer); +	virtual void addObserver(LLVoiceClientStatusObserver* observer) override; +	virtual void removeObserver(LLVoiceClientStatusObserver* observer) override; +	virtual void addObserver(LLFriendObserver* observer) override; +	virtual void removeObserver(LLFriendObserver* observer) override; +	virtual void addObserver(LLVoiceClientParticipantObserver* observer) override; +	virtual void removeObserver(LLVoiceClientParticipantObserver* observer) override;  	//@} -	virtual std::string sipURIFromID(const LLUUID &id); +	virtual std::string sipURIFromID(const LLUUID &id) override;  	//@}  	/// @name LLVoiceEffectInterface virtual implementations @@ -216,32 +216,32 @@ public:  	//////////////////////////  	/// @name Accessors  	//@{ -	virtual bool setVoiceEffect(const LLUUID& id); -	virtual const LLUUID getVoiceEffect(); -	virtual LLSD getVoiceEffectProperties(const LLUUID& id); +	virtual bool setVoiceEffect(const LLUUID& id) override; +	virtual const LLUUID getVoiceEffect() override; +	virtual LLSD getVoiceEffectProperties(const LLUUID& id) override; -	virtual void refreshVoiceEffectLists(bool clear_lists); -	virtual const voice_effect_list_t& getVoiceEffectList() const; -	virtual const voice_effect_list_t& getVoiceEffectTemplateList() const; +	virtual void refreshVoiceEffectLists(bool clear_lists) override; +	virtual const voice_effect_list_t& getVoiceEffectList() const override; +	virtual const voice_effect_list_t& getVoiceEffectTemplateList() const override;  	//@}  	//////////////////////////////  	/// @name Status notification  	//@{ -	virtual void addObserver(LLVoiceEffectObserver* observer); -	virtual void removeObserver(LLVoiceEffectObserver* observer); +	virtual void addObserver(LLVoiceEffectObserver* observer) override; +	virtual void removeObserver(LLVoiceEffectObserver* observer) override;  	//@}  	//////////////////////////////  	/// @name Effect preview buffer  	//@{ -	virtual void enablePreviewBuffer(bool enable); -	virtual void recordPreviewBuffer(); -	virtual void playPreviewBuffer(const LLUUID& effect_id = LLUUID::null); -	virtual void stopPreviewBuffer(); +	virtual void enablePreviewBuffer(bool enable) override; +	virtual void recordPreviewBuffer() override; +	virtual void playPreviewBuffer(const LLUUID& effect_id = LLUUID::null) override; +	virtual void stopPreviewBuffer() override; -	virtual bool isPreviewRecording(); -	virtual bool isPreviewPlaying(); +	virtual bool isPreviewRecording() override; +	virtual bool isPreviewPlaying() override;  	//@}  	//@} @@ -752,7 +752,7 @@ private:  	std::string getAudioSessionURI();  	std::string getAudioSessionHandle(); -    void setHidden(bool hidden); //virtual +    void setHidden(bool hidden) override; //virtual  	void sendPositionAndVolumeUpdate(void);      void sendCaptureAndRenderDevices(); diff --git a/indra/newview/llwearableitemslist.h b/indra/newview/llwearableitemslist.h index f7774a7086..0dbe50d5e4 100644 --- a/indra/newview/llwearableitemslist.h +++ b/indra/newview/llwearableitemslist.h @@ -428,7 +428,7 @@ public:  	{  		LLSINGLETON(ContextMenu);  	public: -		/*virtual*/ void show(LLView* spawning_view, const uuid_vec_t& uuids, S32 x, S32 y); +		/*virtual*/ void show(LLView* spawning_view, const uuid_vec_t& uuids, S32 x, S32 y) override;  		void show(LLView* spawning_view, LLWearableType::EType w_type, S32 x, S32 y); @@ -441,7 +441,7 @@ public:  			MASK_UNKNOWN		= 0x10,  		}; -		/* virtual */ LLContextMenu* createMenu(); +		/* virtual */ LLContextMenu* createMenu() override;  		void updateItemsVisibility(LLContextMenu* menu);  		void updateItemsLabels(LLContextMenu* menu);  		static void setMenuItemVisible(LLContextMenu* menu, const std::string& name, bool val); @@ -472,7 +472,7 @@ public:  	virtual ~LLWearableItemsList(); -	/*virtual*/ LLPanel* createNewItem(LLViewerInventoryItem* item); +	/*virtual*/ LLPanel* createNewItem(LLViewerInventoryItem* item) override;  	void updateList(const LLUUID& category_id); diff --git a/indra/newview/llwindebug.h b/indra/newview/llwindebug.h index 524adba652..31dbfb8ffd 100644 --- a/indra/newview/llwindebug.h +++ b/indra/newview/llwindebug.h @@ -40,9 +40,9 @@ class LLWinDebug:  {  	LLSINGLETON_EMPTY_CTOR(LLWinDebug);  public: -	void initSingleton(); +	void initSingleton() override;  	static void generateMinidump(struct _EXCEPTION_POINTERS *pExceptionInfo = NULL); -	void cleanupSingleton(); +	void cleanupSingleton() override;  private:  	static void writeDumpToFile(MINIDUMP_TYPE type, MINIDUMP_EXCEPTION_INFORMATION *ExInfop, const std::string& filename);  };  | 
