From e2552ec6737fe734ffd5b4768193c6a890d66f70 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Tue, 6 Sep 2011 17:45:47 +0300
Subject: STORM-1577 WIP Implemented translation via Microsoft Translator and
 Google Translate v2 APIs.

---
 indra/newview/app_settings/settings.xml |  33 ++++
 indra/newview/lltranslate.cpp           | 312 ++++++++++++++++++++++++++------
 indra/newview/lltranslate.h             |  87 ++-------
 indra/newview/llviewermessage.cpp       |   7 +-
 4 files changed, 316 insertions(+), 123 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml
index 0996f75fbb..2549538df2 100644
--- a/indra/newview/app_settings/settings.xml
+++ b/indra/newview/app_settings/settings.xml
@@ -10922,6 +10922,39 @@
       <key>Value</key>
       <integer>0</integer>
     </map>
+    <key>TranslationService</key>
+    <map>
+      <key>Comment</key>
+      <string>Translation API to use. (google_v1|google_v2|bing)</string>
+      <key>Persist</key>
+      <integer>1</integer>
+      <key>Type</key>
+      <string>String</string>
+      <key>Value</key>
+      <string>google_v1</string>
+    </map>
+    <key>GoogleTranslateAPIv2Key</key>
+    <map>
+      <key>Comment</key>
+      <string>Google Translate API v2 key</string>
+      <key>Persist</key>
+      <integer>1</integer>
+      <key>Type</key>
+      <string>String</string>
+      <key>Value</key>
+      <string></string>
+    </map>
+    <key>BingTranslateAPIKey</key>
+    <map>
+      <key>Comment</key>
+      <string>Bing AppID to use with the Microsoft Translator V2 API</string>
+      <key>Persist</key>
+      <integer>1</integer>
+      <key>Type</key>
+      <string>String</string>
+      <key>Value</key>
+      <string></string>
+    </map>
     <key>TutorialURL</key>
     <map>
       <key>Comment</key>
diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index 2f60b6b90b..e29ea373ce 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -37,74 +37,263 @@
 
 #include "reader.h"
 
-// These two are concatenated with the language specifiers to form a complete Google Translate URL
-const char* LLTranslate::m_GoogleURL = "http://ajax.googleapis.com/ajax/services/language/translate?v=1.0&q=";
-const char* LLTranslate::m_GoogleLangSpec = "&langpair=";
-float LLTranslate::m_GoogleTimeout = 5;
-
-LLSD LLTranslate::m_Header;
-// These constants are for the GET header.
-const char* LLTranslate::m_AcceptHeader = "Accept";
-const char* LLTranslate::m_AcceptType = "text/plain";
-const char* LLTranslate::m_AgentHeader = "User-Agent";
-
-// These constants are in the JSON returned from Google
-const char* LLTranslate::m_GoogleData = "responseData";
-const char* LLTranslate::m_GoogleTranslation = "translatedText";
-const char* LLTranslate::m_GoogleLanguage = "detectedSourceLanguage";
+class LLTranslationAPIHandler
+{
+public:
+	virtual void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const = 0;
 
-//static
-void LLTranslate::translateMessage(LLHTTPClient::ResponderPtr &result, const std::string &from_lang, const std::string &to_lang, const std::string &mesg)
+	virtual bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const = 0;
+
+	virtual ~LLTranslationAPIHandler() {}
+
+protected:
+	static const int STATUS_OK = 200;
+};
+
+class LLGoogleV1Handler : public LLTranslationAPIHandler
 {
-	std::string url;
-	getTranslateUrl(url, from_lang, to_lang, mesg);
+	LOG_CLASS(LLGoogleV1Handler);
+
+public:
+	/*virtual*/ void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const
+	{
+		url = "http://ajax.googleapis.com/ajax/services/language/translate?v=1.0&q="
+			+ LLURI::escape(text)
+			+ "&langpair=" + from_lang + "%7C" + to_lang;
+	}
+
+	/*virtual*/ bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const
+	{
+		Json::Value root;
+		Json::Reader reader;
+
+		if (!reader.parse(body, root))
+		{
+			err_msg = reader.getFormatedErrorMessages();
+			return false;
+		}
+
+		// This API doesn't return proper status in the HTTP response header,
+		// but it is in the body.
+		status = root["responseStatus"].asInt();
+		if (status != STATUS_OK)
+		{
+			err_msg = root["responseDetails"].asString();
+			return false;
+		}
+
+		const Json::Value& response_data = root["responseData"];
+		translation = response_data.get("translatedText", "").asString();
+		detected_lang = response_data.get("detectedSourceLanguage", "").asString();
+		return true;
+	}
+};
+
+class LLGoogleV2Handler : public LLTranslationAPIHandler
+{
+	LOG_CLASS(LLGoogleV2Handler);
+
+public:
+	/*virtual*/ void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const
+	{
+		url = std::string("https://www.googleapis.com/language/translate/v2?key=")
+			+ getAPIKey() + "&q=" + LLURI::escape(text) + "&target=" + to_lang;
+		if (!from_lang.empty())
+		{
+			url += "&source=" + from_lang;
+		}
+	}
+
+	/*virtual*/ bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const
+	{
+		Json::Value root;
+		Json::Reader reader;
+
+		if (!reader.parse(body, root))
+		{
+			err_msg = reader.getFormatedErrorMessages();
+			return false;
+		}
+
+		if (status != STATUS_OK)
+		{
+			const Json::Value& error = root["error"];
+			err_msg = error["message"].asString();
+			status = error["code"].asInt();
+			return false;
+		}
+
+		const Json::Value& response_data = root["data"]["translations"][0U];
+		translation = response_data["translatedText"].asString();
+		detected_lang = response_data["detectedSourceLanguage"].asString();
+		return true;
+	}
+
+private:
+	static std::string getAPIKey()
+	{
+		return gSavedSettings.getString("GoogleTranslateAPIv2Key");
+	}
+};
+
+class LLBingHandler : public LLTranslationAPIHandler
+{
+	LOG_CLASS(LLBingHandler);
 
-    std::string user_agent = llformat("%s %d.%d.%d (%d)",
-		LLVersionInfo::getChannel().c_str(),
-		LLVersionInfo::getMajor(),
-		LLVersionInfo::getMinor(),
-		LLVersionInfo::getPatch(),
-		LLVersionInfo::getBuild());
+public:
+	/*virtual*/ void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const
+	{
+		url = std::string("http://api.microsofttranslator.com/v2/Http.svc/Translate?appId=")
+			+ getAPIKey() + "&text=" + LLURI::escape(text) + "&to=" + to_lang;
+		if (!from_lang.empty())
+		{
+			url += "&from=" + from_lang;
+		}
+	}
 
-	if (!m_Header.size())
+	/*virtual*/ bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const
 	{
-		m_Header.insert(m_AcceptHeader, LLSD(m_AcceptType));
-		m_Header.insert(m_AgentHeader, LLSD(user_agent));
+		if (status != STATUS_OK)
+		{
+			size_t begin = body.find("Message: ");
+			size_t end = body.find("</p>", begin);
+			err_msg = body.substr(begin, end-begin);
+			LLStringUtil::replaceString(err_msg, "&#xD;", ""); // strip CR
+			return false;
+		}
+
+		// Sample response: <string xmlns="http://schemas.microsoft.com/2003/10/Serialization/">Hola</string>
+		size_t begin = body.find(">");
+		if (begin == std::string::npos || begin >= (body.size() - 1))
+		{
+			return false;
+		}
+
+		size_t end = body.find("</string>", ++begin);
+		if (end == std::string::npos || end < begin)
+		{
+			return false;
+		}
+
+		detected_lang = ""; // unsupported by this API
+		translation = body.substr(begin, end-begin);
+		LLStringUtil::replaceString(translation, "&#xD;", ""); // strip CR
+		return true;
 	}
 
-	LLHTTPClient::get(url, result, m_Header, m_GoogleTimeout);
+private:
+	static std::string getAPIKey()
+	{
+		return gSavedSettings.getString("BingTranslateAPIKey");
+	}
+};
+
+LLTranslate::TranslationReceiver::TranslationReceiver(const std::string& from_lang, const std::string& to_lang)
+:	mFromLang(from_lang)
+,	mToLang(to_lang)
+,	mHandler(LLTranslate::getPreferredHandler())
+{
 }
 
-//static
-void LLTranslate::getTranslateUrl(std::string &translate_url, const std::string &from_lang, const std::string &to_lang, const std::string &mesg)
+// virtual
+void LLTranslate::TranslationReceiver::completedRaw(
+	U32 http_status,
+	const std::string& reason,
+	const LLChannelDescriptors& channels,
+	const LLIOPipe::buffer_ptr_t& buffer)
 {
-	char * curl_str = curl_escape(mesg.c_str(), mesg.size());
-	std::string const escaped_mesg(curl_str);
-	curl_free(curl_str);
-
-	translate_url = m_GoogleURL
-		+ escaped_mesg + m_GoogleLangSpec
-		+ from_lang // 'from' language; empty string for auto
-		+ "%7C" // |
-		+ to_lang; // 'to' language
+	LLBufferStream istr(channels, buffer.get());
+	std::stringstream strstrm;
+	strstrm << istr.rdbuf();
+
+	const std::string body = strstrm.str();
+	std::string translation, detected_lang, err_msg;
+	int status = http_status;
+	if (mHandler.parseResponse(status, body, translation, detected_lang, err_msg))
+	{
+		// Fix up the response
+		LLStringUtil::replaceString(translation, "&lt;", "<");
+		LLStringUtil::replaceString(translation, "&gt;",">");
+		LLStringUtil::replaceString(translation, "&quot;","\"");
+		LLStringUtil::replaceString(translation, "&#39;","'");
+		LLStringUtil::replaceString(translation, "&amp;","&");
+		LLStringUtil::replaceString(translation, "&apos;","'");
+
+		handleResponse(translation, detected_lang);
+	}
+	else
+	{
+		llwarns << "Translation request failed: " << err_msg << llendl;
+		LL_DEBUGS("Translate") << "HTTP status: " << status << " " << reason << LL_ENDL;
+		LL_DEBUGS("Translate") << "Error response body: " << body << LL_ENDL;
+		handleFailure(status, err_msg);
+	}
 }
 
 //static
-bool LLTranslate::parseGoogleTranslate(const std::string& body, std::string &translation, std::string &detected_language)
+void LLTranslate::translateMessage(
+	TranslationReceiverPtr &receiver,
+	const std::string &from_lang,
+	const std::string &to_lang,
+	const std::string &mesg)
 {
-	Json::Value root;
-	Json::Reader reader;
-	
-	bool success = reader.parse(body, root);
-	if (!success)
+	std::string url;
+	receiver->mHandler.getTranslateURL(url, from_lang, to_lang, mesg);
+
+	static const float REQUEST_TIMEOUT = 5;
+    static LLSD sHeader;
+
+	if (!sHeader.size())
 	{
-		LL_WARNS("Translate") << "Non valid response from Google Translate API: '" << reader.getFormatedErrorMessages() << "'" << LL_ENDL;
-		return false;
+	    std::string user_agent = llformat("%s %d.%d.%d (%d)",
+			LLVersionInfo::getChannel().c_str(),
+			LLVersionInfo::getMajor(),
+			LLVersionInfo::getMinor(),
+			LLVersionInfo::getPatch(),
+			LLVersionInfo::getBuild());
+
+		sHeader.insert("Accept", "text/plain");
+		sHeader.insert("User-Agent", user_agent);
 	}
-	
-	translation = 			root[m_GoogleData].get(m_GoogleTranslation, "").asString();
-	detected_language = 	root[m_GoogleData].get(m_GoogleLanguage, "").asString();
-	return true;
+
+	LL_DEBUGS("Translate") << "Sending translation request: " << url << LL_ENDL;
+	LLHTTPClient::get(url, receiver, sHeader, REQUEST_TIMEOUT);
 }
 
 //static
@@ -119,3 +308,22 @@ std::string LLTranslate::getTranslateLanguage()
 	return language;
 }
 
+// static
+const LLTranslationAPIHandler& LLTranslate::getPreferredHandler()
+{
+	static LLGoogleV1Handler	google_v1;
+	static LLGoogleV2Handler	google_v2;
+	static LLBingHandler		bing;
+
+	std::string service = gSavedSettings.getString("TranslationService");
+	if (service == "google_v2")
+	{
+		return google_v2;
+	}
+	else if (service == "google_v1")
+	{
+		return google_v1;
+	}
+
+	return bing;
+}
diff --git a/indra/newview/lltranslate.h b/indra/newview/lltranslate.h
index e85a42e878..1dee792f7b 100644
--- a/indra/newview/lltranslate.h
+++ b/indra/newview/lltranslate.h
@@ -30,89 +30,42 @@
 #include "llhttpclient.h"
 #include "llbufferstream.h"
 
+class LLTranslationAPIHandler;
+
 class LLTranslate
 {
 	LOG_CLASS(LLTranslate);
+
 public :
 	class TranslationReceiver: public LLHTTPClient::Responder
 	{
-	protected:
-		TranslationReceiver(const std::string &from_lang, const std::string &to_lang)
-			: m_fromLang(from_lang),
-			m_toLang(to_lang)
-		{
-		}
-
-		virtual void handleResponse(const std::string &translation, const std::string &recognized_lang) {};
-		virtual void handleFailure() {};
-
 	public:
-		~TranslationReceiver()
-		{
-		}
-
-		virtual void completedRaw(	U32 status,
-									const std::string& reason,
-									const LLChannelDescriptors& channels,
-									const LLIOPipe::buffer_ptr_t& buffer)
-		{
-			if (200 <= status && status < 300)
-			{
-				LLBufferStream istr(channels, buffer.get());
-				std::stringstream strstrm;
-				strstrm << istr.rdbuf();
+		/*virtual*/ void completedRaw(
+			U32 http_status,
+			const std::string& reason,
+			const LLChannelDescriptors& channels,
+			const LLIOPipe::buffer_ptr_t& buffer);
 
-				const std::string result = strstrm.str();
-				std::string translation;
-				std::string detected_language;
+	protected:
+		friend class LLTranslate;
 
-				if (!parseGoogleTranslate(result, translation, detected_language))
-				{
-					handleFailure();
-					return;
-				}
-				
-				// Fix up the response
-				LLStringUtil::replaceString(translation, "&lt;", "<");
-				LLStringUtil::replaceString(translation, "&gt;",">");
-				LLStringUtil::replaceString(translation, "&quot;","\"");
-				LLStringUtil::replaceString(translation, "&#39;","'");
-				LLStringUtil::replaceString(translation, "&amp;","&");
-				LLStringUtil::replaceString(translation, "&apos;","'");
+		TranslationReceiver(const std::string& from_lang, const std::string& to_lang);
 
-				handleResponse(translation, detected_language);
-			}
-			else
-			{
-				LL_WARNS("Translate") << "HTTP request for Google Translate failed with status " << status << ", reason: " << reason << LL_ENDL;
-				handleFailure();
-			}
-		}
+		virtual void handleResponse(const std::string &translation, const std::string &recognized_lang) = 0;
+		virtual void handleFailure(int status, const std::string& err_msg) = 0;
 
-	protected:
-		const std::string m_toLang;
-		const std::string m_fromLang;
+		std::string mFromLang;
+		std::string mToLang;
+		const LLTranslationAPIHandler& mHandler;
 	};
 
-	static void translateMessage(LLHTTPClient::ResponderPtr &result, const std::string &from_lang, const std::string &to_lang, const std::string &mesg);
-	static float m_GoogleTimeout;
+	typedef boost::intrusive_ptr<TranslationReceiver> TranslationReceiverPtr;
+
+	static void translateMessage(TranslationReceiverPtr &receiver, const std::string &from_lang, const std::string &to_lang, const std::string &mesg);
 	static std::string getTranslateLanguage();
 
 private:
-	static void getTranslateUrl(std::string &translate_url, const std::string &from_lang, const std::string &to_lang, const std::string &text);
-	static bool parseGoogleTranslate(const std::string& body, std::string &translation, std::string &detected_language);
-
-	static LLSD m_Header;
-	static const char* m_GoogleURL;
-	static const char* m_GoogleLangSpec;
-	static const char* m_AcceptHeader;
-	static const char* m_AcceptType;
-	static const char* m_AgentHeader;
-	static const char* m_UserAgent;
-
-	static const char* m_GoogleData;
-	static const char* m_GoogleTranslation;
-	static const char* m_GoogleLanguage;
+	static const LLTranslationAPIHandler& getPreferredHandler();
 };
 
 #endif
diff --git a/indra/newview/llviewermessage.cpp b/indra/newview/llviewermessage.cpp
index 68745d5aeb..ff02214194 100644
--- a/indra/newview/llviewermessage.cpp
+++ b/indra/newview/llviewermessage.cpp
@@ -3138,7 +3138,7 @@ protected:
 	{
 		// filter out non-interesting responeses
 		if ( !translation.empty()
-			&& (m_toLang != detected_language)
+			&& (mToLang != detected_language)
 			&& (LLStringUtil::compareInsensitive(translation, m_origMesg) != 0) )
 		{
 			m_chat.mText += " (" + translation + ")";
@@ -3147,9 +3147,8 @@ protected:
 		LLNotificationsUI::LLNotificationManager::instance().onChat(m_chat, m_toastArgs);
 	}
 
-	void handleFailure()
+	void handleFailure(int status, const std::string& err_msg)
 	{
-		LLTranslate::TranslationReceiver::handleFailure();
 		m_chat.mText += " (?)";
 
 		LLNotificationsUI::LLNotificationManager::instance().onChat(m_chat, m_toastArgs);
@@ -3388,7 +3387,7 @@ void process_chat_from_simulator(LLMessageSystem *msg, void **user_data)
 			const std::string from_lang = ""; // leave empty to trigger autodetect
 			const std::string to_lang = LLTranslate::getTranslateLanguage();
 
-			LLHTTPClient::ResponderPtr result = ChatTranslationReceiver::build(from_lang, to_lang, mesg, chat, args);
+			LLTranslate::TranslationReceiverPtr result = ChatTranslationReceiver::build(from_lang, to_lang, mesg, chat, args);
 			LLTranslate::translateMessage(result, from_lang, to_lang, mesg);
 		}
 		else
-- 
cgit v1.2.3


From e23ecf311c729be7e6611ef2fe21badaf9f1c3ed Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Wed, 7 Sep 2011 00:09:49 +0300
Subject: STORM-1577 WIP Implemented chat translation preferences management.

---
 indra/newview/CMakeLists.txt                       |   2 +
 indra/newview/llfloaterpreference.cpp              |   9 +
 indra/newview/llfloaterpreference.h                |   1 +
 indra/newview/llfloatertranslationsettings.cpp     | 146 ++++++++++++++
 indra/newview/llfloatertranslationsettings.h       |  59 ++++++
 indra/newview/llviewerfloaterreg.cpp               |   2 +
 .../xui/en/floater_translation_settings.xml        | 222 +++++++++++++++++++++
 .../default/xui/en/panel_preferences_chat.xml      |  12 ++
 8 files changed, 453 insertions(+)
 create mode 100644 indra/newview/llfloatertranslationsettings.cpp
 create mode 100644 indra/newview/llfloatertranslationsettings.h
 create mode 100644 indra/newview/skins/default/xui/en/floater_translation_settings.xml

(limited to 'indra/newview')

diff --git a/indra/newview/CMakeLists.txt b/indra/newview/CMakeLists.txt
index a117d9a593..e7ca2a4294 100644
--- a/indra/newview/CMakeLists.txt
+++ b/indra/newview/CMakeLists.txt
@@ -237,6 +237,7 @@ set(viewer_SOURCE_FILES
     llfloatertools.cpp
     llfloatertopobjects.cpp
     llfloatertos.cpp
+    llfloatertranslationsettings.cpp
     llfloateruipreview.cpp
     llfloaterurlentry.cpp
     llfloatervoiceeffect.cpp
@@ -799,6 +800,7 @@ set(viewer_HEADER_FILES
     llfloatertools.h
     llfloatertopobjects.h
     llfloatertos.h
+    llfloatertranslationsettings.h
     llfloateruipreview.h
     llfloaterurlentry.h
     llfloatervoiceeffect.h
diff --git a/indra/newview/llfloaterpreference.cpp b/indra/newview/llfloaterpreference.cpp
index d65928e385..07c07d608a 100755
--- a/indra/newview/llfloaterpreference.cpp
+++ b/indra/newview/llfloaterpreference.cpp
@@ -345,6 +345,7 @@ LLFloaterPreference::LLFloaterPreference(const LLSD& key)
 	mCommitCallbackRegistrar.add("Pref.MaturitySettings",		boost::bind(&LLFloaterPreference::onChangeMaturity, this));
 	mCommitCallbackRegistrar.add("Pref.BlockList",				boost::bind(&LLFloaterPreference::onClickBlockList, this));
 	mCommitCallbackRegistrar.add("Pref.Proxy",					boost::bind(&LLFloaterPreference::onClickProxySettings, this));
+	mCommitCallbackRegistrar.add("Pref.TranslationSettings",	boost::bind(&LLFloaterPreference::onClickTranslationSettings, this));
 	
 	sSkin = gSavedSettings.getString("SkinCurrent");
 
@@ -602,6 +603,9 @@ void LLFloaterPreference::cancel()
 	}
 	// hide joystick pref floater
 	LLFloaterReg::hideInstance("pref_joystick");
+
+	// hide translation settings floater
+	LLFloaterReg::hideInstance("prefs_translation");
 	
 	// cancel hardware menu
 	LLFloaterHardwareSettings* hardware_settings = LLFloaterReg::getTypedInstance<LLFloaterHardwareSettings>("prefs_hardware_settings");
@@ -1553,6 +1557,11 @@ void LLFloaterPreference::onClickProxySettings()
 	LLFloaterReg::showInstance("prefs_proxy");
 }
 
+void LLFloaterPreference::onClickTranslationSettings()
+{
+	LLFloaterReg::showInstance("prefs_translation");
+}
+
 void LLFloaterPreference::updateDoubleClickControls()
 {
 	// check is one of double-click actions settings enabled
diff --git a/indra/newview/llfloaterpreference.h b/indra/newview/llfloaterpreference.h
index ef9bc2dd53..ee6bb235be 100644
--- a/indra/newview/llfloaterpreference.h
+++ b/indra/newview/llfloaterpreference.h
@@ -157,6 +157,7 @@ public:
 	void onChangeMaturity();
 	void onClickBlockList();
 	void onClickProxySettings();
+	void onClickTranslationSettings();
 	void applyUIColor(LLUICtrl* ctrl, const LLSD& param);
 	void getUIColor(LLUICtrl* ctrl, const LLSD& param);
 	
diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
new file mode 100644
index 0000000000..56f101d149
--- /dev/null
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -0,0 +1,146 @@
+/** 
+ * @file llfloatertranslationsettings.cpp
+ * @brief Machine translation settings for chat
+ *
+ * $LicenseInfo:firstyear=2011&license=viewerlgpl$
+ * Second Life Viewer Source Code
+ * Copyright (C) 2011, Linden Research, Inc.
+ * 
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation;
+ * version 2.1 of the License only.
+ * 
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ * 
+ * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA
+ * $/LicenseInfo$
+ */
+
+#include "llviewerprecompiledheaders.h"
+
+#include "llfloatertranslationsettings.h"
+
+// Viewer includes
+#include "llviewercontrol.h" // for gSavedSettings
+
+// Linden library includes
+#include "llbutton.h"
+#include "llcheckboxctrl.h"
+#include "llcombobox.h"
+#include "llfloaterreg.h"
+#include "lllineeditor.h"
+#include "llnotificationsutil.h"
+#include "llradiogroup.h"
+
+LLFloaterTranslationSettings::LLFloaterTranslationSettings(const LLSD& key)
+:	LLFloater(key)
+,	mMachineTranslationCB(NULL)
+,	mLanguageCombo(NULL)
+,	mTranslationServiceRadioGroup(NULL)
+,	mBingAPIKeyEditor(NULL)
+,	mGoogleAPIKeyEditor(NULL)
+{
+}
+
+// virtual
+BOOL LLFloaterTranslationSettings::postBuild()
+{
+	mMachineTranslationCB = getChild<LLCheckBoxCtrl>("translate_chat_checkbox");
+	mLanguageCombo = getChild<LLComboBox>("translate_language_combo");
+	mTranslationServiceRadioGroup = getChild<LLRadioGroup>("translation_service_rg");
+	mBingAPIKeyEditor = getChild<LLLineEditor>("bing_api_key");
+	mGoogleAPIKeyEditor = getChild<LLLineEditor>("google_api_key");
+
+	mMachineTranslationCB->setCommitCallback(boost::bind(&LLFloaterTranslationSettings::updateControlsEnabledState, this));
+	mTranslationServiceRadioGroup->setCommitCallback(boost::bind(&LLFloaterTranslationSettings::updateControlsEnabledState, this));
+	getChild<LLButton>("ok_btn")->setClickedCallback(boost::bind(&LLFloaterTranslationSettings::onBtnOK, this));
+	getChild<LLButton>("cancel_btn")->setClickedCallback(boost::bind(&LLFloater::closeFloater, this, false));
+
+	center();
+	return TRUE;
+}
+
+// virtual
+void LLFloaterTranslationSettings::onOpen(const LLSD& key)
+{
+	mMachineTranslationCB->setValue(gSavedSettings.getBOOL("TranslateChat"));
+	mLanguageCombo->setSelectedByValue(gSavedSettings.getString("TranslateLanguage"), TRUE);
+	mTranslationServiceRadioGroup->setSelectedByValue(gSavedSettings.getString("TranslationService"), TRUE);
+	mBingAPIKeyEditor->setText(gSavedSettings.getString("BingTranslateAPIKey"));
+	mGoogleAPIKeyEditor->setText(gSavedSettings.getString("GoogleTranslateAPIv2Key"));
+
+	updateControlsEnabledState();
+}
+
+std::string LLFloaterTranslationSettings::getSelectedService() const
+{
+	return mTranslationServiceRadioGroup->getSelectedValue().asString();
+}
+
+void LLFloaterTranslationSettings::showError(const std::string& err_name)
+{
+	LLSD args;
+	args["MESSAGE"] = getString(err_name);
+	LLNotificationsUtil::add("GenericAlert", args);
+}
+
+bool LLFloaterTranslationSettings::validate()
+{
+	bool translate_chat = mMachineTranslationCB->getValue().asBoolean();
+	if (!translate_chat) return true;
+
+	std::string service = getSelectedService();
+	if (service == "bing" && mBingAPIKeyEditor->getText().empty())
+	{
+		showError("no_bing_api_key");
+		return false;
+	}
+
+	if (service == "google_v2" && mGoogleAPIKeyEditor->getText().empty())
+	{
+		showError("no_google_api_key");
+		return false;
+	}
+
+	return true;
+}
+
+void LLFloaterTranslationSettings::updateControlsEnabledState()
+{
+	// Enable/disable controls based on the checkbox value.
+	bool on = mMachineTranslationCB->getValue().asBoolean();
+	std::string service = getSelectedService();
+
+	mTranslationServiceRadioGroup->setEnabled(on);
+	mLanguageCombo->setEnabled(on);
+
+	getChild<LLTextBox>("bing_api_key_label")->setEnabled(on);
+	mBingAPIKeyEditor->setEnabled(on);
+
+	getChild<LLTextBox>("google_api_key_label")->setEnabled(on);
+	mGoogleAPIKeyEditor->setEnabled(on);
+
+	mBingAPIKeyEditor->setEnabled(service == "bing");
+	mGoogleAPIKeyEditor->setEnabled(service == "google_v2");
+}
+
+void LLFloaterTranslationSettings::onBtnOK()
+{
+	if (validate())
+	{
+		gSavedSettings.setBOOL("TranslateChat", mMachineTranslationCB->getValue().asBoolean());
+		gSavedSettings.setString("TranslateLanguage", mLanguageCombo->getSelectedValue().asString());
+		gSavedSettings.setString("TranslationService", getSelectedService());
+		gSavedSettings.setString("BingTranslateAPIKey", mBingAPIKeyEditor->getText());
+		gSavedSettings.setString("GoogleTranslateAPIv2Key", mGoogleAPIKeyEditor->getText());
+		closeFloater(false);
+	}
+}
diff --git a/indra/newview/llfloatertranslationsettings.h b/indra/newview/llfloatertranslationsettings.h
new file mode 100644
index 0000000000..1c03b86f4d
--- /dev/null
+++ b/indra/newview/llfloatertranslationsettings.h
@@ -0,0 +1,59 @@
+/** 
+ * @file llfloatertranslationsettings.h
+ * @brief Machine translation settings for chat
+ *
+ * $LicenseInfo:firstyear=2011&license=viewerlgpl$
+ * Second Life Viewer Source Code
+ * Copyright (C) 2011, Linden Research, Inc.
+ * 
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation;
+ * version 2.1 of the License only.
+ * 
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ * 
+ * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA
+ * $/LicenseInfo$
+ */
+
+#ifndef LL_LLFLOATERTRANSLATIONSETTINGS_H
+#define LL_LLFLOATERTRANSLATIONSETTINGS_H
+
+#include "llfloater.h"
+
+class LLCheckBoxCtrl;
+class LLComboBox;
+class LLLineEditor;
+class LLRadioGroup;
+
+class LLFloaterTranslationSettings : public LLFloater
+{
+public:
+	LLFloaterTranslationSettings(const LLSD& key);
+	/*virtual*/ BOOL postBuild();
+	/*virtual*/ void onOpen(const LLSD& key);
+
+private:
+	std::string getSelectedService() const;
+	void showError(const std::string& err_name);
+	bool validate();
+	void updateControlsEnabledState();
+	void onMachineTranslationToggle();
+	void onBtnOK();
+
+	LLCheckBoxCtrl* mMachineTranslationCB;
+	LLComboBox* mLanguageCombo;
+	LLLineEditor* mBingAPIKeyEditor;
+	LLLineEditor* mGoogleAPIKeyEditor;
+	LLRadioGroup* mTranslationServiceRadioGroup;
+};
+
+#endif // LL_LLFLOATERTRANSLATIONSETTINGS_H
diff --git a/indra/newview/llviewerfloaterreg.cpp b/indra/newview/llviewerfloaterreg.cpp
index fecc6d91bd..3be26d87e2 100644
--- a/indra/newview/llviewerfloaterreg.cpp
+++ b/indra/newview/llviewerfloaterreg.cpp
@@ -102,6 +102,7 @@
 #include "llfloatertools.h"
 #include "llfloatertos.h"
 #include "llfloatertopobjects.h"
+#include "llfloatertranslationsettings.h"
 #include "llfloateruipreview.h"
 #include "llfloatervoiceeffect.h"
 #include "llfloaterwhitelistentry.h"
@@ -234,6 +235,7 @@ void LLViewerFloaterReg::registerFloaters()
 	LLFloaterReg::add("preferences", "floater_preferences.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLFloaterPreference>);
 	LLFloaterReg::add("prefs_proxy", "floater_preferences_proxy.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLFloaterPreferenceProxy>);
 	LLFloaterReg::add("prefs_hardware_settings", "floater_hardware_settings.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLFloaterHardwareSettings>);
+	LLFloaterReg::add("prefs_translation", "floater_translation_settings.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLFloaterTranslationSettings>);
 	LLFloaterReg::add("perm_prefs", "floater_perm_prefs.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLFloaterPerms>);
 	LLFloaterReg::add("pref_joystick", "floater_joystick.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLFloaterJoystick>);
 	LLFloaterReg::add("preview_anim", "floater_preview_animation.xml", (LLFloaterBuildFunc)&LLFloaterReg::build<LLPreviewAnim>, "preview");
diff --git a/indra/newview/skins/default/xui/en/floater_translation_settings.xml b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
new file mode 100644
index 0000000000..40a176830c
--- /dev/null
+++ b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
@@ -0,0 +1,222 @@
+<?xml version="1.0" encoding="utf-8" standalone="yes" ?>
+<floater
+ legacy_header_height="18"
+ height="320"
+ layout="topleft"
+ name="floater_translation_settings"
+ help_topic="environment_editor_floater"
+ save_rect="true"
+ title="TRANSLATION SETTINGS"
+ width="350">
+
+ <string name="no_bing_api_key">Bing Translator requires and appID to function.</string>
+ <string name="no_google_api_key">Google Translate requires an API key to function.</string>
+
+ <check_box
+  height="16"     
+  label="Use machine translation while chatting"
+  layout="topleft"
+  left="10"
+  name="translate_chat_checkbox"
+  top="30"
+  width="20" />
+ <text
+  height="20"
+  follows="left|top"
+  layout="topleft"
+  left="10"
+  name="translate_language_label"
+  top_pad="20"
+  width="130">
+  Translate chat into: 
+ </text>
+ <combo_box
+  allow_text_entry="true"
+  follows="left|top"
+  height="23"
+  left_pad="10"
+  max_chars="135"
+  mouse_opaque="true"
+  name="translate_language_combo"
+  top_delta="-5"
+  width="190">
+  <combo_box.item
+   label="System Default"
+   name="System Default Language"
+   value="default" />
+  <combo_box.item
+   label="English"
+   name="English"
+   value="en" />
+  <!-- After "System Default" and "English", please keep the rest of these combo_box.items in alphabetical order by the first character in the string. -->
+  <combo_box.item
+   label="Dansk (Danish)"
+   name="Danish"
+   value="da" />
+  <combo_box.item
+   label="Deutsch (German)"
+   name="German"
+   value="de" />
+  <combo_box.item
+   label="Español (Spanish)"
+   name="Spanish"
+   value="es" />
+  <combo_box.item
+   label="Français (French)"
+   name="French"
+   value="fr" />
+  <combo_box.item
+   label="Italiano (Italian)"
+   name="Italian"
+   value="it" />
+  <combo_box.item
+   label="Magyar (Hungarian)"
+   name="Hungarian"
+   value="hu" />
+  <combo_box.item
+   label="Nederlands (Dutch)"
+   name="Dutch"
+   value="nl" />
+  <combo_box.item
+   label="Polski (Polish)"
+   name="Polish"
+   value="pl" />
+  <combo_box.item
+   label="Português (Portuguese)"
+   name="Portugese"
+   value="pt" />
+  <combo_box.item
+   label="Русский (Russian)"
+   name="Russian"
+   value="ru" />
+  <combo_box.item
+   label="Türkçe (Turkish)"
+   name="Turkish"
+   value="tr" />
+  <combo_box.item
+   label="Українська (Ukrainian)"
+   name="Ukrainian"
+   value="uk" />
+  <combo_box.item
+   label="中文 (简体) (Chinese)"
+   name="Chinese"
+   value="zh" />
+  <combo_box.item
+   label="日本語 (Japanese)"
+   name="Japanese"
+   value="ja" />
+  <combo_box.item
+   label="한국어 (Korean)"
+   name="Korean"
+   value="ko" />
+ </combo_box>
+
+ <text
+  follows="top|left|right"
+  height="15"
+  layout="topleft"
+  left="10"
+  name="tip"
+  top_pad="20"
+  width="330"
+  wrap="true">
+  Choose translation service to use:
+ </text>
+
+ <radio_group
+  follows="top|left"
+  height="55"
+  layout="topleft"
+  left_delta="10"
+  name="translation_service_rg"
+  top_pad="20"
+  width="320">
+  <radio_item
+   initial_value="bing"
+   label="Bing Translator"
+   layout="topleft"
+   name="bing" />
+  <radio_item
+   initial_value="google_v2"
+   label="Google Translate"
+   layout="topleft"
+   name="google_v2"
+   top_pad="20" />
+ </radio_group>
+
+ <text
+  type="string"
+  length="1"
+  follows="top|right"
+  height="20"
+  layout="topleft"
+  left="10"
+  name="bing_api_key_label"
+  top_pad="20"
+  width="100">
+  Bing [http://www.bing.com/developers/createapp.aspx AppID]:
+  </text>
+ <line_editor
+  follows="top|left"
+  height="20"
+  layout="topleft"
+  left_pad="10"
+  max_length_chars="50"
+  top_delta="-4"
+  name="bing_api_key"
+  value=""
+  width="220" />
+
+ <text
+  follows="top|right"
+  height="20"
+  layout="topleft"
+  left="10"
+  length="1"
+  name="google_api_key_label"
+  top_pad="20"
+  type="string"
+  width="100">
+  Google [http://code.google.com/apis/language/translate/v2/pricing.html API key]:
+ </text>
+ <line_editor
+  follows="top|left"
+  height="20"
+  layout="topleft"
+  left_pad="10"
+  max_length_chars="50"
+  top_delta="-4"
+  name="google_api_key"
+  width="220" />
+
+ <text
+  follows="top|right"
+  height="20"
+  layout="topleft"
+  left="155"
+  length="1"
+  name="google_pricing_link"
+  top_delta="-80"
+  type="string"
+  width="100">
+  ([http://code.google.com/apis/language/translate/v2/pricing.html pricing])
+ </text>
+
+ <button
+  follows="left|top"
+  height="23"
+  label="OK"
+  layout="topleft"
+  right="-120"
+  name="ok_btn"
+  top="-30"
+  width="100" />
+ <button
+  follows="left|top"
+  height="23"
+  label="Cancel"
+  layout="topleft"
+  left_pad="10"
+  name="cancel_btn"
+  width="100" />	
+</floater>
diff --git a/indra/newview/skins/default/xui/en/panel_preferences_chat.xml b/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
index ea09286592..3fbf484ab2 100644
--- a/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
+++ b/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
@@ -319,4 +319,16 @@
          name="Korean"
          value="ko" />
     </combo_box>
+  <button
+   follows="left|top"
+   height="23"
+   label="Translation Settings"
+   layout="topleft"
+   right="-50"
+   name="ok_btn"
+   top="-30"
+   width="130">
+   <button.commit_callback
+    function="Pref.TranslationSettings" />
+  </button>
 </panel>
\ No newline at end of file
-- 
cgit v1.2.3


From 7975ab138b6ac54fc831613e4d3dfb913c5efbd2 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Wed, 7 Sep 2011 16:14:47 +0300
Subject: STORM-1577 Removed support for Google Translate v1 API.

---
 indra/newview/app_settings/settings.xml            | 10 ++--
 indra/newview/llfloatertranslationsettings.cpp     |  8 +--
 indra/newview/lltranslate.cpp                      | 67 +++-------------------
 .../xui/en/floater_translation_settings.xml        |  4 +-
 4 files changed, 18 insertions(+), 71 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml
index 2549538df2..2f1a2093b2 100644
--- a/indra/newview/app_settings/settings.xml
+++ b/indra/newview/app_settings/settings.xml
@@ -10925,18 +10925,18 @@
     <key>TranslationService</key>
     <map>
       <key>Comment</key>
-      <string>Translation API to use. (google_v1|google_v2|bing)</string>
+      <string>Translation API to use. (google|bing)</string>
       <key>Persist</key>
       <integer>1</integer>
       <key>Type</key>
       <string>String</string>
       <key>Value</key>
-      <string>google_v1</string>
+      <string>bing</string>
     </map>
-    <key>GoogleTranslateAPIv2Key</key>
+    <key>GoogleTranslateAPIKey</key>
     <map>
       <key>Comment</key>
-      <string>Google Translate API v2 key</string>
+      <string>Google Translate API key</string>
       <key>Persist</key>
       <integer>1</integer>
       <key>Type</key>
@@ -10947,7 +10947,7 @@
     <key>BingTranslateAPIKey</key>
     <map>
       <key>Comment</key>
-      <string>Bing AppID to use with the Microsoft Translator V2 API</string>
+      <string>Bing AppID to use with the Microsoft Translator API</string>
       <key>Persist</key>
       <integer>1</integer>
       <key>Type</key>
diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
index 56f101d149..107205aed3 100644
--- a/indra/newview/llfloatertranslationsettings.cpp
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -75,7 +75,7 @@ void LLFloaterTranslationSettings::onOpen(const LLSD& key)
 	mLanguageCombo->setSelectedByValue(gSavedSettings.getString("TranslateLanguage"), TRUE);
 	mTranslationServiceRadioGroup->setSelectedByValue(gSavedSettings.getString("TranslationService"), TRUE);
 	mBingAPIKeyEditor->setText(gSavedSettings.getString("BingTranslateAPIKey"));
-	mGoogleAPIKeyEditor->setText(gSavedSettings.getString("GoogleTranslateAPIv2Key"));
+	mGoogleAPIKeyEditor->setText(gSavedSettings.getString("GoogleTranslateAPIKey"));
 
 	updateControlsEnabledState();
 }
@@ -104,7 +104,7 @@ bool LLFloaterTranslationSettings::validate()
 		return false;
 	}
 
-	if (service == "google_v2" && mGoogleAPIKeyEditor->getText().empty())
+	if (service == "google" && mGoogleAPIKeyEditor->getText().empty())
 	{
 		showError("no_google_api_key");
 		return false;
@@ -129,7 +129,7 @@ void LLFloaterTranslationSettings::updateControlsEnabledState()
 	mGoogleAPIKeyEditor->setEnabled(on);
 
 	mBingAPIKeyEditor->setEnabled(service == "bing");
-	mGoogleAPIKeyEditor->setEnabled(service == "google_v2");
+	mGoogleAPIKeyEditor->setEnabled(service == "google");
 }
 
 void LLFloaterTranslationSettings::onBtnOK()
@@ -140,7 +140,7 @@ void LLFloaterTranslationSettings::onBtnOK()
 		gSavedSettings.setString("TranslateLanguage", mLanguageCombo->getSelectedValue().asString());
 		gSavedSettings.setString("TranslationService", getSelectedService());
 		gSavedSettings.setString("BingTranslateAPIKey", mBingAPIKeyEditor->getText());
-		gSavedSettings.setString("GoogleTranslateAPIv2Key", mGoogleAPIKeyEditor->getText());
+		gSavedSettings.setString("GoogleTranslateAPIKey", mGoogleAPIKeyEditor->getText());
 		closeFloater(false);
 	}
 }
diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index e29ea373ce..6576cbbe64 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -59,57 +59,9 @@ protected:
 	static const int STATUS_OK = 200;
 };
 
-class LLGoogleV1Handler : public LLTranslationAPIHandler
+class LLGoogleHandler : public LLTranslationAPIHandler
 {
-	LOG_CLASS(LLGoogleV1Handler);
-
-public:
-	/*virtual*/ void getTranslateURL(
-		std::string &url,
-		const std::string &from_lang,
-		const std::string &to_lang,
-		const std::string &text) const
-	{
-		url = "http://ajax.googleapis.com/ajax/services/language/translate?v=1.0&q="
-			+ LLURI::escape(text)
-			+ "&langpair=" + from_lang + "%7C" + to_lang;
-	}
-
-	/*virtual*/ bool parseResponse(
-		int& status,
-		const std::string& body,
-		std::string& translation,
-		std::string& detected_lang,
-		std::string& err_msg) const
-	{
-		Json::Value root;
-		Json::Reader reader;
-
-		if (!reader.parse(body, root))
-		{
-			err_msg = reader.getFormatedErrorMessages();
-			return false;
-		}
-
-		// This API doesn't return proper status in the HTTP response header,
-		// but it is in the body.
-		status = root["responseStatus"].asInt();
-		if (status != STATUS_OK)
-		{
-			err_msg = root["responseDetails"].asString();
-			return false;
-		}
-
-		const Json::Value& response_data = root["responseData"];
-		translation = response_data.get("translatedText", "").asString();
-		detected_lang = response_data.get("detectedSourceLanguage", "").asString();
-		return true;
-	}
-};
-
-class LLGoogleV2Handler : public LLTranslationAPIHandler
-{
-	LOG_CLASS(LLGoogleV2Handler);
+	LOG_CLASS(LLGoogleHandler);
 
 public:
 	/*virtual*/ void getTranslateURL(
@@ -159,7 +111,7 @@ public:
 private:
 	static std::string getAPIKey()
 	{
-		return gSavedSettings.getString("GoogleTranslateAPIv2Key");
+		return gSavedSettings.getString("GoogleTranslateAPIKey");
 	}
 };
 
@@ -311,18 +263,13 @@ std::string LLTranslate::getTranslateLanguage()
 // static
 const LLTranslationAPIHandler& LLTranslate::getPreferredHandler()
 {
-	static LLGoogleV1Handler	google_v1;
-	static LLGoogleV2Handler	google_v2;
-	static LLBingHandler		bing;
+	static LLGoogleHandler	google;
+	static LLBingHandler	bing;
 
 	std::string service = gSavedSettings.getString("TranslationService");
-	if (service == "google_v2")
-	{
-		return google_v2;
-	}
-	else if (service == "google_v1")
+	if (service == "google")
 	{
-		return google_v1;
+		return google;
 	}
 
 	return bing;
diff --git a/indra/newview/skins/default/xui/en/floater_translation_settings.xml b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
index 40a176830c..f21f64fcf6 100644
--- a/indra/newview/skins/default/xui/en/floater_translation_settings.xml
+++ b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
@@ -137,10 +137,10 @@
    layout="topleft"
    name="bing" />
   <radio_item
-   initial_value="google_v2"
+   initial_value="google"
    label="Google Translate"
    layout="topleft"
-   name="google_v2"
+   name="google"
    top_pad="20" />
  </radio_group>
 
-- 
cgit v1.2.3


From 1fad7d997d99715cc88b6e69ae325f28be413206 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Wed, 7 Sep 2011 19:12:35 +0300
Subject: STORM-1577 Made parsing translation responses more robust.

JsonCpp is prone to aborting the program on failed assertions,
so be super-careful and verify the response format.
---
 indra/newview/lltranslate.cpp                  | 72 +++++++++++++++++++++++---
 indra/newview/skins/default/xui/en/strings.xml |  3 ++
 2 files changed, 67 insertions(+), 8 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index 6576cbbe64..895d8f78eb 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -31,6 +31,7 @@
 #include <curl/curl.h>
 
 #include "llbufferstream.h"
+#include "lltrans.h"
 #include "llui.h"
 #include "llversioninfo.h"
 #include "llviewercontrol.h"
@@ -94,21 +95,66 @@ public:
 			return false;
 		}
 
+		if (!root.isObject()) // empty response? should not happen
+		{
+			return false;
+		}
+
 		if (status != STATUS_OK)
 		{
-			const Json::Value& error = root["error"];
-			err_msg = error["message"].asString();
-			status = error["code"].asInt();
+			// Request failed. Extract error message from the response.
+			parseErrorResponse(root, status, err_msg);
 			return false;
 		}
 
-		const Json::Value& response_data = root["data"]["translations"][0U];
-		translation = response_data["translatedText"].asString();
-		detected_lang = response_data["detectedSourceLanguage"].asString();
-		return true;
+		// Request succeeded, extract translation from the response.
+		return parseTranslation(root, translation, detected_lang);
 	}
 
 private:
+	static void parseErrorResponse(
+		const Json::Value& root,
+		int& status,
+		std::string& err_msg)
+	{
+		const Json::Value& error = root.get("error", 0);
+		if (!error.isObject() || !error.isMember("message") || !error.isMember("code"))
+		{
+			return;
+		}
+
+		err_msg = error["message"].asString();
+		status = error["code"].asInt();
+	}
+
+	static bool parseTranslation(
+		const Json::Value& root,
+		std::string& translation,
+		std::string& detected_lang)
+	{
+		const Json::Value& data = root.get("data", 0);
+		if (!data.isObject() || !data.isMember("translations"))
+		{
+			return false;
+		}
+
+		const Json::Value& translations = data["translations"];
+		if (!translations.isArray() || translations.size() == 0)
+		{
+			return false;
+		}
+
+		const Json::Value& first = translations[0U];
+		if (!first.isObject() || !first.isMember("translatedText"))
+		{
+			return false;
+		}
+
+		translation = first["translatedText"].asString();
+		detected_lang = first.get("detectedSourceLanguage", "").asString();
+		return true;
+	}
+
 	static std::string getAPIKey()
 	{
 		return gSavedSettings.getString("GoogleTranslateAPIKey");
@@ -143,7 +189,12 @@ public:
 	{
 		if (status != STATUS_OK)
 		{
-			size_t begin = body.find("Message: ");
+			static const std::string MSG_BEGIN_MARKER = "Message: ";
+			size_t begin = body.find(MSG_BEGIN_MARKER);
+			if (begin != std::string::npos)
+			{
+				begin += MSG_BEGIN_MARKER.size();
+			}
 			size_t end = body.find("</p>", begin);
 			err_msg = body.substr(begin, end-begin);
 			LLStringUtil::replaceString(err_msg, "&#xD;", ""); // strip CR
@@ -211,6 +262,11 @@ void LLTranslate::TranslationReceiver::completedRaw(
 	}
 	else
 	{
+		if (err_msg.empty())
+		{
+			err_msg = LLTrans::getString("TranslationResponseParseError");
+		}
+
 		llwarns << "Translation request failed: " << err_msg << llendl;
 		LL_DEBUGS("Translate") << "HTTP status: " << status << " " << reason << LL_ENDL;
 		LL_DEBUGS("Translate") << "Error response body: " << body << LL_ENDL;
diff --git a/indra/newview/skins/default/xui/en/strings.xml b/indra/newview/skins/default/xui/en/strings.xml
index 2094275bed..146665b47d 100644
--- a/indra/newview/skins/default/xui/en/strings.xml
+++ b/indra/newview/skins/default/xui/en/strings.xml
@@ -3502,6 +3502,9 @@ Try enclosing path to the editor with double quotes.
  <string name="ExternalEditorCommandParseError">Error parsing the external editor command.</string>
  <string name="ExternalEditorFailedToRun">External editor failed to run.</string>
 
+ <!--  Machine translation of chat messahes -->
+ <string name="TranslationResponseParseError">Error parsing translation response.</string>
+
   <!-- Key names begin -->
   <string name="Esc">Esc</string>
   <string name="Space">Space</string>
-- 
cgit v1.2.3


From ef01821337a0dc428fd090ae94c8cc9d9a13bdb5 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Wed, 7 Sep 2011 19:29:57 +0300
Subject: STORM-1577 WIP Removed old translation settings controls.

They are now superceded with a separate floater.
---
 .../default/xui/en/panel_preferences_chat.xml      | 119 +--------------------
 1 file changed, 2 insertions(+), 117 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/skins/default/xui/en/panel_preferences_chat.xml b/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
index 3fbf484ab2..28db34f4d4 100644
--- a/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
+++ b/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
@@ -204,129 +204,14 @@
      name="nearby_toasts_fadingtime"
      top_pad="3"
      width="325" />
-    
-    <check_box
-     control_name="TranslateChat"
-     enabled="true"
-     height="16"     
-     layout="topleft"
-     left="30"
-     name="translate_chat_checkbox"
-     top_pad="5"
-     width="400" />
-     <!-- *HACK 
-     	After storm-1109 will be fixed: instead of using this text_box, word_wrap should be applied for "translate_chat_checkbox" check_box's label.-->
-     <text
-      follows="top|left"
-      height="15"
-      layout="topleft"
-      left="50"
-      name="translate_chb_label"
-      top_delta="1"
-      width="450"
-      wrap="true">
-      Use machine translation while chatting (powered by Google)
-     </text>
-    <text
-     top_pad="20"
-     name="translate_language_text"
-     follows="left|top"
-     layout="topleft"
-     left_delta="20"
-     height="20"
-     width="110">
-     Translate chat into: 
-    </text>
-    <combo_box
-     allow_text_entry="true"
-     bottom_delta="3"
-     control_name="TranslateLanguage"
-     enabled="true"
-     follows="left|top"
-     height="23"
-     left_delta="110"
-     max_chars="135"
-     mouse_opaque="true"
-     name="translate_language_combobox"
-     width="146">
-        <combo_box.item
-         label="System Default"
-         name="System Default Language"
-         value="default" />
-        <combo_box.item
-         label="English"
-         name="English"
-         value="en" />
-        <!-- After "System Default" and "English", please keep the rest of these combo_box.items in alphabetical order by the first character in the string. -->
-        <combo_box.item
-         label="Dansk (Danish)"
-         name="Danish"
-         value="da" />
-        <combo_box.item
-         label="Deutsch (German)"
-         name="German"
-         value="de" />
-        <combo_box.item
-         label="Español (Spanish)"
-         name="Spanish"
-         value="es" />
-        <combo_box.item
-         label="Français (French)"
-         name="French"
-         value="fr" />
-        <combo_box.item
-         label="Italiano (Italian)"
-         name="Italian"
-         value="it" />
-        <combo_box.item
-         label="Magyar (Hungarian)"
-         name="Hungarian"
-         value="hu" />
-        <combo_box.item
-         label="Nederlands (Dutch)"
-         name="Dutch"
-         value="nl" />
-        <combo_box.item
-         label="Polski (Polish)"
-         name="Polish"
-         value="pl" />
-        <combo_box.item
-         label="Português (Portuguese)"
-         name="Portugese"
-         value="pt" />
-        <combo_box.item
-         label="Русский (Russian)"
-         name="Russian"
-         value="ru" />
-        <combo_box.item
-         label="Türkçe (Turkish)"
-         name="Turkish"
-         value="tr" />
-        <combo_box.item
-         label="Українська (Ukrainian)"
-         name="Ukrainian"
-         value="uk" />
-        <combo_box.item
-         label="中文 (简体) (Chinese)"
-         name="Chinese"
-         value="zh" />
-        <combo_box.item
-         label="日本語 (Japanese)"
-         name="Japanese"
-         value="ja" />
-        <combo_box.item
-         label="한국어 (Korean)"
-         name="Korean"
-         value="ko" />
-    </combo_box>
   <button
    follows="left|top"
    height="23"
    label="Translation Settings"
    layout="topleft"
-   right="-50"
+   left="30"
    name="ok_btn"
-   top="-30"
+   top="-40"
    width="130">
    <button.commit_callback
     function="Pref.TranslationSettings" />
-- 
cgit v1.2.3


From daf9c53595ebad3561b2a0ea00d9da2f697189d0 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Wed, 7 Sep 2011 19:38:40 +0300
Subject: STORM-1577 WIP Fix: disable both line editors if machine translation
 is disabled.

---
 indra/newview/llfloatertranslationsettings.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
index 107205aed3..3e77578997 100644
--- a/indra/newview/llfloatertranslationsettings.cpp
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -128,8 +128,8 @@ void LLFloaterTranslationSettings::updateControlsEnabledState()
 	getChild<LLTextBox>("google_api_key_label")->setEnabled(on);
 	mGoogleAPIKeyEditor->setEnabled(on);
 
-	mBingAPIKeyEditor->setEnabled(service == "bing");
-	mGoogleAPIKeyEditor->setEnabled(service == "google");
+	mBingAPIKeyEditor->setEnabled(on && service == "bing");
+	mGoogleAPIKeyEditor->setEnabled(on && service == "google");
 }
 
 void LLFloaterTranslationSettings::onBtnOK()
-- 
cgit v1.2.3


From 2c7e943cd2a0e08e7a8216fded332cac18fcc79c Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Wed, 7 Sep 2011 19:56:39 +0300
Subject: STORM-1577 WIP Minor cleanup.

---
 indra/newview/llfloatertranslationsettings.cpp | 4 ++--
 indra/newview/llfloatertranslationsettings.h   | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
index 3e77578997..4079fdf482 100644
--- a/indra/newview/llfloatertranslationsettings.cpp
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -85,14 +85,14 @@ std::string LLFloaterTranslationSettings::getSelectedService() const
 	return mTranslationServiceRadioGroup->getSelectedValue().asString();
 }
 
-void LLFloaterTranslationSettings::showError(const std::string& err_name)
+void LLFloaterTranslationSettings::showError(const std::string& err_name) const
 {
 	LLSD args;
 	args["MESSAGE"] = getString(err_name);
 	LLNotificationsUtil::add("GenericAlert", args);
 }
 
-bool LLFloaterTranslationSettings::validate()
+bool LLFloaterTranslationSettings::validate() const
 {
 	bool translate_chat = mMachineTranslationCB->getValue().asBoolean();
 	if (!translate_chat) return true;
diff --git a/indra/newview/llfloatertranslationsettings.h b/indra/newview/llfloatertranslationsettings.h
index 1c03b86f4d..47e2fc80e6 100644
--- a/indra/newview/llfloatertranslationsettings.h
+++ b/indra/newview/llfloatertranslationsettings.h
@@ -43,10 +43,9 @@ public:
 
 private:
 	std::string getSelectedService() const;
-	void showError(const std::string& err_name);
-	bool validate();
+	void showError(const std::string& err_name) const;
+	bool validate() const;
 	void updateControlsEnabledState();
-	void onMachineTranslationToggle();
 	void onBtnOK();
 
 	LLCheckBoxCtrl* mMachineTranslationCB;
-- 
cgit v1.2.3


From a21a55482a076aa690ca947411f439dd14d59443 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Fri, 9 Sep 2011 20:09:01 +0300
Subject: STORM-1577 WIP Added unit tests.

By the way, fixed minor parsing bugs.
---
 indra/newview/CMakeLists.txt  |   7 +
 indra/newview/lltranslate.cpp | 295 +++++++++++++++++++-----------------------
 indra/newview/lltranslate.h   |  77 ++++++++++-
 3 files changed, 219 insertions(+), 160 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/CMakeLists.txt b/indra/newview/CMakeLists.txt
index e7ca2a4294..635f425540 100644
--- a/indra/newview/CMakeLists.txt
+++ b/indra/newview/CMakeLists.txt
@@ -1985,12 +1985,19 @@ if (LL_TESTS)
     llmediadataclient.cpp
     lllogininstance.cpp
     llremoteparcelrequest.cpp
+    lltranslate.cpp
     llviewerhelputil.cpp
     llversioninfo.cpp
     llworldmap.cpp
     llworldmipmap.cpp
   )
 
+  set_source_files_properties(
+    lltranslate.cpp
+    PROPERTIES
+    LL_TEST_ADDITIONAL_LIBRARIES "${JSONCPP_LIBRARIES}"
+  )
+
   ##################################################
   # DISABLING PRECOMPILED HEADERS USAGE FOR TESTS
   ##################################################
diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index 895d8f78eb..a74b252c68 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -38,194 +38,171 @@
 
 #include "reader.h"
 
-class LLTranslationAPIHandler
-{
-public:
-	virtual void getTranslateURL(
-		std::string &url,
-		const std::string &from_lang,
-		const std::string &to_lang,
-		const std::string &text) const = 0;
-
-	virtual bool parseResponse(
-		int& status,
-		const std::string& body,
-		std::string& translation,
-		std::string& detected_lang,
-		std::string& err_msg) const = 0;
-
-	virtual ~LLTranslationAPIHandler() {}
-
-protected:
-	static const int STATUS_OK = 200;
-};
-
-class LLGoogleHandler : public LLTranslationAPIHandler
+// virtual
+void LLGoogleTranslationHandler::getTranslateURL(
+	std::string &url,
+	const std::string &from_lang,
+	const std::string &to_lang,
+	const std::string &text) const
 {
-	LOG_CLASS(LLGoogleHandler);
-
-public:
-	/*virtual*/ void getTranslateURL(
-		std::string &url,
-		const std::string &from_lang,
-		const std::string &to_lang,
-		const std::string &text) const
+	url = std::string("https://www.googleapis.com/language/translate/v2?key=")
+		+ getAPIKey() + "&q=" + LLURI::escape(text) + "&target=" + to_lang;
+	if (!from_lang.empty())
 	{
-		url = std::string("https://www.googleapis.com/language/translate/v2?key=")
-			+ getAPIKey() + "&q=" + LLURI::escape(text) + "&target=" + to_lang;
-		if (!from_lang.empty())
-		{
-			url += "&source=" + from_lang;
-		}
+		url += "&source=" + from_lang;
 	}
+}
 
-	/*virtual*/ bool parseResponse(
-		int& status,
-		const std::string& body,
-		std::string& translation,
-		std::string& detected_lang,
-		std::string& err_msg) const
-	{
-		Json::Value root;
-		Json::Reader reader;
-
-		if (!reader.parse(body, root))
-		{
-			err_msg = reader.getFormatedErrorMessages();
-			return false;
-		}
-
-		if (!root.isObject()) // empty response? should not happen
-		{
-			return false;
-		}
-
-		if (status != STATUS_OK)
-		{
-			// Request failed. Extract error message from the response.
-			parseErrorResponse(root, status, err_msg);
-			return false;
-		}
+// virtual
+bool LLGoogleTranslationHandler::parseResponse(
+	int& status,
+	const std::string& body,
+	std::string& translation,
+	std::string& detected_lang,
+	std::string& err_msg) const
+{
+	Json::Value root;
+	Json::Reader reader;
 
-		// Request succeeded, extract translation from the response.
-		return parseTranslation(root, translation, detected_lang);
+	if (!reader.parse(body, root))
+	{
+		err_msg = reader.getFormatedErrorMessages();
+		return false;
 	}
 
-private:
-	static void parseErrorResponse(
-		const Json::Value& root,
-		int& status,
-		std::string& err_msg)
+	if (!root.isObject()) // empty response? should not happen
 	{
-		const Json::Value& error = root.get("error", 0);
-		if (!error.isObject() || !error.isMember("message") || !error.isMember("code"))
-		{
-			return;
-		}
+		return false;
+	}
 
-		err_msg = error["message"].asString();
-		status = error["code"].asInt();
+	if (status != STATUS_OK)
+	{
+		// Request failed. Extract error message from the response.
+		parseErrorResponse(root, status, err_msg);
+		return false;
 	}
 
-	static bool parseTranslation(
-		const Json::Value& root,
-		std::string& translation,
-		std::string& detected_lang)
+	// Request succeeded, extract translation from the response.
+	return parseTranslation(root, translation, detected_lang);
+}
+
+// static
+void LLGoogleTranslationHandler::parseErrorResponse(
+	const Json::Value& root,
+	int& status,
+	std::string& err_msg)
+{
+	const Json::Value& error = root.get("error", 0);
+	if (!error.isObject() || !error.isMember("message") || !error.isMember("code"))
 	{
-		const Json::Value& data = root.get("data", 0);
-		if (!data.isObject() || !data.isMember("translations"))
-		{
-			return false;
-		}
+		return;
+	}
 
-		const Json::Value& translations = data["translations"];
-		if (!translations.isArray() || translations.size() == 0)
-		{
-			return false;
-		}
+	err_msg = error["message"].asString();
+	status = error["code"].asInt();
+}
 
-		const Json::Value& first = translations[0U];
-		if (!first.isObject() || !first.isMember("translatedText"))
-		{
-			return false;
-		}
+// static
+bool LLGoogleTranslationHandler::parseTranslation(
+	const Json::Value& root,
+	std::string& translation,
+	std::string& detected_lang)
+{
+	const Json::Value& data = root.get("data", 0);
+	if (!data.isObject() || !data.isMember("translations"))
+	{
+		return false;
+	}
 
-		translation = first["translatedText"].asString();
-		detected_lang = first.get("detectedSourceLanguage", "").asString();
-		return true;
+	const Json::Value& translations = data["translations"];
+	if (!translations.isArray() || translations.size() == 0)
+	{
+		return false;
 	}
 
-	static std::string getAPIKey()
+	const Json::Value& first = translations[0U];
+	if (!first.isObject() || !first.isMember("translatedText"))
 	{
-		return gSavedSettings.getString("GoogleTranslateAPIKey");
+		return false;
 	}
-};
 
-class LLBingHandler : public LLTranslationAPIHandler
+	translation = first["translatedText"].asString();
+	detected_lang = first.get("detectedSourceLanguage", "").asString();
+	return true;
+}
+
+// static
+std::string LLGoogleTranslationHandler::getAPIKey()
+{
+	return gSavedSettings.getString("GoogleTranslateAPIKey");
+}
+
+// virtual
+void LLBingTranslarionHandler::getTranslateURL(
+	std::string &url,
+	const std::string &from_lang,
+	const std::string &to_lang,
+	const std::string &text) const
 {
-	LOG_CLASS(LLBingHandler);
-
-public:
-	/*virtual*/ void getTranslateURL(
-		std::string &url,
-		const std::string &from_lang,
-		const std::string &to_lang,
-		const std::string &text) const
+	url = std::string("http://api.microsofttranslator.com/v2/Http.svc/Translate?appId=")
+		+ getAPIKey() + "&text=" + LLURI::escape(text) + "&to=" + to_lang;
+	if (!from_lang.empty())
 	{
-		url = std::string("http://api.microsofttranslator.com/v2/Http.svc/Translate?appId=")
-			+ getAPIKey() + "&text=" + LLURI::escape(text) + "&to=" + to_lang;
-		if (!from_lang.empty())
-		{
-			url += "&from=" + from_lang;
-		}
+		url += "&from=" + from_lang;
 	}
+}
 
-	/*virtual*/ bool parseResponse(
-		int& status,
-		const std::string& body,
-		std::string& translation,
-		std::string& detected_lang,
-		std::string& err_msg) const
+// virtual
+bool LLBingTranslarionHandler::parseResponse(
+	int& status,
+	const std::string& body,
+	std::string& translation,
+	std::string& detected_lang,
+	std::string& err_msg) const
+{
+	if (status != STATUS_OK)
 	{
-		if (status != STATUS_OK)
+		static const std::string MSG_BEGIN_MARKER = "Message: ";
+		size_t begin = body.find(MSG_BEGIN_MARKER);
+		if (begin != std::string::npos)
 		{
-			static const std::string MSG_BEGIN_MARKER = "Message: ";
-			size_t begin = body.find(MSG_BEGIN_MARKER);
-			if (begin != std::string::npos)
-			{
-				begin += MSG_BEGIN_MARKER.size();
-			}
-			size_t end = body.find("</p>", begin);
-			err_msg = body.substr(begin, end-begin);
-			LLStringUtil::replaceString(err_msg, "&#xD;", ""); // strip CR
-			return false;
+			begin += MSG_BEGIN_MARKER.size();
 		}
-
-		// Sample response: <string xmlns="http://schemas.microsoft.com/2003/10/Serialization/">Hola</string>
-		size_t begin = body.find(">");
-		if (begin == std::string::npos || begin >= (body.size() - 1))
+		else
 		{
-			return false;
+			begin = 0;
+			err_msg.clear();
 		}
-
-		size_t end = body.find("</string>", ++begin);
-		if (end == std::string::npos || end < begin)
-		{
-			return false;
-		}
-
-		detected_lang = ""; // unsupported by this API
-		translation = body.substr(begin, end-begin);
-		LLStringUtil::replaceString(translation, "&#xD;", ""); // strip CR
-		return true;
+		size_t end = body.find("</p>", begin);
+		err_msg = body.substr(begin, end-begin);
+		LLStringUtil::replaceString(err_msg, "&#xD;", ""); // strip CR
+		return false;
 	}
 
-private:
-	static std::string getAPIKey()
+	// Sample response: <string xmlns="http://schemas.microsoft.com/2003/10/Serialization/">Hola</string>
+	size_t begin = body.find(">");
+	if (begin == std::string::npos || begin >= (body.size() - 1))
 	{
-		return gSavedSettings.getString("BingTranslateAPIKey");
+		begin = 0;
 	}
-};
+	else
+	{
+		++begin;
+	}
+
+	size_t end = body.find("</string>", begin);
+
+	detected_lang = ""; // unsupported by this API
+	translation = body.substr(begin, end-begin);
+	LLStringUtil::replaceString(translation, "&#xD;", ""); // strip CR
+	return true;
+}
+
+// static
+std::string LLBingTranslarionHandler::getAPIKey()
+{
+	return gSavedSettings.getString("BingTranslateAPIKey");
+}
 
 LLTranslate::TranslationReceiver::TranslationReceiver(const std::string& from_lang, const std::string& to_lang)
 :	mFromLang(from_lang)
@@ -248,6 +225,8 @@ void LLTranslate::TranslationReceiver::completedRaw(
 	const std::string body = strstrm.str();
 	std::string translation, detected_lang, err_msg;
 	int status = http_status;
+	LL_DEBUGS("Translate") << "HTTP status: " << status << " " << reason << LL_ENDL;
+	LL_DEBUGS("Translate") << "Response body: " << body << LL_ENDL;
 	if (mHandler.parseResponse(status, body, translation, detected_lang, err_msg))
 	{
 		// Fix up the response
@@ -268,8 +247,6 @@ void LLTranslate::TranslationReceiver::completedRaw(
 		}
 
 		llwarns << "Translation request failed: " << err_msg << llendl;
-		LL_DEBUGS("Translate") << "HTTP status: " << status << " " << reason << LL_ENDL;
-		LL_DEBUGS("Translate") << "Error response body: " << body << LL_ENDL;
 		handleFailure(status, err_msg);
 	}
 }
@@ -319,8 +296,8 @@ std::string LLTranslate::getTranslateLanguage()
 // static
 const LLTranslationAPIHandler& LLTranslate::getPreferredHandler()
 {
-	static LLGoogleHandler	google;
-	static LLBingHandler	bing;
+	static LLGoogleTranslationHandler google;
+	static LLBingTranslarionHandler bing;
 
 	std::string service = gSavedSettings.getString("TranslationService");
 	if (service == "google")
diff --git a/indra/newview/lltranslate.h b/indra/newview/lltranslate.h
index 1dee792f7b..1bf6965fd4 100644
--- a/indra/newview/lltranslate.h
+++ b/indra/newview/lltranslate.h
@@ -30,7 +30,82 @@
 #include "llhttpclient.h"
 #include "llbufferstream.h"
 
-class LLTranslationAPIHandler;
+namespace Json
+{
+    class Value;
+}
+
+class LLTranslationAPIHandler
+{
+public:
+	virtual void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const = 0;
+
+	virtual bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const = 0;
+
+	virtual ~LLTranslationAPIHandler() {}
+
+protected:
+	static const int STATUS_OK = 200;
+};
+
+class LLGoogleTranslationHandler : public LLTranslationAPIHandler
+{
+	LOG_CLASS(LLGoogleTranslationHandler);
+
+public:
+	/*virtual*/ void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const;
+	/*virtual*/ bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const;
+
+private:
+	static void parseErrorResponse(
+		const Json::Value& root,
+		int& status,
+		std::string& err_msg);
+	static bool parseTranslation(
+		const Json::Value& root,
+		std::string& translation,
+		std::string& detected_lang);
+	static std::string getAPIKey();
+};
+
+class LLBingTranslarionHandler : public LLTranslationAPIHandler
+{
+	LOG_CLASS(LLBingTranslarionHandler);
+
+public:
+	/*virtual*/ void getTranslateURL(
+		std::string &url,
+		const std::string &from_lang,
+		const std::string &to_lang,
+		const std::string &text) const;
+	/*virtual*/ bool parseResponse(
+		int& status,
+		const std::string& body,
+		std::string& translation,
+		std::string& detected_lang,
+		std::string& err_msg) const;
+private:
+	static std::string getAPIKey();
+};
+
 
 class LLTranslate
 {
-- 
cgit v1.2.3


From 83d889098db7253a8d8bec7940a93724ea724449 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Mon, 12 Sep 2011 17:21:07 +0300
Subject: STORM-1577 WIP Forgot to add the unit test.

---
 indra/newview/tests/lltranslate_test.cpp | 344 +++++++++++++++++++++++++++++++
 1 file changed, 344 insertions(+)
 create mode 100644 indra/newview/tests/lltranslate_test.cpp

(limited to 'indra/newview')

diff --git a/indra/newview/tests/lltranslate_test.cpp b/indra/newview/tests/lltranslate_test.cpp
new file mode 100644
index 0000000000..0f3429b7b3
--- /dev/null
+++ b/indra/newview/tests/lltranslate_test.cpp
@@ -0,0 +1,344 @@
+/** 
+ * @file lltranslate_test.cpp
+ *
+ * $LicenseInfo:firstyear=2011&license=viewerlgpl$
+ * Second Life Viewer Source Code
+ * Copyright (C) 2011, Linden Research, Inc.
+ * 
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation;
+ * version 2.1 of the License only.
+ * 
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ * 
+ * Linden Research, Inc., 945 Battery Street, San Francisco, CA  94111  USA
+ * $/LicenseInfo$
+ */
+
+#include "linden_common.h"
+
+#include "../test/lltut.h"
+#include "../lltranslate.h"
+#include "../llversioninfo.h"
+#include "../llviewercontrol.h"
+
+#include "llbufferstream.h"
+#include "lltrans.h"
+#include "llui.h"
+
+static const std::string GOOGLE_VALID_RESPONSE1 =
+"{\
+ \"data\": {\
+  \"translations\": [\
+   {\
+    \"translatedText\": \"привет\",\
+    \"detectedSourceLanguage\": \"es\"\
+   }\
+  ]\
+ }\
+}";
+
+static const std::string GOOGLE_VALID_RESPONSE2 =
+"{\
+ \"data\": {\
+  \"translations\": [\
+   {\
+    \"translatedText\": \"привет\"\
+   }\
+  ]\
+ }\
+}\
+";
+
+static const std::string GOOGLE_VALID_RESPONSE3 =
+"{\
+ \"error\": {\
+  \"errors\": [\
+   {\
+    \"domain\": \"global\",\
+    \"reason\": \"invalid\",\
+    \"message\": \"Invalid Value\"\
+   }\
+  ],\
+  \"code\": 400,\
+  \"message\": \"Invalid Value\"\
+ }\
+}";
+
+static const std::string BING_VALID_RESPONSE1 =
+"<string xmlns=\"http://schemas.microsoft.com/2003/10/Serialization/\">Привет</string>";
+
+static const std::string BING_VALID_RESPONSE2 =
+"<html><body><h1>Argument Exception</h1><p>Method: Translate()</p><p>Parameter: </p>\
+<p>Message: 'from' must be a valid language</p><code></code>\
+<p>message id=3743.V2_Rest.Translate.58E8454F</p></body></html>";
+
+static const std::string BING_VALID_RESPONSE3 =
+"<html><body><h1>Argument Exception</h1><p>Method: Translate()</p>\
+<p>Parameter: appId</p><p>Message: Invalid appId&#xD;\nParameter name: appId</p>\
+<code></code><p>message id=3737.V2_Rest.Translate.56016759</p></body></html>";
+
+namespace tut
+{
+	class translate_test
+	{
+	protected:
+		void test_translation(
+			LLTranslationAPIHandler& handler,
+			int status, const std::string& resp,
+			const std::string& exp_trans, const std::string& exp_lang, const std::string& exp_err)
+		{
+			std::string translation, detected_lang, err_msg;
+			bool rc = handler.parseResponse(status, resp, translation, detected_lang, err_msg);
+			ensure_equals("rc", rc, (status == 200));
+			ensure_equals("err_msg", err_msg, exp_err);
+			ensure_equals("translation", translation, exp_trans);
+			ensure_equals("detected_lang", detected_lang,  exp_lang);
+		}
+
+		LLGoogleTranslationHandler mGoogle;
+		LLBingTranslarionHandler mBing;
+	};
+
+	typedef test_group<translate_test> translate_test_group_t;
+	typedef translate_test_group_t::object translate_test_object_t;
+	tut::translate_test_group_t tut_translate("LLTranslate");
+
+	template<> template<>
+	void translate_test_object_t::test<1>()
+	{
+		test_translation(mGoogle, 200, GOOGLE_VALID_RESPONSE1, "привет", "es", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<2>()
+	{
+		test_translation(mGoogle, 200, GOOGLE_VALID_RESPONSE2, "привет", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<3>()
+	{
+		test_translation(mGoogle, 400, GOOGLE_VALID_RESPONSE3, "", "", "Invalid Value");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<4>()
+	{
+		test_translation(mGoogle, 400,
+			"",
+			"", "", "* Line 1, Column 1\n  Syntax error: value, object or array expected.\n");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<5>()
+	{
+		test_translation(mGoogle, 400,
+			"[]",
+			"", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<6>()
+	{
+		test_translation(mGoogle, 400,
+			"{\"oops\": \"invalid\"}",
+			"", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<7>()
+	{
+		test_translation(mGoogle, 400,
+			"{\"oops\": \"invalid\"}",
+			"", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<8>()
+	{
+		test_translation(mGoogle, 400,
+				"{\"data\": { \"translations\": [ {} ] }}",
+			"", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<9>()
+	{
+		test_translation(mGoogle, 400,
+				"{\"data\": { \"translations\": [ { \"translatedTextZZZ\": \"привет\", \"detectedSourceLanguageZZZ\": \"es\" } ] }}",
+			"", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<10>()
+	{
+		test_translation(mBing, 200, BING_VALID_RESPONSE1, "Привет", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<11>()
+	{
+		test_translation(mBing, 400, BING_VALID_RESPONSE2, "", "", "'from' must be a valid language");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<12>()
+	{
+		test_translation(mBing, 400, BING_VALID_RESPONSE3, "", "", "Invalid appId\nParameter name: appId");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<13>()
+	{
+		test_translation(mBing, 200,
+			"Привет</string>",
+			"Привет", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<14>()
+	{
+		test_translation(mBing, 200,
+			"<string xmlns=\"http://schemas.microsoft.com/2003/10/Serialization/\">Привет",
+			"Привет", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<15>()
+	{
+		test_translation(mBing, 200,
+			"Привет",
+			"Привет", "", "");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<16>()
+	{
+		test_translation(mBing, 400,
+			"Message: some error</p>",
+			"", "", "some error");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<17>()
+	{
+		test_translation(mBing, 400,
+			"Message: some error",
+			"", "", "some error");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<18>()
+	{
+		test_translation(mBing, 400,
+			"some error</p>",
+			"", "", "some error");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<19>()
+	{
+		test_translation(mBing, 400,
+			"some error",
+			"", "", "some error");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<20>()
+	{
+		std::string url;
+		mBing.getTranslateURL(url, "en", "es", "hi");
+		ensure_equals("bing URL", url,
+			"http://api.microsofttranslator.com/v2/Http.svc/Translate?appId=dummy&text=hi&to=es&from=en");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<21>()
+	{
+		std::string url;
+		mBing.getTranslateURL(url, "", "es", "hi");
+		ensure_equals("bing URL", url,
+			"http://api.microsofttranslator.com/v2/Http.svc/Translate?appId=dummy&text=hi&to=es");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<22>()
+	{
+		std::string url;
+		mGoogle.getTranslateURL(url, "en", "es", "hi");
+		ensure_equals("google URL", url,
+			"https://www.googleapis.com/language/translate/v2?key=dummy&q=hi&target=es&source=en");
+	}
+
+	template<> template<>
+	void translate_test_object_t::test<23>()
+	{
+		std::string url;
+		mGoogle.getTranslateURL(url, "", "es", "hi");
+		ensure_equals("google URL", url,
+			"https://www.googleapis.com/language/translate/v2?key=dummy&q=hi&target=es");
+	}
+}
+
+//== Misc stubs ===============================================================
+LLControlGroup gSavedSettings("test");
+
+std::string LLUI::getLanguage() { return "en"; }
+std::string LLTrans::getString(const std::string &xml_desc, const LLStringUtil::format_map_t& args) { return "dummy"; }
+
+LLControlGroup::LLControlGroup(const std::string& name) : LLInstanceTracker<LLControlGroup, std::string>(name) {}
+std::string LLControlGroup::getString(const std::string& name) { return "dummy"; }
+LLControlGroup::~LLControlGroup() {}
+
+namespace boost {
+	void intrusive_ptr_add_ref(LLCurl::Responder*) {}
+	void intrusive_ptr_release(LLCurl::Responder*) {}
+}
+
+LLCurl::Responder::Responder() {}
+void LLCurl::Responder::completedHeader(U32, std::string const&, LLSD const&) {}
+void LLCurl::Responder::completedRaw(U32, const std::string&, const LLChannelDescriptors&, const LLIOPipe::buffer_ptr_t& buffer) {}
+void LLCurl::Responder::completed(U32, std::string const&, LLSD const&) {}
+void LLCurl::Responder::error(U32, std::string const&) {}
+void LLCurl::Responder::errorWithContent(U32, std::string const&, LLSD const&) {}
+void LLCurl::Responder::result(LLSD const&) {}
+LLCurl::Responder::~Responder() {}
+
+void LLHTTPClient::get(const std::string&, const LLSD&, ResponderPtr, const LLSD&, const F32) {}
+void LLHTTPClient::get(const std::string&, boost::intrusive_ptr<LLCurl::Responder>, const LLSD&, const F32) {}
+
+LLBufferStream::LLBufferStream(const LLChannelDescriptors& channels, LLBufferArray* buffer) : mStreamBuf(channels, buffer) {}
+LLBufferStream::~LLBufferStream() {}
+
+LLBufferStreamBuf::LLBufferStreamBuf(const LLChannelDescriptors&, LLBufferArray*) {}
+#if( LL_WINDOWS || __GNUC__ > 2)
+LLBufferStreamBuf::pos_type LLBufferStreamBuf::seekoff(
+	off_type off,
+	std::ios::seekdir way,
+	std::ios::openmode which)
+#else
+streampos LLBufferStreamBuf::seekoff(
+	streamoff off,
+	std::ios::seekdir way,
+	std::ios::openmode which)
+#endif
+{ return 0; }
+int LLBufferStreamBuf::sync() {return 0;}
+int LLBufferStreamBuf::underflow() {return 0;}
+int LLBufferStreamBuf::overflow(int) {return 0;}
+LLBufferStreamBuf::~LLBufferStreamBuf() {}
+
+S32 LLVersionInfo::getBuild() { return 0; }
+const std::string& LLVersionInfo::getChannel() {static std::string dummy; return dummy;}
+S32 LLVersionInfo::getMajor() { return 0; }
+S32 LLVersionInfo::getMinor() { return 0; }
+S32 LLVersionInfo::getPatch() { return 0; }
-- 
cgit v1.2.3


From 8652b2d1052b989e32f4462a07372901d37f9586 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Tue, 13 Sep 2011 03:05:57 +0300
Subject: STORM-1577 WIP Added API key verification to the translation settings
 floater; new layout.

---
 indra/newview/llfloatertranslationsettings.cpp     | 214 +++++++++++++++++----
 indra/newview/llfloatertranslationsettings.h       |  22 ++-
 indra/newview/lltranslate.cpp                      | 107 +++++++++--
 indra/newview/lltranslate.h                        |  37 ++++
 .../xui/en/floater_translation_settings.xml        |  52 +++--
 5 files changed, 363 insertions(+), 69 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
index 4079fdf482..ac3e7ac8fa 100644
--- a/indra/newview/llfloatertranslationsettings.cpp
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -29,6 +29,7 @@
 #include "llfloatertranslationsettings.h"
 
 // Viewer includes
+#include "lltranslate.h"
 #include "llviewercontrol.h" // for gSavedSettings
 
 // Linden library includes
@@ -40,6 +41,41 @@
 #include "llnotificationsutil.h"
 #include "llradiogroup.h"
 
+class EnteredKeyVerifier : public LLTranslate::KeyVerificationReceiver
+{
+public:
+	EnteredKeyVerifier(LLTranslate::EService service, bool alert)
+	:	LLTranslate::KeyVerificationReceiver(service)
+	,	mAlert(alert)
+	{
+	}
+
+private:
+	/*virtual*/ void setVerificationStatus(bool ok)
+	{
+		LLFloaterTranslationSettings* floater =
+			LLFloaterReg::getTypedInstance<LLFloaterTranslationSettings>("prefs_translation");
+
+		if (!floater)
+		{
+			llwarns << "Cannot find translation settings floater" << llendl;
+			return;
+		}
+
+		switch (getService())
+		{
+		case LLTranslate::SERVICE_BING:
+			floater->setBingVerified(ok, mAlert);
+			break;
+		case LLTranslate::SERVICE_GOOGLE:
+			floater->setGoogleVerified(ok, mAlert);
+			break;
+		}
+	}
+
+	bool mAlert;
+};
+
 LLFloaterTranslationSettings::LLFloaterTranslationSettings(const LLSD& key)
 :	LLFloater(key)
 ,	mMachineTranslationCB(NULL)
@@ -47,6 +83,11 @@ LLFloaterTranslationSettings::LLFloaterTranslationSettings(const LLSD& key)
 ,	mTranslationServiceRadioGroup(NULL)
 ,	mBingAPIKeyEditor(NULL)
 ,	mGoogleAPIKeyEditor(NULL)
+,	mBingVerifyBtn(NULL)
+,	mGoogleVerifyBtn(NULL)
+,	mOKBtn(NULL)
+,	mBingKeyVerified(false)
+,	mGoogleKeyVerified(false)
 {
 }
 
@@ -58,11 +99,21 @@ BOOL LLFloaterTranslationSettings::postBuild()
 	mTranslationServiceRadioGroup = getChild<LLRadioGroup>("translation_service_rg");
 	mBingAPIKeyEditor = getChild<LLLineEditor>("bing_api_key");
 	mGoogleAPIKeyEditor = getChild<LLLineEditor>("google_api_key");
+	mBingVerifyBtn = getChild<LLButton>("verify_bing_api_key_btn");
+	mGoogleVerifyBtn = getChild<LLButton>("verify_google_api_key_btn");
+	mOKBtn = getChild<LLButton>("ok_btn");
 
 	mMachineTranslationCB->setCommitCallback(boost::bind(&LLFloaterTranslationSettings::updateControlsEnabledState, this));
 	mTranslationServiceRadioGroup->setCommitCallback(boost::bind(&LLFloaterTranslationSettings::updateControlsEnabledState, this));
-	getChild<LLButton>("ok_btn")->setClickedCallback(boost::bind(&LLFloaterTranslationSettings::onBtnOK, this));
+	mOKBtn->setClickedCallback(boost::bind(&LLFloaterTranslationSettings::onBtnOK, this));
 	getChild<LLButton>("cancel_btn")->setClickedCallback(boost::bind(&LLFloater::closeFloater, this, false));
+	mBingVerifyBtn->setClickedCallback(boost::bind(&LLFloaterTranslationSettings::onBtnBingVerify, this));
+	mGoogleVerifyBtn->setClickedCallback(boost::bind(&LLFloaterTranslationSettings::onBtnGoogleVerify, this));
+
+	mBingAPIKeyEditor->setFocusReceivedCallback(boost::bind(&LLFloaterTranslationSettings::onEditorFocused, this, _1));
+	mBingAPIKeyEditor->setKeystrokeCallback(boost::bind(&LLFloaterTranslationSettings::onBingKeyEdited, this), NULL);
+	mGoogleAPIKeyEditor->setFocusReceivedCallback(boost::bind(&LLFloaterTranslationSettings::onEditorFocused, this, _1));
+	mGoogleAPIKeyEditor->setKeystrokeCallback(boost::bind(&LLFloaterTranslationSettings::onGoogleKeyEdited, this), NULL);
 
 	center();
 	return TRUE;
@@ -74,43 +125,78 @@ void LLFloaterTranslationSettings::onOpen(const LLSD& key)
 	mMachineTranslationCB->setValue(gSavedSettings.getBOOL("TranslateChat"));
 	mLanguageCombo->setSelectedByValue(gSavedSettings.getString("TranslateLanguage"), TRUE);
 	mTranslationServiceRadioGroup->setSelectedByValue(gSavedSettings.getString("TranslationService"), TRUE);
-	mBingAPIKeyEditor->setText(gSavedSettings.getString("BingTranslateAPIKey"));
-	mGoogleAPIKeyEditor->setText(gSavedSettings.getString("GoogleTranslateAPIKey"));
+
+	std::string bing_key = gSavedSettings.getString("BingTranslateAPIKey");
+	if (!bing_key.empty())
+	{
+		mBingAPIKeyEditor->setText(bing_key);
+		mBingAPIKeyEditor->setTentative(FALSE);
+		verifyKey(LLTranslate::SERVICE_BING, bing_key, false);
+	}
+	else
+	{
+		mBingAPIKeyEditor->setTentative(TRUE);
+		mBingKeyVerified = FALSE;
+	}
+
+	std::string google_key = gSavedSettings.getString("GoogleTranslateAPIKey");
+	if (!google_key.empty())
+	{
+		mGoogleAPIKeyEditor->setText(google_key);
+		mGoogleAPIKeyEditor->setTentative(FALSE);
+		verifyKey(LLTranslate::SERVICE_GOOGLE, google_key, false);
+	}
+	else
+	{
+		mGoogleAPIKeyEditor->setTentative(TRUE);
+		mGoogleKeyVerified = FALSE;
+	}
 
 	updateControlsEnabledState();
 }
 
-std::string LLFloaterTranslationSettings::getSelectedService() const
+void LLFloaterTranslationSettings::setBingVerified(bool ok, bool alert)
 {
-	return mTranslationServiceRadioGroup->getSelectedValue().asString();
+	if (alert)
+	{
+		showAlert(ok ? "bing_api_key_verified" : "bing_api_key_not_verified");
+	}
+
+	mBingKeyVerified = ok;
+	updateControlsEnabledState();
 }
 
-void LLFloaterTranslationSettings::showError(const std::string& err_name) const
+void LLFloaterTranslationSettings::setGoogleVerified(bool ok, bool alert)
 {
-	LLSD args;
-	args["MESSAGE"] = getString(err_name);
-	LLNotificationsUtil::add("GenericAlert", args);
+	if (alert)
+	{
+		showAlert(ok ? "google_api_key_verified" : "google_api_key_not_verified");
+	}
+
+	mGoogleKeyVerified = ok;
+	updateControlsEnabledState();
 }
 
-bool LLFloaterTranslationSettings::validate() const
+std::string LLFloaterTranslationSettings::getSelectedService() const
 {
-	bool translate_chat = mMachineTranslationCB->getValue().asBoolean();
-	if (!translate_chat) return true;
+	return mTranslationServiceRadioGroup->getSelectedValue().asString();
+}
 
-	std::string service = getSelectedService();
-	if (service == "bing" && mBingAPIKeyEditor->getText().empty())
-	{
-		showError("no_bing_api_key");
-		return false;
-	}
+std::string LLFloaterTranslationSettings::getEnteredBingKey() const
+{
+	return mBingAPIKeyEditor->getTentative() ? LLStringUtil::null : mBingAPIKeyEditor->getText();
+}
 
-	if (service == "google" && mGoogleAPIKeyEditor->getText().empty())
-	{
-		showError("no_google_api_key");
-		return false;
-	}
+std::string LLFloaterTranslationSettings::getEnteredGoogleKey() const
+{
+	return mGoogleAPIKeyEditor->getTentative() ? LLStringUtil::null : mGoogleAPIKeyEditor->getText();
+}
 
-	return true;
+void LLFloaterTranslationSettings::showAlert(const std::string& msg_name) const
+{
+	LLSD args;
+	args["MESSAGE"] = getString(msg_name);
+	LLNotificationsUtil::add("GenericAlert", args);
 }
 
 void LLFloaterTranslationSettings::updateControlsEnabledState()
@@ -118,6 +204,8 @@ void LLFloaterTranslationSettings::updateControlsEnabledState()
 	// Enable/disable controls based on the checkbox value.
 	bool on = mMachineTranslationCB->getValue().asBoolean();
 	std::string service = getSelectedService();
+	bool bing_selected = service == "bing";
+	bool google_selected = service == "google";
 
 	mTranslationServiceRadioGroup->setEnabled(on);
 	mLanguageCombo->setEnabled(on);
@@ -128,19 +216,77 @@ void LLFloaterTranslationSettings::updateControlsEnabledState()
 	getChild<LLTextBox>("google_api_key_label")->setEnabled(on);
 	mGoogleAPIKeyEditor->setEnabled(on);
 
-	mBingAPIKeyEditor->setEnabled(on && service == "bing");
-	mGoogleAPIKeyEditor->setEnabled(on && service == "google");
+	mBingAPIKeyEditor->setEnabled(on && bing_selected);
+	mGoogleAPIKeyEditor->setEnabled(on && google_selected);
+
+	mBingVerifyBtn->setEnabled(on && bing_selected &&
+		!mBingKeyVerified && !getEnteredBingKey().empty());
+	mGoogleVerifyBtn->setEnabled(on && google_selected &&
+		!mGoogleKeyVerified && !getEnteredGoogleKey().empty());
+
+	mOKBtn->setEnabled(
+		!on || (
+		(bing_selected && mBingKeyVerified) ||
+		(google_selected && mGoogleKeyVerified)
+	));
 }
 
-void LLFloaterTranslationSettings::onBtnOK()
+void LLFloaterTranslationSettings::verifyKey(int service, const std::string& key, bool alert)
 {
-	if (validate())
+	LLTranslate::KeyVerificationReceiverPtr receiver =
+		new EnteredKeyVerifier((LLTranslate::EService) service, alert);
+	LLTranslate::verifyKey(receiver, key);
+}
+
+void LLFloaterTranslationSettings::onEditorFocused(LLFocusableElement* control)
+{
+	LLLineEditor* editor = dynamic_cast<LLLineEditor*>(control);
+	if (editor)
 	{
-		gSavedSettings.setBOOL("TranslateChat", mMachineTranslationCB->getValue().asBoolean());
-		gSavedSettings.setString("TranslateLanguage", mLanguageCombo->getSelectedValue().asString());
-		gSavedSettings.setString("TranslationService", getSelectedService());
-		gSavedSettings.setString("BingTranslateAPIKey", mBingAPIKeyEditor->getText());
-		gSavedSettings.setString("GoogleTranslateAPIKey", mGoogleAPIKeyEditor->getText());
-		closeFloater(false);
+		if (editor->getTentative())
+		{
+			editor->setText(LLStringUtil::null);
+			editor->setTentative(FALSE);
+		}
 	}
 }
+
+void LLFloaterTranslationSettings::onBingKeyEdited()
+{
+	mBingAPIKeyEditor->setTentative(FALSE);
+	setBingVerified(false, false);
+}
+
+void LLFloaterTranslationSettings::onGoogleKeyEdited()
+{
+	mGoogleAPIKeyEditor->setTentative(FALSE);
+	setGoogleVerified(false, false);
+}
+
+void LLFloaterTranslationSettings::onBtnBingVerify()
+{
+	std::string key = getEnteredBingKey();
+	if (!key.empty())
+	{
+		verifyKey(LLTranslate::SERVICE_BING, key);
+	}
+}
+
+void LLFloaterTranslationSettings::onBtnGoogleVerify()
+{
+	std::string key = getEnteredGoogleKey();
+	if (!key.empty())
+	{
+		verifyKey(LLTranslate::SERVICE_GOOGLE, key);
+	}
+}
+
+void LLFloaterTranslationSettings::onBtnOK()
+{
+	gSavedSettings.setBOOL("TranslateChat", mMachineTranslationCB->getValue().asBoolean());
+	gSavedSettings.setString("TranslateLanguage", mLanguageCombo->getSelectedValue().asString());
+	gSavedSettings.setString("TranslationService", getSelectedService());
+	gSavedSettings.setString("BingTranslateAPIKey", getEnteredBingKey());
+	gSavedSettings.setString("GoogleTranslateAPIKey", getEnteredGoogleKey());
+	closeFloater(false);
+}
diff --git a/indra/newview/llfloatertranslationsettings.h b/indra/newview/llfloatertranslationsettings.h
index 47e2fc80e6..9b47ad72ed 100644
--- a/indra/newview/llfloatertranslationsettings.h
+++ b/indra/newview/llfloatertranslationsettings.h
@@ -29,6 +29,7 @@
 
 #include "llfloater.h"
 
+class LLButton;
 class LLCheckBoxCtrl;
 class LLComboBox;
 class LLLineEditor;
@@ -41,11 +42,22 @@ public:
 	/*virtual*/ BOOL postBuild();
 	/*virtual*/ void onOpen(const LLSD& key);
 
+	void setBingVerified(bool ok, bool alert);
+	void setGoogleVerified(bool ok, bool alert);
+
 private:
 	std::string getSelectedService() const;
-	void showError(const std::string& err_name) const;
-	bool validate() const;
+	std::string getEnteredBingKey() const;
+	std::string getEnteredGoogleKey() const;
+	void showAlert(const std::string& msg_name) const;
 	void updateControlsEnabledState();
+	void verifyKey(int service, const std::string& key, bool alert = true);
+
+	void onEditorFocused(LLFocusableElement* control);
+	void onBingKeyEdited();
+	void onGoogleKeyEdited();
+	void onBtnBingVerify();
+	void onBtnGoogleVerify();
 	void onBtnOK();
 
 	LLCheckBoxCtrl* mMachineTranslationCB;
@@ -53,6 +65,12 @@ private:
 	LLLineEditor* mBingAPIKeyEditor;
 	LLLineEditor* mGoogleAPIKeyEditor;
 	LLRadioGroup* mTranslationServiceRadioGroup;
+	LLButton* mBingVerifyBtn;
+	LLButton* mGoogleVerifyBtn;
+	LLButton* mOKBtn;
+
+	bool mBingKeyVerified;
+	bool mGoogleKeyVerified;
 };
 
 #endif // LL_LLFLOATERTRANSLATIONSETTINGS_H
diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index a74b252c68..7b99c20a58 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -53,6 +53,15 @@ void LLGoogleTranslationHandler::getTranslateURL(
 	}
 }
 
+// virtual
+void LLGoogleTranslationHandler::getKeyVerificationURL(
+	std::string& url,
+	const std::string& key) const
+{
+	url = std::string("https://www.googleapis.com/language/translate/v2/languages?key=")
+		+ key + "&target=en";
+}
+
 // virtual
 bool LLGoogleTranslationHandler::parseResponse(
 	int& status,
@@ -152,6 +161,15 @@ void LLBingTranslarionHandler::getTranslateURL(
 	}
 }
 
+// virtual
+void LLBingTranslarionHandler::getKeyVerificationURL(
+	std::string& url,
+	const std::string& key) const
+{
+	url = std::string("http://api.microsofttranslator.com/v2/Http.svc/GetLanguagesForTranslate?appId=")
+		+ key;
+}
+
 // virtual
 bool LLBingTranslarionHandler::parseResponse(
 	int& status,
@@ -251,6 +269,27 @@ void LLTranslate::TranslationReceiver::completedRaw(
 	}
 }
 
+LLTranslate::KeyVerificationReceiver::KeyVerificationReceiver(EService service)
+:	mService(service)
+{
+}
+
+LLTranslate::EService LLTranslate::KeyVerificationReceiver::getService() const
+{
+	return mService;
+}
+
+// virtual
+void LLTranslate::KeyVerificationReceiver::completedRaw(
+	U32 http_status,
+	const std::string& reason,
+	const LLChannelDescriptors& channels,
+	const LLIOPipe::buffer_ptr_t& buffer)
+{
+	bool ok = (http_status == 200);
+	setVerificationStatus(ok);
+}
+
 //static
 void LLTranslate::translateMessage(
 	TranslationReceiverPtr &receiver,
@@ -261,24 +300,21 @@ void LLTranslate::translateMessage(
 	std::string url;
 	receiver->mHandler.getTranslateURL(url, from_lang, to_lang, mesg);
 
-	static const float REQUEST_TIMEOUT = 5;
-    static LLSD sHeader;
-
-	if (!sHeader.size())
-	{
-	    std::string user_agent = llformat("%s %d.%d.%d (%d)",
-			LLVersionInfo::getChannel().c_str(),
-			LLVersionInfo::getMajor(),
-			LLVersionInfo::getMinor(),
-			LLVersionInfo::getPatch(),
-			LLVersionInfo::getBuild());
+	LL_DEBUGS("Translate") << "Sending translation request: " << url << LL_ENDL;
+	sendRequest(url, receiver);
+}
 
-		sHeader.insert("Accept", "text/plain");
-		sHeader.insert("User-Agent", user_agent);
-	}
+// static
+void LLTranslate::verifyKey(
+	KeyVerificationReceiverPtr& receiver,
+	const std::string& key)
+{
+	std::string url;
+	const LLTranslationAPIHandler& handler = getHandler(receiver->getService());
+	handler.getKeyVerificationURL(url, key);
 
-	LL_DEBUGS("Translate") << "Sending translation request: " << url << LL_ENDL;
-	LLHTTPClient::get(url, receiver, sHeader, REQUEST_TIMEOUT);
+	LL_DEBUGS("Translate") << "Sending key verification request: " << url << LL_ENDL;
+	sendRequest(url, receiver);
 }
 
 //static
@@ -295,15 +331,50 @@ std::string LLTranslate::getTranslateLanguage()
 
 // static
 const LLTranslationAPIHandler& LLTranslate::getPreferredHandler()
+{
+	EService service = SERVICE_BING;
+
+	std::string service_str = gSavedSettings.getString("TranslationService");
+	if (service_str == "google")
+	{
+		service = SERVICE_GOOGLE;
+	}
+
+	return getHandler(service);
+}
+
+// static
+const LLTranslationAPIHandler& LLTranslate::getHandler(EService service)
 {
 	static LLGoogleTranslationHandler google;
 	static LLBingTranslarionHandler bing;
 
-	std::string service = gSavedSettings.getString("TranslationService");
-	if (service == "google")
+	if (service == SERVICE_GOOGLE)
 	{
 		return google;
 	}
 
 	return bing;
 }
+
+// static
+void LLTranslate::sendRequest(const std::string& url, LLHTTPClient::ResponderPtr responder)
+{
+	static const float REQUEST_TIMEOUT = 5;
+	static LLSD sHeader;
+
+	if (!sHeader.size())
+	{
+	    std::string user_agent = llformat("%s %d.%d.%d (%d)",
+			LLVersionInfo::getChannel().c_str(),
+			LLVersionInfo::getMajor(),
+			LLVersionInfo::getMinor(),
+			LLVersionInfo::getPatch(),
+			LLVersionInfo::getBuild());
+
+		sHeader.insert("Accept", "text/plain");
+		sHeader.insert("User-Agent", user_agent);
+	}
+
+	LLHTTPClient::get(url, responder, sHeader, REQUEST_TIMEOUT);
+}
diff --git a/indra/newview/lltranslate.h b/indra/newview/lltranslate.h
index 1bf6965fd4..672a56af8b 100644
--- a/indra/newview/lltranslate.h
+++ b/indra/newview/lltranslate.h
@@ -44,6 +44,10 @@ public:
 		const std::string &to_lang,
 		const std::string &text) const = 0;
 
+	virtual void getKeyVerificationURL(
+		std::string &url,
+		const std::string &key) const = 0;
+
 	virtual bool parseResponse(
 		int& status,
 		const std::string& body,
@@ -67,6 +71,9 @@ public:
 		const std::string &from_lang,
 		const std::string &to_lang,
 		const std::string &text) const;
+	/*virtual*/ void getKeyVerificationURL(
+		std::string &url,
+		const std::string &key) const;
 	/*virtual*/ bool parseResponse(
 		int& status,
 		const std::string& body,
@@ -96,6 +103,9 @@ public:
 		const std::string &from_lang,
 		const std::string &to_lang,
 		const std::string &text) const;
+	/*virtual*/ void getKeyVerificationURL(
+		std::string &url,
+		const std::string &key) const;
 	/*virtual*/ bool parseResponse(
 		int& status,
 		const std::string& body,
@@ -112,6 +122,12 @@ class LLTranslate
 	LOG_CLASS(LLTranslate);
 
 public :
+
+	typedef enum e_service {
+		SERVICE_BING,
+		SERVICE_GOOGLE,
+	} EService;
+
 	class TranslationReceiver: public LLHTTPClient::Responder
 	{
 	public:
@@ -134,13 +150,34 @@ public :
 		const LLTranslationAPIHandler& mHandler;
 	};
 
+	class KeyVerificationReceiver: public LLHTTPClient::Responder
+	{
+	public:
+		EService getService() const;
+
+	protected:
+		KeyVerificationReceiver(EService service);
+		/*virtual*/ void completedRaw(
+			U32 http_status,
+			const std::string& reason,
+			const LLChannelDescriptors& channels,
+			const LLIOPipe::buffer_ptr_t& buffer);
+		virtual void setVerificationStatus(bool ok) = 0;
+
+		EService mService;
+	};
+
 	typedef boost::intrusive_ptr<TranslationReceiver> TranslationReceiverPtr;
+	typedef boost::intrusive_ptr<KeyVerificationReceiver> KeyVerificationReceiverPtr;
 
 	static void translateMessage(TranslationReceiverPtr &receiver, const std::string &from_lang, const std::string &to_lang, const std::string &mesg);
+	static void verifyKey(KeyVerificationReceiverPtr& receiver, const std::string& key);
 	static std::string getTranslateLanguage();
 
 private:
 	static const LLTranslationAPIHandler& getPreferredHandler();
+	static const LLTranslationAPIHandler& getHandler(EService service);
+	static void sendRequest(const std::string& url, LLHTTPClient::ResponderPtr responder);
 };
 
 #endif
diff --git a/indra/newview/skins/default/xui/en/floater_translation_settings.xml b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
index f21f64fcf6..e13c810820 100644
--- a/indra/newview/skins/default/xui/en/floater_translation_settings.xml
+++ b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
@@ -1,16 +1,19 @@
 <?xml version="1.0" encoding="utf-8" standalone="yes" ?>
 <floater
  legacy_header_height="18"
- height="320"
+ height="310"
  layout="topleft"
  name="floater_translation_settings"
  help_topic="environment_editor_floater"
  save_rect="true"
  title="TRANSLATION SETTINGS"
- width="350">
+ width="480">
 
- <string name="no_bing_api_key">Bing Translator requires and appID to function.</string>
- <string name="no_google_api_key">Google Translate requires an API key to function.</string>
+ <string name="bing_api_key_not_verified">Bing appID not verified. Please try again.</string>
+ <string name="google_api_key_not_verified">Google API key not verified. Please try again.</string>
+
+ <string name="bing_api_key_verified">Bing appID verified.</string>
+ <string name="google_api_key_verified">Google API key verified.</string>
 
  <check_box
   height="16"     
@@ -125,7 +128,7 @@
 
  <radio_group
   follows="top|left"
-  height="55"
+  height="70"
   layout="topleft"
   left_delta="10"
   name="translation_service_rg"
@@ -141,7 +144,7 @@
    label="Google Translate"
    layout="topleft"
    name="google"
-   top_pad="20" />
+   top_pad="55" />
  </radio_group>
 
  <text
@@ -150,13 +153,14 @@
   follows="top|right"
   height="20"
   layout="topleft"
-  left="10"
+  left="40"
   name="bing_api_key_label"
-  top_pad="20"
+  top_pad="-45"
   width="100">
   Bing [http://www.bing.com/developers/createapp.aspx AppID]:
   </text>
  <line_editor
+  default_text="Enter Bing AppID and click &quot;Verify&quot;"
   follows="top|left"
   height="20"
   layout="topleft"
@@ -164,22 +168,31 @@
   max_length_chars="50"
   top_delta="-4"
   name="bing_api_key"
-  value=""
   width="220" />
+ <button
+  follows="left|top"
+  height="23"
+  label="Verify"
+  layout="topleft"
+  left_pad="10"
+  name="verify_bing_api_key_btn"
+  top_delta="-2"
+  width="90" />	
 
  <text
   follows="top|right"
   height="20"
   layout="topleft"
-  left="10"
+  left="40"
   length="1"
   name="google_api_key_label"
-  top_pad="20"
+  top_pad="50"
   type="string"
   width="100">
-  Google [http://code.google.com/apis/language/translate/v2/pricing.html API key]:
+  Google [http://code.google.com/apis/language/translate/v2/getting_started.html#auth API key]:
  </text>
  <line_editor
+  default_text="Enter Google API key and click &quot;Verify&quot;"
   follows="top|left"
   height="20"
   layout="topleft"
@@ -188,6 +201,15 @@
   top_delta="-4"
   name="google_api_key"
   width="220" />
+ <button
+  follows="left|top"
+  height="23"
+  label="Verify"
+  layout="topleft"
+  left_pad="10"
+  name="verify_google_api_key_btn"
+  top_delta="-2"
+  width="90" />	
 
  <text
   follows="top|right"
@@ -195,11 +217,11 @@
   layout="topleft"
   left="155"
   length="1"
-  name="google_pricing_link"
-  top_delta="-80"
+  name="google_links_text"
+  top_delta="-23"
   type="string"
   width="100">
-  ([http://code.google.com/apis/language/translate/v2/pricing.html pricing])
+  [http://code.google.com/apis/language/translate/v2/pricing.html Pricing] | [https://code.google.com/apis/console Stats] 
  </text>
 
  <button
-- 
cgit v1.2.3


From d6c8d3dca8cad5d904d3fd4d6eb85ef2a76c0931 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Tue, 13 Sep 2011 03:20:58 +0300
Subject: STORM-1577 WIP Show translation errors in chat.

---
 indra/newview/llviewermessage.cpp              | 4 +++-
 indra/newview/skins/default/xui/en/strings.xml | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llviewermessage.cpp b/indra/newview/llviewermessage.cpp
index ff02214194..0eae6e6383 100644
--- a/indra/newview/llviewermessage.cpp
+++ b/indra/newview/llviewermessage.cpp
@@ -3149,7 +3149,9 @@ protected:
 
 	void handleFailure(int status, const std::string& err_msg)
 	{
-		m_chat.mText += " (?)";
+		std::string msg = LLTrans::getString("TranslationFailed", LLSD().with("[REASON]", err_msg));
+		LLStringUtil::replaceString(msg, "\n", " "); // we want one-line error messages
+		m_chat.mText += " (" + msg + ")";
 
 		LLNotificationsUI::LLNotificationManager::instance().onChat(m_chat, m_toastArgs);
 	}
diff --git a/indra/newview/skins/default/xui/en/strings.xml b/indra/newview/skins/default/xui/en/strings.xml
index 146665b47d..f0bb82fdda 100644
--- a/indra/newview/skins/default/xui/en/strings.xml
+++ b/indra/newview/skins/default/xui/en/strings.xml
@@ -3503,6 +3503,7 @@ Try enclosing path to the editor with double quotes.
  <string name="ExternalEditorFailedToRun">External editor failed to run.</string>
 
  <!--  Machine translation of chat messahes -->
+ <string name="TranslationFailed">Translation failed: [REASON]</string>
  <string name="TranslationResponseParseError">Error parsing translation response.</string>
 
   <!-- Key names begin -->
-- 
cgit v1.2.3


From 10b7c8d07f0c68613e29acecc334ea2d345d8ca3 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Thu, 15 Sep 2011 14:55:32 +0300
Subject: STORM-1577 WIP Trying to fix a Windows compiler error in unit tests.

---
 indra/newview/tests/lltranslate_test.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'indra/newview')

diff --git a/indra/newview/tests/lltranslate_test.cpp b/indra/newview/tests/lltranslate_test.cpp
index 0f3429b7b3..da11b8394a 100644
--- a/indra/newview/tests/lltranslate_test.cpp
+++ b/indra/newview/tests/lltranslate_test.cpp
@@ -316,7 +316,8 @@ LLCurl::Responder::~Responder() {}
 void LLHTTPClient::get(const std::string&, const LLSD&, ResponderPtr, const LLSD&, const F32) {}
 void LLHTTPClient::get(const std::string&, boost::intrusive_ptr<LLCurl::Responder>, const LLSD&, const F32) {}
 
-LLBufferStream::LLBufferStream(const LLChannelDescriptors& channels, LLBufferArray* buffer) : mStreamBuf(channels, buffer) {}
+LLBufferStream::LLBufferStream(const LLChannelDescriptors& channels, LLBufferArray* buffer)
+:	std::iostream(&mStreamBuf), mStreamBuf(channels, buffer) {}
 LLBufferStream::~LLBufferStream() {}
 
 LLBufferStreamBuf::LLBufferStreamBuf(const LLChannelDescriptors&, LLBufferArray*) {}
-- 
cgit v1.2.3


From 1474f8c9a288dbc475ae8c482ee9961a39e94c0a Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Fri, 16 Sep 2011 00:38:17 +0300
Subject: STORM-1577 WIP Addressing review feedback.

* Don't enable the "Verify" button if use just moves cursor in the API key input field.
* Fixed copy&paste error in unit tests.
* Fixed a typo: LLBingTranslarionHandler
* Added Doxygen comments to lltranslate.h.
---
 indra/newview/llfloatertranslationsettings.cpp |  12 ++-
 indra/newview/lltranslate.cpp                  |  12 +--
 indra/newview/lltranslate.h                    | 109 ++++++++++++++++++++++++-
 indra/newview/tests/lltranslate_test.cpp       |   4 +-
 4 files changed, 123 insertions(+), 14 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
index ac3e7ac8fa..ac4514b438 100644
--- a/indra/newview/llfloatertranslationsettings.cpp
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -253,14 +253,18 @@ void LLFloaterTranslationSettings::onEditorFocused(LLFocusableElement* control)
 
 void LLFloaterTranslationSettings::onBingKeyEdited()
 {
-	mBingAPIKeyEditor->setTentative(FALSE);
-	setBingVerified(false, false);
+	if (mBingAPIKeyEditor->isDirty())
+	{
+		setBingVerified(false, false);
+	}
 }
 
 void LLFloaterTranslationSettings::onGoogleKeyEdited()
 {
-	mGoogleAPIKeyEditor->setTentative(FALSE);
-	setGoogleVerified(false, false);
+	if (mGoogleAPIKeyEditor->isDirty())
+	{
+		setGoogleVerified(false, false);
+	}
 }
 
 void LLFloaterTranslationSettings::onBtnBingVerify()
diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index 7b99c20a58..7eb54271f4 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -117,6 +117,8 @@ bool LLGoogleTranslationHandler::parseTranslation(
 	std::string& translation,
 	std::string& detected_lang)
 {
+	// JsonCpp is prone to aborting the program on failed assertions,
+	// so be super-careful and verify the response format.
 	const Json::Value& data = root.get("data", 0);
 	if (!data.isObject() || !data.isMember("translations"))
 	{
@@ -147,7 +149,7 @@ std::string LLGoogleTranslationHandler::getAPIKey()
 }
 
 // virtual
-void LLBingTranslarionHandler::getTranslateURL(
+void LLBingTranslationHandler::getTranslateURL(
 	std::string &url,
 	const std::string &from_lang,
 	const std::string &to_lang,
@@ -162,7 +164,7 @@ void LLBingTranslarionHandler::getTranslateURL(
 }
 
 // virtual
-void LLBingTranslarionHandler::getKeyVerificationURL(
+void LLBingTranslationHandler::getKeyVerificationURL(
 	std::string& url,
 	const std::string& key) const
 {
@@ -171,7 +173,7 @@ void LLBingTranslarionHandler::getKeyVerificationURL(
 }
 
 // virtual
-bool LLBingTranslarionHandler::parseResponse(
+bool LLBingTranslationHandler::parseResponse(
 	int& status,
 	const std::string& body,
 	std::string& translation,
@@ -217,7 +219,7 @@ bool LLBingTranslarionHandler::parseResponse(
 }
 
 // static
-std::string LLBingTranslarionHandler::getAPIKey()
+std::string LLBingTranslationHandler::getAPIKey()
 {
 	return gSavedSettings.getString("BingTranslateAPIKey");
 }
@@ -347,7 +349,7 @@ const LLTranslationAPIHandler& LLTranslate::getPreferredHandler()
 const LLTranslationAPIHandler& LLTranslate::getHandler(EService service)
 {
 	static LLGoogleTranslationHandler google;
-	static LLBingTranslarionHandler bing;
+	static LLBingTranslationHandler bing;
 
 	if (service == SERVICE_GOOGLE)
 	{
diff --git a/indra/newview/lltranslate.h b/indra/newview/lltranslate.h
index 672a56af8b..c2330daa81 100644
--- a/indra/newview/lltranslate.h
+++ b/indra/newview/lltranslate.h
@@ -35,19 +35,53 @@ namespace Json
     class Value;
 }
 
+/**
+ * Handler of an HTTP machine translation service.
+ *
+ * Derived classes know the service URL
+ * and how to parse the translation result.
+ */
 class LLTranslationAPIHandler
 {
 public:
+	/**
+	 * Get URL for translation of the given string.
+	 *
+	 * Sending HTTP GET request to the URL will initiate translation.
+	 *
+	 * @param[out] url        Place holder for the result.
+	 * @param      from_lang  Source language. Leave empty for auto-detection.
+	 * @param      to_lang    Target language.
+	 * @param      text       Text to translate.
+	 */
 	virtual void getTranslateURL(
 		std::string &url,
 		const std::string &from_lang,
 		const std::string &to_lang,
 		const std::string &text) const = 0;
 
+	/**
+	 * Get URL to verify the given API key.
+	 *
+	 * Sending request to the URL verifies the key.
+	 * Positive HTTP response (code 200) means that the key is valid.
+	 *
+	 * @param[out] url  Place holder for the URL.
+	 * @param[in]  key  Key to verify.
+	 */
 	virtual void getKeyVerificationURL(
 		std::string &url,
 		const std::string &key) const = 0;
 
+	/**
+	 * Parse translation response.
+	 *
+	 * @param[in,out] status        HTTP status. May be modified while parsing.
+	 * @param         body          Response text.
+	 * @param[out]    translation   Translated text.
+	 * @param[out]    detected_lang Detected source language. May be empty.
+	 * @param[out]    err_msg       Error message (in case of error).
+	 */
 	virtual bool parseResponse(
 		int& status,
 		const std::string& body,
@@ -61,6 +95,7 @@ protected:
 	static const int STATUS_OK = 200;
 };
 
+/// Google Translate v2 API handler.
 class LLGoogleTranslationHandler : public LLTranslationAPIHandler
 {
 	LOG_CLASS(LLGoogleTranslationHandler);
@@ -93,9 +128,10 @@ private:
 	static std::string getAPIKey();
 };
 
-class LLBingTranslarionHandler : public LLTranslationAPIHandler
+/// Microsoft Translator v2 API handler.
+class LLBingTranslationHandler : public LLTranslationAPIHandler
 {
-	LOG_CLASS(LLBingTranslarionHandler);
+	LOG_CLASS(LLBingTranslationHandler);
 
 public:
 	/*virtual*/ void getTranslateURL(
@@ -116,7 +152,18 @@ private:
 	static std::string getAPIKey();
 };
 
-
+/**
+ * Entry point for machine translation services.
+ *
+ * Basically, to translate a string, we need to know the URL
+ * of a translation service, have a valid API for the service
+ * and be given the target language.
+ *
+ * Callers specify the string to translate and the target language,
+ * LLTranslate takes care of the rest.
+ *
+ * API keys for translation are taken from saved settings.
+ */
 class LLTranslate
 {
 	LOG_CLASS(LLTranslate);
@@ -128,9 +175,23 @@ public :
 		SERVICE_GOOGLE,
 	} EService;
 
+	/**
+	 * Subclasses are supposed to handle translation results (e.g. show them in chat)
+	 */
 	class TranslationReceiver: public LLHTTPClient::Responder
 	{
 	public:
+
+		/**
+		 * Using mHandler, parse incoming response.
+		 *
+		 * Calls either handleResponse() or handleFailure()
+		 * depending on the HTTP status code and parsing success.
+		 *
+		 * @see handleResponse()
+		 * @see handleFailure()
+		 * @see mHandler
+		 */
 		/*virtual*/ void completedRaw(
 			U32 http_status,
 			const std::string& reason,
@@ -140,9 +201,13 @@ public :
 	protected:
 		friend class LLTranslate;
 
+		/// Remember source and target languages for subclasses to be able to filter inappropriate results.
 		TranslationReceiver(const std::string& from_lang, const std::string& to_lang);
 
+		/// Override point to handle successful translation.
 		virtual void handleResponse(const std::string &translation, const std::string &recognized_lang) = 0;
+
+		/// Override point to handle unsuccessful translation.
 		virtual void handleFailure(int status, const std::string& err_msg) = 0;
 
 		std::string mFromLang;
@@ -150,18 +215,41 @@ public :
 		const LLTranslationAPIHandler& mHandler;
 	};
 
+	/**
+	 * Subclasses are supposed to handle API key verification result.
+	 */
 	class KeyVerificationReceiver: public LLHTTPClient::Responder
 	{
 	public:
 		EService getService() const;
 
 	protected:
+		/**
+		 * Save the translation service the key belongs to.
+		 *
+		 * Subclasses need to know it.
+		 *
+		 * @see getService()
+		 */
 		KeyVerificationReceiver(EService service);
+
+		/**
+		 * Parse verification response.
+		 *
+		 * Calls setVerificationStatus() with the verification status,
+		 * which is true if HTTP status code is 200.
+		 *
+		 * @see setVerificationStatus()
+		 */
 		/*virtual*/ void completedRaw(
 			U32 http_status,
 			const std::string& reason,
 			const LLChannelDescriptors& channels,
 			const LLIOPipe::buffer_ptr_t& buffer);
+
+		/**
+		 * Override point for subclasses to handle key verification status.
+		 */
 		virtual void setVerificationStatus(bool ok) = 0;
 
 		EService mService;
@@ -170,7 +258,22 @@ public :
 	typedef boost::intrusive_ptr<TranslationReceiver> TranslationReceiverPtr;
 	typedef boost::intrusive_ptr<KeyVerificationReceiver> KeyVerificationReceiverPtr;
 
+	/**
+	 * Translate given text.
+	 *
+	 * @param receiver   Object to pass translation result to.
+	 * @param from_lang  Source language. Leave empty for auto-detection.
+	 * @param to_lang    Target language.
+	 * @param mesg       Text to translate.
+	 */
 	static void translateMessage(TranslationReceiverPtr &receiver, const std::string &from_lang, const std::string &to_lang, const std::string &mesg);
+
+	/**
+	 * Verify given API key of a translation service.
+	 *
+	 * @param receiver  Object to pass verification result to.
+	 * @param key       Key to verify.
+	 */
 	static void verifyKey(KeyVerificationReceiverPtr& receiver, const std::string& key);
 	static std::string getTranslateLanguage();
 
diff --git a/indra/newview/tests/lltranslate_test.cpp b/indra/newview/tests/lltranslate_test.cpp
index da11b8394a..10e37fae97 100644
--- a/indra/newview/tests/lltranslate_test.cpp
+++ b/indra/newview/tests/lltranslate_test.cpp
@@ -105,7 +105,7 @@ namespace tut
 		}
 
 		LLGoogleTranslationHandler mGoogle;
-		LLBingTranslarionHandler mBing;
+		LLBingTranslationHandler mBing;
 	};
 
 	typedef test_group<translate_test> translate_test_group_t;
@@ -158,7 +158,7 @@ namespace tut
 	void translate_test_object_t::test<7>()
 	{
 		test_translation(mGoogle, 400,
-			"{\"oops\": \"invalid\"}",
+			"{\"data\": {}}",
 			"", "", "");
 	}
 
-- 
cgit v1.2.3


From b48b509d1b6bbbc2ad8a6429e4031c668bf0bfeb Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Fri, 16 Sep 2011 21:09:37 +0300
Subject: STORM-1577 WIP Fixed the "Google Translate" radio button having too
 small clickable area.

---
 indra/newview/skins/default/xui/en/floater_translation_settings.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/skins/default/xui/en/floater_translation_settings.xml b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
index e13c810820..e36348e396 100644
--- a/indra/newview/skins/default/xui/en/floater_translation_settings.xml
+++ b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
@@ -128,7 +128,7 @@
 
  <radio_group
   follows="top|left"
-  height="70"
+  height="80"
   layout="topleft"
   left_delta="10"
   name="translation_service_rg"
@@ -155,7 +155,7 @@
   layout="topleft"
   left="40"
   name="bing_api_key_label"
-  top_pad="-45"
+  top_pad="-55"
   width="100">
   Bing [http://www.bing.com/developers/createapp.aspx AppID]:
   </text>
-- 
cgit v1.2.3


From 69accb7dffed4b7cfdaa53e921ee198da0a95f16 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Tue, 25 Oct 2011 15:37:12 +0200
Subject: STORM-1577 WIP Changed wording.

---
 indra/newview/skins/default/xui/en/floater_translation_settings.xml | 6 +++---
 indra/newview/skins/default/xui/en/panel_preferences_chat.xml       | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/skins/default/xui/en/floater_translation_settings.xml b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
index e36348e396..1eb75e40f3 100644
--- a/indra/newview/skins/default/xui/en/floater_translation_settings.xml
+++ b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
@@ -6,7 +6,7 @@
  name="floater_translation_settings"
  help_topic="environment_editor_floater"
  save_rect="true"
- title="TRANSLATION SETTINGS"
+ title="CHAT TRANSLATION SETTINGS"
  width="480">
 
  <string name="bing_api_key_not_verified">Bing appID not verified. Please try again.</string>
@@ -17,7 +17,7 @@
 
  <check_box
   height="16"     
-  label="Use machine translation while chatting"
+  label="Enable machine translation while chatting"
   layout="topleft"
   left="10"
   name="translate_chat_checkbox"
@@ -123,7 +123,7 @@
   top_pad="20"
   width="330"
   wrap="true">
-  Choose translation service to use:
+  Choose translation service:
  </text>
 
  <radio_group
diff --git a/indra/newview/skins/default/xui/en/panel_preferences_chat.xml b/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
index 28db34f4d4..caf7fc85f5 100644
--- a/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
+++ b/indra/newview/skins/default/xui/en/panel_preferences_chat.xml
@@ -207,12 +207,12 @@
   <button
    follows="left|top"
    height="23"
-   label="Translation Settings"
+   label="Chat Translation Settings"
    layout="topleft"
    left="30"
    name="ok_btn"
    top="-40"
-   width="130">
+   width="170">
    <button.commit_callback
     function="Pref.TranslationSettings" />
   </button>
-- 
cgit v1.2.3


From 56b2e4ac7c7cc4f27f08b4024ecbeace4c3a3e51 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Tue, 25 Oct 2011 16:36:27 +0200
Subject: STORM-1577 WIP Indented floater contents.

---
 .../default/xui/en/floater_translation_settings.xml  | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/skins/default/xui/en/floater_translation_settings.xml b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
index 1eb75e40f3..40fdaaed66 100644
--- a/indra/newview/skins/default/xui/en/floater_translation_settings.xml
+++ b/indra/newview/skins/default/xui/en/floater_translation_settings.xml
@@ -7,7 +7,7 @@
  help_topic="environment_editor_floater"
  save_rect="true"
  title="CHAT TRANSLATION SETTINGS"
- width="480">
+ width="485">
 
  <string name="bing_api_key_not_verified">Bing appID not verified. Please try again.</string>
  <string name="google_api_key_not_verified">Google API key not verified. Please try again.</string>
@@ -27,7 +27,7 @@
   height="20"
   follows="left|top"
   layout="topleft"
-  left="10"
+  left="40"
   name="translate_language_label"
   top_pad="20"
   width="130">
@@ -118,7 +118,7 @@
   follows="top|left|right"
   height="15"
   layout="topleft"
-  left="10"
+  left="40"
   name="tip"
   top_pad="20"
   width="330"
@@ -153,10 +153,10 @@
   follows="top|right"
   height="20"
   layout="topleft"
-  left="40"
+  left="70"
   name="bing_api_key_label"
   top_pad="-55"
-  width="100">
+  width="85">
   Bing [http://www.bing.com/developers/createapp.aspx AppID]:
   </text>
  <line_editor
@@ -168,7 +168,7 @@
   max_length_chars="50"
   top_delta="-4"
   name="bing_api_key"
-  width="220" />
+  width="210" />
  <button
   follows="left|top"
   height="23"
@@ -183,12 +183,12 @@
   follows="top|right"
   height="20"
   layout="topleft"
-  left="40"
+  left="70"
   length="1"
   name="google_api_key_label"
   top_pad="50"
   type="string"
-  width="100">
+  width="85">
   Google [http://code.google.com/apis/language/translate/v2/getting_started.html#auth API key]:
  </text>
  <line_editor
@@ -200,7 +200,7 @@
   max_length_chars="50"
   top_delta="-4"
   name="google_api_key"
-  width="220" />
+  width="210" />
  <button
   follows="left|top"
   height="23"
@@ -215,7 +215,7 @@
   follows="top|right"
   height="20"
   layout="topleft"
-  left="155"
+  left="185"
   length="1"
   name="google_links_text"
   top_delta="-23"
-- 
cgit v1.2.3


From 2bcef9312bc232ab4ff88a9e366aa071a0e2eb67 Mon Sep 17 00:00:00 2001
From: Vadim ProductEngine <vsavchuk@productengine.com>
Date: Tue, 25 Oct 2011 17:14:58 +0200
Subject: STORM-1577 WIP Don't reset the hint on click in a key input field if
 the field is disabled.

---
 indra/newview/llfloatertranslationsettings.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llfloatertranslationsettings.cpp b/indra/newview/llfloatertranslationsettings.cpp
index ac4514b438..959edff713 100644
--- a/indra/newview/llfloatertranslationsettings.cpp
+++ b/indra/newview/llfloatertranslationsettings.cpp
@@ -241,7 +241,7 @@ void LLFloaterTranslationSettings::verifyKey(int service, const std::string& key
 void LLFloaterTranslationSettings::onEditorFocused(LLFocusableElement* control)
 {
 	LLLineEditor* editor = dynamic_cast<LLLineEditor*>(control);
-	if (editor)
+	if (editor && editor->hasTabStop()) // if enabled. getEnabled() doesn't work
 	{
 		if (editor->getTentative())
 		{
-- 
cgit v1.2.3