From 8d9863f4ef039af4f6af7f41909e212b9101ce0f Mon Sep 17 00:00:00 2001 From: Todd Stinson Date: Fri, 6 Apr 2012 13:37:11 -0700 Subject: Altering the layout of the pathfinding console based on feedback. --- indra/newview/llfloaterpathfindingbasic.cpp | 6 +- indra/newview/llfloaterpathfindingcharacters.cpp | 10 +- indra/newview/llfloaterpathfindingconsole.cpp | 15 +- indra/newview/llfloaterpathfindinglinksets.cpp | 13 +- indra/newview/skins/default/colors.xml | 1601 ++++++++++---------- .../default/xui/en/floater_pathfinding_console.xml | 423 +++--- 6 files changed, 1054 insertions(+), 1014 deletions(-) (limited to 'indra/newview') diff --git a/indra/newview/llfloaterpathfindingbasic.cpp b/indra/newview/llfloaterpathfindingbasic.cpp index d1103088ab..19d6742559 100644 --- a/indra/newview/llfloaterpathfindingbasic.cpp +++ b/indra/newview/llfloaterpathfindingbasic.cpp @@ -115,7 +115,7 @@ void LLFloaterPathfindingBasic::onAgentStateCB(LLPathfindingManager::EAgentState void LLFloaterPathfindingBasic::setAgentState(LLPathfindingManager::EAgentState pAgentState) { - static const LLColor4 warningColor = LLUIColorTable::instance().getColor("DrYellow"); + static const LLColor4 errorColor = LLUIColorTable::instance().getColor("PathfindingErrorColor"); LLStyle::Params styleParams; switch (pAgentState) @@ -126,12 +126,12 @@ void LLFloaterPathfindingBasic::setAgentState(LLPathfindingManager::EAgentState break; case LLPathfindingManager::kAgentStateNotEnabled : mStatusText->setVisible(TRUE); - styleParams.color = warningColor; + styleParams.color = errorColor; mStatusText->setText((LLStringExplicit)getString("status_pathfinding_not_enabled"), styleParams); break; case LLPathfindingManager::kAgentStateError : mStatusText->setVisible(TRUE); - styleParams.color = warningColor; + styleParams.color = errorColor; mStatusText->setText((LLStringExplicit)getString("status_unable_to_change_state"), styleParams); break; default : diff --git a/indra/newview/llfloaterpathfindingcharacters.cpp b/indra/newview/llfloaterpathfindingcharacters.cpp index 6fc1b8f051..9998d25c7d 100644 --- a/indra/newview/llfloaterpathfindingcharacters.cpp +++ b/indra/newview/llfloaterpathfindingcharacters.cpp @@ -456,7 +456,8 @@ LLSD LLFloaterPathfindingCharacters::buildCharacterScrollListElement(const LLPat void LLFloaterPathfindingCharacters::updateStatusMessage() { - static const LLColor4 warningColor = LLUIColorTable::instance().getColor("DrYellow"); + static const LLColor4 errorColor = LLUIColorTable::instance().getColor("PathfindingErrorColor"); + static const LLColor4 warningColor = LLUIColorTable::instance().getColor("PathfindingWarningColor"); std::string statusText(""); LLStyle::Params styleParams; @@ -465,13 +466,15 @@ void LLFloaterPathfindingCharacters::updateStatusMessage() { case kMessagingUnknown: statusText = getString("characters_messaging_initial"); + styleParams.color = errorColor; break; case kMessagingGetRequestSent : statusText = getString("characters_messaging_get_inprogress"); + styleParams.color = warningColor; break; case kMessagingGetError : statusText = getString("characters_messaging_get_error"); - styleParams.color = warningColor; + styleParams.color = errorColor; break; case kMessagingComplete : if (mCharactersScrollList->isEmpty()) @@ -498,10 +501,11 @@ void LLFloaterPathfindingCharacters::updateStatusMessage() break; case kMessagingNotEnabled: statusText = getString("characters_messaging_not_enabled"); - styleParams.color = warningColor; + styleParams.color = errorColor; break; default: statusText = getString("characters_messaging_initial"); + styleParams.color = errorColor; llassert(0); break; } diff --git a/indra/newview/llfloaterpathfindingconsole.cpp b/indra/newview/llfloaterpathfindingconsole.cpp index fd5403a7b7..d173764fd1 100644 --- a/indra/newview/llfloaterpathfindingconsole.cpp +++ b/indra/newview/llfloaterpathfindingconsole.cpp @@ -766,7 +766,8 @@ void LLFloaterPathfindingConsole::updateControlsOnConsoleState() void LLFloaterPathfindingConsole::updateStatusOnConsoleState() { - static const LLColor4 warningColor = LLUIColorTable::instance().getColor("DrYellow"); + static const LLColor4 errorColor = LLUIColorTable::instance().getColor("PathfindingErrorColor"); + static const LLColor4 warningColor = LLUIColorTable::instance().getColor("PathfindingWarningColor"); std::string simulatorStatusText(""); std::string viewerStatusText(""); @@ -777,20 +778,22 @@ void LLFloaterPathfindingConsole::updateStatusOnConsoleState() case kConsoleStateUnknown : simulatorStatusText = getString("navmesh_simulator_status_unknown"); viewerStatusText = getString("navmesh_viewer_status_unknown"); + viewerStyleParams.color = errorColor; break; case kConsoleStateLibraryNotImplemented : simulatorStatusText = getString("navmesh_simulator_status_unknown"); viewerStatusText = getString("navmesh_viewer_status_library_not_implemented"); - viewerStyleParams.color = warningColor; + viewerStyleParams.color = errorColor; break; case kConsoleStateRegionNotEnabled : simulatorStatusText = getString("navmesh_simulator_status_unknown"); viewerStatusText = getString("navmesh_viewer_status_region_not_enabled"); - viewerStyleParams.color = warningColor; + viewerStyleParams.color = errorColor; break; case kConsoleStateCheckingVersion : simulatorStatusText = getString("navmesh_simulator_status_unknown"); viewerStatusText = getString("navmesh_viewer_status_checking_version"); + viewerStyleParams.color = warningColor; break; case kConsoleStateDownloading : simulatorStatusText = getSimulatorStatusText(); @@ -802,6 +805,7 @@ void LLFloaterPathfindingConsole::updateStatusOnConsoleState() { viewerStatusText = getString("navmesh_viewer_status_downloading"); } + viewerStyleParams.color = warningColor; break; case kConsoleStateHasNavMesh : simulatorStatusText = getSimulatorStatusText(); @@ -810,11 +814,12 @@ void LLFloaterPathfindingConsole::updateStatusOnConsoleState() case kConsoleStateError : simulatorStatusText = getString("navmesh_simulator_status_unknown"); viewerStatusText = getString("navmesh_viewer_status_error"); - viewerStyleParams.color = warningColor; + viewerStyleParams.color = errorColor; break; default : simulatorStatusText = getString("navmesh_simulator_status_unknown"); viewerStatusText = getString("navmesh_viewer_status_unknown"); + viewerStyleParams.color = errorColor; llassert(0); break; } @@ -967,7 +972,7 @@ void LLFloaterPathfindingConsole::generatePath() void LLFloaterPathfindingConsole::updatePathTestStatus() { - static const LLColor4 warningColor = LLUIColorTable::instance().getColor("DrYellow"); + static const LLColor4 warningColor = LLUIColorTable::instance().getColor("PathfindingWarningColor"); std::string statusText(""); LLStyle::Params styleParams; diff --git a/indra/newview/llfloaterpathfindinglinksets.cpp b/indra/newview/llfloaterpathfindinglinksets.cpp index c2df53a31d..9701002d7d 100644 --- a/indra/newview/llfloaterpathfindinglinksets.cpp +++ b/indra/newview/llfloaterpathfindinglinksets.cpp @@ -864,7 +864,8 @@ bool LLFloaterPathfindingLinksets::isShowCannotBeVolumeWarning(LLPathfindingLink void LLFloaterPathfindingLinksets::updateStatusMessage() { - static const LLColor4 warningColor = LLUIColorTable::instance().getColor("DrYellow"); + static const LLColor4 errorColor = LLUIColorTable::instance().getColor("PathfindingErrorColor"); + static const LLColor4 warningColor = LLUIColorTable::instance().getColor("PathfindingWarningColor"); std::string statusText(""); LLStyle::Params styleParams; @@ -873,20 +874,23 @@ void LLFloaterPathfindingLinksets::updateStatusMessage() { case kMessagingUnknown: statusText = getString("linksets_messaging_initial"); + styleParams.color = errorColor; break; case kMessagingGetRequestSent : statusText = getString("linksets_messaging_get_inprogress"); + styleParams.color = warningColor; break; case kMessagingGetError : statusText = getString("linksets_messaging_get_error"); - styleParams.color = warningColor; + styleParams.color = errorColor; break; case kMessagingSetRequestSent : statusText = getString("linksets_messaging_set_inprogress"); + styleParams.color = warningColor; break; case kMessagingSetError : statusText = getString("linksets_messaging_set_error"); - styleParams.color = warningColor; + styleParams.color = errorColor; break; case kMessagingComplete : if (mLinksetsScrollList->isEmpty()) @@ -913,10 +917,11 @@ void LLFloaterPathfindingLinksets::updateStatusMessage() break; case kMessagingNotEnabled : statusText = getString("linksets_messaging_not_enabled"); - styleParams.color = warningColor; + styleParams.color = errorColor; break; default: statusText = getString("linksets_messaging_initial"); + styleParams.color = errorColor; llassert(0); break; } diff --git a/indra/newview/skins/default/colors.xml b/indra/newview/skins/default/colors.xml index b616e2327b..a39e1a0511 100644 --- a/indra/newview/skins/default/colors.xml +++ b/indra/newview/skins/default/colors.xml @@ -1,825 +1,840 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Leave this here until all Unused? are removed below, otherwise + the viewer generates many warnings on startup. --> + name="Unused?" + value=".831 1 0 1" /> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - + + + + + + + - - - + - - + + name="white" + value="1 1 1 1"/> + name="black" + value="0 0 0 1"/> + name="red" + value="1 0 0 1"/> + name="green" + value="0 1 0 1"/> + name="blue" + value="0 0 1 1"/> diff --git a/indra/newview/skins/default/xui/en/floater_pathfinding_console.xml b/indra/newview/skins/default/xui/en/floater_pathfinding_console.xml index 707b06c643..09fe5f4bc7 100644 --- a/indra/newview/skins/default/xui/en/floater_pathfinding_console.xml +++ b/indra/newview/skins/default/xui/en/floater_pathfinding_console.xml @@ -2,7 +2,7 @@ Please choose start point. Please choose end point. Path is shown in orange. - - Show: - - - - Show walkability map: - - - - - - - - - - - - - - - Viewer status @@ -180,7 +58,7 @@ word_wrap="true" use_ellipses="false" type="string" - text_color="LabelTextColor" + text_color="PathfindingGoodColor" length="1" follows="left|top" layout="topleft" @@ -204,74 +82,124 @@ bevel_style="none" follows="left|top" layout="topleft" - height="73" + height="250" width="200"> - Simulator status + height="13" + word_wrap="true" + use_ellipses="false" + type="string" + text_color="LabelTextColor" + length="1" + follows="left|top" + layout="topleft" + top_pad="9" + width="200"> + Show: + + left="20" + width="180"> + Show walkability map: + + + + + + + + + + + + + - - - Lost characters? Bad performance? - -