From 631b7de4b2262855984ed1d35ae7859507b12e9e Mon Sep 17 00:00:00 2001
From: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date: Wed, 26 Oct 2022 15:03:55 +0300
Subject: SL-18444 Either connection should be create in onOpen or disconnect
 happen in destructor

---
 indra/newview/llinspectobject.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

(limited to 'indra/newview')

diff --git a/indra/newview/llinspectobject.cpp b/indra/newview/llinspectobject.cpp
index 42bf416efb..3d13985f08 100644
--- a/indra/newview/llinspectobject.cpp
+++ b/indra/newview/llinspectobject.cpp
@@ -142,6 +142,10 @@ LLInspectObject::LLInspectObject(const LLSD& sd)
 
 LLInspectObject::~LLInspectObject()
 {
+    if (mSelectionUpdateSlot.connected())
+    {
+        mSelectionUpdateSlot.disconnect();
+    }
 }
 
 /*virtual*/
@@ -247,11 +251,6 @@ void LLInspectObject::onClose(bool app_quitting)
 	mObjectSelection = NULL;
 	mPreviousObjectID = mObjectID;
 
-    if (mSelectionUpdateSlot.connected())
-    {
-        mSelectionUpdateSlot.disconnect();
-    }
-
 	getChild<LLMenuButton>("gear_btn")->hideMenu();
 }
 
-- 
cgit v1.2.3