From 5c797555b3293f0fac20ae5ba27a2bfd6c732215 Mon Sep 17 00:00:00 2001 From: Mike Antipov Date: Fri, 9 Apr 2010 11:50:32 +0300 Subject: Fixed normal bug EXT-6747 ('Favorites bar' folder became blank after part of landmarks were deleted by DnD on Trash button) Reason: LLFolderView::removeSelectedItems() was used to delete dropped items in Places Landmarks Panel. This led to calling this method N times where N is count of selected items. Due to removeSelectedItems() select one of non-removed items each time after removing of selected ones (2*N - 1) items were really deleted. Fix: updated removing in Landmarks panel to remove dropped items one by one. Reviewed by Richard at https://codereview.productengine.com/secondlife/r/204/ --HG-- branch : product-engine --- indra/newview/llpanellandmarks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'indra/newview/llpanellandmarks.h') diff --git a/indra/newview/llpanellandmarks.h b/indra/newview/llpanellandmarks.h index da5d683cfc..2d1eb0f091 100644 --- a/indra/newview/llpanellandmarks.h +++ b/indra/newview/llpanellandmarks.h @@ -142,7 +142,7 @@ private: /** * Processes drag-n-drop of the Landmarks and folders into trash button. */ - bool handleDragAndDropToTrash(BOOL drop, EDragAndDropType cargo_type, EAcceptance* accept); + bool handleDragAndDropToTrash(BOOL drop, EDragAndDropType cargo_type, void* cargo_data, EAcceptance* accept); /** * Landmark actions callbacks. Fire when a landmark is loaded from the list. -- cgit v1.2.3