From 427a33d6108ada1c8ca2e046b87b5d035b0ac877 Mon Sep 17 00:00:00 2001 From: Baker Linden Date: Wed, 9 Oct 2013 17:03:24 -0700 Subject: [GroupBan] Minor fixes / Code review Reviewer: Richard Linden - Minor fixes from code review - Continue stubbing out ban_reason, or implement it (depending on how quickly I can do it, though stubbing out ban_reason will be sufficient, which it is now) - Fixed an issue where a ban list string in the actions tab wasn't showing up properly --- indra/newview/llpanelgroupbulkban.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'indra/newview/llpanelgroupbulkban.cpp') diff --git a/indra/newview/llpanelgroupbulkban.cpp b/indra/newview/llpanelgroupbulkban.cpp index af1809b1f8..3b442036fa 100644 --- a/indra/newview/llpanelgroupbulkban.cpp +++ b/indra/newview/llpanelgroupbulkban.cpp @@ -100,16 +100,10 @@ BOOL LLPanelGroupBulkBan::postBuild() mImplementation->mTooManySelected = getString("ban_selection_too_large"); update(); - - // return (mImplementation->mRoleNames && - // mImplementation->mBannedAgents && - // mImplementation->mRemoveButton); - - return (mImplementation->mBulkAgentList && - mImplementation->mRemoveButton); + return TRUE; } - +// TODO: Refactor the shitty callback functions with void* -- just use boost::bind to call submit() instead. void LLPanelGroupBulkBan::callbackClickSubmit(void* userdata) { LLPanelGroupBulkBan* selfp = (LLPanelGroupBulkBan*)userdata; -- cgit v1.2.3