From 907918c2deaf5880b5417c50c9e0927d4d9ff499 Mon Sep 17 00:00:00 2001
From: Paul Guslisty <pguslisty@productengine.com>
Date: Tue, 6 Jul 2010 14:34:12 +0300
Subject: EXT-8052 FIXED (Unnecessary selection border remains on
'People->Nearby' tab)
- Hide selection border before showing no items comment
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/681/
--HG--
branch : product-engine
---
indra/llui/llflatlistview.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
(limited to 'indra/llui')
diff --git a/indra/llui/llflatlistview.cpp b/indra/llui/llflatlistview.cpp
index b87851490d..6eb214cb93 100644
--- a/indra/llui/llflatlistview.cpp
+++ b/indra/llui/llflatlistview.cpp
@@ -1067,6 +1067,7 @@ void LLFlatListView::setNoItemsCommentVisible(bool visible) const
mNoItemsCommentTextbox->setRect(comment_rect);
*/
}
+ mSelectedItemsBorder->setVisible(FALSE);
mNoItemsCommentTextbox->setVisible(visible);
}
}
@@ -1096,7 +1097,10 @@ void LLFlatListView::getValues(std::vector<LLSD>& values) const
// virtual
void LLFlatListView::onFocusReceived()
{
- mSelectedItemsBorder->setVisible(TRUE);
+ if (size())
+ {
+ mSelectedItemsBorder->setVisible(TRUE);
+ }
gEditMenuHandler = this;
}
// virtual
--
cgit v1.2.3
From a03e1231486bd5c02e27b7020f53dfd2b397c215 Mon Sep 17 00:00:00 2001
From: Alexei Arabadji <aarabadji@productengine.com>
Date: Tue, 6 Jul 2010 17:00:39 +0300
Subject: EXT-8082 FIXED Fixed viewer crash in outfit list accordion. Details:
1 Avoided memory leak of LLAccordionCtrlTab in LLOutfitsList::refreshList
method. 2 Provided resetting selection in
LLAccordionCtrl::removeCollapsibleCtrl method.
reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/701/
--HG--
branch : product-engine
---
indra/llui/llaccordionctrl.cpp | 6 ++++++
1 file changed, 6 insertions(+)
(limited to 'indra/llui')
diff --git a/indra/llui/llaccordionctrl.cpp b/indra/llui/llaccordionctrl.cpp
index 237d42090f..673631f99a 100644
--- a/indra/llui/llaccordionctrl.cpp
+++ b/indra/llui/llaccordionctrl.cpp
@@ -374,6 +374,12 @@ void LLAccordionCtrl::removeCollapsibleCtrl(LLView* view)
break;
}
}
+
+ // if removed is selected - reset selection
+ if (mSelectedTab == view)
+ {
+ mSelectedTab = NULL;
+ }
}
void LLAccordionCtrl::initNoTabsWidget(const LLTextBox::Params& tb_params)
--
cgit v1.2.3