From 32d66e60fddb26d0736149e16b1b57f7aa186146 Mon Sep 17 00:00:00 2001
From: Tofu Linden <tofu.linden@lindenlab.com>
Date: Fri, 29 Jan 2010 13:36:58 -0800
Subject: CID-342

Checker: UNINIT_CTOR
Function: LLNotification::LLNotification(LLUUID)
File: /indra/llui/llnotifications.h

'don't use this for anything real' code shouldn't exist. :)
---
 indra/llui/llnotifications.h | 4 ----
 1 file changed, 4 deletions(-)

(limited to 'indra/llui/llnotifications.h')

diff --git a/indra/llui/llnotifications.h b/indra/llui/llnotifications.h
index aeb4cebf1b..44ff7894ac 100644
--- a/indra/llui/llnotifications.h
+++ b/indra/llui/llnotifications.h
@@ -369,10 +369,6 @@ private:
 
 	LLNotification(const Params& p);
 
-	// this is just for making it easy to look things up in a set organized by UUID -- DON'T USE IT
-	// for anything real!
-	LLNotification(LLUUID uuid) : mId(uuid) {}
-
 	void cancel();
 
 	bool payloadContainsAll(const std::vector<std::string>& required_fields) const;
-- 
cgit v1.2.3


From a07e40e70db8c9a4b90ff114c2bdca5a4ee6da83 Mon Sep 17 00:00:00 2001
From: Tofu Linden <tofu.linden@lindenlab.com>
Date: Fri, 29 Jan 2010 13:53:20 -0800
Subject: CID-341

Checker: UNINIT_CTOR
Function: LLNotificationComparators::orderBy<const LLUUID &>::orderBy(boost::function<const LLUUID &(boost::shared_ptr<LLNotification>)>, LLNotificationComparators::e_direction)
File: /indra/llui/llnotifications.h
---
 indra/llui/llnotifications.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'indra/llui/llnotifications.h')

diff --git a/indra/llui/llnotifications.h b/indra/llui/llnotifications.h
index 44ff7894ac..7269e43325 100644
--- a/indra/llui/llnotifications.h
+++ b/indra/llui/llnotifications.h
@@ -617,7 +617,7 @@ namespace LLNotificationComparators
 	struct orderBy
 	{
 		typedef boost::function<T (LLNotificationPtr)> field_t;
-		orderBy(field_t field, EDirection = ORDER_INCREASING) : mField(field) {}
+        	orderBy(field_t field, EDirection direction = ORDER_INCREASING) : mField(field), mDirection(direction) {}
 		bool operator()(LLNotificationPtr lhs, LLNotificationPtr rhs)
 		{
 			if (mDirection == ORDER_DECREASING)
-- 
cgit v1.2.3


From 5bf17543c2f920509ff2ffe713f4fff6ae10bdae Mon Sep 17 00:00:00 2001
From: Tofu Linden <tofu.linden@lindenlab.com>
Date: Fri, 29 Jan 2010 13:59:54 -0800
Subject: Backed out changeset 298497c8090c

Gosh, I don't know why this unused ctor actually matters, but it does. o.O
---
 indra/llui/llnotifications.h | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'indra/llui/llnotifications.h')

diff --git a/indra/llui/llnotifications.h b/indra/llui/llnotifications.h
index 44ff7894ac..aeb4cebf1b 100644
--- a/indra/llui/llnotifications.h
+++ b/indra/llui/llnotifications.h
@@ -369,6 +369,10 @@ private:
 
 	LLNotification(const Params& p);
 
+	// this is just for making it easy to look things up in a set organized by UUID -- DON'T USE IT
+	// for anything real!
+	LLNotification(LLUUID uuid) : mId(uuid) {}
+
 	void cancel();
 
 	bool payloadContainsAll(const std::vector<std::string>& required_fields) const;
-- 
cgit v1.2.3


From 93b35ad444bea4257b2bd80029e3d01acec1f497 Mon Sep 17 00:00:00 2001
From: Tofu Linden <tofu.linden@lindenlab.com>
Date: Fri, 29 Jan 2010 14:02:59 -0800
Subject: CID-342 alternative fix

Checker: UNINIT_CTOR
Function: LLNotification::LLNotification(LLUUID)
File: /indra/llui/llnotifications.h
---
 indra/llui/llnotifications.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'indra/llui/llnotifications.h')

diff --git a/indra/llui/llnotifications.h b/indra/llui/llnotifications.h
index cf76d00dcf..d55e0f4043 100644
--- a/indra/llui/llnotifications.h
+++ b/indra/llui/llnotifications.h
@@ -371,7 +371,7 @@ private:
 
 	// this is just for making it easy to look things up in a set organized by UUID -- DON'T USE IT
 	// for anything real!
-	LLNotification(LLUUID uuid) : mId(uuid) {}
+ LLNotification(LLUUID uuid) : mId(uuid), mCancelled(false), mRespondedTo(false), mIgnored(false), mTemporaryResponder(false) {}
 
 	void cancel();
 
-- 
cgit v1.2.3