From ee82ed694c85330d88712e92ee5d28685144f680 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:02:32 -0800 Subject: CID-317 Checker: UNINIT_CTOR Function: LLCacheNameEntry::LLCacheNameEntry() File: /indra/llmessage/llcachename.cpp --- indra/llmessage/llcachename.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llcachename.cpp b/indra/llmessage/llcachename.cpp index dbec2816c8..9363b3a8d5 100644 --- a/indra/llmessage/llcachename.cpp +++ b/indra/llmessage/llcachename.cpp @@ -81,6 +81,8 @@ public: }; LLCacheNameEntry::LLCacheNameEntry() + : mIsGroup(false), + mCreateTime(0) { } -- cgit v1.2.3 From 86d07360f6eb58dda55c3673c863b8c9701b3d32 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:09:19 -0800 Subject: CID-316 Checker: UNINIT_CTOR Function: LLHTTPAssetRequest::LLHTTPAssetRequest(LLHTTPAssetStorage *, const LLUUID &, LLAssetType::EType, LLAssetStorage::ERequestType, const std::basic_string, std::allocator>&, void *) File: /indra/llmessage/llhttpassetstorage.cpp --- indra/llmessage/llhttpassetstorage.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llhttpassetstorage.cpp b/indra/llmessage/llhttpassetstorage.cpp index 49dbdbd56d..1980735bbb 100644 --- a/indra/llmessage/llhttpassetstorage.cpp +++ b/indra/llmessage/llhttpassetstorage.cpp @@ -126,8 +126,9 @@ LLHTTPAssetRequest::LLHTTPAssetRequest(LLHTTPAssetStorage *asp, const std::string& url, CURLM *curl_multi) : LLAssetRequest(uuid, type), - mZInitialized(false) + mZInitialized(false) { + memset(&mZStream, 0, sizeof(mZStream)); // we'll initialize this later, but for now zero the whole C-style struct to avoid debug/coverity noise mAssetStoragep = asp; mCurlHandle = NULL; mCurlMultiHandle = curl_multi; -- cgit v1.2.3 From 3064b556ef56ffceda2c11217ac635ee18559751 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:11:32 -0800 Subject: CID-315 Checker: UNINIT_CTOR Function: LLIMInfo::LLIMInfo() File: /indra/llmessage/llinstantmessage.cpp --- indra/llmessage/llinstantmessage.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llinstantmessage.cpp b/indra/llmessage/llinstantmessage.cpp index 3da41939fa..a9e1ee77ef 100644 --- a/indra/llmessage/llinstantmessage.cpp +++ b/indra/llmessage/llinstantmessage.cpp @@ -68,9 +68,11 @@ const S32 IM_TTL = 1; * LLIMInfo */ LLIMInfo::LLIMInfo() : + mFromGroup(FALSE), mParentEstateID(0), mOffline(0), mViewerThinksToIsOnline(false), + mIMType(IM_NOTHING_SPECIAL), mTimeStamp(0), mSource(IM_FROM_SIM), mTTL(IM_TTL) -- cgit v1.2.3 From c99025f68f5a1433488b67915070056055f325fe Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:13:06 -0800 Subject: CID-314 Checker: UNINIT_CTOR Function: LLHTTPResponseHeader::LLHTTPResponseHeader() File: /indra/llmessage/lliohttpserver.cpp --- indra/llmessage/lliohttpserver.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/lliohttpserver.cpp b/indra/llmessage/lliohttpserver.cpp index 97134bd336..3b1ff414bc 100644 --- a/indra/llmessage/lliohttpserver.cpp +++ b/indra/llmessage/lliohttpserver.cpp @@ -403,7 +403,7 @@ void LLHTTPPipe::unlockChain() class LLHTTPResponseHeader : public LLIOPipe { public: - LLHTTPResponseHeader() {} + LLHTTPResponseHeader() : mCode(0) {} virtual ~LLHTTPResponseHeader() {} protected: -- cgit v1.2.3 From 54cc8274b07a66f412115aae92b18428670889eb Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:14:33 -0800 Subject: CID-313 Checker: UNINIT_CTOR Function: LLHTTPPipe::LLHTTPPipe(const LLHTTPNode &) File: /indra/llmessage/lliohttpserver.cpp --- indra/llmessage/lliohttpserver.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/lliohttpserver.cpp b/indra/llmessage/lliohttpserver.cpp index 3b1ff414bc..d6b672ef5c 100644 --- a/indra/llmessage/lliohttpserver.cpp +++ b/indra/llmessage/lliohttpserver.cpp @@ -74,7 +74,12 @@ class LLHTTPPipe : public LLIOPipe { public: LLHTTPPipe(const LLHTTPNode& node) - : mNode(node), mResponse(NULL), mState(STATE_INVOKE), mChainLock(0), mStatusCode(0) + : mNode(node), + mResponse(NULL), + mState(STATE_INVOKE), + mChainLock(0), + mLockedPump(NULL), + mStatusCode(0) { } virtual ~LLHTTPPipe() { -- cgit v1.2.3 From 68304cbd02442589c28458e0e2574d3a31aa1282 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:15:52 -0800 Subject: CID-312 Checker: UNINIT_CTOR Function: LLHTTPPipe::Response::Response() File: /indra/llmessage/lliohttpserver.cpp --- indra/llmessage/lliohttpserver.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/lliohttpserver.cpp b/indra/llmessage/lliohttpserver.cpp index d6b672ef5c..27530fbfe1 100644 --- a/indra/llmessage/lliohttpserver.cpp +++ b/indra/llmessage/lliohttpserver.cpp @@ -116,7 +116,7 @@ private: void nullPipe(); private: - Response() {;} // Must be accessed through LLPointer. + Response() : mPipe(NULL) {} // Must be accessed through LLPointer. LLHTTPPipe* mPipe; }; friend class Response; -- cgit v1.2.3 From bdbb42c0f6c1f2a8afafca58435446e4e3cc37a2 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:16:59 -0800 Subject: CID-311 Checker: UNINIT_CTOR Function: LLXfer::LLXfer(int) File: /indra/llmessage/llxfer.cpp --- indra/llmessage/llxfer.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llxfer.cpp b/indra/llmessage/llxfer.cpp index 8404f6519d..7aa833ee32 100644 --- a/indra/llmessage/llxfer.cpp +++ b/indra/llmessage/llxfer.cpp @@ -74,6 +74,7 @@ void LLXfer::init (S32 chunk_size) mCallback = NULL; mCallbackDataHandle = NULL; + mCallbackResult = 0; mBufferContainsEOF = FALSE; mBuffer = NULL; -- cgit v1.2.3 From ce8e2fc322737e4afa56451ed13611c1c4b9dd45 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:19:56 -0800 Subject: CID-310 Checker: UNINIT_CTOR Function: LLSimpleResponse::LLSimpleResponse() File: /indra/llmessage/llhttpnode.h --- indra/llmessage/llhttpnode.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llhttpnode.h b/indra/llmessage/llhttpnode.h index 915aacb7cc..8212f58653 100644 --- a/indra/llmessage/llhttpnode.h +++ b/indra/llmessage/llhttpnode.h @@ -305,7 +305,7 @@ protected: ~LLSimpleResponse(); private: - LLSimpleResponse() {;} // Must be accessed through LLPointer. + LLSimpleResponse() : mCode(0) {} // Must be accessed through LLPointer. }; std::ostream& operator<<(std::ostream& out, const LLSimpleResponse& resp); -- cgit v1.2.3 From f4c0a5b042087214acc868783d4c98753070de5b Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:30:41 -0800 Subject: partial appeasement for CID-309 only this piece really matters. a bit. Checker: UNINIT_CTOR Function: LLMessageSystem::LLMessageSystem(const std::basic_string, std::allocator>&, unsigned int, int, int, int, bool, float, float) File: /indra/llmessage/message.cpp --- indra/llmessage/message.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'indra/llmessage') diff --git a/indra/llmessage/message.cpp b/indra/llmessage/message.cpp index e56d818d65..916006bc2d 100644 --- a/indra/llmessage/message.cpp +++ b/indra/llmessage/message.cpp @@ -253,6 +253,8 @@ LLMessageSystem::LLMessageSystem(const std::string& filename, U32 port, { init(); + mSendSize = 0; + mSystemVersionMajor = version_major; mSystemVersionMinor = version_minor; mSystemVersionPatch = version_patch; @@ -323,6 +325,8 @@ LLMessageSystem::LLMessageSystem(const std::string& filename, U32 port, mMaxMessageTime = 1.f; mTrueReceiveSize = 0; + + mReceiveTime = 0.f; } -- cgit v1.2.3 From 641f292a5ada637da3729c77ebfccd6b7edab538 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:31:56 -0800 Subject: CID-308 Checker: UNINIT_CTOR Function: LLPartSysCompressedPacket::LLPartSysCompressedPacket() File: /indra/llmessage/partsyspacket.cpp --- indra/llmessage/partsyspacket.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'indra/llmessage') diff --git a/indra/llmessage/partsyspacket.cpp b/indra/llmessage/partsyspacket.cpp index cfb3572d84..2f9e59accb 100644 --- a/indra/llmessage/partsyspacket.cpp +++ b/indra/llmessage/partsyspacket.cpp @@ -144,6 +144,8 @@ LLPartSysCompressedPacket::LLPartSysCompressedPacket() mData[i] = '\0'; } + mNumBytes = 0; + gSetInitDataDefaults(&mDefaults); } -- cgit v1.2.3 From 749eade1cb714728b7a98afdd94482603e121ea3 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:34:06 -0800 Subject: CID-307 Checker: UNINIT_CTOR Function: LLQueryResponder::LLQueryResponder() File: /indra/llmessage/llares.cpp --- indra/llmessage/llares.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llares.cpp b/indra/llmessage/llares.cpp index 104629c157..52edfc86b9 100644 --- a/indra/llmessage/llares.cpp +++ b/indra/llmessage/llares.cpp @@ -175,7 +175,8 @@ void LLAres::rewriteURI(const std::string &uri, UriRewriteResponder *resp) LLQueryResponder::LLQueryResponder() : LLAres::QueryResponder(), - mResult(ARES_ENODATA) + mResult(ARES_ENODATA), + mType(RES_INVALID) { } -- cgit v1.2.3 From 1ce9515685408241495d7c6929bb37cb694d9006 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:35:36 -0800 Subject: CID-306 Checker: UNINIT_CTOR Function: LLAddrRecord::LLAddrRecord(LLResType, const std::basic_string, std::allocator>&, unsigned int) File: /indra/llmessage/llares.cpp --- indra/llmessage/llares.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llares.cpp b/indra/llmessage/llares.cpp index 52edfc86b9..b29eb300fc 100644 --- a/indra/llmessage/llares.cpp +++ b/indra/llmessage/llares.cpp @@ -642,8 +642,10 @@ LLPtrRecord::LLPtrRecord(const std::string &name, unsigned ttl) } LLAddrRecord::LLAddrRecord(LLResType type, const std::string &name, - unsigned ttl) - : LLDnsRecord(type, name, ttl) + unsigned ttl) + : LLDnsRecord(type, name, ttl), + + mSize(0) { } -- cgit v1.2.3 From a09b94eff726f2390fc9300883cba7cd429af5d3 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:37:28 -0800 Subject: CID-305 Checker: UNINIT_CTOR Function: LLSrvRecord::LLSrvRecord(const std::basic_string, std::allocator>&, unsigned int) File: /indra/llmessage/llares.cpp --- indra/llmessage/llares.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llares.cpp b/indra/llmessage/llares.cpp index b29eb300fc..00e77d20e9 100644 --- a/indra/llmessage/llares.cpp +++ b/indra/llmessage/llares.cpp @@ -704,7 +704,11 @@ bail: } LLSrvRecord::LLSrvRecord(const std::string &name, unsigned ttl) - : LLHostRecord(RES_SRV, name, ttl) + : LLHostRecord(RES_SRV, name, ttl), + + mPriority(0), + mWeight(0), + mPort(0) { } -- cgit v1.2.3 From e5e654ac5a58512c1c14b06d28a81882926e4e46 Mon Sep 17 00:00:00 2001 From: Tofu Linden Date: Fri, 29 Jan 2010 15:57:33 -0800 Subject: CID-298 Checker: UNINIT_CTOR Function: LLMsgData::LLMsgData(const char *) File: /indra/llmessage/llmessagetemplate.h --- indra/llmessage/llmessagetemplate.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'indra/llmessage') diff --git a/indra/llmessage/llmessagetemplate.h b/indra/llmessage/llmessagetemplate.h index d7f02ebd85..8abc0aaab2 100644 --- a/indra/llmessage/llmessagetemplate.h +++ b/indra/llmessage/llmessagetemplate.h @@ -82,7 +82,7 @@ protected: class LLMsgBlkData { public: - LLMsgBlkData(const char *name, S32 blocknum) : mOffset(-1), mBlockNumber(blocknum), mTotalSize(-1) + LLMsgBlkData(const char *name, S32 blocknum) : mBlockNumber(blocknum), mTotalSize(-1) { mName = (char *)name; } @@ -108,7 +108,6 @@ public: temp->addData(data, size, type, data_size); } - S32 mOffset; S32 mBlockNumber; typedef LLDynamicArrayIndexed msg_var_data_map_t; msg_var_data_map_t mMemberVarData; @@ -136,7 +135,6 @@ public: void addDataFast(char *blockname, char *varname, const void *data, S32 size, EMsgVariableType type, S32 data_size = -1); public: - S32 mOffset; typedef std::map msg_blk_data_map_t; msg_blk_data_map_t mMemberBlocks; char *mName; -- cgit v1.2.3