From 6f9ea467c2af271baa8cb1a1afc274de4ffe596d Mon Sep 17 00:00:00 2001 From: Brad Kittenbrink Date: Thu, 11 Apr 2019 17:14:15 -0700 Subject: SL-10948: Fix for crash in llcorehttp/_httplibcurl.cpp. The crash can appear on some non-windows platforms (any LP64 model platforms). Depending on alignment this can overwrite one word of the pointer `op` declared above. Subsequently it will crash when later writing to memory through that pointer --- indra/llcorehttp/_httplibcurl.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'indra/llcorehttp') diff --git a/indra/llcorehttp/_httplibcurl.cpp b/indra/llcorehttp/_httplibcurl.cpp index abd304f6a5..975ce8a4d5 100644 --- a/indra/llcorehttp/_httplibcurl.cpp +++ b/indra/llcorehttp/_httplibcurl.cpp @@ -355,7 +355,8 @@ bool HttpLibcurl::completeRequest(CURLM * multi_handle, CURL * handle, CURLcode } if (op->mStatus) { - int http_status(HTTP_OK); + // note: CURLINFO_RESPONSE_CODE requires a long - https://curl.haxx.se/libcurl/c/CURLINFO_RESPONSE_CODE.html + long http_status(HTTP_OK); if (handle) { -- cgit v1.2.3