From d3eccbcd8b9bc51b1a940325509b9508c3697391 Mon Sep 17 00:00:00 2001 From: Andrew Productengine Date: Mon, 13 Dec 2010 13:17:48 +0200 Subject: STORM-229 FIXED Fixed long loading times and stalling of Viewer while loading big scripts or pasting a lot of text into script. The bug was fixed by Satomi Ahn. Here is the description of what causes the problem from her comment in ticket: "Disabling the loading of syntax keywords in LLScriptEdCore::postBuild() removes the freeze (and with it: syntax highlighting). So it obviously comes from the parsing of the text. I also noticed something else: by adding a llwarn in LLTextEditor::updateSegments(), I saw that this function was called a lot of times when loading a script, roughly once for each line in the script (naively I would have thought only necessary to update when finished... or to only update the new line). My llwarn was in the "if (mReflowIndex < S32_MAX && mKeywords.isLoaded())", which means that, at each call, the text is actually parsed for all keywords... so the parsing of the script becomes quadratic instead of linear!!!" - To fix this, Satomi added a flag depending on which parsing is disabled when it is not necessary. --- doc/contributions.txt | 1 + 1 file changed, 1 insertion(+) (limited to 'doc') diff --git a/doc/contributions.txt b/doc/contributions.txt index 4c33834a46..67683204e2 100644 --- a/doc/contributions.txt +++ b/doc/contributions.txt @@ -607,6 +607,7 @@ Sammy Frederix VWR-6186 Satomi Ahn STORM-501 + STORM-229 Scrippy Scofield VWR-3748 Seg Baphomet -- cgit v1.3 From bd53ba004a522d7c0448cdbf2b5f35b6aebd8397 Mon Sep 17 00:00:00 2001 From: Wolfpup Lowenhar Date: Wed, 15 Dec 2010 09:53:24 -0500 Subject: STORM-776 : unable to change permissions to "no trans" on item in avatar inventory applied Kitty's code changes listed in STROM-288 as it is a related issue and this actualy fixed both issues! --- doc/contributions.txt | 3 +++ indra/newview/llsidepaneliteminfo.cpp | 9 +++++++-- indra/newview/llsidepaneliteminfo.h | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) (limited to 'doc') diff --git a/doc/contributions.txt b/doc/contributions.txt index 67683204e2..780fa0e3c8 100644 --- a/doc/contributions.txt +++ b/doc/contributions.txt @@ -372,6 +372,7 @@ Khyota Wulluf VWR-9966 Kitty Barnett VWR-19699 + STORM-288 Kunnis Basiat VWR-82 VWR-102 @@ -774,10 +775,12 @@ WolfPup Lowenhar STORM-143 STORM-255 STORM-256 + STORM-288 STORM-535 STORM-544 STORM-654 STORM-674 + STORM-776 VWR-20741 VWR-20933 Zai Lynch diff --git a/indra/newview/llsidepaneliteminfo.cpp b/indra/newview/llsidepaneliteminfo.cpp index be797ea937..c8c6858b81 100644 --- a/indra/newview/llsidepaneliteminfo.cpp +++ b/indra/newview/llsidepaneliteminfo.cpp @@ -71,12 +71,12 @@ void LLItemPropertiesObserver::changed(U32 mask) const std::set& mChangedItemIDs = gInventory.getChangedIDs(); std::set::const_iterator it; - const LLUUID& object_id = mFloater->getObjectID(); + const LLUUID& item_id = mFloater->getItemID(); for (it = mChangedItemIDs.begin(); it != mChangedItemIDs.end(); it++) { // set dirty for 'item profile panel' only if changed item is the item for which 'item profile panel' is shown (STORM-288) - if (*it == object_id) + if (*it == item_id) { // if there's a change we're interested in. if((mask & (LLInventoryObserver::LABEL | LLInventoryObserver::INTERNAL | LLInventoryObserver::REMOVE)) != 0) @@ -196,6 +196,11 @@ const LLUUID& LLSidepanelItemInfo::getObjectID() const return mObjectID; } +const LLUUID& LLSidepanelItemInfo::getItemID() const +{ + return mItemID; +} + void LLSidepanelItemInfo::reset() { LLSidepanelInventorySubpanel::reset(); diff --git a/indra/newview/llsidepaneliteminfo.h b/indra/newview/llsidepaneliteminfo.h index 6416e2cfe4..25be145f64 100644 --- a/indra/newview/llsidepaneliteminfo.h +++ b/indra/newview/llsidepaneliteminfo.h @@ -55,6 +55,7 @@ public: void setEditMode(BOOL edit); const LLUUID& getObjectID() const; + const LLUUID& getItemID() const; protected: /*virtual*/ void refresh(); -- cgit v1.3 From 452d9d5e3d5261fa5154bd1fe7ef6298dcacf074 Mon Sep 17 00:00:00 2001 From: Kitty Barnett Date: Fri, 17 Dec 2010 15:15:10 +0100 Subject: Updated contributions.txt for STORM-799 and STORM-800 --- doc/contributions.txt | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc') diff --git a/doc/contributions.txt b/doc/contributions.txt index 780fa0e3c8..740c2f470c 100644 --- a/doc/contributions.txt +++ b/doc/contributions.txt @@ -373,6 +373,8 @@ Khyota Wulluf Kitty Barnett VWR-19699 STORM-288 + STORM-799 + STORM-800 Kunnis Basiat VWR-82 VWR-102 -- cgit v1.3