From 7a83f26323b192b09b4017b5f4f986511345bd36 Mon Sep 17 00:00:00 2001 From: Nat Goodspeed Date: Wed, 21 Dec 2016 19:11:58 -0500 Subject: DRTVWR-418: Temporarily disable Mac generate_breakpad_symbols.py. --- build.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'build.sh') diff --git a/build.sh b/build.sh index 5c48b902d4..0b9b644cda 100755 --- a/build.sh +++ b/build.sh @@ -95,10 +95,17 @@ pre_build() && [ -r "$master_message_template_checkout/message_template.msg" ] \ && template_verifier_master_url="-DTEMPLATE_VERIFIER_MASTER_URL=file://$master_message_template_checkout/message_template.msg" + # nat 2016-12-21: disable generate_breakpad_symbols.py on Mac until we + # figure out why it's breaking. + if [ "$arch" == "Darwin" ] + then RELEASE_CRASH_REPORTING=OFF + else RELEASE_CRASH_REPORTING=ON + fi + "$autobuild" configure --quiet -c $variant -- \ -DPACKAGE:BOOL=ON \ -DUNATTENDED:BOOL=ON \ - -DRELEASE_CRASH_REPORTING:BOOL=ON \ + -DRELEASE_CRASH_REPORTING:BOOL="$RELEASE_CRASH_REPORTING" \ -DVIEWER_CHANNEL:STRING="\"$viewer_channel\"" \ -DGRID:STRING="\"$viewer_grid\"" \ -DLL_TESTS:BOOL="$run_tests" \ -- cgit v1.2.3 From aa2aa5e2da896a4ab96da41b878eb39e0dde8f35 Mon Sep 17 00:00:00 2001 From: Nat Goodspeed Date: Wed, 21 Dec 2016 20:51:18 -0500 Subject: DRTVWR-418: Migrate HAVOK suppression from autobuild.xml to build.sh. Turns out that without HAVOK, we can't build the PhysicsExtensions_TPV; but the viewer's build.sh is unaware of CMake switches set in autobuild.xml. Passing those CMake overrides in build.sh allows us to test that setting elsewhere in build.sh to skip the PhysicsExtensions_TPV step -- instead of failing the build. --- build.sh | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'build.sh') diff --git a/build.sh b/build.sh index 0b9b644cda..f826432d93 100755 --- a/build.sh +++ b/build.sh @@ -95,16 +95,20 @@ pre_build() && [ -r "$master_message_template_checkout/message_template.msg" ] \ && template_verifier_master_url="-DTEMPLATE_VERIFIER_MASTER_URL=file://$master_message_template_checkout/message_template.msg" + # nat 2016-12-20: disable HAVOK on Mac until we get a 64-bit Mac build. # nat 2016-12-21: disable generate_breakpad_symbols.py on Mac until we # figure out why it's breaking. if [ "$arch" == "Darwin" ] - then RELEASE_CRASH_REPORTING=OFF - else RELEASE_CRASH_REPORTING=ON + then HAVOK=OFF + RELEASE_CRASH_REPORTING=OFF + else HAVOK=ON + RELEASE_CRASH_REPORTING=ON fi "$autobuild" configure --quiet -c $variant -- \ -DPACKAGE:BOOL=ON \ -DUNATTENDED:BOOL=ON \ + -DHAVOK:BOOL="$HAVOK" \ -DRELEASE_CRASH_REPORTING:BOOL="$RELEASE_CRASH_REPORTING" \ -DVIEWER_CHANNEL:STRING="\"$viewer_channel\"" \ -DGRID:STRING="\"$viewer_grid\"" \ @@ -119,7 +123,8 @@ package_llphysicsextensions_tpv() { begin_section "PhysicsExtensions_TPV" tpv_status=0 - if [ "$variant" = "Release" ] + # nat 2016-12-21: without HAVOK, can't build PhysicsExtensions_TPV. + if [ "$variant" = "Release" -a "${HAVOK:-}" != "OFF" ] then test -r "$build_dir/packages/llphysicsextensions/autobuild-tpv.xml" || fatal "No llphysicsextensions_tpv autobuild configuration found" tpvconfig=$(native_path "$build_dir/packages/llphysicsextensions/autobuild-tpv.xml") -- cgit v1.2.3 From e9f5ed6591fb5d2513b5065622b9e7dac6737913 Mon Sep 17 00:00:00 2001 From: Oz Linden Date: Thu, 22 Dec 2016 10:18:48 -0500 Subject: fix installer name function for Mac (and maybe Linux?) --- build.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'build.sh') diff --git a/build.sh b/build.sh index f826432d93..7d0a961486 100755 --- a/build.sh +++ b/build.sh @@ -47,8 +47,8 @@ viewer_channel_suffix() installer_Darwin() { local package_name="$1" - local package_dir="$(build_dir_Darwin ${last_built_variant:-Release})/newview/" - local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_i386\\.dmg\$" + local package_dir="newview/$(build_dir_Darwin ${last_built_variant:-Release})/" + local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_x86_64\\.dmg\$" # since the additional packages are built after the base package, # sorting oldest first ensures that the unqualified package is returned # even if someone makes a qualified name that duplicates the last word of the base name @@ -59,7 +59,7 @@ installer_Darwin() installer_Linux() { local package_name="$1" - local package_dir="$(build_dir_Linux ${last_built_variant:-Release})/newview/" + local package_dir="newview/$(build_dir_Linux ${last_built_variant:-Release})/" local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_i686\\.tar\\.bz2\$" # since the additional packages are built after the base package, # sorting oldest first ensures that the unqualified package is returned @@ -381,7 +381,7 @@ then package=$(installer_$arch) if [ x"$package" = x ] || test -d "$package" then - record_event "??? mystery event $package // $build_coverity" + fatal "No installer found at '$package'" succeeded=$build_coverity else # Upload base package. -- cgit v1.2.3 From 6ef555414dedca9db915ef71c320ed53090b1e8e Mon Sep 17 00:00:00 2001 From: Oz Linden Date: Thu, 22 Dec 2016 11:50:33 -0500 Subject: try again to actually fix the installer name function for Mac (and maybe Linux?) --- build.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'build.sh') diff --git a/build.sh b/build.sh index 7d0a961486..7efe6e3492 100755 --- a/build.sh +++ b/build.sh @@ -47,7 +47,8 @@ viewer_channel_suffix() installer_Darwin() { local package_name="$1" - local package_dir="newview/$(build_dir_Darwin ${last_built_variant:-Release})/" + local variant=${last_built_variant:-Release} + local package_dir="$(build_dir_Darwin)/newview/${variant}/" local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_x86_64\\.dmg\$" # since the additional packages are built after the base package, # sorting oldest first ensures that the unqualified package is returned @@ -59,7 +60,8 @@ installer_Darwin() installer_Linux() { local package_name="$1" - local package_dir="newview/$(build_dir_Linux ${last_built_variant:-Release})/" + local variant=${last_built_variant:-Release} + local package_dir="$(build_dir_Linux)/newview/${variant}/" local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_i686\\.tar\\.bz2\$" # since the additional packages are built after the base package, # sorting oldest first ensures that the unqualified package is returned -- cgit v1.2.3 From 0131e8a0815826bda538908991d28e23624c0754 Mon Sep 17 00:00:00 2001 From: Oz Linden Date: Thu, 22 Dec 2016 13:54:39 -0500 Subject: one more try... also fixing setting of viewer_channel without quotes --- build.sh | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'build.sh') diff --git a/build.sh b/build.sh index 7efe6e3492..130c620d23 100755 --- a/build.sh +++ b/build.sh @@ -47,8 +47,7 @@ viewer_channel_suffix() installer_Darwin() { local package_name="$1" - local variant=${last_built_variant:-Release} - local package_dir="$(build_dir_Darwin)/newview/${variant}/" + local package_dir="$(build_dir_Darwin)/newview/" local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_x86_64\\.dmg\$" # since the additional packages are built after the base package, # sorting oldest first ensures that the unqualified package is returned @@ -60,8 +59,7 @@ installer_Darwin() installer_Linux() { local package_name="$1" - local variant=${last_built_variant:-Release} - local package_dir="$(build_dir_Linux)/newview/${variant}/" + local package_dir="$(build_dir_Linux)/newview/" local pattern=".*$(viewer_channel_suffix ${package_name})_[0-9]+_[0-9]+_[0-9]+_[0-9]+_i686\\.tar\\.bz2\$" # since the additional packages are built after the base package, # sorting oldest first ensures that the unqualified package is returned @@ -112,7 +110,7 @@ pre_build() -DUNATTENDED:BOOL=ON \ -DHAVOK:BOOL="$HAVOK" \ -DRELEASE_CRASH_REPORTING:BOOL="$RELEASE_CRASH_REPORTING" \ - -DVIEWER_CHANNEL:STRING="\"$viewer_channel\"" \ + -DVIEWER_CHANNEL:STRING="${viewer_channel}" \ -DGRID:STRING="\"$viewer_grid\"" \ -DLL_TESTS:BOOL="$run_tests" \ -DTEMPLATE_VERIFIER_OPTIONS:STRING="$template_verifier_options" $template_verifier_master_url \ @@ -383,7 +381,7 @@ then package=$(installer_$arch) if [ x"$package" = x ] || test -d "$package" then - fatal "No installer found at '$package'" + fatal "No installer found from `pwd`" succeeded=$build_coverity else # Upload base package. -- cgit v1.2.3 From eaeadf71e00ae8381ca3d68ece5f87a31fa8c46e Mon Sep 17 00:00:00 2001 From: Nat Goodspeed Date: Thu, 22 Dec 2016 15:11:37 -0500 Subject: DRTVWR-418: If we don't produce a symbol file, don't try to upload it. --- build.sh | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) (limited to 'build.sh') diff --git a/build.sh b/build.sh index 7efe6e3492..5639c93f40 100755 --- a/build.sh +++ b/build.sh @@ -405,21 +405,25 @@ then if [ "$last_built_variant" = "Release" ] then - # Upload crash reporter file - # These names must match the set of VIEWER_SYMBOL_FILE in indra/newview/CMakeLists.txt - case "$arch" in - CYGWIN) - symbolfile="$build_dir/newview/Release/secondlife-symbols-windows-${AUTOBUILD_ADDRSIZE}.tar.bz2" - ;; - Darwin) - symbolfile="$build_dir/newview/Release/secondlife-symbols-darwin-${AUTOBUILD_ADDRSIZE}.tar.bz2" - ;; - Linux) - symbolfile="$build_dir/newview/Release/secondlife-symbols-linux-${AUTOBUILD_ADDRSIZE}.tar.bz2" - ;; - esac - python_cmd "$helpers/codeticket.py" addoutput "Symbolfile" "$symbolfile" \ - || fatal "Upload of symbolfile failed" + # nat 2016-12-22: without RELEASE_CRASH_REPORTING, we have no symbol file. + if [ "${RELEASE_CRASH_REPORTING:-}" != "OFF" ] + then + # Upload crash reporter file + # These names must match the set of VIEWER_SYMBOL_FILE in indra/newview/CMakeLists.txt + case "$arch" in + CYGWIN) + symbolfile="$build_dir/newview/Release/secondlife-symbols-windows-${AUTOBUILD_ADDRSIZE}.tar.bz2" + ;; + Darwin) + symbolfile="$build_dir/newview/Release/secondlife-symbols-darwin-${AUTOBUILD_ADDRSIZE}.tar.bz2" + ;; + Linux) + symbolfile="$build_dir/newview/Release/secondlife-symbols-linux-${AUTOBUILD_ADDRSIZE}.tar.bz2" + ;; + esac + python_cmd "$helpers/codeticket.py" addoutput "Symbolfile" "$symbolfile" \ + || fatal "Upload of symbolfile failed" + fi # Upload the llphysicsextensions_tpv package, if one was produced # *TODO: Make this an upload-extension -- cgit v1.2.3