From f5c5c5ec9497211010b5a4dd15bea44d4bbc8482 Mon Sep 17 00:00:00 2001 From: Roxie Linden Date: Tue, 16 Apr 2024 23:11:44 -0700 Subject: Issue in WebRTC was disabling custom audio processing (level detection) There is a case where the custom audio processor, which is used to determine audio levels, was disabled on connection shutdown even when another connection was established. This issue has been patched in the webrtc library. --- autobuild.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/autobuild.xml b/autobuild.xml index f9c99514a1..625fe72449 100644 --- a/autobuild.xml +++ b/autobuild.xml @@ -2901,11 +2901,11 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors creds github hash - a49fb3bb8aaf8325e7c6c4b6036db3da16afa2c9 + 21e31d2c2fffdb59d8f50b80db079f86f2df2483 hash_algorithm sha1 url - https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.53/webrtc-m114.5735.08.53.8337236647-darwin64-8337236647.tar.zst + https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.58/webrtc-m114.5735.08.58.8716173807-darwin64-8716173807.tar.zst name darwin64 @@ -2915,11 +2915,11 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors archive hash - 598baa054f63624a8e16883541c1f3dc7aa15a8a + 600cabb49a889db3a29f2910f5bda08f28dd04c8 hash_algorithm sha1 url - https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.53/webrtc-m114.5735.08.53.8337236647-linux64-8337236647.tar.zst + https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.58/webrtc-m114.5735.08.58.8716173807-linux64-8716173807.tar.zst name linux64 @@ -2931,11 +2931,11 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors creds github hash - 59d5f2e40612ab7b0b1a5da8ba288f48d5979216 + 915c9face95efcc6da240aa2c4f8e6c4aa803af8 hash_algorithm sha1 url - https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.53/webrtc-m114.5735.08.53.8337236647-windows64-8337236647.tar.zst + https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.58/webrtc-m114.5735.08.58.8716173807-windows64-8716173807.tar.zst name windows64 -- cgit v1.2.3 From 53c584e1ded5faf8e572ac7b849e53a91fed6206 Mon Sep 17 00:00:00 2001 From: Roxie Linden Date: Tue, 16 Apr 2024 23:22:39 -0700 Subject: Fix cases where voice outstanding requests could be dropped, resulting in no voice --- indra/newview/llvoicewebrtc.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/indra/newview/llvoicewebrtc.cpp b/indra/newview/llvoicewebrtc.cpp index 710067c2bf..7743d6362a 100644 --- a/indra/newview/llvoicewebrtc.cpp +++ b/indra/newview/llvoicewebrtc.cpp @@ -2192,6 +2192,7 @@ void LLVoiceWebRTCConnection::processIceUpdatesCoro() if (LLWebRTCVoiceClient::isShuttingDown()) { + mOutstandingRequests--; return; } @@ -2281,6 +2282,7 @@ void LLVoiceWebRTCConnection::OnRenegotiationNeeded() { setVoiceConnectionState(VOICE_STATE_SESSION_RETRY); } + mCurrentStatus = LLVoiceClientStatusObserver::ERROR_UNKNOWN; }); } @@ -2369,6 +2371,7 @@ void LLVoiceWebRTCConnection::breakVoiceConnectionCoro() { LL_DEBUGS("Voice") << "no capabilities for voice provisioning; waiting " << LL_ENDL; setVoiceConnectionState(VOICE_STATE_SESSION_RETRY); + mOutstandingRequests--; return; } @@ -2376,6 +2379,7 @@ void LLVoiceWebRTCConnection::breakVoiceConnectionCoro() if (url.empty()) { setVoiceConnectionState(VOICE_STATE_SESSION_RETRY); + mOutstandingRequests--; return; } @@ -2405,6 +2409,7 @@ void LLVoiceWebRTCConnection::breakVoiceConnectionCoro() if (LLWebRTCVoiceClient::isShuttingDown()) { + mOutstandingRequests--; return; } -- cgit v1.2.3