From b96c7ec6e6e2e4f2bfd11469155bec4827ac9517 Mon Sep 17 00:00:00 2001
From: Andrey Kleshchev <andreykproductengine@lindenlab.com>
Date: Mon, 18 Aug 2025 22:15:51 +0300
Subject: #4518 Dupplicates can appear in favorites

if parent and child gets added back to back
---
 indra/newview/llinventorypanel.cpp | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/indra/newview/llinventorypanel.cpp b/indra/newview/llinventorypanel.cpp
index b540e9c5bb..b2dd47548c 100644
--- a/indra/newview/llinventorypanel.cpp
+++ b/indra/newview/llinventorypanel.cpp
@@ -2298,6 +2298,7 @@ public:
 
     void removeItemID(const LLUUID& id) override;
     bool isInRootContent(const LLUUID& id, LLFolderViewItem* view_item) override;
+    bool hasPredecessorsInRootContent(const LLInventoryObject* model_item) const;
 
 protected:
     LLInventoryFavoritesItemsPanel(const Params&);
@@ -2344,6 +2345,24 @@ bool LLInventoryFavoritesItemsPanel::isInRootContent(const LLUUID& id, LLFolderV
     return found != mRootContentIDs.end();
 }
 
+bool LLInventoryFavoritesItemsPanel::hasPredecessorsInRootContent(const LLInventoryObject* obj) const
+{
+    LLUUID parent_id = obj->getParentUUID();
+    while (parent_id.notNull())
+    {
+        if (mRootContentIDs.contains(parent_id))
+        {
+            return true;
+        }
+        LLViewerInventoryCategory* cat = mInventory->getCategory(parent_id);
+        if (cat)
+        {
+            parent_id = cat->getParentUUID();
+        }
+    }
+    return false;
+}
+
 void LLInventoryFavoritesItemsPanel::findAndInitRootContent(const LLUUID& id)
 {
     F64 curent_time = LLTimer::getTotalSeconds();
@@ -2495,7 +2514,8 @@ void LLInventoryFavoritesItemsPanel::itemChanged(const LLUUID& id, U32 mask, con
                         }
 
                         LLFolderViewItem* folder_view_item = getItemByID(cat->getUUID());
-                        if (!folder_view_item)
+                        if (!folder_view_item
+                            && !hasPredecessorsInRootContent(model_item))
                         {
                             const LLUUID& parent_id = cat->getParentUUID();
                             mRootContentIDs.emplace(cat->getUUID());
@@ -2507,7 +2527,9 @@ void LLInventoryFavoritesItemsPanel::itemChanged(const LLUUID& id, U32 mask, con
                 else
                 {
                     // New favorite item
-                    if (model_item->getIsFavorite() && typedViewsFilter(id, model_item))
+                    if (model_item->getIsFavorite()
+                        && typedViewsFilter(id, model_item)
+                        && !hasPredecessorsInRootContent(model_item))
                     {
                         const LLUUID& parent_id = model_item->getParentUUID();
                         mRootContentIDs.emplace(id);
-- 
cgit v1.2.3