From 79836e32d575248642cfd6af837548aac054988f Mon Sep 17 00:00:00 2001 From: Graham Linden Date: Mon, 9 Sep 2013 13:26:13 -0700 Subject: MAINT-140 revert to simplified cleanDeadObjects to avoid accidental refcounting crashes --- indra/newview/llviewerobjectlist.cpp | 28 +++++----------------------- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/indra/newview/llviewerobjectlist.cpp b/indra/newview/llviewerobjectlist.cpp index 66615657d8..8a013a6d91 100755 --- a/indra/newview/llviewerobjectlist.cpp +++ b/indra/newview/llviewerobjectlist.cpp @@ -1324,45 +1324,27 @@ void LLViewerObjectList::cleanDeadObjects(BOOL use_timer) return; } + LLViewerObject *objectp = NULL; S32 num_removed = 0; - LLViewerObject *objectp; - - vobj_list_t::reverse_iterator target = mObjects.rbegin(); - vobj_list_t::iterator iter = mObjects.begin(); - for ( ; iter != mObjects.end(); ) + vobj_list_t::iterator iter; + for (iter = mObjects.begin(); iter != mObjects.end();) { // Scan for all of the dead objects and put them all on the end of the list with no ref count ops objectp = *iter; - if (objectp == NULL) - { //we caught up to the dead tail - break; - } - if (objectp->isDead()) + if (objectp && objectp->isDead()) { - LLPointer::swap(*iter, *target); - *target = NULL; - ++target; + iter = mObjects.erase(iter); num_removed++; - - if (num_removed == mNumDeadObjects || iter->isNull()) - { - // We've cleaned up all of the dead objects or caught up to the dead tail - break; - } } else { ++iter; } } - llassert(num_removed == mNumDeadObjects); - //erase as a block - mObjects.erase(mObjects.begin()+(mObjects.size()-mNumDeadObjects), mObjects.end()); - // We've cleaned the global object list, now let's do some paranoia testing on objects // before blowing away the dead list. mDeadObjects.clear(); -- cgit v1.2.3