Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-03-25 | DRTVWR-494: Defend LLInstanceTracker against multi-thread usage. | Nat Goodspeed | |
The previous implementation went to some effort to crash if anyone attempted to create or destroy an LLInstanceTracker subclass instance during traversal. That restriction is manageable within a single thread, but becomes unworkable if it's possible that a given subclass might be used on more than one thread. Remove LLInstanceTracker::instance_iter, beginInstances(), endInstances(), also key_iter, beginKeys() and endKeys(). Instead, introduce key_snapshot() and instance_snapshot(), the only means of iterating over LLInstanceTracker instances. (These are intended to resemble functions, but in fact the current implementation simply presents the classes.) Iterating over a captured snapshot defends against container modifications during traversal. The term 'snapshot' reminds the coder that a new instance created during traversal will not be considered. To defend against instance deletion during traversal, a snapshot stores std::weak_ptrs which it lazily dereferences, skipping on the fly any that have expired. Dereferencing instance_snapshot::iterator gets you a reference rather than a pointer. Because some use cases want to delete all existing instances, add an instance_snapshot::deleteAll() method that extracts the pointer. Those cases used to require explicitly copying instance pointers into a separate container; instance_snapshot() now takes care of that. It remains the caller's responsibility to ensure that all instances of that LLInstanceTracker subclass were allocated on the heap. Replace unkeyed static LLInstanceTracker::getInstance(T*) -- which returned nullptr if that instance had been destroyed -- with new getWeak() method returning std::weak_ptr<T>. Caller must detect expiration of that weak_ptr. Adjust tests accordingly. Use of std::weak_ptr to detect expired instances requires engaging std::shared_ptr in the constructor. We now store shared_ptrs in the static containers (std::map for keyed, std::set for unkeyed). Make LLInstanceTrackerBase a template parameterized on the type of the static data it manages. For that reason, hoist static data class declarations out of the class definitions to an LLInstanceTrackerStuff namespace. Remove the static atomic sIterationNestDepth and its methods incrementDepth(), decrementDepth() and getDepth(), since they were used only to forbid creation and destruction during traversal. Add a std::mutex to static data. Introduce an internal LockStatic class that locks the mutex while providing a pointer to static data, making that the only way to access the static data. The LLINSTANCETRACKER_DTOR_NOEXCEPT macro goes away because we no longer expect ~LLInstanceTracker() to throw an exception in test programs. That affects LLTrace::StatBase as well as LLInstanceTracker itself. Adapt consumers to the new LLInstanceTracker API. | |||
2020-03-25 | DRTVWR-494: Show copy-paste-friendly env vars and test command. | Nat Goodspeed | |
Moderately often I want to copy the (long) integration test program path from build output and rerun the test program by hand. But typically we need environment variables set as well so it can find its dynamic libraries. This has resulted in my copying parts of several lines of build output, then pasting to a command prompt, then hand-tweaking the pasted text so it makes sense as a command. Streamline run_build_test.py output so less hand-tweaking is needed. | |||
2020-03-18 | Increment viewer version to 6.3.9 | Nat Goodspeed | |
following promotion of DRTVWR-481 | |||
2020-03-10 | SL-12817 New text for snapshot upload | Andrey Kleshchev | |
2020-02-25 | SL-12757 - typo in menu_viewer.xml | Brad Payne (Vir Linden) | |
2020-02-21 | SL-10498 - made benefits debug output a bit less verbose | Brad Payne (Vir Linden) | |
2020-02-21 | merge | Brad Payne (Vir Linden) | |
2020-02-20 | Increment viewer version to 6.3.8 | Nat Goodspeed | |
following promotion of DRTVWR-499 | |||
2020-02-05 | Revert SL-4354 | Andrey Kleshchev | |
2020-02-04 | SL-4354 Used wrong condition | Andrey Kleshchev | |
2020-01-30 | SL-4354 Mesh avatars look broken while loading. | andreykproductengine | |
2020-01-29 | SL-12587 - debug logging option to see list of requested caps | Brad Payne (Vir Linden) | |
2020-01-29 | SL-4354 Mesh avatars look broken while loading. | andreykproductengine | |
2020-01-29 | potential crashfix | andreykproductengine | |
2020-01-29 | SL-12590 SL-12608 Fixed wrong states | andreykproductengine | |
2020-01-28 | Merge branch 'master' of https://bitbucket.org/lindenlab/viewer-private into ↵ | Brad Payne (Vir Linden) | |
DRTVWR-481 Merge | |||
2020-01-28 | Merge branch 'master' into DRTVWR-499 | Andrey Lihatskiy | |
2020-01-28 | Increment viewer version to 6.3.7 | Nat Goodspeed | |
following promotion of DRTVWR-496 | |||
2020-01-20 | SL-9699 Enabled word-wrap for 'remember username' checkbox | andreykproductengine | |
2020-01-20 | SL-12595 The checkbox overlaps buttons in the 'Delete selected item?' ↵ | andreykproductengine | |
notification | |||
2020-01-20 | SL-12596 Fixed incorectly enabled checkbox and enabled login button | andreykproductengine | |
2020-01-17 | SL-12587 - trigger build update | Brad Payne (Vir Linden) | |
2020-01-16 | SL-12587 - added ViewerBenefits to requested caps. | Brad Payne (Vir Linden) | |
2020-01-16 | SL-12569 - Fixed more places where texture upload cost was hardcoded in UI | Brad Payne (Vir Linden) | |
2020-01-16 | SL-12556 Fixed another case of login button being active | andreykproductengine | |
2020-01-13 | SL-12555 Fixed Login failed with credencials after the first incorrect entry | andreykproductengine | |
2020-01-13 | SL-12556 Fixed The ‘Log In’ button being active with empty fields | andreykproductengine | |
2020-01-13 | SL-12537 Fixed crash when the box with 'script' moves between two regions | andreykproductengine | |
2020-01-13 | SL-11921 [IT] fixed location overlaps | maxim_productengine | |
2020-01-10 | SL-12485 The 'Sign up' button is still cropped by 1 pixel | andreykproductengine | |
2020-01-09 | SL-12538 SL-12486 Warning about deleting shared local files and some other ↵ | andreykproductengine | |
fiexes | |||
2020-01-10 | SL-11921 fixed location overlaps | maxim_productengine | |
2020-01-09 | SL-12533 Correct password drop and fixed 'dirty' condition | andreykproductengine | |
2020-01-09 | SL-12533 Switching between grids on login page does not always switch the ↵ | andreykproductengine | |
remembered user list | |||
2020-01-08 | SL-12486 Size check fix | andreykproductengine | |
2020-01-08 | SL-12486 Fix unit test build issues | andreykproductengine | |
2020-01-08 | SL-12505 Projectros fix | andreykproductengine | |
2020-01-07 | SL-12486 Grids share folders and some data, so don't compare grids. | andreykproductengine | |
2020-01-07 | SL-12486 Better data deletion | andreykproductengine | |
2020-01-03 | SL-9699 Do not disable 'remember me' checkbox | andreykproductengine | |
2020-01-02 | SL-12484 EXP-696 Remade "Remember Password" checkbox to be multiline | andreykproductengine | |
2019-12-19 | SL-12485 The 'Sign up' button is cropped in some languages | andreykproductengine | |
2019-12-19 | SL-209 Removed obsolete localization files | andreykproductengine | |
2019-12-19 | SL-11315 Updated labels and notification | andreykproductengine | |
2019-12-16 | no-op change to trigger rebuild | Brad Payne (Vir Linden) | |
2019-12-16 | merge | Brad Payne (Vir Linden) | |
2019-12-16 | merge | Brad Payne (Vir Linden) | |
2019-12-12 | Merged in lindenlab/viewer-release | AndreyL ProductEngine | |
2019-12-12 | increment viewer version to 6.3.6 | Nat Goodspeed | |
2019-12-09 | SL-12414 The "Bulk" upload warning message for .bhv files is confusing | andreykproductengine | |