Age | Commit message (Collapse) | Author | |
---|---|---|---|
2012-05-09 | CHOP-900: Use new apr_procattr_constrain_handle_set() extension. | Nat Goodspeed | |
Now LLProcess explicitly requests APR to limit the handles passed to any child process, instead of wantonly passing whatever happens to be lying around the parent process at the time. This requires the latest APR build. Also revert LLUpdateDownloader::Implementation::mDownloadStream to llofstream (as in rev 1878a57aebd7) instead of apr_file_t*. Using APR for that file was a Band-Aid -- a single whacked mole -- for the problem more systemically addressed by apr_procattr_constrain_handle_set(). | |||
2012-04-23 | IQA-463: Add apr_file_open(APR_CREATE) flag for downloaded installer. | Nat Goodspeed | |
This handles the case when the target file doesn't exist, just as APR_TRUNCATE handles the case when it does. Strengthen error checks concerning downloaded installer file from ll_apr_warn_status() to ll_apr_assert_status(). Failing to recognize (e.g.) failure to open that file only leads to mysterious crashes down the road; this removes the mystery. | |||
2012-04-23 | IQA-463: Use APR file I/O for downloaded viewer installer .exe. | Nat Goodspeed | |
On Windows, calling CreateProcess(bInheritHandles=FALSE) is the wrong idea. In that case, CreateProcess() passes NO handles -- even the files you've explicitly designated as the child's stdin, stdout, stderr in the STARTUPINFO struct! Remove LLProcess code to tweak bInheritHandles; we should also remove the corresponding (useless) APR extension. Instead, given that the Windows file-locking problem we've observed is specific to the viewer installer .exe file downloaded by the background updater logic, use APR file I/O for that specific file. Empirically, both llofstream and std::ofstream seem to make the open file handle inheritable; but apr_file_open() documentation says: "By default, the returned file descriptor will not be inherited by child processes created by apr_proc_create()." And indeed, it does appear to sidestep the locking problem. | |||
2012-01-12 | fix for SH-2845, SH-2846, SH-2847, SH-2851: curl crashes and out-of-memory ↵ | Xiaohong Bao | |
crashes. | |||
2010-12-17 | Better fix for CHOP-286 - reenabled bandwidth limits on linux now that we've ↵ | brad kittenbrink | |
fixed the freeze. | |||
2010-12-17 | Temporary workaround for CHOP-286: bandwidth limits freeze the downloader ↵ | brad kittenbrink | |
thread on linux | |||
2010-12-14 | Record update version in download marker so it can be recalled if resumed in ↵ | Andrew A. de Laix | |
another viewer session. | |||
2010-12-10 | no bandwidth limit for required downloads. | Andrew A. de Laix | |
2010-12-07 | limit dowload bandwidth to 'Maximum bandwidth' setting | Andrew A. de Laix | |
2010-12-07 | push required flag into download data for later use. | Andrew A. de Laix | |
2010-12-03 | Fix for coding standard violations and build error on windows. | brad kittenbrink | |
2010-12-01 | download progress events. | Andrew A. de Laix | |
2010-11-18 | CHOP-135 Bug fixes. | Mark Palange (Mani) | |
2010-11-16 | remove downloaded file on error. | Andrew A. de Laix | |
2010-11-16 | better error checking when writing downloaded file. | Andrew A. de Laix | |
2010-11-12 | do not resume or install if current viewer version doesn't match the ↵ | Andrew A. de Laix | |
recorded version which started the process. | |||
2010-11-10 | fix resume crash. | Andrew A. de Laix | |
2010-11-09 | Shut down thread if viewer closed while downloading; fix problem of download ↵ | Andrew A. de Laix | |
marker path failing to expand correctly because it was happening too early in start up. | |||
2010-11-09 | Fix some stream bugs that were affecting windows download and validation. | Andrew A. de Laix | |
2010-11-05 | Automated merge with https://bitbucket.org/mani_linden/viewer-development/ | Andrew A. de Laix | |
2010-11-05 | implement download cancel (untested). | Andrew A. de Laix | |
2010-11-05 | Fixed build error due to unreferenced local variable. | brad kittenbrink | |
2010-11-05 | Fixed windows build error. | Mark Palange (Mani) | |
2010-11-05 | resume feature (untested). | Andrew A. de Laix | |
2010-11-04 | added hash validation of downloaded file. | Andrew A. de Laix | |
2010-11-04 | some better error handling. | Andrew A. de Laix | |
2010-11-04 | checker working with v1.0 update protocol. | Andrew A. de Laix | |
2010-11-04 | just barely working udate downloading service; missing little nicities like ↵ | Andrew A. de Laix | |
error checking and sill stuff like that. | |||
2010-11-02 | start of the downloader service. | Andrew A. de Laix | |