Age | Commit message (Collapse) | Author |
|
all floaters).
The crash was introduced by my previous fix of this ticket in changeset 8ceebd3612f0.
The problem was that, suprisingly, even invisible (faded) toasts were destroyed when you hit Ctrl_Shift+W,
however they were still referenced by the toast pool, so the references were invalidated.
The easiest fix would be to remove all references to the toast being destroyed, no matter is it visible or not.
However, then we'd have to search for each destroyed toast in the pool, which is slow.
Besides, removing toasts from the pool compromises the whole idea of pooling (which was introduced to speed up creation of new toasts).
Another possible fix is not to destroy any nearby chat toasts when user hits Ctrl+Shift+W.
That would save us from any crashes at a price of changing existing behaviour (the toasts will remain visible).
So I went for a third option: when closing all floaters, skip invisible ones.
Then there won't be attempts to destroy invisible (pooled) toasts, so the crash won't happen,
and we don't seem to change any existing behavior.
However I'm not 100% sure of the latter statement, so the fix requires extensive testing.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Profile SP even when no IM session is started with that resident.
|
|
|
|
|
|
|
|
|
|
also popup notification is no longer a singleton
|
|
|
|
|
|
inventory context menu for incomplete outfits.
|
|
|
|
Bug reason: The fix of EXT-1419 disables showing nearby chat showing toasts at all whenever you close one.
That was done to prevent a crash when viewer is exiting, but closing a toast manually should be handled differently.
Fix: If a toast is being closed (destroyed) manually, just remove it from the toast pool
(to prevent further references to the invalid pointer), but keep on showing new toasts.
I've overriden LLFloater::onClose() to differentiate the two cases.
|
|
trusted content is now a const attribute of LLMediaCtrl, set in constructor params
|
|
Reviewed by Callum
|
|
- Moved the "no session" string to XML and used it in code instead of hardcode.
- Conference string turned out to be already translated, but the way translation was happening ad-hoc chat log files on disk
would get localized names, and thus be inconsistent (and that would create problems with browsing them later).
It didn't happen already just because this string wasn't translated in other locales somewhy.
So moved localization of session name after the the creation of log file.
Also changed value of string according to Eli's comment in ticket.
|
|
|
|
|
|
|
|
A little bit more clean up on LLPanelVoiceDeviceSettings while I'm in there.
|
|
|
|
|
|
|
|
|
|
always trigger popup notification and rely on ignore machinery to hide it
|
|
|
|
|
|
|
|
|
|
triggered by user taking an object from inworld into inventory
|
|
just llfloatermediabrowser
|
|
UI hint is open
|
|
|
|
|
|
|
|
|
|
|
|
|
|
button resizing to get more space for other buttons.
|
|
button label truncation.
Removed commented out button and extra layout stack from panel_group_info_sidetray.xml
Resized buttons to use remaining free space when Create Group button is invisible.
|
|
Removed unused code and xml data which were once used for date in status bar.
|
|
|
|
|
|
wearable gets worn.
The fix consists of two parts:
1. Saving/restoring scrollbar position when refreshing the clothing/attachments/bodyparts lists
(the lists get refreshed on COF change).
2. Not resetting expanded accordion tab upon wearing an item (which was introduced with the fix of EXT-8164).
So, apart from preserving scrollbar position (which is what the bug reporter requests),
I also fixed that when you wear something, the Clothing accordion was always expanded.
|