summaryrefslogtreecommitdiff
path: root/indra/newview
AgeCommit message (Collapse)Author
2016-09-16MAINT-5232: Fix a couple new LLGlobalEconomy::Singleton references.Nat Goodspeed
2016-09-16Automated merge with ssh://bitbucket.org/lindenlab/viewer-releaseNat Goodspeed
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2016-09-15increment viewer version to 4.0.9Oz Linden
2016-09-07MAINT-6699 FIXED [VOB] Crash in LLSnapshotLivePreview::getBigThumbnailImage()Mnikolenko Productengine
2016-09-06MAINT-6698 [VOB] "Save" button is always enabled for outfit with non-default ↵Mnikolenko Productengine
image even if there were no changes
2016-09-05MAINT-6685 [VOB] Outfit Image from an Outfit Gallery disappears after ↵Mnikolenko Productengine
editing outfit
2016-09-02MAINT-6461 crash due to invalid menu pointer during visibility changeandreykproductengine
2016-09-01MAINT-6686 FIXED [VOB] Outfit Snapshot floater should be resized ↵Mnikolenko Productengine
independently of general Snapshot floater
2016-08-31MAINT-6386 Update first-time Viewer Login screen with new LISI screenshotsAndreyL ProductEngine
2016-08-31MAINT-5232: Add LLSingletonBase::cleanupAll() and deleteAll() callsNat Goodspeed
near the end of LLAppViewer::cleanup() so every LLSingleton class that hasn't already been explicitly cleaned up gets a chance to perform its own cleanup.
2016-08-31MAINT-5232: LLMetricPerformanceTesterBasic::cleanClass->cleanupClassNat Goodspeed
for consistency with everything else, so we can use SUBSYSTEM_CLEANUP() macro to call it.
2016-08-30MAINT-5232: LLGlobalEconomy is now an LLSingleton.Nat Goodspeed
It used to contain an LLSingleton called Singleton, requiring LLGlobalEconomy::Singleton::instance() to access it rather than the conventional LLGlobalEconomy::instance(). This has been fixed, so normalize references accordingly.
2016-08-30MAINT-5232: Change getIfExists() call to instanceExists().Nat Goodspeed
LLSingleton::getIfExists() has been eliminated. The only remaining way to detect whether a given LLSingleton has been instantiated is to call instanceExists(). But the relevant cleanup code should be refactored to cleanupSingleton() anyway, which would make this specific call moot.
2016-08-30MAINT-5232: Remove unreferenced mInFlightCounter.Nat Goodspeed
This fixes fatal warnings.
2016-08-30Automated merge with ssh://bitbucket.org/lindenlab/viewer-releaseNat Goodspeed
2016-08-23MAINT-6616 new crash in VOB viewer in snapshot previewMnikolenko Productengine
2016-08-16Merge VOB with 4.0.8-releasepavelkproductengine
2016-08-11increment viewer version to 4.0.8Oz Linden
2016-08-10MAINT-6616 new crash in VOB viewer in snapshot previewMnikolenko Productengine
2016-08-04MAINT-6604 FIXED [VOB] Snapshot preview is corruptedMnikolenko Productengine
2016-08-01MAINT-6460 getMeshSize crashandreykproductengine
2016-08-01MAINT-6460 Crash calculating mesh complexityandreykproductengine
2016-08-01Backed out changeset: c21a7e6d9796andreykproductengine
2016-08-01MAINT-6602 disable ability to select local texturesMnikolenko Productengine
2016-07-29MAINT-6601 FIXED [VOB] Texture picker generates WARNING spam in SecondLife.logMnikolenko Productengine
2016-07-26MAINT-6476 VOB - User can add any size image to an Outfit Gallery outfit folderspavelkproductengine
Added restriction of image size that can be added to outfit via "Select Photo"
2016-07-25MAINT-6460 Crash calculating mesh complexityandreykproductengine
2016-07-19MAINT-6583 FIXED [VOB] Snapshot floater is stuck in "Posting" state.pavelkproductengine
Removed wrong callback set from VOB snapshot floater
2016-07-19MAINT-6582 [VOB] Snapshot is not sentMnikolenko Productengine
2016-07-18MAINT-6476 VOB - User can add any size image to an Outfit Gallery outfit folderspavelkproductengine
Added restriction of image size that can be added to outfit
2016-07-14merge changes for STORM-2133Oz Linden
2016-07-14MAINT-6460 Crash calculating mesh complexityandreykproductengine
2016-07-14STORM-2133: VOICE-36 prevents proper shutdown of connectorAnsariel
2016-07-12MAINT-6460 Crash calculating mesh complexityandreykproductengine
2016-07-12MergeRider Linden
2016-07-12STORM-2132: Remove obsoleted unique_ptr.hpp, use make_shared for pointer ↵Rider Linden
allocation.
2016-07-11MAINT-6565: Grab a shared pointer and encapsulate it into the bind call in ↵Rider Linden
place of this. Ensures that the impl is not deleted while the coroutine is active.
2016-07-11MAINT-6534 Resetting scripts via the build menu no longer works on many ↵andreykproductengine
scripted objects
2016-07-08Merged in lindenlab/viewer-releasepavelkproductengine
2016-07-08MAINT-6448 PERMISSION_DEBIT notification should default to Denyandreykproductengine
2016-07-08MAINT-6534 Fixed the LLSD validation failureAndreyL ProductEngine
2016-07-07MAINT-6476 FIXED VOB - User can add any size image to an Outfit Gallery ↵pavelkproductengine
outfit folders Eliminated overuse of texture memory
2016-07-07Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2016-07-06increment viewer version to 4.0.7Oz Linden
2016-06-10MAINT-6475 Add menu item for changing sort priorityMnikolenko Productengine
2016-06-09MAINT-6472 Show outfit tooltips in Outfit Gallery. Increase space between ↵Mnikolenko Productengine
image and outfit name.
2016-06-08MAINT-6473 Request for Drag & Drop functionality for adding images to Outfit ↵Mnikolenko Productengine
Folders
2016-06-06MAINT-6465 FIXED Snapshop "file size" is split apart and looks badpavelkproductengine
2016-06-06MAINT-6474 FIXED No easy way to remove an image from a VOB FolderMnikolenko Productengine
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-23 21:02:54 +0000