Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
has_offline_msg value.
Set UnreadIMs icon to visible if messages were sent while offline.
|
|
In a number of different places, for different reasons, the viewer wants to
load a UI-related file that might be overridden by a non-default skin; and
within that skin, might further be overridden by a non-default language.
Apparently, for each of those use cases, every individual developer approached
it as an entirely new problem, solving it idiosyncratically for that one case.
Not only is this a maintenance problem, but it rubs one's nose in the fact
that most such solutions consider only a subset of the relevant skin
directories.
Richard and I evolved an API intended to address all such cases: a central
LLDir method returning a list of relevant pathnames, from most general to most
localized, filtered to present only existing files; plus a couple of
convenience methods to specifically obtain the most general and most localized
available file.
There were several load-skinned-file methods (LLFloater::buildFromFile(),
LLPanel::buildFromFile() and LLUICtrlFactory::createFromFile() -- apparently
cloned-and-modified from each other) that contained funky bolted-on logic to
output the loaded data to an optional passed LLXMLNodePtr param. The trouble
is that passing that param forced each of these methods to subvert its normal
search: specifically for that case, it needed to find the baseline XML file
instead of the localized one. Richard agreed that for the intended usage
(reformatting XML files) we should use XML schema instead, and that the hacky
functionality should be removed. Remove it. Also remove
LLUICtrlFactory::getLocalizedXMLNode(), only used for those three special cases.
Some callers explicitly passed the optional LLXMLNodePtr param as NULL. Remove
that.
Remove LLFloaterUIPreview::displayFloater(save) param, which relied on the
optional output LLXMLNodePtr param. Make onClickSaveFloater() and
onClickSaveAll() emit popupAndPrintWarning() about discontinued functionality.
Recast LLFloater::buildFromFile(), LLPanel::buildFromFile(),
LLUICtrlFactory::createFromFile(), LLNotifications::loadTemplates(),
LLUI::locateSkin(), LLFontRegistry::parseFontInfo(),
LLUIColorTable::loadFromSettings(), LLUICtrlFactory::loadWidgetTemplate(),
LLUICtrlFactory::getLayeredXMLNode(), LLUIImageList::initFromFile(),
LLAppViewer::launchUpdater() and LLMediaCtrl::navigateToLocalPage() to use
findSkinnedFilenames(). (Is LLAppViewer::launchUpdater() ever called any more?
Apparently so -- though the linux-updater.bin logic to process the relevant
command-line switch has been disabled. Shrug.) (Is
LLMediaCtrl::navigateToLocalPage() ever used?? If so, why?)
Remove LLUI::setupPaths(), getXUIPaths(), getSkinPath() and
getLocalizedSkinPath(). Remove the skins/paths.xml file read by setupPaths().
The only configuration it contained was the pair of partial paths "xui/en" and
"xui/[LANGUAGE]" -- hardly likely to change. getSkinPath() specifically
returned the first of these, while getLocalizedSkinPath() specifically
returned the second. This knowledge is now embedded in findSkinnedFilenames().
Also remove paths.xml from viewer_manifest.py.
Remove injected xui_paths from LLFontGL::initClass() and
LLFontRegistry::LLFontRegistry(). These are no longer needed since
LLFontRegistry can now directly consult LLDir for its path search. Stop
passing LLUI::getXUIPaths() to LLFontGL::initClass() in LLViewerWindow's
constructor and initFonts() method.
Add LLDir::append() and add() methods for the simple task of combining two
path components separated by getDirDelimiter() -- but only if they're both
non-empty. Amazing how often that logic is replicated. Replace some existing
concatenations with add() or append().
New LLDir::findSkinnedFilenames() method must know current language. Allow
injecting current language by adding an LLDir::setSkinFolder(language) param,
and pass it where LLAppViewer::init() and initConfiguration() currently call
setSkinFolder(). Also add LLDir::getSkinFolder() and getLanguage() methods.
Change LLFLoaterUIPreview's LLLocalizationResetForcer helper to "forcibly
reset language" using LLDir::setSkinFolder() instead of LLUI::setupPaths().
Update LLDir stubs in lldir_stub.cpp and llupdaterservice_test.cpp.
Add LLDir::getUserDefaultSkinDir() to obtain often-overlooked possible skin
directory -- like getUserSkinDir() but with "default" in place of the current
skin name as the last path component. (However, we hope findSkinnedFilenames()
obviates most explicit use of such individual skin directory pathnames.)
Add LLDir unit tests for new findSkinnedFilenames() and add() methods -- the
latter exercises append() as well.
Tweak indra/integration_tests/llui_libtest/llui_libtest.cpp for all the above.
Notably, comment out its export_test_floaters() function, since the essential
LLFloater::buildFromFile(optional LLXMLNodePtr) functionality has been
removed. This may mean that llui_libtest.cpp has little remaining value, not
sure.
|
|
phase 2, removal of extraneous signaling in favor of llnotificationchannels
made notificationchannels work better with overrides and lifetime managed
by creator
|
|
phase 1, removal of most of llnotificationhandler
|
|
crash on exit.
The crash happened if connection timed out while there were unread object inventory offers.
|
|
when deleting notifications one by one)
- Changed LLSysWellWindow::reshapeWindow() so that the floater decreases from bottom to top, without changing top coordinate.
- Force dock control repositioning in case floater rect changed.
|
|
- Floaters dock to chiclets at the bottom.
- Floaters docking region limited to non-toolbar view.
- Chiclet bar is positioned between the right toolbar and the minimized floaters stacked at the top left corner by default.
|
|
method that was used for opening IM window
- Replaced setRect method with setShape so that reshape and translate method be called
|
|
|
|
/Users/Aimee/Documents/Work/Linden-Lab/Development/viewer/convert/viewer-identity-evolution
|
|
|
|
|
|
|
|
streamlined LLUICtrlFactory's interface
|
|
removed redundant functionality
moved buildPanel to LLPanel
|
|
|
|
|
|
|
|
|
|
|
|
|
|
floater.
Details:
1 Avoided memory leak in LLScriptFloaterManager caused not destroying processed notifications.
2 Provided destroying notification if user initiate closing script floater and not destroying if viewer exit.
reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/721/
--HG--
branch : product-engine
|
|
|
|
LLIMWellWindow::findIMChiclet().
Bug reason: LLChicletPanel::onCurrentVoiceChannelChanged() was called at startup, which, in turn, called LLIMWellWindow::findIMChiclet().
Apparently, LLIMWellWindow::mMessageList was not initialized yet, so dereferencing the null pointer caused the crash.
I couldn't reproduce the crash so I've just added defensive checks (just for any case)
and moved binding LLIMWellWindow::findIMChiclet() to sFindChicletsSignal from the constructor to postBuild().
Reviewed by Alexei Arabadji at https://codereview.productengine.com/secondlife/r/692/
--HG--
branch : product-engine
|
|
Fixed to use Display Name (Username), fixed icon placement,
also fixed notifications system well names. Reviewed with Leyla.
|
|
Corrected functionality that determines is syswell window is empty;
Removed obsolete functionality related to separator of syswell window items;
reviewed by Loren Shih at https://codereview.productengine.com/secondlife/r/349/
--HG--
branch : product-engine
|
|
conversation starts.) - disabled auto-resizing of well window if it was reshaped by user.
--HG--
branch : product-engine
|
|
conversation starts.)
--HG--
branch : product-engine
|
|
does not focus the floater.
Implemented same fix for Script Floaters
--HG--
branch : product-engine
|
|
not focus the floater.
--HG--
branch : product-engine
|
|
discarded when offered objects got the same name.
Had to do minor refactoring of LLScripFloaterManager in order to fix this issue.
--HG--
branch : product-engine
|
|
made notification that restored from notification well window shows as inspector;
--HG--
branch : product-engine
|
|
from the Well.
--HG--
branch : product-engine
|
|
click was performed over avatar's image but not over avatar's name)
- redirected processing of right mouse down event to an appropriate chiclet.
--HG--
branch : product-engine
|
|
favor of a proper fix.
--HG--
branch : product-engine
|
|
when there's nothing to see
Note:
It was decided to handle an enabling of buttons from syswellwindow according to his empty state
--HG--
branch : product-engine
|
|
made LLIMWellWindow and LLNotificationWellWindow as dockable transient
floaters;
--HG--
branch : product-engine
|
|
window is opened.
--HG--
branch : product-engine
|
|
chiclets for avaline calls are not spawned anymore
--HG--
branch : product-engine
|
|
- manually set rect for a chiclet in the IM Well Window
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
sessions in the IM well window
- IM Well Window's chiclets now have counters and count IMs from 1 to "99+"
- IM Well Window's items can resize on appearance of chiclet's counter or speaker indicator
--HG--
branch : product-engine
|
|
--HG--
branch : product-engine
|
|
ad-hoc, group)
correct chiclet handling functionality in IM when im session is started as voice call
--HG--
branch : product-engine
|