summaryrefslogtreecommitdiff
path: root/indra/newview/llscenemonitor.cpp
AgeCommit message (Collapse)Author
2020-03-25DRTVWR-494: Defend LLInstanceTracker against multi-thread usage.Nat Goodspeed
The previous implementation went to some effort to crash if anyone attempted to create or destroy an LLInstanceTracker subclass instance during traversal. That restriction is manageable within a single thread, but becomes unworkable if it's possible that a given subclass might be used on more than one thread. Remove LLInstanceTracker::instance_iter, beginInstances(), endInstances(), also key_iter, beginKeys() and endKeys(). Instead, introduce key_snapshot() and instance_snapshot(), the only means of iterating over LLInstanceTracker instances. (These are intended to resemble functions, but in fact the current implementation simply presents the classes.) Iterating over a captured snapshot defends against container modifications during traversal. The term 'snapshot' reminds the coder that a new instance created during traversal will not be considered. To defend against instance deletion during traversal, a snapshot stores std::weak_ptrs which it lazily dereferences, skipping on the fly any that have expired. Dereferencing instance_snapshot::iterator gets you a reference rather than a pointer. Because some use cases want to delete all existing instances, add an instance_snapshot::deleteAll() method that extracts the pointer. Those cases used to require explicitly copying instance pointers into a separate container; instance_snapshot() now takes care of that. It remains the caller's responsibility to ensure that all instances of that LLInstanceTracker subclass were allocated on the heap. Replace unkeyed static LLInstanceTracker::getInstance(T*) -- which returned nullptr if that instance had been destroyed -- with new getWeak() method returning std::weak_ptr<T>. Caller must detect expiration of that weak_ptr. Adjust tests accordingly. Use of std::weak_ptr to detect expired instances requires engaging std::shared_ptr in the constructor. We now store shared_ptrs in the static containers (std::map for keyed, std::set for unkeyed). Make LLInstanceTrackerBase a template parameterized on the type of the static data it manages. For that reason, hoist static data class declarations out of the class definitions to an LLInstanceTrackerStuff namespace. Remove the static atomic sIterationNestDepth and its methods incrementDepth(), decrementDepth() and getDepth(), since they were used only to forbid creation and destruction during traversal. Add a std::mutex to static data. Introduce an internal LockStatic class that locks the mutex while providing a pointer to static data, making that the only way to access the static data. The LLINSTANCETRACKER_DTOR_NOEXCEPT macro goes away because we no longer expect ~LLInstanceTracker() to throw an exception in test programs. That affects LLTrace::StatBase as well as LLInstanceTracker itself. Adapt consumers to the new LLInstanceTracker API.
2017-08-30MAINT-7758 Fixed freeze on loading lsl scripts from unicode named windows ↵andreykproductengine
folder.
2015-02-05MAINT-4857 FIXED Reset scene monitor after completing teleport.Mnikolenko ProductEngine
2014-07-23MAINT-4283 FIXED [BEAR] Viewer always crashes when opening "Scene Loading ↵andreykproductengine
Monitor" if you closed it previously with the X
2014-07-04MAINT-4155 FIXED Scene Loading Monitor does not open from menuandreykproductengine
2013-11-21fix for SH-4628: Project Interesting Viewer reduces & fixes graphics to ↵Xiaohong Bao
lowest settings on a MAC
2013-11-13moved SceneLoadingMonitor settings vars (and renamed ↵Richard Linden
SceneLoadingPixelDiffThreshold to SceneLoadingMonitorPixelDiffThreshold) tweaked layout of floater_model_preview.xml
2013-11-12BUILDFIX - miscellaneous stuff missed in the mergeRichard Linden
2013-10-15renamed TimeBlock to BlockTimerStatHandleRichard Linden
2013-10-08merge from viewer-releaseRichard Linden
2013-10-07renamed TraceType to StatTypeRichard Linden
added more MemTrackable types optimized memory usage of LLTrace some more
2013-10-01BUILDFIX: old style fast timer use, broken unit testRichard Linden
2013-09-05changed fast timer over to using macroRichard Linden
another attempt to move mem stat into base class
2013-08-29SH-4377 FIX: Interesting: Windows viewer crashes when ↵Richard Linden
SceneLoadingMonitorEnabled is enabled
2013-08-27SH-4453 FIX: Interesting: SceneLoadingMonitorEnabled does not work until the ↵Richard Linden
camera turns set enabled flag before calling freeze scene
2013-08-26removed some unecessary template parameters from LLUnit member functionsRichard Linden
forced unit conversion code to inline unit conversion now no longer converts all the way to base and back, but tries to find equivalent units as early as possible fixed another llinfos instance scene monitor now outputs n/a for invalid samples
2013-08-18SH-4433 WIP: Interesting: Statistics > Ping Sim is always 0 msRichard Linden
continued conversion to units system made units perform type promotion correctly and preserve type in arithmetic e.g. can now do LLVector3 in units added typedefs for remaining common unit types, including implicits
2013-08-15moved unit types out of LLUnits namespace, since they are prefixedRichard Linden
2013-08-14BUILDFIX: added header for numeric_limits support on gccRichard Linden
added convenience types for units F32Seconds, etc.
2013-07-31Automated merge with http://bitbucket.org/lindenlab/viewer-interestingXiaohong Bao
2013-07-31fix for SH-4290: Running viewer with SceneLoadingMonitorEnabled causes ↵Xiaohong Bao
viewer to be unresponsive on login on low end machine
2013-07-31cleanup - renamed valueAs to valueInUnits and made it a symmetrical ↵Richard Linden
getter/setter
2013-07-20removed debug spamRichard Linden
fast timer data now resets on login
2013-07-19BUILDFIX: #include and dependency cleanupRichard Linden
2013-07-17SH-4299 WIP: Interesting: High fps shown temporarily off scale in statistics ↵Richard Linden
console made unit types work with ostreams fixed timing of scene monitor recordings to better respect requested time diff
2013-07-15SH-4299 FIX: Interesting: High fps shown temporarily off scale in statistics ↵Richard Linden
console timing of scene load recording extension now guaranteed > requested time step removed double add of recorded data removed spam
2013-07-15SH-4299Interesting: High fps shown temporarily off scale in statistics consoleRichard Linden
various fixes to lltrace start() on started recording no longer resets fixed various instances of unit forgetfullness in lltrace recording split now has gapless timing scene monitor now guarantees min sample time renamed a bunch of stats added names to debug thread view on windows
2013-06-28SH-4299 FIX Interesting: High fps shown temporarily off scale in statistics ↵Richard Linden
console added ability to force uniqueness of LLCopyOnWritePointer converted more variables to units added convenience function for unit constants
2013-06-22fixed scene load monitor resetting to eagerly due to spurious camer amotionRichard Linden
pulled swap() out of ui time block cleaned up internal lltrace dependencies, factored out common accumulator definitions
2013-06-19SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
scene monitor output is cleaned up, no duplicate first frame, less scientific notation periodic recording extension now works more cleanly
2013-06-17SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
added getAs and setAs to LLUnit to make it clearer how you specify units removed accidental 0-based indexing of periodicRecording history... should now be consistently 1-based, with 0 accessing current active recording removed per frame timer updates of all historical timer bars in fast timer display added missing assignment operator to recordings
2013-06-13SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
changed Units macros and argument order to make it more clear optimized units for integer types fixed merging of periodicrecordings...should eliminate duplicate entries in sceneloadmonitor history
2013-06-04SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
fixed mem stat tracking...now properly tracks memory footprint with floating point precision cleaned up macros for unit declaration renamed units to SI standard for 1024 multiples (kibibytes, etc) fixed units output for scene monitor dump
2013-06-04BUILDFIX: don't multiple define class statics...use inline static method insteadRichard Linden
2013-06-04SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
added labels to LLUnit types added memstat dumps to llscenemonitor
2013-06-02SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
removed unnecessary templates from accumulator types...now always track data in double precision floating point, using templated accessors to convert to and from arbitrary types
2013-05-31SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
made recordings auto-update when executing query while active
2013-05-31SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
fixed multithreading lltrace causing values to be interpolated towards 0 added Radians unit improved sceneloadmonitor restart heuristic to use accumulated camera motion
2013-05-29Automated merge with ssh://hg.lindenlab.com/richard/viewer-interesting/Richard Linden
2013-05-29SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
fixed copy construction behavior of Recordings to not zero out data split measurement into event and sample, with sample representing a continuous function
2013-05-23Automated merge with ssh://hg.lindenlab.com/richard/viewer-interestingXiaohong Bao
2013-05-23for SH-4145: Interesting: Implement occlusion culling for object cacheXiaohong Bao
2013-05-22SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
clean up of llscenemonitor.cpp
2013-05-20SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
removed extra dereference for copy on write pointer moved copyonwrite mechanism to RecordingBuffers from individual buffer fixed logic that was leaving scene unfrozen when camera moved during metrics gathering
2013-05-20SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
further improvements that should eliminate more short duration recording periods
2013-05-20SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
fixed copy construction of Recorders, eliminated most zero-length frames fixed reset behavior of periodic recordings and extendable recordings to clear entire history removed busy-loop recording of stats from worker threads...stats reported only when work is done
2013-05-16SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
renamed LLView::handleVisibilityChange to onVisibilityChange to reflect cleaned up scene monitor stats recording, now all trace stats dumped to csv also fixed extendablerecording, periodicrecording, etc. to properly implement start/stop/etc
2013-05-13SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
improved precision of scene diff log output
2013-05-13SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
added log output for scene monitoring
2013-05-10BUILDFIX - bad logic in scene monitor frame recordingRichard Linden