summaryrefslogtreecommitdiff
path: root/indra/newview/llpresetsmanager.h
AgeCommit message (Collapse)Author
2019-03-12Backout tabs v spaces changes.Graham Linden
'warn-on-failure:no-tabs'
2019-03-11Tabs -> spaces.Graham Linden
2018-01-12STORM-2145 Merge up to viewer-releaseJonathan Yap
2017-03-03STORM-2145 Attempt to fix Mac build failureJonathan Yap
2017-02-23STORM-2145 Camera Presets -- some initial workJonathan Yap
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2016-05-27MAINT-6435 Deafult preset should set the same settings as the "Reset to ↵AndreyL ProductEngine
recommended settings" button
2016-02-19FIXED Graphics presets do not work properly when localized "Default" stringAnsariel
2015-09-28MAINT-5542: fix initialization of Default graphics preset so that it is ↵Oz Linden
selectable
2015-01-20STORM-2082 Still trying to work out the dirtyChilds issue. Also made some ↵Jonathan Yap
small UI adjustments.
2015-01-20STORM-2082 Update to new UI design. Bugs are not worked out yet.Jonathan Yap
2015-01-14STORM-2082 Assorted UI tweaks, better MaximumARC formula, pulldowns ↵Jonathan Yap
disappear faster
2014-12-12STORM-2082 Merge Hardware floater into main graphics preferences displayJonathan Yap
Change notifications so they are emitted only when an error occurs Put active preset at top of list Add Maximum ARC slider Merge two small methods into slider update code
2014-12-09STORM-2082 Improve file error handling, add help topic labels to new floaters.Jonathan Yap
2014-12-04STORM-2082 Revert name of Reset button from Undo back to Reset. Hopefully ↵Jonathan Yap
this will be renamed Recommended Settings. Display a test icon (artwork needed) in the pulldown panel
2014-12-01STORM-2082 Better control on how (or if) to display Default presetJonathan Yap
Make sure default preset is created when flyout panel is activated Only display deleted notification upon successful deletion
2014-12-01STORM-2082 Fix linux compile errorJonathan Yap
2014-12-01STORM-2082 Implement save floater and some code cleanup.Jonathan Yap
2014-11-30STORM-2082 Make code more generic to handle the future camera presets.Jonathan Yap
2014-11-30STORM-2082 Implement delete floaterJonathan Yap
2014-11-28STORM-2082 Initial support for presets popup from status barJonathan Yap
2014-11-27STORM-2082 Get writing out and loading presets workingJonathan Yap
2014-11-26STORM-2082 Code now fills comboboxJonathan Yap
2014-11-26STORM-2082 Start to convert code to support xml file processingJonathan Yap