summaryrefslogtreecommitdiff
path: root/indra/newview/llpaneleditwearable.cpp
AgeCommit message (Collapse)Author
2016-09-15MAINT-5232: Normalize LLSingleton subclasses.Nat Goodspeed
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
2015-11-10remove execute permission from many files that should not have itOz Linden
2015-06-05MAINT-5186 FIXED (Avatar textures do not load in the Appearance editor after ↵vyacheslavsproductengine
disabling an Alpha mask)
2015-03-05SL-103 WIP - viewer enforces wearable limits based on total articles of ↵Brad Payne (Vir Linden)
clothing rather than per-type limit. Limit is artificially low for testing, will bump before release.
2014-06-18Merge downstream codesimon
2014-05-14v-r -> s-e merge WIPBrad Payne (Vir Linden)
2014-05-13sunshine-external merge WIPBrad Payne (Vir Linden)
2014-05-07Merge downstream version 3.7.8 codesimon
2014-03-21MAINT-3842 FIXED Using "Close Window" (Ctrl + W) shortcut while in ↵andreylproductengine
Appearance mode doesn't visually revert any changes...
2014-03-20MAINT-1190 FIXED Update visual param list when changing sex.Mnikolenko ProductEngine
2014-03-12mergeBrad Payne (Vir Linden)
2014-03-12merge with releaseRichard Linden
2014-02-05MAINT-3555 crash in LLPanel::~LLPanel() on shutdown:maksymsproductengine
- memory leaks fixing;
2014-02-05MAINT-3555 crash in LLPanel::~LLPanel() on shutdown:maksymsproductengine
- memory leaks fixing;
2013-09-26SH-3455 WIPBrad Payne (Vir Linden)
2013-09-19SH-3455 WIP - removing bake upload codeBrad Payne (Vir Linden)
2013-09-19SH-3455 WIP - removing bake upload codeBrad Payne (Vir Linden)
2013-08-14SH-4422 FIX - fixed some recently introduced issues with link description ↵Brad Payne (Vir Linden)
fields, which among other things reduces the number of appearance requests sent.
2013-08-09second phase summer cleaningRichard Linden
replace llinfos, lldebugs, etc with new LL_INFOS(), LL_DEBUGS(), etc.
2013-08-09Refactoring link creation calls in preparation for adding AIS v3 hook.Don Kjer
2013-07-30Summer cleaning - removed a lot of llcommon dependencies to speed up build timesRichard Linden
consolidated most indra-specific constants in llcommon under indra_constants.h fixed issues with operations on mixed unit types (implicit and explicit) made LL_INFOS() style macros variadic in order to subsume other logging methods such as ll_infos added optional tag output to error recorders
2013-07-19SH-3889 WIP - added callbacks to control ordering of operations after ↵Brad Payne (Vir Linden)
wearable save.
2013-06-05merge with viewer-releaseRichard Linden
2013-05-05Spring cleaning: removed unused .cpp and.h files, and cleaned up header ↵Richard Linden
dependencies
2013-04-24SH-4128 WIP - misc cleanupBrad Payne (Vir Linden)
2013-04-24SH-4128 WIP - cleanup around item link removal and callbacksBrad Payne (Vir Linden)
2013-04-19merge changes for DRTVWR-294Oz Linden
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2013-03-11mergeprep
2013-03-04Removed deprecated calls to incrementCofVersionprep
2013-02-27Automated merge with https://bitbucket.org/lindenlab/sunshine-internalRichard Linden
2013-01-24merging in viewer-beta.Nyx Linden
Most of the merge was clean, a couple conflicts. Brought over a couple patches manually for llpolymesh.
2013-01-16SH-3645 WIP - preserve item order after wearable save asBrad Payne (Vir Linden)
2013-01-15SH-3339 WIP, SH-3645 WIP - added getActualDescription to obviate an ↵Brad Payne (Vir Linden)
obnoxious and widely-used workaround, re-create COF link after wearable edit to force COF version bump
2013-01-09SH-3620: Fix for editing a nocopy wearable being removed from the outfitprep
2012-12-13Merged SH-3339 work with sunshine-internal. Still a WIP.Logan Dethrow
2012-12-13WIP SH-3339. Commit to merge from trunk to get build fixes, etc.Logan Dethrow
2012-12-13Fix for SH-3591.prep@lindenlab.com
2012-12-12Fixes for SH-3591 & SH-3620prep
2012-12-04Pull and merge viewer-developmentsimon@Simon-PC.lindenlab.com
2012-11-28SH-3563. Pull and merge from viewer-development. Modest code changes to fix ↵prep
alignment issue in llAppearance.
2012-11-19Removed a few unnecessary include lines.Logan Dethrow
2012-11-19Moved implementation of incrementCofVersion to llappearancemgr.cpp. Changed ↵Logan Dethrow
retry logic to use the more robust mRetryPolicy instead of my own previous implementation.
2012-11-19WIP SH-3339 Only try to increment the cof version if in a server bake region.Logan Dethrow
2012-11-16WIP First buildable code after adding support for SH-3339.Logan Dethrow
2012-11-15WIP Working on adding http request to increment the COF version when a ↵Logan Dethrow
change is made to an item in an agent's current outfit folder. SH-3339
2012-10-11Updating linux build to gcc4.6Don Kjer
2012-09-10MAINT-826 FIXED Show the first subpart by defaultmaxim_productengine
2012-09-06Extracted mWearableDatas from LLAgentWearables into ↵Don Kjer
llappearance/LLWearableData. Moved LLDriverParam into llappearance
2012-09-03Merge VirLinden/sunshine -> don_linden/sunshine-experimentalDon Kjer