Age | Commit message (Collapse) | Author |
|
LF, and trim trailing whitespaces as needed
|
|
|
|
1. Do not process all marketpalce changes at once, schedule them for later
2. Do not notifyObservers from notifyObservers
|
|
|
|
|
|
A shocking number of LLSingleton subclasses had public constructors -- and in
several instances, were being explicitly instantiated independently of the
LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
machinery. It seems only fair that if you say you want an LLSingleton, there
should only be ONE INSTANCE!
Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
friend class LLSingleton<whatevah>;
and explicitly declare a private nullary constructor.
To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
suspect, defined by the macro. If you declare an LLSingleton subclass without
using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
implementation -- which will hopefully remind the coder.
Trawl through ALL LLSingleton subclass definitions, sprinkling in
LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
constructor declarations, public or private, along with relevant 'friend class
LLSingleton<myself>' declarations. Where destructors are declared, move them
into private section as well. Where the constructor was inline but nontrivial,
move out of class body.
Fix several LLSingleton abuses revealed by making ctors/dtors private:
LLGlobalEconomy was both an LLSingleton and the base class for
LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
contained another instance of the LLGlobalEconomy "singleton.") Extract
LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.
LLToolGrab, an LLSingleton, was also explicitly instantiated by
LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
with trivial subclass LLToolGrab, the LLSingleton instance.
(WARNING: LLToolGrabBase methods have an unnerving tendency to go after
LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
between the instance in LLToolCompGun and the LLToolGrab singleton instance.)
LLGridManager declared a variant constructor accepting (const std::string&),
with the comment:
// initialize with an explicity grid file for testing.
As there is no evidence of this being called from anywhere, delete it.
LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
parameter wasn't used, and as there is no evidence of it being passed from
anywhere, delete the parameter.
LLViewerWindow::shutdownViews() was checking LLNavigationBar::
instanceExists(), then deleting its getInstance() pointer -- leaving a
dangling LLSingleton instance pointer, a land mine if any subsequent code
should attempt to reference it. Use deleteSingleton() instead.
~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
Use deleteSingleton() instead.
|
|
|
|
|
|
|
|
MAINT-4952: Coverted VMM to coroutines
|
|
some functions avoiding depth computation when we could, fixed cut case
|
|
to listing folder to improve performance
|
|
Update count on hand in reassociate correctly.
|
|
data and inventory data are being fetched
|
|
error occured on SLM
|
|
confirmation from the server
|
|
|
|
|
|
prevent multiple folder update when receiving data from SLM
|
|
count changes (activate, drag/drop, associate, etc...)
|
|
notification if state is deleted
|
|
503. Show SLM always.
|
|
|
|
state to the UI, showing only the relevant UI to the user (i.e. Merchant Outbox or Marketplace Listings).
|
|
/listing route so to get the updated SLM status for the listing
|
|
Updating status on source and destination working.
|
|
|
|
|
|
|
|
active. Finer granularity of DAMA for all drop and cut and paste cases.
|
|
current SLM issues, it works on version folders, active or not.
|
|
API coverage. Will be used only in test.
|
|
/listing/:listing_id route. Avoid recursive calls in deleteListing()
|
|
|
|
better isolate calls leading to HTTP requests
|
|
account and rewrite getListingURL()
|
|
|
|
readable and cleared old debug code
|
|
marketplace data code a bit as a result
|
|
commented out though as too risky and ugly)
|
|
This observe other changes as well of interest to marketplace and should improve consistency in general
|
|
|
|
|
|
remnants in Marketplace
|
|
glitch in UI (needs to reopen the floater to see content)
|
|
integer when using the associate UI.
|
|
|
|
to get a listing URL
|
|
version folders. Also create test SLM ID when creating listing.
|
|
Listing to Edit Listing.
|