summaryrefslogtreecommitdiff
path: root/indra/newview/llmanipscale.cpp
AgeCommit message (Collapse)Author
2014-09-23MAINT-4481 FIX [viewer-lion] Linux build fails due array-bounds issue in ↵Richard Linden
llmanipscale.cpp This was an out of bounds array access on a code path not normally accessed To test, set debug setting ScaleShowAxes to true, go into build mode, and hold down Ctrl+Shift to scale an object There should be colored bars along the scale axes, limited to the bounds of the object's extents
2014-09-18MAINT-4433 FIXED Don't start changing scale on first click.Mnikolenko ProductEngine
2014-07-07Merge viewer-release and become version 3.7.12simon
2014-06-05MergeRicky Curtice
2014-05-07Merge downstream version 3.7.8 codesimon
2014-05-07Pull and merge viewer-release as version 3.7.8simon
2014-05-07merge changes for 3.7.7-releaseOz Linden
2014-03-04STORM-1920 / STORM-2013: Fixed uniform scaling highlighting at half values.Ricky Curtice
Re-utilized the technique Richard put in the corner drag code.
2014-03-03STORM-2017: Added translatable help text to rotation.Ricky Curtice
I chose the camera’s up vector to place the help text as it provided a consistent location on the screen for the user to see the text pop up. While doing this I realized that the calls to hud_render_utf8text utilized a condition that was guaranteed to be false based on a surrounding if-statement, and so could trivially be replaced with a constant. Also cleaned out a compiler warning about unused private member variables in llmaniptranslate. I don’t like warnings and useless code. :P
2014-03-03STORM-2017 Untranslatable text appears when scaling, or moving objectsJonathan Yap
2014-03-02Fixed compile-time errors. My bad.Ricky Curtice
Serves me right for not waiting through the compile!
2014-03-02Better code documentation.Ricky Curtice
2014-03-02STORM-1920: Corrected bug where snap values would highlight that weren’t ↵Ricky Curtice
supposed to be highlighting. Did some more cleanup and documentation. Also corrected a bug in Richard’s patch that resulted in the object scaling up when the mouse went the opposite direction from the scale. The issue is that the vector length is an absolute value. To allow for "negative" results to be found and discarded, I instead used a dot product with a parallel unit vector to get the signed magnitude - or, if you prefer, the mono-dimensional vector. This bug only surfaced once the code made to actually work as intended in regards to the highlighting. Turns out that if the snapped value was at 2, any axis that was showing values would highlight its "2" text - and the same for all other values. To fix this, I used a simple enum and repurposed the property that tracked whether or not the cursor was in a snap regime. Now it not only tracks whether or not the cursor is in a snap regime, but which one it is in. This allowed the highlight render code to be able to differentiate which row was supposed to highlight and which did not. A couple more duplicated math operations were reduced by rearranging the order of some variable definitions. If at all possible, only do division once. The result is much cleaner and easier to read code. Several deprecated vector functions were updated to match their new versions. If you are going to mark something deprecated, why not just take the time to go through and find all uses and clean it up!? faceToUnitVector() was cleaned up to use the single-output design, matching cornerToUnitVector(). A mess of trailing whitespace was cleaned out. Many more LLManipScale private variables are now documented - though I only documented those I understood fully while reading where they were created and how they were used.
2014-03-02STORM-1920: From Richard, fix for scale sliding when mouse goes in the ↵Ricky Curtice
opposite direction of the scale. I had discovered a set of bugs in the fix he sent me involving when the user decided to move the mouse in the opposite direction. This fixes the bug where the scale would start sliding around.
2014-03-02MergeRicky Curtice
2014-03-02STORM-1920: Richard fixed and optimized a ton more math.Ricky Curtice
From Richard: There are a bunch of things I changed...mainly I eliminated all the grid_offset nonsense and instead simply calculate the tick index for the current drag position and use that to generate a snapped position as needed. I still use approx_equal because I want grid numbers to light up even when they aren't the axis you are currently snapping to.
2014-02-24MAINT-2059 FIX Corner scaling doesn't highlight distance textRichard Linden
much cleanup of vector math also made Stretch Both Sides checkbox clickable via label
2014-02-22Simple variable cleanup.Ricky Curtice
There was a lot of repeated division that was obscuring meaning, along with a variable that was always identical to another preexisting variable. This last was probably an archaism, and was just due for removal.
2014-02-18STORM-1920: Documented the meaning of some of the variables involved, built ↵Ricky Curtice
simplest change to solve issue. The highlighting code assumed that the axis of the scaling movement was aligned with the scale tick marks - e.g. one of the cardinal directions with respect to the OBB of the selection. This was and is NOT true when dragging from the corner, aka scaling more than one axis at a time. The solution was to calculate the measured distance by projecting the snapped distance along the snap direction onto the axis of the relevant snap guide. This gives the correct values, and is nice and clean - both in the change involved, and in the values returned. However, while the fundamental misunderstanding in the code has been cleaned up by this change, the tick_val variable has so much jitter in the bottom end that the is_approx_equal function doesn’t come true > 98% of the time. This is the next problem to solve.
2014-02-18STORM-1920: Math cleanup from Richard Linden.Ricky Curtice
2014-02-13cleaned up llmanipscale logic for readability...no change in functionalityRichard Linden
2013-08-09second phase summer cleaningRichard Linden
replace llinfos, lldebugs, etc with new LL_INFOS(), LL_DEBUGS(), etc.
2013-07-30Summer cleaning - removed a lot of llcommon dependencies to speed up build timesRichard Linden
consolidated most indra-specific constants in llcommon under indra_constants.h fixed issues with operations on mixed unit types (implicit and explicit) made LL_INFOS() style macros variadic in order to subsume other logging methods such as ll_infos added optional tag output to error recorders
2013-06-05merge with viewer-releaseRichard Linden
2013-04-19merge changes for DRTVWR-294Oz Linden
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2013-03-18SH-3931 WIP Interesting: Add graphs to visualize scene load metricsRichard Linden
changed LLCriticalDamp to LLSmoothInterpolation and sped up interpolator lookup improvements to stats display of llstatbar added scene load stats floater accessed with ctrl|shift|2
2012-10-11Updating linux build to gcc4.6Don Kjer
2012-04-03PATH-450: Correcting boolean logic that was resulting in the scale ↵Todd Stinson
manipulator malfunctioning for non-permanent objects.
2012-03-30PATH-450: Disabling the movement and shape manipulation widgets when editing ↵Todd Stinson
an item in a linked set.
2012-03-13PATH-199: Enforcing permanent objects in frozen state to not move.Todd Stinson
2011-09-14SH-2243 work in progress -- application side matrix stack managementDave Parks
2011-06-09Remove ObjectAdd cap, no longer neededRoxie Linden
2011-06-07mergeDave Parks
2011-05-27transplant fix for SH-1467Roxie Linden
viewer now uses simulatorfeatures to check whether to show UI elements for mesh or not
2011-05-26SH-1668 FIXED Cubes can be scaled to 64^3Loren Shih
2011-05-02STORM-1210 fsqrtf cleanupDave Parks
2011-05-02mergeDave Parks
2011-03-12Switched to using *_SQUARED constants instead of multiplied constants, and ↵Ricky Curtice
cleaned up a few other minor issues noted during review.
2011-03-10Squared all dist_vec() based comparisons and other dist_vec() operations ↵Ricky Curtice
where sensible. Not all instances of dist_vec() were squared, only those where it wouldn't (hopefully) change the functionality.
2011-02-24SH-1045leyla_linden
Mesh Viewer temporarily allows object scaling larger than 10m, then moves the object
2011-02-16SH-512 [REGRESSION] Linden trees scale up to 200m on Mesh regionsleyla_linden
SH-943 10 meters maximum Prim/Mesh size in latest Mesh Viewers
2011-02-01SH-512: Inworld scale weights use previous maximum (10)prep linden
2011-01-28SH-808 making sure the 10m vs. 64m scale limit switch happens for both the ↵leyla_linden
spinner and the manipulation tools etc.
2010-10-13correct licenses (fix problem with license change merge)Oz Linden
2010-08-13Change license from GPL to LGPL (version 2.1)Oz Linden
2010-03-23EXT-2959 : Full out camera functions from llagent to llagentcameraLoren Shih
First check-in; only compiles, nothing more.
2010-01-28CID-361Tofu Linden
Checker: UNINIT_CTOR Function: LLToolGrab::LLToolGrab(LLToolComposite *) File: /indra/newview/lltoolgrab.cpp plus followup to previous fix...
2009-11-10Sanitize naming of getWindowRect (scaled vs. raw pixels) and ↵James Cook
getWorldViewRect (scaled vs. raw) Reduces chance of future UI bugs related to UI size. Discussed with Richard.
2009-11-10EXT-677 Build tool arrows work again with UI size != 1.0James Cook
Must use scaled (virtual) pixels in some computations Will review with Richard