summaryrefslogtreecommitdiff
path: root/indra/newview/lllogininstance.cpp
AgeCommit message (Collapse)Author
2020-03-25SL-11215: Add release notes URLs to update-related notifications.Nat Goodspeed
Add code to login-fail handler to provide release notes URL from SLVersionChecker handshake event.
2020-03-25SL-11216: Convert LLVersionInfo to an LLSingleton.Nat Goodspeed
This changeset is meant to exemplify how to convert a "namespace" class whose methods are static -- and whose data are module-static -- to an LLSingleton. LLVersionInfo has no initClass() or cleanupClass() methods, but the general idea is the same. * Derive the class from LLSingleton<T>: class LLSomeSingleton: public LLSingleton<LLSomeSingleton> { ... }; * Add LLSINGLETON(LLSomeSingleton); in the private section of the class. This usage implies a separate LLSomeSingleton::LLSomeSingleton() definition, as described in indra/llcommon/llsingleton.h. * Move module-scope data in the .cpp file to non-static class members. Change any sVariableName to mVariableName to avoid being outright misleading. * Make static class methods non-static. Remove '//static' comments from method definitions as needed. * For LLVersionInfo specifically, the 'const std::string&' return type was replaced with 'std::string'. Returning a reference to a static or a member, const or otherwise, is an anti-pattern: the interface constrains the implementation, prohibiting possibly later returning a temporary (an expression). * For LLVersionInfo specifically, 'const S32' return type was replaced with simple 'S32'. 'const' is just noise in that usage. * Simple member initialization (e.g. the original initializer expressions for static variables) can be done with member{ value } initializers (no examples here though). * Delete initClass() method. * LLSingleton's forté is of course lazy initialization. It might work to simply delete any calls to initClass(). But if there are side effects that must happen at that moment, replace LLSomeSingleton::initClass() with (void)LLSomeSingleton::instance(); * Most initClass() initialization can be done in the constructor, as would normally be the case. * Initialization that might cause a circular LLSingleton reference should be moved to initSingleton(). Override 'void initSingleton();' should be private. * For LLVersionInfo specifically, certain initialization that used to be lazily performed was made unconditional, due to its low cost. * For LLVersionInfo specifically, certain initialization involved calling methods that have become non-static. This was moved to initSingleton() because, in a constructor body, 'this' does not yet point to the enclosing class. * Delete cleanupClass() method. * There is already a generic LLSingletonBase::deleteAll() call in LLAppViewer::cleanup(). It might work to let this new LLSingleton be cleaned up with all the rest. But if there are side effects that must happen at that moment, replace LLSomeSingleton::cleanupClass() with LLSomeSingleton::deleteSingleton(). That said, much of the benefit of converting to LLSingleton is deleteAll()'s guarantee that cross-LLSingleton dependencies will be properly honored: we're trying to migrate the code base away from the present fragile manual cleanup sequence. * Most cleanupClass() cleanup can be done in the destructor, as would normally be the case. * Cleanup that might throw an exception should be moved to cleanupSingleton(). Override 'void cleanupSingleton();' should be private. * Within LLSomeSingleton methods, remove any existing LLSomeSingleton::methodName() qualification: simple methodName() is better. * In the rest of the code base, convert most LLSomeSingleton::methodName() references to LLSomeSingleton::instance().methodName(). (Prefer instance() to getInstance() because a reference does not admit the possibility of NULL.) * Of course, LLSomeSingleton::ENUM_VALUE can remain unchanged. In general, for many successive references to an LLSingleton instance, it can be useful to capture the instance() as in: auto& versionInfo{LLVersionInfo::instance()}; // ... versionInfo.getVersion() ... We did not do that here only to simplify the code review. The STRINGIZE(expression) macro encapsulates: std::ostringstream out; out << expression; return out.str(); We used that in a couple places. For LLVersionInfo specifically, lllogininstance_test.cpp used to dummy out a couple specific static methods. It's harder to dummy out LLSingleton::instance() references, so we add the real class to that test.
2019-04-02Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2019-03-01Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2019-03-01Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2019-01-29SL-2364 Fixed Viewer Caches Login Host DNS Entries Indefinetelyandreykproductengine
2018-10-04DRTVWR-474: Make login coroutine sync with updater process on failure.Nat Goodspeed
Specifically, introduce an LLEventMailDrop("LoginSync"). When the updater detects that an update is required, it will post to that rendezvous point. When login.cgi responds with login failure, make the login coroutine wait (a few seconds) for that ping from the updater. If we receive that ping and if it contains a "reply" key, make the fail.login listener respond to the updater with an indication of whether to proceed with update. If both login.cgi and the updater concur that an update is required, produce a new confirmation message for the user and then (once user responds) tell the updater to proceed. Otherwise, produce the usual login-failure message and tell the updater never mind. Introduce LLCoro::OverrideConsuming to provide temporary save/restore of the set_consuming() / get_consuming() flag. It's a good idea to set the consuming flag when retrieving data from an LLEventMailDrop.
2018-06-29Handle grids.xml w/ single entry instead of an array.Graham Linden
Fix crash when no login URIs are found for a given grid (does not happen after fixing above, but should not crash either).
2018-03-16MAINT-8372 Fixed doubled error messagesandreykproductengine
2017-10-12DRTVWR-418: Remove redundant assignment per Ansariel Hiller.Nat Goodspeed
2017-10-11Automated merge with ssh://bitbucket.org/lindenlab/viewer-releaseNat Goodspeed
2017-09-22MAINT-7827: suppress doubled notices on various login problemsOz Linden
2017-09-15additional logging to help with MAINT 7807Oz Linden
2017-08-23merge changes for MAINT-7594Oz Linden
2017-08-22MAINT-7594: add platform name string to login request (and add request ↵Oz Linden
parameter logging at DEBUG)
2017-08-14fix indentingOz Linden
2017-08-14MAINT-7640: code review fixesOz Linden
2017-08-14MAINT-7640: Notify the user if login is blocked for a required viewer updateOz Linden
2017-08-27Merged in oz_linden/viewer-maint-7594AndreyL ProductEngine
2017-08-24MAINT-7594: add platform name string and address size to login request for ↵Oz Linden
crash stats (and add request parameter logging at DEBUG)
2017-07-24MAINT-7495 Viewer retries too many time apon 504 from login.cgiandreykproductengine
2017-05-05pull from gatecoyot@coyot-sager-PC.hsd1.ca.comcast.net
2017-04-21DRTVWR-418: Send address_size with login and viewer stats.Nat Goodspeed
2016-08-19SL-323: put back mac addr hashGlenn Glazer
2016-08-18SL-323: first pass at ripping out old updaterGlenn Glazer
2015-11-10remove execute permission from many files that should not have itOz Linden
2015-01-23Make MandatoryUpdateMachine use LLLoginInstance's LLNotificationsInterface.Nat Goodspeed
LLLoginInstance has a test hook setNotificationsInterface(), used by lllogininstance_test.cpp to redirect notifications through a dummy LLNotificationsInterface implementation. Certain of LLLoginInstance's MandatoryUpdateMachine state classes need to post notifications too; but until now they directly called LLNotificationsUtil::add(). In the production viewer, this should (!) be the same as calling through LLLoginInstance::mNotifications -- but it broke two of the LLLoginInstance unit tests, so they were skipped. Since MandatoryUpdateMachine's constructor is already passed the invoking LLLoginInstance&, make it store the reference. Add MandatoryUpdateMachine:: getNotificationsInterface(), which forwards to new LLLoginInstance:: getNotificationsInterface(). Change LLNotificationsUtil::add() calls in MandatoryUpdateMachine state classes to call through mMachine's getNotificationInterface() instead. This allows us to remove #include "llnotificationsutil.h" from lllogininstance.cpp, also that #include plus stub LLNotificationsUtil::add() implementation from lllogininstance_test.cpp. Finally, it allows us to remove the skip() calls from the two unit tests.
2014-10-19Update to build on Xcode 6.0: removal on unused variable(s) need more ↵callum_linden
thought from Nat
2013-08-09second phase summer cleaningRichard Linden
replace llinfos, lldebugs, etc with new LL_INFOS(), LL_DEBUGS(), etc.
2013-05-30NORSPEC-158 fix issues with loading of bumpmaps on clean installGraham Madarasz
2013-05-30BUG-2707 add some logging to help narrow down what part of login instance ↵Graham Madarasz
handling is going awry
2013-04-19merge up to latest viewer-development for merge to 3.5.2Oz Linden
2013-04-02Add reporting of last_exec_durationOz Linden
(and clean up logic around multiple instances)
2013-03-29Update Mac and Windows breakpad builds to latestGraham Madarasz
2013-03-27change login to pass only the version instead of channel+version in the ↵Oz Linden
version parameter (channel is passed separately)
2013-03-27add platform and platform version to login request parameters for new ↵Oz Linden
version manager query
2013-02-27finish changes to update handling, including notices of channel changesOz Linden
2013-02-21add use of v1.1 update request protocol, with fallback to v1.0Oz Linden
2011-09-20EXP-1230 FIX As a resident, I want to not have to choose a UI modeRichard Linden
removed all references to basic mode
2011-08-26disabled basic inventory root creationRichard Nelson
reviewed by Stone
2011-08-10CHOP-757 Ask for the inventory-basic login option and dump its return id to ↵Aaron Stone
llinfo.
2011-05-11WIP: viewer side of ER-864: Include message ids and args in login.cgi responsesJoshua Bell
* Look for message_id and message_args in XMLRPC response, look up localized string in strings.xml * Support sub-maps in XMLRPC response conversion to LLSD * Explicitly request extended error info during login (since including sub-maps breaks older viewers) * Support LLSD-based substitutions in LLTrans::getString/findString
2011-04-15EXP-679 As a linden executive, I would like to evaluate the success of basic ↵Leyla Farazha
mode against various metrics
2011-01-28Extend LLEventAPI to directly call other functions & methods.Nat Goodspeed
Until now, LLEventAPI has only been able to register functions specifically accepting(const LLSD&). Typically you add a wrapper method to your LLEventAPI subclass, register that, have it extract desired params from the incoming LLSD and then call the actual function of interest. With help from Alain, added new LLEventAPI::add() methods capable of registering functions/methods with arbitrary parameter signatures. The code uses boost::fusion magic to implicitly match incoming LLSD arguments to the function's formal parameter list, bypassing the need for an explicit helper method. New add() methods caused an ambiguity with a previous convenience overload. Removed that overload and fixed the one existing usage. Replaced LLEventDispatcher::get() with try_call() -- it's no longer easy to return a Callable for caller to call directly. But the one known use of that feature simply used it to avoid fatal LL_ERRS on unknown function-name string, hence the try_call() approach actually addresses that case more directly. Added indra/common/lleventdispatcher_test.cpp to exercise new functionality.
2011-01-20merge changes from viewer-betaOz Linden
2011-01-14fix CHOP-366, on temporary errors (e.g. version manager returns other than ↵Andrew A. de Laix
200) show error dialog instructing the user to manually install the latest viewer.
2011-01-13VWR-24401 Show TOS and other login dialogs when --login is usedJoshua Bell
2010-12-21Merge from trunkAndrew A. de Laix
2010-12-10destroy updater state machine if login instance destroyed.Andrew A. de Laix
2010-12-10ui improvements to more closely match UX design.Andrew A. de Laix