summaryrefslogtreecommitdiff
path: root/indra/newview/lllogininstance.cpp
AgeCommit message (Collapse)Author
2023-09-15SL-20278 Disconnect saving MFA from saving passwordAndrey Kleshchev
2022-10-31Fix SL-18511 TOS and MFA login failure handlers must cooperate to answer ↵Brad Kittenbrink
both reasons at the same time
2022-06-08SL-17546 Fix 'release' configuration build testsAndrey Kleshchev
2022-06-07SL-17546 Do not launch updater for a non-interactible instanceAndrey Kleshchev
2022-04-18Merge remote-tracking branch 'origin/master' into DRTVWR-550-mfaBrad Kittenbrink
2022-03-29SL-16831 Viewer stalls for 10 seconds before displaying a login failureAndrey Kleshchev
# Conflicts: # indra/newview/llstartup.cpp
2022-03-18Fix SL-17034/BUG-231938 whitespace in token causes authentication failureBrad Kittenbrink
2022-03-17SL-17019 mfa_hash should get saved per-usernameBrad Kittenbrink
2022-03-09SL-16888 debug setting MFAHash value now gets saved to mfa_hash secure ↵Brad Kittenbrink
storage as well.
2022-03-01SL-16953 Deprecated NoInventoryLibraryAndrey Kleshchev
Due to changes in SL-16715
2022-02-04Related to fix for SL-16792, standardize on naming the filed simply mfa_hash ↵Brad Kittenbrink
end-to-end to avoid confusion
2022-01-14SL-16654 simplify MFA token prompt UI to use notifications instead of new ↵Brad Kittenbrink
custom floater.
2022-01-14SL-16514 store mfa hash in protected data using LLSecAPIBasicHandlerBrad Kittenbrink
2021-12-14SL-16388 Viewer MFA fix Duplicate Listener crash when first token challenge ↵Brad Kittenbrink
failed also cleaned up some xui warnings
2021-12-13SL-16501 SLMFAHash is now saved client sideBrad Kittenbrink
2021-12-06SL-16388 Viewer MFA Implementation ImprovementsBrad Kittenbrink
token input is now handled and message formatting is improved. Added beginnings of support for saving slmfa_hash value client side.
2021-11-23SL-16388 Viewer MFA ImplementationBrad Kittenbrink
We now present MFA errors to the user during login and prompt them for an authentication token.
2021-11-23SL-16365 Viewer adds empty mfa token to login paramsBrad Kittenbrink
2021-02-10SL-11215 Release notes url should be an urlAndrey Kleshchev
2021-02-01Merge branch 'master' of https://bitbucket.org/lindenlab/viewer/src/master ↵Andrey Kleshchev
into DRTVWR-515-maint # Conflicts: # autobuild.xml (llca) # indra/llwindow/llwindow.h (SL-13507 vs SL-5894) # indra/newview/llscenemonitor.cpp (SL-14422) # indra/newview/llvovolume.cpp (SL-12069)
2020-11-23SL-14386 FIXED Crash: LLLoginInstance::~LLLoginInstance()Mnikolenko Productengine
2020-11-06Reapplied SL-11215: Add release notes URLs to update-related notifications.Andrey Kleshchev
In scope of SL-13740 work, this reverts commit 1935d25c78bf46f0fdc8758b6f215f53d17fd94a.
2020-08-06Revert "SL-11215: Add release notes URLs to update-related notifications."Andrey Kleshchev
This reverts commit bf999f2f84dd26844c60d682f563f982a55e8ee8 due to revert of updater, this will be moved to separate 'epic' instead
2020-05-06DRTVWR-476: Merge branch 'master' of lindenlab/viewer into DRTVWR-476-boost-1.72Nat Goodspeed
2020-03-25SL-11215: Add release notes URLs to update-related notifications.Nat Goodspeed
Add code to login-fail handler to provide release notes URL from SLVersionChecker handshake event.
2020-03-25SL-11216: Convert LLVersionInfo to an LLSingleton.Nat Goodspeed
This changeset is meant to exemplify how to convert a "namespace" class whose methods are static -- and whose data are module-static -- to an LLSingleton. LLVersionInfo has no initClass() or cleanupClass() methods, but the general idea is the same. * Derive the class from LLSingleton<T>: class LLSomeSingleton: public LLSingleton<LLSomeSingleton> { ... }; * Add LLSINGLETON(LLSomeSingleton); in the private section of the class. This usage implies a separate LLSomeSingleton::LLSomeSingleton() definition, as described in indra/llcommon/llsingleton.h. * Move module-scope data in the .cpp file to non-static class members. Change any sVariableName to mVariableName to avoid being outright misleading. * Make static class methods non-static. Remove '//static' comments from method definitions as needed. * For LLVersionInfo specifically, the 'const std::string&' return type was replaced with 'std::string'. Returning a reference to a static or a member, const or otherwise, is an anti-pattern: the interface constrains the implementation, prohibiting possibly later returning a temporary (an expression). * For LLVersionInfo specifically, 'const S32' return type was replaced with simple 'S32'. 'const' is just noise in that usage. * Simple member initialization (e.g. the original initializer expressions for static variables) can be done with member{ value } initializers (no examples here though). * Delete initClass() method. * LLSingleton's forté is of course lazy initialization. It might work to simply delete any calls to initClass(). But if there are side effects that must happen at that moment, replace LLSomeSingleton::initClass() with (void)LLSomeSingleton::instance(); * Most initClass() initialization can be done in the constructor, as would normally be the case. * Initialization that might cause a circular LLSingleton reference should be moved to initSingleton(). Override 'void initSingleton();' should be private. * For LLVersionInfo specifically, certain initialization that used to be lazily performed was made unconditional, due to its low cost. * For LLVersionInfo specifically, certain initialization involved calling methods that have become non-static. This was moved to initSingleton() because, in a constructor body, 'this' does not yet point to the enclosing class. * Delete cleanupClass() method. * There is already a generic LLSingletonBase::deleteAll() call in LLAppViewer::cleanup(). It might work to let this new LLSingleton be cleaned up with all the rest. But if there are side effects that must happen at that moment, replace LLSomeSingleton::cleanupClass() with LLSomeSingleton::deleteSingleton(). That said, much of the benefit of converting to LLSingleton is deleteAll()'s guarantee that cross-LLSingleton dependencies will be properly honored: we're trying to migrate the code base away from the present fragile manual cleanup sequence. * Most cleanupClass() cleanup can be done in the destructor, as would normally be the case. * Cleanup that might throw an exception should be moved to cleanupSingleton(). Override 'void cleanupSingleton();' should be private. * Within LLSomeSingleton methods, remove any existing LLSomeSingleton::methodName() qualification: simple methodName() is better. * In the rest of the code base, convert most LLSomeSingleton::methodName() references to LLSomeSingleton::instance().methodName(). (Prefer instance() to getInstance() because a reference does not admit the possibility of NULL.) * Of course, LLSomeSingleton::ENUM_VALUE can remain unchanged. In general, for many successive references to an LLSingleton instance, it can be useful to capture the instance() as in: auto& versionInfo{LLVersionInfo::instance()}; // ... versionInfo.getVersion() ... We did not do that here only to simplify the code review. The STRINGIZE(expression) macro encapsulates: std::ostringstream out; out << expression; return out.str(); We used that in a couple places. For LLVersionInfo specifically, lllogininstance_test.cpp used to dummy out a couple specific static methods. It's harder to dummy out LLSingleton::instance() references, so we add the real class to that test.
2020-02-21SL-12678 Remove automatic retry of loginAndrey Kleshchev
2020-02-12SL-12678 Remove automatic retry of loginAndrey Kleshchev
2019-04-02Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2019-03-01Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2019-03-01Merged in lindenlab/viewer-releaseAndreyL ProductEngine
2019-01-29SL-2364 Fixed Viewer Caches Login Host DNS Entries Indefinetelyandreykproductengine
2018-10-04DRTVWR-474: Make login coroutine sync with updater process on failure.Nat Goodspeed
Specifically, introduce an LLEventMailDrop("LoginSync"). When the updater detects that an update is required, it will post to that rendezvous point. When login.cgi responds with login failure, make the login coroutine wait (a few seconds) for that ping from the updater. If we receive that ping and if it contains a "reply" key, make the fail.login listener respond to the updater with an indication of whether to proceed with update. If both login.cgi and the updater concur that an update is required, produce a new confirmation message for the user and then (once user responds) tell the updater to proceed. Otherwise, produce the usual login-failure message and tell the updater never mind. Introduce LLCoro::OverrideConsuming to provide temporary save/restore of the set_consuming() / get_consuming() flag. It's a good idea to set the consuming flag when retrieving data from an LLEventMailDrop.
2018-06-29Handle grids.xml w/ single entry instead of an array.Graham Linden
Fix crash when no login URIs are found for a given grid (does not happen after fixing above, but should not crash either).
2018-03-16MAINT-8372 Fixed doubled error messagesandreykproductengine
2017-10-12DRTVWR-418: Remove redundant assignment per Ansariel Hiller.Nat Goodspeed
2017-10-11Automated merge with ssh://bitbucket.org/lindenlab/viewer-releaseNat Goodspeed
2019-04-02Merged in lindenlab/viewer-bearAndreyL ProductEngine
2017-09-22MAINT-7827: suppress doubled notices on various login problemsOz Linden
2017-09-15additional logging to help with MAINT 7807Oz Linden
2017-08-23merge changes for MAINT-7594Oz Linden
2017-08-22MAINT-7594: add platform name string to login request (and add request ↵Oz Linden
parameter logging at DEBUG)
2017-08-14fix indentingOz Linden
2017-08-14MAINT-7640: code review fixesOz Linden
2017-08-14MAINT-7640: Notify the user if login is blocked for a required viewer updateOz Linden
2017-08-27Merged in oz_linden/viewer-maint-7594AndreyL ProductEngine
2017-08-24MAINT-7594: add platform name string and address size to login request for ↵Oz Linden
crash stats (and add request parameter logging at DEBUG)
2017-07-24MAINT-7495 Viewer retries too many time apon 504 from login.cgiandreykproductengine
2017-05-05pull from gatecoyot@coyot-sager-PC.hsd1.ca.comcast.net
2017-04-21DRTVWR-418: Send address_size with login and viewer stats.Nat Goodspeed