Age | Commit message (Collapse) | Author |
|
|
|
to My Inventory->Current Outfit folder.
|
|
Current Outfit.
|
|
restricted to landmarks and folders containing landmarks.
This changes affect all folder views. The previous fix affecting only My Landmarks SP (changeset 330d0e96d58d) was reverted.
|
|
|
|
|
|
|
|
|
|
|
|
Better handling of invalid attachment points.
You can now detach points that are incompatible with your viewer, versus having those permanently in the COF>
|
|
/Users/Aimee/Documents/Work/Linden-Lab/Development/viewer/convert/viewer-identity-evolution
|
|
|
|
Superficial code cleanup of RezAttachment messaging.
|
|
Single attachment request are now batched up and sent all at once as a single message.
|
|
- Disabled moving items from in-world objects to COF or outfit folders not to create copies of items instead of links.
- Enabled dropping a landmark from Library to certain position in Favorites folder which supports items reordering.
|
|
inventory context menu for incomplete outfits.
|
|
back-out the back-out for this branch. yay.
|
|
Backing out this merge that I pushed (prematurely) to the wrong place.
|
|
|
|
|
|
--HG--
branch : product-engine
|
|
|
|
|
|
I couldn't reproduce this problem, but from what I've seen in the crash
reporter, this is a very old bug affecting viewers 1.2x and 2.x.
When user tries to rename an incomplete inventory item, viewer crashes.
The fix is to disallow renaming incomplete items.
Reviewed by Seraph at https://codereview.productengine.com/secondlife/r/857/
--HG--
branch : product-engine
|
|
* EXT-8688 Automatically detach same object is detected
* EXT-8689 Cleanup detachAttachmentIntoInventory code
When an object arrives as an attachment, if it's already attached then it's automatically detached.
|
|
|
|
The crash was reproducible only on startup. Apparently, gAgentAvatarp was not valid at that point.
Worked around by checking gAgentAvatarp for being valid.
I didn't investigate what the root cause of the problem was (probably the new multi-attachments implementation), I just needed my viewer to work.
Reviewed by Seraph at https://codereview.productengine.com/secondlife/r/847/.
--HG--
branch : product-engine
|
|
The crash was reproducible only on startup. Apparently, gAgentAvatarp was not valid at that point.
Worked around by checking gAgentAvatarp for being valid.
I didn't investigate what the root cause of the problem was (probably the new multi-attachments implementation), I just needed my viewer to work.
Reviewed by Seraph at https://codereview.productengine.com/secondlife/r/847/
--HG--
branch : product-engine
|
|
Done:
- 1. Dropped the obsolete "MultipleAttachments" setting.
- 2. Added an "Add" item to the following attachment-related context menus:
* My Appearance (ex-My Outfits) context menu.
* Edit Outfit -> Add More context menu.
* Object in-world context menu.
* Inventory context menu.
* Object inspector gear menu.
- 3. Modified "Attach To / Attach To HUD" to perform the "add" instead of "replace" action.
TODO:
- Ability to attach multiple objects at once from the Add More panel (bulk attach).
- Make sure there's no memleak when you click Wear/Attach in the in-world object context menu
and the callback isn't invoked (because e.g. avatar fails to get close enough to the object).
Issues:
0. I'm not sure whether LLAgentWearables::userAttachMultipleAttachments()
should replace attachments or add them. Assumed the former.
1. I couldn't verify that adding objects from the object inspector menu works
because I either could wear an object or see its inspector, not both.
2. > 1. Right-click on an object in your inventory and select "Wear".
> VERIFY: Attaches the object and replaces whatever's there; asks for
> confirmation before replacing an existing object.
I think this is impossible to implement because we don't know in advance
what point the object will be attached to, so we can't display a confirmation dialog.
Reviewed by Seraph at https://codereview.productengine.com/secondlife/r/843/
--HG--
branch : product-engine
|
|
|
|
Library items have "Share" disabled.
|
|
for it in right-click menus
Changed logic so that the menu is post-processed and, at that time, nooptions is added if the menu is seen to be empty.
|
|
and Trash folder options incorrect
Minor fix to previous checkin for this crash. This fixes the UI issue where you're seeing the context options for the previous folder you clicked when you click on trash/library.
|
|
|
|
reviewed by Callum
|
|
"Attach To..." menus (AE and inventory).
There is an on_enable callback set for the menu items. It tries adding a suffix like "(obj_name)" if there is already an attachment on the attachment point.
No matter whether the suffix has been actually added, the callback resets the menu item label to its parameter (cbparams["label"]).
The problem was that we passed the original English attachment point name to the callback, that set it as the menu item name, thus screwing up translation.
The fix is to pass translated attachment point name to the on_enable callback.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/768/
--HG--
branch : product-engine
|
|
|
|
right-click
EXT-8261 FIXED 'Share' item is disabled in 'My Inventory' folder's context menu
Items can now be appended to menus (versus menus being the most restrictive out of all the item choices).
|
|
EXT-8139 FIXED "Copy and wear" when unboxing an outfit defaults to "add" instead of "replace items"
Copy&Wear now takes off all inventory item before wearing new outfit.
|
|
LLAppearanceMgr::wearItemOnAvatar() method while DnD a wearable to COF.
Reviewed by Vadim Savchuk and Neal Orman at https://codereview.productengine.com/secondlife/r/714/
--HG--
branch : product-engine
|
|
|
|
Fixed logic to disallow folders from being dragged into outfits.
Also added a bunch of low-risk superficial cleanup such as comments, better local variable declaration, etc.
|
|
|
|
the Inventory
Fixed the dnd behavior so that you can only drag appropriate items into the COF or Outfits folder.
Did a bit of superficial code cleanup in terms of adding comments and relocating blocks of code. The actual coding fix was pretty small despite the diff; most of the diff is superficial cleanup.
|
|
Removed checking for wearables loaded on replacing or adding individual items.
After reviewing the code in depth, we believe this is safe to do,
particularly since we allow the user to replace their outfit from the same state.
Filed a followup issue for later investigation EXT-8231
Code reviewed by Vir and Seraph
|
|
Only adding "--no options--" when right-click context menu is empty. Normal priority bug but rather annoying visually.
|
|
|
|
right-click context menus
EXT-8093 FIXED No "open" or "properties" items for gestures
Re-added open/properties to gestures
Fixed right-click inventory selection so that it does something logical & consistent for multiple items. Had to add a "getLastVisible" to LLView to support this.
|
|
This #ifdef is now keyed to MultipleAttachments debug setting
|
|
|